< MarcoFalke>
#proposedmeetingtopic Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak?
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16571: gui: Make Bitcoin Core logo pure black (master...1908-guiIcoPureBlack) https://github.com/bitcoin/bitcoin/pull/16571
< bitcoin-git>
[bitcoin] davereikher opened pull request #16570: Make descriptor tests deterministic (master...make_descriptor_tests_deterministic) https://github.com/bitcoin/bitcoin/pull/16570
< jonasschnelli>
Unfortunate that our current ChaCha20Poly1305@Bitcoin implementation works on a single buffer.
< belcher>
setpill this is a question more for #bitcoin than here, but try running `bitcoin-cli stop`
< setpill>
belcher: it's related to the default systemd service file of bitcoin core not shutting it down cleanly when using `systemctl stop bitcoind.service`
< wumpus>
dongcarl: maybe this could be part of the https://github.com/bitcoin/bips/pull/766#issuecomment-517003833 sendaddrv2 message here to notify peers of addrv2 support (which was poroposed as alternative to the protocol version bump the BIP currently documents)
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< bitcoin-git>
[bitcoin] Sjors opened pull request #16555: [doc] mention whitelist is inbound, and applies to blocksonly (master...2019/08/doc-whitelistrelay) https://github.com/bitcoin/bitcoin/pull/16555
< bitcoin-git>
[bitcoin] fanquake opened pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16551: test: Test that low difficulty chain fork is rejected (master...1908-testDosLowHeader) https://github.com/bitcoin/bitcoin/pull/16551
< bitcoin-git>
[bitcoin] Sjors opened pull request #16549: [WIP] UI external signer support (e.g. hardware wallet) (master...2019/08/hww-qt) https://github.com/bitcoin/bitcoin/pull/16549
< bitcoin-git>
[bitcoin] mmachicao opened pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
< bitcoin-git>
bitcoin/master fa8489a MarcoFalke: test: Add test for BIP30 duplicate tx
< bitcoin-git>
bitcoin/master 62117f9 MarcoFalke: Merge #16363: test: Add test for BIP30 duplicate tx
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git>
[bitcoin] Sjors opened pull request #16546: [WIP] External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #16545: Implement missing error checking for ArgsManager flags (master...pr/argcheck) https://github.com/bitcoin/bitcoin/pull/16545
< bitcoin-git>
[bitcoin] fanquake closed pull request #16138: Scripts and tools: Add sudoers.d, rc.local from docs to gitian script (master...gitian-automated-sudoers-br0) https://github.com/bitcoin/bitcoin/pull/16138
< bitcoin-git>
[bitcoin] fanquake closed pull request #13612: Qt: Only call tryGetBalances in pollBalanceChanged if the result will be used. (master...bitcoin) https://github.com/bitcoin/bitcoin/pull/13612
< elichai2>
emilengler: yp need to add `-S` to everyt git command you run that modifies the commits. but an easier way to do this is just run `git config commit.gpgsign true` in your bitcoin dir which will force your git to sign every commit you make in that repo
< emilengler>
Hope it's ok to ask this question here, because I need it for Bitcoin Core development. How can I sign a commit which include squashed commits. Everytime I squash commits the "parent" commit is unsigned
< bitcoin-git>
[bitcoin] mmachicao closed pull request #15137: Tests: Contract test for CCoinsView and CCoinsViewBacked (master...coins_contract_tests) https://github.com/bitcoin/bitcoin/pull/15137
< emilengler>
Same with Bitcoin Core and FreeBSD for example
< achow101>
fun fact, bitcoin 0.1 was released before Windows 7
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< elichai2>
yeah, but then I can import a desc and try to sign with it. but I guess i'm trying to do too much, for now i'll test manually and concentrate on adding more tests for the desc and then either ask someone to give my code a quick look (I am pretty new to bitcoin core's code and to c++) or look into PSBT/signing, but only after i'm 100% done with the desc
2019-08-02
< bitcoin-git>
[bitcoin] achow101 opened pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
< bitcoin-git>
[bitcoin] emilengler opened pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] ariard opened pull request #16536: [doc] Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
< bitcoin-git>
bitcoin/master 9ed062b Sjors Provoost: [doc] rpc: remove "fallback to" from RBF default help
< bitcoin-git>
bitcoin/master d6b3640 Sjors Provoost: [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< emilengler>
Is there a cmake file for bitcoin core?
2019-08-01
< bitcoin-git>
[bitcoin] jtimon opened pull request #16527: Get rid of Params().RequireStandard() (master...b19-chainparams-no-requirestd) https://github.com/bitcoin/bitcoin/pull/16527
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16525
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #16513: [RFC] Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
< bitcoin-git>
[bitcoin] jtimon opened pull request #16524: Truly decouple wallet from chainparams for -fallbackfee (master...b19-true-wallet-no-chainparams) https://github.com/bitcoin/bitcoin/pull/16524
< bitcoin-git>
[bitcoin] metalicjames opened pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] Remagpie opened pull request #16521: wallet/rpc: Use the default maxfeerate value as BTC/kB (master...maxfeerate-as-rate) https://github.com/bitcoin/bitcoin/pull/16521
< jonasschnelli>
If someone wants to pickup my. topic (bitcoin-dev mailing list moderation), feel free
< bitcoin-git>
[bitcoin] dongcarl opened pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519
< emilengler>
And where is the config file initial be loaded? In src/qt/bitcoin.cpp or src/qt/intro.cpp
< bitcoin-git>
[bitcoin] hebasto closed pull request #16476: Use ArgsManager::ALLOW_STRING flag explicitly in simple cases (master...20190727-pr16097-new-flags) https://github.com/bitcoin/bitcoin/pull/16476
< bitcoin-git>
[bitcoin] laanwj merged pull request #16277: [Tests] Suppress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277
< fanquake>
wumpus: yep QT_RCC_SOURCE_DATE_OVERRIDE fixed the issues with bitcoin-qt 🤦
< coinmonks>
I am online if anyone have any feedback,,or they can just leave private notes on the post itself.. thank you every one for contributing on Bitcoin.. :]
< bitcoin-git>
[bitcoin] meshcollider merged pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git>
bitcoin/master c5d3787 Andrew Chow: Allow createwallet to take empty passwords to make unencrypted wallets
< bitcoin-git>
bitcoin/master 6841b01 MeshCollider: Merge #16394: Allow createwallet to take empty passwords to make unencrypt...
< wumpus>
no, not using --prefix at the moment, I see a diffrence too between the same commits though, in bitcoin-qt but not bitcoind
< fanquake>
I've just done master (b7fbf74b980ebb122ae34b142f2cc49b44b92de3) and a dummy commit, still seeing the same difference in bitcoin-qt.
< wumpus>
i don't think i've ever used build-for-compare with bitcoin-qt, at all
< fanquake>
Doing a binary comparison of a bitcoin-qt built from HEAD~1 and HEAD~2, building on Debian using depends. Currently seeing this diff: https://gist.github.com/fanquake/653bb42176d7772578db08a0f8e60f11 . Any suggestions as to what could be causing the difference? bitcoind matches.
< bitcoin-git>
[bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
< bitcoin-git>
bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
< bitcoin-git>
bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
< bitcoin-git>
bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git>
[bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git>
[bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
< emilengler>
wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
< bitcoin-git>
[bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500