<bitcoin-git>
bitcoin/master 5b8f248 fanquake: lint: remove no-longer used exceptions from lint-format-strings.py
2022-02-22
<bitcoin-git>
[bitcoin] jonatack opened pull request #24424: doc: release process chainparams updates (master...release-process-chainparams-updates) https://github.com/bitcoin/bitcoin/pull/24424
<bitcoin-git>
[gui] luke-jr opened pull request #557: Revert "qt: Do not use QObject::tr plural syntax for numbers with a unit symbol" (master...gui_numeric_GBs) https://github.com/bitcoin-core/gui/pull/557
<willcl_ark>
What purpose exactly does the `CTransactionRef` serve? e.g. when processing incoming transactions in https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L3289 In the subsequent lines we seem to use a combination of `tx` and `ptx` for various operations and I don't see what the distinction is.
<bitcoin-git>
[bitcoin] laanwj opened pull request #24417: net: Update hardcoded seeds for 23.x (master...2022-02-hardcoded-seeds-update) https://github.com/bitcoin/bitcoin/pull/24417
<laanwj>
provoostenator: anecdotally i've also noticed bitcoin core estimates fees on the low side recently for transactions it makes, haven't encountered not meeting the minrelayfee though
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
<bitcoin-git>
[bitcoin] dongcarl opened pull request #24410: [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` (master...2022-02-libbitcoinkernel-p2-coinstats-minimal) https://github.com/bitcoin/bitcoin/pull/24410
<bitcoin-git>
[bitcoin] fanquake opened pull request #24409: Always output license/copyright info with `-version` (master...24263_followups) https://github.com/bitcoin/bitcoin/pull/24409
<bitcoin-git>
[bitcoin] vasild opened pull request #24407: fees: make the class FeeFilterRounder thread-safe (master...FeeFilterRounder_thread_safe) https://github.com/bitcoin/bitcoin/pull/24407
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24370: rpc, cli: describe quality/recency filtering in getnodeaddresses and -addrinfo (master...mention-quality-filter-in-getnodeaddresses-and-addrinfo) https://github.com/bitcoin/bitcoin/pull/24370
<bitcoin-git>
bitcoin/master fa27745 MarcoFalke: ci: Bump fuzz tasks to jammy
<bitcoin-git>
bitcoin/master fab8cd5 MarcoFalke: Revert "ci: Run fuzzer task for the master branch only"
<bitcoin-git>
bitcoin/master 2ab4fbe fanquake: Merge bitcoin/bitcoin#24292: Revert "ci: Run fuzzer task for the master br...
<hebasto>
provoostenator: nice to see https://github.com/bitcoin-core/gui/pull/555 -- it's very similar to my approach I'm currently working on. The only concern is we are past "string freeze" point -- hope no new and changed strings, although, did not check yet
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24339: rpc: Improve RPC help by explicitly mentioning output types (master...feature/2022-02-output-types) https://github.com/bitcoin/bitcoin/pull/24339
<bitcoin-git>
bitcoin/master 1337b93 MarcoFalke: Merge bitcoin/bitcoin#24339: rpc: Improve RPC help by explicitly mentionin...
<bitcoin-git>
bitcoin/master fa56c79 MarcoFalke: Make CDataStream work properly on 64-bit systems
<bitcoin-git>
bitcoin/master fa1b89a MarcoFalke: scripted-diff: Rename nReadPos to m_read_pos in streams.h
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24296: ci: use Ubuntu Jammy for Windows cross-compilation CI (master...win_ci_gcc_10_3) https://github.com/bitcoin/bitcoin/pull/24296
<bitcoin-git>
[gui] jonatack opened pull request #554: Add and improve peers tab address fields dev notes and tooltips (master...improve-peers-tab-address-fields-extracomments-and-tooltips) https://github.com/bitcoin-core/gui/pull/554
<bitcoin-git>
[bitcoin] hebasto opened pull request #24401: wallet: Add external-signer-support specific error message (master...220220-signer) https://github.com/bitcoin/bitcoin/pull/24401
<bitcoin-git>
[bitcoin] fanquake opened pull request #24385: build: remove boost dep from libmultiprocess (master...boost_less_multiprocess) https://github.com/bitcoin/bitcoin/pull/24385
<bitcoin-git>
[bitcoin] vasild opened pull request #24378: refactor: make bind() and listen() mockatble/testable (master...mockable_bind_and_listen) https://github.com/bitcoin/bitcoin/pull/24378
<laanwj>
re: rpc bindings in bitcoin core, the sentiment seems to be 'no', that there is a percieved need for something to be 'well-maintained' doesn't mean it needs to end up on the plate of the maintainers of bitcoin core, see also the discussion in #23468 (and that's about Python, not some language)
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24360: doc: improve -netinfo help based on feedback from users and devs (master...netinfo-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24360
<bitcoin-git>
bitcoin/master a4da16f Jon Atack: Improve -netinfo help based on feedback from users and devs
<jeremyrubin>
i think this is bitcoin-core specific, but are there any well maintained bitcoin core RPC libraries for javascript/typescript?
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #24375: Do not use `LocalTestingSetup` in getarg_tests test file. (master...pr/fixt) https://github.com/bitcoin/bitcoin/pull/24375
2022-02-17
<bitcoin-git>
[bitcoin] achow101 merged pull request #24281: docs: Update to match new default wallet type (master...doc-fix-default-wallet) https://github.com/bitcoin/bitcoin/pull/24281
<bitcoin-git>
bitcoin/master 3a618c1 Andrew Chow: Merge bitcoin/bitcoin#24281: docs: Update to match new default wallet type...
<luke-jr>
might be nice to investigate a disappeared-Bitcoin system and see if the logs say why
<hebasto>
for now we have multiple claims that macos removes Bitcoin Core; assuming it could be related to lack of notarization
<fanquake>
users are reporting their bitcoin core apps just flat out disappearing
<gribble>
https://github.com/bitcoin/bitcoin/issues/24365 | wallet: Dont generate keys for wallets with private keys disabled during upgradewallet by achow101 · Pull Request #24365 · bitcoin/bitcoin · GitHub
<bitcoin-git>
bitcoin/master 7f2f35f Hennadii Stepanov: build: Fix gcc-cross-x86_64-w64-mingw32-10.3.0 in Guix
<bitcoin-git>
bitcoin/master b3617a9 Hennadii Stepanov: build: Point Guix to recent commit on the master branch
<bitcoin-git>
bitcoin/master 9761192 fanquake: Merge bitcoin/bitcoin#24348: build: Fix Guix build for Windows (attempt 2)...
<jonatack>
laanwj: wrt 23542, potential privacy gain but if many DNS seeds take advantage of it before the seeder and bitcoin core code reading them are updated... be good to have those updated before this release (or the next one)
<bitcoin-git>
[bitcoin] achow101 opened pull request #24365: wallet: Don't generate keys for wallets with private keys disabled during upgradewallet (master...upgrade-disable-privkeys) https://github.com/bitcoin/bitcoin/pull/24365
<bitcoin-git>
[bitcoin] jamesob opened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364
2022-02-16
<bitcoin-git>
[bitcoin] hebasto opened pull request #24363: ci: Catch assertion error message into logs for test_bitcoin.exe (master...220216-assert) https://github.com/bitcoin/bitcoin/pull/24363
<bitcoin-git>
[bitcoin] achow101 opened pull request #24362: wallet: Do not match legacy addresses for change type (master...rm-legacy-change) https://github.com/bitcoin/bitcoin/pull/24362
<bitcoin-git>
[bitcoin] dongcarl closed pull request #24332: [kernel 2/n] Decouple from `netaddress`+`asmap`, parts of `timedata`+`init/common` (master...2022-02-libbitcoinkernel-p2-minimal) https://github.com/bitcoin/bitcoin/pull/24332
<bitcoin-git>
[bitcoin] jonatack opened pull request #24360: doc: improve -netinfo help based on feedback from users and devs (master...netinfo-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24360
<bitcoin-git>
[bitcoin] vasild opened pull request #24357: refactor: make setsockopt() and SetSocketNoDelay() mockable/testable (master...mockable_SetSocketNoDelay_and_setsockopt) https://github.com/bitcoin/bitcoin/pull/24357
<bitcoin-git>
[bitcoin] vasild opened pull request #24356: refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany() (master...WaitMany) https://github.com/bitcoin/bitcoin/pull/24356
<laanwj>
i meannn it's the same discussion every time but clearly bitcoin and cryptocurrency is still experimental on several levels, which makes it useful as a warning/disclaimer, and also not in some other ways, it's really not worth getting into that discussion over a single word in the documentation
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #24295: Remove std::move from fs wrapper to work around -D_LIBCPP_DEBUG=1 bug (master...2202-bug) https://github.com/bitcoin/bitcoin/pull/24295
<bitcoin-git>
[bitcoin] kristapsk opened pull request #24353: RPC: Return external_signer command in getwalletinfo (master...getwalletinfo-external_signer-2) https://github.com/bitcoin/bitcoin/pull/24353
<ronoaldo>
I'm not sure if this is the proper place to ask but the bitcoin client qt displays "This is experimental software." when you go to about -> About Bitcoin Core. Is there a goal to consider the software no longer experimental? Like, it won't be experimental when a milestone/feature set is reached.
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24117: index: make indices robust against init aborts (master...202201_index_startup) https://github.com/bitcoin/bitcoin/pull/24117
<yanmaani>
start bitcoin again, wait for it to sync up, kill it with -9
<yanmaani>
to reproduce: install bitcoin core, sync it until it's like a week behind, close it orderly
<yanmaani>
Why doesn't Bitcoin Core sync db after completing ibd?
<provoostenator>
Can move to #bitcoin-dev if the answer is "complicated" :-)
<michaelfolkson>
provoostenator: Probably should be in #bitcoin-dev (and I think only luke-jr can answer it) but BIP 148, 149 weren't given single digits and allocated at similar time. But they were entitled to be SegWit specific rather than general activation mechanism