< October 2023 >
Su Mo Tu We Th Fr Sa 1234 5 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30 31
2022-12-16
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22876: [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test (master...update-txvalid-json) https://github.com/bitcoin/bitcoin/pull/22876
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #23309: [WIP] Add a basic python REST API Server Wrapper (master...rest-python) https://github.com/bitcoin/bitcoin/pull/23309
<bitcoin-git>
[bitcoin] JeremyRubin closed pull request #22954: [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] (master...if_unset_then_unset) https://github.com/bitcoin/bitcoin/pull/22954
<aureleoules>
It contains a pre-compiled bitcoin-core with ccache (thus the image is heavy) but the first compilation is fast
<brunoerg>
reminding that it's not a generalist C++ tool, but focused on Bitcoin Core, because we have e.g. CAmount a = 1; and most tools can't deal with it
<bitcoin-git>
bitcoin/master 89c1491 furszy: wallet: if only have one output type, don't perform "mixed" coin selection
<bitcoin-git>
bitcoin/master ba47a4b Andrew Chow: Merge bitcoin/bitcoin#26668: wallet: if only have one output type, don't p...
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26701: contrib: make DNS seeds file an argument in CLI (`makeseeds`) (master...2022-12-seeds-improv) https://github.com/bitcoin/bitcoin/pull/26701
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #26697: logging: use std::bitset for categories (master...2022-12-log-categories-stdbitset) https://github.com/bitcoin/bitcoin/pull/26697
2022-12-13
<bitcoin-git>
bitcoin/master f866971 Douglas Chimento: rpc: Return fee and prevout(s) to getrawtransaction
<bitcoin-git>
bitcoin/master daf881d Andrew Chow: Merge bitcoin/bitcoin#23319: rpc: Return fee and prevout (utxos) to getraw...
<bitcoin-git>
[bitcoin] achow101 merged pull request #23319: rpc: Return fee and prevout (utxos) to getrawtransaction (master...23264-fee-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/23319
<bitcoin-git>
[bitcoin] achow101 merged pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
<bitcoin-git>
bitcoin/master c1a84f1 Andrew Chow: wallet: Move fee underpayment check to after fee setting
<bitcoin-git>
bitcoin/master e5daf97 Andrew Chow: wallet: Rename nFeeRet in CreateTransactionInternal to current_fee
<bitcoin-git>
bitcoin/master 798430d Andrew Chow: wallet: Sanity check fee paid cannot be negative
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26628: RPC: Reject RPC requests with same named parameter specified multiple times (master...pr/nmult) https://github.com/bitcoin/bitcoin/pull/26628
<bitcoin-git>
bitcoin/master e2c3b18 Ryan Ofsky: test: Add RPC tests for same named parameter specified more than once
<bitcoin-git>
bitcoin/master d1ca563 Ryan Ofsky: bitcoin-cli: Make it an error to specify the "args" parameter two differen...
<bitcoin-git>
bitcoin/master 6bd1d20 Ryan Ofsky: rpc: Make it an error server-side to specify same named parameter multiple...
<bitcoin-git>
[bitcoin] glozow opened pull request #26695: bench: BlockAssembler on a mempool with packages (master...2022-12-bench-miner) https://github.com/bitcoin/bitcoin/pull/26695
<bitcoin-git>
[bitcoin] kdmukai opened pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run the unsigned v23.0 arm64 binary; fall back to x86_64 binary (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<kdmukai>
fanquake: ya. "bitcoin-qt: code object is not signed at all" vs "Signature size=8958" etc.
<fanquake>
if you run codesign —display —versbose and pass either bitcoin-qt bin, you’ll see what I mean.
<fanquake>
The bitcoin-qt in the tarball wont be code signed. It likely would have just run ok on previous versions of macOS. However with newer versions of macOS that is less likely the case
<kdmukai>
then just directly downloaded the dmg version from https://bitcoincore.org/bin/bitcoin-core-23.0/ and that installed and ran fine. When Sjors ran a diff on the two v23.0 bitcoin-qt binaries (the one from the tar.gz vs what was unpacked from the dmg), they came up as different, which confounded Sjors.
<bitcoin-git>
[bitcoin] achow101 opened pull request #26690: wallet: Refactor database cursor into its own object with proper return codes (master...walletdb-cursor-unstupidfy) https://github.com/bitcoin/bitcoin/pull/26690
<bitcoin-git>
[bitcoin] josibake opened pull request #26689: test: add add_wallet_options to TestShell (master...josibake-add-wallet-options-test-shell) https://github.com/bitcoin/bitcoin/pull/26689
<bitcoin-git>
[bitcoin] hebasto opened pull request #26688: Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common` (master...221212-common) https://github.com/bitcoin/bitcoin/pull/26688
<bitcoin-git>
[bitcoin] 1440000bytes closed pull request #26682: doc: add expectation that dns seed domain should not be used for other things (master...doc-seed) https://github.com/bitcoin/bitcoin/pull/26682
<bytes1440000>
DNS seed domain for bitcoin core has has only one thing
<bytes1440000>
However, I have seen vulnerability in website leads to bigger things. Why take risks for all bitcoin core users? Use domain only for bitcoin core dns seed and other domains for other things.
<bitcoin-git>
[bitcoin] 1440000bytes opened pull request #26682: doc: add expectation that dns seed domain should not be used for other things (master...doc-seed) https://github.com/bitcoin/bitcoin/pull/26682
<bitcoin-git>
[bitcoin] yusufsahinhamza opened pull request #26681: net, contrib: Fix checking bad dns seeds without casting (master...fix-makeseeds-bug) https://github.com/bitcoin/bitcoin/pull/26681
<bitcoin-git>
[bitcoin] achow101 opened pull request #26679: wallet: Skip rescanning if wallet is more recent than tip (master...skip-newer-wallet-rescan) https://github.com/bitcoin/bitcoin/pull/26679
<bitcoin-git>
[bitcoin] john-moffett opened pull request #26675: wallet: For feebump, ignore abandoned descendant spends (master...2022_12_Bumpfee_ignore_abandoned) https://github.com/bitcoin/bitcoin/pull/26675
<bitcoin-git>
[bitcoin] AaronDewes opened pull request #26674: Add reindex=auto flag to automatically reindex corrupt data (master...auto-recovery) https://github.com/bitcoin/bitcoin/pull/26674
<pinheadmz>
any recco's for installing bitcoin core in a github CI action? trying wget bitcoincore.org now, takes like 10 minutes just to download
<stacie>
vasild: I could be mistaken but I think there might be enums for most of these things? For example, the ConnectionType enum in src/node/connection_types.h. I will admit this new RPC is pushing the limits of both my C++ and Bitcoin Core knowledge :)
<bitcoin-git>
[bitcoin] furszy opened pull request #26668: wallet: if only have one output type, don't perform "mixed" coin selection (master...2022_wallet_double_coin_selection) https://github.com/bitcoin/bitcoin/pull/26668
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26308: rpc/rest/zmq: reduce LOCK(cs_main) scope: ~6 times as many requests per second (master...no-lock-for-read-block) https://github.com/bitcoin/bitcoin/pull/26308
<bitcoin-git>
bitcoin/master c75e3d2 Andrew Toth: rest: reduce LOCK(cs_main) scope in rest_block
<bitcoin-git>
bitcoin/master f00808e Andrew Toth: rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock
<bitcoin-git>
bitcoin/master 7d253c9 Andrew Toth: zmq: remove LOCK(cs_main) from NotifyBlock
<ariard>
bitcoinerrorlog: on the actual benefit of mempoolfullrbf, abstraction made of the coinjoin/ln DoS that could be solved under a new replacement regime (e.g spent nversion-based signaling) there is the use-case of non-signaling replacement of external transactions by a supporting wallet as exposed here: https://github.com/bitcoin/bitcoin/pull/26438#issuecomment-1304370679
<bitcoin-git>
[bitcoin] achow101 opened pull request #26656: tests: Improve runtime of some tests when `--enable-debug` (master...faster-test-runner-when-debug) https://github.com/bitcoin/bitcoin/pull/26656
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26653: test, init: perturb file to ensure failure instead of only deleting them (master...2022-12-stress-test-perturbing) https://github.com/bitcoin/bitcoin/pull/26653
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26517: test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. (master...use-vsize-for-fee-tests) https://github.com/bitcoin/bitcoin/pull/26517
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26651: test: Avoid intermittent timeout in feature_assumevalid.py (master...2212-test-fix-assumevalid-🌞) https://github.com/bitcoin/bitcoin/pull/26651
<fanquake>
To github.com:bitcoin-core/bitcoin-detached-sigs.git
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26645: util: Include full version id in bug reports (master...2212-full-version-id-🍁) https://github.com/bitcoin/bitcoin/pull/26645
<bitcoin-git>
bitcoin/master fa825bd MarcoFalke: util: Include full version id in bug reports
<bitcoin-git>
bitcoin/master 272fb0a MarcoFalke: Merge bitcoin/bitcoin#26645: util: Include full version id in bug reports
<bitcoin-git>
[gui] hebasto closed pull request #236: Bugfix: Allow the user to start anyway when loading a wallet errors (master...gui_init_walleterror_cont) https://github.com/bitcoin-core/gui/pull/236
<bitcoin-git>
bitcoin/master 0596aa4 Hennadii Stepanov: Merge bitcoin-core/gui#683: doc: Drop no longer relevant comment
<bitcoin-git>
bitcoin/24.x 1b19c89 fanquake: build: bump version to 24.0.1 final
<bitcoin-git>
bitcoin/24.x a9ea715 fanquake: doc: adjust release notes for 24.0.1
<bitcoin-git>
bitcoin/24.x c119b0a fanquake: doc: generate manual pages for 24.0.1 final
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible (master...2212-ser-type-ver-👬) https://github.com/bitcoin/bitcoin/pull/26649
<BitcoinErrorLog>
Is 3 days enough for removal of "too heated" status? Conversation is happening in the mailing list and some people may want to comment in the PR. https://github.com/bitcoin/bitcoin/pull/26525
<bitcoin-git>
[bitcoin] fanquake opened pull request #26648: doc: move release notes to 24.0.1 and add notice (master...add_24_0_1_docs_redirect) https://github.com/bitcoin/bitcoin/pull/26648
<bitcoin-git>
[bitcoin] glozow opened pull request #26646: validation, bugfix: provide more info in *MempoolAcceptResult (master...package-single-tx-result) https://github.com/bitcoin/bitcoin/pull/26646
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26645: util: Include full version id in bug reports (master...2212-full-version-id-🍁) https://github.com/bitcoin/bitcoin/pull/26645
<bitcoin-git>
[bitcoin] furszy opened pull request #26644: wallet: bugfix, 'wallet_load_ckey' unit test fails with bdb (master...2022_walletdb_fix_bdb_deadlock) https://github.com/bitcoin/bitcoin/pull/26644
<bitcoin-git>
[bitcoin] achow101 opened pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
<bitcoin-git>
[bitcoin] hebasto opened pull request #26642: clang-tidy: Add more `performance-*` checks and related fixes (master...221205-ci-tidy) https://github.com/bitcoin/bitcoin/pull/26642