2018-12-06

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a88bd3186dfe...23a1fa0248fe
< bitcoin-git> bitcoin/master 58c5cc9 James Hilliard: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI
< bitcoin-git> bitcoin/master 23a1fa0 MarcoFalke: Merge #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI...
< bitcoin-git> [bitcoin] isghe opened pull request #14888: Fix createrawtransaction multi op return - issue #14868 (master...fix-createrawtransaction-multi-OP_RETURN) https://github.com/bitcoin/bitcoin/pull/14888
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14880: 0.17: Backport #14453 (0.17...2018-12-backport-14453) https://github.com/bitcoin/bitcoin/pull/14880
< gribble> https://github.com/bitcoin/bitcoin/issues/14689 | Require a public key to be retrieved when signing a P2PKH input by achow101 · Pull Request #14689 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14880 | 0.17: Backport #14453 by promag · Pull Request #14880 · bitcoin/bitcoin · GitHub
< promag> how about "bitcoin-qt -testnet -printtoconsole"?
< gribble> https://github.com/bitcoin/bitcoin/issues/14866 | Improve property evaluation way in bitcoin.conf by AkioNak · Pull Request #14866 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14670: http: Fix HTTP server shutdown (master...2018-11-httpserver) https://github.com/bitcoin/bitcoin/pull/14670
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/4987cdd16d76...a88bd3186dfe
< bitcoin-git> bitcoin/master 02e1e4e João Barbosa: rpc: Add wait argument to stop
< bitcoin-git> bitcoin/master 18e9685 João Barbosa: http: Send "Connection: close" header if shutdown is requested...
< bitcoin-git> bitcoin/master 6b13580 João Barbosa: http: Unlisten sockets after all workers quit...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14882: [doc] developer-notes.md: point out that UniValue deviates from upstream (master...2018/12/doc-univalue) https://github.com/bitcoin/bitcoin/pull/14882
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01bc479d1639...4987cdd16d76
< bitcoin-git> bitcoin/master a67d713 Sjors Provoost: [doc] developer-notes.md: point out that UniValue deviates from upstream
< bitcoin-git> bitcoin/master 4987cdd MarcoFalke: Merge #14882: [doc] developer-notes.md: point out that UniValue deviates from upstream...
< ossifrage> promag, that pull allowed bitcoin-qt --testnet
< bitcoin-git> [bitcoin] promag opened pull request #14887: RFC: rpc: Support time specifiers in dumpwallet filename (master...2018-12-dumpwallet-time) https://github.com/bitcoin/bitcoin/pull/14887
< ossifrage> Ugg, chrome + bitcoin 'make -j3' == OOM :-(
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14886 | [tests] Refactor importmulti tests by jnewbery · Pull Request #14886 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #14886: [tests] Refactor importmulti tests (master...importmulti_tests) https://github.com/bitcoin/bitcoin/pull/14886
< bitcoin-git> [bitcoin] promag opened pull request #14885: rpc: Assert arguments are unique in RPCHelpMan (master...2018-12-assert-unique-args) https://github.com/bitcoin/bitcoin/pull/14885
< gribble> https://github.com/bitcoin/bitcoin/issues/14783 | gui: Fix boost::signals2::no_slots_error in early calls to InitWarning by promag · Pull Request #14783 · bitcoin/bitcoin · GitHub
< ossifrage> I just tried running testnet bitcoin-qt and got: terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::signals2::no_slots_error> >'
< ossifrage> bitcoind works and my mainnet bitcoin-qt worked
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14869: scripts: Add trusted key for Samuel Dobson (master...2018_12_meshcollider) https://github.com/bitcoin/bitcoin/pull/14869
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0936e2596bbf...01bc479d1639
< bitcoin-git> bitcoin/master 1ca0502 Wladimir J. van der Laan: scripts: Add trusted key for Samuel Dobson...
< bitcoin-git> bitcoin/master 01bc479 Wladimir J. van der Laan: Merge #14869: scripts: Add trusted key for Samuel Dobson...
< bitcoin-git> [bitcoin] laanwj closed pull request #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. (master...proper_shebang) https://github.com/bitcoin/bitcoin/pull/14831
< bitcoin-git> [bitcoin] Sjors opened pull request #14884: [WIP] Travis: use Python 3.4 on one instance to check support (master...2018/12/python-3-4) https://github.com/bitcoin/bitcoin/pull/14884
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/127b30cce8af...0936e2596bbf
< bitcoin-git> bitcoin/master 688f665 vim88: Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.
< bitcoin-git> bitcoin/master 0936e25 Wladimir J. van der Laan: Merge #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash....
< bitcoin-git> [bitcoin] laanwj closed pull request #14838: Use const in COutPoint class (master...20181129-const-null-outpoint) https://github.com/bitcoin/bitcoin/pull/14838
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1858e6f2f20f...127b30cce8af
< bitcoin-git> bitcoin/master 6b82fc5 Hennadii Stepanov: Use const in COutPoint class
< bitcoin-git> bitcoin/master cf4b032 practicalswift: Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1
< bitcoin-git> bitcoin/master 127b30c Wladimir J. van der Laan: Merge #14838: Use const in COutPoint class...
< bitcoin-git> [bitcoin] laanwj closed pull request #14864: test: Run scripted-diff in subshell (master...2018-12-unset-commit-script-check) https://github.com/bitcoin/bitcoin/pull/14864
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2c473ff75f9...1858e6f2f20f
< bitcoin-git> bitcoin/master 43f9099 Carl Dong: scripted-diff: Run scripted-diff in subshell...
< bitcoin-git> bitcoin/master 1858e6f Wladimir J. van der Laan: Merge #14864: test: Run scripted-diff in subshell...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/6042dfe008e7...8b8b3a9a5fd9
< bitcoin-git> bitcoin/0.17 7a590d8 Gregory Sanders: fix converttopsbt permitsigdata arg, add basic test...
< bitcoin-git> bitcoin/0.17 8b8b3a9 Wladimir J. van der Laan: Merge #14878: 0.17: Further backports...
< bitcoin-git> [bitcoin] qubenix opened pull request #14883: add `--retry 5` to curl opts in install_db4.sh (master...qubenix-curl-retry) https://github.com/bitcoin/bitcoin/pull/14883
< gribble> https://github.com/bitcoin/bitcoin/issues/14424 | Stop requiring imported pubkey to sign non-PKH schemes by sipa · Pull Request #14424 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #14882: [doc] developer-notes.md: point out that UniValue deviates from upstream (master...2018/12/doc-univalue) https://github.com/bitcoin/bitcoin/pull/14882
< gribble> https://github.com/bitcoin/bitcoin/issues/14878 | 0.17: Further backports by MarcoFalke · Pull Request #14878 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14689 | Require a public key to be retrieved when signing a P2PKH input by achow101 · Pull Request #14689 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14880 | 0.17: Backport #14453 by promag · Pull Request #14880 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.17: https://github.com/bitcoin/bitcoin/commit/6042dfe008e7ad2c3495d1e9c484c7f2e256f04c
< bitcoin-git> bitcoin/0.17 6042dfe Wladimir J. van der Laan: build: bump version to 0.17.1...
< bitcoin-git> [bitcoin] mmachicao opened pull request #14881: Tests: Contract testing for the procedure AddTimeData (master...timedata_contract_test) https://github.com/bitcoin/bitcoin/pull/14881
< bitcoin-git> [bitcoin] mmachicao closed pull request #14800: Tests : timedata : unittest : median file filter shall not grow beyond size. (master...test_timedata) https://github.com/bitcoin/bitcoin/pull/14800

2018-12-05

< bitcoin-git> [bitcoin] promag opened pull request #14880: 0.17: Backport #14453 (0.17...2018-12-backport-14453) https://github.com/bitcoin/bitcoin/pull/14880
< promag> MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/14641#discussion_r239270214, what do you mean by "disallowing something else"?
< bitcoin-git> [bitcoin] hebasto opened pull request #14879: qt: Add warning messages to the debug window (master...20181205-debugwindow-warnings) https://github.com/bitcoin/bitcoin/pull/14879
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14878: 0.17: Further backports (0.17...Mf1812-17Backports) https://github.com/bitcoin/bitcoin/pull/14878
< moneyball> zallarak there are 26 open PRs on the good first issue list. does this help? https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
< bitcoin-git> [bitcoin] ch4ot1c opened pull request #14876: zmq: Add jsonblock, jsontx (master...feature/zmq-json) https://github.com/bitcoin/bitcoin/pull/14876
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14875: RPCHelpMan: Support required arguments after optional ones (master...Mf1812-rpcOptional) https://github.com/bitcoin/bitcoin/pull/14875
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/86ff0413bb8f...e2c473ff75f9
< bitcoin-git> bitcoin/master 1db0096 MarcoFalke: rpc: Pass argument descriptions to RPCHelpMan
< bitcoin-git> bitcoin/master fafd040 MarcoFalke: rpc: Add description to fundrawtransaction vout_index
< bitcoin-git> bitcoin/master fabca42 MarcoFalke: RPCHelpMan: Add space after colons in extended description...
< bitcoin-git> [bitcoin] MarcoFalke pushed 10 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/3362a95be360...5d12143c730c
< bitcoin-git> bitcoin/0.17 a3fe125 Andrew Chow: check that a separator is found for psbt inputs, outputs, and global map...
< bitcoin-git> bitcoin/0.17 cfdd6b2 Glenn Willen: More concise conversion of CDataStream to string...
< bitcoin-git> bitcoin/0.17 a9eab08 Glenn Willen: Remove redundant txConst parameter to FillPSBT...
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< promag> regarding #13780, I'm going to reproduce what sipa said in https://github.com/bitcoin/bitcoin/pull/14780#issuecomment-441101314
< gribble> https://github.com/bitcoin/bitcoin/issues/13780 | 0.17: Pre-branch maintenance by DrahtBot · Pull Request #13780 · bitcoin/bitcoin · GitHub
< provoostenator> I'm a bit confused how C++ magic makes it so that CTransactionRef (non_witness_utxo) and CTxOut (witness_utxo) are interchangeable. Context: https://github.com/bitcoin/bitcoin/pull/14588/commits/565500508aa5df0011109ebf375ba71b693fc7de#diff-d546634098d8003b6397c8643b74e47dR297
< gmaxwell> https://github.com/bitcoin/bitcoin/pull/14780 looks like it is the only thing outstanding for 0.17.1, which would be _really_ good to get out considering that 0.17 is broken on both the latest ubuntu and fedora. achow101 is a specfically requested reviewer, meshcollider also reviewed one of the original PRs.
< bitcoin-git> [bitcoin] mysticaltech opened pull request #14872: Adding -daemon default option to bitcoind (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14872
< moneyball> #proposedmeetingtopic next CoreDev meetup...be ready to give feedback at Thursday's weekly meeting...considering 3 days prior to Breaking Bitcoin June 5-7 in Amsterdam https://twitter.com/breakingbitcoin/status/1070060118866305026

2018-12-04

< gribble> https://github.com/bitcoin/bitcoin/issues/7718 | Verifying blocks window stays open after the main GUI appears · Issue #7718 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14854 | qt: Cleanup SplashScreen class by hebasto · Pull Request #14854 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #14869: scripts: Add trusted key for Samuel Dobson (master...2018_12_meshcollider) https://github.com/bitcoin/bitcoin/pull/14869
< bitcoin-git> [bitcoin] laanwj closed pull request #14840: Remove duplicate libconsensus linking in test make (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14840
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/abbf4be181e0...86ff0413bb8f
< bitcoin-git> bitcoin/master b14948e Amir Abrams: Remove duplicate libconsensus linking in test make...
< bitcoin-git> bitcoin/master 86ff041 Wladimir J. van der Laan: Merge #14840: Remove duplicate libconsensus linking in test make...
< bitcoin-git> [bitcoin] laanwj closed pull request #14861: tests: Modify rpc_bind to conform to #14532 behaviour. (master...2018-12-fix-rpc-bind-tests) https://github.com/bitcoin/bitcoin/pull/14861
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88445889f1b3...abbf4be181e0
< bitcoin-git> bitcoin/master f3cf95f Carl Dong: tests: Modify rpc_bind to conform to #14532 behaviour....
< bitcoin-git> bitcoin/master abbf4be Wladimir J. van der Laan: Merge #14861: tests: Modify rpc_bind to conform to #14532 behaviour....
< bitcoin-git> [bitcoin] laanwj closed pull request #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/42653570373d...88445889f1b3
< bitcoin-git> bitcoin/master 8042bbf Zain Iqbal Allarakhia: p2p: allow p2ptimeout to be configurable, speed up slow test
< bitcoin-git> bitcoin/master 48b37db Zain Iqbal Allarakhia: make peertimeout a debug argument, remove error message translation
< bitcoin-git> bitcoin/master 8844588 Wladimir J. van der Laan: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested....
< phwalkr> Where can I find a multi input tx building example? I have tried libbitcoin and bitcoin core and found nothing.
< bitcoin-git> [bitcoin] laanwj closed pull request #14848: docs: Fix broken Gmane URL in security-check.py (master...fix-gmane-urls) https://github.com/bitcoin/bitcoin/pull/14848
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c789add6fcc9...42653570373d
< bitcoin-git> bitcoin/master af1ed20 Craig Younkins: Fix broken Gmane URLs
< bitcoin-git> bitcoin/master 4265357 Wladimir J. van der Laan: Merge #14848: docs: Fix broken Gmane URL in security-check.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #14760: Log env path in BerkeleyEnvironment::Flush (master...2018-11-logmultienvflush) https://github.com/bitcoin/bitcoin/pull/14760
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8f1753b298f1...c789add6fcc9
< bitcoin-git> bitcoin/master 4674610 João Barbosa: Log env path in BerkeleyEnvironment::Flush
< bitcoin-git> bitcoin/master c789add Wladimir J. van der Laan: Merge #14760: Log env path in BerkeleyEnvironment::Flush...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0257062e50ca...8f1753b298f1
< bitcoin-git> bitcoin/master 6c6ee8a Chakib Benziane: Less confusing documentation for `torpassword`...
< bitcoin-git> bitcoin/master 8f1753b Wladimir J. van der Laan: Merge #14804: docs: Less confusing documentation for `torpassword`...
< bitcoin-git> [bitcoin] laanwj closed pull request #14804: docs: Less confusing documentation for `torpassword` (master...rebased-squashed-14609) https://github.com/bitcoin/bitcoin/pull/14804
< bitcoin-git> [bitcoin] laanwj closed pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64fc7c0c1b17...0257062e50ca
< bitcoin-git> bitcoin/master 2012d4d Gregory Sanders: Add CScriptNum decode python implementation in functional suite
< bitcoin-git> bitcoin/master 0257062 Wladimir J. van der Laan: Merge #14816: Add CScriptNum decode python implementation in functional suite...
< bitcoin-git> [bitcoin] AkioNak opened pull request #14866: Improve property evaluation way in bitcoin.conf (master...includeconf_eval_at_its_position) https://github.com/bitcoin/bitcoin/pull/14866
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14828: qt: Remove hidden columns in coin control dialog (master...2018-11-coincontroldialog) https://github.com/bitcoin/bitcoin/pull/14828
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c62b15118997...64fc7c0c1b17
< bitcoin-git> bitcoin/master 1c28feb João Barbosa: qt: Remove hidden columns in coin control dialog
< bitcoin-git> bitcoin/master 64fc7c0 Jonas Schnelli: Merge #14828: qt: Remove hidden columns in coin control dialog...
< ujjwalt> Hey, I’m new here and I want to start developing Bitcoin apps. I have basic idea about the protocol - enough to understand how the system largely works (keys, basic crypto etc) but where and how do I start if I want to make an app around this. I have a full node running now.
< sipa> you mean what does bitcoin core do if it doesn't hear back from a tx getdata request?
< gleb> A Bitcoin core node :)
< bitcoin-git> [bitcoin] dongcarl opened pull request #14864: test: Run scripted-diff in subshell (master...2018-12-unset-commit-script-check) https://github.com/bitcoin/bitcoin/pull/14864

2018-12-03

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14863: refactor: Add and use HaveTxsDownloaded() where appropriate (master...Mf1812-docNchainTx) https://github.com/bitcoin/bitcoin/pull/14863
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14862: [doc] chain: Declare BLOCK_VALID_HEADER unused (master...Mf1812-validationDocBLOCK_VALID_HEADER) https://github.com/bitcoin/bitcoin/pull/14862
< MarcoFalke> It is the last thing in https://github.com/bitcoin/bitcoin/milestone/39
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #14861: tests: Modify rpc_bind to conform to #14532 behaviour. (master...2018-12-fix-rpc-bind-tests) https://github.com/bitcoin/bitcoin/pull/14861
< bitcoin-git> [bitcoin] DrahtBot closed pull request #10794: Add simple light-client mode (RPC only) (master...2017/07/spv) https://github.com/bitcoin/bitcoin/pull/10794
< bitcoin-git> [bitcoin] DrahtBot closed pull request #12274: http: avoid fd exhaustion (master...http-fd-limit) https://github.com/bitcoin/bitcoin/pull/12274
< gribble> https://github.com/bitcoin/bitcoin/issues/14792 | rpc_bind tests failing locally for ipv6 and nonloopback · Issue #14792 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] DrahtBot closed pull request #12934: [net] [validation] Call ProcessNewBlock() asynchronously (master...module-isolation) https://github.com/bitcoin/bitcoin/pull/12934
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13413: [net,mempool] Call AcceptToMemoryPool() asynchronously in p2p (master...mempool-async) https://github.com/bitcoin/bitcoin/pull/13413
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14231: travis: Save cache even when build or test fail (master...travis-save-cache-on-error) https://github.com/bitcoin/bitcoin/pull/14231
< bitcoin-git> [bitcoin] DrahtBot closed pull request #13168: Thread names in logs and deadlock debug tools (take 2) (master...2018-05-threadnames-take-2) https://github.com/bitcoin/bitcoin/pull/13168
< molz> joiflores, you can talk about your issue in channel #bitcoin, let's hear it there
< joiflores> I know this channel is to discuss Bitcoin development, I am not a developer but I would like to talk with some developer about an issue
< bitcoin-git> [bitcoin] ken2812221 closed pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< addressleakt> I do a "bitcoin-cli dumpwallet wallet.txt" and I get a 300 MB file which seems to contain all addresses.
< addressleakt> Reading the manual I got the impression that importwallet would be the command to use to import this wallet-dump. So on a different Bitcoin Core I do "bitcoin-cli importwallet wallet.txt", I then do a dumpwallet on this new node to verify that the wallet have imported all the addresses correctly.

2018-12-02

< bitcoin-git> [bitcoin] salisbury-espinosa closed pull request #14858: RPC getblock accepts height or hash (master...rpc_getblock_accepts_height_or_hash) https://github.com/bitcoin/bitcoin/pull/14858
< bitcoin-git> [bitcoin] salisbury-espinosa opened pull request #14858: RPC getblock accepts height or hash (master...rpc_getblock_accepts_height_or_hash) https://github.com/bitcoin/bitcoin/pull/14858
< bitcoin-git> [bitcoin] ch4ot1c closed pull request #14459: More RPC help description fixes (master...fix/rpc-descriptions) https://github.com/bitcoin/bitcoin/pull/14459
< instagibbs> amaclin, if it's a feature for bitcoin core, opening an issue as feature request is definitely appropriate
< molz> amaclin, you can do it in channel #bitcoin or #bitcoin-dev
< amaclin> may I propose Bitcoin client feature here?
< bitcoin-git> [bitcoin] instagibbs opened pull request #14857: wallet_keypool_topup.py: Test for all keypool address types (master...keypool_topup_addresstype) https://github.com/bitcoin/bitcoin/pull/14857
< bitcoin-git> [bitcoin] dongcarl opened pull request #14856: [rebase] net: remove more CConnman globals (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
< bitcoin-git> [bitcoin] practicalswift closed pull request #11551: Fix unsigned integer wrap-around in GetBlockProofEquivalentTime (master...proof-equivalent-time) https://github.com/bitcoin/bitcoin/pull/11551
< NicolasDorier> gmaxwell: The people who would not check the utxo set, would also never check the bitcoin core binaries via gitian and just download them from the website.
< gribble> https://github.com/bitcoin/bitcoin/issues/8708 | net: have CConnman handle message sending by theuni · Pull Request #8708 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #14855: test: Correct ineffectual WithOrVersion from transactions_tests (master...with-or-version-test) https://github.com/bitcoin/bitcoin/pull/14855
< NicolasDorier> Sorry, this conversation might be better on bitcoin-dev than on bitcoin-core-dev.
< NicolasDorier> I initially just wanted to propose the idea of including such utxo set snapshot hash in a text file in Bitcoin Core releases as part of the release process. So people trusting the gitian sigs, can also trust the snapshot hash. It would be one UTXO set snapshot at every core release, which is more than enough.
< NicolasDorier> Strictly better to use Bitcoin Core to filter the traffic for me

2018-12-01

< bitcoin-git> [bitcoin] hebasto opened pull request #14854: qt: Cleanup SplashScreen class (master...20181201-cleanup-splashscreen) https://github.com/bitcoin/bitcoin/pull/14854
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/924cf794e1f4...3362a95be360
< bitcoin-git> bitcoin/0.17 fcdea8a Andrew Chow: Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things...
< bitcoin-git> bitcoin/0.17 fcefc68 Andrew Chow: Convert non-witness UTXOs to witness if witness sig created...
< bitcoin-git> bitcoin/0.17 3362a95 MarcoFalke: Merge #14196: [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary...
< Chris_Stewart_5> basically reproducing https://github.com/bitcoin/bitcoin/pull/14853
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ab5341d1356...ed12fd83ca79
< bitcoin-git> bitcoin/master fe1ff50 Chun Kuan Lee: Hide spendable label if priveate key is disabled
< bitcoin-git> bitcoin/master 82d6c5a Chun Kuan Lee: gui: Show watch-only eye instead of HD disabled
< bitcoin-git> bitcoin/master ed12fd8 Wladimir J. van der Laan: Merge #13966: gui: When private key is disabled, only show watch-only balance...
< bitcoin-git> [bitcoin] laanwj closed pull request #13966: gui: When private key is disabled, only show watch-only balance (master...ui-disable-privkey) https://github.com/bitcoin/bitcoin/pull/13966
< gribble> https://github.com/bitcoin/bitcoin/issues/13930 | Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader by Sjors · Pull Request #13930 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14841: consensus: Move CheckBlock() call to critical section (master...20181129-checkblock-mutex) https://github.com/bitcoin/bitcoin/pull/14841
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/011c42c5bd17...5ab5341d1356
< bitcoin-git> bitcoin/master c5ed6e7 Hennadii Stepanov: Move CheckBlock() call to critical section...
< bitcoin-git> bitcoin/master 5ab5341 Wladimir J. van der Laan: Merge #14841: consensus: Move CheckBlock() call to critical section...
< provoostenator> luke-jr: my dedicated pizza provider accepts bitcoin via BitPay, and I generally finish my pizza before it's confirmed, depsite all the error messages and RBF fud.
< luke-jr> provoostenator: my dedicated server provider accepts bitcoin via BitPay, and I just use PayPal nowadays instead because BitPay screwed up one too many times
< luke-jr> sipa: well, chasing away centralising people would only be a means to a goal (keeping Bitcoin itself secure)
< luke-jr> well, if they move to altcoins, that's not so much Bitcoin's problem..
< gmaxwell> luke-jr: even if you don't care about compeating with paypal, other people in the bitcoin ecosystem do. And they'll make tradeoffs as required to do so, and drag the ecosystem in that direction, especially if people who don't so much care about paypal ignore the requirements.
< gribble> https://github.com/bitcoin/bitcoin/issues/13937 | Track best-possible-headers (TheBlueMatt) by Sjors · Pull Request #13937 · bitcoin/bitcoin · GitHub
< gmaxwell> luke-jr: well it does when to compete with paypal others make centeralized bitcoin solutions.
< luke-jr> people choosing paypal doesn't harm Bitcoin's security, though
< gmaxwell> And so low end SBC hardware or VPSes will continue to target low end usage, which will work with centeralized bitcoin alternatives.
< luke-jr> albypaul: if you're not testing, then ask in #bitcoin to learn why you can't
< albypaul> is there a way to change the difficulty of bitcoin core if you are mining off you're own computer just a question i need to ask.
< luke-jr> albypaul: #bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/9483 | Complete hybrid full block SPV mode by jonasschnelli · Pull Request #9483 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14841 | consensus: Move CheckBlock() call to critical section by hebasto · Pull Request #14841 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #14853: depends: latest rapidcheck, enable property based tests on Travis (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
< gribble> https://github.com/bitcoin/bitcoin/issues/14733 | P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub

2018-11-30

< gribble> https://github.com/bitcoin/bitcoin/issues/11551 | Fix unsigned integer wrap-around in GetBlockProofEquivalentTime by practicalswift · Pull Request #11551 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/252844329f17...924cf794e1f4
< bitcoin-git> bitcoin/0.17 53dcf2b Gregory Sanders: Remove stale comment in CalculateMaximumSignedInputSize
< bitcoin-git> bitcoin/0.17 2a5cc40 Gregory Sanders: CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
< bitcoin-git> bitcoin/0.17 924cf79 MarcoFalke: Merge #14851: [backport] fix assert crash when specified change output spend size is unknown...
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< provoostenator> I wrote a document to describe what hardware wallet signing RPC calls could look like, what the hardware script should do (mostly achow101's HWI already does), and how that all ties together: https://github.com/Sjors/bitcoin/blob/2018/11/rpc-signer/doc/external-signer.md
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors · Pull Request #12134 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] laanwj closed pull request #13258: uint256: Remove unnecessary crypto/common.h dependency (master...uint256-no-crypto-alt) https://github.com/bitcoin/bitcoin/pull/13258
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81bd349c9c8d...011c42c5bd17
< bitcoin-git> bitcoin/master bf2e010 Karl-Johan Alm: uint256: Remove unnecessary crypto/common.h use
< bitcoin-git> bitcoin/master 011c42c Wladimir J. van der Laan: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14852: 0.17 backport: [tests] Add wallet_balance.py (0.17...Mf1811-walletBalanceTestBackport) https://github.com/bitcoin/bitcoin/pull/14852
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14845: [tests] Add wallet_balance.py (master...balance_tests) https://github.com/bitcoin/bitcoin/pull/14845
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14852: 0.17 backport: [tests] Add wallet_balance.py (0.17...Mf1811-walletBalanceTestBackport) https://github.com/bitcoin/bitcoin/pull/14852
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13a7454fbdac...81bd349c9c8d
< bitcoin-git> bitcoin/master c1825b9 John Newbery: [tests] Add wallet_balance.py...
< bitcoin-git> bitcoin/master 81bd349 MarcoFalke: Merge #14845: [tests] Add wallet_balance.py...
< bitcoin-git> [bitcoin] instagibbs opened pull request #14851: [backport] fix assert crash when specified change output spend size is unknown (0.17...change_crash_backport) https://github.com/bitcoin/bitcoin/pull/14851
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14380: fix assert crash when specified change output spend size is unknown (master...unknown_change_size) https://github.com/bitcoin/bitcoin/pull/14380
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74254fea1ef0...13a7454fbdac
< bitcoin-git> bitcoin/master b06483c Gregory Sanders: Remove stale comment in CalculateMaximumSignedInputSize
< bitcoin-git> bitcoin/master 0fb2e69 Gregory Sanders: CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
< bitcoin-git> bitcoin/master 13a7454 MarcoFalke: Merge #14380: fix assert crash when specified change output spend size is unknown...
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/9f556622c57d...d8bc0ce1da1c
< bitcoin-git> bitcoin/0.17 df5131b fanquake: gui: explicitly disable "Dark Mode" appearance on macOS...
< bitcoin-git> bitcoin/0.17 de5e48a Luke Dashjr: Bugfix: RPC: Add address_type named param for createmultisig...
< bitcoin-git> bitcoin/0.17 5782fdc Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14683: tests: better combine_logs.py behavior (master...2018-11-better-cons-log) https://github.com/bitcoin/bitcoin/pull/14683
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60b20c869f8d...74254fea1ef0
< bitcoin-git> bitcoin/master 4aabadb James O'Beirne: tests: have combine_logs default to most recent test dir
< bitcoin-git> bitcoin/master 74254fe MarcoFalke: Merge #14683: tests: better combine_logs.py behavior...
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #14849: [wip] depends: qt 5.9.7 (master...qt-5-9-7) https://github.com/bitcoin/bitcoin/pull/14849
< bitcoin-git> [bitcoin] cyounkins-bot opened pull request #14848: Fix broken Gmane URLs (master...fix-gmane-urls) https://github.com/bitcoin/bitcoin/pull/14848
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13676 | Explain that mempool memory is added to -dbcache by Sjors · Pull Request #13676 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12833 | [qt] move QSettings to bitcoin_rw.conf where possible by Sjors · Pull Request #12833 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors closed pull request #13470: WIP [bench] CCoinsView(Cache): measure various scenarios (master...2018/06/bench_db_cache) https://github.com/bitcoin/bitcoin/pull/13470
< gribble> https://github.com/bitcoin/bitcoin/issues/13998 | Scripts and tools: gitian-build.py improvements and corrections by hebasto · Pull Request #13998 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors closed pull request #13937: Track best-possible-headers (TheBlueMatt) (master...2018/08/best-header-tracking) https://github.com/bitcoin/bitcoin/pull/13937
< bitcoin-git> [bitcoin] fanquake closed pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< bitcoin-git> [bitcoin] kallewoof closed pull request #14847: refactor: SHA256AutoDetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
< gribble> https://github.com/bitcoin/bitcoin/issues/13258 | uint256: Remove unnecessary crypto/common.h dependency by kallewoof · Pull Request #13258 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof closed pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
< sdaftuar> "what is the hold up with implementing Dandelion in Bitcoin Core" <-- definitely a loaded question
< bitcoin-git> [bitcoin] kallewoof opened pull request #14847: refactor: SHA256Autodetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
< gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub
< Chris_Stewart_5> if anyone wants to take a stab at answering this loaded question ;) ttps://bitcoin.stackexchange.com/questions/81503/what-is-the-tradeoff-between-privacy-and-implementation-complexity-of-dandelion

2018-11-29

< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< jnewbery> zallarak: any testing/review of PRs in 'high priority for review' is always appreciated: https://github.com/bitcoin/bitcoin/projects/8
< bitcoin-git> [bitcoin] vim88 opened pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< BlueMatt> I have another bitcoin-dev post coming discussing package relay, but we have a few options there, if we just want to solve package relay for contracting applications like lightning, we can do so with limited consideration, I think
< sipa> here is another earlier proposed modification: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-February/015717.html
< wumpus> BlueMatt: ok what was your proposal, I'm not in #bitcoin-dev
< BlueMatt> oh, i meant bitcoin-dev ml but it hasnt passed moderation yet
< BlueMatt> next topic: the wall of text I just posted to bitcoin-dev :p
< wumpus> (see the commits in other backport PRs such as https://github.com/bitcoin/bitcoin/pull/14835)
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< BlueMatt> but, at least IMO, its super annoying that you cant build+run bitcoin-qt on the now-several-months-old versions of various OSs, and I presume other rolling distros (eg arch) also have this issue
< wumpus> still lots of backports open https://github.com/bitcoin/bitcoin/milestone/39 I guess they need review, or at least merging
< gmaxwell> I guess I can argue the consequences either way, I can imagine someone losing a wallet file with lots of bitcoin in it because it showed a low balance due to some easily abandoned transactions.
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< BlueMatt> but 0.17.0 currently cannot be self-built and bitcoin-qt opened on latest fedora/ubuntu release
< gribble> https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git> [bitcoin] jnewbery opened pull request #14845: [tests] Add wallet_balance.py (master...balance_tests) https://github.com/bitcoin/bitcoin/pull/14845
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ariaamz opened pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
< bitcoin-git> [bitcoin] fanquake closed pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
< bitcoin-git> [bitcoin] hebasto opened pull request #14841: consensus: Move CheckBlock() call to critical section (master...20181129-checkblock-mutex) https://github.com/bitcoin/bitcoin/pull/14841