2019-11-29

< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub

2019-11-28

< gribble> https://github.com/bitcoin/bitcoin/issues/15729 | rpc: Raise error in getbalance if minconf is not zero by promag . Pull Request #15729 . bitcoin/bitcoin . GitHub
< provoostenator> This outage breaks a bunch of deploy scripts out there, e.g. https://github.com/btcpayserver/dockerfile-deps/blob/master/Bitcoin/0.17.0/linuxamd64.Dockerfile#L8
< gribble> https://github.com/bitcoin/bitcoin/issues/17599 | ci: Run functional tests on s390x by MarcoFalke . Pull Request #17599 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23cecd6cd56f...114e89e596a6
< bitcoin-git> bitcoin/master 73b96c9 practicalswift: net: Fix uninitialized read in ProcessMessage(...)
< bitcoin-git> bitcoin/master 114e89e Wladimir J. van der Laan: Merge #17624: net: Fix an uninitialized read in ProcessMessage(..., "tx", ...)...
< bitcoin-git> [bitcoin] laanwj merged pull request #17624: net: Fix an uninitialized read in ProcessMessage(..., "tx", ...) when receiving a transaction we already have (master...uninitialized-read-in-ProcessMessage) https://github.com/bitcoin/bitcoin/pull/17624
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f59885d27a0...23cecd6cd56f
< bitcoin-git> bitcoin/master d2a3a5c fanquake: util: make ScheduleBatchPriority advisory only
< bitcoin-git> bitcoin/master 23cecd6 Wladimir J. van der Laan: Merge #17604: util: make ScheduleBatchPriority advisory only
< bitcoin-git> [bitcoin] laanwj merged pull request #17604: util: make ScheduleBatchPriority advisory only (master...fix_ScheduleBatchPriority_comment) https://github.com/bitcoin/bitcoin/pull/17604
< bitcoin-git> [bitcoin] Sjors opened pull request #17627: Initialize entropy buffers to suppress false positive warning (master...2019/11/buffers) https://github.com/bitcoin/bitcoin/pull/17627
< provoostenator> Ouch, bitcoincore.org SSL expired: https://github.com/bitcoin-core/bitcoincore.org/issues/690
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d8a66626d631...1f59885d27a0
< bitcoin-git> bitcoin/master 14aded4 Hennadii Stepanov: script: Lint Gitian descriptors with ShellCheck
< bitcoin-git> bitcoin/master 577682d Hennadii Stepanov: script: Enable SC2006 rule for Gitian scripts
< bitcoin-git> bitcoin/master 61bb21b Hennadii Stepanov: script: Enable SC2155 rule for Gitian scripts
< bitcoin-git> [bitcoin] laanwj merged pull request #17361: script: Lint Gitian descriptors with ShellCheck (master...20191103-lint-gitian-scripts) https://github.com/bitcoin/bitcoin/pull/17361
< gribble> https://github.com/bitcoin/bitcoin/issues/17626 | Travis apt download for trusty is failing with 401 . Issue #17626 . bitcoin/bitcoin . GitHub

2019-11-27

< bitcoin-git> [bitcoin] brakmic opened pull request #17623: rpc: add extensive file checks for dumptxoutset and dumpwallet (master...checks-for-dump-functions) https://github.com/bitcoin/bitcoin/pull/17623
< bitcoin-git> [bitcoin] brakmic closed pull request #17615: rpc: check for irregular files in dumptxoutset (master...dumptxoutset-invalid-file-error) https://github.com/bitcoin/bitcoin/pull/17615
< gribble> https://github.com/bitcoin/bitcoin/issues/17620 | MemorySanitizer complains about unitialized variable in RPC method names . Issue #17620 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] instagibbs opened pull request #17621: IsUsedDestination should count any known single-key address (master...actually_no_reuse) https://github.com/bitcoin/bitcoin/pull/17621

2019-11-26

< bitcoin-git> [bitcoin] jonatack opened pull request #17617: rpc: replace varying UNIX time strings with a constant (master...unix-epoch-time-consistency) https://github.com/bitcoin/bitcoin/pull/17617
< bitcoin-git> [bitcoin] petterhs closed pull request #17614: rpc: fix failure calling dumptxoutset with invalid filename (master...fix-rpc-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/17614
< bitcoin-git> [bitcoin] brakmic opened pull request #17615: rpc: check for irregular files in dumptxoutset (master...dumptxoutset-invalid-file-error) https://github.com/bitcoin/bitcoin/pull/17615
< bitcoin-git> [bitcoin] petterhs opened pull request #17614: rpc: fix failure calling dumptxoutset with invalid filename (master...fix-rpc-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/17614
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/4fb82e916b3b...d8a66626d631
< bitcoin-git> bitcoin/master 70cda34 Jon Atack: rpc: improve getaddressinfo RPCHelpman formatting
< bitcoin-git> bitcoin/master 5a0ed85 Jon Atack: rpc: improve getaddressinfo RPCHelpman content
< bitcoin-git> bitcoin/master 8d1ed0c Jon Atack: rpc: clarify label vs labels in getaddressinfo RPCHelpman
< bitcoin-git> [bitcoin] laanwj merged pull request #17283: rpc: improve getaddressinfo test coverage, help, code docs (master...rpc-getaddressinfo-labels) https://github.com/bitcoin/bitcoin/pull/17283
< gribble> https://github.com/bitcoin/bitcoin/issues/17613 | doc: unify epoch time description in RPC output . Issue #17613 . bitcoin/bitcoin . GitHub
< MarcoFalke> Yeah, we should probably clarify that all times in Bitcoin are not clocks (e.g. the c++11 clock), but durations measured from epoch
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2ab1309619b...4fb82e916b3b
< bitcoin-git> bitcoin/master 27d82b6 fanquake: gui: remove macOS start on login code
< bitcoin-git> bitcoin/master 4fb82e9 fanquake: Merge #17567: gui: remove macOS start on login code
< bitcoin-git> [bitcoin] fanquake merged pull request #17567: gui: remove macOS start on login code (master...remove_macos_startup_item) https://github.com/bitcoin/bitcoin/pull/17567
< gribble> https://github.com/bitcoin/bitcoin/issues/17578 | rpc: simplify getaddressinfo labels, deprecate previous behavior by jonatack . Pull Request #17578 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17283 | rpc: improve getaddressinfo test coverage, help, code docs by jonatack . Pull Request #17283 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0ee914ba9e59...f2ab1309619b
< bitcoin-git> bitcoin/master 8781904 Hennadii Stepanov: qt: Fix class name of Ui::ModalOverlay
< bitcoin-git> bitcoin/master 93352d2 Hennadii Stepanov: qt: Use proper class for Ui::ReceiveCoinsDialog
< bitcoin-git> bitcoin/master f2ab130 fanquake: Merge #17606: qt, refactor: Use proper classes for Ui::*
< bitcoin-git> [bitcoin] fanquake merged pull request #17606: qt, refactor: Use proper classes for Ui::* (master...20191125-fix-ui-baseclass) https://github.com/bitcoin/bitcoin/pull/17606
< bitcoin-git> [bitcoin] promag opened pull request #17611: gui: Make send and receive widgets extend QWidget (master...2019-11-send-receive-widgets) https://github.com/bitcoin/bitcoin/pull/17611
< gribble> https://github.com/bitcoin/bitcoin/issues/17104 | build: `make dist` uses `git archive` by ch4ot1c . Pull Request #17104 . bitcoin/bitcoin . GitHub
< wumpus> dviola: FWIW rcs have tarballs and binaries too https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc3/
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c1c43754b7a...0ee914ba9e59
< bitcoin-git> bitcoin/master 1a3a256 Harris: wallet: replace raw pointer with const reference in AddrToPubKey
< bitcoin-git> bitcoin/master 0ee914b Samuel Dobson: Merge #17584: wallet: replace raw pointer with const reference in AddrToPu...
< bitcoin-git> [bitcoin] meshcollider merged pull request #17584: wallet: replace raw pointer with const reference in AddrToPubKey (master...rpcwallet-redundant-pointer-conversion) https://github.com/bitcoin/bitcoin/pull/17584
< bitcoin-git> [bitcoin] hebasto opened pull request #17606: qt, refactor: Use proper classes for Ui::* (master...20191125-fix-ui-baseclass) https://github.com/bitcoin/bitcoin/pull/17606
< dviola> i.e. if I clone from https://github.com/bitcoin/bitcoin.git

2019-11-25

< dviola> the git tags in the bitcoin repo and the releases at bitcoincore.org are the same thing, right?
< bitcoin-git> [bitcoin] fanquake opened pull request #17604: doc: correct ScheduleBatchPriority return value documentation (master...fix_ScheduleBatchPriority_comment) https://github.com/bitcoin/bitcoin/pull/17604
< bitcoin-git> [bitcoin] dongcarl opened pull request #17602: net: Lower # of IPs learned from a DNS seed (master...2019-11-lower-nMaxIPs) https://github.com/bitcoin/bitcoin/pull/17602
< bitcoin-git> [bitcoin] jnewbery opened pull request #17601: Validation: Move CheckBlock() mutation guard to AcceptBlock() (master...2019-11-checkblock-in-acceptblock) https://github.com/bitcoin/bitcoin/pull/17601
< bitcoin-git> [bitcoin] hebasto opened pull request #17600: qt: Remove connection for unused accepted() signal in ReceiveRequestDialog (master...20191125-unused-connection) https://github.com/bitcoin/bitcoin/pull/17600
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17599: ci: Run functional tests on s390x (master...1911-ciS390x) https://github.com/bitcoin/bitcoin/pull/17599
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12230529e330...2c1c43754b7a
< bitcoin-git> bitcoin/master 2fa65e0 Elichai Turkel: Add ci script to install on s390x
< bitcoin-git> bitcoin/master da1f153 Elichai Turkel: Add s390x tests to travis
< bitcoin-git> bitcoin/master 2c1c437 MarcoFalke: Merge #17591: ci: Add big endian platform - s390x
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17591: ci: Add big endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
< bitcoin-git> [bitcoin] hebasto reopened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17598: doc: Update release process with latest changes (master...1911-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17598
< bitcoin-git> [bitcoin] hebasto closed pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
< bitcoin-git> [bitcoin] hebasto opened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
< bitcoin-git> [bitcoin] fanquake merged pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89a1f7a250ef...12230529e330
< bitcoin-git> bitcoin/master 41d7db0 Wladimir J. van der Laan: doc: Change doxygen URL to doxygen.bitcoincore.org
< bitcoin-git> bitcoin/master 1223052 fanquake: Merge #17596: doc: Change doxygen URL to doxygen.bitcoincore.org
< bitcoin-git> [bitcoin] laanwj opened pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
< gribble> https://github.com/bitcoin/bitcoin/issues/17576 | Mempool fields in Debug Windows show "N/A" . Issue #17576 . bitcoin/bitcoin . GitHub
< dviola> in bitcoin-qt 0.19.0.1 "Current number of transactions" and "Memory usage" stays at "N/A"
< gribble> https://github.com/bitcoin/bitcoin/issues/17573 | Seed RNG with precision timestamps on receipt of net messages. by TheBlueMatt . Pull Request #17573 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #17595: guix: Enable building for `x86_64-w64-mingw32` target (master...2019-09-guix-staging-win-mingw-6.0.0) https://github.com/bitcoin/bitcoin/pull/17595
< bitcoin-git> [bitcoin] laanwj merged pull request #16617: [0.18.2] Backports (0.18...0_18_2_backports) https://github.com/bitcoin/bitcoin/pull/16617
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e6f167bfdfc0...89a1f7a250ef
< bitcoin-git> bitcoin/master f13e274 Aaron Clauson: Appveyor install libevent[thread] vcpkg
< bitcoin-git> bitcoin/master 89a1f7a MarcoFalke: Merge #17592: Appveyor install libevent[thread] vcpkg
< fanquake> Seems this is our second uninitialized var issue in as many weeks: https://github.com/bitcoin/bitcoin/pull/17568#issuecomment-558026462
< gribble> https://github.com/bitcoin/bitcoin/issues/16617 | [0.18.2] Backports by fanquake . Pull Request #16617 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] mzumsande opened pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
< bitcoin-git> [bitcoin] sipsorcery opened pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
< bitcoin-git> [bitcoin] elichai opened pull request #17591: Testing bitcoin in a Big Endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
< sipa> "fanquake, faster than his shadow bitcoin-git"
< bitcoin-git> [bitcoin] fanquake closed pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
< bitcoin-git> [bitcoin] muzafa-popo opened pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
< wumpus> I remember we had an issue in the beginning (2011? 2012?) where for some reason, bitcoin was linked against a single-threaded standard library on windows and this wasn't caught as a compile time issue, resulting in some really ugly unpredictable crashes
< vasild> jkczyz: What do you think of https://github.com/bitcoin/bitcoin/pull/17577?
< bitcoin-git> [bitcoin] Sjors opened pull request #17587: gui: show watch-only balance in send screen (master...2019/11/send_balance) https://github.com/bitcoin/bitcoin/pull/17587
< sipsorcery> my appveyor job does build bitcoin core successfully on master and the only difference will be my job has a more recent update of vcpkg
< gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17586 | build: AppVeyor build uses Libevent that built without support for evthread_use_windows_threads() . Issue #17586 . bitcoin/bitcoin . GitHub
< sipsorcery> it won't be DrahtBot/bitcoin
< sipsorcery> it will be DrahtBot/bitcoin-xxxx
< wumpus> ok, tried it with https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache, which at least gives me a different permission denied error :-)
< sipsorcery> this bit in the url is specific to my account and job "sipsorcery/bitcoin-72c17"
< hebasto> meshcollider: wumpus: I've restored removed header from 17518 - it doesn't help https://ci.appveyor.com/project/hebasto/bitcoin/builds/29095602
< sipsorcery> has anyone use the new github actions for bitcoin core builds?
< sipsorcery> manually by sending a http request of the form curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/sipsorcery/bitcoin-72c17/buildcache
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/dd198064b5d9...a284bbbee805
< bitcoin-git> bitcoin/0.19 2aba76c Hennadii Stepanov: qt: Fix missing qRegisterMetaType for size_t
< bitcoin-git> bitcoin/0.19 a284bbb Hennadii Stepanov: refactor: Styling w/ clang-format, comment update
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/1bc9988993ee...dd198064b5d9
< bitcoin-git> bitcoin/0.19 dd19806 Wladimir J. van der Laan: doc: Clear out release notes after 0.19.0.1
< gribble> https://github.com/bitcoin/bitcoin/issues/17571 | Add libtest_util library to msvc build configuration by sipsorcery . Pull Request #17571 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17008 | build: bump libevent to 2.1.11 in depends by stefanwouldgo . Pull Request #17008 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17518 | refactor, wallet: Nuke coincontrol circular dependency by hebasto . Pull Request #17518 . bitcoin/bitcoin . GitHub
< wumpus> appveyor failing: "C:\projects\bitcoin\src\httpserver.cpp(373,5): error C3861: 'evthread_use_windows_threads': identifier not found [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]"
< bitcoin-git> [bitcoin] jonatack opened pull request #17585: rpc: deprecate getaddressinfo label (master...deprecate-getaddressinfo-label) https://github.com/bitcoin/bitcoin/pull/17585
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17569: build: Allow export of environ symbols and work around rv64 toolchain issue (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/746318179884...e6f167bfdfc0
< bitcoin-git> bitcoin/master f6e4225 Wladimir J. van der Laan: build: Allow export of environ symbols
< bitcoin-git> bitcoin/master eafd259 Wladimir J. van der Laan: build: Add NX workaround for RV64
< bitcoin-git> bitcoin/master e6f167b MarcoFalke: Merge #17569: build: Allow export of environ symbols and work around rv64 ...

2019-11-24

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17538: build: Bump minimum libc to 2.17 for release binaries (master...bump_libc_217) https://github.com/bitcoin/bitcoin/pull/17538
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/239d19966788...746318179884
< bitcoin-git> bitcoin/master b77d5ad Wladimir J. van der Laan: build: Disallow dynamic linking against c++ library
< bitcoin-git> bitcoin/master 16a7be1 Wladimir J. van der Laan: build: Bump minimum versions in symbol checker
< bitcoin-git> bitcoin/master 8f15a31 fanquake: doc: add glibc 2.17 requirement to release-notes
< bitcoin-git> [bitcoin] brakmic opened pull request #17584: wallet: replace raw pointer with const reference in AddrToPubKey (master...rpcwallet-redundant-pointer-conversion) https://github.com/bitcoin/bitcoin/pull/17584
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17581: refactor: Remove settings merge reverse precedence code (master...pr/wdrev) https://github.com/bitcoin/bitcoin/pull/17581
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17580: refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags (master...pr/wdlist) https://github.com/bitcoin/bitcoin/pull/17580
< bitcoin-git> [bitcoin] andrewtoth opened pull request #17579: [refactor] Merge getreceivedby tally into GetReceived function (master...getreceivedby-refactor) https://github.com/bitcoin/bitcoin/pull/17579
< bitcoin-git> [bitcoin] jonatack opened pull request #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior (master...deprecate-getaddress-info-labels-purpose) https://github.com/bitcoin/bitcoin/pull/17578
< bitcoin-git> [bitcoin] vasild opened pull request #17577: refactor: deduplicate the message sign/verify code (master...message-dedup) https://github.com/bitcoin/bitcoin/pull/17577
< bitcoin-git> [bitcoin] laanwj merged pull request #17574: doc: Add historical release notes for 0.19.0.1 (master...2019_11_relnot_0.19.0.1) https://github.com/bitcoin/bitcoin/pull/17574
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2eeacdfe44e5...239d19966788
< bitcoin-git> bitcoin/master 14feda0 Wladimir J. van der Laan: doc: Add historical release notes for 0.19.0.1
< bitcoin-git> bitcoin/master 239d199 Wladimir J. van der Laan: Merge #17574: doc: Add historical release notes for 0.19.0.1
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9cbd87d8ee29...2eeacdfe44e5
< bitcoin-git> bitcoin/master ba2c5fe Pieter Wuille: Fix CPUID subleaf iteration
< bitcoin-git> bitcoin/master f93fc61 Pieter Wuille: Put bounds on the number of CPUID leaves explored
< bitcoin-git> bitcoin/master 2eeacdf Wladimir J. van der Laan: Merge #17527: Fix CPUID subleaf iteration
< bitcoin-git> [bitcoin] laanwj merged pull request #17527: Fix CPUID subleaf iteration (master...201911_fixed_cpuid_subleafs) https://github.com/bitcoin/bitcoin/pull/17527
< bitcoin-git> [bitcoin] laanwj opened pull request #17574: doc: Add historical release notes for 0.19.0.1 (master...2019_11_relnot_0.19.0.1) https://github.com/bitcoin/bitcoin/pull/17574
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c98e2024d52...9cbd87d8ee29
< bitcoin-git> bitcoin/master 3ed5e68 Hennadii Stepanov: refactor: Nuke coincontrol circular dependency
< bitcoin-git> bitcoin/master 9cbd87d Samuel Dobson: Merge #17518: refactor, wallet: Nuke coincontrol circular dependency
< bitcoin-git> [bitcoin] meshcollider merged pull request #17518: refactor, wallet: Nuke coincontrol circular dependency (master...20191119-coincontrol-dep) https://github.com/bitcoin/bitcoin/pull/17518
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17430: build:fix "make clean" darwin build (master...fix-darwin-make-clean) https://github.com/bitcoin/bitcoin/pull/17430
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17558: build: organize tests by goal (master...2019/325/order-by-goal) https://github.com/bitcoin/bitcoin/pull/17558

2019-11-23

< gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
< fanquake> "PS this seems to be causing a noise inversely proportional to the complexity of the change" https://github.com/bitcoin/bitcoin/pull/17563#issuecomment-557829862
< gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33c103e2fe67...2c98e2024d52
< bitcoin-git> bitcoin/master b509554 Aaron Clauson: Added libtest_util library to msvc build configuration.
< bitcoin-git> bitcoin/master 2c98e20 fanquake: Merge #17571: Add libtest_util library to msvc build configuration
< bitcoin-git> [bitcoin] fanquake merged pull request #17571: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17573: Seed RNG with precision timestamps on receipt of net messages. (master...2019-11-rng-netmsg) https://github.com/bitcoin/bitcoin/pull/17573
< cfields> cory@Macbook:~/dev/bitcoin$ spctl --assess -vv /Volumes/Bitcoin-Core/Bitcoin-Qt.app
< cfields> /Volumes/Bitcoin-Core/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified)
< bitcoin-git> [bitcoin] fanquake merged pull request #17539: doc: Update and improve Developer Notes (master...20191120-developer-notes) https://github.com/bitcoin/bitcoin/pull/17539
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b79caf65801...33c103e2fe67
< bitcoin-git> bitcoin/master 794fe91 Hennadii Stepanov: doc: Update and improve Developer Notes
< bitcoin-git> bitcoin/master 33c103e fanquake: Merge #17539: doc: Update and improve Developer Notes
< JeremyCrookshank> Anyone know why Qt-creator says the Bitcoin form .h files aren't part of the project? Not able to add slots because of it
< bitcoin-git> [bitcoin] sipsorcery opened pull request #17571: WIP: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
< gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17452 | lib: update fuzz directory in .gitignore by jonatack . Pull Request #17452 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17542 | build: Create test utility library from src/test/util/ by brakmic . Pull Request #17542 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17561 | doc: Changed MiniUPnPc link to https in dependencies.md by sandakersmann . Pull Request #17561 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler . Pull Request #17536 . bitcoin/bitcoin . GitHub
< sipsorcery> JeremyCrookshank: only one I've seen is readme at https://github.com/bitcoin/bitcoin/tree/master/src/qt
< bitcoin-git> [bitcoin] KaanKC opened pull request #17570: test: add unit test for non-standard txs w/ too large tx size (master...test_unit_IsStandardTx_tx-size) https://github.com/bitcoin/bitcoin/pull/17570
< gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols by laanwj . Pull Request #17569 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #17569: build: Allow export of environ symbols (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
< gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs (master...fix-bnb-preset-sub) https://github.com/bitcoin/bitcoin/pull/17568
< bitcoin-git> [bitcoin] fanquake closed pull request #16738: gui: Remove needless GCC diagnostic pragma (master...20190827-gcc-pragmas) https://github.com/bitcoin/bitcoin/pull/16738
< bitcoin-git> [bitcoin] fanquake opened pull request #17567: gui: remove macOS start on login code (master...remove_macos_startup_item) https://github.com/bitcoin/bitcoin/pull/17567

2019-11-22

< gribble> https://github.com/bitcoin/bitcoin/issues/16688 | log: Add validation interface logging by jkczyz . Pull Request #16688 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15849 | Thread names in logs and deadlock debug tools by jamesob . Pull Request #15849 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] meshcollider merged pull request #17447: wallet: Make -walletdir network only (master...2019-11-fix-15630) https://github.com/bitcoin/bitcoin/pull/17447
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4effd67bf407...0b79caf65801
< bitcoin-git> bitcoin/master 3c2c439 Joao Barbosa: wallet: Make -walletdir network only
< bitcoin-git> bitcoin/master 0b79caf Samuel Dobson: Merge #17447: wallet: Make -walletdir network only
< bitcoin-git> [bitcoin] darosior opened pull request #17566: Switch to weight units for all feerates computation (master...feerate_in_weight) https://github.com/bitcoin/bitcoin/pull/17566
< bitcoin-git> [bitcoin] mxaddict opened pull request #17565: Fixed freezing GUI on reindex (master...freezing-gui-on-reindex) https://github.com/bitcoin/bitcoin/pull/17565
< bitcoin-git> [bitcoin] meshcollider merged pull request #17387: wallet_importmulti: use addresses of the same type as being imported (master...tests-fix-getaddrinfo-type-consistency) https://github.com/bitcoin/bitcoin/pull/17387
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6f5b6f47d71...4effd67bf407
< bitcoin-git> bitcoin/master b84e776 Andrew Chow: wallet_importmulti: use addresses of the same type as being imported
< bitcoin-git> bitcoin/master 4effd67 Samuel Dobson: Merge #17387: wallet_importmulti: use addresses of the same type as being ...
< gribble> https://github.com/bitcoin/bitcoin/issues/17387 | wallet_importmulti: use addresses of the same type as being imported by achow101 . Pull Request #17387 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a97d2b1a525...a6f5b6f47d71
< bitcoin-git> bitcoin/master 7d7bf2f fanquake: build: set minimum supported macOS to 10.12
< bitcoin-git> bitcoin/master a6f5b6f fanquake: Merge #17550: build: set minimum supported macOS to 10.12
< bitcoin-git> [bitcoin] fanquake merged pull request #17550: build: set minimum supported macOS to 10.12 (master...macOS_10_12_minimum) https://github.com/bitcoin/bitcoin/pull/17550
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7127c3102047...2a97d2b1a525
< bitcoin-git> bitcoin/master 6a2e6b0 Gregory Sanders: Remove out of date comments for CalculateMaximumSignedTxSize
< bitcoin-git> bitcoin/master 2a97d2b Samuel Dobson: Merge #17553: wallet: Remove out of date comments for CalculateMaximumSign...
< bitcoin-git> [bitcoin] meshcollider merged pull request #17553: wallet: Remove out of date comments for CalculateMaximumSignedTxSize (master...calc_max_size_comment) https://github.com/bitcoin/bitcoin/pull/17553
< bitcoin-git> [bitcoin] vasild opened pull request #17563: lib: fix a compiler warning: unused GetDevURandom() (master...unused-GetDevURandom) https://github.com/bitcoin/bitcoin/pull/17563
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17564: rpc: Use mempool from node context instead of global (master...1911-rpcNoTxPoolGlobal) https://github.com/bitcoin/bitcoin/pull/17564
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0aa72061e5d6...7127c3102047
< bitcoin-git> bitcoin/master 55295fb Joao Barbosa: wallet: Lock address type in ReserveDestination
< bitcoin-git> bitcoin/master 3958295 Joao Barbosa: wallet: LearnRelatedScripts only if KeepDestination
< bitcoin-git> bitcoin/master 7127c31 Samuel Dobson: Merge #17237: wallet: LearnRelatedScripts only if KeepDestination
< bitcoin-git> [bitcoin] meshcollider merged pull request #17237: wallet: LearnRelatedScripts only if KeepDestination (master...2019-10-wallet-reservedestination) https://github.com/bitcoin/bitcoin/pull/17237
< bitcoin-git> [bitcoin] meshcollider merged pull request #16944: gui: create PSBT with watch-only wallet (master...2019/08/gui-send-psbt) https://github.com/bitcoin/bitcoin/pull/16944
< bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8aac85d71e21...0aa72061e5d6
< bitcoin-git> bitcoin/master 40537f0 Sjors Provoost: [wallet] ListCoins: include watch-only for wallets without private keys
< bitcoin-git> bitcoin/master 848f889 Sjors Provoost: [gui] send: include watch-only
< bitcoin-git> bitcoin/master 39465d5 Sjors Provoost: [wallet] add fillPSBT to interface
< gribble> https://github.com/bitcoin/bitcoin/issues/17550 | build: set minimum supported macOS to 10.12 by fanquake . Pull Request #17550 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17525 | build: Linux gitian builds fail on master . Issue #17525 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17538 | build: Bump minimum libc to 2.17 for release binaries by fanquake . Pull Request #17538 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
< sipa> achow101: my first PR in bitcoin core took 5 months to be merged, and that was 2011 :p
< gribble> https://github.com/bitcoin/bitcoin/issues/17387 | wallet_importmulti: use addresses of the same type as being imported by achow101 . Pull Request #17387 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] meshcollider merged pull request #17371: Refactor: Require scriptPubKey to get wallet SigningProvider (master...wallet-box-pr-5) https://github.com/bitcoin/bitcoin/pull/17371
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cef87f7a48f7...8aac85d71e21
< bitcoin-git> bitcoin/master 4b0c718 Andrew Chow: Accumulate result UniValue in SignTransaction
< bitcoin-git> bitcoin/master d0dab89 Andrew Chow: Refactor: Require scriptPubKey to get wallet SigningProvider
< bitcoin-git> bitcoin/master 8aac85d Samuel Dobson: Merge #17371: Refactor: Require scriptPubKey to get wallet SigningProvider...
< bitcoin-git> [bitcoin] jnewbery opened pull request #17562: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bb862d7864cc...cef87f7a48f7
< bitcoin-git> bitcoin/master db15e71 Andrew Chow: Use BnB when preset inputs are selected
< bitcoin-git> bitcoin/master b007efd Andrew Chow: Allow BnB when subtract fee from outputs
< bitcoin-git> bitcoin/master cef87f7 Samuel Dobson: Merge #17290: Enable BnB coin selection for preset inputs and subtract fee...
< bitcoin-git> [bitcoin] meshcollider merged pull request #17290: Enable BnB coin selection for preset inputs and subtract fee from outputs (master...all-bnb) https://github.com/bitcoin/bitcoin/pull/17290
< gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17526 | Use Single Random Draw In addition to knapsack as coin selection fallback by achow101 . Pull Request #17526 . bitcoin/bitcoin . GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17560: ci: Use apt-fast ? (master...1911-ciAptFast) https://github.com/bitcoin/bitcoin/pull/17560
< jonasschnelli> I pushed the 0.19.0.1 macOS signature: https://github.com/bitcoin-core/bitcoin-detached-sigs/commits/0.19
< luke-jr> instagibbs_: "As of today, this fix has NOT been backported to older versions. When/if v0.15.3 and v0.16.4 are released, they may also include a fix, but due to the minor severity of this vulnerability, it does not merit a dedicated release on its own." https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-June/017040.html
< bitcoin-git> [bitcoin] sandakersmann opened pull request #17561: doc: Changed MiniUPnPc link to https in dependencies.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17561
< gribble> https://github.com/bitcoin/bitcoin/issues/17371 | Refactor: Require scriptPubKey to get wallet SigningProvider by achow101 . Pull Request #17371 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #14384: Fire TransactionRemovedFromMempool callbacks from mempool (master...patch/validationinterface-resolve-circular-dependencies) https://github.com/bitcoin/bitcoin/pull/14384
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17560: ci: Use apt-fast ? (master...1911-ciAptFast) https://github.com/bitcoin/bitcoin/pull/17560
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03f6f408ab2e...bb862d7864cc
< bitcoin-git> bitcoin/master e20c72f 251: Fire TransactionRemovedFromMempool from mempool
< bitcoin-git> bitcoin/master bb862d7 Wladimir J. van der Laan: Merge #14384: Fire TransactionRemovedFromMempool callbacks from mempool
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b983e7e1721f...03f6f408ab2e
< bitcoin-git> bitcoin/master ec89d28 fanquake: build: remove libanl.so.1 from ALLOWED_LIBRARIES
< bitcoin-git> bitcoin/master 03f6f40 fanquake: Merge #17545: build: remove libanl.so.1 from ALLOWED_LIBRARIES
< bitcoin-git> [bitcoin] fanquake merged pull request #17545: build: remove libanl.so.1 from ALLOWED_LIBRARIES (master...remove_libanl_from_allowed_symbols) https://github.com/bitcoin/bitcoin/pull/17545
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a739d207a39f...b983e7e1721f
< bitcoin-git> bitcoin/master a2e581d Harris: build: Create test utility library from src/test/util/
< bitcoin-git> bitcoin/master b983e7e MarcoFalke: Merge #17542: build: Create test utility library from src/test/util/
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17542: build: Create test utility library from src/test/util/ (master...test-util-lib) https://github.com/bitcoin/bitcoin/pull/17542
< bitcoin-git> [bitcoin] Sjors closed pull request #17559: [build] travis: upgrade macOS image (master...2019/11/travis-macos-rvm) https://github.com/bitcoin/bitcoin/pull/17559
< bitcoin-git> [bitcoin] Sjors opened pull request #17559: [build] travis: upgrade rvm to avoid push crash (master...2019/11/travis-macos-rvm) https://github.com/bitcoin/bitcoin/pull/17559
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/69a6f1ad1f7c...a739d207a39f
< bitcoin-git> bitcoin/master e9a27cf Neha Narula: refactor: Remove unused COINBASE_FLAGS
< bitcoin-git> bitcoin/master a739d20 Wladimir J. van der Laan: Merge #17519: rpc: Remove unused COINBASE_FLAGS
< bitcoin-git> [bitcoin] laanwj merged pull request #17519: rpc: Remove unused COINBASE_FLAGS (master...removecoinbaseflags) https://github.com/bitcoin/bitcoin/pull/17519
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17558: build: organize tests by goal (master...2019/325/order-by-goal) https://github.com/bitcoin/bitcoin/pull/17558
< bitcoin-git> [bitcoin] jkczyz opened pull request #17557: util: Refactor message hashing into a utility function (master...2019-11-hash-message) https://github.com/bitcoin/bitcoin/pull/17557

2019-11-21

< bitcoin-git> [bitcoin] ryanofsky opened pull request #17556: Change feature_config_args.py not to rely on strange regtest=0 behavior (master...pr/wdpy) https://github.com/bitcoin/bitcoin/pull/17556
< bitcoin-git> [bitcoin] dspicher opened pull request #17555: test: add unit test for non-standard txs with wrong nVersion (master...isStandard-unittests) https://github.com/bitcoin/bitcoin/pull/17555
< bitcoin-git> [bitcoin] instagibbs opened pull request #17553: Remove out of date comments for CalculateMaximumSignedTxSize (master...calc_max_size_comment) https://github.com/bitcoin/bitcoin/pull/17553
< instagibbs_> gwillen, couple more if you're interested https://github.com/bitcoin/bitcoin/pull/17492
< wumpus> #topic Renewal of the Bitcoin Core Code Signing Apple Program (jonasschnelli)
< gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors . Pull Request #16944 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa . Pull Request #10785 . bitcoin/bitcoin . GitHub
< jonasschnelli> Renewal of the Bitcoin Core Code Signing Apple Programm
< wumpus> 8 blockers, 6 chasing concept ACK at https://github.com/bitcoin/bitcoin/projects/8
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/ae6943620ab3...69a6f1ad1f7c
< bitcoin-git> bitcoin/master 73b5505 Hennadii Stepanov: refactor: Move SendCoinsRecipient in own header
< bitcoin-git> bitcoin/master 567cb44 Hennadii Stepanov: refactor: Nuke guiutil circular dependency
< bitcoin-git> bitcoin/master 49c4211 Hennadii Stepanov: refactor: Nuke walletmodeltransaction circular dep
< bitcoin-git> [bitcoin] laanwj merged pull request #17513: refactor, qt: Nuke some circular dependencies (master...20191119-nuke-circular-dep) https://github.com/bitcoin/bitcoin/pull/17513
< amiti> emilengler: did you take a look at `test_runner.py`? you'll want to add your test there. see https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_runner.py#L76
< bitcoin-git> [bitcoin] brakmic opened pull request #17551: test: added test for RPCConvertNamedValues in rpc_tests (master...expanding-test-coverage) https://github.com/bitcoin/bitcoin/pull/17551
< bitcoin-git> [bitcoin] fanquake opened pull request #17550: build: set minimum supported macOS to 10.12 (master...macOS_10_12_minimum) https://github.com/bitcoin/bitcoin/pull/17550
< bitcoin-git> [bitcoin] fanquake closed pull request #17202: Travis CI bug in macOS environment #17178 workaround (master...issue#17178) https://github.com/bitcoin/bitcoin/pull/17202
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17549: ci: misc cleanups (master...1911-ciCleanups) https://github.com/bitcoin/bitcoin/pull/17549
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5ff798c39b8a...ae6943620ab3
< bitcoin-git> bitcoin/master fac07f2 MarcoFalke: node: Add reference to mempool in NodeContext
< bitcoin-git> bitcoin/master 8888ad0 MarcoFalke: test: Replace recursive lock with locking annotations
< bitcoin-git> bitcoin/master fa53881 MarcoFalke: scripted-diff: Replace ::mempool with m_node.mempool in tests
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17407: node: Add reference to mempool in NodeContext (master...1911-txPoolOptional) https://github.com/bitcoin/bitcoin/pull/17407
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b7bc9b833009...5ff798c39b8a
< bitcoin-git> bitcoin/master 402ee70 Hennadii Stepanov: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const
< bitcoin-git> bitcoin/master cb9d830 Hennadii Stepanov: test: Use proper MAX_SCRIPT_ELEMENT_SIZE
< bitcoin-git> bitcoin/master 5ff798c MarcoFalke: Merge #17439: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE constants consi...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17439: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE constants consistently (master...20191111-maxscriptelementsize-const) https://github.com/bitcoin/bitcoin/pull/17439
< gribble> https://github.com/bitcoin/bitcoin/issues/17513 | refactor, qt: Nuke some circular dependencies by hebasto . Pull Request #17513 . bitcoin/bitcoin . GitHub