< January 2025 >
Su Mo Tu We Th Fr Sa 12345678910111213141516 17 18
19 20 21 22 23 24 25
26 27 28 29 30 31
2019-08-01
< fanquake>
wumpus: yep QT_RCC_SOURCE_DATE_OVERRIDE fixed the issues with bitcoin-qt 🤦
< coinmonks>
I am online if anyone have any feedback,,or they can just leave private notes on the post itself.. thank you every one for contributing on Bitcoin.. :]
< bitcoin-git>
[bitcoin] meshcollider merged pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git>
bitcoin/master c5d3787 Andrew Chow: Allow createwallet to take empty passwords to make unencrypted wallets
< bitcoin-git>
bitcoin/master 6841b01 MeshCollider: Merge #16394: Allow createwallet to take empty passwords to make unencrypt...
< wumpus>
no, not using --prefix at the moment, I see a diffrence too between the same commits though, in bitcoin-qt but not bitcoind
< fanquake>
I've just done master (b7fbf74b980ebb122ae34b142f2cc49b44b92de3) and a dummy commit, still seeing the same difference in bitcoin-qt.
< wumpus>
i don't think i've ever used build-for-compare with bitcoin-qt, at all
< fanquake>
Doing a binary comparison of a bitcoin-qt built from HEAD~1 and HEAD~2, building on Debian using depends. Currently seeing this diff: https://gist.github.com/fanquake/653bb42176d7772578db08a0f8e60f11 . Any suggestions as to what could be causing the difference? bitcoind matches.
< bitcoin-git>
[bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
< bitcoin-git>
bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
< bitcoin-git>
bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
< bitcoin-git>
bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git>
[bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git>
[bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
< emilengler>
wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
< bitcoin-git>
[bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< sdaftuar>
on the bitcoin main chain, this is not actually a problem (modulo the hypothetical future problem we can have after block 1.9M or whatever it is)
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git>
bitcoin/master 80ba424 Amiti Uttarwar: extract min & max depth onto coin control
< bitcoin-git>
bitcoin/master 00922b8 Wladimir J. van der Laan: Merge #15906: [wallet] Move min_depth and max_depth to coin control
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git>
[bitcoin] promag opened pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
2019-07-30
< bitcoin-git>
[bitcoin] ariard opened pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503
< fanquake>
In newer versions of Xcode some of the headers our depends packages rely on aren’t where they used to be, and there a a script you can run that’ll put them back. See this comment: https://github.com/bitcoin/bitcoin/pull/16392#issuecomment-515268092 and the one I’m referencing.
< bitcoin-git>
[bitcoin] promag closed pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< bitcoin-git>
[bitcoin] ronaldstoner closed pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git>
[bitcoin] ronaldstoner opened pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git>
[bitcoin] instagibbs opened pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< emilengler>
I don't get where the bitcoin-qt rpc console detecs when Ctrl-L is being pressed? With the help of the grep command I've only found the way how Ctrl-Q is being handled. Can someone tell me where I find it?
< gribble>
https://github.com/bitcoin/bitcoin/issues/16433 | txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN by MarcoFalke · Pull Request #16433 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] TheBlueMatt reopened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
< BlueMatt>
jonasschnelli: to answer your question, in a general case, the way you write a network layer (eg the way bitcoin core does it today) is step 1) read message header, step 2) check stuff about the header, step 3) allocate buffer for the size it told you, step 4) read message. this keeps things nice and simple, you dont have much allocation complexity and you avoid most buffer overflow issues if you misallocate in your network stack.
< bitcoin-git>
[bitcoin] promag opened pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< elichai2>
oh. but they will need to implement the variable size type/functions anyway for the rest of the stuff in bitcoin. so why not use the same type we use everywhere?
< bitcoin-git>
bitcoin/master 0c78e49 practicalswift: tests: Switch one of the Travis jobs to an unsigned char environment (-fun...
< bitcoin-git>
bitcoin/master 74f1a27 Wladimir J. van der Laan: Merge #15134: tests: Switch one of the Travis jobs to an unsigned char env...
< bitcoin-git>
[bitcoin] laanwj merged pull request #15134: tests: Switch one of the Travis jobs to an unsigned char environment (-funsigned-char) (master...unsigned-char) https://github.com/bitcoin/bitcoin/pull/15134
< kallewoof>
achow101: https://github.com/bitcoin/bitcoin/pull/16440#discussion_r308332901 I basically need the wallet interface to give me a way to sign things from the QT side, and this was the only approach I could think of. sipa suggested I ping you to make sure I wasn't trampling on stuff with the descriptor wallet changes you are working on.
< bitcoin-git>
[bitcoin] pstratem opened pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
< bitcoin-git>
[bitcoin] laanwj merged pull request #16436: gui: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
< bitcoin-git>
[bitcoin] laanwj merged pull request #15993: net: Drop support of the insecure miniUPnPc versions (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
< bitcoin-git>
[bitcoin] fanquake closed pull request #13357: Define SIGHASH_MASK in validation and determine the use of SIGHASH_SINGLE in signing (master...signsingle) https://github.com/bitcoin/bitcoin/pull/13357
< bitcoin-git>
[bitcoin] fanquake closed pull request #15104: Tests: Add unit testing for the CompressScript function (master...compress_contract_test3) https://github.com/bitcoin/bitcoin/pull/15104
< bitcoin-git>
[bitcoin] fanquake closed pull request #15052: Tests: Contract testing for the procedure AddTimeData and related fixes (master...timedata_contract_test2) https://github.com/bitcoin/bitcoin/pull/15052
< bitcoin-git>
[bitcoin] fanquake opened pull request #16477: build: skip deploying plugins we dont use in macdeployqtplus (master...slim_macdeployqtplus) https://github.com/bitcoin/bitcoin/pull/16477
< bitcoin-git>
[bitcoin] hebasto opened pull request #16476: Use ArgsManager::ALLOW_STRING flag explicitly (master...20190727-pr16097-new-flags) https://github.com/bitcoin/bitcoin/pull/16476
< emilengler>
Where do I find the bitcoin-qt binary when I compile with --with-gui?
< bitcoin-git>
bitcoin/master b3d4f6c Andrew Chow: Log the actual wallet file version
< bitcoin-git>
bitcoin/master 35e60e7 Andrew Chow: Remove ReadVersion and WriteVersion
< bitcoin-git>
[bitcoin] meshcollider merged pull request #15588: Log the actual wallet file version and no longer publicly expose the "version" record (master...rm-wallet-nfileversion) https://github.com/bitcoin/bitcoin/pull/15588
< bitcoin-git>
[bitcoin] hebasto closed pull request #16469: refactoring: Use direct list initialization for Arg struct (master...20190726-remove-arg-ctor) https://github.com/bitcoin/bitcoin/pull/16469
2019-07-26
< bitcoin-git>
[bitcoin] jnewbery opened pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16470: test: Fail early on disconnect in mininode.wait_for_* (master...1907-testMininodeNoWaitOnDisconnect) https://github.com/bitcoin/bitcoin/pull/16470
< bitcoin-git>
[bitcoin] hebasto opened pull request #16469: refactoring: Use direct list initialization for Arg struct (master...20190726-remove-arg-ctor) https://github.com/bitcoin/bitcoin/pull/16469
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | WIP: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #16464: [qa] Ensure we don't generate a too-big block in p2sh sigops test (master...2019-07-fix-feature-block) https://github.com/bitcoin/bitcoin/pull/16464
< bitcoin-git>
[bitcoin] achow101 opened pull request #16463: [BIP 174] Implement serialization support for GLOBAL_XPUB field. (master...bip174-xpub) https://github.com/bitcoin/bitcoin/pull/16463
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #16453: WIP: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16455: doc: Remove downgrading warning in release notes, per 0.18 branch (master...1907-docReleaseNotes) https://github.com/bitcoin/bitcoin/pull/16455
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16453: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453