2017-08-10

< wumpus> also in principle you can run all the functional tests with bitcoin-qt instead of bitcoind (but that's not useful for travis :-)
< wumpus> if the test is not interested in windowed output w/ QT_QPA_PLATFORM=minimal you can avoid the X dependency, this is what the bitcoin-qt unit-tests in src/qt/test do
< aj> wumpus: hmm, can travis start qt/bitcoin, or would local-only tests be sufficient at least to start?
< bitcoin-git> [bitcoin] kallewoof opened pull request #11019: [wallet] Abandon transactions that fail to go into the mempool (master...abandon-longchain-failed-tx) https://github.com/bitcoin/bitcoin/pull/11019

2017-08-09

< chainhead> bitcore is not from bitcoin core
< smill> Hello, I have a problem using bitcore-wallet-service and insight-api, I have everything working with bitcoind from bitcoin-0.12.1 bitcore build (the one that gets installed if you follow the dosc) but im trying to get the new release working from https://github.com/bitpay/bitcoin/releases and im basically having the same problem as this guy https://github.com/bitpay/insight-ui/issues/746 and there are no answers yet
< bitcoin-git> [bitcoin] achow101 closed pull request #10900: [0.14] Enforce segsignal activation height and rules (0.14...early-uasf-bip91) https://github.com/bitcoin/bitcoin/pull/10900
< bitcoin-git> [bitcoin] jameshilliard closed pull request #10444: Implement BIP91 Reduced threshold Segwit MASF (0.14...segsignal-v0.14.1) https://github.com/bitcoin/bitcoin/pull/10444
< bitcoin-git> bitcoin/master e526ca6 MarcoFalke: Merge #10835: Rename member field according to the style guide...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10835: Rename member field according to the style guide (master...20170715_Wshadow_reverseiterator) https://github.com/bitcoin/bitcoin/pull/10835
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67f6f1c2d5c8...e526ca6284b9
< bitcoin-git> bitcoin/master 4d4fb33 Pavel Janík: Rename member field according to the style guide.
< gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10996 | [WIP] Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 67f6f1c Wladimir J. van der Laan: qt: Periodic translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/67f6f1c2d5c826d3062cb6b5c5d91190d1adcb76
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision (master...restore-format-state-of-cout) https://github.com/bitcoin/bitcoin/pull/10963
< bitcoin-git> bitcoin/master ecd2135 MarcoFalke: Merge #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision...
< bitcoin-git> bitcoin/master fd05132 practicalswift: Restore default format state of cout after printing with std::fixed/setprecision
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4b5a7ce0c301...ecd21357f161
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11003: Docs: Capitalize bullet points in CONTRIBUTING guide (master...contributing_grammar) https://github.com/bitcoin/bitcoin/pull/11003
< bitcoin-git> bitcoin/master 13b1e9a Evan Klitzke: Capitalize bullet points in CONTRIBUTING guide...
< bitcoin-git> bitcoin/master 4b5a7ce MarcoFalke: Merge #11003: Docs: Capitalize bullet points in CONTRIBUTING guide...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/929fd7276c0f...4b5a7ce0c301
< bitcoin-git> [bitcoin] kallewoof opened pull request #11017: [wallet] Close DB on error. (master...close-dbenv) https://github.com/bitcoin/bitcoin/pull/11017
< bitcoin-git> [bitcoin] lclc opened pull request #11015: [Qt] Search TX: Add delay before filtering (master...searchDelay) https://github.com/bitcoin/bitcoin/pull/11015
< bitcoin-git> [bitcoin] eklitzke closed pull request #10880: Update .gitignore to ignore more test files (master...gitignore) https://github.com/bitcoin/bitcoin/pull/10880
< bitcoin-git> [bitcoin] eklitzke opened pull request #11013: Build: Fix Automake warnings when running autogen.sh (master...override_gzip_env) https://github.com/bitcoin/bitcoin/pull/11013
< bitcoin-git> [bitcoin] eklitzke closed pull request #11005: Tests: Add a lint check for trailing whitespace (master...whitespace) https://github.com/bitcoin/bitcoin/pull/11005
< bitcoin-git> [bitcoin] theuni opened pull request #11012: Make sure to clean up mapBlockSource if we've already seen the block (master...cleanup-blocksource) https://github.com/bitcoin/bitcoin/pull/11012
< earlz> regarding std::string ABI stuff, would that really matter that much? I know compiling Bitcoin outside of Gitian (ie with system deps) works fine in every version of GCC I've tried
< earlz> My concern isn't bitcoin itself, but rather it's dependencies will start using C++11 features, making for more and more patches being required for gitian compiles

2017-08-08

< bitcoin-git> [bitcoin] gmaxwell opened pull request #11011: [Trivial] Add a comment on the use of prevector in script. (master...201708-prevector-comment) https://github.com/bitcoin/bitcoin/pull/11011
< bitcoin-git> [bitcoin] rawodb closed pull request #11010: Add information about the next state in getblockchaininfo rpc request (master...pr/getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/11010
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10695: [qa] Rewrite BIP65/BIP66 functional tests (master...2017-06-fix-bip65-test) https://github.com/bitcoin/bitcoin/pull/10695
< bitcoin-git> bitcoin/master 929fd72 MarcoFalke: Merge #10695: [qa] Rewrite BIP65/BIP66 functional tests...
< bitcoin-git> bitcoin/master 4ccc12a Suhas Daftuar: [qa] Rewrite BIP66 functional tests...
< bitcoin-git> bitcoin/master d4f0d87 Suhas Daftuar: [qa] Rewrite BIP65 functional tests...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2507fd55568b...929fd7276c0f
< bitcoin-git> [bitcoin] rawodb opened pull request #11010: Add information about the next state in getblockchaininfo rpc request (master...pr/getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/11010
< sdaftuar> that way if someone wants to write a bitcoin network client that only worries about one of those properties, they don't need to do any complicated reasoning
< bitcoin-git> [bitcoin] rawodb closed pull request #11009: Add information about the next state in getblockchaininfo rpc request (master...master) https://github.com/bitcoin/bitcoin/pull/11009
< bitcoin-git> [bitcoin] rawodb opened pull request #11009: Add information about the next state in getblockchaininfo rpc request (master...master) https://github.com/bitcoin/bitcoin/pull/11009
< bitcoin-git> [bitcoin] gmaxwell opened pull request #11008: Enable disablesafemode by default. (master...no-safe-mode) https://github.com/bitcoin/bitcoin/pull/11008
< gribble> https://github.com/bitcoin/bitcoin/issues/10695 | [qa] Rewrite BIP65/BIP66 functional tests by sdaftuar · Pull Request #10695 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< Chris_Stewart_5> ancient in terms of bitcoin! :P
< bitcoin-git> [bitcoin] practicalswift opened pull request #11007: [qt] Fix memory leak when loading a corrupted wallet file (master...wallet-corrupted-leak) https://github.com/bitcoin/bitcoin/pull/11007
< gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10982 | Disconnect network service bits 6 and 8 until Aug 1, 2018 by TheBlueMatt · Pull Request #10982 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10870 | [Qt] Use wallet 0 in rpc console if running with multiple wallets by jonasschnelli · Pull Request #10870 · bitcoin/bitcoin · GitHub
< gmaxwell> luke-jr: bitcoin cli works, and many other things are easy to get working...
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10989 | RPC: Restore backward compatibility, in multiwallet mode by luke-jr · Pull Request #10989 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10607 | scripted-diff: stop using the gArgs wrappers by benma · Pull Request #10607 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10483 | scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL by practicalswift · Pull Request #10483 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10998: Fix upgrade cancel warnings (master...2017-08-fix-upgrade-cancel-warnings) https://github.com/bitcoin/bitcoin/pull/10998
< bitcoin-git> bitcoin/master 2507fd5 Wladimir J. van der Laan: Merge #10998: Fix upgrade cancel warnings...
< bitcoin-git> bitcoin/master 861f9a2 Matt Corallo: Skip remainder of init if upgrade is cancelled
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4268426b4500...2507fd55568b
< bitcoin-git> [bitcoin] laanwj closed pull request #11002: [wallet] return correct error code from resendwallettransaction (master...resendwallettransaction_error_code) https://github.com/bitcoin/bitcoin/pull/11002
< bitcoin-git> bitcoin/master 4268426 Wladimir J. van der Laan: Merge #11002: [wallet] return correct error code from resendwallettransaction...
< bitcoin-git> bitcoin/master 055d95f John Newbery: [wallet] return correct error code from resendwallettransaction
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/627c3c0e495b...4268426b4500
< bitcoin-git> [bitcoin] laanwj closed pull request #10999: Fix amounts formatting in `decoderawtransaction` (master...2017_08_decoderawtx_amount) https://github.com/bitcoin/bitcoin/pull/10999
< bitcoin-git> bitcoin/master ec05c50 Wladimir J. van der Laan: rpc: Use ValueFromAmount instead of FormatMoney in TxToUniv...
< bitcoin-git> bitcoin/master dac3782 Wladimir J. van der Laan: doc: Correct AmountFromValue/ValueFromAmount names
< bitcoin-git> bitcoin/master 46347ad Wladimir J. van der Laan: rpc: Move ValueFromAmount to core_write...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa8a0639f7b0...627c3c0e495b
< gribble> https://github.com/bitcoin/bitcoin/issues/10982 | Disconnect network service bits 6 and 8 until Aug 1, 2018 by TheBlueMatt · Pull Request #10982 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #11006: WIP: Improve shutdown process (master...201708-fast-shutdown) https://github.com/bitcoin/bitcoin/pull/11006
< bitcoin-git> [bitcoin] eklitzke opened pull request #11005: Tests: Add a lint check for trailing whitespace (master...whitespace) https://github.com/bitcoin/bitcoin/pull/11005

2017-08-07

< LordCow> bitcoin-cli getchaintips
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11001: [tests] Test disconnecting unsupported service bits logic. (master...unsupported_service_bits_test) https://github.com/bitcoin/bitcoin/pull/11001
< bitcoin-git> bitcoin/master 5e35cd9 John Newbery: [tests] Test disconnecting unsupported service bits logic....
< bitcoin-git> bitcoin/master fa8a063 MarcoFalke: Merge #11001: [tests] Test disconnecting unsupported service bits logic....
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/318392ca7cda...fa8a0639f7b0
< bitcoin-git> [bitcoin] eklitzke opened pull request #11003: Docs: Capitalize bullet points in CONTRIBUTING guide (master...contributing_grammar) https://github.com/bitcoin/bitcoin/pull/11003
< gribble> https://github.com/bitcoin/bitcoin/issues/11000 | test: Add resendwallettransactions functional tests by promag · Pull Request #11000 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9889 | TODO for release notes 0.15.0 · Issue #9889 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #11002: [wallet] return correct error code from resendwallettransaction (master...resendwallettransaction_error_code) https://github.com/bitcoin/bitcoin/pull/11002
< gribble> https://github.com/bitcoin/bitcoin/issues/10200 | Mining: Skip recent transactions if fee difference is small by sdaftuar · Pull Request #10200 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #11001: [tests] Test disconnecting unsupported service bits logic. (master...unsupported_service_bits_test) https://github.com/bitcoin/bitcoin/pull/11001
< gribble> https://github.com/bitcoin/bitcoin/issues/11000 | test: Add resendwallettransactions functional tests by promag · Pull Request #11000 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
< bitcoin-git> bitcoin/master 318392c Wladimir J. van der Laan: Merge #10301: Check if sys/random.h is required for getentropy....
< bitcoin-git> bitcoin/master ee2d10a James Hilliard: Check if sys/random.h is required for getentropy on OSX.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa646369489d...318392ca7cda
< bitcoin-git> [bitcoin] promag opened pull request #11000: test: Add resendwallettransactions functional tests (master...201708-resendwallettransactions-test) https://github.com/bitcoin/bitcoin/pull/11000
< gribble> https://github.com/bitcoin/bitcoin/issues/10301 | Check if sys/random.h is required for getentropy. by jameshilliard · Pull Request #10301 · bitcoin/bitcoin · GitHub
< wumpus> we started always returning 8 decimals in this commit in july 2015, https://github.com/bitcoin/bitcoin/commit/e061e2778d592826970483e0844308c4e9a12626
< bitcoin-git> [bitcoin] laanwj opened pull request #10999: Fix amounts formatting in `decoderawtransaction` (master...2017_08_decoderawtx_amount) https://github.com/bitcoin/bitcoin/pull/10999
< gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
< wumpus> seems I found the bug in #10952: https://github.com/bitcoin/bitcoin/pull/10952/files#r131637416
< gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
< bitcoin-git> bitcoin/master fa64636 Wladimir J. van der Laan: Merge #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c1c671feb163...fa646369489d
< bitcoin-git> bitcoin/master 01699fb Matt Corallo: Fix resendwallettransactions assert failure if -walletbroadcast=0
< bitcoin-git> [bitcoin] laanwj closed pull request #10919: Fix more init bugs. (master...2017-07-init-bugs) https://github.com/bitcoin/bitcoin/pull/10919
< bitcoin-git> bitcoin/master 13ab353 Matt Corallo: Check for empty coinsview instead of just-reset coinsview in init...
< bitcoin-git> bitcoin/master efac91e Matt Corallo: Always wait for threadGroup to exit in bitcoind shutdown...
< bitcoin-git> bitcoin/master fce3f4f Matt Corallo: Fix resume-of-reindex-after-restart...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8b62c7de3d4...c1c671feb163
< bitcoin-git> [bitcoin] laanwj closed pull request #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018 (master...2017-08-bad-service-bits) https://github.com/bitcoin/bitcoin/pull/10982
< bitcoin-git> bitcoin/master c8b62c7 Wladimir J. van der Laan: Merge #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018...
< bitcoin-git> bitcoin/master 1de73f4 Matt Corallo: Disconnect network service bits 6 and 8 until Aug 1, 2018...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9dd11144152...c8b62c7de3d4
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10998: 2017 08 fix upgrade cancel warnings (master...2017-08-fix-upgrade-cancel-warnings) https://github.com/bitcoin/bitcoin/pull/10998

2017-08-06

< r251d> "Fork address versions" https://github.com/btc1/bitcoin/issues/101
< bitcoin-git> [bitcoin] jharvell opened pull request #10997: Add option -stdinrpcpass to allow RPC password to be read from stdin (master...stdinrpcpass) https://github.com/bitcoin/bitcoin/pull/10997
< gribble> https://github.com/bitcoin/bitcoin/issues/10982 | Disconnect network service bits 6 and 8 until Aug 1, 2018 by TheBlueMatt · Pull Request #10982 · bitcoin/bitcoin · GitHub
< wumpus> there is #bitcoin-dev that is more general
< wumpus> bryyan: this channel is specifically for "bitcoin core", the c++ implementation, it has a very narrow scope on purpose to make sure the scrollback is relevant to the devs here
< gmaxwell> the discussion is also an oppturnity to make it clear that Bitcoin developers don't support s2x... there are still some people going along spreading the idea that we'll somehow be going along with it.

2017-08-05

< arubi> sipa, would be cool to have the .conf file per network. I do this now with shell functions and I'd love if it would be a part of the original bitcoin.conf. makes it much simpler to version control
< gribble> https://github.com/bitcoin/bitcoin/issues/8175 | gitian: Add --disable-bench to config flags for windows by laanwj · Pull Request #8175 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ajtowns opened pull request #10996: [WIP] Add per-network config file network.conf (master...netconf) https://github.com/bitcoin/bitcoin/pull/10996
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
< bitcoin-git> [bitcoin] ajtowns opened pull request #10994: Add option to avoid warning on certain network upgrades (master...ignore-vbits) https://github.com/bitcoin/bitcoin/pull/10994
< gmaxwell> Symptom is that bitcoin core rejects the private keys as invalid, which they are.
< bitcoin-git> [bitcoin] laanwj closed pull request #10988: qt: Increase BLOCK_CHAIN_SIZE constants (master...2017_08_qt_block_chain_size) https://github.com/bitcoin/bitcoin/pull/10988
< bitcoin-git> bitcoin/master a9dd111 Wladimir J. van der Laan: Merge #10988: qt: Increase BLOCK_CHAIN_SIZE constants...
< bitcoin-git> bitcoin/master 1967d2a Wladimir J. van der Laan: qt: Increase BLOCK_CHAIN_SIZE constants...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/02f4c4a42e94...a9dd11144152
< bitcoin-git> [bitcoin] laanwj closed pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git> bitcoin/master 02f4c4a Wladimir J. van der Laan: Merge #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)...
< bitcoin-git> bitcoin/master 11dd29b practicalswift: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88b1e4bc0e36...02f4c4a42e94
< bitcoin-git> [bitcoin] laanwj closed pull request #10971: build: fix missing sse42 in depends builds (master...fix-config-override) https://github.com/bitcoin/bitcoin/pull/10971
< bitcoin-git> bitcoin/master 88b1e4b Wladimir J. van der Laan: Merge #10971: build: fix missing sse42 in depends builds...
< bitcoin-git> bitcoin/master 9baca41 Cory Fields: build: always attempt to enable targeted sse42 cxxflags...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2361208424de...88b1e4bc0e36
< bitcoin-git> [bitcoin] laanwj closed pull request #10986: Update chain transaction statistics (master...20170803_txstats) https://github.com/bitcoin/bitcoin/pull/10986
< bitcoin-git> bitcoin/master 2361208 Wladimir J. van der Laan: Merge #10986: Update chain transaction statistics...
< bitcoin-git> bitcoin/master b1973d6 Pieter Wuille: Update chain transaction statistics
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d896d5cc4274...2361208424de
< bitcoin-git> [bitcoin] laanwj closed pull request #10985: Add undocumented -forcecompactdb to force LevelDB compactions (master...20170803_forcecompactdb) https://github.com/bitcoin/bitcoin/pull/10985
< bitcoin-git> bitcoin/master 8842d1a Pieter Wuille: Add undocumented -forcecompactdb to force LevelDB compactions
< bitcoin-git> bitcoin/master d896d5c Wladimir J. van der Laan: Merge #10985: Add undocumented -forcecompactdb to force LevelDB compactions...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e222618a32a1...d896d5cc4274
< wumpus> people that were still running that, despite repeatedly being told not to use it for bitcoin, have probably lost their coins
< gribble> https://github.com/bitcoin/bitcoin/issues/7142 | Travis: Test build against system Qt4 by luke-jr · Pull Request #7142 · bitcoin/bitcoin · GitHub

2017-08-04

< bitcoin-git> [bitcoin] gandrewstone opened pull request #10990: 0 locktime issue (master...fix0locktimebug) https://github.com/bitcoin/bitcoin/pull/10990
< gribble> https://github.com/bitcoin/bitcoin/issues/9889 | TODO for release notes 0.15.0 · Issue #9889 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #10989: RPC: Restore backward compatibility, in multiwallet mode (master...multiwallet_rpccompat) https://github.com/bitcoin/bitcoin/pull/10989
< bitcoin-git> [bitcoin] laanwj opened pull request #10988: qt: Increase BLOCK_CHAIN_SIZE constants (master...2017_08_qt_block_chain_size) https://github.com/bitcoin/bitcoin/pull/10988
< Chicago> Well, you know once the base image is built; it could be a few weeks between Bitcoin release cycles; and so it has to build the dependency graph and do the package installations deterministically such that if you built an image last month with Trusty and I built an image today with Trusty, we both end up getting the exact same depgraph when we go to build everything.
< gmaxwell> (not that bch is even the first altcoin to airdrop on bitcoin users, just the first with a highly funded marketing effort behind it)
< goatpig> Bitcoin is unaffected though
< timothy> gmaxwell: the real problem is that the broken forks (aka abc) uses the bitcoin-core data directory
< Chicago> yeah, looks like he got to it 15 minutes ago on the Bitcoin subreddit
< Chicago> venzen, I would presume the bitcoin.org (over HTTPS) hosted key is an order of magnitude more trustworthy than anything you randomly find by looking for a short string at the MIT PGP server.
< venzen> Chicago: thanks, I'll post the link you provide to the r/bitcoin post. The OP seems to be confused and I figured wumpus should be aware of the post
< Chicago> venzen, another place to find keys to import is over here, https://github.com/bitcoin/bitcoin/tree/master/contrib/gitian-keys

2017-08-03

< gribble> https://github.com/bitcoin/bitcoin/issues/10985 | Add undocumented -forcecompactdb to force LevelDB compactions by sipa · Pull Request #10985 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #10986: Update chain transaction statistics (master...20170803_txstats) https://github.com/bitcoin/bitcoin/pull/10986
< bitcoin-git> [bitcoin] sipa opened pull request #10985: Add undocumented -forcecompactdb to force LevelDB compactions (master...20170803_forcecompactdb) https://github.com/bitcoin/bitcoin/pull/10985
< gribble> https://github.com/bitcoin/bitcoin/issues/10756 | net processing: swap out signals for an interface class by theuni · Pull Request #10756 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10984: Allow 2 simultaneous (compact-)block downloads (master...2017-08-paralell-block-downloads) https://github.com/bitcoin/bitcoin/pull/10984
< wumpus> Cobra-Bitcoin: more (trusted) places to get the binaries from gives some redundancy
< wumpus> Cobra-Bitcoin: hosting on both bitcoin.org and bitconcore.org is perfectly acceptable, preferable even IMO
< BlueMatt> Cobra-Bitcoin: see pm
< Cobra-Bitcoin> But is bitcoin.org not doing enough to already distribute the binaries effectively?
< Cobra-Bitcoin> We have no choice but to mirror, since we have a lot of pages structured around the binaries and Core
< gribble> https://github.com/bitcoin/bitcoin/issues/10651 | Verify binaries from bitcoincore.org and bitcoin.org by TheBlueMatt · Pull Request #10651 · bitcoin/bitcoin · GitHub
< BlueMatt> Cobra-Bitcoin: see-also #10651
< BlueMatt> Cobra-Bitcoin: that is the intention, yes, I mailed you about this a while back :). I think the goal is to start pointing people to bitcoincore.org, but also sicne y'all wanted to keep mirroring on bitcoin.org (and cause no point telling people to go somewhere else if they're already used to bitcoin.org), they'd be in both places
< Cobra-Bitcoin> So the release notes will point users to bitcoincore.org binaries?
< Cobra-Bitcoin> Anyone know what btcdrak means when he says "future releases will be linked" here https://github.com/bitcoin-core/bitcoincore.org/issues/33?
< Cobra-Bitcoin> Any core dev around?
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018 (master...2017-08-bad-service-bits) https://github.com/bitcoin/bitcoin/pull/10982
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell> At the end we're doing them a favor, there are a lot more bitcoin nodes than random altcoin nodes, so these incorrect connections tend to cause them a lot more problems than us.
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell> what? no. matt, doing that will ban Bitcoin Core users when someone on the same IP ran crapware.
< gribble> https://github.com/bitcoin/bitcoin/issues/10981 | resendwallettransactions asserts if walletbroadcast=0 · Issue #10981 · bitcoin/bitcoin · GitHub
< karelb> OK, maybe I will ask here. What format are the bitcoin .dat files in data/blocks/*.dat? is that leveldb? what is it exactly?
< gribble> https://github.com/bitcoin/bitcoin/issues/10971 | build: fix missing warnings and sse42 in depends builds by theuni · Pull Request #10971 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10832 | init: Factor out AppInitLockDataDirectory and fix startup core dump issue by laanwj · Pull Request #10832 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10919 | Fix more init bugs. by TheBlueMatt · Pull Request #10919 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10919 | Fix more init bugs. by TheBlueMatt · Pull Request #10919 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
< earlz> yea, I'm not understanding where that gets created in the guide. Last time I setup gitian it was for Bitcoin 0.9 so not sure what all has changed since then
< BlueMatt> Make Bitcoin Great Again: Bring back Pay-2-IP
< wumpus> though if a wallet gets corrupted that's a good indication you should stop using that computer for bitcoin, now
< BlueMatt> achow101: if you have a wallet with keys, and a default key that is invalid or missing, your wallet was clearly either corrupted or generated by something other than bitcoin core
< karelb> ok we got abc node working, but it was some crazy solution of switching between various binaries and invalidating nodes; it did not crash (yet). But it seems that bitcore patches inside connectblock/disconnectblock are really not the way for the future; it will probably break again (both in abc and later in bitcoin core once you release the db changes)
< gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10980: [WIP] Decouple CKeyStore from CWatchOnlyStore (master...decouplewatchonly) https://github.com/bitcoin/bitcoin/pull/10980
< bitcoin-git> [bitcoin] laanwj closed pull request #10851: depends: fix fontconfig with newer glibc (master...fontconfig-bump) https://github.com/bitcoin/bitcoin/pull/10851
< bitcoin-git> bitcoin/master e222618 Wladimir J. van der Laan: Merge #10851: depends: fix fontconfig with newer glibc...
< bitcoin-git> bitcoin/master 3498a8d Cory Fields: depends: fix fontconfig with newer glibc...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e857bb619f5...e222618a32a1
< karelb> I am actually talking about ABC, but the same issue crops up in bitcoin, plus it might be because ABC added some db logic from master
< karelb> it must be because of the address index somehow, because on the same PC, bitcoin core without bitcore (sigh) patches runs fine
< bitcoin-git> [bitcoin] laanwj closed pull request #10942: Eliminate fee overpaying edge case when subtracting fee from recipients (master...subtractfee) https://github.com/bitcoin/bitcoin/pull/10942
< bitcoin-git> bitcoin/master 2e857bb Wladimir J. van der Laan: Merge #10942: Eliminate fee overpaying edge case when subtracting fee from recipients...
< bitcoin-git> bitcoin/master 49d903e Alex Morcos: Eliminate fee overpaying edge case when subtracting fee from recipients
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/659c09613408...2e857bb619f5
< gmaxwell> karelb: the challenge there is that we have insanely optimized bitcoin core's sync process.. we avoid writing to leveldb at all costs, basically, and a significant fraction of UTXO never hit the database at all during normal sync because they're spent before the dbcache fills)
< karelb> and normal bitcoin without bitcore patches doesn't do it, on the same HW
< Austindoggie> Did it take a long time to reindex because you went back a version of bitcoin core?
< gmaxwell> karelb: bitcoin core master changed the atomiticity requirements for the backend database, but a side effect of this is that it needs special replay logic to handle crash recovery. ABC has partially ported some of these changes. I am not sure, but I wouldn't be surprised if the address indexing would get corrupted until updated to have the right synchronization behavior.
< gmaxwell> karelb: probably code based on Bitcoin Core master (including ABC) will not be reliably compatible with that address indexing stuff until it is changed.
< karelb> actually one issue was sort-of ABC related, but it was because of a commit ported from master from bitcoin core, so it will be relevant anyway
< karelb> (It is actually bitcoin-abc, I hope I won't be banned :D, but this issue popped up in bitcoin core too)
< karelb> but right now we are reindexing bitcoin blockchain and it takes foreved
< gmaxwell> Hi all, karelb is working on the trezor wallet, and they've been trying to use these patches to bitcoin that implement the bitcore address indexing stuff, but they're finding it really slow to the point where performance is problematic.
< praxeology> HKEY_CURRENT_USER\Software\Bitcoin\Bitcoin-Qt
< praxeology> does bitcoin still use windows registry?
< praxeology> alright... well, its unfortunate I misdiagnosed the guy's issue. Thanks for the help. Hopefully he will come back and ask again on #bitcoin and one of sees him... for his sake... before he -reindex
< praxeology> when bitcoin starts up, it only chooses one peer to ask for latest headers?
< praxeology> ok. james0909 in #bitcoin said his error log said... "ERROR: invalid header received 2017-08-03 01:48:18 ProcessMessages(headers, 11422 bytes) FAILED peer=38"? and his tip was stuck at 478645.
< instagibbs> james0909, #bitcoin please, someone can help there
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub

2017-08-02

< bitcoin-git> [bitcoin] practicalswift opened pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
< bitcoin-git> [bitcoin] practicalswift opened pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
< bitcoin-git> [bitcoin] laanwj closed pull request #10958: Update to latest Bitcoin patches for LevelDB (master...20170731_leveldb) https://github.com/bitcoin/bitcoin/pull/10958
< bitcoin-git> bitcoin/master 659c096 Wladimir J. van der Laan: Merge #10958: Update to latest Bitcoin patches for LevelDB...
< bitcoin-git> bitcoin/master 47f3e8c Pieter Wuille: Update LevelDB with latest Bitcoin-specific patches
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0579bfea1db...659c09613408
< bitcoin-git> bitcoin/master b13a68e Pieter Wuille: Squashed 'src/leveldb/' changes from 196962ff0..c521b3ac6...
< bitcoin-git> [bitcoin] laanwj closed pull request #10974: Fix typo in sendcoinsdialog. (master...fix-typo-in-sendcoindialog) https://github.com/bitcoin/bitcoin/pull/10974
< bitcoin-git> bitcoin/master 7f121a0 Masahiko Hyuga: Fix typo in sendcoinsdialog.
< bitcoin-git> bitcoin/master f0579bf Wladimir J. van der Laan: Merge #10974: Fix typo in sendcoinsdialog....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f66c59650527...f0579bfea1db
< bitcoin-git> [bitcoin] visvirial opened pull request #10974: Fix typo in sendcoinsdialog. (master...fix-typo-in-sendcoindialog) https://github.com/bitcoin/bitcoin/pull/10974
< gmaxwell> https://github.com/bitcoin/bitcoin/pull/10195 might be what you were looking for

2017-08-01

< bitcoin-git> [bitcoin] ryanofsky opened pull request #10973: WIP: Add IPC layer between node and wallet (master...pr/wipc-sep) https://github.com/bitcoin/bitcoin/pull/10973
< earlz> Has anyone successfully cross-compiled Bitcoin Core for a raspberry pi? If so, is that process documented somewhere?
< bitcoin-git> [bitcoin] practicalswift opened pull request #10972: Check return value of addr.GetKeyID(keyid) on custom change address change (master...GetKeyID-assertion) https://github.com/bitcoin/bitcoin/pull/10972
< bitcoin-git> [bitcoin] theuni opened pull request #10971: build: fix missing warnings and sse42 in depends builds (master...fix-config-override) https://github.com/bitcoin/bitcoin/pull/10971
< bitcoin-git> [bitcoin] laanwj closed pull request #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature (master...fix-addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/10788
< bitcoin-git> bitcoin/master f66c596 Wladimir J. van der Laan: Merge #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature...
< bitcoin-git> bitcoin/master e222dc2 Andrew Chow: Replace ismine with producesignature check in witnessifier...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/754aa02b8a72...f66c59650527
< bitcoin-git> [bitcoin] practicalswift opened pull request #10969: Declare single-argument (non-converting) constructors "explicit" (master...explicit) https://github.com/bitcoin/bitcoin/pull/10969
< bitcoin-git> [bitcoin] laanwj closed pull request #10526: Force on-the-fly compaction during pertxout upgrade (master...compactrange) https://github.com/bitcoin/bitcoin/pull/10526
< bitcoin-git> bitcoin/master 754aa02 Wladimir J. van der Laan: Merge #10526: Force on-the-fly compaction during pertxout upgrade...
< bitcoin-git> bitcoin/master efeb273 Pieter Wuille: Force on-the-fly compaction during pertxout upgrade
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd924241e7dc...754aa02b8a72
< bitcoin-git> [bitcoin] laanwj closed pull request #10758: Fix some chainstate-init-order bugs. (master...2014-07-nonatomic-flush-fixes) https://github.com/bitcoin/bitcoin/pull/10758
< bitcoin-git> bitcoin/master ff3a219 Matt Corallo: Call RewindBlockIndex even if we're about to run -reindex-chainstate...
< bitcoin-git> bitcoin/master b0f3249 Matt Corallo: More user-friendly error message if UTXO DB runs ahead of block DB...
< bitcoin-git> bitcoin/master eda888e Matt Corallo: Fix some LoadChainTip-related init-order bugs....
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/42307c4bf363...bd924241e7dc
< bitcoin-git> [bitcoin] coblee opened pull request #10968: Add instructions for parallel gitian builds. (master...coblee_multi_core) https://github.com/bitcoin/bitcoin/pull/10968
< theymos> Old versions recommended installing over the old one: https://bitcoin.org/en/release/v0.12.0
< theymos> (Speaking generally here -- I've never looked at the Bitcoin Core installer.)
< Emcy_> 'On Windows, do not forget to uninstall all earlier versions of the Bitcoin client first.' Is this really *necessary*. No one ever does this
< sipa> jnewbery: i've also changed all v0.15 notation into 'version' or 'Bitcoin Core'
< jnewbery> Block file upgrade code removed here: https://github.com/bitcoin/bitcoin/pull/9822

2017-07-31

< bitcoin-git> [bitcoin] promag opened pull request #10966: Add walletnotify functional test (master...2017-07-walletnotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10966
< bitcoin-git> [bitcoin] practicalswift opened pull request #10965: Use the noexcept specifier (C++11) instead of deprecated throw() (master...noexcept) https://github.com/bitcoin/bitcoin/pull/10965
< gribble> https://github.com/bitcoin/bitcoin/issues/8330 | Structure Packing Optimizations in C{,Mutable}Transaction by JeremyRubin · Pull Request #8330 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #10964: Pass SendCoinsRecipient (208 bytes) and CConnman::Options (168 bytes) by reference (master...pass-big-parameters-by-reference) https://github.com/bitcoin/bitcoin/pull/10964
< bitcoin-git> [bitcoin] practicalswift opened pull request #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision (master...restore-format-state-of-cout) https://github.com/bitcoin/bitcoin/pull/10963
< bitcoin-git> [bitcoin] practicalswift opened pull request #10961: Improve readability of DecodeBase58Check(...) (master...DecodeBase58Check-cleanup) https://github.com/bitcoin/bitcoin/pull/10961
< bitcoin-git> bitcoin/master 42307c4 Wladimir J. van der Laan: qt: Periodic translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/42307c4bf363d695c68a65ba7cbf8d6790079abf
< bitcoin-git> [bitcoin] laanwj closed pull request #10949: Clarify help message for -discardfee (master...betterhelp) https://github.com/bitcoin/bitcoin/pull/10949
< bitcoin-git> bitcoin/master bdd5543 Alex Morcos: Clarify help message for -discardfee
< bitcoin-git> bitcoin/master af56397 Wladimir J. van der Laan: Merge #10949: Clarify help message for -discardfee...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df3a6f4ee4e2...af563971fcbe
< bitcoin-git> [bitcoin] laanwj closed pull request #10948: p2p: Hardcoded seeds update pre-0.15 branch (master...2017_07_seeds_update) https://github.com/bitcoin/bitcoin/pull/10948
< bitcoin-git> bitcoin/master df3a6f4 Wladimir J. van der Laan: Merge #10948: p2p: Hardcoded seeds update pre-0.15 branch...
< bitcoin-git> bitcoin/master f0acedd Wladimir J. van der Laan: p2p: Hardcoded seeds update pre-0.15 branch
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a50b11586a2...df3a6f4ee4e2
< bitcoin-git> [bitcoin] laanwj closed pull request #10945: Update defaultAssumeValid according to release-process.md. (master...201707-update-assumevalid) https://github.com/bitcoin/bitcoin/pull/10945
< bitcoin-git> bitcoin/master 2a50b11 Wladimir J. van der Laan: Merge #10945: Update defaultAssumeValid according to release-process.md....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/70888a39c43a...2a50b11586a2
< bitcoin-git> bitcoin/master 9a8b054 Gregory Maxwell: Update defaultAssumeValid according to release-process.md....
< luke-jr> wumpus: can I get access to bitcoin-devwiki? seems github is picky about pushing changes via git/ssh :/
< sipa> Oscillate: #bitcoin
< Oscillate> New to bitcoin here, can somebody tell me if the split is neccecary fot bitcoin hardfork ??
< gribble> https://github.com/bitcoin/bitcoin/issues/10853 | [tests] Fix RPC failure testing (again) by jnewbery · Pull Request #10853 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #10958: Update to latest Bitcoin patches for LevelDB (master...20170731_leveldb) https://github.com/bitcoin/bitcoin/pull/10958
< gmaxwell> oh jesus bitcoin amounts aren't natively floating point.