< bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #15696: [qa] test_runner: Move feature_pruning to base tests (master...1904-qaPruning) https://github.com/bitcoin/bitcoin/pull/15696
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #15696: [qa] test_runner: Move feature_pruning to base tests (master...1904-qaPruning) https://github.com/bitcoin/bitcoin/pull/15696
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15897: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one (master...qa_mininode_headers) https://github.com/bitcoin/bitcoin/pull/15897
< bitcoin-git>
bitcoin/master 9f9db39 Luke Dashjr: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sen...
< bitcoin-git>
bitcoin/master ce67620 MarcoFalke: Merge #15897: QA/mininode: Send all headers upfront in send_blocks_and_tes...
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15922: doc: Explain how to pass in non-fundamental types into functions (master...1904-docPassFun) https://github.com/bitcoin/bitcoin/pull/15922
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15919: Remove unused OpenSSL includes to make it more clear where OpenSSL is used (master...openssl-includes) https://github.com/bitcoin/bitcoin/pull/15919
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15920: lint: Check that all wallet args are hidden (master...1904-lintWalletArgsHidden) https://github.com/bitcoin/bitcoin/pull/15920
< bitcoin-git>
[bitcoin] practicalswift opened pull request #15919: Remove unused OpenSSL includes to make it more clear where OpenSSL is used (master...openssl-includes) https://github.com/bitcoin/bitcoin/pull/15919
< bitcoin-git>
[bitcoin] jonasschnelli merged pull request #15371: gui: Uppercase bech32 addresses in qr codes (master...gui_bech_32_optimized_qr_codes) https://github.com/bitcoin/bitcoin/pull/15371
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13062: Make script interpreter independent from storage type CScript (master...201804_spaninterpret) https://github.com/bitcoin/bitcoin/pull/13062
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #13875: [doc] nChainTx needs to become a 64-bit earlier due to SegWit (master...2018/08/nChainTx) https://github.com/bitcoin/bitcoin/pull/13875
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13789: crypto/sha256: Use pragmas to enforce necessary intrinsics for GCC and Clang (master...bugfix_asm_pragmas) https://github.com/bitcoin/bitcoin/pull/13789
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #13789: crypto/sha256: Use pragmas to enforce necessary intrinsics for GCC and Clang (master...bugfix_asm_pragmas) https://github.com/bitcoin/bitcoin/pull/13789
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13875: [doc] nChainTx needs to become a 64-bit earlier due to SegWit (master...2018/08/nChainTx) https://github.com/bitcoin/bitcoin/pull/13875
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15913: Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (master...bugfix_nowallet_avoidpspends) https://github.com/bitcoin/bitcoin/pull/15913
< midnightmagic>
ElePHPhant: #bitcoin, please. The topic here is very specifically for development of bitcoin core and not support questions.
< ElePHPhant>
gmaxwell: Will that mean that Bitcoin Core will no longer work with Bitpay payments?
< bitcoin-git>
[bitcoin] Sjors opened pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
< gmaxwell>
We're removing BIP70 from bitcoin core completely, since essentially nothing uses it (except bitpay) --- we were close to removing it when they made it mandatory, then we held off, but since their implementation is hardly compatible there really isn't much reason to not remove it just for them.
< ElePHPhant>
Is it a bug with Bitpay or Bitcoin Core?
< ElePHPhant>
I just made a Bitcoin payment and the merchant uses Bitpay. First of all, the webpage displayed a "We see you are using Bitcoin Core" message which freaked me out. How can they know that? Secondly, I got this weird Bitcoin Core error popup when actually performing the payment (which had a green coloring around it): "Error communicating with https://bitpay.com/i/<REDACTED>: Error transferring https://bitpay.com/i/<REDACTED> - server
< bitcoin-git>
[bitcoin] darosior opened pull request #15909: Use 'CreateProcess' instead of 'wsystem' in 'runCommand' for Windows. (master...windows_blocknotify_blink) https://github.com/bitcoin/bitcoin/pull/15909
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15899: rpc: Document iswitness flag and fix bug in converttopsbt (master...1904-docIsWitness) https://github.com/bitcoin/bitcoin/pull/15899
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15893: Add test for superfluous witness record in deserialization (master...test_super_witness) https://github.com/bitcoin/bitcoin/pull/15893
< bitcoin-git>
bitcoin/master 25b0786 Gregory Sanders: Fix missing input template by making minimal tx
< bitcoin-git>
bitcoin/master cc556e4 Gregory Sanders: Add test for superfluous witness record in deserialization
< bitcoin-git>
bitcoin/master 653b2b4 MarcoFalke: Merge #15893: Add test for superfluous witness record in deserialization
2019-04-25
< ghost43>
I think it's still compatible. last I tried, they did not reject, they are just threating they will. they are rejecting for shitcoins but not bitcoin
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15897: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one (master...qa_mininode_headers) https://github.com/bitcoin/bitcoin/pull/15897
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15896: QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core (master...qa_pkgname) https://github.com/bitcoin/bitcoin/pull/15896
< harding>
I'm also worried that announcing that v1 doesn't work will cause wallet authors to disable it. I actually wrote docs suggesting that (not published) a couple weeks ago because that's what it looked like Bitcoin Core was encouraging.
< bitcoin-git>
[bitcoin] instagibbs opened pull request #15893: Add test for superfulous witness record in deserialization (master...test_super_witness) https://github.com/bitcoin/bitcoin/pull/15893
< bitcoin-git>
bitcoin/master 097c4aa Luke Dashjr: Bugfix: test/functional/rpc_psbt: Remove check for specific error message ...
< bitcoin-git>
bitcoin/master c87fc71 Luke Dashjr: Bugfix: test/functional/rpc_psbt: Correct test description comment
< bitcoin-git>
bitcoin/master 8cca1fb MarcoFalke: Merge #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific ...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15891: test: Require standard txs in regtest (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
< bitcoin-git>
[bitcoin] harding opened pull request #15890: Doc: remove text about txes always relayed from -whitelist (master...2019-04-whitelist-help) https://github.com/bitcoin/bitcoin/pull/15890
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15888: QA: Add wallet_implicitsegwit to test the ability to transform keys between address types (master...test_wallet_implicitsegwit) https://github.com/bitcoin/bitcoin/pull/15888
< sipa>
gmaxwell: yeah, though orders of magnitude matter... if we'd have bignum arithmetic available you'd still not want to implement SNARK verification in bitcoin script :)
2019-04-24
< bitcoin-git>
[bitcoin] hebasto opened pull request #15887: docs: Align code example style with clang-format (master...20190424-coding-style) https://github.com/bitcoin/bitcoin/pull/15887
< molz>
tryphe, i compile my own windows bitcoin, let me pm you
< tryphe>
anyone running core on windows? someone in #bitcoin is saying that the ::system() call for -blocknotify= and others pops up a shell window while the command is running. this makes sense, as it's the default functionality of cmd.exe when spawned by system(). anyways, i have a proposed fix if someone can compile on windows *sic*, which the user can't
< bitcoin-git>
[bitcoin] hebasto opened pull request #15880: utils and libraries: Replace deprecated Boost Filesystem functions (master...20190423-boost-coding-guidelines) https://github.com/bitcoin/bitcoin/pull/15880
< echeveria>
if it's displayed in my copy of bitcoin-qt I've literally never noticed it.
< echeveria>
luke-jr: I've watched the results of this, users come to #bitcoin and you try to panic them about how "miners are exploiting bitcoin". this is deeply unhelpful and doesn't achieve what you think it does.
< luke-jr>
I guess echeveria unanimously represents consensus for adopting a patented exploit into the Bitcoin protocol
< gribble>
https://github.com/bitcoin/bitcoin/issues/15861 | Restore warning for individual unknown version bits, as well as unknown version schemas by luke-jr · Pull Request #15861 · bitcoin/bitcoin · GitHub
2019-04-22
< riperk>
On the bitcoin-dev ML, ZmnSCPxj linked to "coinjoin sudoku" as a reason you need to use equal-value outputs for privacy coinjoins
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15870: wallet: Only fail rescan when blocks have actually been pruned (master...1904-walletRescanPruned) https://github.com/bitcoin/bitcoin/pull/15870
< echeveria>
that's unusual. I don't think bitcoin.exe supported that.
< harding>
filter is supposed to contain four elements: 1. the generation tx's vout0 scriptPubKey (sPK), 2. the regular tx's vin0 prevout sPK, 3. reg tx's vout0 sPK, reg tx's vout1 sPK. Does anyone know what I'm misunderstanding about BIP158? bitcoin-cli getblockfilter $( bitcoin-cli getblockhash 170 )
< bitcoin-git>
[bitcoin] hebasto opened pull request #15863: scripts and tools: Ensure repos are up-to-date in gitian-build.py (master...20190421-update-repos) https://github.com/bitcoin/bitcoin/pull/15863
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15862: Bugfix: RPC: rawtransaction: Accept string-encoded amounts for maxfeerate in sendrawtransaction & testmempoolaccept (master...bugfix_rawtx_maxfeerate_str) https://github.com/bitcoin/bitcoin/pull/15862
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15861: Restore warning for individual unknown version bits, as well as unknown version schemas (master...restore_vbits_warning) https://github.com/bitcoin/bitcoin/pull/15861
< bitcoin-git>
bitcoin/0.18 4384839 Wladimir J. van der Laan: doc: Move release notes from wiki
< bitcoin-git>
[bitcoin] darosior opened pull request #15848: Add a check for free disk space at first startup. ref #15813 (master...check_free_disk_size) https://github.com/bitcoin/bitcoin/pull/15848
< kanzure>
why is bitcoin-git exiting so frequently. can we fix this?