2017-07-20

< kanzure> the bitcoin.org warning was about aug1?
< instagibbs> bitcoincore.org could have something like bitcoin.org's warning
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8745 | [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli · Pull Request #8745 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< instagibbs> so, there's gotta be something better than "load your wallet in an older bitcoin instance"
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | Add SSE4 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 has pretty much been cleaned out (only #10652 left), anything new?
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< wumpus> BlueMatt: https://github.com/laanwj/bitcoin/tree/2016_05_sha256_accel readme.md has some benchmarks
< bitcoin-git> [bitcoin] laanwj closed pull request #10821: Add SSE4 optimized SHA256 (master...20170713_shasse) https://github.com/bitcoin/bitcoin/pull/10821
< bitcoin-git> bitcoin/master c1ccb15 Pieter Wuille: Add SSE4 based SHA256
< bitcoin-git> bitcoin/master 2991c91 Pieter Wuille: Add SHA256 dispatcher
< bitcoin-git> bitcoin/master 4d50f38 Pieter Wuille: Support multi-block SHA256 transforms...
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c2400cb8ab7...16240f43a550
< wumpus> there's no reason bitcoind couldn't have a dynamic settings mechanism, with some configuration that automatically gets re-loaded on next run, for example the bitcoin-rw.conf idea
< jonasschnelli> https://github.com/bitcoin/bitcoin/pull/10870#discussion_r128546723 must be removed (replaced) once 0.15 is fixed.
< jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/10870#discussion_r128546723, .. what do you think about not doing the URL encode
< bitcoin-git> [bitcoin] laanwj closed pull request #10775: nCheckDepth chain height fix (master...master) https://github.com/bitcoin/bitcoin/pull/10775
< bitcoin-git> bitcoin/master d9d1bd3 romanornr: nCheckDepth chain height fix
< bitcoin-git> bitcoin/master 7c2400c Wladimir J. van der Laan: Merge #10775: nCheckDepth chain height fix...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/041dad94b047...7c2400cb8ab7
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | [WIP] Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10783: [RPC] Various rpc argument fixes (master...rpcargfixes) https://github.com/bitcoin/bitcoin/pull/10783
< bitcoin-git> bitcoin/master 4dc1915 Gregory Sanders: check for null values in rpc args and handle appropriately
< bitcoin-git> bitcoin/master 999ef20 Gregory Sanders: importmulti options are optional
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd2814ef1182...041dad94b047
< bitcoin-git> bitcoin/master a70d025 Gregory Sanders: fixup some rpc param counting for rpc help
< bitcoin-git> [bitcoin] laanwj closed pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition". (master...nEnd) https://github.com/bitcoin/bitcoin/pull/10862
< bitcoin-git> bitcoin/master fd2814e Wladimir J. van der Laan: Merge #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition"....
< bitcoin-git> bitcoin/master 5a6671c practicalswift: Fix typo: "conditon" → "condition"...
< bitcoin-git> bitcoin/master 35aff43 practicalswift: Remove unused variable int64_t nEnd...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/adf170daf90f...fd2814ef1182
< bitcoin-git> [bitcoin] laanwj closed pull request #10571: [RPC]Move transaction combining from signrawtransaction to new RPC (master...combineraw-rpc) https://github.com/bitcoin/bitcoin/pull/10571
< bitcoin-git> bitcoin/master adf170d Wladimir J. van der Laan: Merge #10571: [RPC]Move transaction combining from signrawtransaction to new RPC...
< bitcoin-git> bitcoin/master 6b4f231 Andrew Chow: Move transaction combining from signrawtransaction to new RPC...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf3b742e2852...adf170daf90f
< bitcoin-git> [bitcoin] jnewbery closed pull request #10868: Remove -usewallet (master...remove_use_wallet) https://github.com/bitcoin/bitcoin/pull/10868
< bitcoin-git> [bitcoin] benma opened pull request #10888: range-based loops and const qualifications in net.cpp (master...netcpp_cosmetics2) https://github.com/bitcoin/bitcoin/pull/10888
< bitcoin-git> [bitcoin] laanwj closed pull request #10883: Rename -usewallet to -rpcwallet (master...rpcwallet) https://github.com/bitcoin/bitcoin/pull/10883
< bitcoin-git> bitcoin/master bf3b742 Wladimir J. van der Laan: Merge #10883: Rename -usewallet to -rpcwallet...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df0793f324e3...bf3b742e2852
< bitcoin-git> bitcoin/master 2264236 Alex Morcos: Rename -usewallet to -rpcwallet
< wumpus> he also has some english to english messages in de_DE https://www.transifex.com/bitcoin/bitcoin/translate/#de_DE/$/65093519?user=pehotinec
< wumpus> e.g. nearly all of these are nonsense https://www.transifex.com/bitcoin/bitcoin/translate/#de/$/104570304?user=pehotinec, sometimes he copies slightly similar messages to make it look ok, sometimes he just copies the English message, in any cast this seems deliberate
< bitcoin-git> [bitcoin] MeshCollider closed pull request #10886: Remove unused #define in sync.h (master...remove-unused-define) https://github.com/bitcoin/bitcoin/pull/10886
< bitcoin-git> [bitcoin] MeshCollider opened pull request #10886: Remove unused #define in sync.h (master...remove-unused-define) https://github.com/bitcoin/bitcoin/pull/10886
< bitcoin-git> [bitcoin] promag opened pull request #10885: Prevent duplicate wallets (master...2017-07-prevent-duplicate-wallets) https://github.com/bitcoin/bitcoin/pull/10885

2017-07-19

< promag> is this correct bitcoin-qt -wallet=foo.dat -wallet=wallet.dat -regtest ?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10681: add gdb attach process to test README (master...gdbattach) https://github.com/bitcoin/bitcoin/pull/10681
< bitcoin-git> bitcoin/master 7ec3343 Gregory Sanders: add gdb attach process to test README
< bitcoin-git> bitcoin/master df0793f MarcoFalke: Merge #10681: add gdb attach process to test README...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d445a2c2eaa1...df0793f324e3
< bitcoin-git> [bitcoin] eliahuhorwitz opened pull request #10884: Update build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10884
< jnewbery> I suppose we'll generally need to give bitcoin-cli more smarts if we do wallet process separation
< jonasschnelli> BTW: github recommends to add a COC to the bitcoin core project: https://opensource.guide/code-of-conduct/
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
< bitcoin-git> [bitcoin] morcos opened pull request #10883: Rename -usewallet to -rpcwallet (master...rpcwallet) https://github.com/bitcoin/bitcoin/pull/10883
< instagibbs> eck, #bitcoin (can answer there)
< jonasschnelli> But I guess what we should merge for 0.15 is the Qt console support: https://github.com/bitcoin/bitcoin/pull/10870
< jonasschnelli> Should we still revoke (halt bitcoin-cli) if one provides multiple -rpc/-usewallet arguments?
< wumpus> if it wasn't for the authentication options we could stop parsing bitcoin.conf completely for the -cli
< sipa> ./bitcoin-cli -thethingimean=foo
< gmaxwell> is it the setting that tells bitcoin-cli what wallet to talk to
< jonasschnelli> I just though until now, I could not see any "rpc" in bitcoin-cli (from the users perspetive)
< sipa> bitcoin-cli is an rpc client
< jonasschnelli> I probably over-engineer. But what if we once change bitcoin-cli's transport layer?
< jonasschnelli> isn't bitcoin-cli transport agnostic?
< bitcoin-git> [bitcoin] jnewbery closed pull request #10830: [WIP] [wallet] keypool restore (master...pr10240) https://github.com/bitcoin/bitcoin/pull/10830
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10882: [WIP] Keypool topup (master...keypool_topup) https://github.com/bitcoin/bitcoin/pull/10882
< jnewbery> but specifying the wrong -dbcache on the command line for bitcoin-cli cannot lead to loss of funds
< jnewbery> >we don't complain in bitcoin-cli that -dbcache is specfied
< gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< sipa> but we don't complain in bitcoin-cli that -dbcache is specfied, right?
< jnewbery> I think Russ is thinking about the case where someone starts bitcoind with -wallet=mybusinesswallet.dat in the conf file, then calls `bitcoin-cli -wallet=mypersonalwallet.dat send ...` and is confused that money is sent from their business wallet even though they specified a different wallet
< ryanofsky> yes that's why i said "on bitcoin-cli command line"
< ryanofsky> maybe also consider making it an error for user to specify -wallet on bitcoin-cli command line if it will be ignored
< jnewbery> Because of the arguments I give here: https://github.com/bitcoin/bitcoin/pull/10868#issuecomment-316409725
< wumpus> why owuld that be strange? bitcoin-cli has lots of arguments that are not used by bitcoind
< jnewbery> having a `useargument` argument that is used by bitcoin-cli but is not used by bitcoind seems strange to me
< wumpus> if bitcoin-cli would not read the config file at all, or a different config file, I'd be ok with it
< ryanofsky> wumpus, yes, the tradeoff for having bitcoin-cli accept a wallet argument is having to ignore wallet values from the config file
< wumpus> e.g. you might want to set a default wallet for bitcoin-cli to use in the configuration file, you can't use -wallet for that
< wumpus> I don't think re-using -wallet for bitcoin-cli is a good idea
< sipa> jonasschnelli: but it's not so different from how -rpcport for bitcoind means "the port to listen on" nd for bitcoin-cli means "the port to connect to"
< jnewbery> but how -usewallet is interpreted is differentiated as well - acted on by bitcoin-cli, ignored by bitcoind, and you haven't decided on whether it should be ignored or not by bitcoin-qt
< ryanofsky> that is a drawback. if you want bitcoin-cli to be able to use wallet filename from a config file, you have to call the option something other than -wallet
< jonasschnelli> I just can't follow why you would want to add code to differenciate -wallet in bitcoin conf to -wallet passed into bitcoin-cli
< ryanofsky> users should just be shown an error if they are expecting bitcoin-cli to send an single rpc command to multiple wallets
< bitcoin-git> [bitcoin] laanwj closed pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< bitcoin-git> bitcoin/master d445a2c Wladimir J. van der Laan: Merge #10857: [RPC] Add a deprecation warning to getinfo's output...
< bitcoin-git> bitcoin/master 1c9b818 Andrew Chow: getinfo deprecation warning
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9022aa37226b...d445a2c2eaa1
< jnewbery> jonasschnelli, for the reasons I gave in https://github.com/bitcoin/bitcoin/pull/10868#issuecomment-316409725 - I think the name usewallet is meaningless and confusing
< jonasschnelli> ryanofsky: a) because its to different things (and users should learn that from the beginning), b) -usewallet could be reused for bitcoin-Qt (until there is a GUI way to select the wallet)
< bitcoin-git> [bitcoin] laanwj closed pull request #10817: Redefine Dust and add a discard_rate (master...discardmore) https://github.com/bitcoin/bitcoin/pull/10817
< bitcoin-git> bitcoin/master 9022aa3 Wladimir J. van der Laan: Merge #10817: Redefine Dust and add a discard_rate...
< bitcoin-git> bitcoin/master f4d00e6 Alex Morcos: Add a discard_rate...
< bitcoin-git> bitcoin/master b138585 Alex Morcos: Remove factor of 3 from definition of dust....
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a6ec5802b0a9...9022aa37226b
< gribble> https://github.com/bitcoin/bitcoin/issues/10873 | Use a condition variable for shutdown notifications by eklitzke · Pull Request #10873 · bitcoin/bitcoin · GitHub
< jonasschnelli> I can't reproduce the following travis issue locally (by using Ubuntu 14.04 and the same build configuration): https://travis-ci.org/bitcoin/bitcoin/jobs/254826520#L2299
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (master...GetWarnings-in-warnings.h) https://github.com/bitcoin/bitcoin/pull/10864
< bitcoin-git> bitcoin/master a6ec580 Jonas Schnelli: Merge #10864: Avoid redundant redeclaration of GetWarnings(const string&)...
< bitcoin-git> bitcoin/master e0d4592 practicalswift: Avoid redundant redeclaration of GetWarnings(const string&)...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e8d6a3fb43a...a6ec5802b0a9
< bitcoin-git> [bitcoin] eklitzke opened pull request #10881: trivial: fix various pyflakes/vulture warnings (master...vulture) https://github.com/bitcoin/bitcoin/pull/10881
< bitcoin-git> [bitcoin] eklitzke opened pull request #10880: Update .gitignore to ignore more test files (master...gitignore) https://github.com/bitcoin/bitcoin/pull/10880
< bitcoin-git> [bitcoin] kallewoof closed pull request #10879: Difficulty adjustment (master...difficulty-adjustment) https://github.com/bitcoin/bitcoin/pull/10879
< bitcoin-git> [bitcoin] kallewoof opened pull request #10879: Difficulty adjustment (master...difficulty-adjustment) https://github.com/bitcoin/bitcoin/pull/10879
< bitcoin-git> [bitcoin] dongcarl opened pull request #10878: Docs: Fix markdown line breaks in init.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10878
< bitcoin-git> [bitcoin] kallewoof opened pull request #10877: [rpc] Verbose flags for chaining and scripting (master...verbose-flagging) https://github.com/bitcoin/bitcoin/pull/10877
< bitcoin-git> [bitcoin] sipa closed pull request #10876: What do you mean a bug in the latest version? (0.14...master) https://github.com/bitcoin/bitcoin/pull/10876
< bitcoin-git> [bitcoin] DJMorgan opened pull request #10876: What do you mean a bug in the latest version? (0.14...master) https://github.com/bitcoin/bitcoin/pull/10876
< bitcoin-git> [bitcoin] achow101 opened pull request #10875: BIP 91 deployment parameters (master...bip91-dep-params) https://github.com/bitcoin/bitcoin/pull/10875
< bitcoin-git> [bitcoin] achow101 opened pull request #10874: [RPC] getblockchaininfo: Loop through the bip9 soft fork deployments instead of hard coding (master...getblockchaininfo-bip9-loop) https://github.com/bitcoin/bitcoin/pull/10874

2017-07-18

< bitcoin-git> [bitcoin] eklitzke opened pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
< bitcoin-git> [bitcoin] eklitzke opened pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
< bitcoin-git> [bitcoin] achow101 opened pull request #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) (master...cli-getinfo) https://github.com/bitcoin/bitcoin/pull/10871
< jtimon> jonasschnelli: I'm having problems explaining my suggestion in https://github.com/bitcoin/bips/pull/555
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
< gribble> https://github.com/bitcoin/bitcoin/issues/10817 | Redefine Dust and add a discard_rate by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
< ryanofsky> url encoding was suggested when there were still wallet ids. if you want to check for CHARS_ALPHA_NUM in bitcoin-cli instead of percent encoding, that seems fine, though a little more fragile (because maybe we will allow another class of characters in bitcoind and bitcoin-cli will break)
< bitcoin-git> [bitcoin] jnewbery opened pull request #10868: Remove -usewallet (master...remove_use_wallet) https://github.com/bitcoin/bitcoin/pull/10868
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
< bitcoin-git> [bitcoin] laanwj closed pull request #10784: Do not allow users to get keys from keypool without reserving them (master...2017-07-keep-change) https://github.com/bitcoin/bitcoin/pull/10784
< bitcoin-git> bitcoin/master 9e8d6a3 Wladimir J. van der Laan: Merge #10784: Do not allow users to get keys from keypool without reserving them...
< bitcoin-git> bitcoin/master cf82a9e Matt Corallo: Do not allow users to get keys from keypool without reserving them...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bde4f937aebc...9e8d6a3fb43a
< gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10849: Multiwallet: simplest endpoint support (master...2017/07/mw_endpoint_simple) https://github.com/bitcoin/bitcoin/pull/10849
< bitcoin-git> bitcoin/master 32c9710 Jonas Schnelli: Fix test_bitcoin circular dependency issue
< bitcoin-git> bitcoin/master 31e0720 Jonas Schnelli: Add wallet endpoint support to bitcoin-cli (-usewallet)
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b6e8bc44240...bde4f937aebc
< bitcoin-git> bitcoin/master dd2185c Jonas Schnelli: Register wallet endpoint
< gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10571 | [RPC]Move transaction combining from signrawtransaction to new RPC by achow101 · Pull Request #10571 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #10866: Add mutex requirement for AddToCompactExtraTransactions(…) (master...lock-requirement-for-AddToCompactExtraTransactions) https://github.com/bitcoin/bitcoin/pull/10866
< bitcoin-git> [bitcoin] corebob opened pull request #10865: Move CloseSocket out of SetSocketNonBlocking in netbase.cpp (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
< bitcoin-git> [bitcoin] corebob closed pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
< bitcoin-git> [bitcoin] practicalswift opened pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (master...GetWarnings-in-warnings.h) https://github.com/bitcoin/bitcoin/pull/10864
< bitcoin-git> [bitcoin] corebob opened pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
< bitcoin-git> [bitcoin] practicalswift opened pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition". (master...nEnd) https://github.com/bitcoin/bitcoin/pull/10862
< bitcoin-git> [bitcoin] laanwj closed pull request #10795: No longer ever reuse keypool indexes (master...2017-07-wallet-keypool-overwrite) https://github.com/bitcoin/bitcoin/pull/10795
< bitcoin-git> bitcoin/master 7b6e8bc Wladimir J. van der Laan: Merge #10795: No longer ever reuse keypool indexes...
< bitcoin-git> bitcoin/master 1fc8c3d Matt Corallo: No longer ever reuse keypool indexes...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81560b07ce8a...7b6e8bc44240
< bitcoin-git> [bitcoin] laanwj closed pull request #10855: random: only use getentropy on openbsd (master...getentropy-openbsd) https://github.com/bitcoin/bitcoin/pull/10855
< bitcoin-git> bitcoin/master 81560b0 Wladimir J. van der Laan: Merge #10855: random: only use getentropy on openbsd...
< bitcoin-git> bitcoin/master 077d01f Cory Fields: random: only use getentropy on openbsd
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75b5643c47c3...81560b07ce8a
< bitcoin-git> [bitcoin] ryanofsky closed pull request #10829: Simple, backwards compatible RPC multiwallet support. (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10829
< Guest38971> Understood my question was hypethical. My main concern is if I am running my node how can I test BIP148 suppost. I found a link that allows me to download bitcoin core with BIP148 support, but I did not know if this was trustworthy. Thank you
< sipa> Bitcoin Core at this point does not support BIP148
< Guest38971> lets say I wanted my node to support bip148. What do I need to configure in order to allow this? I am currently running bitcoin core 0.14.2 am I just ammending a line of code into the config file? I just need a reference if possible or is it advised to just wait for a release from bitcoin core?. I do not know if this is the proper channel for this so I apologize in advance. Thank you very much for the help.
< bitcoin-git> [bitcoin] jtimon opened pull request #10859: RPC: gettxout: Slightly improve doc and tests (master...b15-rpc-gettxout-mempool) https://github.com/bitcoin/bitcoin/pull/10859

2017-07-17

< bitcoin-git> [bitcoin] sipa closed pull request #10707: Better API for estimatesmartfee RPC (master...bettersmartfeeapi) https://github.com/bitcoin/bitcoin/pull/10707
< bitcoin-git> bitcoin/master 75b5643 Pieter Wuille: Merge #10707: Better API for estimatesmartfee RPC...
< bitcoin-git> bitcoin/master 439c4e8 Alex Morcos: Improve api to estimatesmartfee...
< bitcoin-git> bitcoin/master 06bcdb8 Alex Morcos: Convert named argument from nblocks to conf_target...
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fee0d803fb55...75b5643c47c3
< bitcoin-git> [bitcoin] achow101 opened pull request #10858: [RPC] Add "errors" field to getblockchaininfo and unify "errors" field in get*info RPCs (master...getblockchaininfo-errors) https://github.com/bitcoin/bitcoin/pull/10858
< bitcoin-git> [bitcoin] achow101 opened pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< bitcoin-git> [bitcoin] sipa closed pull request #9980: Fix mem access violation merkleblock (master...fix_mem_access_violation_merkleblock) https://github.com/bitcoin/bitcoin/pull/9980
< bitcoin-git> bitcoin/master fee0d80 Pieter Wuille: Merge #9980: Fix mem access violation merkleblock...
< bitcoin-git> bitcoin/master 8276e70 Chris Stewart: Adding assert to avoid a memory access violation inside of PartialMerkleTree::CalcHash()...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0b019357ff09...fee0d803fb55
< gribble> https://github.com/bitcoin/bitcoin/issues/10822 | RPC: Also serve txo from gettxout (not just utxo and mempool) by jtimon · Pull Request #10822 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10822 | RPC: Also serve txo from gettxout (not just utxo and mempool) by jtimon · Pull Request #10822 · bitcoin/bitcoin · GitHub
< jnewbery> sipa: I can think of a couple of good solutions to the old encrypted wallet at start: 1. have a bitcoin-wallet util that can topup the keypool offline. 2. have a `loadwallet` RPC that can decrypt on load
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< promag> https://github.com/bitcoin/bitcoin/pull/9502 it's supposed to keep syncing headers? sipa?
< gribble> https://github.com/bitcoin/bitcoin/issues/9806 | txoutsbyaddress index (take 3) by droark · Pull Request #9806 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< ryanofsky> i think changes to bitcoin-cli are simple but ugly
< jnewbery> with (2), the bitcoin-cli caller needs to change to include a `-usewallet` argument. With (1) the entire invocation needs to change
< jnewbery> I think (2) is better in that respect. We need to modify bitcoin-cli, but we have those changes already coded. With (1), every script that calls wallet methods using bitcoin-cli needs to be changed because positional arguments are no longer supported
< gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
< ryanofsky> yes named arguments require no changes to bitcoin-cli
< jnewbery> > countervailing tradeoffs like having to modify bitcoin-cli
< ryanofsky> your second reason is reason sipa & gmaxwell like approaches (2)&(3) over approach (1), in that respect there is no distiniction between (2)/(3), and countervailing tradeoffs like having to modify bitcoin-cli and other things i mentioned above
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< ryanofsky> also just to list other practical advantages i see in (1) over (2/3). Requires no changes to bitcoin-cli. Is properly documented, easy to understand, just a param. Encourages named arguments. Allows checking wallet name for safety even with multiprocess.
< ryanofsky> i also want to point out that there we are talking about 1 practical tradeoff between 1 & 2/3, there are other practical advantages to 1 like not having to modify bitcoin-cli
< sipa> BlueMatt: the bitcoin specific shims can be trivially patched to pass that through
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #10855: random: only use getentropy on openbsd (master...getentropy-openbsd) https://github.com/bitcoin/bitcoin/pull/10855
< bitcoin-git> [bitcoin] theuni closed pull request #10335: back-compat: add fallback getentropy implementation (master...getentropy-back-compat) https://github.com/bitcoin/bitcoin/pull/10335
< bitcoin-git> [bitcoin] gmaxwell opened pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
< gribble> https://github.com/bitcoin/bitcoin/issues/10335 | back-compat: add fallback getentropy implementation by theuni · Pull Request #10335 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10672 | Avoid division by zero in the case of a corrupt estimates file by practicalswift · Pull Request #10672 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10829 | Simple, backwards compatible RPC multiwallet support. by ryanofsky · Pull Request #10829 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | Add SSE4 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10829 | Simple, backwards compatible RPC multiwallet support. by ryanofsky · Pull Request #10829 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10853: [tests] Fix RPC failure testing (again) (master...cleanup_jsonrpc_asserts) https://github.com/bitcoin/bitcoin/pull/10853
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #10851: depends: bump fontconfig to 2.12.4 (master...fontconfig-bump) https://github.com/bitcoin/bitcoin/pull/10851
< gmaxwell> away an extra 5 cents in bitcoin to avoid change outputs)
< gribble> https://github.com/bitcoin/bitcoin/issues/10817 | Redefine Dust and add a discard_rate by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831
< bitcoin-git> bitcoin/master 30d8f3a Gregory Maxwell: Pushdown walletdb though CWallet::AddKeyPubKey to avoid flushes....
< bitcoin-git> bitcoin/master 41dc163 Gregory Maxwell: Increase wallet default keypool size to 1000.
< bitcoin-git> bitcoin/master 3a53f19 Gregory Maxwell: Pushdown walletdb object through GenerateNewKey/DeriveNewChildKey....
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/89bb0365b97a...0b019357ff09
< bitcoin-git> [bitcoin] laanwj closed pull request #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue (master...2017_07_appinitlockdatadirectory) https://github.com/bitcoin/bitcoin/pull/10832
< bitcoin-git> bitcoin/master 89bb036 Wladimir J. van der Laan: Merge #10832: init: Factor out AppInitLockDataDirectory and fix startup core dump issue...
< bitcoin-git> bitcoin/master dba485d Wladimir J. van der Laan: init: Factor out AppInitLockDataDirectory...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b0179d8a9b7...89bb0365b97a
< bitcoin-git> [bitcoin] promag closed pull request #10804: Add histunspent RPC (master...2017-07-rpc-add-histunspent) https://github.com/bitcoin/bitcoin/pull/10804
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10804 | Add histunspent RPC by promag · Pull Request #10804 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8843 | rpc: Handle `getinfo` client-side in bitcoin-cli w/ `-getinfo` by laanwj · Pull Request #8843 · bitcoin/bitcoin · GitHub
< gmaxwell> wumpus: I liked it except for one concern, the parity between the CLI and RPC is a major learing curve improvement. If we went down the path of a highly cooked bitcoin-cli then knoweldge wouldn't automatically transfer between them, improvements wouldn't automatically transfer, etc.
< gmaxwell> rename bitcoin-cli bitcoin-rpc and we create a real bitcoin-cli ? :P
< gribble> https://github.com/bitcoin/bitcoin/issues/10804 | Add histunspent RPC by promag · Pull Request #10804 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #10841: [rpc] Give users one final warning before removing getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
< gribble> https://github.com/bitcoin/bitcoin/issues/10841 | [rpc] Give users one final warning before removing getinfo by jnewbery · Pull Request #10841 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10838 | (finally) remove the longest-ever-deprecated RPC call getinfo by TheBlueMatt · Pull Request #10838 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10841 | [rpc] Give users one final warning before removing getinfo by jnewbery · Pull Request #10841 · bitcoin/bitcoin · GitHub
< jnewbery> unit testing or functional testing? Default keypool size in the functional tests is 1 (https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_framework.py#L212)
< promag> wumpus: remove https://github.com/bitcoin/bitcoin/pull/10650 from project 8?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10834: Remove declaration of unused method: void UpdatedTransaction(const uint256 &) (master...remove-UpdatedTransaction) https://github.com/bitcoin/bitcoin/pull/10834
< bitcoin-git> bitcoin/master 2b0179d MarcoFalke: Merge #10834: Remove declaration of unused method: void UpdatedTransaction(const uint256 &)...
< bitcoin-git> bitcoin/master e061d8d practicalswift: Remove declaration of unused function: void UpdatedTransaction(const uint256 &)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8bc6d1f179a0...2b0179d8a9b7
< bitcoin-git> [bitcoin] laanwj closed pull request #10837: Fix resource leak on error in GetDevURandom (master...20170715-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10837
< bitcoin-git> bitcoin/master a8ae0b2 Dag Robole: Fix resource leak
< bitcoin-git> bitcoin/master 8bc6d1f Wladimir J. van der Laan: Merge #10837: Fix resource leak on error in GetDevURandom...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/91edda8f3c81...8bc6d1f179a0
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10849: Multiwallet: simplest endpoint support (master...2017/07/mw_endpoint_simple) https://github.com/bitcoin/bitcoin/pull/10849
< gribble> https://github.com/bitcoin/bitcoin/issues/10817 | Add a discard_rate to avoid small change by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< gribble> https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10803: Explicitly search for bdb5.3. (master...2017-07-02-bdb5.3) https://github.com/bitcoin/bitcoin/pull/10803
< bitcoin-git> bitcoin/master 91edda8 Wladimir J. van der Laan: Merge #10803: Explicitly search for bdb5.3....
< bitcoin-git> bitcoin/master 1cc251f Patrick Strateman: Explicitly search for bdb5.3....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6859ad2936bf...91edda8f3c81
< gribble> https://github.com/bitcoin/bitcoin/issues/10829 | Simple, backwards compatible RPC multiwallet support. by ryanofsky · Pull Request #10829 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10706: Improve wallet fee logic and fix GUI bugs (master...improveWalletFeeLogic) https://github.com/bitcoin/bitcoin/pull/10706
< bitcoin-git> bitcoin/master 1983ca6 Alex Morcos: Use CoinControl to pass custom fee setting from QT....
< bitcoin-git> bitcoin/master 03ee701 Alex Morcos: Refactor to use CoinControl in GetMinimumFee and FeeBumper...
< bitcoin-git> bitcoin/master ecd81df Alex Morcos: Make CoinControl a required argument to CreateTransaction
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf0a08be281d...6859ad2936bf
< bitcoin-git> [bitcoin] luke-jr closed pull request #10074: Block size/weight fraud proofs (master...sizefp) https://github.com/bitcoin/bitcoin/pull/10074
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10829 | Simple, backwards compatible RPC multiwallet support. by ryanofsky · Pull Request #10829 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< wumpus> I'll just maintain my own client-side info scripts, I'm not going to try to introduce convenient info functionality in bitcoin-cli anymore
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #8843: rpc: Handle `getinfo` client-side in bitcoin-cli w/ `-getinfo` (master...2016_09_getinfo_clientside) https://github.com/bitcoin/bitcoin/pull/8843
< gribble> https://github.com/bitcoin/bitcoin/issues/8843 | rpc: Handle `getinfo` client-side in bitcoin-cli w/ `-getinfo` by laanwj · Pull Request #8843 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #10802: [tests] skip zapwallettxes.py (master...skip_zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10802
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10330: [wallet] fix zapwallettxes interaction with persistent mempool (master...zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10330
< bitcoin-git> bitcoin/master 4c3b538 John Newbery: [logs] fix zapwallettxes startup logs
< bitcoin-git> bitcoin/master ff7365e John Newbery: [tests] fix flake8 warnings in zapwallettxes.py
< bitcoin-git> bitcoin/master e7a2181 John Newbery: [wallet] fix zapwallettxes interaction with persistent mempool...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3895e25a7736...bf0a08be281d

2017-07-16

< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
< BlueMatt> gmaxwell: hmm? bitcoin.org/bin has binary distributions
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
< bitcoin-git> bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching....
< bitcoin-git> bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fc783fc08bc...3895e25a7736
< bitcoin-git> [bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
< bitcoin-git> bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739
< bitcoin-git> bitcoin/master 5618b7d Pavel Janík: Do not shadow upper local variable `state`.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/565494619d80...1fc783fc08bc