2017-07-16

< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad6fce67b9bb...565494619d80
< bitcoin-git> [bitcoin] sipa closed pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
< bitcoin-git> bitcoin/master ad6fce6 Pieter Wuille: Merge #10844: Use range based for loop...
< bitcoin-git> bitcoin/master d0413c6 René Nyffenegger: Use range based for loop...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99c7db8731cc...ad6fce67b9bb
< bitcoin-git> [bitcoin] sipa closed pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
< bitcoin-git> bitcoin/master 99c7db8 Pieter Wuille: Merge #10840: Remove duplicate include...
< bitcoin-git> bitcoin/master c53369c practicalswift: Remove duplicate include
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d03be3cac0...99c7db8731cc
< bitcoin-git> [bitcoin] sipa closed pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766
< bitcoin-git> bitcoin/master b4d03be Pieter Wuille: Merge #10766: Building Environment: Set ARFLAGS to cr...
< bitcoin-git> bitcoin/master 912da1d René Nyffenegger: Use AC_ARG_VAR to set ARFLAGS....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef37f2033c4a...b4d03be3cac0
< bitcoin-git> [bitcoin] sipa closed pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820
< bitcoin-git> bitcoin/master ef37f20 Pieter Wuille: Merge #10820: Use cpuid intrinsics instead of asm code...
< bitcoin-git> bitcoin/master a9e82f6 Pieter Wuille: Use cpuid intrinsics instead of asm code
< bitcoin-git> bitcoin/master 674848f Pieter Wuille: Clarify entropy source
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cfdda2503c9...ef37f2033c4a
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
< bitcoin-git> [bitcoin] practicalswift opened pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
< bitcoin-git> [bitcoin] practicalswift opened pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843
< bitcoin-git> [bitcoin] practicalswift opened pull request #10842: Fix incorrect Doxygen tag (@ince → @since) (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
< bitcoin-git> [bitcoin] jnewbery opened pull request #10841: [rpc] Give users one final warning before depracating getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
< sipa> your question is about how bitcoin transactions work
< sipa> or #bitcoin
< sipa> not here, try bitcoin.stackexchange.com
< AsadSalman> I'm working in the bitcoin core, trying to get the amount of a transaction sent into the mempool
< bitcoin-git> [bitcoin] practicalswift opened pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
< bitcoin-git> [bitcoin] practicalswift opened pull request #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). (master...dont-pass-by-reference-for-cheaply-copied-types) https://github.com/bitcoin/bitcoin/pull/10839

2017-07-15

< BlueMatt> uhhh, sipa, are you sure https://github.com/bitcoin/bitcoin/pull/10770#issuecomment-315558931 is specific to that PR?
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | [WIP] Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10235: Track keypool entries as internal vs external in memory (master...2017-04-wallet-more-keypool-cache) https://github.com/bitcoin/bitcoin/pull/10235
< bitcoin-git> bitcoin/master d40a72c Matt Corallo: Clarify *(--.end()) iterator semantics in CWallet::TopUpKeyPool
< bitcoin-git> bitcoin/master 28301b9 Matt Corallo: Meet code style on lines changed in the previous commit
< bitcoin-git> bitcoin/master 4a3fc35 Matt Corallo: Track keypool entries as internal vs external in memory...
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5904e871479...5cfdda2503c9
< bitcoin-git> [bitcoin] sipa closed pull request #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets (master...bitcoin_cli_ipv6) https://github.com/bitcoin/bitcoin/pull/10812
< bitcoin-git> bitcoin/master c5904e8 Pieter Wuille: Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets...
< bitcoin-git> bitcoin/master 5c64324 John Newbery: [utils] allow square brackets for ipv6 addresses in bitcoin-cli...
< bitcoin-git> bitcoin/master fe4faba John Newbery: [refactor] move SplitHostPort() into utilstrencodings...
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/10b22e3141a6...c5904e871479
< bitcoin-git> [bitcoin] corebob opened pull request #10837: Fix resource leak (master...20170715-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10837
< bitcoin-git> [bitcoin] sipa closed pull request #10760: Avoid dereference-of-casted-pointer (master...20170707_avoidcastptr) https://github.com/bitcoin/bitcoin/pull/10760
< bitcoin-git> bitcoin/master 10b22e3 Pieter Wuille: Merge #10760: Avoid dereference-of-casted-pointer...
< bitcoin-git> bitcoin/master 0aadc11 Pieter Wuille: Avoid dereference-of-casted-pointer
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afd2fca911c4...10b22e3141a6
< bitcoin-git> [bitcoin] paveljanik opened pull request #10835: Do not shadow a field of 'reverse_range<T>' (master...20170715_Wshadow_reverseiterator) https://github.com/bitcoin/bitcoin/pull/10835
< bitcoin-git> [bitcoin] sipa closed pull request #10807: getbalance example covers at least 6 confirms (master...getbalexample) https://github.com/bitcoin/bitcoin/pull/10807
< bitcoin-git> bitcoin/master afd2fca Pieter Wuille: Merge #10807: getbalance example covers at least 6 confirms...
< bitcoin-git> bitcoin/master 228987d Gregory Sanders: getbalance example covers at least 6 confirms
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/505955052e60...afd2fca911c4
< bitcoin-git> [bitcoin] practicalswift opened pull request #10834: Remove declaration of unused function: void UpdatedTransaction(const uint256 &) (master...remove-UpdatedTransaction) https://github.com/bitcoin/bitcoin/pull/10834
< bitcoin-git> [bitcoin] sipa closed pull request #10833: Fix typos (master...typos-201707) https://github.com/bitcoin/bitcoin/pull/10833
< bitcoin-git> bitcoin/master 5059550 Pieter Wuille: Merge #10833: Fix typos...
< bitcoin-git> bitcoin/master 0189d8e practicalswift: Fix typos
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8fdd23a224ba...505955052e60
< jamesob> If I wanted to do some kind of analysis on the UTXO set, is my best bet forking and making use of CCoinsView somehow? is https://github.com/bitcoin/bitcoin/pull/7759 worth resurrecting?
< bitcoin-git> [bitcoin] practicalswift opened pull request #10833: Fix typos (master...typos-201707) https://github.com/bitcoin/bitcoin/pull/10833
< bitcoin-git> [bitcoin] laanwj closed pull request #10818: init: Keep track of whether data directory locked, don't cleanup if not (master...2017_05_locked_datadir) https://github.com/bitcoin/bitcoin/pull/10818
< bitcoin-git> [bitcoin] laanwj opened pull request #10832: init: Factor out AppInitLockDataDirectory (master...2017_07_appinitlockdatadirectory) https://github.com/bitcoin/bitcoin/pull/10832
< bitcoin-git> [bitcoin] sipa closed pull request #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (master...2017/07/qt_fee_slider) https://github.com/bitcoin/bitcoin/pull/10769
< bitcoin-git> bitcoin/master 8fdd23a Pieter Wuille: Merge #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets...
< bitcoin-git> bitcoin/master 2aef1f1 Jonas Schnelli: [Qt] migrate old fee slider value to new dropbown...
< bitcoin-git> bitcoin/master bc1be90 Jonas Schnelli: [Qt] replace fee slider with a Dropdown, extend conf. targets
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1c011ff43010...8fdd23a224ba
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | [WIP] Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. (master...multiwallet_parameters) https://github.com/bitcoin/bitcoin/pull/10816
< bitcoin-git> bitcoin/master 1c011ff Pieter Wuille: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet....
< bitcoin-git> bitcoin/master dd97a52 Alex Morcos: Properly forbid -salvagewallet and -zapwallettxes for multi wallet.
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec8a50b8d786...1c011ff43010
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gmaxwell opened pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831
< bitcoin-git> [bitcoin] sipa closed pull request #10808: Avoid some new gcc warnings in 15 (master...2017-07-15-new-warnings) https://github.com/bitcoin/bitcoin/pull/10808
< bitcoin-git> bitcoin/master ec8a50b Pieter Wuille: Merge #10808: Avoid some new gcc warnings in 15...
< bitcoin-git> bitcoin/master c73b8be Matt Corallo: Explicitly initialize prevector::_union to avoid new warning...
< bitcoin-git> bitcoin/master 1016dac Matt Corallo: Fix signed/unsigned comparison warning introduced in c8e29d7ff0.
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f90603ac6d24...ec8a50b8d786
< gribble> https://github.com/bitcoin/bitcoin/issues/10808 | Avoid some new gcc warnings in 15 by TheBlueMatt · Pull Request #10808 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10618: Remove confusing MAX_BLOCK_BASE_SIZE. (master...size_b_gone) https://github.com/bitcoin/bitcoin/pull/10618
< bitcoin-git> bitcoin/master f90603a Pieter Wuille: Merge #10618: Remove confusing MAX_BLOCK_BASE_SIZE....
< bitcoin-git> bitcoin/master 3babbcb Gregory Maxwell: Remove confusing MAX_BLOCK_BASE_SIZE....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b7d6623c76e1...f90603ac6d24

2017-07-14

< sipa> /home/pw/git/bitcoin-shasse/src/util.cpp:861: undefined reference to `boost::filesystem::path::imbue(std::__1::locale const&)'
< bitcoin-git> [bitcoin] sipa closed pull request #10819: Fix uninitialized atomic variables (master...2017-07-fix-unitialized-atomic) https://github.com/bitcoin/bitcoin/pull/10819
< bitcoin-git> bitcoin/master 4652791 João Barbosa: Fix uninitialized atomic variables
< bitcoin-git> bitcoin/master b7d6623 Pieter Wuille: Merge #10819: Fix uninitialized atomic variables...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66270a416edb...b7d6623c76e1
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10240: Add HD wallet auto-restore functionality (master...2017/04/hd_rescan) https://github.com/bitcoin/bitcoin/pull/10240
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10830: [WIP] [wallet] keypool restore (master...pr10240) https://github.com/bitcoin/bitcoin/pull/10830
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10829: Simple, backwards compatible RPC multiwallet support. (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10829
< bitcoin-git> [bitcoin] Thecave3 closed pull request #10827: fixed grammar error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10827
< bitcoin-git> [bitcoin] sipa closed pull request #10557: Make check to distinguish between orphan txs and old txs more efficient. (master...dontcheckoutputs) https://github.com/bitcoin/bitcoin/pull/10557
< bitcoin-git> bitcoin/master 66270a4 Pieter Wuille: Merge #10557: Make check to distinguish between orphan txs and old txs more efficient....
< bitcoin-git> bitcoin/master 18bacec Alex Morcos: Make check to distinguish between orphan txs and old txs more efficient....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db825d293be8...66270a416edb
< Murch> What would be a good way to reach them? Would that perhaps be worth a mail to the bitcoin-dev list?
< bitcoin-git> [bitcoin] Thecave3 opened pull request #10827: fixed grammar error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10827
< To7> Core dev, time to protect Bitcoin differently.
< bitcoin-git> [bitcoin] fametrano opened pull request #10825: Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 (master...fametrano-regtestport) https://github.com/bitcoin/bitcoin/pull/10825
< mmgen> yet #bitcoin-core-dev doesn't
< mmgen> arubi: agreed, this is offtop, but #bitcoin-dev requires registration doesn't it?
< arubi> mmgen, then your sig is not valid. it's too off topic here. we can move to #bitcoin-dev if you want
< bitcoin-git> [bitcoin] promag opened pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824
< bitcoin-git> [bitcoin] greenaddress opened pull request #10823: Allow all mempool txs to be replaced after a configurable timeout (default 6h) (master...replace-by-fee-old-transactions) https://github.com/bitcoin/bitcoin/pull/10823
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] janstary closed pull request #10805: have proper manpages for bitcoin*(1) (master...master) https://github.com/bitcoin/bitcoin/pull/10805
< wumpus> sipa: hah, no need to wait for that, I compile bitcoin core on openbsd quite a lot
< gribble> https://github.com/bitcoin/bitcoin/issues/10275 | [rpc] Allow fetching tx directly from specified block in getrawtransaction by kallewoof · Pull Request #10275 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon opened pull request #10822: TOTEST: Also server txo from gettxout (not just utxo and mempool) (master...b15-rpc-txo) https://github.com/bitcoin/bitcoin/pull/10822
< bitcoin-git> [bitcoin] laanwj closed pull request #10806: build: verify that the assembler can handle crc32 functions (master...configure-check-asm) https://github.com/bitcoin/bitcoin/pull/10806
< bitcoin-git> bitcoin/master db825d2 Wladimir J. van der Laan: Merge #10806: build: verify that the assembler can handle crc32 functions...
< bitcoin-git> bitcoin/master d34d77a Cory Fields: build: verify that the assembler can handle crc32 functions...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7666250ffb4e...db825d293be8
< bitcoin-git> [bitcoin] sipa opened pull request #10821: Add SSE 4.2 optimized SHA256 (master...20170713_shasse) https://github.com/bitcoin/bitcoin/pull/10821
< luke-jr> the only ways I see to improve on how we do it now are 1) we lost a manpage for bitcoin.conf, and 2) they ideally would be auto-generated during the build
< bitcoin-git> [bitcoin] ReneNyffenegger closed pull request #10768: Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp (master...init-nStart) https://github.com/bitcoin/bitcoin/pull/10768

2017-07-13

< bitcoin-git> [bitcoin] sipa opened pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820
< bitcoin-git> [bitcoin] promag opened pull request #10819: Fix uninitialized atomic variables (master...2017-07-fix-unitialized-atomic) https://github.com/bitcoin/bitcoin/pull/10819
< gribble> https://github.com/bitcoin/bitcoin/issues/10714 | Avoid printing incorrect block indexing time due to uninitialized variable by practicalswift · Pull Request #10714 · bitcoin/bitcoin · GitHub
< jtimon> can someone close https://github.com/bitcoin/bitcoin/pull/10768 ? the author said it but for some reason didn't closed it himself
< rhavar> If you can see why that model doesn't pick the obvious solution (the one you can force it to), I'd be happy to give you a $100 in bitcoin or something :P
< rhavar> I got like 10-15 emails yesterday from people freaking out after the bitcoin.org notice lolz ><
< wumpus> seems time to end the meeting, speculation about the reason for the stop of utxo growth is interesting but not a bitcoin core meeting topic
< luke-jr> jonasschnelli: bitcoin-cli will get these options too.
< luke-jr> jonasschnelli: typical multiwallet use case has wallet=abc.db \n wallet=def.db in bitcoin.conf
< jtimon> bitcoin-cli calls with -wallet that don't need it could just ignore the extra argument and spit a warning somehwere or something?
< luke-jr> jonasschnelli: how do yuo remove it, if it's in bitcoin.conf?
< luke-jr> hmm, bitcoin-cli reads bitcoin.conf, doesn't it? how does that interact? :/
< jonasschnelli> One thing that is a bit cumbersome is that you have to remove the -wallet argument from bitcoin-cli when calling a non wallet command
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier · Pull Request #9728 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9566 | threading: use std::chrono for timestamps by theuni · Pull Request #9566 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< wumpus> PSA: https://github.com/bitcoin/bitcoin/issues/9961, feature freeze is sunday (which is an awful day, it'll probably be monday in practice)
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< bitcoin-git> [bitcoin] laanwj opened pull request #10818: init: Keep track of whether data directory locked, don't cleanup if not (master...2017_05_locked_datadir) https://github.com/bitcoin/bitcoin/pull/10818
< bitcoin-git> [bitcoin] morcos opened pull request #10817: Add a discard_rate to avoid small change (master...discardmore) https://github.com/bitcoin/bitcoin/pull/10817
< morcos> while i have you, can i have your opinion on another RPC agument name change issue, this time all messed up solely by me: https://github.com/bitcoin/bitcoin/pull/10707#issuecomment-314869251
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. (master...multiwallet_parameters) https://github.com/bitcoin/bitcoin/pull/10816
< gribble> https://github.com/bitcoin/bitcoin/issues/10418 | Need fee estimation migration for 0.15 · Issue #10418 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10815 | bitcoin-qt core dumps when bitcoin(d/-qt) is already running · Issue #10815 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< jnewbery> ryanofsky: right. That's what's in the test I provided https://github.com/jnewbery/bitcoin/commit/53be2f334979f2cd979554fe81c4837ad02328cd
< jnewbery> suggest you tcpdump and compare the requests from bitcoin-cli and authproxy
< jonasschnelli> But bitcoin-cli works.. so the endpoint must be registered
< jonasschnelli> jnewbery: Ah.. is was looking for that one: https://github.com/jnewbery/bitcoin/commit/4597818e43900dc07271773f544f47d1da6d635c
< gribble> https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #10814: Change type of op to agree with type of MAX_OPCODE. (master...MAX_OPCODE) https://github.com/bitcoin/bitcoin/pull/10814
< ryanofsky> jonasschnelli, does suggested code in https://github.com/bitcoin/bitcoin/pull/10650#discussion_r123484826 not work?
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10814: Change type of op to agree with type of MAX_OPCODE. (master...MAX_OPCODE) https://github.com/bitcoin/bitcoin/pull/10814
< gribble> https://github.com/bitcoin/bitcoin/issues/10731 | Escape rather than remove any printable characters in UAs by luke-jr · Pull Request #10731 · bitcoin/bitcoin · GitHub
< gmaxwell> UA: OFFICIAL BITCOIN NOTICE. BITCOIN HAS BEEN REPLACED BY ULTRACOIN BUY REPLACEMENT COINS AT BITCOIN.COM NOW
< jonasschnelli> The original idea was also to place a donation bitcoin address there... :/
< bitcoin-git> [bitcoin] jonasschnelli reopened pull request #10731: SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731
< gribble> https://github.com/bitcoin/bitcoin/issues/10731 | SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" by luke-jr · Pull Request #10731 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10731: SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10810: missing white space in function arg (master...missing_white_space) https://github.com/bitcoin/bitcoin/pull/10810
< bitcoin-git> bitcoin/master 7666250 Jonas Schnelli: Merge #10810: missing white space in function arg...
< bitcoin-git> bitcoin/master 69a4339 Lawrence Nahum: missing white space in function arg
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4fcbf797ed3...7666250ffb4e
< bitcoin-git> [bitcoin] sipa closed pull request #10780: Simplify "!foo || (foo && bar)" as "!foo || bar" (master...redundant-condition) https://github.com/bitcoin/bitcoin/pull/10780
< bitcoin-git> bitcoin/master e4fcbf7 Pieter Wuille: Merge #10780: Simplify "!foo || (foo && bar)" as "!foo || bar"...
< bitcoin-git> bitcoin/master 1e3a320 practicalswift: Simplify "!foo || (foo && bar)" as "!foo || bar"
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/479afa0f8486...e4fcbf797ed3

2017-07-12

< bitcoin-git> [bitcoin] sipa closed pull request #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. (master...fix-subscript-0) https://github.com/bitcoin/bitcoin/pull/9804
< bitcoin-git> bitcoin/master 96f2119 Jeremy Rubin: Fix subscript[0] in compressor.cpp
< bitcoin-git> bitcoin/master 500710b Jeremy Rubin: Fix 2 subscript[0] bugs in pubkey.cpp, and eliminate one extra size check
< bitcoin-git> bitcoin/master e0451e3 Jeremy Rubin: Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector
< bitcoin-git> [bitcoin] sipa pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a09a3891fde...479afa0f8486
< gribble> https://github.com/bitcoin/bitcoin/issues/10557 | Make check to distinguish between orphan txs and old txs more efficient. by morcos · Pull Request #10557 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10714: Avoid printing incorrect block indexing time due to uninitialized variable (master...avoid-uninitialized-nStart) https://github.com/bitcoin/bitcoin/pull/10714
< bitcoin-git> bitcoin/master 2a09a38 Pieter Wuille: Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable...
< bitcoin-git> bitcoin/master 959dd87 practicalswift: Avoid printing incorrect block indexing time due to uninitialized variable...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8b95239eeb0...2a09a3891fde
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< BlueMatt> <gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets (master...bitcoin_cli_ipv6) https://github.com/bitcoin/bitcoin/pull/10812
< bitcoin-git> [bitcoin] greenaddress opened pull request #10810: missing white space in function arg (master...missing_white_space) https://github.com/bitcoin/bitcoin/pull/10810
< sipa> we should include that change up into the bitcoin core subtree for 0.15
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< sipa> cfields: ack, fix it in bitcoin-core/leveldb
< bitcoin-git> [bitcoin] petertodd closed pull request #8543: Use ANYONECANPAY if -spendzeroconfchange=0 (master...2016-08-anyonecanpay-if-spendzeroconfchange-disabled) https://github.com/bitcoin/bitcoin/pull/8543
< bitcoin-git> [bitcoin] theuni opened pull request #10809: optim: mark a few classes final (master...final-classes) https://github.com/bitcoin/bitcoin/pull/10809
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10808: Avoid some new gcc warnings in 15 (master...2017-07-15-new-warnings) https://github.com/bitcoin/bitcoin/pull/10808
< bitcoin-git> [bitcoin] instagibbs opened pull request #10807: getbalance example covers at least 6 confirms (master...getbalexample) https://github.com/bitcoin/bitcoin/pull/10807
< jnewbery> arubi: yeah bitcoin-cli over ipv6 seems pretty niche. Can't imagine many people use it
< jnewbery> Does that mean you were able to use bitcoin-cli with ipv6?
< jnewbery> I've added a `-usecli` option to the functional tests which makes all RPCs go through bitcoin-cli. This is the last test that I can't get to run with that option
< jnewbery> I think so. Background is I'm trying to run rpcbind.py. It works when I use direct RPC, but not if I feed all RPC through bitcoin-cli
< gribble> https://github.com/bitcoin/bitcoin/issues/1827 | HTTP client needs IPv6 support · Issue #1827 · bitcoin/bitcoin · GitHub
< jnewbery> Does anyone know if bitcoin-cli is supposed to work with ipv6? I can't seem to make it connect when specifying an ipv6 address in -rpcconnect
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #10806: build: verify that the assembler can handle crc32 functions (master...configure-check-asm) https://github.com/bitcoin/bitcoin/pull/10806
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< jnewbery> wumpus: sorry for the back and forth - i think we can remove #10711 from https://github.com/bitcoin/bitcoin/projects/8 . I still want it to go in, but it's not essential for 0.15 (in fact it could probably go in after feature freeze since it doesn't touch product code)
< gribble> https://github.com/bitcoin/bitcoin/issues/10800 | build: add lto configure option by theuni · Pull Request #10800 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] janstary opened pull request #10805: have proper manpages for bitcoin*(1) (master...master) https://github.com/bitcoin/bitcoin/pull/10805
< bitcoin-git> [bitcoin] promag opened pull request #10804: Add histunspent RPC (master...2017-07-rpc-add-histunspent) https://github.com/bitcoin/bitcoin/pull/10804
< bitcoin-git> [bitcoin] pstratem opened pull request #10803: Explicitly search for bdb5.3. (master...2017-07-02-bdb5.3) https://github.com/bitcoin/bitcoin/pull/10803
< bitcoin-git> [bitcoin] jnewbery opened pull request #10802: [tests] skip zapwallettxes.py (master...skip_zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10802
< cdecker> We might want to think about ways to differentiate once a hard fork occurs, I'm not sure one implementation will want to differentiate itself out of fear of being called non-bitcoin
< jonasschnelli> That: The DNS seed results must consist exclusively of fairly selected and functioning Bitcoin nodes from the public network to the best of the operator's understanding and capability.
< bitcoin-git> [bitcoin] theuni opened pull request #10800: build: add lto configure option (master...enable-lto) https://github.com/bitcoin/bitcoin/pull/10800
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10799: Prevent user from specifying conflicting parameters to fundrawtx (master...2017-07-no-fundraw-conflicts) https://github.com/bitcoin/bitcoin/pull/10799

2017-07-11

< BlueMatt> -> #bitcoin
< bitcoin-git> [bitcoin] jnewbery opened pull request #10798: test bitcoin-cli (master...cli_tests) https://github.com/bitcoin/bitcoin/pull/10798
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getperblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< ryanofsky> am i missing something? https://github.com/bitcoin/bitcoin/pull/9483#discussion_r100077677 seems pretty straightforward and not a large amount of refactoring
< gribble> https://github.com/bitcoin/bitcoin/issues/10794 | Add simple light-client mode (RPC only) by jonasschnelli · Pull Request #10794 · bitcoin/bitcoin · GitHub
< ryanofsky> here is the comment where i point out the duplication: https://github.com/bitcoin/bitcoin/pull/9483#discussion_r100077677
< jonasschnelli> ryanofsky about the CAuxiliaryRequest, where do you think we have duplicated code? Also, what do you think about the points I wrote (https://github.com/bitcoin/bitcoin/pull/10794#issuecomment-314534086)?
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | [qt] Add abstraction layer for accessing node and wallet functionality from gui by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #8369: [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369
< BlueMatt> ok, no big deal, lets move to #bitcoin
< cluelessperson> is currently on my plate, but I was wondering if you might suggest something else that might be more beneficial towards bitcoin development, testing/QA?
< gmaxwell> BlueMatt: I do not believe that LTO fails to work on anything that can compile Bitcoin Core. It's been supported since GCC 4.7
< BlueMatt> is O3 a win in bitcoin?
< gribble> https://github.com/bitcoin/bitcoin/issues/9804 | Fixes subscript 0 ([0]) where should use (var.data()) instead. by JeremyRubin · Pull Request #9804 · bitcoin/bitcoin · GitHub
< gmaxwell> here is something funny: compilng bitcoin with -march=native makes the sha2 in C most of the speed of the sse one. (compiler manages to use rorx)
< BlueMatt> lol, Make Bitcoin CryptoPP Again
< bitcoin-git> [bitcoin] laanwj closed pull request #10712: Add change output if necessary to reduce excess fee (master...addchangehwenoverpaying) https://github.com/bitcoin/bitcoin/pull/10712
< bitcoin-git> bitcoin/master e8b9523 Wladimir J. van der Laan: Merge #10712: Add change output if necessary to reduce excess fee...
< bitcoin-git> bitcoin/master 0f402b9 Alex Morcos: Fix rare edge case of paying too many fees when transaction has no change....
< bitcoin-git> bitcoin/master 253cd7e Alex Morcos: Only reserve key for scriptChange once in CreateTransaction...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca4c545cc7e8...e8b95239eeb0
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10795: No longer ever reuse keypool indexes (master...2017-07-wallet-keypool-overwrite) https://github.com/bitcoin/bitcoin/pull/10795
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9171: Introduce auxiliary block requests (master...2016/11/spv_step_1) https://github.com/bitcoin/bitcoin/pull/9171
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10794: Add simple light-client mode (RPC only) (master...2017/07/spv) https://github.com/bitcoin/bitcoin/pull/10794
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10786: Add PR description to merge commit in github-merge.py (master...20170710_prbody) https://github.com/bitcoin/bitcoin/pull/10786
< bitcoin-git> bitcoin/master ca4c545 Wladimir J. van der Laan: Merge #10786: Add PR description to merge commit in github-merge.py...
< bitcoin-git> bitcoin/master 475c08c Pieter Wuille: Add PR description to merge commit in github-merge.py
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b27b004532db...ca4c545cc7e8
< bitcoin-git> [bitcoin] laanwj closed pull request #10543: Change API to estimaterawfee (master...estimaterawapi) https://github.com/bitcoin/bitcoin/pull/10543
< bitcoin-git> bitcoin/master 5e3b7b5 Alex Morcos: Improve error reporting for estimaterawfee
< bitcoin-git> bitcoin/master 1fafd70 Alex Morcos: Add function to report highest estimate target tracked per horizon
< bitcoin-git> bitcoin/master 9c85b91 Alex Morcos: Change API to estimaterawfee...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cef4b5ccaa37...b27b004532db
< bitcoin-git> [bitcoin] laanwj closed pull request #10651: Verify binaries from bitcoincore.org and bitcoin.org (master...2017-06-verify-coreorg) https://github.com/bitcoin/bitcoin/pull/10651
< bitcoin-git> bitcoin/master cef4b5c Wladimir J. van der Laan: Merge #10651: Verify binaries from bitcoincore.org and bitcoin.org...
< bitcoin-git> bitcoin/master 6270d62 Matt Corallo: Verify binaries from bitcoincore.org and bitcoin.org
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/badd81bd3185...cef4b5ccaa37
< bitcoin-git> [bitcoin] laanwj closed pull request #10792: Replace MAX_OPCODE for OP_NOP10. (master...max-opcode-over-nop10) https://github.com/bitcoin/bitcoin/pull/10792
< bitcoin-git> bitcoin/master badd81b Wladimir J. van der Laan: Merge #10792: Replace MAX_OPCODE for OP_NOP10....
< bitcoin-git> bitcoin/master c8e29d7 Mark Friedenbach: Replace MAX_OPCODE for OP_NOP10....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4f226a133d0...badd81bd3185
< bitcoin-git> [bitcoin] laanwj closed pull request #10190: [tests] mining functional tests (including regression test for submitblock) (master...mining_functional_test) https://github.com/bitcoin/bitcoin/pull/10190
< bitcoin-git> bitcoin/master 38b38cd John Newbery: [tests] getblocktemplate_proposals.py: add logging