< September 2024 >
Su Mo Tu We Th Fr Sa 12345678910 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30
2019-02-24
< flowctrl>
Hello! I downloaded a macos binary, bitcoin-0.17.1-osx.dmg, from bitcoin.org. In the image, there is a file that produces a 'permission denied' error message when I try to copy it to any location. The file is: /Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #15468: wallet: Use fsbridge::ifstream to fix Windows path issue (master...win-wallet-fix) https://github.com/bitcoin/bitcoin/pull/15468
< warren>
https://github.com/bitcoin/bitcoin/pull/15277 Hoping people can help with what is hopefully a simple environment difference between Ubuntu and this other distro. dongcarl is really close to a deterministic replacement for gitian's toolchain. It may only be a matter of figuring out this linker issue then writing a wrapper around the entire thing.
< gmaxwell>
MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/15451 I assume that we broke some altcoin that has other kinds of invs, and the PR author is trying to suggest a comment change that would have avoided his confusion.
< jnewbery>
I have one other announcement: we're closing applications to the residency on Sunday. We've found that some of our best applicants have been referrals, so if you know anyone who you think would be a good Bitcoin contributor, please send them our way! https://residency.chaincode.com
< gribble>
https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< jnewbery>
Hi all. dongcarl is doing great work picking up the p2p refactor project (https://github.com/bitcoin/bitcoin/projects/4). I think it makes sense for him to have write access so he can update that board. Due to github permissions, that would also allow give him write access to do things like tag and close issues. It would *not* give him commit permissions.
< bitcoin-git>
[bitcoin] marcoagner opened pull request #15459: [doc] release process: how to calculate m_assumed_blockchain_size and m_assumed_chain_state_size (master...doc_blockchain_and_chainstate_size_calculation) https://github.com/bitcoin/bitcoin/pull/15459
< bitcoin-git>
[bitcoin] promag opened pull request #15458: refactor: Drop redundant wallet reference (master...2019-02-interfaces-wallet) https://github.com/bitcoin/bitcoin/pull/15458
< bitcoin-git>
[bitcoin] Sjors opened pull request #15457: Check std::system for -[alert|block|wallet]notify (master...2019/02/std__system) https://github.com/bitcoin/bitcoin/pull/15457
< gmaxwell>
and one final one https://github.com/bitcoin-core/secp256k1/pull/568 (which mostly I want plain C code review-- as it previously had a silly pointer vs int bug, though this one touches more complicated code that might leave people unfamilar with the library feeling lost)
< bitcoin-git>
[bitcoin] laanwj merged pull request #15222: docs: Add info about factors that affect dependency list (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15222
< bitcoin-git>
[bitcoin] achow101 opened pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
< bitcoin-git>
[bitcoin] instagibbs opened pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452
< luke-jr>
echeveria: a few years ago, someone decided to tip me unknownst to me, and googled "luke-jr bitcoin address", then paid a random address on the bc.i page (which luckily happened to be my *change* address in the transaction that came up)
< gmaxwell>
luke-jr: at least by transaction count bitcoin core usage appears to outpace electrum something like 5:1
2019-02-19
< gmaxwell>
booyah: and in bitcoin today users generally assume addresses can be reused. It's not a great assumption.
< gmaxwell>
luke-jr: you've had years where you could have also written wallet features in bitcoin core to do stuff like pop up a message saying "You're paying to an address you've paid to before. Is this a mistake? Address reuse can be a symptom of a mistaken double payment and can lead to privacy or funds loss". but apparently it wasn't important enough to you to bother.
< gmaxwell>
Not according to how bitcoin has always worked.
< booyah>
is bitcoin somehow improving strength of normal random as provided by OS specific api?
< gmaxwell>
overwhos fault it was. That kind of footgun isn't what you expect from bitcoin engineering, it sounds like something ethereum would do.
< bitcoin-git>
bitcoin/master e3e1a56 Sjors Provoost: [test] functional: set cwd of nodes to tmpdir
< bitcoin-git>
bitcoin/master 3e4fd40 MarcoFalke: Merge #15415: [test] functional: allow custom cwd, use tmpdir as default
< harding>
promag: works for me via bitcoin-cli on mainnet using commit 4064d048d6 (master from Sunday). Rebuilding now to try on latest.
< bitcoin-git>
[bitcoin] Sjors opened pull request #15441: [doc] build: warn against spaces in working directory (master...2019/02/build_discourage_space) https://github.com/bitcoin/bitcoin/pull/15441
< gmaxwell>
I am just imagining a create dialog with a text entry box where you can enter a seed, and then confused users not realizing they can ignore it, googling bitcoin seed and entering in some example they found online.. :P
< bitcoin-git>
[bitcoin] AkioNak opened pull request #15439: tests: remove byte.hex() to keep compatibility (master...keep_compatiblity) https://github.com/bitcoin/bitcoin/pull/15439
2019-02-18
< belcher>
luke-jr it does, bitcoin core's wallet has the history
< luke-jr>
maybe we should take this to #bitcoin
< belcher>
its a wrapper around bitcoin core's wallet that speaks the electrum server protocol, so it has no extra indexes and is compatible with pruning etc
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433
< gmaxwell>
I don't agree that any reduction of block sizes is "up for discussion" in bitcoin core development. Quite the opposite: You have already been privately censured for creating drama in the press for annoucing some absurd reduction fait accompli when you hadn't even brought the subject up with other developers.
< luke-jr>
bitcoinEnthusias: the only thing up for discussion at this time is a reduction in block sizes; take this topic to #bitcoin if you want to continue it
< jarthur>
bitcoinEnthusias: on the protocol side, sipa has been organizing a BIP for Schnorr signatures. It hasn't officially been proposed yet, and typically an implementation would follow a proposal. https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki if you want to see the current state. bitcoin-dev mailing list a fine place to discuss the proposal
< gribble>
https://github.com/bitcoin/bitcoin/issues/15428 | GUI: Add Pairing tab with Tor onion address as copyable text and QR code by luke-jr · Pull Request #15428 · bitcoin/bitcoin · GitHub
< gmaxwell>
take a step back. I believe the history of this discussion is that luke told someone somewhere don't use wallet X (some untrusted server SPV thing) because its insecure. Then someone said something like "well obviously I'm not going to run bitcoin core on my phone so how should I solve this"?
< gmaxwell>
provoostenator: it is because you don't need to know essentially anything about bitcoin.
< echeveria>
what I don't want to deal with is the bitcoin project being responsible for a bunch of people running outdated, vulnerable tor software that's doing nothing but harm them. include some scripts for setting this up in contrib/ if people really want it. I certainly do not.
< provoostenator>
wumpus: I tend to agree that remote control is a more generic internet problem that can be solved outside of Bitcoin.
< wumpus>
remote control over bitcoin P2P? what?
< wumpus>
routing your traffic over a relay would make zero sense for the bitcoin protocol as all the data is public
< wumpus>
also I've always believed the way forward would be to improve the bitcoin protocol itself; BIP150/151, Dandelion, as well as lightning onion routing
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433
< wumpus>
but tor is illegal in some countries where bitcoin is not so coupling them as the only option is a bad idea
< wumpus>
I don't think we should be shipping tor binaries at all, at least not with the default download, I'm fine with a "tor bitcoin core" bundle
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project file (master...msvc-no-ndebug) https://github.com/bitcoin/bitcoin/pull/15431
< bitcoin-git>
[bitcoin] practicalswift closed pull request #15215: rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]]. (master...getnetworkinfo-getproxy) https://github.com/bitcoin/bitcoin/pull/15215
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) https://github.com/bitcoin/bitcoin/pull/15429
< gmaxwell>
luke-jr: no, but if you care about authentication the bitcoin crypto/auth proposals are better for that...
< gmaxwell>
like will we have to do emergency releases whenever tor has a vuln? ... will we finally get rid of the openssl induced firedrills in bitcoin only to regain them via tor? etc..
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15428: GUI: Add Pairing tab with Tor onion address as copyable text and QR code (master...tor_gui_pairing) https://github.com/bitcoin/bitcoin/pull/15428
< bitcoin-git>
[bitcoin] laanwj merged pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< bitcoin-git>
[bitcoin] sipa opened pull request #15427: Add support for descriptors to utxoupdatepsbt (master...201902_utxoupdatepsbtdesc) https://github.com/bitcoin/bitcoin/pull/15427
2019-02-16
< bitcoin-git>
[bitcoin] harding opened pull request #15426: [Doc] importmulti: add missing description of keypool option (master...2019-02-importmulti-keypool) https://github.com/bitcoin/bitcoin/pull/15426
< bitcoin-git>
[bitcoin] harding opened pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< achow101>
harding: i do. I think it's because bitcoin has a lot of objects which the garbage collector cleans up every so often.
< harding>
achow101: do you use worktrees with any other projects? I do, and I just checked a few and didn't find any of them broken (even ones on the same qube as my bitcoin repository). I don't know what would distinguish bitcoin from other repositories I use; the only thing I can think of is that it's the largest (size and object count) that I use with worktrees.
< harding>
achow101: my git worktrees for the bitcoin repository also broke inexplicably two days ago in between my uses of them. I thought maybe something on my system broke them (I use Qubes 4 + Debian 9), e.g. some symlink was lost, but now I'm wondering if it was something else.
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15421: torcontrol: Launch a private Tor instance when not already running (master...tor_subprocess) https://github.com/bitcoin/bitcoin/pull/15421
< bitcoin-git>
[bitcoin] laanwj merged pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
< bitcoin-git>
bitcoin/master 7cee858 practicalswift: Add compile time verification of assumptions we're currently making implic...
< bitcoin-git>
bitcoin/master 9580190 Wladimir J. van der Laan: Merge #15391: Add compile time verification of assumptions we're currently...
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15419: qa: Always refresh rotten cache to be out of ibd (master...Mf1902-mocktime) https://github.com/bitcoin/bitcoin/pull/15419
< bitcoin-git>
[bitcoin] Sjors opened pull request #15414: [wallet] allow adding pubkeys from imported private keys to keypool (master...2019/02/keypool_import_private_keys) https://github.com/bitcoin/bitcoin/pull/15414
< bitcoin-git>
[bitcoin] practicalswift opened pull request #15413: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (master...validation-cs_main-tests) https://github.com/bitcoin/bitcoin/pull/15413
< bitcoin-git>
[bitcoin] yunchiri closed pull request #15396: docs: make it clearer that posix mode must be used in WSL (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15396
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14075: Import watch only pubkeys to the keypool if private keys are disabled (master...watch-only-keypool) https://github.com/bitcoin/bitcoin/pull/14075
< bitcoin-git>
bitcoin/master 99cccb9 Andrew Chow: Add a method to add a pubkey to the keypool
< bitcoin-git>
bitcoin/master 9b81fd1 Andrew Chow: Fetch keys from keypool when private keys are disabled
< bitcoin-git>
bitcoin/master 513719c Andrew Chow: Add option to importmulti add an imported pubkey to the keypool
< Aequitas_>
Hello, is there a valid bitcoin core binary release signing key? It looks like the key with fingerprint 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 expired today.
< bitcoin-git>
bitcoin/master c45415f Andrew Chow: Refactor keymetadata writing to a separate method
< bitcoin-git>
bitcoin/master e7652d3 Andrew Chow: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
< bitcoin-git>
bitcoin/master bac8c67 Andrew Chow: Add a method to CWallet to write just CKeyMetadata
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14021: Import key origin data through descriptors in importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 0890339 Sjors Provoost: build: prefer python3.4 even if newer versions are present on the system
< bitcoin-git>
bitcoin/master 33480c6 MarcoFalke: Merge #15285: build: Prefer Python 3.4 even if newer versions are present ...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15285: build: Prefer Python 3.4 even if newer versions are present on the system (master...2019/01/bitcoin-util-test-python) https://github.com/bitcoin/bitcoin/pull/15285
< bitcoin-git>
bitcoin/master fa535af MarcoFalke: fuzz: test_runner: Better error message when built with afl
< bitcoin-git>
bitcoin/master 31f7c6d MarcoFalke: Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295