2018-10-25

< wumpus> or maybe they found an exploit in bitcoin-cli and are waiting for you to use it on them :-)
< harding> luke-jr: the list of IPs I scan cam from bitnodes, which I think currently filters out Bitcoin Cash nodes. Obviously so were probably spy nodes and the like.
< luke-jr> I wonder if these 8332s aren't even bitcoin itself?
< esotericnonsense> luke-jr: is it possible to get a bitcoin-like response back with invalid auth
< esotericnonsense> e.g. if you had bitcoind, bitcoin-qt and bitcoin-qt had perms on the socket but other than bitcoin-qt only root did
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< wumpus> an alert RPC, simple as that: https://github.com/laanwj/bitcoin/commit/ace137ff25ab4c7c2a521abe9ba2af0d8af32ec2 (could theoretically make the style flags configurable to send errors etc as well but anyhow xD)
< wumpus> I have various scripts that interface to bitcoin and I use them with the GUI too.
< esotericnonsense> personally i'd probably ask why bitcoin-qt even has the ability to enable RPC
< wumpus> what, if you want to enable RPC in bitcoin-qt you should be able to
< esotericnonsense> i've just jumped in here and stuck some chat in #bitcoin
< gmaxwell> harding: probably making bitcoin make its own template config file when one doesn't exist would help.
< harding> I guess when .bitcoin is created, a default bitcoin.conf could be created with some normal-to-change options and basic comment documentation. I think you'd want to keep it short, rather than providing every possible option, so that people aren't tempted to delete the whole thing and replace it with a random config from the Wiki.
< wumpus> in any case I checked: bitcoin-qt still doesn't enable RPC server by default
< gmaxwell> echeveria crawled the internet and found something like 3000 bitcoin rpc ports listening, which would be a substantial percentage of all p2p listening nodes.
< harding> Looked up the conversation on #bitcoin, the user didn't explicitly say that he was using the default config, so he could've had -server=1.
< harding> I did test on Linux, and bitcoin-qt doesn't do RPC there by default.
< wumpus> harding: setting server=1 in bitcoin.conf should be the only way to enable it with bitcoin-qt
< harding> wumpus: someone in #bitcoin the other day said that RPC was enabled by default on Windows in bitcoin-qt. That surprised me, as I didn't even know bitcoin-qt could expose RPC (I thought you needed to use bitcoind for that). I didn't think to mention it here because I didn't realize that not running RPC with bitcoin-qt was supposed to be a security feature.
< wumpus> I think what discourages people from even trying browser-based attacks is that bitcoin-qt by default has the RPC server disabled, so most unknowning users won't be affected, the people that enable RPC will generally be more technical and hopefully be careful what they allow
< Sentineo> but someoone might try to give you a browser which does not check CORS and connect to your bitcoin through rpc?
< bitcoin-git> [bitcoin] promag opened pull request #14573: qt: Add Wallet and Window menus (master...2018-10-overhaul-menus) https://github.com/bitcoin/bitcoin/pull/14573
< promag> https://github.com/bitcoin/bitcoin/blob/0.17/.travis.yml#L151 should be `travis_retry pip install flake8==3.5.0`
< wumpus> the 0.17 issue is a linter issue?!? https://travis-ci.org/bitcoin/bitcoin/jobs/446184576
< luke-jr> frankly, I think we bumped univalue too prematurely (and ended up with an unnecessary/unreasonable fork in bitcoin/univalue as a result)
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.17: https://github.com/bitcoin/bitcoin/commit/eb2cc84a31fb923b2b25b979682904cb81edec7e
< bitcoin-git> bitcoin/0.17 eb2cc84 Jonas Schnelli: [macOS] Remove DS_Store WindowBounds bytes object...
< promag> wumpus: let me know if https://github.com/bitcoin/bitcoin/pull/14561/files lgty
< bitcoin-git> [bitcoin] laanwj closed pull request #14416: Fix OSX dmg issue (10.12 to 10.14) (master...2018/10/osx_dmg) https://github.com/bitcoin/bitcoin/pull/14416
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/613fc95ee4ea...754a00d55f30
< bitcoin-git> bitcoin/master 43719e0 Jonas Schnelli: [macOS] Remove DS_Store WindowBounds bytes object
< bitcoin-git> bitcoin/master 754a00d Wladimir J. van der Laan: Merge #14416: Fix OSX dmg issue (10.12 to 10.14)...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14571: [tests] Test that nodes respond to getdata with notfound (master...Mf1810-qaNotfound) https://github.com/bitcoin/bitcoin/pull/14571
< gribble> https://github.com/bitcoin/bitcoin/issues/14561 | Remove fs::relative call and fix listwalletdir tests by promag · Pull Request #14561 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14569: travis: Print characters per 9 min to avoid timeout (master...travis-avoid-timeout) https://github.com/bitcoin/bitcoin/pull/14569
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14568: build: Fix Qt link order for Windows build (master...win-qt-fix) https://github.com/bitcoin/bitcoin/pull/14568
< ken2812221> Gitian build for Windows is fail on master branch, I can confirm this with WSL. https://bitcoin.jonasschnelli.ch/build/858
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof closed pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14566: 0.17: qa backports (0.17...Mf1810-qaBackports) https://github.com/bitcoin/bitcoin/pull/14566
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #14565: Overhaul importmulti logic (master...201810_refactor_importmulti) https://github.com/bitcoin/bitcoin/pull/14565
< bitcoin-git> [bitcoin] jameshilliard opened pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564

2018-10-24

< bitcoin-git> [bitcoin] instagibbs closed pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
< bitcoin-git> [bitcoin] instagibbs opened pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
< michagogo> Hm. I just tried fixing https://github.com/bitcoin-core/gitian.sigs/issues/658
< instagibbs> hmm that one is giving some other error, but here's tip of 0.17 https://travis-ci.org/bitcoin/bitcoin/jobs/443960300
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< bitcoin-git> [bitcoin] Neeshmacpaul opened pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b88f67e0bcc...613fc95ee4ea
< bitcoin-git> bitcoin/master 4dca7d0 Chun Kuan Lee: appveyor: Enable multiwallet test
< bitcoin-git> bitcoin/master 613fc95 MarcoFalke: Merge #14559: appveyor: Enable multiwallet tests...
< bitcoin-git> [bitcoin] promag closed pull request #13637: wallet: Add GetBalances to calculate all balances (master...2018-06-wallet-getbalance) https://github.com/bitcoin/bitcoin/pull/13637
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929
< bitcoin-git> [bitcoin] laanwj closed pull request #14320: [bugfix] wallet: Fix duplicate fileid detection (master...2018-09-25-wallet-duplicate-fileid-fix) https://github.com/bitcoin/bitcoin/pull/14320
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6241eb3224d9...2b88f67e0bcc
< bitcoin-git> bitcoin/master 2d796fa Chun Kuan Lee: wallet: Fix duplicate fileid
< bitcoin-git> bitcoin/master 4ea7732 Chun Kuan Lee: tests: add test case for loading copied wallet twice
< bitcoin-git> bitcoin/master 2b88f67 Wladimir J. van der Laan: Merge #14320: [bugfix] wallet: Fix duplicate fileid detection...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14504: tests: show the progress of functional tests (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a74ed3a05b27...6241eb3224d9
< bitcoin-git> bitcoin/master 96c509e Isidoro Ghezzi: show the progress of functional test...
< bitcoin-git> bitcoin/master 6241eb3 MarcoFalke: Merge #14504: tests: show the progress of functional tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #14453: rpc: Fix wallet unload during walletpassphrase timeout (master...2018-10-unload-unlocked-wallet) https://github.com/bitcoin/bitcoin/pull/14453
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9886590116b1...a74ed3a05b27
< bitcoin-git> bitcoin/master 321decf João Barbosa: rpc: Fix wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master 8907df9 João Barbosa: qa: Ensure wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master a74ed3a Wladimir J. van der Laan: Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout...
< luke-jr> not building bitcoin-qt seems a bit extreme though; might make sense to refactor configure to just change the bip70 option
< fanquake> wumpus are we meant to be able to build bitcoin-qt without protobuf after #14451?
< gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support (master...deprecate-bip70) https://github.com/bitcoin/bitcoin/pull/14451
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e15fa16cd3b...9886590116b1
< bitcoin-git> bitcoin/master 9dcf6c0 Wladimir J. van der Laan: build: Add --disable-bip70 configure option...
< bitcoin-git> bitcoin/master 38b9850 Wladimir J. van der Laan: qt: cleanup: Move BIP70 functions together in paymentserver...
< bitcoin-git> bitcoin/master fbb643d James Hilliard: Add BIP70 deprecation warning
< bitcoin-git> [bitcoin] promag closed pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
< wumpus> loool https://github.com/bitcoin/bitcoin/pull/14504#issuecomment-431169025 apparently a spinner makes for a "boring user experience" of the tests, happy that running the tests is so exciting now
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dda5fdf64ca...2e15fa16cd3b
< bitcoin-git> bitcoin/master 585b47c João Barbosa: rpc: Prevent concurrent savemempool
< bitcoin-git> bitcoin/master 2e15fa1 Wladimir J. van der Laan: Merge #12842: Prevent concurrent savemempool...
< bitcoin-git> [bitcoin] laanwj closed pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842
< bitcoin-git> [bitcoin] karel-3d closed pull request #14502: Rpc help helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14296: [wallet] Remove addwitnessaddress (master...remove_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/14296
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/e895fdc9fc83...9dda5fdf64ca
< bitcoin-git> bitcoin/master 67d7d67 John Newbery: [test] Fix flake8 warnings in tests...
< bitcoin-git> bitcoin/master bdefc97 John Newbery: [tests] Remove deprecated addwitnessaddress call from feature_nulldummy...
< bitcoin-git> bitcoin/master 3cf77f0 John Newbery: [tests] Remove deprecated addwitnessaddress call from wallet_dump.py...
< bitcoin-git> [bitcoin] practicalswift closed pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< bitcoin-git> [bitcoin] promag opened pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561
< gribble> https://github.com/bitcoin/bitcoin/issues/14559 | appveyor: Enable multiwallet tests by ken2812221 · Pull Request #14559 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5473e255f687...e895fdc9fc83
< bitcoin-git> bitcoin/master 1c7e25d practicalswift: wallet: Add missing locks
< bitcoin-git> bitcoin/master dee4292 practicalswift: wallet: Add Clang thread safety analysis annotations
< bitcoin-git> bitcoin/master 37b2538 practicalswift: Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634
< promag> ken2812221: I don't understand what you mean here https://github.com/bitcoin/bitcoin/pull/14552#issuecomment-432409103
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< bitcoin-git> [bitcoin] achow101 opened pull request #14558: rpc: Require solvability in importmulti if importing more than the scriptPubKey (master...importmulti-solvability) https://github.com/bitcoin/bitcoin/pull/14558
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14444: Add compile time checking for cs_main locks which we assert at run time (master...move-runtime-checking-to-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/14444
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/94cf1ec94821...5473e255f687
< bitcoin-git> bitcoin/master 0089905 practicalswift: Add compile time checking for cs_main locks which we assert at run time
< bitcoin-git> bitcoin/master 5473e25 MarcoFalke: Merge #14444: Add compile time checking for cs_main locks which we assert at run time...

2018-10-23

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14417: Fix listreceivedbyaddress not taking address as a string (master...fix-rpc-calls-not-taking-valid-strings) https://github.com/bitcoin/bitcoin/pull/14417
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3668bb335c6a...94cf1ec94821
< bitcoin-git> bitcoin/master d4d70ed Eric Scrivner: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> bitcoin/master 94cf1ec MarcoFalke: Merge #14417: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14468: [wallet] Deprecate generate RPC method (master...deprecate_generate) https://github.com/bitcoin/bitcoin/pull/14468
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3f377daaa86...3668bb335c6a
< bitcoin-git> bitcoin/master c269209 John Newbery: [tests] Small fixups before deprecating generate...
< bitcoin-git> bitcoin/master aab8172 John Newbery: [tests] Add generate method to TestNode...
< bitcoin-git> bitcoin/master c9f0295 John Newbery: [wallet] Deprecate the generate RPC method
< bitcoin-git> [bitcoin] hebasto opened pull request #14556: qt: Fix bug #13299 (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
< bitcoin-git> [bitcoin] jimpo opened pull request #14555: Move util files to directory (master...util-cleanup) https://github.com/bitcoin/bitcoin/pull/14555
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14554: qt: Remove unused `adjustedTime` parameter (master...20181023-unused-adjustedtime) https://github.com/bitcoin/bitcoin/pull/14554
< bitcoin-git> [bitcoin] merland opened pull request #14553: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14552: wallet: throw an error if user load the wallet file by different ways (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
< bitcoin-git> [bitcoin] laanwj closed pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
< bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
< bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
< bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539

2018-10-22

< bitcoin-git> [bitcoin] sipa closed pull request #14150: Add key origin support to descriptors (master...201807_minedesc_origin) https://github.com/bitcoin/bitcoin/pull/14150
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c25409d6851...0a8f519a0626
< bitcoin-git> bitcoin/master 2c6281f Pieter Wuille: Add key origin support to descriptors
< bitcoin-git> bitcoin/master ff37459 Pieter Wuille: Add tests for key origin support
< bitcoin-git> bitcoin/master 8afb166 Pieter Wuille: Update documentation to incude origin information
< bitcoin-git> [bitcoin] instagibbs opened pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
< bitcoin-git> [bitcoin] practicalswift closed pull request #13766: Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. (master...initialize-members-in-initialization-list) https://github.com/bitcoin/bitcoin/pull/13766
< bitcoin-git> [bitcoin] practicalswift closed pull request #12984: logs: Make the columns in subsequent UpdateTip log entries horizontally aligned (master...attention-to-detail) https://github.com/bitcoin/bitcoin/pull/12984
< Wadexs> Bitcoin testnet exchange
< echeveria> might be best to continue this in #bitcoin then.
< sanket1729> This code appears to reject blocks 2 hours into future based on local time. https://github.com/bitcoin/bitcoin/blob/5c25409d6851182c5e351720cee36812c229b77a/src/validation.cpp#L3245 . What am I missing?
< sanket1729> Hello, can anyone comment on the following claim. "If there is a clock drifts more than 2 hours and and there are 2 chains similar PoW, then we can have a fork where both chains think they are longest in their own view. So, bitcoin network operates on some synchronous assumptions."
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14540 | Enable flake8 rule E231. by jbampton · Pull Request #14540 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540

2018-10-21

< bitcoin-git> [bitcoin] jbampton opened pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540
< bitcoin-git> [bitcoin] charlesrocket opened pull request #14539: add Apple SDK download and checksum (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
< wumpus> if you're looking for a specific block, you could check block explorers if they have it, or ask here or in #bitcoin
< sanket1729> Hello, I have one small quick question. Does bitcoin core ever prune orphan blocks? I mean do all full nodes have a very old orphan block, say from 2014?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14161: doc/descriptors.md tweaks (master...pr/ddoc) https://github.com/bitcoin/bitcoin/pull/14161
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/73cddb36a88f...5c25409d6851
< bitcoin-git> bitcoin/master eb49412 Russell Yanofsky: doc/descriptors.md tweaks...
< bitcoin-git> bitcoin/master eeeaa29 Russell Yanofsky: descriptors.md: Refer to descriptors as describing instead of matching
< bitcoin-git> bitcoin/master 5c25409 MarcoFalke: Merge #14161: doc/descriptors.md tweaks...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75795603dd2f...73cddb36a88f
< bitcoin-git> bitcoin/master 8640631 Mason Simon: docs: Document lint tests
< bitcoin-git> bitcoin/master 73cddb3 MarcoFalke: Merge #14526: docs: Document lint tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14309: Use non-throwing type-safe ChainType where possible (master...Mf1809-chainType) https://github.com/bitcoin/bitcoin/pull/14309
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96c409c919b9...75795603dd2f
< bitcoin-git> bitcoin/master 97ddc60 practicalswift: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)
< bitcoin-git> bitcoin/master 7579560 MarcoFalke: Merge #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909

2018-10-20

< bitcoin-git> [bitcoin] jbampton opened pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< bitcoin-git> [bitcoin] mrwhythat opened pull request #14533: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/14533
< bitcoin-git> [bitcoin] practicalswift reopened pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
< bitcoin-git> [bitcoin] luke-jr opened pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git> [bitcoin] promag opened pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14530: scripted-diff: Use RPCHelpMan on RPCs with no args (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] laanwj closed pull request #14527: qa: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6746a8951923...96c409c919b9
< bitcoin-git> bitcoin/master fadffae MarcoFalke: Revert "Make qt wallet test compatible with qt4"...
< bitcoin-git> bitcoin/master 96c409c Wladimir J. van der Laan: Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"...
< fanquake> Chris_Stewart_5 See the channel history, we've forked rapidcheck to bitcoin-core, could be a chance to use the new make install method etc. You should have gotten invite to /bitcoin and /bitcoin-core as well.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14528: travis: Compile once on xenial (master...Mf1810-travisXenial) https://github.com/bitcoin/bitcoin/pull/14528
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14527: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< wumpus> invited to bitcoin and bitcoin-core at least
< wumpus> repo created, see https://github.com/bitcoin-core/rapidcheck, who needs commit access?
< fanquake> wumpus thanks. More context in my comment here: https://github.com/bitcoin/bitcoin/pull/14430#issuecomment-431555605
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< fanquake> wumpus Would we be able to fork emil-e/rapidcheck to github.com/bitcoin-core/?
< bitcoin-git> [bitcoin] laanwj closed pull request #14497: docs: Add doc/bitcoin-conf.md (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d433239a8d54...6746a8951923
< bitcoin-git> bitcoin/master 1fb3c16 Hennadii Stepanov: Add `doc/bitcoin-conf.md`
< bitcoin-git> bitcoin/master 6746a89 Wladimir J. van der Laan: Merge #14497: docs: Add doc/bitcoin-conf.md...
< gribble> https://github.com/bitcoin/bitcoin/issues/14497 | docs: Add doc/bitcoin-conf.md by hebasto · Pull Request #14497 · bitcoin/bitcoin · GitHub
< midnightmagic> still burns me atmel dropped avr for arm. wumpus: well if it does anything interesting with the bitcoin node, I know I at least would love to hear about it.
< wumpus> yes, bitcoin runs ok, syncing doesn't go super fast but it was a bit faster than most ARM boards from a few years ago I've tried on
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14456: test: forward timeouts properly in send_blocks_and_test (master...2018-10-test-forward-timeouts) https://github.com/bitcoin/bitcoin/pull/14456
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/544f3234384b...d433239a8d54
< bitcoin-git> bitcoin/master 94e21c1 James O'Beirne: test: forward timeouts properly in send_blocks_and_test
< bitcoin-git> bitcoin/master d433239 MarcoFalke: Merge #14456: test: forward timeouts properly in send_blocks_and_test...
< midnightmagic> runs bitcoin okay? how long did it take to sync with nbd..?
< wumpus> FWIW it runs a bitcoin + lightning node + tor fine :D
< fanquake> wumpus I've looked at the BSD configure issue a bit more. Looks like a bug fix in 1.16 might have broken something we do, https://github.com/bitcoin/bitcoin/issues/14404#issuecomment-431542526
< wumpus> midnightmagic: well... currently only run OpenBSD in VM; and yes, bitcoin builds fine on OpenBSD, there's special instructions for that, which fanquake updated for 6.4 and I'l like to test out but couldn't yet
< bitcoin-git> [bitcoin] fanquake closed pull request #14014: Scripts and tools: fix gitian-build.py --verify option (master...gitian-verify) https://github.com/bitcoin/bitcoin/pull/14014
< bitcoin-git> [bitcoin] fanquake closed pull request #13542: Adding Docker/docker-compose files (master...docker) https://github.com/bitcoin/bitcoin/pull/13542
< bitcoin-git> [bitcoin] fanquake opened pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526
< bitcoin-git> [bitcoin] fanquake closed pull request #13708: docs: Document lint tests (master...document-lint-tests) https://github.com/bitcoin/bitcoin/pull/13708
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/91482e5bf22d...544f3234384b
< bitcoin-git> bitcoin/master b6b9915 Martin Erlandsson: Textual improvements
< bitcoin-git> bitcoin/master 544f323 Pieter Wuille: Merge #14512: docs: Textual improvements in README.md...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e754c6e33194...91482e5bf22d
< bitcoin-git> bitcoin/master 29ed2d6 Hennadii Stepanov: Improve CAmount tests...
< bitcoin-git> bitcoin/master 91482e5 Pieter Wuille: Merge #14460: tests: Improve 'CAmount' tests...
< bitcoin-git> [bitcoin] sipa closed pull request #14011: Disable wallet and address book Qt tests on macOS minimal platform (master...pr/fuqtmac) https://github.com/bitcoin/bitcoin/pull/14011
< gribble> https://github.com/bitcoin/bitcoin/issues/14512 | docs: Textual improvements in README.md by merland · Pull Request #14512 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc1e54206d76...e754c6e33194
< bitcoin-git> bitcoin/master a3197c5 Russell Yanofsky: Disable wallet and address book Qt tests on macOS minimal platform...
< bitcoin-git> bitcoin/master e754c6e Pieter Wuille: Merge #14011: Disable wallet and address book Qt tests on macOS minimal platform...
< gribble> https://github.com/bitcoin/bitcoin/issues/14011 | Disable wallet and address book Qt tests on macOS minimal platform by ryanofsky · Pull Request #14011 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5b47b8efd48d...1b5af2c177ee
< bitcoin-git> bitcoin/0.17 f7dbcaa Sjors Provoost: [doc] getblocktemplate: use SegWit in example
< bitcoin-git> bitcoin/0.17 1b5af2c Pieter Wuille: Merge #14509: [0.17] doc: use SegWit in getblocktemplate example...
< bitcoin-git> [bitcoin] sipa closed pull request #14474: bitcoin-tx: Use constant for n pubkeys check (master...bitcoin_tx_use_constant) https://github.com/bitcoin/bitcoin/pull/14474
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2863c0685a5...dc1e54206d76
< bitcoin-git> bitcoin/master 1f01fe0 Antoine Le Calvez: bitcoin-tx: Use constant for n pubkeys check...
< bitcoin-git> bitcoin/master dc1e542 Pieter Wuille: Merge #14474: bitcoin-tx: Use constant for n pubkeys check...
< bitcoin-git> [bitcoin] sipa closed pull request #14426: utils: Fix broken Windows filelock (master...filelock-test) https://github.com/bitcoin/bitcoin/pull/14426
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b14db5abab40...b2863c0685a5
< bitcoin-git> bitcoin/master 369244f Chun Kuan Lee: utils: Fix broken Windows filelock
< bitcoin-git> bitcoin/master b2863c0 Pieter Wuille: Merge #14426: utils: Fix broken Windows filelock...
< bitcoin-git> [bitcoin] sipa closed pull request #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (master...1<<31-again) https://github.com/bitcoin/bitcoin/pull/14513
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8010ded6da56...b14db5abab40
< bitcoin-git> bitcoin/master bc60c61 practicalswift: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
< bitcoin-git> bitcoin/master b14db5a Pieter Wuille: Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG...
< bitcoin-git> [bitcoin] sipa closed pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d387507aeca6...8010ded6da56
< bitcoin-git> bitcoin/master 7e18673 Kristaps Kaupe: Fix typo
< bitcoin-git> bitcoin/master 8010ded Pieter Wuille: Merge #14524: Trivial: fix typo...

2018-10-19

< bitcoin-git> [bitcoin] kristapsk opened pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524
< jarthur> jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
< gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
< andytoshi> meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core"
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14503 | scantxoutset does not identify UTXO origins · Issue #14503 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< sipa> gwillen: discussed yesterday in the bitcoin core meeting :)
< sipa> welcome to the first bitcoin core wallet meeting!
< bitcoin-git> [bitcoin] jamesob opened pull request #14522: tests: add invalid P2P message tests (master...2018-10-invalid-msgs-test) https://github.com/bitcoin/bitcoin/pull/14522
< bitcoin-git> [bitcoin] hebasto opened pull request #14521: qt, docs: Fix `bitcoin-qt -version` output formatting (master...20181019-qt-cli-license) https://github.com/bitcoin/bitcoin/pull/14521
< midnightmagic> wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time.
< bitcoin-git> [bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
< gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #14475: serialize: Document integer width assumptions we are making when calculating compact sizes (master...integer-width-assumptions) https://github.com/bitcoin/bitcoin/pull/14475
< bitcoin-git> [bitcoin] practicalswift closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
< bitcoin-git> [bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
< bitcoin-git> [bitcoin] practicalswift closed pull request #14010: tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization (master...SelectParams-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/14010
< bitcoin-git> [bitcoin] practicalswift closed pull request #13971: Add tests and error handling to DecodeExtPubKey/DecodeExtKey. Add [[nodiscard]]. (master...DecodeExtKey) https://github.com/bitcoin/bitcoin/pull/13971
< bitcoin-git> [bitcoin] practicalswift closed pull request #14254: build: Add address sanitizer (ASan) Travis job (master...asan) https://github.com/bitcoin/bitcoin/pull/14254
< bitcoin-git> [bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
< gribble> https://github.com/bitcoin/bitcoin/issues/14514 | Version number for `bitcoin.conf` · Issue #14514 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14517: qt: Fix start with the `-min` option (master...20181019-start-minimized-to-tray) https://github.com/bitcoin/bitcoin/pull/14517
< gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #14465: tests: Stop node before removing the notification file (master...test-notification-fix) https://github.com/bitcoin/bitcoin/pull/14465
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8eb2cd1ddaab...d387507aeca6
< bitcoin-git> bitcoin/master ca6d86c Chun Kuan Lee: tests: Stop node before removing the notification file
< bitcoin-git> bitcoin/master d387507 Pieter Wuille: Merge #14465: tests: Stop node before removing the notification file...
< bitcoin-git> [bitcoin] fanquake opened pull request #14515: doc: Update OpenBSD build guide for 6.4 (master...openbsd-6-4) https://github.com/bitcoin/bitcoin/pull/14515
< bitcoin-git> [bitcoin] fanquake closed pull request #14314: Trivial: gitignore contents of db4 folder (master...master) https://github.com/bitcoin/bitcoin/pull/14314

2018-10-18

< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletInfo class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14291: wallet: Add ListWalletDir utility function (master...2018-09-list-wallet-dir) https://github.com/bitcoin/bitcoin/pull/14291
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/3715b2489e98...8eb2cd1ddaab
< bitcoin-git> bitcoin/master fc4db35 João Barbosa: wallet: Add ListWalletDir utility...
< bitcoin-git> bitcoin/master d1b03b8 João Barbosa: interfaces: Add getWalletDir and listWalletDir to Node
< bitcoin-git> bitcoin/master cc33773 João Barbosa: rpc: Add listwalletdir RPC
< gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #13897: clientversion: Define only macros we’ll use (master...remove-unused-macros) https://github.com/bitcoin/bitcoin/pull/13897
< bitcoin-git> [bitcoin] practicalswift closed pull request #13548: Document assumptions made in PeerLogicValidation::SendMessages(...) and rescanblockchain(...) (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/13548
< bitcoin-git> [bitcoin] practicalswift closed pull request #14506: Remove redundancies: redundant forward declaration, redundant namespace, redundant copying, redundant conditionals (master...remove) https://github.com/bitcoin/bitcoin/pull/14506
< bitcoin-git> [bitcoin] practicalswift opened pull request #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (master...1<<31-again) https://github.com/bitcoin/bitcoin/pull/14513
< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() (master...1<<31) https://github.com/bitcoin/bitcoin/pull/14510
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe23553edd84...3715b2489e98
< bitcoin-git> bitcoin/master 96f6dc9 practicalswift: Avoid triggering undefined behaviour in base_uint<BITS>::bits()
< bitcoin-git> bitcoin/master 3715b24 Wladimir J. van der Laan: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits()...
< gribble> https://github.com/bitcoin/bitcoin/issues/14510 | Avoid triggering undefined behaviour in base_uint ::bits() by practicalswift · Pull Request #14510 · bitcoin/bitcoin · GitHub
< wumpus> luke-jr: a bitcoin core-tor bundle has been talked about since 2012 at least