< bitcoin-git>
[bitcoin] promag opened pull request #17237: wallet: LearnRelatedScripts only if KeepDestination (master...2019-10-wallet-reservedestination) https://github.com/bitcoin/bitcoin/pull/17237
< bitcoin-git>
[bitcoin] laanwj merged pull request #17154: wallet: Remove return value from CommitTransaction (master...2019-04-CommitTransaction) https://github.com/bitcoin/bitcoin/pull/17154
< bitcoin-git>
[bitcoin] practicalswift opened pull request #17235: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed. (master...fuzz-initialize-when-needed) https://github.com/bitcoin/bitcoin/pull/17235
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #17233: travis: Run unit and functional tests on native arm (master...1910-travisNativeArm) https://github.com/bitcoin/bitcoin/pull/17233
< bitcoin-git>
[bitcoin] adamjonas opened pull request #17232: Sanity assert GetAncestor() != nullptr where appropriate (master...assert_get_ancestor) https://github.com/bitcoin/bitcoin/pull/17232
< bitcoin-git>
[bitcoin] theuni opened pull request #17231: depends: fix boost mac cross build with clang 9+ (master...fix-boost-clang9) https://github.com/bitcoin/bitcoin/pull/17231
< sdaftuar>
for instance: i think greg once mentioned that you could turn the bitcoin network nodes' mempools into a distributed file system
< bitcoin-git>
[bitcoin] practicalswift opened pull request #17229: tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions (master...fuzzers-base_encode_decode) https://github.com/bitcoin/bitcoin/pull/17229
< bitcoin-git>
[bitcoin] promag opened pull request #17226: gui: Fix payAmount tooltip in SendCoinsEntry (master...2019-10-payamount-tooltip) https://github.com/bitcoin/bitcoin/pull/17226
< wumpus>
(harmless) new clang warning: bitcoin/src/qt/guiutil.cpp:855:26: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
< bitcoin-git>
[bitcoin] practicalswift opened pull request #17225: tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. (master...fuzzers-deserialize-with-roundtrip) https://github.com/bitcoin/bitcoin/pull/17225
< bitcoin-git>
bitcoin/master cd68594 Andrew Chow: Only check the hash of transactions loaded from disk
< bitcoin-git>
bitcoin/master a884b32 Wladimir J. van der Laan: Merge #16911: wallet: Only check the hash of transactions loaded from disk...
< bitcoin-git>
[bitcoin] laanwj merged pull request #16911: wallet: Only check the hash of transactions loaded from disk (master...wallet-skip-checktx) https://github.com/bitcoin/bitcoin/pull/16911
< bitcoin-git>
[bitcoin] JeremyCrookshank closed pull request #17221: refactor: call getDisplayUnit() once instead of three times (master...sendcoincodereuse) https://github.com/bitcoin/bitcoin/pull/17221
< bitcoin-git>
[bitcoin] JeremyCrookshank opened pull request #17221: refactor: call getDisplayUnit() once instead of three times (master...sendcoincodereuse) https://github.com/bitcoin/bitcoin/pull/17221
< bitcoin-git>
[bitcoin] adamjonas opened pull request #17220: tests: Add unit testing for the CompressScript function (master...add_compress_test_cases) https://github.com/bitcoin/bitcoin/pull/17220
< bitcoin-git>
[bitcoin] JeremyCrookshank reopened pull request #17180: gui: Improved tooltip for send amount field (master...sendamounttooltip) https://github.com/bitcoin/bitcoin/pull/17180
< bitcoin-git>
[bitcoin] JeremyCrookshank closed pull request #17180: gui: Improved tooltip for send amount field (master...sendamounttooltip) https://github.com/bitcoin/bitcoin/pull/17180
< bitcoin-git>
[bitcoin] Sjors opened pull request #17219: wallet: allow transaction without change if keypool is empty (master...2019/10/change-without-keypool) https://github.com/bitcoin/bitcoin/pull/17219
< bitcoin-git>
[bitcoin] achow101 opened pull request #17211: Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs (master...fundtx-external-inputs) https://github.com/bitcoin/bitcoin/pull/17211
< jeremyrubin>
BlueMatt: sdaftuar: I'm looking at descendant tracking recently, morcos suggested I ping you both. Similar to https://github.com/bitcoin/bitcoin/pull/15681/files, I'd like to make an exception for OP_SECURETHEBAG transactions where the descendant does not get counted if its parent is an OP_SECUREHTEBAG and it goes through ancestors to some confirmed output, which is an OP_SECURETHEBAG. This property would 'prove' that the
< jeremyrubin>
data is immutable, and therefore impossible to be replaced without a reorg. The issue otherwise is that an OP_SECURETHEBAG transaction tree with a large number of recipients and a small radix quickly surpasses the descendants limit (large radixes can be OK). See https://github.com/bitcoin/bitcoin/compare/master...JeremyRubin:stb-with-rpc?expand=1 for more details on the implementation details
< bitcoin-git>
[bitcoin] practicalswift opened pull request #17208: Make all tests pass UBSan without using any UBSan suppressions (master...ubsan-warnings) https://github.com/bitcoin/bitcoin/pull/17208
< bitcoin-git>
[bitcoin] sadrasabouri reopened pull request #17202: Travis CI bug in macOS environment #17178 solved (master...issue#17178) https://github.com/bitcoin/bitcoin/pull/17202
< bitcoin-git>
[bitcoin] meshcollider closed pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git>
[bitcoin] meshcollider opened pull request #17204: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) (master...201910_1negate_rebase) https://github.com/bitcoin/bitcoin/pull/17204
< bitcoin-git>
bitcoin/master f09ba06 dannmat: doc: Added instructions for how to add an upsteam to forked repo
< bitcoin-git>
bitcoin/master b8f041a fanquake: Merge #17157: doc: Added instructions for how to add an upsteam to forked ...
< bitcoin-git>
[bitcoin] fanquake merged pull request #17157: doc: Added instructions for how to add an upsteam to forked repo (master...Oct-19-Contribution.mc) https://github.com/bitcoin/bitcoin/pull/17157
< bitcoin-git>
[bitcoin] theStack opened pull request #17199: test: use default address type (bech32) for wallet_bumpfee tests (master...20191020-test-wallet-bumpfee_adapt_constants_after_default_address_change) https://github.com/bitcoin/bitcoin/pull/17199
< BlueMatt>
on-topic for this channel: I have a p2p implementation built in rust linking rust-bitcoin's well-fuzzed network message decoder and such to download the chain in a memory-constrained, no-undefined-behavior way inside of bitcoin core :)
< sipa>
actually, that code currently in pubkey.cpp isn't actually even trying to support what bitcoin's consensus rules historically did; just something sufficient for the existing chain
< sipa>
that possibly accepts way more than what bitcoin historically did
< BlueMatt>
well "what bitcoin historically did" is itself poorly-defined :)
< sipa>
a bitcoin consensus implementation obviously needs this
< sipa>
it's a bitcoin core detail
< elichai2>
What do you mean by demo code? And yeah, I think I kind of get it, just weird that it's in both of them. Either libsecp is serving it or it's a bitcoin core detail(Altough it will be a breaking change to remove that from libsecp). Just might be false advertising for users(I.e thinking they're using the Bitcoin core consensus function) if these two impl will ever diverge for some reason
< sipa>
it's just that bitcoin's ecdsa signature parsing is obviously consensus critical, and i don't feel that the demo code in libsecp256k1 should be
< sipa>
the code in secp256k1 is demo that could diverge from the consensus code used in bitcoin
< bitcoin-git>
[bitcoin] fanquake merged pull request #16949: build: only pass --disable-dependency-tracking to packages that understand it (master...no_disable_dependency_tracking) https://github.com/bitcoin/bitcoin/pull/16949
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #17192: util: Add CHECK_NONFATAL and use it in src/rpc (master...1910-utilCHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17192
< bitcoin-git>
[bitcoin] fanquake opened pull request #17191: random: remove call to RAND_screen() (Windows only) (master...remove_openssl_rand_screen) https://github.com/bitcoin/bitcoin/pull/17191
< bitcoin-git>
bitcoin/master 7005d6a Danny-Scott: gui: Add placeholder text to the sign message field
< bitcoin-git>
bitcoin/master f2a0948 fanquake: Merge #17186: gui: Add placeholder text to the sign message field
< bitcoin-git>
[bitcoin] fanquake merged pull request #17186: gui: Add placeholder text to the sign message field (master...oct-2019-sign-message) https://github.com/bitcoin/bitcoin/pull/17186
< kallewoof>
wumpus: not all BIPs have PRs though. (and not all BIPs have PRs to bitcoin core)
< bitcoin-git>
[bitcoin] Danny-Scott opened pull request #17186: gui: Add placeholder text to the sign message field (master...oct-2019-sign-message) https://github.com/bitcoin/bitcoin/pull/17186
< bitcoin-git>
[bitcoin] jonasschnelli merged pull request #15084: gui: don't disable the sync overlay when wallet is disabled (master...sync_overlay_without_wallet) https://github.com/bitcoin/bitcoin/pull/15084
< bitcoin-git>
bitcoin/master 9576614 Martin Erlandsson: doc: Describe log files + consistent paths in test READMEs
< bitcoin-git>
bitcoin/master 88eff96 MarcoFalke: Merge #17177: doc: Describe log files + consistent paths in test READMEs
< bitcoin-git>
[bitcoin] JeremyCrookshank opened pull request #17180: gui: Improved wording/explanation of Bitcoin sends amount box (master...sendamounttooltip) https://github.com/bitcoin/bitcoin/pull/17180
< fanquake>
It might be because we are doing more strict argument passing now? It's also only happens when you run Bitcoin Core for the very first time
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16597: Travis: run full test suite on native macOS (master...2019/08/travis-macos) https://github.com/bitcoin/bitcoin/pull/16597
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 . Pull Request #16341 . bitcoin/bitcoin . GitHub
< bitcoin-git>
[bitcoin] fanquake opened pull request #17169: doc: correct function name in ReportHardwareRand() (master...random_doc_inithardwarerand) https://github.com/bitcoin/bitcoin/pull/17169
< bitcoin-git>
[bitcoin] sandakersmann opened pull request #17166: Changed http:// to https:// on one link in build-unix.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17166
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #17164: p2p: Avoid allocating memory for addrKnown where we don't need it (master...addr_relay_optimization_4) https://github.com/bitcoin/bitcoin/pull/17164