< BlueMatt>
unlike the other things there where views of most people are much too nuanced to categorized, segwit2x is a laughable affront to bitcoin's utility and the technical decisions they're making seem to be entirely based on deliberately ignoring people who tried to give them advice and a deep lack of understanding of the system they're changing
< bitcoin-git>
[bitcoin] achow101 opened pull request #10571: [RPC]Move transaction combining from signrawtransaction to new RPC (master...combineraw-rpc) https://github.com/bitcoin/bitcoin/pull/10571
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10566: Use the "domain name setup" image (previously unused) in the gitian docs (master...unreferenced-file) https://github.com/bitcoin/bitcoin/pull/10566
< bitcoin-git>
[bitcoin] achow101 opened pull request #10565: [coverage] Remove leveldb, univalue, and benchmarks from coverage report (master...lcov-remove-extra) https://github.com/bitcoin/bitcoin/pull/10565
< bitcoin-git>
[bitcoin] morcos opened pull request #10559: Change semantics of HaveCoinInCache to match HaveCoin (master...haveunspentincache) https://github.com/bitcoin/bitcoin/pull/10559
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sdaftuar reopened pull request #10357: Allow setting nMinimumChainWork on command line (master...2017-05-chainwork-commandline) https://github.com/bitcoin/bitcoin/pull/10357
< bitcoin-git>
[bitcoin] laanwj closed pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git>
bitcoin/master 29f80cd Wladimir J. van der Laan: Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of...
< bitcoin-git>
bitcoin/master 3fb81a8 practicalswift: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
< bitcoin-git>
[bitcoin] morcos opened pull request #10557: Make check to distinguish between orphan txs and old txs more efficient. (master...dontcheckoutputs) https://github.com/bitcoin/bitcoin/pull/10557
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10556: Move stop/start functions from utils.py into BitcoinTestFramework (master...testframeworkstopstart) https://github.com/bitcoin/bitcoin/pull/10556
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10555: [tests] various improvements to zmq_test.py (master...zmqtestimprovements) https://github.com/bitcoin/bitcoin/pull/10555
< bitcoin-git>
[bitcoin] laanwj closed pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
< bitcoin-git>
bitcoin/master 35e7f13 Wladimir J. van der Laan: Merge #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}...
< bitcoin-git>
bitcoin/master 246a02f practicalswift: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}
< bitcoin-git>
[bitcoin] laanwj closed pull request #10547: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
< bitcoin-git>
bitcoin/master 71ab6e5 Wladimir J. van der Laan: Merge #10547: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}...
< bitcoin-git>
bitcoin/master 227ae9b practicalswift: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10553: Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon. (master...minor-cleanups) https://github.com/bitcoin/bitcoin/pull/10553
< gribble>
https://github.com/bitcoin/bitcoin/issues/10477 | Use C++ initializer to initialze map and implement map comparator as const by cg31 · Pull Request #10477 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake closed pull request #10477: Use C++ initializer to initialze map and implement map comparator as const (master...master) https://github.com/bitcoin/bitcoin/pull/10477
< bitcoin-git>
[bitcoin] achow101 opened pull request #10552: [Test] Tests for zmqpubrawtx and zmqpubrawblock (master...zmq-raw-tests) https://github.com/bitcoin/bitcoin/pull/10552
< gribble>
https://github.com/bitcoin/bitcoin/issues/10279 | Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces by TheBlueMatt · Pull Request #10279 · bitcoin/bitcoin · GitHub
< wumpus>
bitcoin core compiles almost entirely without changes in c++17 mode, btw
< BlueMatt>
luke-jr: I absolutely do not believe it is false equivalency, actually. We're talking about what precedent is being set for Bitcoin's future and how changes are made in Bitcoin
< BlueMatt>
the idea that its a "bug" (or even an issue) for a user to *not* "upgrade" to enforce a soft fork is laughable...if that were the case, Bitcoin would pretty clearly have no long-term value
< sipa>
luke-jr: i don't "want" BIP148. I want segwit, as I think it's necessary for Bitcoin's future. BIP148 is a overly risky means of obtaining that. That does not mean I oppose it if there were tremendous support, but on itself I think it's a bad idea
< bitcoin-git>
[bitcoin] drizzt opened pull request #10549: Avoid printing generic and duplicated "checking for QT" during ./configure (master...check_qt) https://github.com/bitcoin/bitcoin/pull/10549
< jnewbery>
no need to revert. I was just voicing surprise that it got merged without response to review comments or test cases for the new functionality in bitcoin-tx
< bitcoin-git>
[bitcoin] jnewbery closed pull request #10540: [WIP] Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10547: Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10546: Remove unused Boost includes (master...remove-unused-boost-includes) https://github.com/bitcoin/bitcoin/pull/10546
< bitcoin-git>
[bitcoin] sipa closed pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git>
bitcoin/master be3e042 Pieter Wuille: Merge #10523: Perform member initialization in initialization lists where possible...
< bitcoin-git>
bitcoin/master 656dbd8 practicalswift: Perform member initialization in initialization lists where possible
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git>
[bitcoin] laanwj closed pull request #10201: pass Consensus::Params& to functions in validation.cpp and make them static (master...consensusparams-receivedblocktransactions) https://github.com/bitcoin/bitcoin/pull/10201
< bitcoin-git>
bitcoin/master 1b708f2 Wladimir J. van der Laan: Merge #10201: pass Consensus::Params& to functions in validation.cpp and make them static...
< bitcoin-git>
bitcoin/master 24980a3 Mario Dian: Make functions in validation.cpp static and pass chainparams...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10540: Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git>
[bitcoin] laanwj closed pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git>
[bitcoin] laanwj opened pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git>
bitcoin/0.14 5e408d9 Wladimir J. van der Laan: doc: Update manpages for 0.14.2
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537
2017-06-05
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< bitcoin-git>
[bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
< BlueMatt>
;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()?
< spudowiar>
I'm not talking about the RPC interface Bitcoin Core normally uses
< spudowiar>
Then on first run, Bitcoin Core could allow you to select a vendor and then a device
< spudowiar>
I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one
< bitcoin-git>
[bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS>. (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< sipa>
for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< spudowiar>
One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet
< spudowiar>
The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor`
< gmaxwell>
luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
< spudowiar>
One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< spudowiar>
It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
< spudowiar>
luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
< spudowiar>
But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
< gmaxwell>
spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
< bitcoin-git>
[bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git>
bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
< bitcoin-git>
bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
< spudowiar>
If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
< spudowiar>
Then Bitcoin Core verifies that
< gmaxwell>
uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
< spudowiar>
gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
< bitcoin-git>
[bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512