2017-06-11

< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e7d8f8b7d98...562caf1c74fd
< bitcoin-git> [bitcoin] laanwj closed pull request #10569: Fix stopatheight (master...fix-stopatheight) https://github.com/bitcoin/bitcoin/pull/10569
< bitcoin-git> bitcoin/master 2e7d8f8 Wladimir J. van der Laan: Merge #10569: Fix stopatheight...
< bitcoin-git> bitcoin/master c45cbaf Andrew Chow: Fix stopatheight...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76f268b9bd1b...2e7d8f8b7d98

2017-06-10

< BlueMatt> unlike the other things there where views of most people are much too nuanced to categorized, segwit2x is a laughable affront to bitcoin's utility and the technical decisions they're making seem to be entirely based on deliberately ignoring people who tried to give them advice and a deep lack of understanding of the system they're changing
< luke-jr> can anyone figure out what's up with Travis for https://github.com/bitcoin/bitcoin/pull/10512 ? the same test it's failing on passes locally :/
< bitcoin-git> [bitcoin] achow101 opened pull request #10571: [RPC]Move transaction combining from signrawtransaction to new RPC (master...combineraw-rpc) https://github.com/bitcoin/bitcoin/pull/10571

2017-06-09

< gmaxwell> luke-jr: you should ping everyone listed on this https://en.bitcoin.it/wiki/Segwit_support 1:1 to make sure its accurate.
< bitcoin-git> [bitcoin] sipa closed pull request #10521: Limit variable scope (master...tighten-scope) https://github.com/bitcoin/bitcoin/pull/10521
< bitcoin-git> bitcoin/master 90593ed practicalswift: Limit variable scope
< bitcoin-git> bitcoin/master 76f268b Pieter Wuille: Merge #10521: Limit variable scope...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/29f80cd230c3...76f268b9bd1b
< bitcoin-git> [bitcoin] achow101 opened pull request #10569: Fix stopatheight (master...fix-stopatheight) https://github.com/bitcoin/bitcoin/pull/10569
< bitcoin-git> [bitcoin] practicalswift opened pull request #10568: Remove unnecessary forward class declarations in header files (master...fwd-decl) https://github.com/bitcoin/bitcoin/pull/10568
< bitcoin-git> [bitcoin] practicalswift opened pull request #10566: Use the "domain name setup" image (previously unused) in the gitian docs (master...unreferenced-file) https://github.com/bitcoin/bitcoin/pull/10566
< bitcoin-git> [bitcoin] achow101 opened pull request #10565: [coverage] Remove leveldb, univalue, and benchmarks from coverage report (master...lcov-remove-extra) https://github.com/bitcoin/bitcoin/pull/10565
< bitcoin-git> [bitcoin] gmaxwell opened pull request #10564: Return early in IsBanned. (master...banned-early-term) https://github.com/bitcoin/bitcoin/pull/10564
< bitcoin-git> [bitcoin] achow101 opened pull request #10563: Remove safe mode (master...rm-safemode) https://github.com/bitcoin/bitcoin/pull/10563

2017-06-08

< bitcoin-git> [bitcoin] practicalswift opened pull request #10561: Remove duplicate includes (master...remove-duplicate-includes) https://github.com/bitcoin/bitcoin/pull/10561
< bitcoin-git> [bitcoin] practicalswift opened pull request #10560: Remove non-existing "force safe mode" (-testsafemode). Remove unused constants. (master...noop-modes) https://github.com/bitcoin/bitcoin/pull/10560
< bitcoin-git> [bitcoin] practicalswift closed pull request #10343: Remove redundant on-the-same-line-repetition of type names (DRY): RepeatedTypeName foo = static_cast<RepeatedTypeName>(bar) (master...auto) https://github.com/bitcoin/bitcoin/pull/10343
< gmaxwell> bitcoin/bitcoin/pull/9533
< bitcoin-git> [bitcoin] morcos opened pull request #10559: Change semantics of HaveCoinInCache to match HaveCoin (master...haveunspentincache) https://github.com/bitcoin/bitcoin/pull/10559
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10555 | [tests] various improvements to zmq_test.py by jnewbery · Pull Request #10555 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10512 | Rework same-chain from abusing DoS banning, to explicit checks by luke-jr · Pull Request #10512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10377 | Use rdrand as entropy source on supported platforms by sipa · Pull Request #10377 · bitcoin/bitcoin · GitHub
< jtimon> luke-jr: we could move the main datadir to ./bitcoin/main maybe
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 instagibbs
< bitcoin-git> [bitcoin] sdaftuar reopened pull request #10357: Allow setting nMinimumChainWork on command line (master...2017-05-chainwork-commandline) https://github.com/bitcoin/bitcoin/pull/10357
< bitcoin-git> [bitcoin] laanwj closed pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git> bitcoin/master 29f80cd Wladimir J. van der Laan: Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of...
< bitcoin-git> bitcoin/master 3fb81a8 practicalswift: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c248e39f280...29f80cd230c3
< bitcoin-git> [bitcoin] achow101 closed pull request #9522: [RPC] Fix decoderawtransaction decoding of segwit txs (master...fix-decoderawtx) https://github.com/bitcoin/bitcoin/pull/9522
< jtimon> travis didn't run for https://github.com/bitcoin/bitcoin/pull/9176
< bitcoin-git> [bitcoin] morcos opened pull request #10558: Address nits from per-utxo change (master...10195nits) https://github.com/bitcoin/bitcoin/pull/10558
< bitcoin-git> [bitcoin] morcos opened pull request #10557: Make check to distinguish between orphan txs and old txs more efficient. (master...dontcheckoutputs) https://github.com/bitcoin/bitcoin/pull/10557
< bitcoin-git> [bitcoin] jnewbery opened pull request #10556: Move stop/start functions from utils.py into BitcoinTestFramework (master...testframeworkstopstart) https://github.com/bitcoin/bitcoin/pull/10556
< bitcoin-git> [bitcoin] jnewbery opened pull request #10555: [tests] various improvements to zmq_test.py (master...zmqtestimprovements) https://github.com/bitcoin/bitcoin/pull/10555
< bitcoin-git> [bitcoin] somdoron opened pull request #10554: ZMQ: add publishers for wallet transactions. (master...zmq_wallet_tx) https://github.com/bitcoin/bitcoin/pull/10554
< bitcoin-git> [bitcoin] laanwj closed pull request #10481: Decodehextx scripts sanity check (master...decodehextx-sanity) https://github.com/bitcoin/bitcoin/pull/10481
< bitcoin-git> bitcoin/master 9c248e3 Wladimir J. van der Laan: Merge #10481: Decodehextx scripts sanity check...
< bitcoin-git> bitcoin/master 5b75c47 Andrew Chow: Add a valid opcode sanity check to CScript...
< bitcoin-git> bitcoin/master ac4e438 Andrew Chow: Sanity check transaction scripts in DecodeHexTx...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/35e7f13f68f9...9c248e39f280
< bitcoin-git> [bitcoin] laanwj closed pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
< bitcoin-git> bitcoin/master 35e7f13 Wladimir J. van der Laan: Merge #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}...
< bitcoin-git> bitcoin/master 246a02f practicalswift: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set}
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71ab6e553856...35e7f13f68f9
< bitcoin-git> [bitcoin] laanwj closed pull request #10547: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
< bitcoin-git> bitcoin/master 71ab6e5 Wladimir J. van der Laan: Merge #10547: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}...
< bitcoin-git> bitcoin/master 227ae9b practicalswift: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c2d81f34dc4...71ab6e553856
< bitcoin-git> [bitcoin] practicalswift opened pull request #10553: Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon. (master...minor-cleanups) https://github.com/bitcoin/bitcoin/pull/10553
< bitcoin-git> [bitcoin] laanwj closed pull request #10524: [tests] Remove printf(...) (master...u-for-unsigned-int) https://github.com/bitcoin/bitcoin/pull/10524
< bitcoin-git> bitcoin/master 6c2d81f Wladimir J. van der Laan: Merge #10524: [tests] Remove printf(...)...
< bitcoin-git> bitcoin/master 0abc588 practicalswift: [tests] Remove printf(...)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e801084decf4...6c2d81f34dc4
< gribble> https://github.com/bitcoin/bitcoin/issues/10477 | Use C++ initializer to initialze map and implement map comparator as const by cg31 · Pull Request #10477 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #10477: Use C++ initializer to initialze map and implement map comparator as const (master...master) https://github.com/bitcoin/bitcoin/pull/10477
< bitcoin-git> [bitcoin] achow101 opened pull request #10552: [Test] Tests for zmqpubrawtx and zmqpubrawblock (master...zmq-raw-tests) https://github.com/bitcoin/bitcoin/pull/10552
< bitcoin-git> [bitcoin] jtimon closed pull request #9579: Net: Trivial-review: Make SendMessages easier to review (master...0.15-split-sendmessages) https://github.com/bitcoin/bitcoin/pull/9579

2017-06-07

< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9717 | Pow: Remove fCheckPOW from CheckBlockHeader by jtimon · Pull Request #9717 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10321: Use FastRandomContext for all tests (master...fast_rand_tests) https://github.com/bitcoin/bitcoin/pull/10321
< bitcoin-git> bitcoin/master 124d13a Pieter Wuille: Merge test_random.h into test_bitcoin.h
< bitcoin-git> bitcoin/master 90620d6 Pieter Wuille: scripted-diff: Rename cuckoo tests' local rand context...
< bitcoin-git> bitcoin/master 37e864e Pieter Wuille: Add FastRandomContext::rand256() and ::randbytes()...
< bitcoin-git> [bitcoin] sipa pushed 11 new commits to master: https://github.com/bitcoin/bitcoin/compare/46311e792f4e...e801084decf4
< bitcoin-git> [bitcoin] jtimon closed pull request #10427: Consensus: Introduce static GetScriptFlags (mostly MOVEONLY) (master...b15-consensus-script-flags-min) https://github.com/bitcoin/bitcoin/pull/10427
< ryanofsky> should it be necessary to lock mempool.cs before calling atmp? is this lock needed: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1546
< bitcoin-git> [bitcoin] achow101 opened pull request #10551: [Tests] Wallet encryption functional tests (master...wallet-encrypt-test) https://github.com/bitcoin/bitcoin/pull/10551
< gribble> https://github.com/bitcoin/bitcoin/issues/10279 | Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces by TheBlueMatt · Pull Request #10279 · bitcoin/bitcoin · GitHub
< wumpus> bitcoin core compiles almost entirely without changes in c++17 mode, btw
< BlueMatt> luke-jr: I absolutely do not believe it is false equivalency, actually. We're talking about what precedent is being set for Bitcoin's future and how changes are made in Bitcoin
< BlueMatt> the idea that its a "bug" (or even an issue) for a user to *not* "upgrade" to enforce a soft fork is laughable...if that were the case, Bitcoin would pretty clearly have no long-term value
< sipa> luke-jr: i don't "want" BIP148. I want segwit, as I think it's necessary for Bitcoin's future. BIP148 is a overly risky means of obtaining that. That does not mean I oppose it if there were tremendous support, but on itself I think it's a bad idea
< jtimon> if you are included in https://en.bitcoin.it/wiki/Segwit_support please check that your position is not misrepresented (mine was by mistake)
< bitcoin-git> [bitcoin] pavlosantoniou reopened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< bitcoin-git> [bitcoin] pavlosantoniou closed pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] drizzt opened pull request #10549: Avoid printing generic and duplicated "checking for QT" during ./configure (master...check_qt) https://github.com/bitcoin/bitcoin/pull/10549
< jnewbery> no need to revert. I was just voicing surprise that it got merged without response to review comments or test cases for the new functionality in bitcoin-tx
< wumpus> any opinion on reverting https://github.com/bitcoin/bitcoin/pull/9672 ? seems to have been a bit of a mistake
< bitcoin-git> [bitcoin] laanwj closed pull request #9672: Opt-into-RBF for RPC & bitcoin-tx (master...rpc_rbf) https://github.com/bitcoin/bitcoin/pull/9672
< bitcoin-git> bitcoin/master 36bcab2 Luke Dashjr: RPC/Wallet: Add RBF support for fundrawtransaction
< bitcoin-git> bitcoin/master 891c5ee Luke Dashjr: Wallet: Refactor FundTransaction to accept parameters via CCoinControl
< bitcoin-git> bitcoin/master 578ec80 Luke Dashjr: RPC: rawtransaction: Add RBF support for createrawtransaction
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/be3e042c20e2...46311e792f4e
< bitcoin-git> [bitcoin] jnewbery closed pull request #10540: [WIP] Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git> [bitcoin] practicalswift opened pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
< bitcoin-git> [bitcoin] practicalswift opened pull request #10547: Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
< bitcoin-git> bitcoin/0.14 7a64351 Wladimir J. van der Laan: doc: Fill in details about miniupnp CVE-2017-8798
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/7a643511b474d53f952d3cd403af51aabd104044
< bitcoin-git> [bitcoin] practicalswift opened pull request #10546: Remove unused Boost includes (master...remove-unused-boost-includes) https://github.com/bitcoin/bitcoin/pull/10546
< bitcoin-git> [bitcoin] sipa closed pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git> bitcoin/master be3e042 Pieter Wuille: Merge #10523: Perform member initialization in initialization lists where possible...
< bitcoin-git> bitcoin/master 656dbd8 practicalswift: Perform member initialization in initialization lists where possible
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75e898c094ee...be3e042c20e2

2017-06-06

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10331: Share config between util and functional tests (master...shared_util_function_test_config) https://github.com/bitcoin/bitcoin/pull/10331
< bitcoin-git> bitcoin/master 89fcd35 John Newbery: Use an .ini config file for environment vars in bitcoin-util-test.py
< bitcoin-git> bitcoin/master e9265df John Newbery: Change help_text in bitcoin-util-test.py to a docstring.
< bitcoin-git> bitcoin/master ce58e93 John Newbery: Change bitcoin-util-test.py to use Python3
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/2805d606bc46...75e898c094ee
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10522: [wallet] Remove unused variables (master...unused-strings) https://github.com/bitcoin/bitcoin/pull/10522
< bitcoin-git> bitcoin/master 2805d60 MarcoFalke: Merge #10522: [wallet] Remove unused variables...
< bitcoin-git> bitcoin/master a8c09af practicalswift: Remove unused variables
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/32751807c9c0...2805d606bc46
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances") (master...occurrences) https://github.com/bitcoin/bitcoin/pull/10538
< bitcoin-git> bitcoin/master 3275180 MarcoFalke: Merge #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances")...
< bitcoin-git> bitcoin/master b083db6 practicalswift: [trivial] Fix typo: "occurrences" (misspelled as "occurrances")...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b708f2cf3e6...32751807c9c0
< bitcoin-git> [bitcoin] practicalswift opened pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git> [bitcoin] sipa opened pull request #10544: Update to LevelDB 1.20 (master...leveldb120) https://github.com/bitcoin/bitcoin/pull/10544
< bitcoin-git> [bitcoin] morcos opened pull request #10543: Change API to estimaterawfee (master...estimaterawapi) https://github.com/bitcoin/bitcoin/pull/10543
< bitcoin-git> [bitcoin] ABISprotocol opened pull request #10541: Docs: Update INSTALL.md to add link to dev notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10541
< bitcoin-git> [bitcoin] laanwj closed pull request #10201: pass Consensus::Params& to functions in validation.cpp and make them static (master...consensusparams-receivedblocktransactions) https://github.com/bitcoin/bitcoin/pull/10201
< bitcoin-git> bitcoin/master 1b708f2 Wladimir J. van der Laan: Merge #10201: pass Consensus::Params& to functions in validation.cpp and make them static...
< bitcoin-git> bitcoin/master 24980a3 Mario Dian: Make functions in validation.cpp static and pass chainparams...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/300f8e7a828f...1b708f2cf3e6
< bitcoin-git> [bitcoin] jnewbery opened pull request #10540: Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git> [bitcoin] laanwj closed pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git> [bitcoin] laanwj opened pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git> bitcoin/0.14 5e408d9 Wladimir J. van der Laan: doc: Update manpages for 0.14.2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/5e408d99a219f80e3dab06d3ba03f102d404b886
< bitcoin-git> [bitcoin] laanwj closed pull request #9909: tests: Add FindEarliestAtLeast test for edge cases (master...pr/faltest) https://github.com/bitcoin/bitcoin/pull/9909
< bitcoin-git> bitcoin/master cf66f04 Russell Yanofsky: Add FindEarliestAtLeast test for edge cases...
< bitcoin-git> bitcoin/master 300f8e7 Wladimir J. van der Laan: Merge #9909: tests: Add FindEarliestAtLeast test for edge cases...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/980deaf0b1cc...300f8e7a828f
< bitcoin-git> [bitcoin] laanwj closed pull request #10252: RPC/Mining: Restore API compatibility for prioritisetransaction (master...rpc_prioritise_api) https://github.com/bitcoin/bitcoin/pull/10252
< bitcoin-git> bitcoin/master 980deaf Wladimir J. van der Laan: Merge #10252: RPC/Mining: Restore API compatibility for prioritisetransaction...
< bitcoin-git> bitcoin/master 870824e Luke Dashjr: RPC/Mining: Restore API compatibility for prioritisetransaction...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/30853e16d332...980deaf0b1cc
< bitcoin-git> bitcoin/0.14 cc23438 Wladimir J. van der Laan: qt: 0.14.2 pre-rc2 translations update
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/cc23438af017da8d477e2dbe58a5ba374a691a03
< bitcoin-git> [bitcoin] practicalswift opened pull request #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances") (master...occurrences) https://github.com/bitcoin/bitcoin/pull/10538
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535
< bitcoin-git> bitcoin/master 30853e1 MarcoFalke: Merge #10535: [qa] fundrawtx: Fix shutdown race...
< bitcoin-git> bitcoin/master fa62dad MarcoFalke: [qa] fundrawtx: Fix shutdown race
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67700b39241d...30853e16d332
< bitcoin-git> bitcoin/master 67700b3 Wladimir J. van der Laan: Merge #10345: [P2P] Timeout for headers sync...
< bitcoin-git> [bitcoin] laanwj closed pull request #10345: [P2P] Timeout for headers sync (master...2017-05-timeout-headers-sync) https://github.com/bitcoin/bitcoin/pull/10345
< bitcoin-git> bitcoin/master 76f7481 Suhas Daftuar: Add timeout for headers sync...
< bitcoin-git> bitcoin/master e265200 Suhas Daftuar: Delay parallel block download until chain has sufficient work...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/16f6c98fa8ee...67700b39241d
< bitcoin-git> [bitcoin] laanwj closed pull request #10426: Replace bytes_serialized with bogosize (master...bogosize) https://github.com/bitcoin/bitcoin/pull/10426
< bitcoin-git> bitcoin/master 16f6c98 Wladimir J. van der Laan: Merge #10426: Replace bytes_serialized with bogosize...
< bitcoin-git> bitcoin/master 8b22af3 Pieter Wuille: Replace bytes_serialized with bogosize
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/323a46e03414...16f6c98fa8ee
< bitcoin-git> [bitcoin] laanwj closed pull request #10463: Names: BIP9 vs versionbits (master...b15-bip8-cherry-reanme) https://github.com/bitcoin/bitcoin/pull/10463
< bitcoin-git> bitcoin/master 323a46e Wladimir J. van der Laan: Merge #10463: Names: BIP9 vs versionbits...
< bitcoin-git> bitcoin/master b463bc9 Jorge Timón: scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/...
< bitcoin-git> bitcoin/master 29c0719 shaolinfry: Rename -bip9params to -vbparams
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9fec4da0bec9...323a46e03414
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537

2017-06-05

< bitcoin-git> [bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< gribble> https://github.com/bitcoin/bitcoin/issues/9384 | CCoinsViewCache code cleanup & deduplication by ryanofsky · Pull Request #9384 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #10534: Clarify prevector::erase and avoid swap-to-clear (master...clarify_erase) https://github.com/bitcoin/bitcoin/pull/10534
< bitcoin-git> [bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
< gribble> https://github.com/bitcoin/bitcoin/issues/10463 | Names: BIP9 vs versionbits by jtimon · Pull Request #10463 · bitcoin/bitcoin · GitHub
< jtimon> https://github.com/bitcoin/bitcoin/pull/10502 was created 4 days ago and laready needed rebase twice
< BlueMatt> ;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()?
< btcdrak> wumpus: could you restart the two failing jobs here https://travis-ci.org/bitcoin/bitcoin/builds/238932256
< bitcoin-git> [bitcoin] earonesty opened pull request #10532: -bip148 option (master...bip148) https://github.com/bitcoin/bitcoin/pull/10532
< spudowiar> And provide an option at startup of Bitcoin-Qt to enter the command
< bitcoin-git> [bitcoin] laanwj closed pull request #9740: Add friendly output to dumpwallet (master...dumpwallet) https://github.com/bitcoin/bitcoin/pull/9740
< bitcoin-git> bitcoin/master 9fec4da Wladimir J. van der Laan: Merge #9740: Add friendly output to dumpwallet...
< bitcoin-git> bitcoin/master 164019d aideca: Add dumpwallet output test
< bitcoin-git> bitcoin/master 9f82134 aideca: Add friendly output to dumpwallet refs #9564
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bea5b00cfe95...9fec4da0bec9
< bitcoin-git> [bitcoin] laanwj closed pull request #9745: [RPC] Getting confirmations command (master...add-getconfirmations-to-rpc) https://github.com/bitcoin/bitcoin/pull/9745
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
< bitcoin-git> bitcoin/master bea5b00 MarcoFalke: Merge #10509: Remove xvfb configuration from travis...
< bitcoin-git> bitcoin/master e4bc19f Russell Yanofsky: Remove xvfb configuration from travis...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e654d61d94ee...bea5b00cfe95
< bitcoin-git> [bitcoin] laanwj closed pull request #10489: build: silence gcc7's implicit fallthrough warning (master...wimplicit-fallthrough) https://github.com/bitcoin/bitcoin/pull/10489
< bitcoin-git> bitcoin/master e654d61 Wladimir J. van der Laan: Merge #10489: build: silence gcc7's implicit fallthrough warning...
< bitcoin-git> bitcoin/master cf390df Cory Fields: build: silence gcc7's implicit fallthrough warning...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08d0390a5fea...e654d61d94ee
< bitcoin-git> [bitcoin] laanwj closed pull request #10403: Fix importmulti failure to return rescan errors (master...pr/scansame) https://github.com/bitcoin/bitcoin/pull/10403
< bitcoin-git> bitcoin/master 08d0390 Wladimir J. van der Laan: Merge #10403: Fix importmulti failure to return rescan errors...
< bitcoin-git> bitcoin/master 4d2d604 Russell Yanofsky: Fix importmulti failure to return rescan errors...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0747d3349817...08d0390a5fea
< bitcoin-git> [bitcoin] laanwj closed pull request #10455: Simplify feebumper minimum fee code slightly (master...pr/bumpmin) https://github.com/bitcoin/bitcoin/pull/10455
< bitcoin-git> bitcoin/master 0747d33 Wladimir J. van der Laan: Merge #10455: Simplify feebumper minimum fee code slightly...
< bitcoin-git> bitcoin/master 88b8f0b Russell Yanofsky: Simplify feebumper minimum fee code slightly...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c871f323b418...0747d3349817
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515
< bitcoin-git> bitcoin/master c871f32 MarcoFalke: Merge #10515: [test] Add test for getchaintxstats...
< bitcoin-git> bitcoin/master cc36b5e Jimmy Song: [test] Add test for getchaintxstats
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cec9e1ea6174...c871f323b418
< bitcoin-git> [bitcoin] laanwj closed pull request #10422: Fix timestamp in fee estimate debug message (master...fixtimeunits) https://github.com/bitcoin/bitcoin/pull/10422
< bitcoin-git> bitcoin/master cec9e1e Wladimir J. van der Laan: Merge #10422: Fix timestamp in fee estimate debug message...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e103b3ff1e4f...cec9e1ea6174
< bitcoin-git> bitcoin/master 8d4f401 Alex Morcos: Fix timestamp in fee estimate debug message
< bitcoin-git> [bitcoin] laanwj closed pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
< bitcoin-git> bitcoin/master e103b3f Wladimir J. van der Laan: Merge #10514: Bugfix: missing == 0 after randrange...
< bitcoin-git> bitcoin/master 9aa215b Pieter Wuille: Bugfixes: missing == 0 after randrange
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/296928eb38a4...e103b3ff1e4f
< bitcoin-git> [bitcoin] laanwj closed pull request #10478: rpc: Add listen address to incoming connections in `getpeerinfo` (master...2017_05_peer_listenaddr) https://github.com/bitcoin/bitcoin/pull/10478
< bitcoin-git> bitcoin/master 296928e Wladimir J. van der Laan: Merge #10478: rpc: Add listen address to incoming connections in `getpeerinfo`...
< bitcoin-git> bitcoin/master 3457331 Wladimir J. van der Laan: test: Add test for `getpeerinfo` `bindaddr` field
< bitcoin-git> bitcoin/master a7e3c28 Wladimir J. van der Laan: rpc: Add listen address to incoming connections in `getpeerinfo`...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/400fdd08cc95...296928eb38a4
< bitcoin-git> [bitcoin] colgreen opened pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
< spudowiar> e.g. bitcoin-hww-*
< spudowiar> The other PR we need is making signing asynchronous in Bitcoin Qt
< spudowiar> I'm not talking about the RPC interface Bitcoin Core normally uses
< spudowiar> Then on first run, Bitcoin Core could allow you to select a vendor and then a device
< spudowiar> I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one
< bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS>. (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< gribble> https://github.com/bitcoin/bitcoin/issues/10529 | Improve bitcoind systemd service file by Flowdalic · Pull Request #10529 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Flowdalic opened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
< bitcoin-git> bitcoin/0.14 21e1ed4 Wladimir J. van der Laan: doc: Preliminary release notes 0.14.2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/21e1ed48989e1d150e9f85770fd098534e0f81f1
< bitcoin-git> [bitcoin] fanquake closed pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513

2017-06-04

< gribble> https://github.com/bitcoin/bitcoin/issues/10512 | Rework same-chain from abusing DoS banning, to explicit checks by luke-jr · Pull Request #10512 · bitcoin/bitcoin · GitHub
< sipa> for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers)
< bitcoin-git> [bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< spudowiar> One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet
< spudowiar> The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor`
< spudowiar> sipa: I ended up doing a signrawtransaction-esque API https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1489-L1527
< bitcoin-git> [bitcoin] sipa opened pull request #10526: Force on-the-fly compaction during pertxout upgrade (master...compactrange) https://github.com/bitcoin/bitcoin/pull/10526
< bitcoin-git> [bitcoin] sipa closed pull request #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const (master...master) https://github.com/bitcoin/bitcoin/pull/10471
< bitcoin-git> bitcoin/master 400fdd0 Pieter Wuille: Merge #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const...
< bitcoin-git> bitcoin/master 5f672ca Pavlos Antoniou: net: Denote some CNode functions const
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/098b01dc58ff...400fdd08cc95
< gmaxwell> luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
< spudowiar> One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
< luke-jr> can people check their positions on https://en.bitcoin.it/wiki/Segwit_support and fill in any blanks? thanks
< btcdrak> looks like https://travis-ci.org/bitcoin/bitcoin/builds/238932256 needs of two jobs which stall-errored

2017-06-03

< bitcoin-git> [bitcoin] practicalswift opened pull request #10524: Fix incorrect format strings (master...u-for-unsigned-int) https://github.com/bitcoin/bitcoin/pull/10524
< bitcoin-git> [bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git> [bitcoin] practicalswift opened pull request #10522: Remove unused variables (master...unused-strings) https://github.com/bitcoin/bitcoin/pull/10522
< bitcoin-git> [bitcoin] practicalswift opened pull request #10521: Limit variable scope (master...tighten-scope) https://github.com/bitcoin/bitcoin/pull/10521
< spudowiar> It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
< spudowiar> luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
< spudowiar> But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
< bitcoin-git> [bitcoin] sipa closed pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
< spudowiar> So, I have a HWW plugin (a command called bitcoin-hww-trezor)
< bitcoin-git> [bitcoin] achow101 opened pull request #10519: [RPC] Remove waitforblock and waitfornewblock (master...rm-waitforblock-rpcs) https://github.com/bitcoin/bitcoin/pull/10519
< spudowiar> Or even `bitcoin-qt -hww-server=http://user:password@othermachine:8332` and connect to another bitcoind
< spudowiar> e.g. You could do `bitcoin-qt -hww-cmd=bitcoin-hww-trezor`
< bitcoin-git> [bitcoin] biniek opened pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
< bitcoin-git> [bitcoin] luke-jr opened pull request #10516: Backports for 0.14.2 (0.14...0.14.2_fixes) https://github.com/bitcoin/bitcoin/pull/10516
< bitcoin-git> [bitcoin] jimmysong opened pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515

2017-06-02

< bitcoin-git> [bitcoin] sipa opened pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
< gmaxwell> spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
< bitcoin-git> [bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git> bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
< bitcoin-git> bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/329fc1dce7a1...098b01dc58ff
< spudowiar> If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
< spudowiar> Then Bitcoin Core verifies that
< gmaxwell> uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
< spudowiar> gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
< bitcoin-git> [bitcoin] ABISprotocol opened pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513
< bitcoin-git> [bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
< bitcoin-git> [bitcoin] achow101 opened pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511
< spudowiar> Also, are there any examples of this in the Bitcoin Core code?
< gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
< spudowiar> What's the protocol for adding new strings to Bitcoin Core? Do I have to worry about translation or will that be sorted by others?
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509