< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18249: test: Bump timeouts to accomodate really slow disks (master...2003-testTimeout) https://github.com/bitcoin/bitcoin/pull/18249
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18247: test: Wait for both veracks in add_p2p_connection (master...2003-qaMininodeVerackRace) https://github.com/bitcoin/bitcoin/pull/18247
< bitcoin-git>
[bitcoin] promag opened pull request #18246: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18245: Test some transaction creation with non-empty fee estimator (master...test_est_txn) https://github.com/bitcoin/bitcoin/pull/18245
< bitcoin-git>
[bitcoin] Sjors opened pull request #18244: rpc: have lockUnspents also lock manually selected coins (master...2020/03/rpc_coin_locks) https://github.com/bitcoin/bitcoin/pull/18244
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #18242: Add BIP324 encrypted p2p transport de-/serializer (only used in tests) (master...2020/03/net_v2) https://github.com/bitcoin/bitcoin/pull/18242
< bitcoin-git>
[bitcoin] kallewoof opened pull request #18241: wallet/refactor: refer to CWallet immutably when possible (master...2002-const-fixes) https://github.com/bitcoin/bitcoin/pull/18241
< kallewoof>
sipa, aj, luke-jr: for the record, changing to immutable-CWallet-pointers in places where it made sense (many places did non-const stuff) resulted in 68 changes; see https://github.com/bitcoin/bitcoin/compare/master...kallewoof:2002-const-fixes ... is this something people would concept ack on a PR?
< bitcoin-git>
[bitcoin] meshcollider merged pull request #18224: Make AnalyzePSBT next role calculation simple, correct (master...analyze_psbt_role_simple) https://github.com/bitcoin/bitcoin/pull/18224
< bitcoin-git>
bitcoin/master 1f88624 Samuel Dobson: Merge #18224: Make AnalyzePSBT next role calculation simple, correct
< bitcoin-git>
bitcoin/master 1ef28b4 Gregory Sanders: Make AnalyzePSBT next role calculation simple, correct
< bitcoin-git>
[bitcoin] promag opened pull request #18239: gui: Refactor to drop client and wallet models setters (master...2020-03-drop-setmodel) https://github.com/bitcoin/bitcoin/pull/18239
< bitcoin-git>
[bitcoin] ajtowns opened pull request #18238: net_processing: Retry notfounds with more urgency (master...202002-bump-notfound) https://github.com/bitcoin/bitcoin/pull/18238
< kallewoof>
So, bitcoin core right now seems to lean towards constant func/method parameters to pointers in the form "type* const" (55 instances of "CWallet* const pwallet") over "const type*" (15 instances of "const CWallet*"), but from what I understand, "type* const" means the pointer itself is const (i.e. "pwallet = blarf" is illegal) but the pointed to instance is not const (i.e. pwallet->MutableThing() is legal). I tested this
< bitcoin-git>
[bitcoin] ajtowns opened pull request #18234: scheduler.cpp: Replace boost::mutex,condition_var,chrono with std equivalents (master...202002-scheduler-deboost) https://github.com/bitcoin/bitcoin/pull/18234
2020-02-29
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18232: test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18232
< bitcoin-git>
[bitcoin] instagibbs closed pull request #18214: wallet: Give slightly more understandable advice when needing -fallbackfee (master...fallback_msg) https://github.com/bitcoin/bitcoin/pull/18214
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18225: util: Fail to parse empty string in ParseMoney (master...2002-utilMoney) https://github.com/bitcoin/bitcoin/pull/18225
< bitcoin-git>
[bitcoin] Sjors closed pull request #18220: psbt: AnalyzePSBT set next to"finalizer" when all inputs need finalizing (master...2020/02/analyze_psbt) https://github.com/bitcoin/bitcoin/pull/18220
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18224: Make AnalyzePSBT next role calculation simple, correct (master...analyze_psbt_role_simple) https://github.com/bitcoin/bitcoin/pull/18224
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17921: test: test OP_CSV empty stack fail in feature_csv_activation.py (master...20200113-test-check-for-empty-stack-op_csv) https://github.com/bitcoin/bitcoin/pull/17921
< bitcoin-git>
bitcoin/master 5ffaf88 Sebastian Falbesoner: test: eliminiated magic numbers in feature_csv_activation.py
< bitcoin-git>
bitcoin/master 09f706a Sebastian Falbesoner: test: check for OP_CSV empty stack fail reject reason in feature_csv_activ...
< bitcoin-git>
bitcoin/master cbd345a Sebastian Falbesoner: test: test OP_CSV empty stack fail in feature_csv_activation.py
< bitcoin-git>
[bitcoin] dangershony opened pull request #18223: Add new filer type p2wpkh to blockfilterindex (master...nutrino-p2wpkh-filters) https://github.com/bitcoin/bitcoin/pull/18223
< bitcoin-git>
[bitcoin] Sjors opened pull request #18220: psbt: AnalyzePSBT set next to FINALIZER when all inputs need finalizing (master...2020/02/analyze_psbt) https://github.com/bitcoin/bitcoin/pull/18220
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18214: Give slightly more understandable advice when needing -fallbackfee (master...fallback_msg) https://github.com/bitcoin/bitcoin/pull/18214
< jonasschnelli>
luke-jr: you could register at apple (99$/year) or we could see if we want to sign it with the Bitcoin Core Code Sign Association key.
< luke-jr>
+ imposed by Apple, which the Bitcoin Knots project does not implement.
< luke-jr>
+ to open the Bitcoin Knots .dmg. This is due to new signing requirements
< Kiminuo>
I'll push it to bitcoin repo when I'm sufficiently happy about it
< gribble>
https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
< bitcoin-git>
[bitcoin] fanquake merged pull request #18211: test: Disable mockforward scheduler unit test for now (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
< bitcoin-git>
[bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
< bitcoin-git>
bitcoin/master 4502ed7 fanquake: Merge #18211: test: Disable mockforward scheduler unit test for now
< bitcoin-git>
bitcoin/master fab2527 MarcoFalke: test: Disable mockforward scheduler unit test for now
< bitcoin-git>
[bitcoin] laanwj merged pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
< bitcoin-git>
bitcoin/master e5d47ed Wladimir J. van der Laan: Merge #18167: Fix a violation of C++ standard rules where unions are used ...
< bitcoin-git>
[bitcoin] achow101 closed pull request #18163: descriptors: Use xpub at last hardened step if possible (master...desc-last-hardened) https://github.com/bitcoin/bitcoin/pull/18163
< harding>
stevenroose: I've only used the BitcoinCore.org. Back when I worked on Bitcoin.org, I hand crafted those docs. After years of those docs bitrotting, they wrote their own tool, but I've never used it.
< gleb>
Yeah, at this point I'd also prefer to stick with 256-bit ids, for the reason suhas points out. I also bet someone smart would decide to waste their time to write a paper about attacking bitcoin with this thing :)
< vasild>
I tried to rebase achow101/sign-in-spkman on top of bitcoin/master and got a conflict not related to 17577, but due to #17264 which modified src/wallet/psbtwallet.h (git show 29a21c906 -- src/wallet/psbtwallet.h) and 18115 deleted the file. To resolve, I replayed the change on wallet.h: git rebase bitcoin/master ; git rm src/wallet/psbtwallet.h ; sed -i '' 's/bip32derivs = false/bip32derivs =
< gribble>
https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipsorcery closed pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
< gribble>
https://github.com/bitcoin/bitcoin/issues/17443 | Drop checkFinalTx and use Median Time Past to check finality of wallet transactions by ariard · Pull Request #17443 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake closed pull request #17815: rpc: Make __cookie__ user immune to rpcwhitelist (master...2019-12-rpc-cookie-user-independence) https://github.com/bitcoin/bitcoin/pull/17815
< bitcoin-git>
[bitcoin] fanquake closed pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18199: build: Enable AddressSanitizer as part of --enable-debug (master...enable-debug-asan) https://github.com/bitcoin/bitcoin/pull/18199
< bitcoin-git>
[bitcoin] practicalswift reopened pull request #17208: Make all tests pass UBSan without using any UBSan suppressions (master...ubsan-warnings) https://github.com/bitcoin/bitcoin/pull/17208
< bitcoin-git>
[bitcoin] yancyribbens opened pull request #18195: test: Add cost_of_change parameter assertions to bnb_search_test (master...add-coinselection-cost-of-change-test-cases) https://github.com/bitcoin/bitcoin/pull/18195
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18194: GUI: Remove broken ability to edit the address field in the sending address book (master...bugfix_gui_edit_sendaddr) https://github.com/bitcoin/bitcoin/pull/18194
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18193: scripted-diff: Wallet: Rename incorrectly named *UsedDestination (master...rename_useddest) https://github.com/bitcoin/bitcoin/pull/18193
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #18191: Epoch mempool cache regression plus remove excluded set. (master...epoch-mempool-cache-regression-plus-remove-excluded) https://github.com/bitcoin/bitcoin/pull/18191
2020-02-21
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18183: test: Set catch_system_errors=no on boost unit tests (master...2002-testNoCatchSystemErrors) https://github.com/bitcoin/bitcoin/pull/18183
< bitcoin-git>
bitcoin/master 36e5072 MarcoFalke: Merge #18183: test: Set catch_system_errors=no on boost unit tests
< bitcoin-git>
bitcoin/master fac52da MarcoFalke: test: Set catch_system_errors=no on boost unit tests
< bitcoin-git>
[bitcoin] luke-jr closed pull request #18175: [0.19] build: Allow export of environ symbols and work around rv64 toolchain issue (0.19...pr17569-0.18) https://github.com/bitcoin/bitcoin/pull/18175
< bitcoin-git>
[bitcoin] jonasschnelli closed pull request #18131: add macOS notarization info to the release process doc (master...2020/02/notarize) https://github.com/bitcoin/bitcoin/pull/18131
< bitcoin-git>
[bitcoin] practicalswift closed pull request #17208: Make all tests pass UBSan without using any UBSan suppressions (master...ubsan-warnings) https://github.com/bitcoin/bitcoin/pull/17208
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18188: test: Bump process time in scheduler_tests to avoid race (master...2002-testBumpSched) https://github.com/bitcoin/bitcoin/pull/18188