< Talkless>
Could it be "controversial" to implement addrindex, so that other third party wallets (like Electrum) would not need intermediary server (like Electrumx) to make it work? It could access all info via Bitcoin RPC instead.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18555: wallet: Abort when assumption fails in debug mode (master...2004-walletAssumeAbortDebug) https://github.com/bitcoin/bitcoin/pull/18555
< bitcoin-git>
[bitcoin] mrwhythat opened pull request #18554: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/18554
< bitcoin-git>
bitcoin/master 7a2ecf1 Luke Dashjr: Wallet: Change IsMine check in CWallet::DelAddressBook from assert to fail...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
< bitcoin-git>
bitcoin/master 2952c46 Luke Dashjr: Wallet: Replace CAddressBookData.name with GetLabel() method
< bitcoin-git>
bitcoin/master d7092c3 Luke Dashjr: QA: Test that change doesn't turn into non-change when spent in an avoid-r...
< bitcoin-git>
[bitcoin] sipa opened pull request #18551: Do not clear validationinterface entries being executed (master...202004_fix_validation_notify_clear) https://github.com/bitcoin/bitcoin/pull/18551
2020-04-06
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
< bitcoin-git>
bitcoin/master abc145c MarcoFalke: Merge #18543: test: Use one node to avoid a race due to missing sync in rp...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18543: test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
< bitcoin-git>
bitcoin/master fa2251d MarcoFalke: test: Use one node to avoid a race due to missing sync in rpc_signrawtrans...
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
< bitcoin-git>
bitcoin/master 65b6bdc Luke Dashjr: Wallet: Add CAddressBookData::IsChange which returns true iff label has ne...
< bitcoin-git>
bitcoin/master 144b2f8 Luke Dashjr: Wallet: Require usage of new CAddressBookData::setLabel to change label
< bitcoin-git>
bitcoin/master b86cd15 Luke Dashjr: scripted-diff: Wallet: Rename mapAddressBook to m_address_book
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
< gribble>
https://github.com/bitcoin/bitcoin/issues/18484 | rpc: Correctly compute redeemScript from witnessScript for signrawtransaction by achow101 · Pull Request #18484 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
< luke-jr>
"While the Snap packages use the deterministically generated executables, the Snap tool itself does not provide a streamlined way to reveal the contents of a Snap package. Thus, the Bitcoin Core project does not have the information necessary to help you verify the Bitcoin Core Snap packages."
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
< bitcoin-git>
bitcoin/master 425a7f9 MarcoFalke: Merge #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte
< bitcoin-git>
bitcoin/master 25e03ba Jon Atack: test: relax bumpfee dust_to_fee txsize an extra vbyte
< ryanofsky>
no, my pr is really just a refactor that doesn't change bitcoin behavior. #18338 is an actual bugfix but the implementation relies on behavior only implemented in new boost versions
< ryanofsky>
i don't know how things are normally done. i'd revert it on master for but some reason bitcoin projects treats reverts as more of a big deal than other projects i've worked on
< bitcoin-git>
[bitcoin] fanquake opened pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
2020-04-05
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18533: scripted-diff: Replace strCommand with msg_type (master...2004-netMsgType) https://github.com/bitcoin/bitcoin/pull/18533
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18532: rpc: Avoid initialization-order-fiasco on static CRPCCommand tables (master...2004-rpcNoFiasco) https://github.com/bitcoin/bitcoin/pull/18532
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py (master...20200403-test-check-for-CVE20135700-vuln-in-bip37-tests) https://github.com/bitcoin/bitcoin/pull/18515
< bitcoin-git>
bitcoin/master cf21293 MarcoFalke: Merge #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p...
< bitcoin-git>
bitcoin/master 0ed2d8e Sebastian Falbesoner: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py
< bitcoin-git>
[bitcoin] glowang opened pull request #18530: WIP: add test for -blocksonly and -whitelistforcerelay (master...add_blocksonly_tests) https://github.com/bitcoin/bitcoin/pull/18530
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18509: fuzz: Avoid running over all inputs after merging them (master...2004-fuzzMergeOnce) https://github.com/bitcoin/bitcoin/pull/18509
< bitcoin-git>
bitcoin/master a3b61cf MarcoFalke: Merge #18509: fuzz: Avoid running over all inputs after merging them
< bitcoin-git>
bitcoin/master facc332 MarcoFalke: fuzz: Avoid running over all inputs after merging them
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #18524: refactor: drop boost::signals2 in validationinterface (master...pr/nosig) https://github.com/bitcoin/bitcoin/pull/18524
< bitcoin-git>
[bitcoin] hebasto opened pull request #18523: util: Handle HTTP_INTERNAL_SERVER_ERROR in bitcoin-cli (master...20200404-rpc-depth) https://github.com/bitcoin/bitcoin/pull/18523
< bitcoin-git>
[bitcoin] fanquake closed pull request #18522: test: Add current year to copyright notice (master...add-copyright-year) https://github.com/bitcoin/bitcoin/pull/18522
< bitcoin-git>
[bitcoin] SuriyaaKudoIsc opened pull request #18522: test: Add current year to copyright notice (master...add-copyright-year) https://github.com/bitcoin/bitcoin/pull/18522
< bitcoin-git>
[bitcoin] fanquake closed pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
< bitcoin-git>
[bitcoin] Christewart closed pull request #14430: Add more property based tests for basic bitcoin data structures (master...add_tests_from_8469) https://github.com/bitcoin/bitcoin/pull/14430
< bitcoin-git>
[bitcoin] fanquake opened pull request #18514: test: remove rapidcheck integration and tests (master...remove_rapidcheck) https://github.com/bitcoin/bitcoin/pull/18514
< jonatack>
fanquake: it says: "Additionally, Bitcoin Core does not yet change appearance when macOS "dark mode" is activated." -> what say you to appending ", except if compiling from source." or similar, for dummies like me :)
< fanquake>
jonatack: that's expected. If you're self compiling, and just running src/qt/bitcoin-qt, it will work. If you run deploy and use the app bundle (as releases are built) it wont.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18509: fuzz: Avoid running over all inputs after merging them (master...2004-fuzzMergeOnce) https://github.com/bitcoin/bitcoin/pull/18509
2020-04-02
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18383: refactor: Check for overflow when calculating sum of tx outputs (master...2020-03-value-overflow) https://github.com/bitcoin/bitcoin/pull/18383
< bitcoin-git>
bitcoin/master dce6f3b MarcoFalke: Merge #18383: refactor: Check for overflow when calculating sum of tx outp...
< bitcoin-git>
bitcoin/master f65c9ad Elichai Turkel: Check for overflow when calculating sum of outputs
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
< wumpus>
every change requires changes to all software using bitcoin core, sure, sometimes it's really unavoidable (APIs that don't make sense anymore given our implementation, or are a lot of bother to maintain), but I don't think `getbalance` is that
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18503: init: Replace URL_WEBSITE with PACKAGE_URL (master...2004-initRebrand) https://github.com/bitcoin/bitcoin/pull/18503
< bitcoin-git>
[bitcoin] uzyn opened pull request #18502: doc: Update docs for getbalance (default minconf should be 0) (master...doc-getbalance) https://github.com/bitcoin/bitcoin/pull/18502
< bitcoin-git>
[bitcoin] dongcarl closed pull request #18478: build: Automatically include both `git`-tracked and bootstrapped files. (master...2020-03-adventures-in-reconciling-automake-and-git) https://github.com/bitcoin/bitcoin/pull/18478
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18499: rpc: Make rpc documentation not depend on rpc args (master...2004-rpcStaticDoc) https://github.com/bitcoin/bitcoin/pull/18499
< bitcoin-git>
[bitcoin] jonatack opened pull request #18498: test: enable opening partial p2p connections where useful (master...allow-peer-conn-sans-sync) https://github.com/bitcoin/bitcoin/pull/18498