2018-08-22

< Jmabsd> and so Bitcoin is really only dealing with the "contract endorsement" structures, and hence in the real world those are 72B+1B sighhash=73B max.
< Jmabsd> sipa: ah right, so, the zoomed-out situation in Bitcoin is that DER situations are in sigscript, redeem script (part of sigscript right) and P2WSH witness script (input's last witness element), only.
< sipa> every signature in bitcoin script has a sighash byte
< Jmabsd> Wait, in what situations are sighash bytes not added vs. added, to ecdsa signatures in Bitcoin? With a sighhash byte the DER signature max size is 73B (if low-s, 72B) whereas without sighash byte the max size is 72B (if low-s, 71B).

2018-08-21

< wumpus> but you can be certain it's not about a "string parser", nothing in bitcoin script uses strings
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
< Jmabsd> (ah he responded on #bitcoin, great.)
< sipa> and bitcoin adds a 1 byte sighash to the end
< Jmabsd> (this may be more of a #bitcoin question), what is an authoritative reference on that the DER signature's max size is 72 bytes? i see some discussion like this https://bitcoin.stackexchange.com/questions/12554/why-the-signature-is-always-65-13232-bytes-long but it's not super clea.r
< Jmabsd> wait, where are Bitcoin Core's logics to actually enforce little-endian serialization - say I run Bitcoin Core on an ARM.. is this the line that will cause the big endian (native to my computer) to little endian (serialization form) conversoin: https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L89 ?
< Jmabsd> sipa, the SHA256 specific about Bitcoin is why you need to byte-reverse most(all?) SHA256 libraries' results within Bitcoin merkle tree merkle node calculations, right?
< sipa> (SHA256 internally uses big endian, but that's black box - it's a function that takes as input a byte array and produces another byte array from bitcoin's pov)
< sipa> everything in bitcoin uses little endian
< Jmabsd> Where is Bitcoin Core's serialization and deserialization code for values in various structures such as transactions, block headers, and protocol data? This code shows the endianness used
< gribble> https://github.com/bitcoin/bitcoin/issues/13968 | [wallet] couple of walletcreatefundedpsbt fixes by instagibbs · Pull Request #13968 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14005 | [0.17] depends: fix qt determinism by MarcoFalke · Pull Request #14005 · bitcoin/bitcoin · GitHub

2018-08-20

< wumpus> Zenton: better ask in #bitcoin, this is a developer channel, you'd probably want to mention your perceived threat model for 'secure enough' as well
< gribble> https://github.com/bitcoin/bitcoin/issues/13248 | [gui] Make proxy icon from statusbar clickable by mess110 · Pull Request #13248 · bitcoin/bitcoin · GitHub
< mess110> hi, can I get a few reviews for https://github.com/bitcoin/bitcoin/pull/13248 please?

2018-08-18

< sipa> bitcoin-qt -reindex
< sipa> this discussion should probably move to #bitcoin
< unixb0y> sipa: I run bitcoin-qt tbh :P
< gmaxwell> Unfortunately, Bitcoin actually makes quite full use of the computer and so if its flaky at all it'll croak out. deleting blk and rev files is never going to help anything.
< unixb0y> HI guys, I have a little issue with the initial Bitcoin Core setup.

2018-08-17

< gribble> https://github.com/bitcoin/bitcoin/issues/14000 | depends: fix qt determinism by theuni · Pull Request #14000 · bitcoin/bitcoin · GitHub
< MarcoFalke> gitian-builder/cache/bitcoin-linux-0.17/x86_64-linux-gnu/* I meant
< gmaxwell> I think it's fine to just wait for the next message for bitcoin core, since we ping with a perfectly fine interval.
< gmaxwell> it think it would be really neat for someone to implement a UDP protocol for bitcoin that just runs as a proxy in another process.
< achow101> cfields_: here are my binaries https://github.com/achow101/bitcoin/releases/tag/v0.17.0rc1
< achow101> oh, nvm, i see what you meant by bitcoin-qt being the non-deterministic one
< wumpus> bitcoin-qt only suggests to me it's another non-determinism thing with the qt tooling, maybe file ordering or date/time in metadata in the qrc archives
< ken2812221> The difference is on bitcoin-qt, I've compared it before but I deleted the docker one.
< promag> in 13501, I was puzzled to know why bitcoin-cli worked differently than AuthProxy
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub

2018-08-16

< kevink> I'm using Bitcoin Core's API and am wondering whats the difference between `duplicate-inconclusive` and `duplicate` when calling `submitblock`. I'm just trying to verify that a block exists in the blockchain and `submitblock` seems like the simplest way to do that.
< wumpus> probably the first RISC-V bitcoin node in the world
< gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13311 | Dont edit Chainparams after initialization by jtimon · Pull Request #13311 · bitcoin/bitcoin · GitHub
< jtimon> if high priority is still for blockers, https://github.com/bitcoin/bitcoin/pull/13311 is kind of a blocker for https://github.com/bitcoin/bitcoin/pull/8994 which is itself a blocker for toher things I wanted to do
< gribble> https://github.com/bitcoin/bitcoin/issues/13866 | utils: Use _wfopen and _wfreopen on Windows by ken2812221 · Pull Request #13866 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13968 | [wallet] couple of walletcreatefundedpsbt fixes by instagibbs · Pull Request #13968 · bitcoin/bitcoin · GitHub
< instagibbs> https://github.com/bitcoin/bitcoin/pull/13968 bugfixes for psbt stuff too(0.17 backport)
< gribble> https://github.com/bitcoin/bitcoin/issues/13723 | PSBT key path cleanups by sipa · Pull Request #13723 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 there's only one PR in there at the moment, #13100
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark mi
< gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
< jonasschnelli> wumpus: still building: https://bitcoin.jonasschnelli.ch/build/743

2018-08-15

< gmaxwell> https://github.com/bitcoin/bitcoin/pull/13657 I don't understand this change. Coinbase transactions can be conflicted, by being orphaned block. I guess GetDepthInMainChain doesn't return negative in the case, but I think it probably should.
< fanquake> Unsure how a readme got added with a bunch of references to open PRs? https://github.com/bitcoin/bitcoin/pull/13981#issuecomment-413190203 Not sure if they should be removed or not
< Jmabsd> i would think that Bitcoin accomodated burn already, that's why i was so surprised to see that comment in that bitcoin.org article.
< Jmabsd> sipa: exactly, i'm rading the relay code and can't find it too. so i was thinking maybe that bitcoin.org article is bss*ahem*incorrect*ahem*obsolete.
< sipa> this discussion is more appropriate for #bitcoin or https://bitcoin.stackexchange.com
< Jmabsd> "Bitcoin Core 0.12.0 defaults to relaying and mining null data outputs with up to 83 bytes with any number of data pushes, provided the total byte limit is not exceeded. There must still only be a single null data output and it must still pay exactly 0 satoshis."
< Jmabsd> luke-jr: wrong url sorry, here! https://bitcoin.org/en/developer-guide#standard-transactions
< Jmabsd> there's a weird claim at https://en.bitcoin.it/wiki/Script#Constants that null outputs must have amount == 0 to be relayed. is it so?

2018-08-14

< jonasschnelli> The tor argument "collect now, decrypt later" may not be applicable 1:1 to bitcoin
< sipa> but you don't want existing addnode=IP lines in bitcoin.conf files suddenly fail
< bitcoin-git> [bitcoin] laanwj closed pull request #13960: Fix PSBT deserialization of 0-input transactions (master...fix-decodepsbt-no-in) https://github.com/bitcoin/bitcoin/pull/13960
< bitcoin-git> bitcoin/master 3e5424f Wladimir J. van der Laan: Merge #13960: Fix PSBT deserialization of 0-input transactions...
< bitcoin-git> bitcoin/master 43811e6 Andrew Chow: Fix PSBT deserialization of 0-input transactions...
< bitcoin-git> bitcoin/master bd19cc7 Andrew Chow: Serialize non-witness utxo as a non-witness tx but always deserialize as witness...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/dabfcb03071e...3e5424faf6ff
< gribble> https://github.com/bitcoin/bitcoin/issues/13901 | adduser: The user `bitcoin already exists. Exiting. · Issue #13901 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13826 | packaging: Auto-change datadir in ubuntu ppa · Issue #13826 · bitcoin/bitcoin · GitHub
< Gnappuraz> Hi, I was going through the bitcoin documentation but I can't find the rationale behind the fact of using the prevTx.scriptPubKey in the place of curTx.scriptSig when creating the signature
< wumpus> ken2812221_: problems with bitcoincore.org you can file at https://github.com/bitcoin-core/bitcoincore.org
< waiting2compile> hi, could someone walk me a bit through running Bitcoin's tests? I tried following the instructions in the README.md, though I suspect there's some extra setup that needs to be done that's missing, since running the command just gives make errors and the like (pardon me, I'm new to this and am trying to fix one of the good first bugs :))

2018-08-13

< nmnkgl> MarcoFalke: Could you point me to anything would prevent bitcoin core nodes from having crazy everlasting loops in case when there is a ring of whitelisted peers? In regular mode the loop will break at least because of using INVs. That may be very unlikely case though.
< MarcoFalke> This is bitcoin-core-dev
< gribble> https://github.com/bitcoin/bitcoin/issues/13951 | Hardcoded seeds update pre-0.17 branch by laanwj · Pull Request #13951 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13905 | docs: fixed bitcoin-cli -help output for help2man by hebasto · Pull Request #13905 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< MarcoFalke> wumpus: I think https://github.com/bitcoin/bitcoin/pull/13905 can go in to 0.17 as doc bug fix (tiny one)
< gribble> https://github.com/bitcoin/bitcoin/issues/13666 | Always create signatures with Low R values by achow101 · Pull Request #13666 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13938 | refactoring: Cleanup StartRest() by DesWurstes · Pull Request #13938 · bitcoin/bitcoin · GitHub
< kallewoof> I tried [ createpsbt "[]" "[{\"$(./bitcoin-cli getnewaddress)\":0.01}]" ], which worked fine. But decodepsbt errors for the result.
< gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub

2018-08-12

< gmaxwell> I totally agree that wallets shoudl be batching and whatnot, but consider: we don't even have a friendly way to do that... There is no dohicky in bitcoin core where you can queue a payment, have it draft it, but not send it, waiting for either more payments it can be bached with, timeout, or shutdown trigger.
< MarcoFalke> I was hoping we could do a primitive cache for now and later replace that with https://github.com/bitcoin/bitcoin/pull/13804 (tx pool layer)
< sipa> he left. also, https://bitcoin.stackexchange.com is your friend
< itaseski> i wasn't able to find anything bitcoin specific ...
< devmob> hi, I'd really like to know how bitcoin does gossip, like how the gossip protocol is implemented
< reald0ff1> well thanks for the answer. I think I will try to contact bitcoincore.org via email and bitcoin.org also via email to the website maintainer. Maybe some of them could provide me stats
< harding> reald0ff1: I don't know if anyone has that information for BitcoinCore.org, sorry. In addition, the binaries can also be downloaded from Bitcoin.org (maintained by a different team) or via a torrent (with optional magnet URI) that contains the binaries for all platforms.
< reald0ff1> Can someone please provide me download stats (or at least share in %) of bitcoin core, regarding the different platform versions (Win, Linux, OSX, etc) ?

2018-08-10

< gribble> https://github.com/bitcoin/bitcoin/issues/13930 | Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader by Sjors · Pull Request #13930 · bitcoin/bitcoin · GitHub
< ken2812221> I wonder why the linter failed? https://travis-ci.org/bitcoin/bitcoin/jobs/414449333
< sipa> this channel is mostly about developmemt of the bitcoin core software
< sipa> Jmabsd: i think your questions are probably better suited for bitcoin.stackexchange.com
< Jmabsd> are we in a place today where you can assume that every relevant participant in the Bitcoin ecosystem will be fine with Bitcoin transactions with version = 2?

2018-08-09

< sipa> 2018-08-09T18:55:00.301077Z receive version message: /bitcoinj:0.14.7/Bitcoin Wallet:6.28/: version 70001, blocks=535894, us=127.0.0.1:8333, peer=414
< sipa> and your ISP's cost, and the bitcoin exchange rate?
< gribble> https://github.com/bitcoin/bitcoin/issues/13808 | wallet: shuffle coins before grouping, where warranted by kallewoof · Pull Request #13808 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13922 | Lower default relay fees by ajtowns · Pull Request #13922 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13666 | Always create signatures with Low R values by achow101 · Pull Request #13666 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13922 | Lower default relay fees by ajtowns · Pull Request #13922 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< wumpus> pierre_rochard: I did some analysis of the bitcoin source using clang a long time ago, using the python clang bindings (clang.cindex)
< pierre_rochard> searching the repo turned up this recent comment from skeees https://github.com/bitcoin/bitcoin/pull/13815#issuecomment-409795628 which makes it sound like a material undertaking
< sipa> Jmabsd: https://bitcoin.stackexchange.com may be a better place to ask these things
< gribble> https://github.com/bitcoin/bitcoin/issues/13922 | Lower default relay fees by ajtowns · Pull Request #13922 · bitcoin/bitcoin · GitHub
< Jmabsd> aj: ah, so Bitcoin Core nodes will accept a nonstandard tx when it's in a block, but it will not accept them in gossiping, right?
< Jmabsd> Where in Bitcoin Core's code are the constraints on what scripts are allowed, implemented? E.g., gossiped transaction's lock scripts must be either of P2PK, P2PKH, multisig, nulldata or P2SH in order to be considered valid and be gossiped?
< Jmabsd> code question, https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1162 - when generating the sign text for OP_CHECKSIG, the code to produce the signtext with respect to one transaction output, is just " ::Serialize(s, txTo.vout[nOutput]);".

2018-08-08

< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13442 | Convert the 1-way SSE4 SHA256 code from asm to intrinsics by sipa · Pull Request #13442 · bitcoin/bitcoin · GitHub
< gmaxwell> lordcow in #bitcoin reports a compile failure on freebsd: https://pastebin.com/wBN0YChc
< jonasschnelli> I'm implementing BIP151 message structures: https://github.com/bitcoin/bips/blob/master/bip-0151.mediawiki#encrypted-messages-structure

2018-08-07

< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< MarcoFalke> githubs send from:"notifications@github.com" to:"bitcoin@noreply.github.com" with cc:"comment@noreply.github.com" and cc you
< harding> MarcoFalke: to ping privately, the bot could just pull the email address of the committer from the most recent commit message and email them. Alternatively, the bot could open an issue on the repository they're making their PR from, e.g. github.com/harding/bitcoin/issues/new
< gribble> https://github.com/bitcoin/bitcoin/issues/13808 | wallet: shuffle coins before grouping, where warranted by kallewoof · Pull Request #13808 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13667 | wallet: Fix backupwallet for multiwallets by domob1812 · Pull Request #13667 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13788 | Fix --disable-asm for newer assembly checks/code by luke-jr · Pull Request #13788 · bitcoin/bitcoin · GitHub

2018-08-06

< gribble> https://github.com/bitcoin/bitcoin/issues/11640 | Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection by ryanofsky · Pull Request #11640 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13890 | PGP: 18AE2F798E0D239755DA4FD24B79F986CBDF8736 BTC: bc1q9md8qvhuswr9wgj8re2wscsfcxel3wvmdmeg96 31orZSrFb8ES1f5g8ogyzZZZb4MzsGkreu · Issue #13890 · bitcoin/bitcoin · GitHub

2018-08-05

< viaj3ro> have an issue with my 0.16.2 node: https://github.com/bitcoin/bitcoin/issues/13885
< gmaxwell> jl2012: bitcoin core doesn't even serve SPV proofs for arbritary transactions today!
< gmaxwell> The bitcoin protocol doesn't generate SPV proofs for arbritary transactions, it certantly isn't consensus critical to do so! :)
< wumpus> depending on how technical the question is, #bitcoin might be a better place to ask if it's about high-level concepts and not implementation
< devmob> anyone here I can talk to about bitcoin's p2p layer ?

2018-08-04

< BlueMatt> is a rust-lightning client that uses bitcoin core's rpc

2018-08-03

< gribble> https://github.com/bitcoin/bitcoin/issues/13696 | Add aarch64 qt depends support for cross compiling bitcoin-qt by TheCharlatan · Pull Request #13696 · bitcoin/bitcoin · GitHub
< ossifrage> Oh, I was thinking of this: https://github.com/bitcoin/bitcoin/pull/12495

2018-08-02

< gmaxwell> https://github.com/bitcoin/bitcoin/pull/12495#issuecomment-367815005 < eklitzke suggests increasing leveldb's mmap limit here. ossifrage also apparently did that and reported it fixed his problems, though his specific problems are likely better fixed by switching to poll.
< gribble> https://github.com/bitcoin/bitcoin/issues/12495 | Increase LevelDB max_open_files by eklitzke · Pull Request #12495 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12613 | [CI] Adding MSVC build to CI check with Appveyor · Issue #12613 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13789 | crypto/sha256: Use pragmas to enforce necessary intrinsics for GCC and Clang by luke-jr · Pull Request #13789 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< gribble> https://github.com/bitcoin/bitcoin/issues/13754 | Windows crashes for -wallet=你好 · Issue #13754 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13426 | [bugfix] Fix encoding issue for Windows by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13697 | Support output descriptors in scantxoutset by sipa · Pull Request #13697 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13844 | doc: correct the help output for -prune by hebasto · Pull Request #13844 · bitcoin/bitcoin · GitHub
< ossifrage> mmap() is a great way to generate a very large amount of write pressure, but it seems like most of the leveldb use in bitcoin has a very low change rate

2018-08-01

< sipa> the library implementing the elliptic curve things is in bhttps://github.com/bitcoin-core/secp256k1
< achow101> there's a library that implements all of that stuff: https://github.com/bitcoin-core/secp256k1
< sipa> actually, #bitcoin-commits already exists
< gribble> https://github.com/bitcoin/bitcoin/issues/13662 | Explain when reindex-chainstate can be used instead of reindex by Sjors · Pull Request #13662 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13676 | Explain that mempool memory is added to -dbcache during IBD by Sjors · Pull Request #13676 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< skeees> BlueMatt: sorry missed that one, updated in https://github.com/bitcoin/bitcoin/pull/13835
< ossifrage> Oh, in my case it was bitcoin-qt not bitcoind
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (master...scheduler-tests) https://github.com/bitcoin/bitcoin/pull/13247
< bitcoin-git> bitcoin/master cbeaa91 Jesse Cohen: Update ValidationInterface() documentation to explicitly specify threading and memory model
< bitcoin-git> bitcoin/master b296b42 Jesse Cohen: Update documentation for SingleThreadedSchedulerClient() to specify the memory model
< bitcoin-git> bitcoin/master 9994d01 Jesse Cohen: Add Unit Test for SingleThreadedSchedulerClient...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0fb9c87815d1...e83d82a85c53
< sipa> bitcoind 11155 pw 40r REG 252,1 2173957 779300 /home/pw/.bitcoin/chainstate/864998.ldb
< sipa> bitcoind 11155 pw mem REG 252,1 2173885 783231 /home/pw/.bitcoin/chainstate/864555.ldb
< ossifrage> I have txindex and sadly my bitcoin data is on a btrfs filesystem (a mistake I won't make again)

2018-07-31

< bitcoin-git> [bitcoin] jnewbery opened pull request #13825: [wallet] [Do not merge until v0.18] Kill accounts (master...kill_accounts) https://github.com/bitcoin/bitcoin/pull/13825
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13824: doc: Remove outdated net comment (master...Mf1808-docNetCritSec) https://github.com/bitcoin/bitcoin/pull/13824
< ossifrage> it looks like bitcoin-qt is using up 800 FDs for open files (chainstate, txindex, etc...)
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13822: bench: Make CoinSelection output groups pass eligibility filter (master...fix-out-groups-bench) https://github.com/bitcoin/bitcoin/pull/13822
< ossifrage> I didn't think bitcoin would be using select(), I thought it would be using epoll() and friends?
< bitcoin-git> bitcoin/master 0fb9c87 MarcoFalke: Merge #13822: bench: Make CoinSelection output groups pass eligibility filter...
< bitcoin-git> bitcoin/master 494634a Andrew Chow: bench: Make CoinSelection output groups pass eligibility filter...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d3623794a10...0fb9c87815d1
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13823: qa: quote path in authproxy for external multiwallets (master...Mf1808-qaAuthProxyQuotePath) https://github.com/bitcoin/bitcoin/pull/13823
< bitcoin-git> [bitcoin] laanwj closed pull request #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) (master...call-IsIPv6-in-GetIn6Addr) https://github.com/bitcoin/bitcoin/pull/13776
< bitcoin-git> bitcoin/master 7d36237 Wladimir J. van der Laan: Merge #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)...
< bitcoin-git> bitcoin/master 2fb0066 practicalswift: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/230652cafc51...7d3623794a10
< bitcoin-git> [bitcoin] achow101 opened pull request #13822: bench: Make CoinSelection output groups pass eligibility filter (master...fix-out-groups-bench) https://github.com/bitcoin/bitcoin/pull/13822
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13799: Ignore unknown config file options; warn instead of error (master...201807_warnunknown) https://github.com/bitcoin/bitcoin/pull/13799
< bitcoin-git> bitcoin/master 230652c MarcoFalke: Merge #13799: Ignore unknown config file options; warn instead of error...
< bitcoin-git> bitcoin/master 247d574 Pieter Wuille: Ignore unknown config file options for now
< bitcoin-git> bitcoin/master 04ce0d8 Pieter Wuille: Report when unknown config file options are ignored
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/77168f766f15...230652cafc51
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13809: contrib: Remove debian and rpm subfolder (master...Mf1808-debianContrib) https://github.com/bitcoin/bitcoin/pull/13809
< bitcoin-git> bitcoin/master 77168f7 MarcoFalke: Merge #13809: contrib: Remove debian and rpm subfolder...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ce55df70d31...77168f766f15
< bitcoin-git> bitcoin/master fa0e1e2 MarcoFalke: contrib: Remove debian and rpm subfolders
< bitcoin-git> [bitcoin] chipstar closed pull request #13820: Replace Bitcoin to XPChain (master...replace-botcoin-to-xpchain) https://github.com/bitcoin/bitcoin/pull/13820
< bitcoin-git> [bitcoin] chipstar opened pull request #13820: Replace Bitcoin to XPChain (master...replace-botcoin-to-xpchain) https://github.com/bitcoin/bitcoin/pull/13820
< bitcoin-git> [bitcoin] Sjors opened pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
< bitcoin-git> [bitcoin] scravy opened pull request #13816: travis: build and run tests on os: osx (master...run-functional-tests-on-macos) https://github.com/bitcoin/bitcoin/pull/13816
< harding> various places in their home directory for different Bitcoin-related resources.
< harding> mryandao: ok. I guess I have a different backup philosophy than you do. I use cheap external HDs, and so I just grab everything indiscriminately. I think there probably is an advantage to fully separating stuff we really want users to backup (e..g bitcoin.conf and wallets) from stuff that's just nice to backup (e.g. old blocks), but I personally don't think that's enough of an advantage to make them have to go looking around
< mryandao> typically most linux distribution follow XDG specification for looking up config files, would this be preferable in Core? I know there was a previous closed issue which mentioned this, but we could keep the datadir cache separate in ~/.bitcoin as is
< sipa> bitcoin-cli needs to know what arguments to treat as string literals and which ones not
< luke-jr> kallewoof: for bitcoin-cli, which isn't tested by assert_raises_rpc_error
< bitcoin-git> [bitcoin] practicalswift opened pull request #13815: build: Add linter to make sure the return value of Parse[...](...) is checked (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815

2018-07-30

< gribble> https://github.com/bitcoin/bitcoin/issues/13791 | gui: Reject dialogs if key escape is pressed by promag · Pull Request #13791 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gmaxwell> quitobro: you might want to also keep an eye on https://github.com/bitcoin/bitcoin/pull/12254
< quitobro> definitely; should we just keep our eyes on bitcoin-dev-mailing-list?
< wumpus> the only use of protobuf is the payment request code in bitcoin-qt and that hasn't seen serious changes since... forever
< gribble> https://github.com/bitcoin/bitcoin/issues/13804 | Stacked Transaction Pool Layer by MarcoFalke · Pull Request #13804 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< satwo> wumpus: thanks! I definitely need to familiarize myself with functional vs unit tests in bitcoin. I'll continue to come here to ask my noobish questions.
< fanquake> There was at one point a bitcoin test cases/writeups repo, but I don't think it ever got much traction
< gribble> https://github.com/bitcoin/bitcoin/issues/12879 | [scripted-diff] No extern function declarations by kallewoof · Pull Request #12879 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13803 | doc: add note to developer docs about warranted PRs by kallewoof · Pull Request #13803 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13802 | Dont use zero as null pointer constant by practicalswift · Pull Request #13802 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13795 | build: Add missing [[noreturn]] to handleRunawayException(...). Enable -Wsuggest-attribute=noreturn if available. by practicalswift · Pull Request #13795 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13770 | Use explicit captures in lambda expressions by practicalswift · Pull Request #13770 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13801 | wallet: -avoidreuse with destination filters by kallewoof · Pull Request #13801 · bitcoin/bitcoin · GitHub
< Fuzzbawls> Question: (please ping me directly with answer) Given the recent acquisition of GitHub by Microsoft, is a relocation of the bitcoin source code to an alternative platform (like GitLab) being considered at all? If so, has anyone been actively working towards porting the `.travis.yml` file over to an alternative CI provider? I've had mixed results with such a port; some features can be duplicated/represented, and some cannot (like the $TRAVIS_COMMIT
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: -avoidreuse feature for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10065 | Support not reusing addresses · Issue #10065 · bitcoin/bitcoin · GitHub
< fanquake> Also locked the conversation on https://github.com/bitcoin/bitcoin/commit/d2186b3db61a9d4dc2d4a6211573790d9e34bf58#comments, as that's probably carried on long enough.

2018-07-29

< gmaxwell> I saw it, and so did some ordinary user in #bitcoin, and I'm pretty sure I didn't have anything cached.
< wumpus> they both show 0.16.2 don't they? https://bitcoin.org/en/download https://bitcoincore.org/en/download/

2018-07-28

< jonasschnelli> cfields: sigs ---> https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/10 (thanks ken2812221)
< jonasschnelli> ken2812221: sry. :) now my fault. I need: e56b7d20bc7bfb8203f1651ddcf4fc18d8685acf942a8c7b90919f29e24db3a1 bitcoin-0.16.2-osx-unsigned.tar.gz
< jonasschnelli> You file: e56b7d20bc7bfb8203f1651ddcf4fc18d8685acf942a8c7b90919f29e24db3a1 bitcoin-osx-unsigned.tar.gz
< jonasschnelli> ken2812221: the file sha256sum doesn't match the available signatures: https://github.com/bitcoin-core/gitian.sigs/blob/master/0.16.2-osx-unsigned/laanwj/bitcoin-osx-0.16-build.assert
< gribble> https://github.com/bitcoin/bitcoin/issues/13782 | Fix osslsigncode compile issue in gitian-build by ken2812221 · Pull Request #13782 · bitcoin/bitcoin · GitHub
< windsok> +1 to making invalid options in bitcoin.conf a warning. I'm having trouble figuring out which option is causing the error

2018-07-27

< jhfrontz> I'm getting errors about missing symbols (like described here: https://github.com/bitcoin/bitcoin/issues/12511#issuecomment-386740137 ).
< wumpus> but a warning if in bitcoin.conf
< luke-jr> wumpus: actually, it might be annoying if users get errors for Knots configs in bitcoin.conf
< sipa> (by default it's enforced, unless you pass -ignoreunknownconfigoptions or so; and then it still only applies to bitcoin.conf and not to command line options)
< sipa> wumpus: or we need a way to specify bitcoin.conf options that only apply to a particular binary
< sipa> but we should probably make it ignore bitcoin-cli only options like this one, when present in bitcoin.conf
< sipa> right; you can't put it in bitcoin.conf anymore, because it's not a bitcoind option
< sipa> in bitcoin.conf it should work fine; that file should be read by both bitcoind and bitcoin-cli
< sipa> satwo: no, but it's a bitcoin-cli command line option; not a bitcoind one
< satwo> Has the bitcoind config param -rpcclienttimeout been removed? I'm getting errors trying to set it in both the command line and in bitcoin.conf.
< harding> brighton36: I'm not sure what you're talking about, but it feels a bit off topic for this channel. Would you mind joining #bitcoin-core-website to discuss further? (Or you can PM me if you're a registered user.)
< harding> brighton36: I help maintain the site. I don't relaly understand your question. There's a basic contributing policy at https://github.com/bitcoin-core/bitcoincore.org/blob/master/CONTRIBUTING.md but the basic process is the same for any open source project: people open PRs proposing changes, other people provide feedback, once the feedback is generally positive, the PR is merged. If the PR never gets to that stage, it's
< jonasschnelli> sipa: would adding 'h' as equivalent to ' in the descriptor xpub/xpriv range definition makes sense? >'< in conjunction with JSON and the GUI/bitcoin-cli/shell seems to be a hassle

2018-07-26

< gribble> https://github.com/bitcoin/bitcoin/issues/13311 | Dont edit Chainparams after initialization by jtimon · Pull Request #13311 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble> https://github.com/bitcoin/bitcoin/issues/13426 | [bugfix] Fix encoding issue for Windows by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13426 | [bugfix] Fix encoding issue for Windows by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub
< wumpus> jamesob: < wumpus> as for high priority for review, please review everything under the 0.17 milestone: https://github.com/bitcoin/bitcoin/milestone/33
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: -avoidreuse feature for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< wumpus> as for high priority for review, please review everything under the 0.17 milestone: https://github.com/bitcoin/bitcoin/milestone/33
< gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub
< BlueMatt> jonasschnelli: well I ask because there is debate about what to write in some docs in rust-bitcoin, and also what to call it on bitcoincore.org docs
< sipa> BlueMatt: scriptWitness is just in bitcoin core's source code though; is it called that way anywhere else?
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark mi
< satwo> Would modifying bitcoin-rpc to say something like "size (total):" or "total size:" be messy overkill? At the very least it would bring RPC and BIP 141 in harmony, potentially reducing some confusion
< satwo> Hi all. BIP-141 defines 4 ways to measure the size of a transaction: weight, virtual size, base size, and total size. Bitcoin-cli decoderawtransaction returns weight, vsize ("virtual size" - obvious), and size (“total size" - not obvious). I must not be the only one to have found it nontrivial to figure out how base size, total size in BIP141 and “size” in RPC are related. Even once one figures out that “BIP 141
< arubi> DDG first result for "scriptWitness" is the transaction.h file in the repo, and for "witnessScript bitcoin" the first result is is the core-dev docs site
< BlueMatt> Ugh, ok, poll time, what are peoples' thoughts on what to call the witness version of the redeemScript? https://github.com/bitcoin-core/bitcoincore.org/issues/581 and https://github.com/rust-bitcoin/rust-bitcoin/pull/109 for debate context
< ken2812221> bitcoin-git is dead?
< jonasschnelli> provoostenator: https://bitcoin.jonasschnelli.ch/build/715
< gribble> https://github.com/bitcoin/bitcoin/issues/13426 | [bugfix] Fix encoding issue for Windows by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub

2018-07-25

< bitcoin-git> [bitcoin] fanquake closed pull request #12696: Fix possible data race when committing block files (master...fsync) https://github.com/bitcoin/bitcoin/pull/12696
< gribble> https://github.com/bitcoin/bitcoin/issues/13696 | Add aarch64 qt depends support for cross compiling bitcoin-qt by TheCharlatan · Pull Request #13696 · bitcoin/bitcoin · GitHub
< provoostenator> Mirroring everything in #bitcoin-core-dev-read-only is not ideal either I guess
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13714: contrib: Add lxc network setup for Bionic host (master...gitian-build-auto-install) https://github.com/bitcoin/bitcoin/pull/13714
< bitcoin-git> bitcoin/master 29b4ee6 MarcoFalke: Merge #13714: contrib: Add lxc network setup for Bionic host...
< bitcoin-git> bitcoin/master 60c3c23 Chun Kuan Lee: [contrib] Add automatic setup for Ubuntu Bionic
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2d41af17282e...29b4ee64695f
< bitcoin-git> [bitcoin] laanwj closed pull request #13658: [moveonly] Extract RescanWallet to handle a simple rescan (master...rescan-from-time) https://github.com/bitcoin/bitcoin/pull/13658
< bitcoin-git> bitcoin/master 2d41af1 Wladimir J. van der Laan: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan...