2019-03-22

< bitcoin-git> bitcoin/master 6852059 MarcoFalke: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
< bitcoin-git> [bitcoin] sipa opened pull request #15644: Make orphan processing interruptible (master...201903_interruptibleorphans) https://github.com/bitcoin/bitcoin/pull/15644
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15643: contrib: gh-merge: Include review comments in merge commit (master...1903-ghMergeAck) https://github.com/bitcoin/bitcoin/pull/15643
< bitcoin-git> [bitcoin] laanwj merged pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/238ef3369296...b0222428879f
< bitcoin-git> bitcoin/0.18 98a24a2 João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active
< bitcoin-git> bitcoin/0.18 b022242 Wladimir J. van der Laan: Merge #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet wh...
< bitcoin-git> [bitcoin] jnewbery opened pull request #15642: [rpc] Remove deprecated rpc functionality (master...2019_03_remove_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/15642
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack reopened pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
< bitcoin-git> [bitcoin] jonatack closed pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641
< gribble> https://github.com/bitcoin/bitcoin/issues/15591 | balance wrong after unloading wallet and loading it again · Issue #15591 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15614: gui: Defer removeAndDeleteWallet when no modal widget is active (master...2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15614
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/717fd58c4ba5...abd914ed34f1
< bitcoin-git> bitcoin/master a10972b João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active
< bitcoin-git> bitcoin/master abd914e Jonas Schnelli: Merge #15614: gui: Defer removeAndDeleteWallet when no modal widget is act...
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638
< bitcoin-git> [bitcoin] fanquake closed pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008
< bitcoin-git> [bitcoin] fanquake opened pull request #15637: rpc: Rename size to vsize in mempool related calls (master...rebased-13008-rename-size-vsize) https://github.com/bitcoin/bitcoin/pull/15637

2019-03-21

< echeveria> wumpus: for the record, I reported the malicious versions of the bitcoin core website to the host.
< sipa> or even that the source code is what people canonically understand to be bitcoin core
< jonasschnelli> (An attacker could register "Bitcoin Core Code Shitting Association" and signing the malicious binary with that and nobody would recognise that)
< gwillen> "the bitcoin core code signing association thinks Windows should not yell when running this binary"
< luke-jr> "this is bitcoin core" *should* be meaningless really
< jonasschnelli> It only tells users it was signed by an organisation called "Bitcoin Core Code Signing Association"
< sipa> or "this is bitcoin core"
< luke-jr> jonasschnelli: obviously there would have to be some reasonable policy on what gets signed (eg, gitian builds of Bitcoin-compatible software)
< jonasschnelli> There is another association I'm currently building up (with a proper structure) called "Bitcoin Developer and Researcher Association" (BitDRA) which should aim to finance real work/projects
< gwillen> yes I am happy to formally donate to the Bitcoin Core Code Signing Association, someone should tell me an amount and where to mail a check :-)
< jonasschnelli> Bitcoin Core Code Signing Association (based in Switzerland)
< warren> oh I missed the win signature discussion, will it be something other than Bitcoin Foundation in the future?
< wumpus> surprisingly much of the infrastructure and stuff around bitcoin is hanging together by a few threads, and single individuals that happily still care about it
< wumpus> thanks to the Linux Foundation too, then! it wouldn't be crazy for them to drop bitcoin-dev if it's such a hot potato
< warren> It's worth noting despite trying to deprecate the old mailman2 server they've tried to keep it online for us and a few other dev communities who had a hard time moving, and most of their downtime trouble was due to DoS attacks targeting only bitcoin-dev.
< wumpus> in principle it's even off topic in the bitcoin core meeting, the bitcoin-dev mailing list is outside it's scope, not that I mind
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15596 | rpc: Ignore sendmany::minconf as dummy value by MarcoFalke · Pull Request #15596 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< jonasschnelli> Would also be good to get a sponsor for the Bitcoin Core Code Signing Association at some point (raise your hand if your willing)
< jonasschnelli> cfields: should we register a new one via the Bitcoin Core Code Signing Association?
< promag> again, this is really very unlikely, you have to run bitcoin-qt -server
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...2019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15310 | gui: crash if encrypt / change passphrase window is open and wallet is unloaded · Issue #15310 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] gmaxwell closed pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
< wumpus> I think it's one of the most popular devices to run a bitcoin node on
< emilr> I'm building bitcoin on a rpi, biggest hurdle thus far is the dependency tree, I had to give up on building boost-libs and use binaries
< bitcoin-git> [bitcoin] gmaxwell opened pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
< gribble> https://github.com/bitcoin/bitcoin/issues/84 | Transaction-less transfer of value · Issue #84 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
< wumpus> so apparently there's some funding initiative by Twitter/Square for core devs (I only learn of this through twitter now), https://twitter.com/jimmysong/status/1108500506106843137 - anyhow, if you're actively involved in Bitcoin Core's development and need this funding, and would like me to write a recommendation for you, let me know
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2607d960a02e...717fd58c4ba5
< bitcoin-git> bitcoin/master bb6195e practicalswift: refactor: Remove unused function
< bitcoin-git> bitcoin/master 717fd58 MeshCollider: Merge #15625: refactor: Remove unused function
< bitcoin-git> [bitcoin] MeshCollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b3f82284ba90...2607d960a02e
< bitcoin-git> bitcoin/master 91868e6 Russell Yanofsky: Remove use CValidationInterface in wallet code
< bitcoin-git> bitcoin/master 4e4d9e9 Russell Yanofsky: Remove use of CRPCTable::appendCommand in wallet code
< bitcoin-git> bitcoin/master b1b2b23 Russell Yanofsky: Remove use of CCoinsViewMemPool::GetCoin in wallet code
< bitcoin-git> [bitcoin] MeshCollider merged pull request #10973: Refactor: separate wallet from node (master...pr/wipc-sep) https://github.com/bitcoin/bitcoin/pull/10973
< echeveria> fanquake: I can confirm that this is an attack site (as if it wasn't obvious). depending on the links you follow, you either get the legit binaries, or "bitcoin.exe".

2019-03-20

< bitcoin-git> [bitcoin] jnewbery opened pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
< gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15631: qa: mininode: Clearer error message on invalid magic bytes (master...1903-qaMagicMininode) https://github.com/bitcoin/bitcoin/pull/15631
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< dongcarl> ryanofsky: I see. When we have multiprocess bitcoin, will it be an interface violation for optionsmodel.cpp to include net.h?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629
< bitcoin-git> [bitcoin] laanwj pushed 18 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/392d1382c1b1...6cf81b01b48e
< bitcoin-git> bitcoin/0.17 f455979 Andrew Chow: Add function to close all Db's and reload the databae environment
< bitcoin-git> bitcoin/0.17 048fda2 Andrew Chow: After encrypting the wallet, reload the database environment
< bitcoin-git> bitcoin/0.17 435df68 Andrew Chow: Move BerkeleyEnvironment deletion from internal method to callsite
< bitcoin-git> [bitcoin] laanwj merged pull request #15575: 0.17: Backport 15297 (0.17...2019-03-backport-15297-017) https://github.com/bitcoin/bitcoin/pull/15575
< bitcoin-git> [bitcoin] laanwj merged pull request #15597: net: Generate log entry when blocks messages are received unexpectedly (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbc436e09ef1...b3f82284ba90
< bitcoin-git> bitcoin/master ef0019e Patrick Strateman: Generate log entry when blocks messages are received unexpectedly.
< bitcoin-git> bitcoin/master b3f8228 Wladimir J. van der Laan: Merge #15597: net: Generate log entry when blocks messages are received un...
< bitcoin-git> [bitcoin] laanwj merged pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93623eea71e7...bbc436e09ef1
< bitcoin-git> bitcoin/master 0d9d2b3 Jon Atack: Doc: update ACK description in CONTRIBUTING.md
< bitcoin-git> bitcoin/master bbc436e Wladimir J. van der Laan: Merge #15626: Docs: Update ACK description in CONTRIBUTING.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15623: refactor: Expose UndoReadFromDisk in header (master...1903-UndoReadFromDiskHeader) https://github.com/bitcoin/bitcoin/pull/15623
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81f732bcaa30...93623eea71e7
< bitcoin-git> bitcoin/master fa11c03 MarcoFalke: refactor: Expose UndoReadFromDisk in header
< bitcoin-git> bitcoin/master 93623ee MarcoFalke: Merge #15623: refactor: Expose UndoReadFromDisk in header
< dongcarl> nothingmuch: basically, instead of having an actual IP, you have (0xFD + sha256("bitcoin")[0:5] + sha256(hostname))[0:16], which is useful in cases where you don't actually care about the IP, but the hostname, e.g. for seeds
< gribble> https://github.com/bitcoin/bitcoin/issues/10446 | net: avoid extra dns query per seed by theuni · Pull Request #10446 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11512 | Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding by TheBlueMatt · Pull Request #11512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10466 | Use localhost for bitcoin · Issue #10466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
< bitcoin-git> [bitcoin] layer1gfx opened pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
< gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
< wumpus> there's also still a few PRs (such as #12493) that are marked "needs release note" https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=label%3A%22Needs+release+note%22+
< gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
< wumpus> i've added the list of PRs and authors to the preliminary release notes, if someone could double-check that'd be good, https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
< bitcoin-git> [bitcoin] jonatack opened pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/d3a038200709...238ef3369296
< bitcoin-git> bitcoin/0.18 238ef33 Pieter Wuille: Do not relay banned IP addresses
< bitcoin-git> [bitcoin] laanwj merged pull request #15617: p2p: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45b7f20e651...81f732bcaa30
< bitcoin-git> bitcoin/master 054d01d Pieter Wuille: Do not relay banned IP addresses
< bitcoin-git> bitcoin/master 81f732b Wladimir J. van der Laan: Merge #15617: p2p: Do not relay banned IP addresses
< bitcoin-git> [bitcoin] practicalswift opened pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625

2019-03-19

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15623: refactor: Expose UndoReadFromDisk in header (master...1903-UndoReadFromDiskHeader) https://github.com/bitcoin/bitcoin/pull/15623
< bitcoin-git> [bitcoin] practicalswift opened pull request #15622: Remove globals: Avoid using the global namespace if possible (master...globals-1) https://github.com/bitcoin/bitcoin/pull/15622

2019-03-18

< harding> moneyball: are you using the version with ./bitcoin-cli embedded? You need the one where the lines start with "setban"
< moneyball> $bitcoin-cli listbanned | grep address | wc -l
< moneyball> $bitcoin-cli listbanned | grep manually | wc -l
< gmaxwell> $ ./bitcoin-cli listbanned | grep address | wc -l
< moneyball> i used bitcoin-cli listbanned to determine i have 474 banned, all of which are manually added. greg's list has 670. so i am wondering why my ban list is less (likely due to error aborting prematurely?). i am also still wondering about the "already banned" error message since i have none in the ban list that are shown as automatic.
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c033c4b5cef8...e45b7f20e651
< bitcoin-git> bitcoin/master fa5c511 MarcoFalke: refactor: Remove unused function
< bitcoin-git> bitcoin/master e45b7f2 Wladimir J. van der Laan: Merge #15618: refactor: Remove unused function
< bitcoin-git> [bitcoin] laanwj merged pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15620: rpc: Uncouple rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #13541: wallet/rpc: sendrawtransaction maxfeerate (master...sendrawtransaction-maxfeerate) https://github.com/bitcoin/bitcoin/pull/13541
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2c336a9ccdf4...c033c4b5cef8
< bitcoin-git> bitcoin/master e5efacb Karl-Johan Alm: test: Refactor vout fetches in rpc_rawtransaction
< bitcoin-git> bitcoin/master 6c0a6f7 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to sendrawtransaction
< bitcoin-git> bitcoin/master 7abd2e6 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to testmempoolaccept
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/27781b6530c0...2c336a9ccdf4
< bitcoin-git> bitcoin/master 340ef50 Carl Dong: depends: Defer to Python detected by autoconf
< bitcoin-git> bitcoin/master 89bee1b Carl Dong: depends: tar: Always extract as yourself
< bitcoin-git> bitcoin/master f7696e6 Carl Dong: depends: qt: Don't hardcode pwd path
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15581: depends: Make less assumptions about build env (master...2019-03-true-neutral-depends) https://github.com/bitcoin/bitcoin/pull/15581
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15466: tests: Print remaining jobs in test_runner.py (master...remaining-jobs) https://github.com/bitcoin/bitcoin/pull/15466
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ec7aea44281...27781b6530c0
< bitcoin-git> bitcoin/master 2e5d482 Steven Roose: tests: Print remaining jobs in test_runner.py
< bitcoin-git> bitcoin/master 27781b6 MarcoFalke: Merge #15466: tests: Print remaining jobs in test_runner.py
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/acbbb7bf0d45...7ec7aea44281
< bitcoin-git> bitcoin/master faf3698 Glenn Willen: wallet: Improve log output for errors during load
< bitcoin-git> bitcoin/master 7ec7aea MeshCollider: Merge #15491: wallet: Improve log output for errors during load
< bitcoin-git> [bitcoin] sipa opened pull request #15617: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15616: rpc: Remove hex from decodescript RPCResult doc (master...1903-rpcDocDecodeS) https://github.com/bitcoin/bitcoin/pull/15616

2019-03-17

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15601: build: depends: Switch to python3 (take 3) (master...1903-buildPy3) https://github.com/bitcoin/bitcoin/pull/15601
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85f003274d8c...acbbb7bf0d45
< bitcoin-git> bitcoin/master fa0f92a MarcoFalke: build: depends: Switch to python3
< bitcoin-git> bitcoin/master acbbb7b MarcoFalke: Merge #15601: build: depends: Switch to python3 (take 3)
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15615: Add log output during initial header sync (master...2019/03/hdr_sync) https://github.com/bitcoin/bitcoin/pull/15615
< bitcoin-git> [bitcoin] promag opened pull request #15614: 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15614
< bitcoin-git> [bitcoin] pstratem opened pull request #15613: net: Simplify PONG handler, improve readability of the processing logic. (master...2019-03-17-net-processing-pong) https://github.com/bitcoin/bitcoin/pull/15613
< Guest41284> peers of this type pretend to be running various versions of Bitcoin software, but are not. they respond with compact blocks handshakes, pings and pongs, but never respond to headers, get blocks, or inventory messages. the addr messages they push are stuffed with like-peers, and in general seem to be over represented in outgoing connections of normal nodes.
< bitcoin-git> [bitcoin] laanwj merged pull request #15611: Add Gitian key for droark (master...master-keys-update) https://github.com/bitcoin/bitcoin/pull/15611
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2f501fb5c68d...85f003274d8c
< bitcoin-git> bitcoin/master 204c729 Douglas Roark: Add Gitian key for droark
< bitcoin-git> bitcoin/master 85f0032 Wladimir J. van der Laan: Merge #15611: Add Gitian key for droark
< gribble> https://github.com/bitcoin/bitcoin/issues/15611 | Add Gitian key for droark by droark · Pull Request #15611 · bitcoin/bitcoin · GitHub
< gmaxwell> you could try to compress up some non-bitcoin stuff to save you some space... or try to force a leveldb compaction.
< fanquake> dongcarl no worries. Yea, and I'll update my comment here: https://github.com/bitcoin/bitcoin/pull/15277#issuecomment-473539212, with some more info.

2019-03-16

< gribble> https://github.com/bitcoin/bitcoin/issues/14917 | wallet_multiwallet --usecli fails with "Duplicate -wallet filename specified" · Issue #14917 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] droark opened pull request #15611: Add Gitian key for droark (master...master-keys-update) https://github.com/bitcoin/bitcoin/pull/15611
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gmaxwell> Googling shows one or two other pages also saying "bitcoin bark" but it doesn't appear to be an altcoin.
< gribble> https://github.com/bitcoin/bitcoin/issues/15487 | [WIP] descriptor based wallet serialization and import by Sjors · Pull Request #15487 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15522: Document sizeof(size_t) assumptions and compiler assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/165ea14efeda...2f501fb5c68d
< bitcoin-git> bitcoin/master c7ea8d3 practicalswift: Add sizeof(size_t) assumptions
< bitcoin-git> bitcoin/master c7a7250 practicalswift: Document assumptions about C++ compiler
< bitcoin-git> bitcoin/master 2f501fb Wladimir J. van der Laan: Merge #15522: Document sizeof(size_t) assumptions and compiler assumptions...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cede01b41668...165ea14efeda
< bitcoin-git> bitcoin/master 92f3e80 John Newbery: [docs] release note for disabling reject messages by default
< bitcoin-git> bitcoin/master 165ea14 Wladimir J. van der Laan: Merge #15604: [docs] release note for disabling reject messages by default...
< bitcoin-git> [bitcoin] laanwj merged pull request #15604: [docs] release note for disabling reject messages by default (master...release_notes_bip61) https://github.com/bitcoin/bitcoin/pull/15604
< bitcoin-git> [bitcoin] laanwj merged pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/118a5c8d94de...cede01b41668
< bitcoin-git> bitcoin/master b8705a0 Hennadii Stepanov: Set 'distro' explicitly
< bitcoin-git> bitcoin/master cede01b Wladimir J. van der Laan: Merge #15609: scripts and tools: Set 'distro' explicitly
< gribble> https://github.com/bitcoin/bitcoin/issues/15609 | scripts and tools: Set distro explicitly by hebasto · Pull Request #15609 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15604 | [docs] release note for disabling reject messages by default by jnewbery · Pull Request #15604 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15541 | Reproducibility issue with 0.18.0rc1 · Issue #15541 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
< warren> I apologize for not participating in gitian for a while. debootstrap has not worked on Fedora for a few years now. I'm hoping people can help https://github.com/bitcoin/bitcoin/pull/15277 so we have a deterministic buildsystem to replace gitian.

2019-03-15

< provoostenator> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/15608 | Feature request: bitcoin-wallet tool: dont modify files unless requested · Issue #15608 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #15607: Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
< harding> Yeah, I'd think the same. In my test, if I try running on a read-only file (ext4 fs), bitcoin-wallet says it can't open and asks if the file is in use by another process.
< bitcoin-git> [bitcoin] jamesob opened pull request #15606: [experimental] UTXO snapshots (master...utxo-dumpload-compressed) https://github.com/bitcoin/bitcoin/pull/15606
< harding> As part of testing RC1, I was using the new bitcoin-wallet with its "info" command to inspect some backups, but I noticed that it changes the file write times (and won't work if I run on a read-only wallet file). Does it actually need write access to print basic wallet info? I'd really prefer inspections be read only (and work with read-only files).
< wumpus> (e.g.the qt library not just bitcoin-qt)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d67f9d0db98e...118a5c8d94de
< bitcoin-git> bitcoin/master 19a0c4a Carl Dong: depends: native_protobuf: avoid system zlib
< bitcoin-git> bitcoin/master 118a5c8 MarcoFalke: Merge #15580: depends: native_protobuf: avoid system zlib
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15580: depends: native_protobuf: avoid system zlib (master...2019-03-depends-native_protobuf-no-zlib) https://github.com/bitcoin/bitcoin/pull/15580
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15577: Docs: Enable TLS in link to chris.beams.io (master...chris-beams-tls) https://github.com/bitcoin/bitcoin/pull/15577
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b83c6f79400f...d67f9d0db98e
< bitcoin-git> bitcoin/master 228e806 JeremyRand: Enable TLS in link to chris.beams.io
< bitcoin-git> bitcoin/master d67f9d0 Jonas Schnelli: Merge #15577: Docs: Enable TLS in link to chris.beams.io
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc2
< gribble> https://github.com/bitcoin/bitcoin/issues/15604 | [docs] release note for disabling reject messages by default by jnewbery · Pull Request #15604 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15602 | 0.18: [p2p] Enable reject messages by default by jnewbery · Pull Request #15602 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ken2812221 closed pull request #14464: refactor: make checkqueue manage the threads by itself (also removed some boost dependencies) (master...drop-boost-cond) https://github.com/bitcoin/bitcoin/pull/14464
< dmkathayat> dongcarl: are you working on network namespaces already? I'd love to help anyway I can. Tbh, I just wanted to get started on bitcoin
< dmkathayat> sdaftuar has raised this issue in the past: https://github.com/bitcoin/bitcoin/issues/14210

2019-03-14

< bitcoin-git> [bitcoin] jnewbery opened pull request #15604: [docs] release note for disabling reject messages by default (master...release_notes_bip61) https://github.com/bitcoin/bitcoin/pull/15604
< webuser3254> "Cannot send to nick/channel: #bitcoin"
< webuser3254> hello, I have a question regarding pruned mode and importprivkey. I have just imported hundreds of privkeys from my electrum wallet to bitcoin gold core pruned wallet but I can't see any addresses or balances. I can't seem to be able to do rescan on pruned mode. Is there a way to see my balance or move ALL the coins to a new address?
< webuser3254> I appologise for posting it here but I can't do it #bitcoin for some reason :/
< pierre_rochard> "I think his desire is to allow people to immediately start using LND and the LN wallet using BIP157 filters served from his node while their Bitcoin Core node syncs."
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15444: [docs] Additional productivity tips (master...2019/02/typo-productivity) https://github.com/bitcoin/bitcoin/pull/15444
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7fa1f6258c05...b83c6f79400f
< bitcoin-git> bitcoin/master bf12093 Sjors Provoost: [doc] productivity: fix broken link
< bitcoin-git> bitcoin/master 3a21905 Sjors Provoost: [doc] devtools: mention clang-format dependency
< bitcoin-git> bitcoin/master ff7f31e Sjors Provoost: [doc] productivity: more advanced git range-diff
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/889af0eaacd9...d3a038200709
< bitcoin-git> bitcoin/0.18 da14d90 John Newbery: [p2p] Enable BIP 61 REJECT messages by default
< bitcoin-git> bitcoin/0.18 a756363 John Newbery: [docs] document BIP 61 deprecation
< bitcoin-git> bitcoin/0.18 d3a0382 MarcoFalke: Merge #15602: 0.18: [p2p] Enable reject messages by default
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15602: 0.18: [p2p] Enable reject messages by default (0.18...reject_message_by_default) https://github.com/bitcoin/bitcoin/pull/15602
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gwillen opened pull request #15603: docs: Add more tips to productivity.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15603
< gmaxwell> So then I guess the confusion there would be that what he'd really want as the alternative is 'hybrid spv mode' in the ln wallet? not in bitcoin core.
< sipa> only partially related, i think there is a lot of confusion about what "bip157" means; there is (a) the spec, allowing software to implement the filters in a private protocol like wasabi does (b) support for it in bitcoin core via RPC (what the current PRs do) (c) exposing it in core and other software via P2P for trusting peers to use (d) exposing it in core via P2P for non-trusting peers (e) a
< moneyball> My understanding is that pierre_rochard is focused on onboarding new Bitcoin users via Lightning (with his Lightning Powered Users), and he would like as many of them as possible to run full nodes, but he wants them to be able to use Bitcoin immediately so wants to support BIP157 style light clients. He's also saying if Core doesn't merge support for BIP157, he'd maintain a version of Core with it merged, and run
< harding> gmaxwell: pierre_rochard maintains an installer that installs Bitcoin Core, LND, and a LN wallet that's capable of using BIP157/158. I think his desire is to allow people to immediately start using LND and the LN wallet using BIP157 filters served from his node while their Bitcoin Core node syncs. That is, I don't think he's talking about hybrid SPV in Bitcoin Core by hybrid SPV via LND/Neutrino/some other wallet.
< gmaxwell> (someone in #bitcoin tried asking me my opinion about that debate earlier, and I thought it would be nice to actually understand it before responding...)
< bitcoin-git> [bitcoin] jnewbery opened pull request #15602: [p2] Enable reject messages by default (0.18...reject_message_by_default) https://github.com/bitcoin/bitcoin/pull/15602
< gmaxwell> MarcoFalke: e.g. if the wallet always stores the tx like bitcoin core, the current block and txid are enough.
< gribble> https://github.com/bitcoin/bitcoin/issues/14054 | p2p: Disable BIP 61 by default by MarcoFalke · Pull Request #14054 · bitcoin/bitcoin · GitHub
< gmaxwell> sipa: the two respondands saying they're using it (1) only log it, (2) don't work against bitcoin core already.
< gribble> https://github.com/bitcoin/bitcoin/issues/14054 | p2p: Disable BIP 61 by default by MarcoFalke · Pull Request #14054 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13134 | net: Add option `-enablebip61` to configure sending of BIP61 notifications by laanwj · Pull Request #13134 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 three PRs on here #15141 #10973 #14856
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15601: build: depends: Switch to python3 (take 3) (master...1903-buildPy3) https://github.com/bitcoin/bitcoin/pull/15601
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/85f1755163a1...889af0eaacd9
< bitcoin-git> bitcoin/0.18 889af0e Wladimir J. van der Laan: doc: Update manpages
< bitcoin-git> [bitcoin] laanwj merged pull request #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree (master...2019-03-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/15583
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/ef27a060ac0d...85f1755163a1
< bitcoin-git> bitcoin/0.18 85f1755 Wladimir J. van der Laan: build: bump to rc2
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1704c01537...7fa1f6258c05
< bitcoin-git> bitcoin/master 15c69b1 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
< bitcoin-git> bitcoin/master 7fa1f62 Wladimir J. van der Laan: Merge #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkele...
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/a01925c1502a...ef27a060ac0d
< bitcoin-git> bitcoin/0.18 ef27a06 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
< gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/232ef630ecd3...a01925c1502a
< bitcoin-git> bitcoin/0.18 a01925c Wladimir J. van der Laan: doc: Pre-rc2 translations update
< bitcoin-git> [bitcoin] luke-jr opened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600
< provoostenator> Sentineo the fingerprint of sipa's key, that you just downloaded, is in trusted-keys here: https://github.com/bitcoin/bitcoin/tree/master/contrib/verify-commits
< bitcoin-git> [bitcoin] pstratem opened pull request #15597: Generate log entry when blocks messages are received unexpectedly. (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597

2019-03-13

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15587: wallet: Remove GetLegacyBalance (master...1903-walletRemoveLegacyBal) https://github.com/bitcoin/bitcoin/pull/15587
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15596: rpc: Ignore sendmany::minconf as dummy value (master...1903-rpcWalletDummySendmany_2) https://github.com/bitcoin/bitcoin/pull/15596
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
< wumpus> MarcoFalke: https://github.com/zw/bitcoin-gh-meta.git is what I used but it seems it hasn't been updated in a while :(
< gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
< echeveria> eg, curl -s http://data.gharchive.org/2015-01-01-{1..31}.json.gz | zgrep "github.com/bitcoin/bitcoin"
< MarcoFalke> What is the git repo again that mirrors all bitcoin core github comments?
< jonasschnelli> Any idea why Draht reports conflicts multiple times? https://github.com/bitcoin/bitcoin/pull/14032#issuecomment-471980504
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/2edd0c40c34b...232ef630ecd3
< bitcoin-git> bitcoin/0.18 232ef63 Pieter Wuille: Fix overflow bug in analyzepsbt fee: CAmount instead of int
< gribble> https://github.com/bitcoin/bitcoin/issues/15582 | Fix overflow bug in analyzepsbt fee: CAmount instead of int by sipa · Pull Request #15582 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15592 | Bitcoin signing key by @laanwj expired on 2019-02-14 · Issue #15592 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
< bitcoin-git> [bitcoin] promag closed pull request #14826: Avoid expanding descriptor scriptPubKeys (master...2018-11-faster-descriptor-expand) https://github.com/bitcoin/bitcoin/pull/14826
< bitcoin-git> [bitcoin] pajasevi opened pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
< bitcoin-git> [bitcoin] Sjors opened pull request #15590: Descriptor: add GetAddressType() -> base58 / bech32 (master...2019/03/descriptor-address-type) https://github.com/bitcoin/bitcoin/pull/15590