< bitcoin-git>
[bitcoin] benthecarman opened pull request #15086: rpc: Fixing logical error in ListTransactions (master...fix_logical_error_in_ListTransactions) https://github.com/bitcoin/bitcoin/pull/15086
< bitcoin-git>
[bitcoin] benthecarman opened pull request #15085: gui: Fix for Incorrect application name when passing -regtest (master...regest_window_name) https://github.com/bitcoin/bitcoin/pull/15085
< bitcoin-git>
[bitcoin] benthecarman opened pull request #15084: gui: don't disable the sync overlay when wallet is disabled (master...sync_overlay_without_wallet) https://github.com/bitcoin/bitcoin/pull/15084
< bitcoin-git>
[bitcoin] bytting opened pull request #15083: wallet: Fix a bug where memcmp takes a pointer address as second argument (master...20190103-fix-memcmp) https://github.com/bitcoin/bitcoin/pull/15083
< fanquake>
promag, when you are testing for notifications on macOS. Are you using src/qt/bitcoin-qt, or calling make-deploy and using the App in the .dmg?
< bitcoin-git>
[bitcoin] harding opened pull request #15081: Doc: Update release notes for master through to 2019-01-01 (master...2019-01-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15081
< wumpus>
there would be a point in changing it I guess especially if you're using bitcoin-qt regtest with the functional tests, wouldn't want to run it with the testnet settings
< cjd>
BTW: one type of fuzzing which could potentially be very valuable for bitcoin is difference fuzzing.. create a test function which takes input and produces output and then use some linker trickery to allow linking 2 versions of bitcoin and invoking the function from each, if the output is different between the two then you got trouble
< cjd>
I'll write my thoughts on github, as I am not in a position where I have to work with the bitcoin codebase every day so I don't want to impose, but I would like to raise a few questions as someone who does use this method
< bitcoin-git>
bitcoin/master b60ac00 Antti Majakivi: Botbot.me (IRC logs) not available anymore...
< bitcoin-git>
bitcoin/master 4f041ba MeshCollider: Merge #15073: docs: Botbot.me (IRC logs) not available anymore...
< bitcoin-git>
[bitcoin] ken2812221 closed pull request #14922: [WIP] windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
2019-01-01
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15077: rpc: List all message types in getpeerinfo recv/send stats (master...Mf1812-netStats0) https://github.com/bitcoin/bitcoin/pull/15077
< cobega>
using it like ./bitcoin-cli importmulti '[{"scriptPubKey":{"address":"2MtxopLjtoJbfxJqNptZR17RzPGSTSTmqZsy"},"timestamp":1546218000}]' it says "invalid address"
< cobega>
using ./bitcoin-cli importmulti '[{ "address": "2MtxopLjtoJbfxJqNptZR17RzPGSTSTmqZsy", "timestamp": 1546218000 }]' I get this error Invalid scriptPubKey, as far as I see the docs, it's either scriptPubKey or address to use?
< bitcoin-git>
bitcoin/master 3019ba2 Ben Carman: Making supported operating systems more clear
< bitcoin-git>
bitcoin/master f5a70d1 Wladimir J. van der Laan: Merge #14974: doc: Removing redundant line: "Windows XP not supported"...
< cjd>
Bitcoin is a unique project, in that it's a piece of code which is typically not exploited to get access to someting else, it's exploited for it's own purpose
< gmaxwell>
and consider, JS code for bitcoin has a had flaws that cost users funds many many many more times than code written in languages that aren't segfault free. :P
< MarcoFalke>
Should we add a repo to bitcoin-core with fuzz seeds?
< midnightmagic>
Bitcoin can't run on an Amiga. :-P
< cjd>
This is funny, 4 years ago bitcoin could only possibly work on little endian (probably only on i386/amd64) and cjdns had nice endian swapping macros and all of that
< cjd>
now I see endian swapping macros in bitcoin and they look almost exactly like my old code
< wumpus>
fanquake: blocked on bitcoin and bitcoin-core
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15063: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (master...bip70_fallback_to_bip21) https://github.com/bitcoin/bitcoin/pull/15063
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15064: [PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] (master...bip70_merchant_to_to) https://github.com/bitcoin/bitcoin/pull/15064
< eugene9999>
There was a PR (https://github.com/bitcoin/bitcoin/issues/11045) that sought to change this but never got merged. So the switching can "confuse" the fuzzer and gmaxwell said that by hashing the branch targets, the fuzzer may not take certain code paths. Is this because of the known "edge collision" in AFL?
< eugene9999>
Hello I asked this question before about fuzzing. Now I'm asking a slightly different question. This q is aimed at anybody well-versed in the fuzzing of bitcoin core and of fuzzing in general (@sipa, @gmaxwell, others?). So bitcoin core currently has a fuzzing harness where a switch is done based on the input to determine the message type to be fuzzed.
< luke-jr>
either way, #bitcoin is the place for this
< bitcoin-git>
[bitcoin] emilengler opened pull request #15061: [Trivial] Update license year range to 2019 (master...update-license-to-2019) https://github.com/bitcoin/bitcoin/pull/15061
< cluelessperson>
So, I'm wanting to put bitcoin core's data dir on NFS to a ZFS storage server
< bitcoin-git>
bitcoin/master 2196c51 Chun Kuan Lee: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform
< bitcoin-git>
bitcoin/master cb53b82 Chun Kuan Lee: scripted-diff: Replace boost::bind with std::bind...
< bitcoin-git>
[bitcoin] fanquake closed pull request #13741: Only allocate a LevelDB block cache if LevelDB will actually use it (master...eklitzke-buffer-cache-rebased) https://github.com/bitcoin/bitcoin/pull/13741
< toeinriver>
Anyone knows a good place to find out the next bitcoin core dev meetup?
2018-12-28
< bitcoin-git>
[bitcoin] mmachicao closed pull request #14881: Tests: Contract testing for the procedure AddTimeData (master...timedata_contract_test) https://github.com/bitcoin/bitcoin/pull/14881
< bitcoin-git>
[bitcoin] mmachicao opened pull request #15052: Tests: Contract testing for the procedure AddTimeData and related fixes (master...timedata_contract_test2) https://github.com/bitcoin/bitcoin/pull/15052
< bitcoin-git>
[bitcoin] mmachicao opened pull request #15051: Tests: IsReachable is the inverse of IsLimited (DRY). Includes unit tests (master...net_contract_test2) https://github.com/bitcoin/bitcoin/pull/15051
< bitcoin-git>
[bitcoin] mmachicao closed pull request #15044: Tests: IsReachable is the inverse of IsLimited (DRY) (master...net_contract_test) https://github.com/bitcoin/bitcoin/pull/15044
< bitcoin-git>
[bitcoin] laanwj closed pull request #14968: http: Fail initialization when any bind fails (master...2018_12_http_bind_error) https://github.com/bitcoin/bitcoin/pull/14968
< bitcoin-git>
[bitcoin] laanwj closed pull request #15050: http: Fail initialization when any bind fails (0.17) (0.17...2018_12_http_bind_error_0_17) https://github.com/bitcoin/bitcoin/pull/15050
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14981: rpc: Clarifying RPC getrawtransaction's time help text (master...getrawtransaction_help_text_fix) https://github.com/bitcoin/bitcoin/pull/14981
< bitcoin-git>
[bitcoin] laanwj opened pull request #15050: http: Fail initialization when any bind fails (0.17) (0.17...2018_12_http_bind_error_0_17) https://github.com/bitcoin/bitcoin/pull/15050
2018-12-27
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15047: build: Allow to configure --with-sanitizers=fuzzer (master...Mf1812-buildSanFuzz) https://github.com/bitcoin/bitcoin/pull/15047
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14930: test: pruning: Check that verifychain can be called when pruned (master...Mf1812-testPruneVerify) https://github.com/bitcoin/bitcoin/pull/14930
< bitcoin-git>
bitcoin/master fa3e874 MarcoFalke: test: pruning: Check that verifychain can be called when pruned
< bitcoin-git>
bitcoin/master e4850ce MarcoFalke: Merge #14930: test: pruning: Check that verifychain can be called when pruned...
< bitcoin-git>
[bitcoin] jl2012 opened pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045
< bitcoin-git>
[bitcoin] mmachicao opened pull request #15044: Tests: IsReachable is the inverse of IsLimited (DRY) (master...net_contract_test) https://github.com/bitcoin/bitcoin/pull/15044
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15043: test: Build fuzz targets into seperate executables (master...Mf1812-buildFuzzTargets) https://github.com/bitcoin/bitcoin/pull/15043
2018-12-26
< bitcoin-git>
[bitcoin] hebasto opened pull request #15040: qt: Add workaround for QProgressDialog bug on macOS (master...20181226-fix-macos-qprogressdialog) https://github.com/bitcoin/bitcoin/pull/15040
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15039: wallet: Avoid leaking nLockTime fingerprint when anti-fee-sniping (master...Mf1812-walletLocktimeFingerprint) https://github.com/bitcoin/bitcoin/pull/15039
< bitcoin-git>
[bitcoin] hebasto opened pull request #15038: docs: Get more info about GUI-related issue on Linux (master...20181226-issue-template-gui-linux) https://github.com/bitcoin/bitcoin/pull/15038
< jimmysong>
similar to jj's attack from breaking bitcoin last year
< sipa>
it is store on disk though, in the undo block data in bitcoin core, for as long as the block itself is stored
2018-12-25
< sipa>
Guest14218: try #bitcoin or bitcoin.stackexchange.com
< Guest14218>
I just want to drop two ideas here, what would make a difference in the future of bitcoin and crypto in general. 1. Solving real world problems through mining, like miners being tied to BOINC projects, so all the computing power is put to good use. 2. Wallets with AI budgeting, that takes care of your money for you, learns your expenses, auto-allocates budgets for economies, has investment schemes for low, medium and hig
< Guest14218>
These 2 will give bitcoin and crypto the edge it needs over banks.
< wumpus>
ah yes: adding the release on github.com/bitcoin
< bitcoin-git>
[bitcoin] canselcik opened pull request #15031: Removing unnecessary comparison of size_t maxConfirms (master...maxConfirms) https://github.com/bitcoin/bitcoin/pull/15031
< wumpus>
gmaxwell: after build of the code-signed binaries: creating and signing SHA256sums, uploading the binaries everywhere, seeding the torrent, release annoucements (mail, twitter, etc), PR and merge release metadata on bitcoincore.org and bitcoin.org, copying and committing the historical release notes to master, ehh and probably some other things I forgot :<
< Eugene9999>
why did you recommend splitting the bitcoin fuzz harnesses into one binary per target? I know it’s more efficient but you mentioned also not doing so could “confuse” the fuzzer - what does that mean?
< bitcoin-git>
bitcoin/master 20b8129 Jim Posen: blockfilter: Refactor GCS params into struct.
< bitcoin-git>
bitcoin/master c306209 Jim Posen: blockfilter: Additional constructors for BlockFilter.
< bitcoin-git>
bitcoin/master e4ed8ce Jim Posen: blockfilter: Remove default clause in switch statement....
2018-12-21
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #15024: Allow specific private keys to be derived from descriptor (master...201812_descriptor_keys) https://github.com/bitcoin/bitcoin/pull/15024
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15023: GUI: Restore RPC Console to non-wallet tray icon menu (master...gui_node_rpcconsole) https://github.com/bitcoin/bitcoin/pull/15023
< gkrizek>
Apologies on that pull request ^^ I was trying to do that on my local fork before going to the Bitcoin project. I'm updating the title and contents
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10595: Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients (master...gbt_nosegwit_fix) https://github.com/bitcoin/bitcoin/pull/10595
< bitcoin-git>
bitcoin/master 0025c9e John Newbery: [mining] segwit option must be set in GBT...
< bitcoin-git>
bitcoin/master d2ce315 John Newbery: [docs] add release note for change to GBT...
< bitcoin-git>
bitcoin/master feda41e MarcoFalke: Merge #14811: Mining: Enforce that segwit option must be set in GBT...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14811: Mining: Enforce that segwit option must be set in GBT (master...remove_non_segwit_mining) https://github.com/bitcoin/bitcoin/pull/14811
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14932: ui: Warn the user on file corruption in mempool.dat (master...Mf1812-testFileCorruption) https://github.com/bitcoin/bitcoin/pull/14932
< provoostenator>
timothy: bitcoin-cli could prompt for a password rather than expecting it as an argument
< timothy>
(bitcoin-cli already have -stdin)
< timothy>
provoostenator: it's not a problem of bitcoin-cli, you cannot disable history in called command
< provoostenator>
That would be a change at the bitcoin-cli level.
< bitcoin-git>
[bitcoin] jnewbery opened pull request #15010: [wallet] Fix getbalance with minconf (master...fix_getbalance_with_minconf) https://github.com/bitcoin/bitcoin/pull/15010