2018-02-07

< bitcoin-git> [bitcoin] laanwj opened pull request #12374: qt: Make sure splash screen is freed on AppInitMain fail (master...2017_02_splash_abort) https://github.com/bitcoin/bitcoin/pull/12374
< bitcoin-git> [bitcoin] murrayn opened pull request #12373: Build: Add build support for profiling. (master...profiling) https://github.com/bitcoin/bitcoin/pull/12373
< hanzou> Well Bitcoin core has code such that a client will respond to getblocks, but it never sends it.
< gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub

2018-02-06

< gribble> https://github.com/bitcoin/bitcoin/issues/12372 | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). · Issue #12372 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] akx20000a opened pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12365 | Add ppa:bitcoin/bitcoin repository on linux problem · Issue #12365 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/25110 | HTTP Error 404: Not Found
< BlueMatt> cfields: well I never found any resolution to it? moc doesnt build bitcoin-qt right now....no idea why
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
< sipa> dongcarl: if you plan to regularly dongitian builds foe bitcoin core releases, you're very mufh encouraged to upload your key and do so:)
< gribble> https://github.com/bitcoin/bitcoin/issues/12366 | http: Join worker threads before deleting work queue by laanwj · Pull Request #12366 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12368 | Hold mempool.cs for the duration of ATMP. by TheBlueMatt · Pull Request #12368 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
< bitcoin-git> [bitcoin] laanwj opened pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
< gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< BlueMatt> the stupid patch at https://github.com/bitcoin/bitcoin/issues/12362#issuecomment-363503855 apparently works
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class. (master...patch/BaseRequestHandler-virtual-dtor) https://github.com/bitcoin/bitcoin/pull/12050
< bitcoin-git> bitcoin/master 1462bde Wladimir J. van der Laan: Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class....
< bitcoin-git> bitcoin/master bdb3231 251: Implements a virtual destructor on the BaseRequestHandler class....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ad320598f06...1462bde767a1
< bitcoin-git> [bitcoin] laanwj closed pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
< bitcoin-git> bitcoin/master 5ad3205 Wladimir J. van der Laan: Merge #12363: Update README after filename change...
< bitcoin-git> bitcoin/master 8a6c62b Conor Scott: [tests] Update README after filename change
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6cd41d93e12...5ad320598f06
< gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< Randolf> It would also be nice to know whether some major ISPs have actively started blocking Bitcoin node traffic.
< Randolf> ossifrage: I wonder if some folks have simply stopped running Bitcoin nodes given the recent downturn in price. Or are you seeing the same number of initial connections as you did before?
< bitcoin-git> [bitcoin] laanwj closed pull request #12305: [docs] [refactor] Add help messages for datadir path mangling (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
< bitcoin-git> bitcoin/master f6cd41d Wladimir J. van der Laan: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling...
< bitcoin-git> bitcoin/master 5460460 James O'Beirne: Add AbsPathForConfigVal to consolidate datadir prefixing for path args...
< bitcoin-git> bitcoin/master a1e1305 James O'Beirne: Clarify help messages for path args to mention datadir prefix...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/88971352f610...f6cd41d93e12
< bitcoin-git> [bitcoin] laanwj closed pull request #11909: contrib: Replace developer keys with list of pgp fingerprints (master...Mf1712-gitianKeysDel) https://github.com/bitcoin/bitcoin/pull/11909
< bitcoin-git> bitcoin/master 8897135 Wladimir J. van der Laan: Merge #11909: contrib: Replace developer keys with list of pgp fingerprints...
< bitcoin-git> bitcoin/master fabb72b MarcoFalke: contrib: Remove xpired 522739F6 key
< bitcoin-git> bitcoin/master faeab66 MarcoFalke: contrib: Replace developer keys with list of pgp fingerprints
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3451483d283...88971352f610
< bitcoin-git> [bitcoin] conscott opened pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
< bitcoin-git> [bitcoin] laanwj closed pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325
< bitcoin-git> [bitcoin] laanwj closed pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322
< bitcoin-git> bitcoin/master c345148 Wladimir J. van der Laan: Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build....
< bitcoin-git> bitcoin/master eeeb416 murrayn: Remove suggestion to make cloned repository world-writable for Windows build.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a32114626fc...c3451483d283
< bitcoin-git> [bitcoin] laanwj closed pull request #12218: net: Move misbehaving logging to net logging category (master...2018_01_misbehaving_logging) https://github.com/bitcoin/bitcoin/pull/12218
< bitcoin-git> bitcoin/master 9a32114 Wladimir J. van der Laan: Merge #12218: net: Move misbehaving logging to net logging category...
< bitcoin-git> bitcoin/master d3a185a Wladimir J. van der Laan: net: Move misbehaving logging to net logging category...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eaeaa2d0b4e8...9a32114626fc
< wumpus> right might be that bitcoin-cli needs changes as well
< wumpus> btcd has this option: --rpcquirks Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless interoperability issues need to be worked around -- O dpm
< bitcoin-git> [bitcoin] laanwj closed pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
< bitcoin-git> bitcoin/master eaeaa2d Wladimir J. van der Laan: Merge #12342: Extend #11583 to include "version handshake timeout" message...
< bitcoin-git> bitcoin/master c887f87 Clem Taylor: Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a30e67d20f7...eaeaa2d0b4e8
< bitcoin-git> [bitcoin] laanwj closed pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< sipa> conman: BIP173 (https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki) under "The following list gives valid segwit addresses and the scriptPubKey that they translate to in hex" gives you what you need

2018-02-05

< bitcoin-git> [bitcoin] promag opened pull request #12361: Replace unreachable error handling with assertions in feebumber (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361
< bitcoin-git> [bitcoin] fanquake closed pull request #11398: Hardcode CSV and SEGWIT deployment (master...csvburied) https://github.com/bitcoin/bitcoin/pull/11398
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330
< bitcoin-git> bitcoin/master 2a30e67 MarcoFalke: Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions...
< bitcoin-git> bitcoin/master c409b1a João Barbosa: [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32528e733f2...2a30e67d20f7
< gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12315 | Bech32 addresses in dumpwallet by fivepiece · Pull Request #12315 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #12360: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/12360
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
< bitcoin-git> [bitcoin] filips123 opened pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
< bitcoin-git> [bitcoin] Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
< bitcoin-git> [bitcoin] Empact opened pull request #12356: Fix 'mempool min fee not met' debug output (master...minfee-message) https://github.com/bitcoin/bitcoin/pull/12356
< bitcoin-git> [bitcoin] fivepiece opened pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
< bitcoin-git> [bitcoin] fivepiece closed pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
< bitcoin-git> [bitcoin] fivepiece opened pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
< bitcoin-git> [bitcoin] fanquake closed pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
< bitcoin-git> [bitcoin] murrayn opened pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
< bitcoin-git> [bitcoin] murrayn opened pull request #12351: Libraries: Use type more precisely indicating usage and avoid compilers warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351
< gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
< bitcoin-git> [bitcoin] kien999 opened pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
< conman> my pool code asks bitcoin core to validate addresses so if I upgrade to .16 without adding support it will likely create corrupt generation transactions for bech32

2018-02-04

< bitcoin-git> [bitcoin] theuni opened pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
< bitcoin-git> [bitcoin] filips123 opened pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12331: Docs: Properly alphabetize output of CLI --help option. (master...help_changes) https://github.com/bitcoin/bitcoin/pull/12331
< bitcoin-git> bitcoin/master d32528e MarcoFalke: Merge #12331: Docs: Properly alphabetize output of CLI --help option....
< bitcoin-git> bitcoin/master d3e4675 murrayn: Properly alphabetize output of CLI --help option.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/85123be78df5...d32528e733f2
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12347: python3 http module uses enum to define HTTP status codes (master...interface_http_status_patch) https://github.com/bitcoin/bitcoin/pull/12347
< bitcoin-git> [bitcoin] yashbhutwala opened pull request #12347: python3 http module uses enum to define HTTP status codes (master...interface_http_status_patch) https://github.com/bitcoin/bitcoin/pull/12347
< bitcoin-git> [bitcoin] practicalswift closed pull request #11754: wallet: Add missing cs_wallet locks when accessing m_last_block_processed (master...missing-m_last_block_processed-locks) https://github.com/bitcoin/bitcoin/pull/11754
< gribble> https://github.com/bitcoin/bitcoin/issues/12285 | Socket select error Bad file descriptor (9) after upgrading to master · Issue #12285 · bitcoin/bitcoin · GitHub
< gmaxwell> re messages with ERROR discussed earlier, ::sigh:: https://github.com/bitcoin/bitcoin/issues/12256#issuecomment-361513326

2018-02-03

< gribble> https://github.com/bitcoin/bitcoin/issues/9989 | [Doc] Removing references to Windows 32 bit from README by NicolasDorier · Pull Request #9989 · bitcoin/bitcoin · GitHub
< Murch> yeah, opinions vary a bit here, but Bitcoin Core should probably be more selective in spending uneconomic unspents.
< rhavar> i think i created some issues on the bitcoin repo to deal with that
< bitcoin-git> [bitcoin] sipa closed pull request #12345: Asymmetric encryption stubs. (master...master) https://github.com/bitcoin/bitcoin/pull/12345
< gribble> https://github.com/bitcoin/bitcoin/issues/12345 | Asymmetric encryption stubs. by Rutkouski · Pull Request #12345 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Rutkouski opened pull request #12345: Asymmetric encryption stubs. (master...master) https://github.com/bitcoin/bitcoin/pull/12345
< bitcoin-git> [bitcoin] clemtaylor opened pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
< gribble> https://github.com/bitcoin/bitcoin/issues/11583 | Do not make it trivial for inbound peers to generate log entries by TheBlueMatt · Pull Request #11583 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #12341: Correction in choice of words in QT (dutch) (master...201802030229-qt-dutch-lang-fix) https://github.com/bitcoin/bitcoin/pull/12341
< bitcoin-git> [bitcoin] RvMp opened pull request #12341: Correction in choice of words (master...201802030229-qt-dutch-lang-fix) https://github.com/bitcoin/bitcoin/pull/12341

2018-02-02

< cfields> achow101: testing bitcoin-qt ?
< BlueMatt> achow101: it should always crash if you quit bitcoin-qt while its loading
< BlueMatt> cfields: in bitcoind (and I was very sure bitcoin-qt) if AppInitMain ever *enters* it should still call Shutdown()
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< GitHub149> [bitcoin-detached-sigs] theuni closed pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
< GitHub24> [bitcoin-detached-sigs] jonasschnelli opened pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
< bitcoin-git> [bitcoin] jnewbery opened pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336
< bitcoin-git> [bitcoin] laanwj closed pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
< bitcoin-git> bitcoin/master 85123be Wladimir J. van der Laan: Merge #12317: Document method for reviewers to verify chainTxData...
< bitcoin-git> bitcoin/master 7444149 John Newbery: Document method for reviewers to verify chainTxData...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4cad91663df3...85123be78df5
< AndyS2> Newbie to C++ and bitcoin core here. I've been looking at EvalScript in interpreter.cpp, and from what I gathered it seems to push things onto 'stack' or return an error if something isn't kosher. But when/where is the stack actually 'executed'. EvalScript doesn't seem to evaluate the script anywhere I could see.
< bitcoin-git> [bitcoin] promag opened pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333
< meshcollider> A megabit is 1 bitcoin?
< gmaxwell> somewhere some french altcoiners people are cacking at bitcoiners trying get everyone to measure their bitcoin in millièmebite.
< provoostenator> gmaxwell: that's why I always nag about screenshots: https://github.com/bitcoin/bitcoin/pull/12035#issuecomment-354297195
< meshcollider> wumpus: can I join bitcoin-core too
< wumpus> invited provoostenator for bitcoin and bitcoin-core orgs
< wumpus> I do have a lot of bitcoin core stickers
< wumpus> provoostenator: I'm not sure; maybe someone still has a stack of bitcoin core t-shirts from one of the real life dev meetings
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/ (master...b16-segwit-test-fix) https://github.com/bitcoin/bitcoin/pull/11869
< bitcoin-git> bitcoin/master 4cad916 MarcoFalke: Merge #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/...
< bitcoin-git> bitcoin/master 9bb59cf Jorge Timón: QA: segwit.py: s/find_unspent/find_spendable_utxo/
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b06ed136f17...4cad91663df3
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12283: Fix typos (master...typos-20180128) https://github.com/bitcoin/bitcoin/pull/12283
< bitcoin-git> bitcoin/master 1b06ed1 MarcoFalke: Merge #12283: Fix typos...
< bitcoin-git> bitcoin/master 1340eda practicalswift: Fix typos
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa360e76a74b...1b06ed136f17
< gribble> https://github.com/bitcoin/bitcoin/issues/12330 | Reduce scope of cs_main and cs_wallet locks in listtransactions by promag · Pull Request #12330 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.16 f17942a Wladimir J. van der Laan: qt: Pre-rc2 translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/f17942a3bc810d981724228bb5c99b5fb572efbe
< bitcoin-git> [bitcoin] laanwj closed pull request #12329: net: don't retry failed oneshot connections forever (master...no-infinite-oneshot) https://github.com/bitcoin/bitcoin/pull/12329
< bitcoin-git> bitcoin/0.16 0dc6a30 João Barbosa: [gui] Defer coin control instancing...
< bitcoin-git> bitcoin/0.16 5303970 Cory Fields: net: don't retry failed oneshot connections forever...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/e54c1ac11066...5303970c26a5
< bitcoin-git> bitcoin/master 660f5f1 Cory Fields: net: don't retry failed oneshot connections forever
< bitcoin-git> bitcoin/master aa360e7 Wladimir J. van der Laan: Merge #12329: net: don't retry failed oneshot connections forever...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41363fe11df5...aa360e76a74b
< bitcoin-git> [bitcoin] murrayn opened pull request #12331: Docs: Properly alphabetize output of CLI --help option. (master...help_changes) https://github.com/bitcoin/bitcoin/pull/12331
< gribble> https://github.com/bitcoin/bitcoin/issues/12322 | Docs: Remove step making cloned repository world-writable for Windows build. by murrayn · Pull Request #12322 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330

2018-02-01

< gribble> https://github.com/bitcoin/bitcoin/issues/12329 | net: dont retry failed oneshot connections forever by theuni · Pull Request #12329 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12219 | More granular net logging · Issue #12219 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12327: [gui] Defer coin control instancing (master...2018-02-fix-12312) https://github.com/bitcoin/bitcoin/pull/12327
< bitcoin-git> bitcoin/master 41363fe Jonas Schnelli: Merge #12327: [gui] Defer coin control instancing...
< bitcoin-git> bitcoin/master 6558f8a João Barbosa: [gui] Defer coin control instancing...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/84291d18dd69...41363fe11df5
< cfields> jcorgan: you're Bitcoin Core maintainer now! congrats.
< jcorgan> hey guys, just fyi, i've passed on the management/maintainer/architect roles in gnuradio to new hands (after 12 years), to focus on bitcoin-related work full-time. part of that will be getting back into core dev process. very much looking forward to the change of pace.
< gribble> https://github.com/bitcoin/bitcoin/issues/12326 | net: initialize socket to avoid closing random fds by theuni · Pull Request #12326 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12323 | File descriptor problem, causing leveldb crash · Issue #12323 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #12329: net: don't retry failed oneshot connections forever (master...no-infinite-oneshot) https://github.com/bitcoin/bitcoin/pull/12329
< gribble> https://github.com/bitcoin/bitcoin/issues/11739 | Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis by sdaftuar · Pull Request #11739 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/pull/12327 fixes a more minor issue with coin control and the change type setting
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< cfields> actually, anyone know why oneshots are re-added in the first place? https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1685
< bitcoin-git> [bitcoin] laanwj closed pull request #12326: net: initialize socket to avoid closing random fd's (master...fix-socket-init) https://github.com/bitcoin/bitcoin/pull/12326
< bitcoin-git> bitcoin/0.16 e54c1ac Cory Fields: net: initialize socket to avoid closing random fd's...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/e54c1ac110664efd58b7351139da55284f58f2ca
< bitcoin-git> bitcoin/master 84291d1 Wladimir J. van der Laan: Merge #12326: net: initialize socket to avoid closing random fd's...
< bitcoin-git> bitcoin/master 96dbd38 Cory Fields: net: initialize socket to avoid closing random fd's
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/895fbd768f0c...84291d18dd69
< provoostenator> Produced a crash using an older version: https://github.com/bitcoin/bitcoin/commit/16bac24f60fa3ae27cb2d9d89dfdd245694445d4
< gribble> https://github.com/bitcoin/bitcoin/issues/12328 | Consistent crashes for v0.16.0rc1 · Issue #12328 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #12327: [gui] Defer coin control instancing (master...2018-02-fix-12312) https://github.com/bitcoin/bitcoin/pull/12327
< gribble> https://github.com/bitcoin/bitcoin/issues/11512 | Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding by TheBlueMatt · Pull Request #11512 · bitcoin/bitcoin · GitHub
< sdaftuar> i don't know if this is related, but i have a lot of lines like this in my debug.log: "trying connection seed.testnet.bitcoin.sprovoost.nl lastseen=0.0hrs"
< morcos> cfields i did make changes in /etc/hosts, but isn't seed.bitcoin.sipa.be a mainnet seed?
< morcos> 0x00005555555ed33a in CConnman::ConnectNode (this=this@entry=0x555556bc8530, addrConnect=..., pszDest=0x0, pszDest@entry=0x7fffac08c150 "seed.testnet.bitcoin.sprovoost.nl", fCountFailure=fCountFailure@entry=false) at net.cpp:448
< morcos> btw, before i forget, it seemed that running in testnet was reading peers.dat from .bitcoin and not testnet3
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #12326: net: initialize socket to avoid closing random fd's (master...fix-socket-init) https://github.com/bitcoin/bitcoin/pull/12326
< cfields> morcos: 127.0.0.1 seed.bitcoin.sipa.be
< wumpus> cfields: the one I was thinking of https://github.com/bitcoin/bitcoin/pull/11913 is not merged :)
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10663 | net: split resolve out of connect by theuni · Pull Request #10663 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11363 | net: Split socket create/connect by theuni · Pull Request #11363 · bitcoin/bitcoin · GitHub
< provoostenator> I know, I was doing that (make src/qt/bitcoin-qt)
< wumpus> or any fd related settings in bitcoin.conf?
< bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325
< bitcoin-git> [bitcoin] AkioNak opened pull request #12324: speed up Unserialize_impl for prevector (master...unserialize) https://github.com/bitcoin/bitcoin/pull/12324
< wumpus> gmaxwell: dx25: I've created an issue for the problem, please add more information if you have there https://github.com/bitcoin/bitcoin/issues/12323
< bitcoin-git> [bitcoin] murrayn opened pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322
< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fivepiece opened pull request #12321: p2wsh address in decodescript (master...decodescript-p2wsh) https://github.com/bitcoin/bitcoin/pull/12321
< GitHub8> [bitcoin-detached-sigs] theuni closed pull request #1: 0.16: osx signatures for 0.16.0rc1 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/1
< GitHub131> [bitcoin-detached-sigs] jonasschnelli opened pull request #1: 0.16: osx signatures for 0.16.0rc1 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/1

2018-01-31

< bitcoin-git> [bitcoin] Empact opened pull request #12319: Add size checking to CPubKey::IsValid, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319
< jimpo> mryandao: https://github.com/bitcoin/bitcoin/pull/12254. Could use some review if you have time. :-)
< jtimon> review begging for https://github.com/bitcoin/bitcoin/pull/12128/files I think it's a simple to review but nice simplification (sorry for the redundancy)
< mryandao> are there any plans to implement compact filters for bitcoin-core?
< jtimon> what is this label supposed to mean? https://github.com/bitcoin/bitcoin/labels/good%20first%20issue
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
< bitcoin-git> [bitcoin] jnewbery opened pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
< bitcoin-git> [bitcoin] thijstriemstra opened pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
< bitcoin-git> [bitcoin] fivepiece opened pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315
< gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Schallabeer opened pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
< gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
< AndyS2> It's not even on the blockchain if it is unconfirmed. It's just in the mempool to be potentially added. There's #bitcoin-dev for more general development questions, btw. This channel is more so for development of Bitcoin Core (an implementation of the protocol).
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
< bitcoin-git> bitcoin/master 895fbd7 MarcoFalke: Merge #12309: doc: Explain how to update chainTxData in release process...
< bitcoin-git> bitcoin/master 7f968ae Wladimir J. van der Laan: doc: Explain how to update chainTxData in release process...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/216f9a42e689...895fbd768f0c
< bitcoin-git> [bitcoin] fanquake closed pull request #12311: build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
< bitcoin-git> [bitcoin] rutkov opened pull request #12311: build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
< provoostenator> What would be more useful for me is being able to have testnet=1 in bitcoin.conf and then launch with -mainnet, because I do make that mistake quite often on my dev account.
< gribble> https://github.com/bitcoin/bitcoin/issues/12300 | [Build] Adding --enable-mainnet configuration option for running mainnet by jeffrade · Pull Request #12300 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
< wumpus> also they're probably not doing anything else in these VMs than building bitcoin
< bitcoin-git> [bitcoin] laanwj opened pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
< bitcoin-git> [bitcoin] laanwj opened pull request #12308: contrib: Add support for out-of-tree builds in gen-manpages.sh (master...2018_01_genmanpages_outoftree) https://github.com/bitcoin/bitcoin/pull/12308
< bitcoin-git> [bitcoin] laanwj closed pull request #12306: Docs: Improvements to UNIX documentation (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/12306
< bitcoin-git> bitcoin/master 216f9a4 Wladimir J. van der Laan: Merge #12306: Docs: Improvements to UNIX documentation...
< bitcoin-git> bitcoin/master ee5e896 Alex Vear: Organise Linux build instructions to be categorised by distro
< bitcoin-git> bitcoin/master 4c85517 Alex Vear: Add NetBSD build instruction links
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0295becbf3e...216f9a42e689
< jtimon> I don't think the option is very interesting (since the result will always be the same unless very bad things happen, just to further note is not bitcoin core specific)

2018-01-30

< promag> for instance, in that case ryanofsky, I would lock from https://github.com/bitcoin/bitcoin/pull/12287/files#diff-b2bb174788c7409b671c46ccc86034bdR1678 to L1690
< denis2342> I just tested bitcoin 0.16.0rc1 on freebsd and it runs fine so far
< jamesob> paths like "./bitcoin.conf" are interpreted as being relative to datadir as well; is this behavior we want to retain?
< bitcoin-git> [bitcoin] axvr opened pull request #12306: Docs: Improvements to UNIX documentation (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/12306
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12304: [qa] 0.16: Backport 12302 (0.16...backport_12302) https://github.com/bitcoin/bitcoin/pull/12304
< bitcoin-git> [bitcoin] jamesob opened pull request #12305: Clarify -conf help message to mention datadir path prefix (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
< bitcoin-git> bitcoin/0.16 6c2788c Wladimir J. van der Laan: test: Make ua_comment test pass on 0.16.0...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/6c2788c7c8d45ac8f38e998c8a9739efdd0b6d18
< MarcoFalke> Anyone with block bit want to kick the markov chain generator https://github.com/bitcoin/bitcoin/pull/11771#issuecomment-361742013
< bitcoin-git> [bitcoin] jnewbery opened pull request #12304: Backport 12302 (0.16...backport_12302) https://github.com/bitcoin/bitcoin/pull/12304
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< bitcoin-git> bitcoin/master f0295be MarcoFalke: Merge #12302: test: Make ua_comment test pass on 0.16.0...
< bitcoin-git> bitcoin/master aac6bce Wladimir J. van der Laan: test: Make ua_comment test pass on 0.16.0...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cb230905088...f0295becbf3e
< bitcoin-git> [bitcoin] laanwj reopened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< provoostenator> Made some progress: https://github.com/bitcoin-core/docs/issues/15
< provoostenator> Ah wait, it's more subtle. These instructions use "ifconfig" which isn't installed on Debian by default: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md#setting-up-debian-for-gitian-building
< wumpus> I understand the consensus code for bitcoin is set in stone, but surely the interface for the test framework isn't
< bitcoin-git> [bitcoin] laanwj closed pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< arubi> daemon stopped, I mkdir 'wallet/' in datadir, moved all my wallet .dats in there, added a new 'wallet=30_01_28_btc_segwit.dat' line in bitcoin.conf, started the daemon, and the new wallet file with this name was created in the datadir root. somewhat surprising, I'm able to getwalletinfo for both this new wallet and old wallets that are now in wallet/ using the -rpcwallet= set
< bitcoin-git> [bitcoin] laanwj opened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
< provoostenator> The guide is very clear until after the Setup Gitian section. After that there's too many options. https://github.com/bitcoin-core/docs/blob/master/gitian-building.md#getting-and-building-the-inputs
< cfields> BlueMatt: got a stale bitcoin-config.h around somewhere?
< BlueMatt> cfields: -DHAVE_CONFIG_H is passed to moc-qt5 (make claims it is, at least), and if I put an ENABLE_WALLET inside the if defined(HAVE_CONFIG_H) it works fine, but somehow bitcoin-config.h isnt getting included
< provoostenator> I wasnt' the first ot notice: https://github.com/bitcoin-core/docs/pull/6
< cfields> achow101: bitcoin-0.16.0-osx-unsigned.dmg
< cfields> (config/bitcoin-config.h)
< sdaftuar> luke-jr: I'm trying to restore a document I authored to its original text. I don't know why this needs a discussion on bitcoin-dev?
< luke-jr> sdaftuar: I don't understand this question: https://github.com/bitcoin/bips/pull/639#issuecomment-361642505
< wumpus> I've added changelog and author information to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
< wumpus> the release notes still need work, if anyone feels like improving them please do so on the wiki, https://github.com/bitcoin/bitcoin/issues/11054 https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/9cb2309050880c2887b4b5f7a7231e4fc6dc3f47
< bitcoin-git> bitcoin/master 9cb2309 Wladimir J. van der Laan: doc: Update manpages to 0.16.99...
< bitcoin-git> bitcoin/master 4602dc7 Wladimir J. van der Laan: build: Bump version to 0.16.99...