2019-03-09

< bitcoin-git> [bitcoin] laanwj pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/f810f14cf61d...936ef73fabc9
< bitcoin-git> bitcoin/0.18 561b00a Suhas Daftuar: [addrman] Improve tried table collision logging
< bitcoin-git> bitcoin/0.18 487f0c3 Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
< bitcoin-git> bitcoin/0.18 333be7a Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff3814880861...6b2ee268be45
< bitcoin-git> bitcoin/master 5bd0788 Ferdinando M. Ametrano: doc: correct path in build-windows.md
< bitcoin-git> bitcoin/master 6b2ee26 Wladimir J. van der Laan: Merge #15562: doc: remove duplicate clone step in build-windows.md
< bitcoin-git> [bitcoin] fanquake opened pull request #15563: backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (0.18...backport-15486-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15563
< bitcoin-git> [bitcoin] laanwj merged pull request #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/12408d33c6ac...ff3814880861
< bitcoin-git> bitcoin/master 4d83401 Suhas Daftuar: [addrman] Improve tried table collision logging
< bitcoin-git> bitcoin/master 4991e3c Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
< bitcoin-git> bitcoin/master f71fdda Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
< bitcoin-git> [bitcoin] fanquake closed pull request #15550: doc: correct path in build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
< bitcoin-git> [bitcoin] fanquake opened pull request #15562: doc: remove duplicate clone step in build-windows.md (master...improved-15550) https://github.com/bitcoin/bitcoin/pull/15562
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/0fd3632868e2...f810f14cf61d
< bitcoin-git> bitcoin/0.18 f810f14 Wladimir J. van der Laan: gitian: Improve error handling
< bitcoin-git> [bitcoin] laanwj merged pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efed9809b4fa...12408d33c6ac
< bitcoin-git> bitcoin/master 32da92b Wladimir J. van der Laan: gitian: Improve error handling
< bitcoin-git> bitcoin/master 12408d3 Wladimir J. van der Laan: Merge #15549: gitian: Improve error handling
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub

2019-03-08

< gmaxwell> I'd expect bitcoin core users and ones that update more actively to consume more inputs... due to being larger more active wallets, and due to BNB.
< sipa> bitcoin core since 0.10 uses this as synchronization mechanism; it's called headers-first sync
< sdaftuar> pinheadmz: no, it being deprecated is just in my head, that was how i thought about. i think bitcoin core hasn't sent getblocks messages in 5+ years or so.
< pinheadmz> when I test against Bitcoin Core, I noticed Core sent getheaders first, then getdata for the actual blocks
< gmaxwell> My list of banworthy unsubtle bitcoin spies and mass connectors has been updated! https://people.xiph.org/~greg/banlist.cli.txt https://people.xiph.org/~greg/banlist.gui.txt
< bitcoin-git> [bitcoin] laanwj merged pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/923d87497c7c...efed9809b4fa
< bitcoin-git> bitcoin/master 82c3b3f practicalswift: Remove sharp edge (uninitialized m_filter_type) when using the compiler-ge...
< bitcoin-git> bitcoin/master efed980 Wladimir J. van der Laan: Merge #15532: Remove sharp edge (uninit member) when using the compiler-ge...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d211edb34982...923d87497c7c
< bitcoin-git> bitcoin/master fa58a2e MarcoFalke: contrib: Bump gitian descriptors for 0.19
< bitcoin-git> bitcoin/master 923d874 MarcoFalke: Merge #15528: contrib: Bump gitian descriptors for 0.19
< gribble> https://github.com/bitcoin/bitcoin/issues/15560 | When to make bech32 the default -addresstype? · Issue #15560 · bitcoin/bitcoin · GitHub
< gmaxwell> Bitcoin core makes it pretty easy to get other addresses when you need them for compatiblity, fortunately.
< gribble> https://github.com/bitcoin/bitcoin/issues/14561 | Remove fs::relative call and fix listwalletdir tests by promag · Pull Request #14561 · bitcoin/bitcoin · GitHub
< fanquake> At least one issue reported for rc1 so far, https://github.com/bitcoin/bitcoin/issues/15555#issuecomment-470827939, although need more info.
< gmaxwell> Also, if you can think of the idea and getsomeone on fiverr to implement it, thats less harmful than something where a 5 year bitcoin expert has two spend three weeks extracting behavior patterns from codebases.
< shesek> maybe easier to think about this as "overall negative or positive effect on bitcoin users' privacy" than in morality terms
< gmaxwell> bitcoin core can but its a setting.
< gmaxwell> You might want to look over time, you may see the release when bitcoin core wouldn't violate UIH-2.
< shesek> not specifically electrum, quite a lot of other wallet software that I've had experience with. but yes, agreed, I didn't appreciate how good bitcoin core was at avoiding change, and didn't realize that it might break UIH-2 quite often
< gmaxwell> consistent. unbiased. e.g. all through our earlier discussion, you singled out behaviors of bitcoin because they aren't done by electrum, yet bitcoin core is responsible for a much larger share of transactions, so you're litterally singling out the larger anonymity set.
< gmaxwell> shesek: the end effect is you get some weird privacy warning on a small but non-trivial percentage of bitcoin core txn, ... but how does this help anyone? it just spreads fud. The txn are usually identifyable through other characteristics.
< shesek> UIH 1 or 2? UIH 1 is quite effective with most typical consumer wallet software. and you can check for some fingerprints first to try and rule out bitcoin core transactions (say, fee sniping nlocktime)
< gmaxwell> Well I still can't see how the UIH is essentially anything other than bitcoin core (derrived code) detection. And I think that sysematically putting up privacy warnings on the by far most private option (in spite its other costs) is really harmful.
< gmaxwell> I'm concerned with it being like the "bitcoin privacy project" which had a bunch of spurrious privacy unrelated ratings that caused it to derate the only options that had remotely good privacy (bitcoin core and armory) and rate over them a dozen wallets that sent all the users addresses to third parties.
< shesek> echeveria, the message shown when there's nothing to show is "his transaction doesn't violate any of the privacy gotchas we cover. Read on other potential ways it might leak privacy.", with a link to https://en.bitcoin.it/wiki/Privacy#Blockchain_attacks_on_privacy
< shesek> right, donations made by expert users that do manual coin selection is another potential reason. I was just writing that down in the wiki Privacy page today :) https://en.bitcoin.it/w/index.php?title=Privacy&diff=66261&oldid=66255
< gmaxwell> Again, it sounds like you're basically writing detect bitcoin core and print nasty warnings about litterly the only widely used wallet software that provides users with a decent degree of privacy at all.
< gmaxwell> that hurestic will pretty reliably misidentify change for many bitcoin core users right now. :)
< shesek> bitcoin core seems pretty smart about this. but, unfortunately, I don't think its actually being used to produce that many transactions, or does it? are there any estimates on that?
< gmaxwell> fees by, then there is probably a changeless solution, and bitcoin core will find it if there is one.
< gmaxwell> shesek: bitcoin core manages to produce changeless payments quite often, so long as the wallet has many inputs.
< gmaxwell> ./bitcoin-cli getpeerinfo | grep '^ "addr"' | grep '[0-9]\.' | cut -d'"' -f4 | cut -d':' -f1 | sort | uniq
< shesek> it would be interesting to test a bunch of transactions produced by bitcoin core and see what percent of them matches UIH-2. but I'm not using core to produce transactions, any thoughts on where one might be able to find a list of txids that are known to be core-originated?
< gmaxwell> shesek: IIRC bitcoin core has always violated it from day one. just not that all that often.
< gmaxwell> shesek: yes, bitcoin core will spend inputs a bit more when fees are low, though right now that behavior is kinda weak
< bitcoin-git> [bitcoin] fanquake opened pull request #15559: doc: correct analysepsbt rpc doc (master...fixup-analysepsbt-rpc-doc) https://github.com/bitcoin/bitcoin/pull/15559
< bitcoin-git> [bitcoin] Empact closed pull request #15556: build: Optionally enable -Wthread-safety-attributes (master...wthread-safety-attributes) https://github.com/bitcoin/bitcoin/pull/15556

2019-03-07

< gmaxwell> We probably don't want to randomly query them on each start, because if some are bad for your privacy (e.g. logging networks running bitcoin node) then you'll eventually hit them.
< bitcoin-git> [bitcoin] sipa opened pull request #15558: Query DNS seeds one by one (master...201903_dnsoneatatime) https://github.com/bitcoin/bitcoin/pull/15558
< gribble> https://github.com/bitcoin/bitcoin/issues/15103 | fix getentropy import check on osx by jameshilliard · Pull Request #15103 · bitcoin/bitcoin · GitHub
< * gmaxwell> votes to drop dnsseed discovery and just have bitcoin nodes scan the whole internet. :P
< gmaxwell> It does however mean that cloudflare is seeing the ip address of ~every bitcoin node.
< gmaxwell> (it's a 300s ttl at that level, but it's not like anyone else but bitcoin nodes are querying seeds.bitcoinstats.com )
< sipa> xps is where the bitcoin.sipa.be site runs
< gmaxwell> src/chainparams.cpp: vSeeds.emplace_back("seed.bitcoin.sipa.be"); // Pieter Wuille, only supports x1, x5, x9, and xd
< sipa> dig -t seed.bitcoin.sipa.be gives me the name of the machine running my dns seed; dig -t NS bitcoin.sipa.be gives me nothing
< gmaxwell> [gmaxwell@bean ~]$ dig +short NS bitcoin.sipa.be
< shesek> oh, sorry, I think #bitcoin-dev would probably be a better place to ask, shall I move it there?
< shesek> is it likely for bitcoin core to produce transactions matching UIH-2? (https://gist.github.com/AdamISZ/4551b947789d3216bacfcb7af25e029e#gistcomment-2796539, basically means that some inputs could've been avoided and the transaction would still have enough funding to cover the larger output)
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15464: gui: Drop unused return values in WalletFrame (master...2019-02-walletframe) https://github.com/bitcoin/bitcoin/pull/15464
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3db0cc394730...d211edb34982
< bitcoin-git> bitcoin/master 28c86de João Barbosa: gui: Drop unused return values in WalletFrame
< bitcoin-git> bitcoin/master d211edb Jonas Schnelli: Merge #15464: gui: Drop unused return values in WalletFrame
< gmaxwell> Probably we wouldn't propose implementing the multi-key version for bitcoin, but we had to feel out the design to figure out if it would be useful or not.
< provoostenator> I like being able to detect when my ISP starts messing with my Bitcoin P2P traffic :-)
< sipa> instagibbs: his position is that authentication without encryption is pointless (i agree, it mostly is), and that authentication of bitcoin connections is a slippery slope
< gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15519 | Add Poly1305 implementation by jonasschnelli · Pull Request #15519 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14047 | Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli · Pull Request #14047 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14049 | Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli · Pull Request #14049 · bitcoin/bitcoin · GitHub
< jonasschnelli> In case anyone wants to review the new v2 protocol (BIP151), including the new special ChaCha20Poly1305@bitcoin AEAD,... its here -> https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] instagibbs opened pull request #15557: Enhance `bumpfee` to include inputs when targeting a feerate (master...bumpall) https://github.com/bitcoin/bitcoin/pull/15557
< bitcoin-git> [bitcoin] Empact opened pull request #15556: build: Optionally enable -Wthread-safety-attributes (master...wthread-safety-attributes) https://github.com/bitcoin/bitcoin/pull/15556
< bitcoin-git> [bitcoin] laanwj merged pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/71ac4ebe4893...0fd3632868e2
< bitcoin-git> bitcoin/0.18 9d6dcc5 Pieter Wuille: Abstract EraseBlockData out of RewindBlockIndex
< bitcoin-git> bitcoin/0.18 32b2696 Pieter Wuille: Move erasure of non-active blocks to a separate loop in RewindBlockIndex
< bitcoin-git> bitcoin/0.18 1d34287 Pieter Wuille: Merge the disconnection and erasing loops in RewindBlockIndex
< bitcoin-git> [bitcoin] laanwj merged pull request #15552: 0.18: Granular invalidateblock and RewindBlockIndex (0.18...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15552
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/726d0668ff78...3db0cc394730
< bitcoin-git> bitcoin/master 9d6dcc5 Pieter Wuille: Abstract EraseBlockData out of RewindBlockIndex
< bitcoin-git> bitcoin/master 32b2696 Pieter Wuille: Move erasure of non-active blocks to a separate loop in RewindBlockIndex
< bitcoin-git> bitcoin/master 1d34287 Pieter Wuille: Merge the disconnection and erasing loops in RewindBlockIndex
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3515612e069e...726d0668ff78
< bitcoin-git> bitcoin/master faebd2e MarcoFalke: doc: Move wallet lock annotations to header
< bitcoin-git> bitcoin/master 726d066 MarcoFalke: Merge #15530: doc: Move wallet lock annotations to header
< bitcoin-git> [bitcoin] laanwj reopened pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] laanwj closed pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< wumpus> whoa at least the wumpus-announce list (i mean, bitcoin-core-dev) is still working
< bitcoin-git> [bitcoin] cisba opened pull request #15554: docs: binary tar improvement (master...improve-tar) https://github.com/bitcoin/bitcoin/pull/15554
< gmaxwell> /join #bitcoin
<@gwillen> but it's not really in keeping with the bitcoin-qt aesthetic
< bitcoin-git> [bitcoin] fanquake closed pull request #15544: Comment typo "iff" (master...master) https://github.com/bitcoin/bitcoin/pull/15544

2019-03-06

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15552: 0.18: Granular invalidateblock and RewindBlockIndex (0.18...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15552
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df36ddf9ce8a...3515612e069e
< bitcoin-git> bitcoin/master fa5dc35 MarcoFalke: rpc: Pass mempool into MempoolToJSON
< bitcoin-git> bitcoin/master fa38535 MarcoFalke: bench: Benchmark MempoolToJSON
< bitcoin-git> bitcoin/master 3515612 MarcoFalke: Merge #15473: bench: Benchmark MempoolToJSON
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15473: bench: Benchmark MempoolToJSON (master...Mf1902-benchRpcMempool) https://github.com/bitcoin/bitcoin/pull/15473
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15504: fuzz: Link BasicTestingSetup (shared with unit tests) (master...1903-testMain) https://github.com/bitcoin/bitcoin/pull/15504
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4952a953585e...df36ddf9ce8a
< bitcoin-git> bitcoin/master fab2daa MarcoFalke: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
< bitcoin-git> bitcoin/master fa02b22 MarcoFalke: test: Remove useless test_bitcoin_main.cpp
< bitcoin-git> bitcoin/master fa85468 MarcoFalke: test: Move main_tests to validation_tests
< bitcoin-git> [bitcoin] fametrano opened pull request #15550: [trivial] fixed path (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
< wumpus> andytoshi: that's a good question, normally the bitcoin-dev mailing list would be the best place to solicit feedback like that, but now that it's not working I don't really know
< gribble> https://github.com/bitcoin/bitcoin/issues/15549 | gitian: Improve error handling by laanwj · Pull Request #15549 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15548: build: use full version string in setup.exe (master...1903-winVer) https://github.com/bitcoin/bitcoin/pull/15548
< wumpus> so… it all turned out to be a VM disk space issue: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470160960
< bitcoin-git> [bitcoin] instagibbs opened pull request #15547: Switch wallet default to reject too-long transaction chains for mempool (master...walletreject_true) https://github.com/bitcoin/bitcoin/pull/15547
< provoostenator> I just need to brush up my bash to take only the first two digits from $VERSION in https://github.com/bitcoin-core/docs/issues/18
< provoostenator> The unsolved one is that we still use "bitcoin-linux-0.18-build.assert.sig" instead of "bitcoin-linux-0.18.0-build.assert.sig"
< gribble> https://github.com/bitcoin/bitcoin/issues/15546 | gitian: Windows installer EXE filenames lack "rcN" suffix · Issue #15546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
< luke-jr> bitcoin-0.18.0-win32-setup-unsigned.exe bitcoin-0.18.0rc1-win32.zip bitcoin-0.18.0-win64-setup-unsigned.exe bitcoin-0.18.0rc1-win64.zip
< provoostenator> File naming has some other issues too, in some places it doesn't include the patch version. See: https://github.com/bitcoin-core/docs/issues/18
< provoostenator> luke-jr: for which distro? Afaik bitcoind and bitcoin-cli never include a version number.
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15440 | RFC including boost-process · Issue #15440 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15545: [doc] explain why CheckBlock() is called before AcceptBlock (master...2019/03/clarify-checkblock) https://github.com/bitcoin/bitcoin/pull/15545
< * wumpus> doesn't even succeed in making the bitcoin core build deterministic so who am I to complain ...
< wumpus> same for the divergence between my own previous and current builds, except that affects bitcoin-qt
< wumpus> the difference seems to be minimal: presence/absence of .gnu_debuglink section: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470034776
< bitcoin-git> [bitcoin] Bushstar opened pull request #15544: Comment typo "iff" (master...master) https://github.com/bitcoin/bitcoin/pull/15544
< wumpus> unfortunately ,no they're different sizes, https://github.com/bitcoin/bitcoin/issues/15541
< wumpus> Binary files achow101/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin differ
< wumpus> Binary files achow101/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin differ
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521

2019-03-05

< booyah> mmgen: #bitcoin-bans is about discussing bans
< mmgen> sipa: well, I'd be happy to take it to #bitcoin, but gmaxwell has banned me there, for promoting "snake oil"
< mmgen> well if i'm banned on #bitcoin, how can I get unbanned?
<@gwillen> FWIW I think your tool looks cool, although I am skeptical that your alternative to BIP32 is an improvement but I'd be interested to hear about the motivation behind it (but not in this channel, perhaps #bitcoin-dev would accept such a conversation)
< gmaxwell> My logs show mmgen first joined #bitcoin on feb 23rd and in that time he his linked his tool 35 times.
<@gwillen> also, in general #bitcoin has a lot of people who are a danger to themselves in terms of running whatever software is in front of them
< mmgen> gmaxwell: is this a permanent ban from #bitcoin, greg? Just asking. To be honest, I'm astounded. As a long-time participant here, I wasn't expecting this
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #8471: Key origin metadata, with HD wallet support (master...keyorigin_hd) https://github.com/bitcoin/bitcoin/pull/8471
< bitcoin-git> [bitcoin] instagibbs opened pull request #15538: wallet_bumpfee.py: Make sure coin selection produces change (master...bumpfee_change_test) https://github.com/bitcoin/bitcoin/pull/15538
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15534: [test] lint-format-strings: open files sequentially (fix for OS X) (master...feature-fix-lint-osx) https://github.com/bitcoin/bitcoin/pull/15534
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8a62db8bf68...4952a953585e
< bitcoin-git> bitcoin/master 21be609 Glenn Willen: In lint-format-strings, open files sequentially
< bitcoin-git> bitcoin/master 4952a95 MarcoFalke: Merge #15534: [test] lint-format-strings: open files sequentially (fix for...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15531: Suggested interfaces::Chain cleanups from #15288 (master...pr/wclean2) https://github.com/bitcoin/bitcoin/pull/15531
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a74d588f2154...d8a62db8bf68
< bitcoin-git> bitcoin/master 4d4e4c6 Russell Yanofsky: Suggested interfaces::Chain cleanups from #15288
< bitcoin-git> bitcoin/master d8a62db MarcoFalke: Merge #15531: Suggested interfaces::Chain cleanups from #15288
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14954: build: Require python 3.5 (master...Mf1811-buildPython3) https://github.com/bitcoin/bitcoin/pull/14954
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/3800ca606896...a74d588f2154
< bitcoin-git> bitcoin/master fa6bf21 MarcoFalke: scripted-diff: test: Use py3.5 bytes::hex() method
< bitcoin-git> bitcoin/master fab5a1e MarcoFalke: build: Require python 3.5
< bitcoin-git> bitcoin/master fa0e65b MarcoFalke: scripted-diff: test: Remove brackets after assert
< jonasschnelli> I once proposed an ecc based authentication with no replay protection: https://github.com/bitcoin/bitcoin/pull/6604
< bitcoin-git> [bitcoin] laanwj merged pull request #15513: docs: add "sections" info to example bitcoin.conf (master...rebase-fixup-15387) https://github.com/bitcoin/bitcoin/pull/15513
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4b57b7f0f0c3...3800ca606896
< bitcoin-git> bitcoin/master 3eac2d5 Alistair Mann: docs: add "sections" info to example bitcoin.conf
< bitcoin-git> bitcoin/master 3800ca6 Wladimir J. van der Laan: Merge #15513: docs: add "sections" info to example bitcoin.conf
< fanquake> wumpus achow's build results are up here: https://github.com/achow101/bitcoin/releases/tag/v0.18.0rc1. I can upload mine as well if needed
< jonasschnelli> hmmm.... looks like the linux build is not deterministic: https://bitcointools.jonasschnelli.ch/data/builds/1007/bitcoin-linux-0.18-build.assert
< bitcoin-git> [bitcoin] laanwj merged pull request #15527: doc: Remove pr release notes file in wrong dir (master...1903-docRelPr) https://github.com/bitcoin/bitcoin/pull/15527
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14023c966c51...4b57b7f0f0c3
< bitcoin-git> bitcoin/master fad76e7 MarcoFalke: doc: Remove pr release notes file in wrong dir
< bitcoin-git> bitcoin/master 4b57b7f Wladimir J. van der Laan: Merge #15527: doc: Remove pr release notes file in wrong dir
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/6a178e52618d...71ac4ebe4893
< bitcoin-git> bitcoin/0.18 71ac4eb MarcoFalke: doc: Remove pr release notes file in wrong dir
< bitcoin-git> [bitcoin] fanquake closed pull request #15535: Dander (0.14...master) https://github.com/bitcoin/bitcoin/pull/15535
< bitcoin-git> [bitcoin] Deano1167 opened pull request #15535: Dander (0.14...master) https://github.com/bitcoin/bitcoin/pull/15535
< zhangzf> hello, Who have testnet bitcoin? Can you give me some, I want to test code. My address is mgSRBDvv9h2bRgZHGWLo4xQU9PLvssK6Yi
< bitcoin-git> [bitcoin] gwillen opened pull request #15534: In lint-format-strings, open files sequentially (fix for OS X failure) (master...feature-fix-lint-osx) https://github.com/bitcoin/bitcoin/pull/15534
< achow101> my gitian build results are available at https://github.com/achow101/bitcoin/releases/tag/v0.18.0rc1 if you need them

2019-03-04

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15533: test: .style.yapf: Set column_limit=160 (master...1903-testNoPep8Collim) https://github.com/bitcoin/bitcoin/pull/15533
< gmaxwell> Does anyone in here have a host with clang8? looks like fedora29 is using clang7. ISTM its assembly is broken: https://github.com/bitcoin-core/secp256k1/issues/594
< bitcoin-git> [bitcoin] practicalswift opened pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15531: Suggested interfaces::Chain cleanups from #15288 (master...pr/wclean2) https://github.com/bitcoin/bitcoin/pull/15531
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530
< bitcoin-git> [bitcoin] sipsorcery opened pull request #15529: WIP: Add Qt programs to msvc build (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528
< harding> dongcarl: I just tried and it lets me edit via the web interface but git push for the exact same change gives me: remote: Permission to bitcoin-core/bitcoin-devwiki.wiki.git denied to harding.
< gribble> https://github.com/bitcoin/bitcoin/issues/15527 | doc: Remove pr release notes file in wrong dir by MarcoFalke · Pull Request #15527 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15527: doc: Remove pr release notes file in wrong dir (master...1903-docRelPr) https://github.com/bitcoin/bitcoin/pull/15527
< harding> sipa: the PSBT doc was backported to the 0.17 branch but was not released in 0.17.1 (and there's no 0.17.2 yet). See MarcoFalke and my discussion about it here: https://github.com/bitcoin/bitcoin/pull/15314#issuecomment-459740847
< dongcarl> Anyone know how to push to the wiki? I've got `git@github.com:bitcoin-core/bitcoin-devwiki.wiki.git` as my remote and git tells me permission denied
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45f434f44d0b...14023c966c51
< bitcoin-git> bitcoin/master fa45123 MarcoFalke: test: Add .style.yapf
< bitcoin-git> bitcoin/master 14023c9 MarcoFalke: Merge #15479: test: Add .style.yapf
< dongcarl> wumpus: Wondering what should be done about https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes/release-notes-pr12255.md ? It seems that at least it should go in the release notes for 0.18, and perhaps removed from the tree?
< bitcoin-git> [bitcoin] MarcoFalke pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/57acfcb9fd05...45f434f44d0b
< bitcoin-git> bitcoin/master 80f52a2 Russell Yanofsky: Remove uses of CheckFinalTx in wallet code
< bitcoin-git> bitcoin/master bdc6628 Russell Yanofsky: Remove use of IsRBFOptIn in wallet code
< bitcoin-git> bitcoin/master 291276f Russell Yanofsky: Remove use of GetCountWithDescendants in wallet code
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15288: Remove wallet -> node global function calls (master...pr/wchain3) https://github.com/bitcoin/bitcoin/pull/15288
< Dizzle> lorko123: let's take this to #bitcoin
< lorko123> anyone know how to mine bitcoin directly with bitcoin core
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
< bitcoin-git> [bitcoin] laanwj deleted tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/329381d6ae9a...000000000000
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/7630301c1628...6a178e52618d
< bitcoin-git> bitcoin/0.18 6a178e5 Wladimir J. van der Laan: build: set RC1
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/b702e3757e1d...7630301c1628
< bitcoin-git> bitcoin/0.18 fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
< bitcoin-git> bitcoin/0.18 7630301 Wladimir J. van der Laan: Merge #15524: [0.18] doc: Remove ppa from linux build instructions
< bitcoin-git> [bitcoin] laanwj merged pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
< wumpus> 0.18.0 release notes draft up on the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/742f7dd972fc...b702e3757e1d
< bitcoin-git> bitcoin/0.18 b702e37 Wladimir J. van der Laan: doc: Merge release notes fragments
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
<@luke-jr> rafalcpp: include a copy of just boost::process in the Bitcoin source code, used when the system lacks it
< rafalcpp> I could make another small script to grab + build enough of boost to have boost::process for Bitcoin
< bitcoin-git> [bitcoin] practicalswift opened pull request #15522: Document sizeof(size_t) assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
< gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d46f1be0c3c...57acfcb9fd05
< bitcoin-git> bitcoin/master fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
< bitcoin-git> bitcoin/master 57acfcb Wladimir J. van der Laan: Merge #15518: doc: Remove ppa from linux build instructions
< wumpus> so is there anything in https://github.com/bitcoin/bitcoin/milestones/0.18.0 that blocks rc1?
< bitcoin-git> [bitcoin] rojarsmith opened pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521

2019-03-03

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15520: ci: Run extended tests (master...1903-ciExt) https://github.com/bitcoin/bitcoin/pull/15520
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15519: Add Poly1305 implementation (master...2019/03/poly1305) https://github.com/bitcoin/bitcoin/pull/15519
< gribble> https://github.com/bitcoin/bitcoin/issues/15474 | rest/rpc: Make mempoolinfo atomic by promag · Pull Request #15474 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15464 | gui: Drop unused return values in WalletFrame by promag · Pull Request #15464 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518
< bitcoin-git> [bitcoin] promag opened pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517
< gribble> https://github.com/bitcoin/bitcoin/issues/15500 | Support for a bitcoind ready file to indicate startup is complete. by murrayn · Pull Request #15500 · bitcoin/bitcoin · GitHub

2019-03-02

< bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/789b0bbf2afc...2d46f1be0c3c
< bitcoin-git> bitcoin/master 62e7add Jim Posen: util: Move CheckDiskSpace to util.
< bitcoin-git> bitcoin/master 9183d6e Jim Posen: validation: Extract basic block file logic into FlatFileSeq class.
< bitcoin-git> bitcoin/master e2d2abb Jim Posen: validation: Refactor OpenDiskFile into method on FlatFileSeq.
< bitcoin-git> [bitcoin] laanwj merged pull request #15118: Refactor block file logic (master...flatfile) https://github.com/bitcoin/bitcoin/pull/15118
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15335: Fix lack of warning of unrecognized section names (master...conf_include_multi) https://github.com/bitcoin/bitcoin/pull/15335
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/849f37fa22b0...789b0bbf2afc
< bitcoin-git> bitcoin/master 1a7ba84 Akio Nakamura: Fix lack of warning of unrecognized section names
< bitcoin-git> bitcoin/master 789b0bb MarcoFalke: Merge #15335: Fix lack of warning of unrecognized section names
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80112b17e75b...849f37fa22b0
< bitcoin-git> bitcoin/master fa1d400 MarcoFalke: cirrus ci: Inital config
< bitcoin-git> bitcoin/master 849f37f MarcoFalke: Merge #15338: ci: Build and run tests once on freebsd
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15296: tests: Add script checking for deterministic line coverage in unit tests (master...test_deterministic_coverage) https://github.com/bitcoin/bitcoin/pull/15296
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e3122de054a...80112b17e75b
< bitcoin-git> bitcoin/master 4320623 practicalswift: tests: Add script checking for deterministic line coverage
< bitcoin-git> bitcoin/master 80112b1 MarcoFalke: Merge #15296: tests: Add script checking for deterministic line coverage i...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e47d8a1b7c8b...9e3122de054a
< bitcoin-git> bitcoin/master 8bb3e4c Sjors Provoost: [rpc] remove deprecated generate method
< bitcoin-git> bitcoin/master 07cae52 Sjors Provoost: [wallet] remove unused GetScriptForMining
< bitcoin-git> bitcoin/master 9e3122d MarcoFalke: Merge #15492: [rpc] remove deprecated generate method
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15492: [rpc] remove deprecated generate method (master...2019/02/rpc-generate-remove) https://github.com/bitcoin/bitcoin/pull/15492
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c9985c84f9c1...e47d8a1b7c8b
< bitcoin-git> bitcoin/master 10c7642 marcuswin: docs: Update Transifex links
< bitcoin-git> bitcoin/master e47d8a1 MarcoFalke: Merge #15514: docs: Update Transifex links
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15514: docs: Update Transifex links (master...rebase-fixup-15406) https://github.com/bitcoin/bitcoin/pull/15514
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/37f236acc6de...c9985c84f9c1
< bitcoin-git> bitcoin/master c9985c8 Wladimir J. van der Laan: build: Bump version to 0.18.99
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/37f236acc6de...742f7dd972fc
< bitcoin-git> bitcoin/0.18 742f7dd Wladimir J. van der Laan: build: Bump version to 0.18.0
< bitcoin-git> [bitcoin] darosior closed pull request #15511: RPC : More user-friendly services field in getnetworkinfo and getpeerinfo (master...services_for_humans) https://github.com/bitcoin/bitcoin/pull/15511
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< wumpus> good, it worked; [bitcoin-git] is logged in as bitcoin-git
< bitcoin-git> [bitcoin] fanquake closed pull request #15071: Docs: add gmake syntax to autoconf script (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15071
< gribble> https://github.com/bitcoin/bitcoin/issues/15071 | Docs: add gmake syntax to autoconf script by seth586 · Pull Request #15071 · bitcoin/bitcoin · GitHub
< wumpus> FWIW, I have registered bitcoin-git as well, and added a password to the bot configuration
< bitcoin-git> [bitcoin] fanquake opened pull request #15514: docs: Update Transifex links (master...rebase-fixup-15406) https://github.com/bitcoin/bitcoin/pull/15514