< bitcoin-git>
[bitcoin] promag opened pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git>
[bitcoin] dongcarl opened pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | WIP: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipsorcery closed pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995
< sipa>
this is about the bitcoin scirpt language as it exists today, without any softforks or other changes to consensus needed (but obviously prepared for those)
< sipa>
so me and some colleagues of mine have been working on a way to make more complex bitcoin scripts more accessible, in a project called miniscript
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] achow101 opened pull request #16341: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) (master...box-the-wallet) https://github.com/bitcoin/bitcoin/pull/16341
< bitcoin-git>
[bitcoin] fanquake merged pull request #16308: [MSVC] Copy build output to src/ automatically after build (master...build/copy-in-msbuild) https://github.com/bitcoin/bitcoin/pull/16308
< bitcoin-git>
[bitcoin] qmma70 opened pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< sipa>
sorry i haven't found much time for review; i've been spending a lot of time on improving and implementing miniscript, which i hope will at some point be integratable in bitcoin core
< bitcoin-git>
[bitcoin] emilengler closed pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< bitcoin-git>
[bitcoin] fanquake closed pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336
< bitcoin-git>
bitcoin/0.18 5935f01 MarcoFalke: build with -fstack-reuse=none
< bitcoin-git>
bitcoin/0.18 9c1a607 MarcoFalke: net: Rename ::fRelayTxes to ::g_relay_txes
< bitcoin-git>
bitcoin/0.18 8f215c7 MarcoFalke: test: Format predicate source as multiline on error
< bitcoin-git>
[bitcoin] qmma70 opened pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336
2019-07-03
< bitcoin-git>
[bitcoin] dongcarl opened pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git>
bitcoin/master faa1e0f MarcoFalke: qt: test: Create at most one testing setup
< bitcoin-git>
bitcoin/master 38fbb57 Wladimir J. van der Laan: Merge #16294: qt: test: Create at most one testing setup
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16331: build: Add configure option --enable-lowmem to allow for building in low-memory environments (master...low-mem) https://github.com/bitcoin/bitcoin/pull/16331
< bitcoin-git>
[bitcoin] laanwj merged pull request #16158: Fix logic of memory_cleanse() on MSVC and clean up docs (master...cleanup-cleanse) https://github.com/bitcoin/bitcoin/pull/16158
< bitcoin-git>
[bitcoin] hebasto opened pull request #16330: docs: Update release signing key expiration date (master...20190702-key-expiration) https://github.com/bitcoin/bitcoin/pull/16330
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16329: test: Add tests for getblockchaininfo.softforks (master...1907-qaSoftforksHeight) https://github.com/bitcoin/bitcoin/pull/16329
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16328: rpc: Tidy up reporting of buried and ongoing softforks (master...1907-rpcSoftforks) https://github.com/bitcoin/bitcoin/pull/16328
< bitcoin-git>
[bitcoin] hebasto opened pull request #16327: scripts and tools: Update ShellCheck linter (master...20190702-shellcheck) https://github.com/bitcoin/bitcoin/pull/16327
< bitcoin-git>
[bitcoin] jnewbery opened pull request #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables (master...2019-07-utxoupdatepsbt-args) https://github.com/bitcoin/bitcoin/pull/16326
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16325: rpc: Clarify that block count means height excl genesis (master...1907-rpcBlockCount) https://github.com/bitcoin/bitcoin/pull/16325
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git>
bitcoin/master fa2b083 MarcoFalke: [test] Add test to check mempool consistency in case of reorgs
< bitcoin-git>
[bitcoin] promag opened pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git>
bitcoin/master 6c21a80 Wladimir J. van der Laan: Merge #15538: wallet_bumpfee.py: Make sure coin selection produces change
< bitcoin-git>
[bitcoin] laanwj merged pull request #16212: addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors (master...SerializeFileDB-non-determinism) https://github.com/bitcoin/bitcoin/pull/16212
< bitcoin-git>
bitcoin/master d975338 practicalswift: addrdb: Remove temporary files created in SerializeFileDB. Fixes non-deter...
< bitcoin-git>
bitcoin/master 3ccab64 Wladimir J. van der Laan: Merge #16212: addrdb: Avoid eating inodes - remove temporary files created...
2019-07-01
< wumpus>
pinheadmz: that was always the problem, I'm usually happy to help people but it was always the same discussions about bitcoin over and over again, that just wears you out
< pinheadmz>
The room "#bitcoin" on "chat.freenode.net" is invite only. -- getting this message today all of a sudden, anyone else?
< bitcoin-git>
[bitcoin] laanwj merged pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
< bitcoin-git>
bitcoin/master 806b005 Sjors Provoost: [wallet] abort when attempting to fund a transaction above maxtxfee
< bitcoin-git>
bitcoin/master 1212808 Wladimir J. van der Laan: Merge #16257: [wallet] abort when attempting to fund a transaction above -...
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16320: ci: Add Travis check to catch accidental introduction of non-determinism in unit tests (master...test-deterministic-coverage-in-travis) https://github.com/bitcoin/bitcoin/pull/16320
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #16319: [MSVC] Simplify AppVeyor build by using user customized project file (master...msvc/appveyor-refactor) https://github.com/bitcoin/bitcoin/pull/16319
< bitcoin-git>
[bitcoin] promag closed pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
< bitcoin-git>
[bitcoin] emilengler opened pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< phantomcircuit>
it was called "Bitcoin Wallet" by ... however you spell his name
< sipa>
phantomcircuit, gwillen: well... i don't think; bitcoin wallet for android started as a project when afaik literally it was the first android wallet (it may have been the first wallet software besides core entirely); i don't think in that context it was unreasonable to call it that way
< bitcoin-git>
[bitcoin] fanquake merged pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< phantomcircuit>
gwillen, bitcoin wallet by bitcoin wallet developers is schilbach i think
< harding>
gwillen: that email address isn't legit. I let the owner of bitcoin.org know so he could file his own report (I filed a report myself).
2019-06-29
< gwillen>
luke-jr: I have no idea, that would make sense but "Bitcoin Wallet developers" is very vague so it made me suspicious. It has strong reviews though.
< gwillen>
hm, the developer contact email is listed as "adminsupport@bitcoin.org"
< luke-jr>
"Bitcoin Wallet" is the original Android wallet, right?
< gwillen>
(this is on "Bitcoin Core - BTC Wallet")
< gwillen>
midnightmagic: there is another one called "Bitcoin Wallet" by "Bitcoin Wallet developers"
< midnightmagic>
er. the bitcoin core - btc wallet one I mean is just a rebranded breadwallet.
< gwillen>
midnightmagic: I assume you are looking at "Bitcoin Core - BTC Wallet" by "Core Org"? (I have no idea what it is, I endorse marking it malware if nobody knows what it is.)
< bitcoin-git>
[bitcoin] hebasto opened pull request #16314: scripts and tools: Update copyright_header.py script (master...20190629-copyright-headers) https://github.com/bitcoin/bitcoin/pull/16314
< bitcoin-git>
[bitcoin] jonatack opened pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16312: tests: Reduce compile-time memory usage by 0.5 GB when compiling script_tests.cpp (from 1.4 GB to 0.9 GB) (master...fix-absurd-memory-usage-when-compiling-script_build) https://github.com/bitcoin/bitcoin/pull/16312
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #16308: [MSVC] Copy build output to src/ automatically after build (master...build/copy-in-msbuild) https://github.com/bitcoin/bitcoin/pull/16308
< bitcoin-git>
[bitcoin] fanquake merged pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
< bitcoin-git>
bitcoin/master fa69c3e MarcoFalke: util: Explain why the path is cached
< bitcoin-git>
bitcoin/master 935cd6b Wladimir J. van der Laan: Merge #16300: util: Explain why the path is cached
< bitcoin-git>
[bitcoin] achow101 opened pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301
2019-06-27
< bitcoin-git>
[bitcoin] meshcollider closed pull request #16192: Wallet: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192
< bitcoin-git>
[bitcoin] promag opened pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git>
[bitcoin] promag closed pull request #12419: Force distinct destinations in CWallet::CreateTransaction (master...2018-02-distinct-destinations) https://github.com/bitcoin/bitcoin/pull/12419
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< dongcarl>
For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
< bitcoin-git>
[bitcoin] practicalswift closed pull request #16045: Skip redundant memset(p, 0, 0) calls where p is not valid for writing (master...redundant-memsets) https://github.com/bitcoin/bitcoin/pull/16045
< jtimon>
regarding https://github.com/bitcoin/bitcoin/pull/8994 I'm not sure it needs conceptual review (I'm sure there's many concept acks buried in the comments), but mostly review and re-review