2017-04-05

< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/df82ea914f6f569e244ab59ca24e4eea898eb1a9
< gribble> https://github.com/bitcoin/bitcoin/issues/10094 | 0.14: Clear release notes by MarcoFalke · Pull Request #10094 · bitcoin/bitcoin · GitHub
< wumpus> anoyone care to write something about notable changes in 0.14.1? https://github.com/bitcoin/bitcoin/blob/0.14/doc/release-notes.md#notable-changes
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/920acbcca8240cb11a74055a81d5129c8a4c85af
< bitcoin-git> bitcoin/0.14 920acbc Wladimir J. van der Laan: doc: Update release notes for 0.14.1
< bitcoin-git> [bitcoin] laanwj closed pull request #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails) (master...logging_initialization) https://github.com/bitcoin/bitcoin/pull/10151
< bitcoin-git> bitcoin/master c7e73ea Wladimir J. van der Laan: Merge #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails)...
< bitcoin-git> bitcoin/master cd7f394 John Newbery: initialize flag variable to 0 (and continue if GetLogCategory() fails)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c95bd43d8ff...c7e73eafa139
< bitcoin-git> [bitcoin] laanwj closed pull request #10154: init: Remove redundant logging code (master...Mf1704-lognodebug) https://github.com/bitcoin/bitcoin/pull/10154
< bitcoin-git> bitcoin/master 3c95bd4 Wladimir J. van der Laan: Merge #10154: init: Remove redundant logging code...
< bitcoin-git> bitcoin/master faafa80 MarcoFalke: init: Remove redundant logging code
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fade78854cf4...3c95bd43d8ff
< bitcoin-git> [bitcoin] AllanDoensen opened pull request #10156: Fix for issues with startup and mutiple monitors on windows. (master...masterMultiMonFix) https://github.com/bitcoin/bitcoin/pull/10156
< bitcoin-git> [bitcoin] laanwj opened pull request #10155: build: Deduplicate version numbers (master...2017_03_version_bump) https://github.com/bitcoin/bitcoin/pull/10155
< bitcoin-git> [bitcoin] laanwj closed pull request #10153: logging: Fix off-by-one for shrinkdebugfile default (master...Mf1704-offbyoneDebug) https://github.com/bitcoin/bitcoin/pull/10153
< bitcoin-git> bitcoin/master fade788 Wladimir J. van der Laan: Merge #10153: logging: Fix off-by-one for shrinkdebugfile default...
< bitcoin-git> bitcoin/master faab624 MarcoFalke: logging: Fix off-by-one for shrinkdebugfile
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f93f9b92969b...fade78854cf4
< bitcoin-git> bitcoin/0.14 47d24c8 Wladimir J. van der Laan: Bump version to 0.14.1
< bitcoin-git> bitcoin/0.14 ea060c7 Suhas Daftuar: Bugfix: ancestor modifed fees were incorrect for descendants...
< bitcoin-git> bitcoin/0.14 d947afc Suhas Daftuar: Test prioritisetransaction and ancestor fee state...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/0e5133cb2ef8...47d24c85b71b
< bitcoin-git> [bitcoin] laanwj closed pull request #10144: Prioritisetransaction wasn't always updating ancestor fee (master...2017-04-fix-mempool-modified-ancestor-fees) https://github.com/bitcoin/bitcoin/pull/10144
< bitcoin-git> bitcoin/master f93f9b9 Wladimir J. van der Laan: Merge #10144: Prioritisetransaction wasn't always updating ancestor fee...
< bitcoin-git> bitcoin/master 9bef02e Suhas Daftuar: Bugfix: ancestor modifed fees were incorrect for descendants...
< bitcoin-git> bitcoin/master ba7dd8b Suhas Daftuar: Test prioritisetransaction and ancestor fee state...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5fc6a77aa626...f93f9b92969b
< bitcoin-git> bitcoin/0.14 0e5133c Alex Morcos: Make threshold for flushing more conservative....
< bitcoin-git> bitcoin/0.14 d686768 Alex Morcos: Lower default memory footprint slightly...
< bitcoin-git> bitcoin/0.14 ab864d3 Alex Morcos: Make pcoinsTip memory calculations consistent...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/a44a6a15f94a...0e5133cb2ef8
< bitcoin-git> [bitcoin] laanwj closed pull request #10133: Clean up calculations of pcoinsTip memory usage (master...cachememory) https://github.com/bitcoin/bitcoin/pull/10133
< bitcoin-git> bitcoin/master 1b55e07 Alex Morcos: Make threshold for flushing more conservative....
< bitcoin-git> bitcoin/master f33afd3 Alex Morcos: Lower default memory footprint slightly
< bitcoin-git> bitcoin/master 5b95a19 Alex Morcos: Make pcoinsTip memory calculations consistent...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fadf078c9cd7...5fc6a77aa626
< bitcoin-git> [bitcoin] laanwj closed pull request #10104: linearize script: Option to use RPC cookie (master...linearize-use-cookie) https://github.com/bitcoin/bitcoin/pull/10104
< bitcoin-git> bitcoin/master fadf078 Wladimir J. van der Laan: Merge #10104: linearize script: Option to use RPC cookie...
< bitcoin-git> bitcoin/master bd41d98 Andrew Chow: Datadir option in linearize scripts...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/080d7c700fc3...fadf078c9cd7

2017-04-04

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #10154: init: Remove redundant logging code (master...Mf1704-lognodebug) https://github.com/bitcoin/bitcoin/pull/10154
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #10153: logging: Fix off-by-one for shrinkdebugfile default (master...Mf1704-offbyoneDebug) https://github.com/bitcoin/bitcoin/pull/10153
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10152: [trivial] remove unused line in Travis config (master...travis_cleanup) https://github.com/bitcoin/bitcoin/pull/10152
< bitcoin-git> bitcoin/master 16791c5 John Newbery: [trivial] remove unused line in Travis config
< bitcoin-git> bitcoin/master 080d7c7 MarcoFalke: Merge #10152: [trivial] remove unused line in Travis config...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/72bc7e1303d5...080d7c700fc3
< bitcoin-git> [bitcoin] jnewbery opened pull request #10152: [trivial] remove unused line in Travis config (master...travis_cleanup) https://github.com/bitcoin/bitcoin/pull/10152
< bitcoin-git> [bitcoin] jnewbery opened pull request #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails) (master...logging_initialization) https://github.com/bitcoin/bitcoin/pull/10151
< bsm117532> My question is: does bitcoin consensus-enforce the statements in BIP16 about disallowing non-pushdata?
< bitcoin-git> [bitcoin] jnewbery opened pull request #10150: [rpc Add logging rpc (master...logging_rpc) https://github.com/bitcoin/bitcoin/pull/10150
< bitcoin-git> [bitcoin] sipa opened pull request #10148: Use non-atomic flushing with block replay (master...non_atomic_flush) https://github.com/bitcoin/bitcoin/pull/10148
< da2ce7> In particular this pull request need code-review: https://github.com/bitcoin/bips/pull/512
< da2ce7> I have updated both my Bitcoin Knots and Bitcoin Core 0.14 patches for BIP 148
< bitcoin-git> [bitcoin] laanwj closed pull request #10146: Better error handling for submitblock (master...better_error_submitblock) https://github.com/bitcoin/bitcoin/pull/10146
< bitcoin-git> bitcoin/master 30f30c0 Gregory Maxwell: Add braces to submitblock per current style.
< bitcoin-git> bitcoin/master 4f15ea1 Gregory Maxwell: Check transaction count early in submitblock....
< bitcoin-git> bitcoin/master ada0caa Gregory Maxwell: Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn....
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/471ed00fcd3b...72bc7e1303d5
< bitcoin-git> [bitcoin] gmaxwell opened pull request #10146: Better error handling for submitblock (master...better_error_submitblock) https://github.com/bitcoin/bitcoin/pull/10146

2017-04-03

< bitcoin-git> [bitcoin] JeremyRubin opened pull request #10145: Separate Contextual checks and handling & switch on enum in net_processing.cpp (master...netprocessing_enum_rebased) https://github.com/bitcoin/bitcoin/pull/10145
< bitcoin-git> [bitcoin] theuni reopened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git> [bitcoin] theuni closed pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10144: Prioritisetransaction wasn't always updating ancestor fee (master...2017-04-fix-mempool-modified-ancestor-fees) https://github.com/bitcoin/bitcoin/pull/10144
< bitcoin-git> [bitcoin] jnewbery opened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git> [bitcoin] laanwj closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git> bitcoin/master 471ed00 Wladimir J. van der Laan: Merge #10123: Allow debug logs to be excluded from specified component...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb598cfba1cb...471ed00fcd3b
< bitcoin-git> bitcoin/master 3bde556 John Newbery: Add -debugexclude option to switch off logging for specified components
< bitcoin-git> [bitcoin] ryanofsky closed pull request #10117: Fix "make check" on systems with qt and libxcb but no active DISPLAY (master...pr/noqapp) https://github.com/bitcoin/bitcoin/pull/10117
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10142: Run bitcoin_test-qt under minimal QPA platform (master...pr/qtmin) https://github.com/bitcoin/bitcoin/pull/10142
< bitcoin-git> [bitcoin] laanwj closed pull request #9533: Allow non-power-of-2 signature cache sizes (master...anysigcachesize) https://github.com/bitcoin/bitcoin/pull/9533
< bitcoin-git> bitcoin/master 7482781 Pieter Wuille: Allow non-power-of-2 signature cache sizes
< bitcoin-git> bitcoin/master cb598cf Wladimir J. van der Laan: Merge #9533: Allow non-power-of-2 signature cache sizes...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a2cd0b0eecfe...cb598cfba1cb
< bitcoin-git> [bitcoin] laanwj closed pull request #10058: No need to use OpenSSL malloc/free (master...tjps_ssl_mutex) https://github.com/bitcoin/bitcoin/pull/10058
< bitcoin-git> bitcoin/master a2cd0b0 Wladimir J. van der Laan: Merge #10058: No need to use OpenSSL malloc/free...
< bitcoin-git> bitcoin/master 6d5dd60 Thomas Snider: No need to use OpenSSL malloc/free
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6033e00b164...a2cd0b0eecfe
< bitcoin-git> bitcoin/0.14 f15268d practicalswift: [rpc] Remove auth cookie on shutdown...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/f15268db3bf1a8c4ea410f4f63c6187b45e06ded
< bitcoin-git> [bitcoin] laanwj closed pull request #10139: [rpc] Remove auth cookie on shutdown (master...delete-auth-cookies) https://github.com/bitcoin/bitcoin/pull/10139
< bitcoin-git> bitcoin/master 4b87973 practicalswift: [rpc] Remove auth cookie on shutdown...
< bitcoin-git> bitcoin/master e6033e0 Wladimir J. van der Laan: Merge #10139: [rpc] Remove auth cookie on shutdown...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ebfd65379811...e6033e00b164

2017-04-02

< bitcoin-git> [bitcoin] jnewbery reopened pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git> [bitcoin] jnewbery closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git> [bitcoin] jnewbery reopened pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< Naphex> [4761171.418546] bitcoin-httpwor[39240]: segfault at 0 ip 0000002314a2a1b7 sp 00000393b3f1f4f0 error 4 in bitcoind[23148a2000+550000]
< bitcoin-git> [bitcoin] practicalswift opened pull request #10139: [rpc] Remove auth cookie on shutdown (master...delete-auth-cookies) https://github.com/bitcoin/bitcoin/pull/10139
< bitcoin-git> [bitcoin] laanwj closed pull request #10077: [qa] Add setnetworkactive smoke test (master...Mf1703-toggleNet) https://github.com/bitcoin/bitcoin/pull/10077
< bitcoin-git> bitcoin/master ebfd653 Wladimir J. van der Laan: Merge #10077: [qa] Add setnetworkactive smoke test...
< bitcoin-git> bitcoin/master fa697b7 MarcoFalke: [qa] Add setnetworkactive smoke test
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12af74b289f8...ebfd65379811
< da2ce7> this commit is based upon bitcoin knots
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10072: Remove sources of unreliablility in extended functional tests (master...extended_test_unreliablility) https://github.com/bitcoin/bitcoin/pull/10072
< bitcoin-git> bitcoin/master 12af74b MarcoFalke: Merge #10072: Remove sources of unreliablility in extended functional tests...
< bitcoin-git> bitcoin/master a4fd89f John Newbery: Make forknotify.py more robust...
< bitcoin-git> bitcoin/master 1f3d78b John Newbery: Wait for connection to open in bip9-softforks.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b477e6aa196...12af74b289f8
< bitcoin-git> [bitcoin] laanwj closed pull request #10098: Make qt wallet test compatible with qt4 (master...pr/wqt4) https://github.com/bitcoin/bitcoin/pull/10098
< bitcoin-git> bitcoin/master 2b477e6 Wladimir J. van der Laan: Merge #10098: Make qt wallet test compatible with qt4...
< bitcoin-git> bitcoin/master e9a6461 Russell Yanofsky: Make qt wallet test compatible with qt4...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fbf36cae3a46...2b477e6aa196
< bitcoin-git> [bitcoin] fanquake closed pull request #9418: [Net] Refactor: exit when no direct fetch (master...ExitWhenNoDirectFetch) https://github.com/bitcoin/bitcoin/pull/9418
< bitcoin-git> [bitcoin] fanquake closed pull request #9402: Allow per network configuration file (master...PerNetworkConfig) https://github.com/bitcoin/bitcoin/pull/9402
< gribble> https://github.com/bitcoin/bitcoin/issues/10138 | LevelDB 1.20 · Issue #10138 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10036: Fix init README format to render correctly on github (master...readmeFormatting) https://github.com/bitcoin/bitcoin/pull/10036
< bitcoin-git> bitcoin/master fbf36ca Wladimir J. van der Laan: Merge #10036: Fix init README format to render correctly on github...
< bitcoin-git> bitcoin/master b99fbad Jameson Lopp: Fix init README format to render correctly on github
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/427d2fd04eee...fbf36cae3a46
< gribble> https://github.com/bitcoin/bitcoin/issues/10036 | Fix init README format to render correctly on github by jlopp · Pull Request #10036 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10128: Speed Up CuckooCache tests (master...cuckoo-tests-faster) https://github.com/bitcoin/bitcoin/pull/10128
< bitcoin-git> bitcoin/master 427d2fd Wladimir J. van der Laan: Merge #10128: Speed Up CuckooCache tests...
< bitcoin-git> bitcoin/master 3f098cc Jeremy Rubin: Decrease testcase sizes in cuckoocache tests
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1a5aaabb8a3d...427d2fd04eee
< bitcoin-git> [bitcoin] fanquake closed pull request #10121: Add missing header file (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10121
< bitcoin-git> [bitcoin] laanwj closed pull request #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings. (master...log_category_simplify) https://github.com/bitcoin/bitcoin/pull/9424
< bitcoin-git> bitcoin/master 1a5aaab Wladimir J. van der Laan: Merge #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings....
< bitcoin-git> bitcoin/master 6b3bb3d Gregory Maxwell: Change LogAcceptCategory to use uint32_t rather than sets of strings....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81da4c7b5bc1...1a5aaabb8a3d
< bitcoin-git> [bitcoin] laanwj closed pull request #10136: build: Disable Wshadow warning (master...2017_04_disable_wshadow) https://github.com/bitcoin/bitcoin/pull/10136
< bitcoin-git> bitcoin/master 81da4c7 Wladimir J. van der Laan: Merge #10136: build: Disable Wshadow warning...
< bitcoin-git> bitcoin/master 2c83911 Wladimir J. van der Laan: build: Disable Wshadow warning...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/351d0ad40495...81da4c7b5bc1
< gribble> https://github.com/bitcoin/bitcoin/issues/10098 | Make qt wallet test compatible with qt4 by ryanofsky · Pull Request #10098 · bitcoin/bitcoin · GitHub

2017-04-01

< bitcoin-git> [bitcoin] practicalswift opened pull request #10137: Remove unused import. Remove accidental trailing semicolons. (master...python-20170402) https://github.com/bitcoin/bitcoin/pull/10137
< bitcoin-git> [bitcoin] laanwj opened pull request #10136: build: Disable Wshadow warning (master...2017_04_disable_wshadow) https://github.com/bitcoin/bitcoin/pull/10136
< bitcoin-git> bitcoin/master 351d0ad Wladimir J. van der Laan: Merge #10129: scheduler: fix sub-second precision with boost < 1.50...
< bitcoin-git> [bitcoin] laanwj closed pull request #10129: scheduler: fix sub-second precision with boost < 1.50 (master...fix-scheduler-millisecs) https://github.com/bitcoin/bitcoin/pull/10129
< bitcoin-git> bitcoin/master e025246 Cory Fields: scheduler: fix sub-second precision with boost < 1.50
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4aa07fa73569...351d0ad40495

2017-03-31

< bitcoin-git> [bitcoin] jnewbery closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git> [bitcoin] jnewbery opened pull request #10135: Send the correct error code in reject messages (master...correctrejectmessages) https://github.com/bitcoin/bitcoin/pull/10135
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10134: [qa] Fixes segwit block relay test after inv-direct-fetch was disabled (master...2017-03-fix-segwit-relay-test) https://github.com/bitcoin/bitcoin/pull/10134
< gribble> https://github.com/bitcoin/bitcoin/issues/10133 | Clean up calculations of pcoinsTip memory usage by morcos · Pull Request #10133 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #10133: Clean up calculations of pcoinsTip memory usage (master...cachememory) https://github.com/bitcoin/bitcoin/pull/10133
< gribble> https://github.com/bitcoin/bitcoin/issues/10126 | Compensate for memory peak at flush time by sipa · Pull Request #10126 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10095: refactor: Move GetDifficulty out of `rpc/server.h` (master...2017_03_getdifficulty_header) https://github.com/bitcoin/bitcoin/pull/10095
< bitcoin-git> bitcoin/master f885b67 Wladimir J. van der Laan: refactor: Make rest.cpp dependency on `*toJSON` in `blockchain.cpp` explicit
< bitcoin-git> bitcoin/master e6dcfee Wladimir J. van der Laan: refactor: Move GetDifficulty out of `rpc/server.h`...
< bitcoin-git> bitcoin/master 8d8f28d Wladimir J. van der Laan: refactor: Move RPCNotifyBlockChange out of `rpc/server.h`
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ab26bf7e428...4aa07fa73569
< bitcoin-git> bitcoin/0.14 0b5e162 Pieter Wuille: Compensate for memory peak at flush time...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/0b5e162b84ec95cb63903dd21e4003a3d4503421
< bitcoin-git> [bitcoin] laanwj closed pull request #10127: [0.14 backport] Mining: Prevent slowdown in CreateNewBlock on large mempools (0.14...2017-03-backport-cnb-optimizations) https://github.com/bitcoin/bitcoin/pull/10127
< bitcoin-git> [bitcoin] laanwj closed pull request #10126: Compensate for memory peak at flush time (master...peak_compensation) https://github.com/bitcoin/bitcoin/pull/10126
< bitcoin-git> bitcoin/master 9ab26bf Wladimir J. van der Laan: Merge #10126: Compensate for memory peak at flush time...
< bitcoin-git> bitcoin/master 7228ce8 Pieter Wuille: Compensate for memory peak at flush time
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ba12b3a84469...9ab26bf7e428
< bitcoin-git> bitcoin/0.14 f59e3df John Newbery: Add tests for bitcoin-tx input checking...
< bitcoin-git> bitcoin/0.14 ecc5232 John Newbery: Check stderr when testing bitcoin-tx...
< bitcoin-git> bitcoin/0.14 04c21af Awemany: bitcoin-tx: Fix missing range check...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/b768202695a0...e4c9a90fe9aa
< bitcoin-git> [bitcoin] laanwj closed pull request #10120: util: Work around (virtual) memory exhaustion on 32-bit w/ glibc (master...2017_03_address_space_exhaustion_workaround) https://github.com/bitcoin/bitcoin/pull/10120
< bitcoin-git> bitcoin/master ba12b3a Wladimir J. van der Laan: Merge #10120: util: Work around (virtual) memory exhaustion on 32-bit w/ glibc...
< bitcoin-git> bitcoin/master 625488a Wladimir J. van der Laan: util: Work around (virtual) memory exhaustion on 32-bit w/ glibc...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de301b048810...ba12b3a84469
< bitcoin-git> [bitcoin] laanwj closed pull request #10130: bitcoin-tx input verification (awemany, jnewbery) (master...bitcoin_tx_input_sanitiser) https://github.com/bitcoin/bitcoin/pull/10130
< bitcoin-git> bitcoin/master 19ecd1e John Newbery: Add tests for bitcoin-tx input checking
< bitcoin-git> bitcoin/master 21704f6 John Newbery: Check stderr when testing bitcoin-tx
< bitcoin-git> bitcoin/master eb66bf9 Awemany: bitcoin-tx: Fix missing range check...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e4f7e72410d...de301b048810
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10090: Update bitcoin.conf with example for pruning (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10090
< bitcoin-git> bitcoin/master 8e4f7e7 MarcoFalke: Merge #10090: Update bitcoin.conf with example for pruning...
< bitcoin-git> bitcoin/master c0651cc Kyle Honeycutt: Update bitcoin.conf with example for pruning...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc62c959ab3...8e4f7e72410d

2017-03-30

< bitcoin-git> [bitcoin] fanquake closed pull request #10106: bitcoin-tx: Fix missing range check (master...bitcointx-addoutaddr) https://github.com/bitcoin/bitcoin/pull/10106
< bitcoin-git> [bitcoin] jnewbery opened pull request #10130: bitcoin-tx input verification (master...bitcoin_tx_input_sanitiser) https://github.com/bitcoin/bitcoin/pull/10130
< bitcoin-git> [bitcoin] gmaxwell reopened pull request #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings. (master...log_category_simplify) https://github.com/bitcoin/bitcoin/pull/9424
< bitcoin-git> [bitcoin] theuni opened pull request #10129: scheduler: fix sub-second precision with boost < 1.50 (master...fix-scheduler-millisecs) https://github.com/bitcoin/bitcoin/pull/10129
< gmaxwell> Or we take a whole different approach to failure messages, .e.g. wrap bitcoin-qt in another program that when qt exists it can go through the logs and give you a useful error. (though this doesn't answer morcos' wallet flush, but really that should be in another process.)
< gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9208 | Improve DisconnectTip performance by sdaftuar · Pull Request #9208 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9208 | Improve DisconnectTip performance by sdaftuar · Pull Request #9208 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9208 | Improve DisconnectTip performance by sdaftuar · Pull Request #9208 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #10128: Speed Up CuckooCache tests (master...cuckoo-tests-faster) https://github.com/bitcoin/bitcoin/pull/10128
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9424 | Change LogAcceptCategory to use uint32_t rather than sets of strings. by gmaxwell · Pull Request #9424 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9208 | Improve DisconnectTip performance by sdaftuar · Pull Request #9208 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10123 | Allow debug logs to be excluded from specified component by jnewbery · Pull Request #10123 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9792 | FastRandomContext improvements and switch to ChaCha20 by sipa · Pull Request #9792 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10114: [tests] sync_with_ping should assert that ping hasn't timed out (master...improve_sync_with_ping) https://github.com/bitcoin/bitcoin/pull/10114
< bitcoin-git> bitcoin/master edc62c9 Wladimir J. van der Laan: Merge #10114: [tests] sync_with_ping should assert that ping hasn't timed out...
< bitcoin-git> bitcoin/master 6a18bb9 John Newbery: [tests] sync_with_ping should assert that ping hasn't timed out...
< bitcoin-git> bitcoin/master 6426716 John Newbery: Add send_await_disconnect() method to p2p-compactblocks.py...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cde9b1a864c1...edc62c959ab3
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10127: [0.14 backport] Mining: Prevent slowdown in CreateNewBlock on large mempools (0.14...2017-03-backport-cnb-optimizations) https://github.com/bitcoin/bitcoin/pull/10127
< gribble> https://github.com/bitcoin/bitcoin/issues/10072 | Remove sources of unreliablility in extended functional tests by jnewbery · Pull Request #10072 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10114 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< jonasschnelli> gmaxwell: https://bitcoin.jonasschnelli.ch
< gribble> https://github.com/bitcoin/bitcoin/issues/10072 | Remove sources of unreliablility in extended functional tests by jnewbery · Pull Request #10072 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10114 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9938 | Lock-Free CheckQueue by JeremyRubin · Pull Request #9938 · bitcoin/bitcoin · GitHub
< jeremyrubin> A lot of it is my fault it seems. https://github.com/bitcoin/bitcoin/pull/10099 is ready to go
< wumpus> I made an overview here: https://github.com/bitcoin/bitcoin/issues/10026 of the slowest unit tests
< bitcoin-git> [bitcoin] sipa opened pull request #10126: Compensate for memory peak at flush time (master...peak_compensation) https://github.com/bitcoin/bitcoin/pull/10126
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< gribble> https://github.com/bitcoin/bitcoin/issues/9959 | Mining: Prevent slowdown in CreateNewBlock on large mempools by sdaftuar · Pull Request #9959 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9959: Mining: Prevent slowdown in CreateNewBlock on large mempools (master...2017-03-cnb-optimizations) https://github.com/bitcoin/bitcoin/pull/9959
< bitcoin-git> bitcoin/master 011124a Suhas Daftuar: Update benchmarking with package statistics
< bitcoin-git> bitcoin/master 42cd8c8 Suhas Daftuar: Add benchmarking for CreateNewBlock
< bitcoin-git> bitcoin/master eed816a Suhas Daftuar: Mining: return early when block is almost full
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ac804128671...cde9b1a864c1
< gribble> https://github.com/bitcoin/bitcoin/issues/9959 | Mining: Prevent slowdown in CreateNewBlock on large mempools by sdaftuar · Pull Request #9959 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #9630: Add logging to GetAncestor if pindex->pprev == NULL (master...crashlogging) https://github.com/bitcoin/bitcoin/pull/9630
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10125: Exit bitcoind immediately on shutdown instead of 200ms later (master...2017-03-faster-shutdown) https://github.com/bitcoin/bitcoin/pull/10125
< bitcoin-git> [bitcoin] jnewbery opened pull request #10124: [test] Suppress test logging spam (master...suppress_test_logging_spam) https://github.com/bitcoin/bitcoin/pull/10124
< bitcoin-git> [bitcoin] jnewbery opened pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git> [bitcoin] shitakee opened pull request #10121: Add missing header file (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10121
< gribble> https://github.com/bitcoin/bitcoin/issues/10114 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< jonasschnelli> wumpus: hmmm.. assumevalid.py failed/failes on master (CRON travis): https://travis-ci.org/bitcoin/bitcoin/jobs/216360061#L5396
< gribble> https://github.com/bitcoin/bitcoin/issues/10120 | util: Work around (virtual) memory exhaustion on 32-bit w/ glibc by laanwj · Pull Request #10120 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9464 | [GUI] No GUI updates when running with --reindex or --reindex-chainstate · Issue #9464 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #10120: util: Work around (virtual) memory exhaustion on 32-bit w/ glibc (master...2017_03_address_space_exhaustion_workaround) https://github.com/bitcoin/bitcoin/pull/10120
< bitcoin-git> [bitcoin] fanquake closed pull request #10089: Fix shadowing of 'what' as described in #10080. (master...fix-what-shadowing) https://github.com/bitcoin/bitcoin/pull/10089
< gribble> https://github.com/bitcoin/bitcoin/issues/9464 | [GUI] No GUI updates when running with --reindex or --reindex-chainstate · Issue #9464 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10109: Remove SingleNodeConnCB (master...remove_single_node_conn_cb) https://github.com/bitcoin/bitcoin/pull/10109
< bitcoin-git> bitcoin/master 8ac8041 MarcoFalke: Merge #10109: Remove SingleNodeConnCB...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f34cdcbd806d...8ac804128671
< bitcoin-git> bitcoin/master 159fe88 John Newbery: Remove SingleNodeConnCB...
< bitcoin-git> [bitcoin] jtimon opened pull request #10119: Util: Remove ArgsManager wrappers: (master...0.14-args-wrappers) https://github.com/bitcoin/bitcoin/pull/10119
< jonasschnelli> BlueMatt: I can't follow your comment: https://github.com/bitcoin/bitcoin/pull/9681/files#r108679775 ... can you elaborate?
< bitcoin-git> [bitcoin] tjps closed pull request #10059: [trivial] Removed one Boost usage and headers in util.cpp (master...tjps_boost) https://github.com/bitcoin/bitcoin/pull/10059

2017-03-29

< bitcoin-git> [bitcoin] jtimon opened pull request #10118: Util: Remove redundant calls to argsGlobal.IsArgSet() (master...0.14-args-class2) https://github.com/bitcoin/bitcoin/pull/10118
< bitcoin-git> [bitcoin] roconnor-blockstream closed pull request #10116: Consensus: use IsWitnessEnabled in ContextualCheckBlock (master...ContextualCheckBlock-refector) https://github.com/bitcoin/bitcoin/pull/10116
< bitcoin-git> [bitcoin] ryanofsky closed pull request #10113: Fix test_bitcoin-qt when DISPLAY is unset (master...pr/nodisp) https://github.com/bitcoin/bitcoin/pull/10113
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10117: Fix "make check" on systems with qt and libxcb but no active DISPLAY (master...pr/noqapp) https://github.com/bitcoin/bitcoin/pull/10117
< bitcoin-git> [bitcoin] sdaftuar closed pull request #9709: [WIP] Cache segwit signature hash components inside CTransactionRef to optimize validation performance (master...2017-02-segwit-cache-3) https://github.com/bitcoin/bitcoin/pull/9709
< bitcoin-git> [bitcoin] roconnor-blockstream opened pull request #10116: Consensus: use IsWitnessEnabled in ContextualCheckBlock (master...ContextualCheckBlock-refector) https://github.com/bitcoin/bitcoin/pull/10116
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10115: Avoid reading the old hd master key during wallet encryption (master...2017-03-cleanup-sethdmasterkey) https://github.com/bitcoin/bitcoin/pull/10115
< bitcoin-git> [bitcoin] jnewbery opened pull request #10114: [tests] sync_with_ping should assert that ping hasn't timed out (master...improve_sync_with_ping) https://github.com/bitcoin/bitcoin/pull/10114
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9947: Add true/false return value to prioritisetransaction (master...2017/03/ptx) https://github.com/bitcoin/bitcoin/pull/9947
< bitcoin-git> [bitcoin] laanwj closed pull request #9294: Use internal HD chain for change outputs (hd split) (master...2016/12/hd_split) https://github.com/bitcoin/bitcoin/pull/9294
< bitcoin-git> bitcoin/master 01de822 Jonas Schnelli: Removed redundant IsLocked() check in NewKeyPool()
< bitcoin-git> bitcoin/master d59531d Jonas Schnelli: Immediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported
< bitcoin-git> bitcoin/master 02592f4 Jonas Schnelli: [Wallet] split the keypool in an internal and external part
< bitcoin-git> [bitcoin] laanwj pushed 24 new commits to master: https://github.com/bitcoin/bitcoin/compare/f2734c2828f6...f34cdcbd806d
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10107: Remove unused variable. Remove accidental trailing semicolons in Python code (master...recent-python-style-regressions) https://github.com/bitcoin/bitcoin/pull/10107
< bitcoin-git> bitcoin/master f2734c2 MarcoFalke: Merge #10107: Remove unused variable. Remove accidental trailing semicolons in Python code...
< bitcoin-git> bitcoin/master 85de9d4 practicalswift: Remove call to gettransaction(...) where the result is unused
< bitcoin-git> bitcoin/master bd02422 practicalswift: Remove accidental trailing semicolons in Python code
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9692be4a9a9b...f2734c2828f6
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP) by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.14 e9611d1 Cory Fields: depends: fix zlib build on osx...
< bitcoin-git> bitcoin/0.14 ddc2dd1 Andrew Chow: Ensure an item exists on the rpcconsole stack before adding...
< bitcoin-git> bitcoin/0.14 4d8e660 James Evans: Trivial: Fix typo in help getrawtransaction RPC...
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/37bf0d5b381f...b768202695a0
< bitcoin-git> bitcoin/master 9692be4 Wladimir J. van der Laan: Merge #10084: rpc: Rename first named arg of createrawtransaction...
< bitcoin-git> [bitcoin] laanwj closed pull request #10084: rpc: Rename first named arg of createrawtransaction (master...Mf1703-createRawName) https://github.com/bitcoin/bitcoin/pull/10084
< bitcoin-git> bitcoin/master fa55853 MarcoFalke: rpc: Rename first named arg of createrawtransaction
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4bd0e9b90a39...9692be4a9a9b
< bitcoin-git> [bitcoin] sipa closed pull request #10088: Trivial: move several relay options into the relay help group (master...relayoptions) https://github.com/bitcoin/bitcoin/pull/10088
< bitcoin-git> bitcoin/master 4bd0e9b Pieter Wuille: Merge #10088: Trivial: move several relay options into the relay help group...
< bitcoin-git> bitcoin/master 0fb2887 Jameson Lopp: Move several relay options into the Relay help group
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7438ceac716f...4bd0e9b90a39
< bitcoin-git> [bitcoin] sipa closed pull request #10086: Trivial: move rpcserialversion into RPC option group (master...rpcserialversion) https://github.com/bitcoin/bitcoin/pull/10086
< bitcoin-git> bitcoin/master 7438cea Pieter Wuille: Merge #10086: Trivial: move rpcserialversion into RPC option group...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e3efd47e0d5...7438ceac716f
< bitcoin-git> bitcoin/master 1403b1a Jameson Lopp: move rpcserialversion into RPC option group
< bitcoin-git> [bitcoin] sipa closed pull request #10108: ApproximateBestSubset should take inputs by reference, not value (master...trivial) https://github.com/bitcoin/bitcoin/pull/10108
< bitcoin-git> bitcoin/master 4e3efd4 Pieter Wuille: Merge #10108: ApproximateBestSubset should take inputs by reference, not value...
< bitcoin-git> bitcoin/master 5335132 Ryan Havar: ApproximateBestSubset should take inputs by reference, not value
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0b9fb682890b...4e3efd47e0d5

2017-03-28

< bitcoin-git> [bitcoin] ryanofsky opened pull request #10113: Fix test_bitcoin-qt when DISPLAY is unset (master...pr/nodisp) https://github.com/bitcoin/bitcoin/pull/10113
< bitcoin-git> [bitcoin] jnewbery opened pull request #10111: Remove NetworkThread from individual test cases (master...remove_network_thread_from_test_scripts) https://github.com/bitcoin/bitcoin/pull/10111
< gribble> https://github.com/bitcoin/bitcoin/issues/10017 | combine_logs.py - aggregates log files from multiple bitcoinds during functional tests. by jnewbery · Pull Request #10017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10109: Remove SingleNodeConnCB (master...remove_single_node_conn_cb) https://github.com/bitcoin/bitcoin/pull/10109
< bitcoin-git> [bitcoin] RHavar opened pull request #10108: ApproximateBestSubset should take inputs by reference, not value (master...trivial) https://github.com/bitcoin/bitcoin/pull/10108
< sipa> bsm117532: my vps provider claims it was running a bitcoin miner and turned it off
< bsm117532> bitcoin.sipa.be appears to be down. I can't check my daily segwit activation stats!
< gmaxwell> this keeps the implementation of whatever weird interface you want to use outside of bitcoin.
< spudowiar> Doesn't Bitcoin Core use Protocol Buffers for payment requests?
< spudowiar> e.g. Core starts `bitcoin-trezor-signd`, communicates over IPC
< TD-Linux> I think it'd actually be really neat if bitcoin core supported hw wallets out of the box
< spudowiar> We could have something like bitcoin-trezor-signd
< spudowiar> I want a separate process (I don't want any hardware wallet stuff in Bitcoin Core)
< TD-Linux> there was a previous BIP proposal for a URL-style communication for hw wallets: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-August/013008.html
< spudowiar> Does Bitcoin Core use any IPC?
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< bitcoin-git> [bitcoin] practicalswift opened pull request #10107: Remove unused variable. Fix accidental trailing semicolons in Python code (master...recent-python-style-regressions) https://github.com/bitcoin/bitcoin/pull/10107
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10105: [tests] fixup - make all Travis test runs quiet, non just cron job runs (master...fixup_travis_logging) https://github.com/bitcoin/bitcoin/pull/10105
< bitcoin-git> bitcoin/master 0b9fb68 MarcoFalke: Merge #10105: [tests] fixup - make all Travis test runs quiet, non just cron job runs...
< bitcoin-git> bitcoin/master 91f1f19 John Newbery: Make all Travis test runs quiet, non just cron job runs
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b029aaedb5f...0b9fb682890b
< bitcoin-git> [bitcoin] awemany opened pull request #10106: bitcoin-tx: Fix missing range check (master...bitcointx-addoutaddr) https://github.com/bitcoin/bitcoin/pull/10106
< bitcoin-git> [bitcoin] jnewbery opened pull request #10105: [tests] fixup - make all Travis test runs quiet, non just cron job runs (master...fixup_travis_logging) https://github.com/bitcoin/bitcoin/pull/10105