< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
< bitcoin-git>
[bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git>
[bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git>
[bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
< bitcoin-git>
[bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
< shesek>
I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them
2020-05-17
< shesek>
does bitcoin-qt not show the fee of confirmed incoming transactions (ie where the spent prevouts are no longer in the utxo set)?
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #19001: qt: bugfix unsupported QLocale languages (master...202005-bugfix-qlocale) https://github.com/bitcoin/bitcoin/pull/19001
< jonatack>
tryphe: on github projects with a small number of collaborators i think they are fun; on more widely-watched ones like bitcoin core i tend to not use them to avoid it turning into a social media or slack feed. using an emoji inside a comment, sure. worked more ideas into the doc from all three of you, thanks!
< tryphe>
when getting into bitcoin PR review i feel like there's this -almost- unscalable mountain in front of you; semi-scalable in terms of "things that i can actually review without much historical bitcoin knowlegde" (NATPMP for example, that was easy, but almost straightforward enough that it requires no comments), but also unscalable parts in terms of other PRs where the motivation was so ingenius that trying to review it almost seems like a
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18994: tests: Add fuzzing harnesses for functions in script/ (master...fuzzers-script-slash) https://github.com/bitcoin/bitcoin/pull/18994
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #18993: qt: increase console command max lenght (master...202005-increase-console-command) https://github.com/bitcoin/bitcoin/pull/18993
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #18992: qt: add sign and verify message support to AddressBookPage (master...202005-sign-message-ui) https://github.com/bitcoin/bitcoin/pull/18992
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18990: log: Properly log txs rejected from mempool (master...2005-logMempoolRej) https://github.com/bitcoin/bitcoin/pull/18990
< bitcoin-git>
[bitcoin] ariard opened pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
< bitcoin-git>
[bitcoin] ariard opened pull request #18987: RFC: Introducing Watchdog, a cross-layer anomaly detection module (master...2020-05-rfc-watchdog) https://github.com/bitcoin/bitcoin/pull/18987
< bitcoin-git>
[bitcoin] rajarshimaitra opened pull request #18986: Adds a new --notimeout flag in test_framework. (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< bitcoin-git>
[bitcoin] kallewoof closed pull request #18981: doc: add note about considering making issues over TODO source code comments (master...202005-no-todo) https://github.com/bitcoin/bitcoin/pull/18981
< bitcoin-git>
[bitcoin] jb55 opened pull request #18985: bloom: use Span instead of std::vector for `insert` and `contains` [ZAP3] (master...2020-05-bloom-span) https://github.com/bitcoin/bitcoin/pull/18985
< jonatack>
I wonder if it would make any sense to bring bitcoinacks, with pierre_rochard's permission of course, into https://github.com/bitcoin-core/ to see more attention
< bitcoin-git>
[bitcoin] tarboss closed pull request #18961: gui: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
< gribble>
https://github.com/bitcoin/bitcoin/issues/18413 | script: prevent UB when computing abs value for num opcode serialize by pierreN · Pull Request #18413 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake merged pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git>
bitcoin/master e2f6866 fanquake: Merge #18975: test: Remove const to work around compiler error on xenial
< bitcoin-git>
bitcoin/master 050e2ee Wladimir J. van der Laan: test: Remove const to work around compiler error on xenial
< MarcoFalke>
And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
< wumpus>
luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
< bitcoin-git>
bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] tarboss opened pull request #18961: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
< jb55>
let's say I send a tx to a tor peer, they would have some custom code that correlates encrypted bitcoin-p2p traffic with transactions coming out of exit nodes somehow?
< bitcoin-git>
[bitcoin] laanwj merged pull request #18945: build: Ensure source tarball has leading directory name (0.20) (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
< bitcoin-git>
[bitcoin] dongcarl opened pull request #18958: guix: Make V=1 more powerful for debugging (master...2020-05-guix-improvements) https://github.com/bitcoin/bitcoin/pull/18958
< bitcoin-git>
[bitcoin] fanquake merged pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git>
bitcoin/master ad1b7b1 fanquake: Merge #18957: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git>
bitcoin/master d97fac4 Damian Mee: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git>
[bitcoin] fanquake merged pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git>
bitcoin/master 49d237c fanquake: Merge #18928: build: don't pass -w when building for Windows
< bitcoin-git>
bitcoin/master 89fea68 fanquake: build: don't pass -w when building for Windows
< bitcoin-git>
[bitcoin] meeDamian opened pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git>
[bitcoin] fanquake opened pull request #18956: build: enforce minumim required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git>
[bitcoin] andrewtoth reopened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git>
[bitcoin] jnewbery closed pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955
< bitcoin-git>
[bitcoin] fanquake merged pull request #18808: [net processing] Drop unknown types in getdata (master...2020-04-getdata) https://github.com/bitcoin/bitcoin/pull/18808
< bitcoin-git>
bitcoin/master 2f03255 Amiti Uttarwar: [test] test that an invalid GETDATA doesn't prevent processing of future m...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955
2020-05-11
< bitcoin-git>
[bitcoin] andrewtoth closed pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< amiti>
I’m learning a lot and I appreciate your patience with me along the way. Its an honor to work with you all on bitcoin core <3
< amiti>
I feel deeply grateful to get to work on bitcoin core on a daily basis. I 100% do not think I would be here if it weren’t for the many of you who have believed in me & taught me so much, even when I doubt myself. I’ve found the bitcoin core community to be welcoming & supportive, and I wish to share that with others who feel intimidated but interested
< bitcoin-git>
[bitcoin] hebasto opened pull request #18948: qt: Do not call setParent() for WalletModel instances (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
< wumpus>
thanks for weighing in; I think having contributed *something* is good before starting to review, unless you can somehow start reviewing at a deep technical level without having written any code for bitcoin core (e.g. contributor to a similar or adjacent project), but that's rare