2019-02-14

< wumpus> there's still quite a few PRs open on the 0.18 milestone https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0 though not all are features of course
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b1c7a9d6ae...9b1df4ba0bec
< bitcoin-git> bitcoin/master 4a43eb8 Sjors Provoost: [build] Makefile.am: add rule for src/bitcoin-wallet
< bitcoin-git> bitcoin/master 9b1df4b MarcoFalke: Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15408: Remove unused TransactionError constants (master...Mf1902-TransactionErrorConst) https://github.com/bitcoin/bitcoin/pull/15408
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38989ab03fb7...e3b1c7a9d6ae
< bitcoin-git> bitcoin/master 3c6ef03 Chun Kuan Lee: msvc: Fix silent merge conflict between #13926 and #14372 part II
< bitcoin-git> bitcoin/master e3b1c7a MarcoFalke: Merge #15407: msvc: Fix silent merge conflict between #13926 and #14372 pa...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2452c6cc0a23...38989ab03fb7
< bitcoin-git> bitcoin/master 8c3fdd3 marcoagner: fixes m_assumed_blockchain_size variables values:
< bitcoin-git> bitcoin/master 38989ab MarcoFalke: Merge #15183: [Qt]: fixes m_assumed_blockchain_size variable value
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< bitcoin-git> [bitcoin] marcuswin opened pull request #15406: Update links (master...master) https://github.com/bitcoin/bitcoin/pull/15406
< provoostenator> Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
< gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9c93f5d9fc93...2452c6cc0a23
< bitcoin-git> bitcoin/master 162ffef Glenn Willen: Add pf_invalid arg to std::string DecodeBase{32,64}
< bitcoin-git> bitcoin/master c734aaa Glenn Willen: Split DecodePSBT into Base64 and Raw versions
< bitcoin-git> bitcoin/master 81cd958 Glenn Willen: Factor BroadcastTransaction out of sendrawtransaction
< provoostenator> "bitcoin-wallet.exe : fatal error LNK1120: 14 unresolved externals"
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15404: [test] Remove -txindex to start nodes (master...remove_txindex) https://github.com/bitcoin/bitcoin/pull/15404
< bitcoin-git> [bitcoin] sipa opened pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub

2019-02-13

< mave> under .config/Bitcoin/Bitcoin-QT.conf
< luke-jr> sipa: assuming you mean ~/.config/Bitcoin/Bitcoin-Qt.conf , he said he already checked it
< sipa> bitcoin-qt has its own config, but i don't know the details
< mave> there is no qt-config that I am aware of aside from bitcoin.conf
< jarthur> Alright, how are you opening Bitcoin-Qt, and are you passing it that conf file at the command line?
< mave> nope, I'm running it from shell just using the command bitcoin-qt, no params
< mave> so, the debug.log says it's using as default data dir /home/roge/.bitcoin which is empty on purpose
< mave> and on the next debug.log line it says it's using as datadir /disco-dos/bitcoin-data/testnet3 which is correct
< mave> 2019-02-13 23:34:57 Default data directory /home/roge/.bitcoin
< mave> 2019-02-13 23:34:57 Using data directory /disco-dos/bitcoin-data/testnet3
< mave> 2019-02-13 23:34:57 Using config file /disco-dos/bitcoin-data/bitcoin.conf
< mave> it says it's using /home/roge/.bitcoin as default data dir
< mave> 2019-02-13 23:34:57 Bitcoin Core version v0.16.0 (release build)
< jarthur> So it says "Using data directory /disco-dos/bitcoin-data/" shortly after that?
< mave> 2019-02-13 23:34:57 Bitcoin Core version v0.16.0 (release build) 2019-02-13 23:34:57 InitParameterInteraction: parameter interaction: -whitelistforcerelay=1 -> setting -whitelistrelay=1 2019-02-13 23:34:57 Assuming ancestors of block 0000000002e9e7b00e1f6dc5123a04aad68dd0f0968d8c7aa45f6640795c37b1 have valid signatures. 2019-02-13 23:34:57 Setting nMinimumChainWork=00000000000000000000000000000000000000000000002
< mave> which is my $HOME/.bitcoin
< mave> Default data directory /home/roge/.bitcoin
< mave> I now understand that bitcoin-qt has some other set of config files under $HOME/.config/Bitcoin
< luke-jr> well, if $HOME/.bitcoin is your datadir ;)
< mave> but I don't when starting bitcoin-qt
< mave> hence my surprise to see that bitcoin-qt could find my datadir
< mave> I thought it would read from $HOME/.bitcoin/bitcoin.conf
< mave> the one that's surprising me is bitcoin-qt
< luke-jr> cat ~/.config/Bitcoin/Bitcoin-Qt.conf
< mave> for this use case it's bitcoin-qt
< mave> yes, it is finding everything correctly (which is unexpected as I deleted $HOME/.bitcoin on purpose)
< luke-jr> mave: bitcoind or bitcoin-qt?
< mave> I'm not telling it and it's finding my /disco-dos/bitcoin-data/ directory :o
< mave> I just start it up with bitcoin-qt
< mave> with an empty $HOME/.bitcoin
< mave> noob question, I've deleted $HOME/.bitcoin/, how does bitcoin-qt know where to find my other datadir correctly? (it does to my surprise)
< mryandao> or it creates a new $HOME/.bitcoin/
< jarthur> Empact: re the runtime \n embedding, should this literal now be a raw-string or escaped slash?: https://github.com/bitcoin/bitcoin/pull/15257/files#diff-dc87c4c96fc5f98c3734a2c16504eb30R88 I only ask since it replaced ones you had changed to be raw in earlier version of the PR.
< gribble> https://github.com/bitcoin/bitcoin/issues/15257 | Scripts and tools: Bump flake8 to 3.6.0 by Empact · Pull Request #15257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c4a90040dd3...9c93f5d9fc93
< bitcoin-git> bitcoin/master a4b92e4 Hennadii Stepanov: Log full paths for wallets
< bitcoin-git> bitcoin/master 9c93f5d Wladimir J. van der Laan: Merge #15334: wallet: Log absolute paths for the wallets
< bitcoin-git> [bitcoin] laanwj merged pull request #15334: wallet: Log absolute paths for the wallets (master...20190203-wallet-env-log) https://github.com/bitcoin/bitcoin/pull/15334
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15401: rpc: Actually throw help when passed invalid number of params (master...Mf1902-rpcNumArgs) https://github.com/bitcoin/bitcoin/pull/15401
< gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15400 | p2p_invalid_messages test can fail in runner due to stderr text when socket write buffer flushed · Issue #15400 · bitcoin/bitcoin · GitHub
< x4b1d> Fair, I wish that I could break the offline functions into a seperate set of libs provided by bitcoin core but yeah more ot
< wumpus> yea #bitcoin is better for questions like this as they don't involve bitcoin core development
< sipa> #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cbe7efe9ea6c...9c4a90040dd3
< bitcoin-git> bitcoin/master 318b1f7 John Newbery: [wallet] Close bdb when flushing wallet.
< bitcoin-git> bitcoin/master 9c4a900 MarcoFalke: Merge #15390: [wallet-tool] Close bdb when flushing wallet
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15390: [wallet-tool] Close bdb when flushing wallet (master...wallet_flush) https://github.com/bitcoin/bitcoin/pull/15390
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15399: fuzz: Script validation flags (master...Mf1902-fuzzSoft) https://github.com/bitcoin/bitcoin/pull/15399
< gribble> https://github.com/bitcoin/bitcoin/issues/14241 | appveyor: script improvement by ken2812221 · Pull Request #14241 · bitcoin/bitcoin · GitHub
< provoostenator> Travis is happy, but AppVeyor seems to need additional magic to find boost::process : https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/22347238
< gribble> https://github.com/bitcoin/bitcoin/issues/15250 | Use RdSeed when available, and reduce RdRand load by sipa · Pull Request #15250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13129 | Meta-issue: Add Clang thread safety analysis annotations · Issue #13129 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13103 | Invalid wallet path with Chinese characters in windows · Issue #13103 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15398: msvc: add rapid check property tests (master...appveyor-rapid-check) https://github.com/bitcoin/bitcoin/pull/15398
< gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15393 | build: Bump minimum Qt version to 5.5.1 by Sjors · Pull Request #15393 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15389: Remove unnecessary const_cast (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15389
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d1160e42185...cbe7efe9ea6c
< bitcoin-git> bitcoin/master 5039e4b Julian Fleischer: Remove unnecessary const_cast
< bitcoin-git> bitcoin/master cbe7efe Wladimir J. van der Laan: Merge #15389: Remove unnecessary const_cast
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
< gmaxwell> (consider the recently published rpc cve in bitcoin that we basically cannot fix...)
< wumpus> so rust implementation of bitcoin core when?
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] instagibbs opened pull request #15397: Remove manual byte editing in wallet_tx_clone func test (master...wallet_clone_magic) https://github.com/bitcoin/bitcoin/pull/15397
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15395: test: Remove TODO comments to remove -txindex option (master...Mf1902-qaNoTodo) https://github.com/bitcoin/bitcoin/pull/15395
< gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] yunchiri opened pull request #15396: Update build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15396
< sipa> (and probably more on topic in #bitcoin-wizards)
< booyah_> why bitcoin uses ECDSA on secp256k1 instead of Ed25519, any arguments for/against?

2019-02-12

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14918: RPCHelpMan: Check default values are given at compile-time (master...Mf1812-rpcOptionalCompile) https://github.com/bitcoin/bitcoin/pull/14918
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/029d28a7aa56...0d1160e42185
< bitcoin-git> bitcoin/master fa0ad4e MarcoFalke: RPCHelpMan: Check default values are given at compile-time
< bitcoin-git> bitcoin/master 0d1160e MarcoFalke: Merge #14918: RPCHelpMan: Check default values are given at compile-time
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15395: test: Remove TODO comments to remove -txindex option (master...Mf1902-qaNoTodo) https://github.com/bitcoin/bitcoin/pull/15395
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d73918447faf...029d28a7aa56
< bitcoin-git> bitcoin/master 1e7f741 Gregory Sanders: remove some magic mining constants in functional tests
< bitcoin-git> bitcoin/master b651ef7 Gregory Sanders: submitheader: more directly test missing prev block header
< bitcoin-git> bitcoin/master 029d28a MarcoFalke: Merge #15238: [QA] remove some magic mining constants in functional tests
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15238: [QA] remove some magic mining constants in functional tests (master...magic_miner) https://github.com/bitcoin/bitcoin/pull/15238
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea022d9fd047...d73918447faf
< bitcoin-git> bitcoin/master 8c9b8a3 Hennadii Stepanov: Replace script name with special parameter
< bitcoin-git> bitcoin/master d739184 MarcoFalke: Merge #15216: Scripts and tools: Replace script name with a special parame...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15378: tests: Added missing tests for RPC wallet errors (master...tests_missing_tests) https://github.com/bitcoin/bitcoin/pull/15378
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d3f255316fc...ea022d9fd047
< bitcoin-git> bitcoin/master dc3b2cc Ben Carman: tests: Added missing tests for RPC wallet errors
< bitcoin-git> bitcoin/master ea022d9 MarcoFalke: Merge #15378: tests: Added missing tests for RPC wallet errors
< bitcoin-git> [bitcoin] Sjors opened pull request #15393: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
< provoostenator> gmaxwell: it was renamed from bitcoin-wallet-tool to bitcoin-wallet along the way.
< gmaxwell> FWIW, I actually misread PRs related to the wallet tool and thought it was named bitcoin-wallet-tool
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< jnewbery> so for now, keep the wallet tool as bitcoin-wallet, and when the separated bitcoin-wallet happens the tool commands will continue to work as expected?
< jnewbery> That seems like a reasonable suggestion to me. Merge wallet tool functionality into the new new bitcoin-wallet when it happens
< ryanofsky> i was just thinking that you have one binary called bitcoin-wallet that you use for all wallet stuff
< ryanofsky> not sure what advantage there would be to having separate bitcoin-wallet and bitcoin-wallet-tool binaries
< provoostenator> Ironically bitcoin-wallet was ryanofsky's idea in that comment :-)
< provoostenator> So wallet-tool makes sense for this tool. Or even offline-wallet or something. The live wallet in a split code base, which connects to a node, could then be called bitcoin-wallet.
< provoostenator> luke-jr in #10102 that new binary is called bitcoin-wallet
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< jnewbery> Was changed from bitcoin-wallet-tool after discussion here: https://github.com/bitcoin/bitcoin/pull/13926#issuecomment-423326338
< provoostenator> luke-jr jnewbery: I was thoroughly confused by this naming today while debugging the Makefile, because that actualy contains "bitcoin-wallet" as an intermediate stage for the wallet itself.
< luke-jr> has there been any discussion previously about the binary name for bitcoin-wallet? seems strange to me.
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15153: gui: Add Open Wallet menu (master...2019-01-openwallet) https://github.com/bitcoin/bitcoin/pull/15153
< bitcoin-git> [bitcoin] jonasschnelli pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/d8794a78a887...7d3f255316fc
< bitcoin-git> bitcoin/master 17abc0f João Barbosa: wallet: Factor out LoadWallet
< bitcoin-git> bitcoin/master ab288b4 João Barbosa: interfaces: Add loadWallet to Node
< bitcoin-git> bitcoin/master 32a8c6a João Barbosa: gui: Add openWallet and getWalletsAvailableToOpen to WalletController
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
< bitcoin-git> [bitcoin] jnewbery opened pull request #15390: [wallet] Close bdb when flushing wallet. (master...wallet_flush) https://github.com/bitcoin/bitcoin/pull/15390
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] scravy opened pull request #15389: Remove unnecessary const_cast (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15389
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03732f8644a4...d8794a78a887
< bitcoin-git> bitcoin/master ae892ad Chun Kuan Lee: tests: accept unicode characters on Windows
< bitcoin-git> bitcoin/master 15b3103 Chun Kuan Lee: appveyor: Remove outdated libraries
< bitcoin-git> bitcoin/master d8794a7 MarcoFalke: Merge #13787: Test for Windows encoding issue
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #13787: Test for Windows encoding issue (master...test_u8path) https://github.com/bitcoin/bitcoin/pull/13787
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
< gribble> https://github.com/bitcoin/bitcoin/issues/11491 | [gui] Add proxy icon in statusbar by mess110 · Pull Request #11491 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65435701efda...03732f8644a4
< bitcoin-git> bitcoin/master 1cdb9bb Gregory Sanders: minor p2p_sendheaders fix of height in coinbase
< bitcoin-git> bitcoin/master 03732f8 MarcoFalke: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
< bitcoin-git> [bitcoin] Sjors opened pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< wumpus> I don't get why this code does (Network)1 (Network)2 instead of directly using the NET_* constants: https://github.com/bitcoin/bitcoin/blob/master/src/qt/clientmodel.cpp#L279
< provoostenator> luke-jr: how so? "bin_PROGRAMS += bitcoin-tx" is in src/Makefile.am too
< provoostenator> Any idea why "make src/bitcoin-tx" works, but "make src/bitcoin-wallet" returns "No rule to make target"?
< bitcoin-git> [bitcoin] laanwj merged pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bc149d05b09...65435701efda
< bitcoin-git> bitcoin/master a99999c MarcoFalke: util: Add SetupHelpOptions()
< bitcoin-git> bitcoin/master 6543570 Wladimir J. van der Laan: Merge #15358: util: Add SetupHelpOptions()
< bitcoin-git> [bitcoin] laanwj closed pull request #15155: test: Support -cli tests using external bitcoin-cli (master...test_external_bcli) https://github.com/bitcoin/bitcoin/pull/15155
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Csi18nAlistairMann opened pull request #15387: docs: add "sections" info to example bitcoin.conf (master...confSections) https://github.com/bitcoin/bitcoin/pull/15387
< bitcoin-git> [bitcoin] ken2812221 closed pull request #15376: appveyor: ignore functional test failure (master...appveyor-ignore-functional-tests) https://github.com/bitcoin/bitcoin/pull/15376

2019-02-11

< bitcoin-git> [bitcoin] Csi18nAlistairMann closed pull request #15374: docs: add "sections" info to example bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15374
< bitcoin-git> [bitcoin] practicalswift closed pull request #14479: serialization: Don't invoke undefined behaviour when doing type punning (master...serialization-ub) https://github.com/bitcoin/bitcoin/pull/14479
< bitcoin-git> [bitcoin] practicalswift closed pull request #15262: build: Enable C++14 in build, require C++14 compiler. (master...c++14) https://github.com/bitcoin/bitcoin/pull/15262
< bitcoin-git> [bitcoin] macgeek30 closed pull request #15385: Removed unnecessary commas in README.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15385
< bitcoin-git> [bitcoin] macgeek30 opened pull request #15385: Removed unnecessary commas in README.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15385
< bitcoin-git> [bitcoin] practicalswift closed pull request #14239: Avoid dividing by zero in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet) (master...undefined-behaviour-division-by-zero) https://github.com/bitcoin/bitcoin/pull/14239
< bitcoin-git> [bitcoin] macgeek30 closed pull request #15384: Removed unnecessary commas in a compound predicate. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15384
< bitcoin-git> [bitcoin] macgeek30 opened pull request #15384: Removed unnecessary commas in a compound predicate. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15384
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336
< bitcoin-git> [bitcoin] Empact closed pull request #15377: build: Disallow shadowing variables via -isystem, -Wshadow (master...wshadow) https://github.com/bitcoin/bitcoin/pull/15377
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15383: [rpc] mining: Report -1 for uninitialized currentblockweight and currentblocktx (master...Mf1902-rpcMining) https://github.com/bitcoin/bitcoin/pull/15383
< bitcoin-git> [bitcoin] Sjors opened pull request #15382: WIP [util] add runCommandParseJSON (master...2019/02/runCommandParseJSON) https://github.com/bitcoin/bitcoin/pull/15382
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15353: docs: Minor textual improvements in translation_strings_policy.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15353
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad039aa0d3e8...1bc149d05b09
< bitcoin-git> bitcoin/master a94e470 Martin Erlandsson: A few textual improvements
< bitcoin-git> bitcoin/master 1bc149d MarcoFalke: Merge #15353: docs: Minor textual improvements in translation_strings_poli...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff9e197212eb...ad039aa0d3e8
< bitcoin-git> bitcoin/master 50e6472 Russell Yanofsky: Move ParseConfirmTarget from rpc/mining to rpc/util
< bitcoin-git> bitcoin/master ad039aa MarcoFalke: Merge #15373: Move ParseConfirmTarget from rpc/mining to rpc/util
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15380: trivial: correct parameter name in comments (master...fix-comment) https://github.com/bitcoin/bitcoin/pull/15380
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4e0d154256...e84e0d4b5e1f
< bitcoin-git> bitcoin/master 30d0f7b benthecarman: rpc: Fix for segfault if combinepsbt called with empty inputs
< bitcoin-git> bitcoin/master e84e0d4 MarcoFalke: Merge #15337: rpc: Fix for segfault if combinepsbt called with empty input...
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] domob1812 opened pull request #15381: Optionally return HTTP_OK for RPC errors (master...httprpc-error-code) https://github.com/bitcoin/bitcoin/pull/15381
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub

2019-02-10

< bitcoin-git> [bitcoin] andrewtoth opened pull request #15380: trivial: correct parameter name in comments (master...fix-comment) https://github.com/bitcoin/bitcoin/pull/15380
< anon7485> I was reading here https://bitcoin.org/en/developer-reference
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15226: Allow creating blank (empty) wallets (alternative) (master...blank-wallets) https://github.com/bitcoin/bitcoin/pull/15226
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/294549242493...6f4e0d154256
< bitcoin-git> bitcoin/master 7687f78 Andrew Chow: [wallet] Support creating a blank wallet
< bitcoin-git> bitcoin/master 6f4e0d1 MeshCollider: Merge #15226: Allow creating blank (empty) wallets (alternative)
< gribble> https://github.com/bitcoin/bitcoin/issues/14239 | Avoid dividing by zero (undefined behaviour) in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet) by practicalswift · Pull Request #14239 · bitcoin/bitcoin · GitHub
< booyah> zndtoshi: it is best to ask in #bitcoin for usage questoins
< zndtoshi> Hello. I connect to bitcoin network over Tor. Can someone please tell me how I can change the onion address of my bitcoin core?
< mryandao> hello, i've stumbled upon a threading exception with bitcoind and the program crashed. The exception message is "invalid argument in bitcoin scheduler"
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] benthecarman opened pull request #15378: tests: Added missing tests for RPC wallet errors (master...tests_missing_tests) https://github.com/bitcoin/bitcoin/pull/15378

2019-02-09

< bitcoin-git> [bitcoin] fanquake closed pull request #15375: Better to read (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15375
< bitcoin-git> [bitcoin] Empact opened pull request #15377: Disallow shadowing variables via -isystem, -Wshadow (master...wshadow) https://github.com/bitcoin/bitcoin/pull/15377
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15376: appveyor: ignore functional test failure (master...appveyor-ignore-functional-tests) https://github.com/bitcoin/bitcoin/pull/15376
< bitcoin-git> [bitcoin] lucaslopes opened pull request #15375: Better to read (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15375
< bitcoin-git> [bitcoin] Csi18nAlistairMann opened pull request #15374: Trivial: conf file changes involving sections (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15374

2019-02-08

< bitcoin-git> [bitcoin] ryanofsky opened pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373
< gribble> https://github.com/bitcoin/bitcoin/issues/15341 | rpc: Support specifying change address in bumpfee by promag · Pull Request #15341 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar closed pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5dbb45bdf7d...294549242493
< bitcoin-git> bitcoin/master dfbf117 Jordan Baczuk: Move maxTxFee initialization to init.cpp
< bitcoin-git> bitcoin/master 2945492 MarcoFalke: Merge #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...2019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1477933f289e...d5dbb45bdf7d
< bitcoin-git> bitcoin/master 9ad5ca1 David A. Harding: Release notes: integrate detached & rm backports
< bitcoin-git> bitcoin/master 5d35d43 David A. Harding: Update release notes through to cb35f1d3
< bitcoin-git> bitcoin/master d5dbb45 MarcoFalke: Merge #15314: [Doc] update release notes for changes up to cb35f1d
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15364: qa: Fix race in feature_notifications (master...Mf1902-qaNotifRace) https://github.com/bitcoin/bitcoin/pull/15364
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/020695660859...1477933f289e
< bitcoin-git> bitcoin/master faf3d22 MarcoFalke: test_runner: Remove unused --force option
< bitcoin-git> bitcoin/master fae8b8b MarcoFalke: qa: Add tool-prefix to functional test readme
< bitcoin-git> bitcoin/master 1477933 MarcoFalke: Merge #15370: test_runner: Remove unused --force option
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30495d1e756c...020695660859
< bitcoin-git> bitcoin/master faa4647 MarcoFalke: wallet: Add lock annotation for mapAddressBook
< bitcoin-git> bitcoin/master 0206956 MarcoFalke: Merge #15365: wallet: Add lock annotation for mapAddressBook
< bitcoin-git> [bitcoin] benthecarman opened pull request #15371: gui: Optimization for bech32 qr codes (master...gui_bech_32_optimized_qr_codes) https://github.com/bitcoin/bitcoin/pull/15371
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fc656a410b6...30495d1e756c
< bitcoin-git> bitcoin/master eea02be practicalswift: Add locking annotation for vNodes. vNodes is guarded by cs_vNodes.
< bitcoin-git> bitcoin/master 30495d1 MarcoFalke: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is gu...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9b26d9c3615...6fc656a410b6
< bitcoin-git> bitcoin/master d855e4c practicalswift: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an in...
< bitcoin-git> bitcoin/master 6fc656a Wladimir J. van der Laan: Merge #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0...
< bitcoin-git> [bitcoin] laanwj merged pull request #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (master...ub-in-DecodeSecret) https://github.com/bitcoin/bitcoin/pull/14242
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa merged pull request #14897: randomize GETDATA(tx) request order and introduce bias toward outbound (master...master) https://github.com/bitcoin/bitcoin/pull/14897
< bitcoin-git> [bitcoin] sipa pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9127bd7abaf8...b9b26d9c3615
< bitcoin-git> bitcoin/master 1cff3d6 Gleb Naumenko: Change in transaction pull scheduling to prevent InvBlock-related attacks
< bitcoin-git> bitcoin/master b9b26d9 Pieter Wuille: Merge #14897: randomize GETDATA(tx) request order and introduce bias towar...

2019-02-07

< bitcoin-git> [bitcoin] sipa opened pull request #15368: Descriptor checksums (master...201902_descsum) https://github.com/bitcoin/bitcoin/pull/15368
< bitcoin-git> [bitcoin] laanwj merged pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
< bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/1933e38c1a08...9127bd7abaf8
< bitcoin-git> bitcoin/master a1b25e1 John Newbery: [wallet] Refactor ProcessImport()
< bitcoin-git> bitcoin/master 4cac0dd John Newbery: [wallet] Add ProcessImportLegacy()
< bitcoin-git> bitcoin/master d2b381c John Newbery: [wallet] Refactor ProcessImport() to call ProcessImportLegacy()
< bitcoin-git> [bitcoin] benthecarman opened pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367
< benthecarman> gmaxwell: my thinking was that you don't need to add all those to your automatic startup or have to run anything extra and bitcoin core can set it up for you
< benthecarman> Hey, so I am making a PR to add an option to give the user the ability to have commands run after Bitcoin Core is finished starting up, the idea is so someone could have things like lnd or electrum-personal-server automatically run when Bitcoin Core starts. Is this something desirable to add or could it be too unsafe?
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub