< bitcoin-git>
[bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< provoostenator>
Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
< bitcoin-git>
[bitcoin] sipa opened pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< gribble>
https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
2019-02-13
< mave>
under .config/Bitcoin/Bitcoin-QT.conf
< luke-jr>
sipa: assuming you mean ~/.config/Bitcoin/Bitcoin-Qt.conf , he said he already checked it
< sipa>
bitcoin-qt has its own config, but i don't know the details
< mave>
there is no qt-config that I am aware of aside from bitcoin.conf
< jarthur>
Alright, how are you opening Bitcoin-Qt, and are you passing it that conf file at the command line?
< mave>
nope, I'm running it from shell just using the command bitcoin-qt, no params
< mave>
so, the debug.log says it's using as default data dir /home/roge/.bitcoin which is empty on purpose
< mave>
and on the next debug.log line it says it's using as datadir /disco-dos/bitcoin-data/testnet3 which is correct
< mave>
2019-02-13 23:34:57 Default data directory /home/roge/.bitcoin
< mave>
2019-02-13 23:34:57 Using data directory /disco-dos/bitcoin-data/testnet3
< mave>
2019-02-13 23:34:57 Using config file /disco-dos/bitcoin-data/bitcoin.conf
< mave>
it says it's using /home/roge/.bitcoin as default data dir
< mave>
2019-02-13 23:34:57 Bitcoin Core version v0.16.0 (release build)
< jarthur>
So it says "Using data directory /disco-dos/bitcoin-data/" shortly after that?
< bitcoin-git>
bitcoin/master a4b92e4 Hennadii Stepanov: Log full paths for wallets
< bitcoin-git>
bitcoin/master 9c93f5d Wladimir J. van der Laan: Merge #15334: wallet: Log absolute paths for the wallets
< bitcoin-git>
[bitcoin] laanwj merged pull request #15334: wallet: Log absolute paths for the wallets (master...20190203-wallet-env-log) https://github.com/bitcoin/bitcoin/pull/15334
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15401: rpc: Actually throw help when passed invalid number of params (master...Mf1902-rpcNumArgs) https://github.com/bitcoin/bitcoin/pull/15401
< gribble>
https://github.com/bitcoin/bitcoin/issues/15400 | p2p_invalid_messages test can fail in runner due to stderr text when socket write buffer flushed · Issue #15400 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
< jnewbery>
so for now, keep the wallet tool as bitcoin-wallet, and when the separated bitcoin-wallet happens the tool commands will continue to work as expected?
< jnewbery>
That seems like a reasonable suggestion to me. Merge wallet tool functionality into the new new bitcoin-wallet when it happens
< ryanofsky>
i was just thinking that you have one binary called bitcoin-wallet that you use for all wallet stuff
< ryanofsky>
not sure what advantage there would be to having separate bitcoin-wallet and bitcoin-wallet-tool binaries
< provoostenator>
Ironically bitcoin-wallet was ryanofsky's idea in that comment :-)
< provoostenator>
So wallet-tool makes sense for this tool. Or even offline-wallet or something. The live wallet in a split code base, which connects to a node, could then be called bitcoin-wallet.
< provoostenator>
luke-jr in #10102 that new binary is called bitcoin-wallet
< provoostenator>
luke-jr jnewbery: I was thoroughly confused by this naming today while debugging the Makefile, because that actualy contains "bitcoin-wallet" as an intermediate stage for the wallet itself.
< luke-jr>
has there been any discussion previously about the binary name for bitcoin-wallet? seems strange to me.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
< bitcoin-git>
[bitcoin] Csi18nAlistairMann opened pull request #15387: docs: add "sections" info to example bitcoin.conf (master...confSections) https://github.com/bitcoin/bitcoin/pull/15387
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< mryandao>
hello, i've stumbled upon a threading exception with bitcoind and the program crashed. The exception message is "invalid argument in bitcoin scheduler"
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master a1b25e1 John Newbery: [wallet] Refactor ProcessImport()
< bitcoin-git>
bitcoin/master 4cac0dd John Newbery: [wallet] Add ProcessImportLegacy()
< bitcoin-git>
bitcoin/master d2b381c John Newbery: [wallet] Refactor ProcessImport() to call ProcessImportLegacy()
< bitcoin-git>
[bitcoin] benthecarman opened pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367
< benthecarman>
gmaxwell: my thinking was that you don't need to add all those to your automatic startup or have to run anything extra and bitcoin core can set it up for you
< benthecarman>
Hey, so I am making a PR to add an option to give the user the ability to have commands run after Bitcoin Core is finished starting up, the idea is so someone could have things like lnd or electrum-personal-server automatically run when Bitcoin Core starts. Is this something desirable to add or could it be too unsafe?