2019-07-02

< bitcoin-git> [bitcoin] laanwj merged pull request #15427: Add support for descriptors to utxoupdatepsbt (master...201902_utxoupdatepsbtdesc) https://github.com/bitcoin/bitcoin/pull/15427
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c6e42f1ca9c8...2f717fb5cdfc
< bitcoin-git> bitcoin/master eaf4f88 Pieter Wuille: Abstract out IsSegWitOutput from utxoupdatepsbt
< bitcoin-git> bitcoin/master fb90ec3 Pieter Wuille: Abstract out EvalDescriptorStringOrObject from scantxoutset
< bitcoin-git> bitcoin/master 3135c1a Pieter Wuille: Abstract out UpdatePSBTOutput from FillPSBT
< bitcoin-git> [bitcoin] laanwj merged pull request #14193: validation: Add missing mempool locks (master...Mf1809-valLocksMempool) https://github.com/bitcoin/bitcoin/pull/14193
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6c21a801f3df...c6e42f1ca9c8
< bitcoin-git> bitcoin/master fa0c9db MarcoFalke: txpool: Make nTransactionsUpdated atomic
< bitcoin-git> bitcoin/master fabeb1f MarcoFalke: validation: Add missing mempool locks
< bitcoin-git> bitcoin/master fa2b083 MarcoFalke: [test] Add test to check mempool consistency in case of reorgs
< bitcoin-git> [bitcoin] promag opened pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15538: wallet_bumpfee.py: Make sure coin selection produces change (master...bumpfee_change_test) https://github.com/bitcoin/bitcoin/pull/15538
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3ccab6470a61...6c21a801f3df
< bitcoin-git> bitcoin/master 276972c Gregory Sanders: wallet_bumpfee.py: Make sure coin selection produces change
< bitcoin-git> bitcoin/master 6c21a80 Wladimir J. van der Laan: Merge #15538: wallet_bumpfee.py: Make sure coin selection produces change
< bitcoin-git> [bitcoin] laanwj merged pull request #16212: addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors (master...SerializeFileDB-non-determinism) https://github.com/bitcoin/bitcoin/pull/16212
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1212808762f6...3ccab6470a61
< bitcoin-git> bitcoin/master d975338 practicalswift: addrdb: Remove temporary files created in SerializeFileDB. Fixes non-deter...
< bitcoin-git> bitcoin/master 3ccab64 Wladimir J. van der Laan: Merge #16212: addrdb: Avoid eating inodes - remove temporary files created...

2019-07-01

< wumpus> pinheadmz: that was always the problem, I'm usually happy to help people but it was always the same discussions about bitcoin over and over again, that just wears you out
< pinheadmz> The room "#bitcoin" on "chat.freenode.net" is invite only. -- getting this message today all of a sudden, anyone else?
< gribble> https://github.com/bitcoin/bitcoin/issues/16277 | [Tests] Suppress output in test_bitcoin for expected errors by gertjaap · Pull Request #16277 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3edacb5299b...1212808762f6
< bitcoin-git> bitcoin/master 806b005 Sjors Provoost: [wallet] abort when attempting to fund a transaction above maxtxfee
< bitcoin-git> bitcoin/master 1212808 Wladimir J. van der Laan: Merge #16257: [wallet] abort when attempting to fund a transaction above -...
< bitcoin-git> [bitcoin] practicalswift opened pull request #16320: ci: Add Travis check to catch accidental introduction of non-determinism in unit tests (master...test-deterministic-coverage-in-travis) https://github.com/bitcoin/bitcoin/pull/16320
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16319: [MSVC] Simplify AppVeyor build by using user customized project file (master...msvc/appveyor-refactor) https://github.com/bitcoin/bitcoin/pull/16319
< bitcoin-git> [bitcoin] fanquake merged pull request #16309: [MSVC] allow user level project customization (master...msvc/user-build) https://github.com/bitcoin/bitcoin/pull/16309
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e9eda556717...b3edacb5299b
< bitcoin-git> bitcoin/master c83f0ac nicolas.dorier: [MSVC] allow user level project customization
< bitcoin-git> bitcoin/master b3edacb fanquake: Merge #16309: [MSVC] allow user level project customization

2019-06-30

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16271: build: remove -Wall from rapidcheck build flags (master...rapidcheck_no_wall) https://github.com/bitcoin/bitcoin/pull/16271
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7f3450b7d36...6e9eda556717
< bitcoin-git> bitcoin/master 63d0a07 fanquake: build: dont compile rapidcheck with -Wall
< bitcoin-git> bitcoin/master 6e9eda5 MarcoFalke: Merge #16271: build: remove -Wall from rapidcheck build flags
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16302: test: Add missing syncwithvalidationinterfacequeue to wallet_balance test (master...1906-testWalletBal) https://github.com/bitcoin/bitcoin/pull/16302
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd925e9b1cca...e7f3450b7d36
< bitcoin-git> bitcoin/master fa81525 MarcoFalke: test: Add missing sync_all to wallet_balance test
< bitcoin-git> bitcoin/master e7f3450 MarcoFalke: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to wallet...
< bitcoin-git> [bitcoin] promag closed pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
< bitcoin-git> [bitcoin] emilengler opened pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< phantomcircuit> it was called "Bitcoin Wallet" by ... however you spell his name
< sipa> phantomcircuit, gwillen: well... i don't think; bitcoin wallet for android started as a project when afaik literally it was the first android wallet (it may have been the first wallet software besides core entirely); i don't think in that context it was unreasonable to call it that way
< bitcoin-git> [bitcoin] fanquake merged pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04710b6d8c9e...fd925e9b1cca
< bitcoin-git> bitcoin/master 90b5c4e Jon Atack: doc: Fix broken link in doc/build-osx.md
< bitcoin-git> bitcoin/master fd925e9 fanquake: Merge #16313: doc: Fix broken link in doc/build-osx.md
< sipa> this person seems confused too: https://bitcoin.stackexchange.com/q/88716/208
< gwillen> phantomcircuit: calling it "bitcoin wallet developers" is? Yeah it's pretty dubious.
< phantomcircuit> gwillen, bitcoin wallet by bitcoin wallet developers is schilbach i think
< harding> gwillen: that email address isn't legit. I let the owner of bitcoin.org know so he could file his own report (I filed a report myself).

2019-06-29

< gwillen> luke-jr: I have no idea, that would make sense but "Bitcoin Wallet developers" is very vague so it made me suspicious. It has strong reviews though.
< gwillen> hm, the developer contact email is listed as "adminsupport@bitcoin.org"
< luke-jr> "Bitcoin Wallet" is the original Android wallet, right?
< gwillen> (this is on "Bitcoin Core - BTC Wallet")
< gwillen> midnightmagic: there is another one called "Bitcoin Wallet" by "Bitcoin Wallet developers"
< midnightmagic> er. the bitcoin core - btc wallet one I mean is just a rebranded breadwallet.
< gwillen> midnightmagic: I assume you are looking at "Bitcoin Core - BTC Wallet" by "Core Org"? (I have no idea what it is, I endorse marking it malware if nobody knows what it is.)
< bitcoin-git> [bitcoin] hebasto opened pull request #16314: scripts and tools: Update copyright_header.py script (master...20190629-copyright-headers) https://github.com/bitcoin/bitcoin/pull/16314
< bitcoin-git> [bitcoin] jonatack opened pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< bitcoin-git> [bitcoin] practicalswift opened pull request #16312: tests: Reduce compile-time memory usage by 0.5 GB when compiling script_tests.cpp (from 1.4 GB to 0.9 GB) (master...fix-absurd-memory-usage-when-compiling-script_build) https://github.com/bitcoin/bitcoin/pull/16312
< bitcoin-git> [bitcoin] practicalswift closed pull request #15814: Add tests for (or remove) untested unused methods (master...untested-unused-methods) https://github.com/bitcoin/bitcoin/pull/15814
< bitcoin-git> [bitcoin] shargon opened pull request #16310: Small optimization for IsHex method (master...master) https://github.com/bitcoin/bitcoin/pull/16310
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16309: [MSVC] allow user level project customization (master...msvc/user-build) https://github.com/bitcoin/bitcoin/pull/16309
< bitcoin-git> [bitcoin] fanquake merged pull request #15964: Docs: Improve build-osx document formatting (master...feature/update-macOS-doc) https://github.com/bitcoin/bitcoin/pull/15964
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0f309541aa6d...04710b6d8c9e
< bitcoin-git> bitcoin/master dbd137a Giulio Lombardo: Improve build-osx formatting
< bitcoin-git> bitcoin/master 04710b6 fanquake: Merge #15964: Docs: Improve build-osx document formatting
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16308: [MSVC] Copy build output to src/ automatically after build (master...build/copy-in-msbuild) https://github.com/bitcoin/bitcoin/pull/16308
< bitcoin-git> [bitcoin] fanquake merged pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/935cd6b1ec08...0f309541aa6d
< bitcoin-git> bitcoin/master e47e793 nicolas.dorier: [MSVC]: Create the config.ini as part of bitcoind build
< bitcoin-git> bitcoin/master 819c5dd nicolas.dorier: [MSVC] Enable Fuzz for functional tests
< bitcoin-git> bitcoin/master 0f30954 fanquake: Merge #16258: [MSVC]: Create the config.ini as part of bitcoind build
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub

2019-06-28

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16303: bench: Replace <wallet/crypter.h> with <keystore.h> in src/bench/ccoins_caching.cpp (master...patch/replace_crypter_include) https://github.com/bitcoin/bitcoin/pull/16303
< bitcoin-git> [bitcoin] l2a5b1 opened pull request #16303: bench: Replace <wallet/crypter.h> with <keystore.h> in src/bench/ccoins_caching.cpp (master...patch/replace_crypter_include) https://github.com/bitcoin/bitcoin/pull/16303
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16302: test: Add missing sync_all to wallet_balance test (master...1906-testWalletBal) https://github.com/bitcoin/bitcoin/pull/16302
< bitcoin-git> [bitcoin] laanwj merged pull request #16300: util: Explain why the path is cached (master...1906-utilPathWhy) https://github.com/bitcoin/bitcoin/pull/16300
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7400135b7918...935cd6b1ec08
< bitcoin-git> bitcoin/master fa69c3e MarcoFalke: util: Explain why the path is cached
< bitcoin-git> bitcoin/master 935cd6b Wladimir J. van der Laan: Merge #16300: util: Explain why the path is cached
< bitcoin-git> [bitcoin] achow101 opened pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301

2019-06-27

< bitcoin-git> [bitcoin] meshcollider closed pull request #16192: Wallet: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192
< gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16227 | Refactor CWallets inheritance chain by achow101 · Pull Request #16227 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16300: util: Explain why the path is cached (master...1906-utilPathWhy) https://github.com/bitcoin/bitcoin/pull/16300
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< gribble> https://github.com/bitcoin/bitcoin/issues/16292 | wallet_resendwallettransaction.py: fix coinbase height by instagibbs · Pull Request #16292 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16278: tests: Remove unused includes (master...cut-compilation-bloat-in-unit-tests) https://github.com/bitcoin/bitcoin/pull/16278
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3077f11dadff...7400135b7918
< bitcoin-git> bitcoin/master 9a84169 practicalswift: tests: Reduce compilation time and unneccessary recompiles by removing unu...
< bitcoin-git> bitcoin/master 7400135 MarcoFalke: Merge #16278: tests: Remove unused includes
< bitcoin-git> [bitcoin] promag opened pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git> [bitcoin] promag closed pull request #12419: Force distinct destinations in CWallet::CreateTransaction (master...2018-02-distinct-destinations) https://github.com/bitcoin/bitcoin/pull/12419
< gribble> https://github.com/bitcoin/bitcoin/issues/16027 | client 0.18.0 crashes when computer wakes up from hibernation · Issue #16027 · bitcoin/bitcoin · GitHub

2019-06-26

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b28bca04c27...3077f11dadff
< bitcoin-git> bitcoin/master f466c4c Jonas Schnelli: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp
< bitcoin-git> bitcoin/master 3077f11 MarcoFalke: Merge #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< dongcarl> sipa: The rationale here is that SHA-NI seems to be faster than SSE4/AVX2 in all cases? https://github.com/bitcoin/bitcoin/pull/13386/files#diff-cf563899256ae1ec7ee78b61806e40caR608
< dongcarl> For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly.
< gribble> https://github.com/bitcoin/bitcoin/issues/13989 | add avx512 instrinsic by fingera · Pull Request #13989 · bitcoin/bitcoin · GitHub
< MarcoFalke> E.g the arm hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550863420#L160 is 42c149c5429f559658e55580a560c8f631c5a8c8bb2db228b3b73635f0e90558
< MarcoFalke> And the win64 hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550927504#L159 is d42e27fad05b3f827b638d9dda4edcac0b86aeefd6658d03f48468bbde9b1845
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
< bitcoin-git> [bitcoin] practicalswift closed pull request #16045: Skip redundant memset(p, 0, 0) calls where p is not valid for writing (master...redundant-memsets) https://github.com/bitcoin/bitcoin/pull/16045
< jtimon> regarding https://github.com/bitcoin/bitcoin/pull/8994 I'm not sure it needs conceptual review (I'm sure there's many concept acks buried in the comments), but mostly review and re-review
< bitcoin-git> [bitcoin] instagibbs opened pull request #16292: wallet_resendwallettransaction.py: fix coinbase height (master...resend_test_height) https://github.com/bitcoin/bitcoin/pull/16292
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16287: refactor: remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca80fec973f0...1b28bca04c27
< bitcoin-git> bitcoin/master 9824a0d RJ Rybarczyk: Remove extra CBlockIndex declaration
< bitcoin-git> bitcoin/master 1b28bca MarcoFalke: Merge #16287: refactor: remove extra CBlockIndex declaration
< fanquake> If anyone is interested in some build system review. Cory has a PR open on the bitcoin-core/univalue repo: https://github.com/bitcoin-core/univalue/pull/19
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290
< bitcoin-git> [bitcoin] Bushstar opened pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #16289: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289
< bitcoin-git> [bitcoin] fanquake merged pull request #16286: refactoring: wallet: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/332c6134bb15...ca80fec973f0
< bitcoin-git> bitcoin/master d8bd97d Hennadii Stepanov: Fix GCC 7.4.0 warning
< bitcoin-git> bitcoin/master ca80fec fanquake: Merge #16286: refactoring: wallet: Fix GCC 7.4.0 warning

2019-06-25

< ossifrage> 574747 was the first UpdateTip line from the previous run of bitcoin-qt, this seems like an excessive amount of state to loose
< hebasto> Hi! Could someone point me to the adopted practice or discussion about translation of the "Bitcoin Core" brand name to other languages?
< bitcoin-git> [bitcoin] rrybarczyk opened pull request #16287: Remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
< bitcoin-git> [bitcoin] hebasto opened pull request #16286: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
< gribble> https://github.com/bitcoin/bitcoin/issues/16183 | depends: xtrans: Configure flags cleanup. by dongcarl · Pull Request #16183 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #16285: rpc: Improve scantxoutset response and help message (master...2019-06-scantxoutset-nits) https://github.com/bitcoin/bitcoin/pull/16285
< gribble> https://github.com/bitcoin/bitcoin/issues/16238 | build: Remove unused C++ standard library includes by practicalswift · Pull Request #16238 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16129 | refactor: Remove unused includes by practicalswift · Pull Request #16129 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16278 | tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests by practicalswift · Pull Request #16278 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15894: Remove duplicated "Error: " prefix in logs (master...20190425-duplicated-error-prefix) https://github.com/bitcoin/bitcoin/pull/15894
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c52776e6ff4d...332c6134bb15
< bitcoin-git> bitcoin/master f0641f2 Hennadii Stepanov: Prepend the error/warning prefix for GUI messages
< bitcoin-git> bitcoin/master 96fd4ee Hennadii Stepanov: Add MSG_NOPREFIX flag for user messages
< bitcoin-git> bitcoin/master f724f31 Hennadii Stepanov: Make AbortNode() aware of MSG_NOPREFIX flag
< bitcoin-git> [bitcoin] fanquake reopened pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
< bitcoin-git> [bitcoin] laanwj merged pull request #16252: test: Log to debug.log in all unit tests (master...1905-bufferLog) https://github.com/bitcoin/bitcoin/pull/16252
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc948d4cfd6d...c52776e6ff4d
< bitcoin-git> bitcoin/master fad3d2a MarcoFalke: test: Create data dir in BasicTestingSetup
< bitcoin-git> bitcoin/master fa4a04a MarcoFalke: test: use common setup in gui tests
< bitcoin-git> bitcoin/master fabc57e MarcoFalke: test: Log to debug.log in all tests
< gribble> https://github.com/bitcoin/bitcoin/issues/15894 | Remove duplicated "Error: " prefix in logs by hebasto · Pull Request #15894 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #15572: Add auto select custom fee when smart fee not initialized. (master...dev) https://github.com/bitcoin/bitcoin/pull/15572
< bitcoin-git> [bitcoin] fanquake merged pull request #16183: depends: xtrans: Configure flags cleanup. (master...2019-06-leave-xtrans-alone-right-now) https://github.com/bitcoin/bitcoin/pull/16183
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21bd6eb782ca...bc948d4cfd6d
< bitcoin-git> bitcoin/master 30ea931 Carl Dong: depends: xtrans: Configure flags cleanup.
< bitcoin-git> bitcoin/master bc948d4 fanquake: Merge #16183: depends: xtrans: Configure flags cleanup.
< bitcoin-git> [bitcoin] fanquake closed pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
< bitcoin-git> [bitcoin] stplaydog opened pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
< bitcoin-git> [bitcoin] fanquake merged pull request #16188: net: Document what happens to getdata of unknown type (master...1906-netGetData) https://github.com/bitcoin/bitcoin/pull/16188
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e115a21f79c4...21bd6eb782ca
< bitcoin-git> bitcoin/master dddd927 MarcoFalke: net: Document what happens to getdata of unknonw type
< bitcoin-git> bitcoin/master 21bd6eb fanquake: Merge #16188: net: Document what happens to getdata of unknown type
< gribble> https://github.com/bitcoin/bitcoin/issues/16188 | net: Document what happens to getdata of unknown type by MarcoFalke · Pull Request #16188 · bitcoin/bitcoin · GitHub

2019-06-24

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16279: Return the AcceptBlock CValidationState directly in ProcessNewBlock (master...2019-06-pnb-dos-state) https://github.com/bitcoin/bitcoin/pull/16279
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16223: devtools: Fetch and display ACKs at sign-off time in github-merge (master...2019_06_contrib_acks) https://github.com/bitcoin/bitcoin/pull/16223
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44e849c35a7e...e115a21f79c4
< bitcoin-git> bitcoin/master 0e01e45 Wladimir J. van der Laan: devtools: Fetch and display ACKs at sign-off time in github-merge
< bitcoin-git> bitcoin/master e115a21 MarcoFalke: Merge #16223: devtools: Fetch and display ACKs at sign-off time in github-...
< bitcoin-git> [bitcoin] practicalswift opened pull request #16278: tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (master...cut-compilation-bloat-in-unit-tests) https://github.com/bitcoin/bitcoin/pull/16278
< bitcoin-git> [bitcoin] gertjaap opened pull request #16277: Supress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277
< bitcoin-git> [bitcoin] promag closed pull request #16215: gui: Refactor wallet controller activities (master...2019-06-refactor-wallet-controller-activities) https://github.com/bitcoin/bitcoin/pull/16215
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16254: qt: Set AA_EnableHighDpiScaling attribute early (master...20190620-EnableHighDpiScaling-warning) https://github.com/bitcoin/bitcoin/pull/16254
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fee6769a10...44e849c35a7e
< bitcoin-git> bitcoin/master 099e4b9 Hennadii Stepanov: Set AA_EnableHighDpiScaling attribute early
< bitcoin-git> bitcoin/master 44e849c MarcoFalke: Merge #16254: qt: Set AA_EnableHighDpiScaling attribute early
< bitcoin-git> [bitcoin] orientye opened pull request #16276: optimize for diagnosis of deadlock (master...master) https://github.com/bitcoin/bitcoin/pull/16276
< bitcoin-git> [bitcoin] fanquake closed pull request #13442: Convert the 1-way SSE4 SHA256 code from asm to intrinsics (master...201806_sse4intrin) https://github.com/bitcoin/bitcoin/pull/13442
< bitcoin-git> [bitcoin] fanquake closed pull request #13472: [devtools translations] catch invalid specifiers (master...HashUnlimited-translate-1) https://github.com/bitcoin/bitcoin/pull/13472
< gribble> https://github.com/bitcoin/bitcoin/issues/13084 | Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code by sipa · Pull Request #13084 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master c8fee67 fanquake: Merge #16263: qt: Use qInfo() if no error occurs
< bitcoin-git> [bitcoin] fanquake merged pull request #16263: qt: Use qInfo() if no error occurs (master...20190621-qInfo) https://github.com/bitcoin/bitcoin/pull/16263
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1bab5052a2b...c8fee6769a10
< bitcoin-git> bitcoin/master a2aabfb Hennadii Stepanov: Use qInfo() if no error occurs

2019-06-23

< bitcoin-git> [bitcoin] practicalswift opened pull request #16273: refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
< bitcoin-git> [bitcoin] practicalswift closed pull request #16238: build: Remove unused C++ standard library includes (master...c++-standard-library-headers) https://github.com/bitcoin/bitcoin/pull/16238
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16272: Update aes.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16272
< bitcoin-git> [bitcoin] highfeed opened pull request #16272: Update aes.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16272
< bitcoin-git> [bitcoin] fanquake opened pull request #16271: build: remove -Wall from rapidcheck build flags (master...rapidcheck_no_wall) https://github.com/bitcoin/bitcoin/pull/16271
< bitcoin-git> [bitcoin] fanquake merged pull request #16231: gui: Fix open wallet menu initialization order (master...2019-06-fix-open-menu) https://github.com/bitcoin/bitcoin/pull/16231
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2cbcc55ba6ae...c1bab5052a2b
< bitcoin-git> bitcoin/master 5224be5 João Barbosa: gui: Fix open wallet menu initialization order
< bitcoin-git> bitcoin/master c1bab50 fanquake: Merge #16231: gui: Fix open wallet menu initialization order
< bitcoin-git> [bitcoin] fanquake opened pull request #16270: depends: expat 2.2.7 (master...expat-2-2-7) https://github.com/bitcoin/bitcoin/pull/16270
< fanquake> Looks like we've got reproducible Guix builds (for Linux): https://github.com/bitcoin/bitcoin/pull/15277#issuecomment-504729878 !

2019-06-22

< ossifrage> I have 'onlynet=ipv4' in my bitcoin.conf, but I saw this today (with 2cbcc55ba) "Error: Couldn't open socket for incoming connections (socket returned error Address family not supported by protocol (97))"
< bitcoin-git> [bitcoin] fanatid opened pull request #16267: bench: Benchmark blockToJSON (master...bench-blocktojson) https://github.com/bitcoin/bitcoin/pull/16267
< meshcollider> fanquake: usually the former, I think more advanced users will prefer to use the command line anyway, I think the two main purposes the GUI serves in my mind is 1) for less technical users that just want to start it up and run bitcoin, and 2) for more advanced users to do stuff that would be really painful on the command line like coin selection stuff
< gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
< fanquake> meshcollider when thinking about the wallet GUI, what end user do you normally have in mind? Somewhere on the spectrum of "new non-technical user, just downloaded Bitcoin Core" & "one of the engineers that helps build Bitcoin Core"?
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] meshcollider merged pull request #16239: wallet/rpc: follow-up clean-up/fixes to avoid_reuse (master...2019-06-followup-avoidreuse) https://github.com/bitcoin/bitcoin/pull/16239
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/32e94538185b...2cbcc55ba6ae
< bitcoin-git> bitcoin/master 53c3c1e Karl-Johan Alm: wallet/rpc/getbalances: add entry for 'mine.used' balance in results
< bitcoin-git> bitcoin/master 3d2ff37 Karl-Johan Alm: wallet/rpc: use static help text
< bitcoin-git> bitcoin/master 71d0344 Karl-Johan Alm: docs: release note wording
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub

2019-06-21

< jtimon> In regtest, I'm sending coins from bitcoin core to lightningd's newaddr but it doesn't seem to be receiving anything, I'm generating more blocks on the core node and calling dev_rescan_outputs on the lightning node, but still not seeing anything in listfunds and fundchannel says "Cannot afford transaction"
< gwillen> (he is also the author of "Peer-to-Peer Affine Commitment using Bitcoin", which describes the "Typecoin" system, and was almost named "Massively Multiplayer Online Linear Logic")
< bitcoin-git> [bitcoin] asood123 opened pull request #16265: Update check disk space in bitcoind (master...patch-15813) https://github.com/bitcoin/bitcoin/pull/16265
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16264: policy: Add experimental -mempoolreplacement=full (off by default) (master...1906-policyFullRbf) https://github.com/bitcoin/bitcoin/pull/16264
< bitcoin-git> [bitcoin] hebasto opened pull request #16263: qt: Use qInfo() if no error occurs (master...20190621-qInfo) https://github.com/bitcoin/bitcoin/pull/16263
< gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] pstratem opened pull request #16262: Slightly simplify the mining loop. (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
< gribble> https://github.com/bitcoin/bitcoin/issues/15588 | Log the actual wallet file version and no longer publicly expose the "version" record by achow101 · Pull Request #15588 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #16261: gui: Refactor OpenWalletActivity (master...2019-06-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/16261
< phantomcircuit> kallewoof, there's a pr with comments https://github.com/bitcoin/bitcoin/pull/7663
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
< bitcoin-git> [bitcoin] natangl opened pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
< bitcoin-git> [bitcoin] fanquake merged pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd333e15a545...32e94538185b
< bitcoin-git> bitcoin/master 5a88ea7 Jon Atack: doc: remove orphaned header in developer notes
< bitcoin-git> bitcoin/master 32e9453 fanquake: Merge #16256: doc: remove orphaned header in developer notes
< bitcoin-git> [bitcoin] meshcollider merged pull request #16226: Move ismine to the wallet module (master...mv-ismine-wallet) https://github.com/bitcoin/bitcoin/pull/16226
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/303ec103bacf...fd333e15a545
< bitcoin-git> bitcoin/master 7c611e2 Andrew Chow: Move ismine to wallet module
< bitcoin-git> bitcoin/master e61de63 Andrew Chow: Change ismine to take a CWallet instead of CKeyStore
< bitcoin-git> bitcoin/master fd333e1 MeshCollider: Merge #16226: Move ismine to the wallet module
< bitcoin-git> [bitcoin] meshcollider merged pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23815ee74dfd...303ec103bacf
< bitcoin-git> bitcoin/master a495034 Andrew Chow: Make and get the multisig redeemscript and destination in one function ins...
< bitcoin-git> bitcoin/master 303ec10 MeshCollider: Merge #16026: Ensure that uncompressed public keys in a multisig always re...
< kallewoof> @sipa I am confused about a commit of yours from March 2016 (sorry..!), but someone else might be able to explain this: https://github.com/bitcoin/bitcoin/commit/8a253b342c5272496926ed391b078742bbe937ae -- the nInnerLoopCount restricts the nonce to 0..65535 (16 bits), but the nonce is 32 bits. Why? I realize if you make this 0xffffffff and try to Ctrl-C a bitcoind instance while trying to find a blokc, it will lock up and
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
< kallewoof> I have a qemu instance for trying bitcoin compiling
< gribble> https://github.com/bitcoin/bitcoin/issues/16231 | gui: Fix open wallet menu initialization order by promag · Pull Request #16231 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16215 | gui: Refactor wallet controller activities by promag · Pull Request #16215 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257

2019-06-20

< bitcoin-git> [bitcoin] jonatack opened pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16246: MSVC: Fix error in debug mode (Fix #16245) (master...fix/bigobj) https://github.com/bitcoin/bitcoin/pull/16246
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16207: test: stop generating lcov coverage when functional tests fail (master...patch-15648) https://github.com/bitcoin/bitcoin/pull/16207
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4ad4c0de30f...23815ee74dfd
< bitcoin-git> bitcoin/master eb832cd nicolas.dorier: MSVC: Fix error in debug mode (Fix #16245)
< bitcoin-git> bitcoin/master 23815ee MarcoFalke: Merge #16246: MSVC: Fix error in debug mode (Fix #16245)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea45967e856d...b4ad4c0de30f
< bitcoin-git> bitcoin/master 9218ce8 Aseem Sood: Failing functional tests stop lcov
< bitcoin-git> bitcoin/master b4ad4c0 MarcoFalke: Merge #16207: test: stop generating lcov coverage when functional tests fa...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16234: test: Add test for unknown args (master...1906-unknownArgs) https://github.com/bitcoin/bitcoin/pull/16234
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c95515ba034...ea45967e856d
< bitcoin-git> bitcoin/master fa7dd88 MarcoFalke: test: Add test for unknown args
< bitcoin-git> bitcoin/master ea45967 MarcoFalke: Merge #16234: test: Add test for unknown args
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15520: cirrus: Run extended test feature_pruning (master...1903-ciExt) https://github.com/bitcoin/bitcoin/pull/15520
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/413e438ea976...9c95515ba034
< bitcoin-git> bitcoin/master fa00326 MarcoFalke: ci: Run extended tests
< bitcoin-git> bitcoin/master 9c95515 MarcoFalke: Merge #15520: cirrus: Run extended test feature_pruning
< sipa> oh also short reminder we're going to meet with github tomorrow, if there are any things we should bring up, see https://github.com/bitcoin/bitcoin/issues/15847
< wumpus> #topic Requiring 2FA for bitcoin orgs on GH (fanquake)
< BlueMatt> I dont think we could realistically say "take this file that shipped with bitcoin core and copy it to your datadir on first run"
< sipa> an obvious improvement is to have a map built-in to bitcoin core that tells what the actual independent network ranges are
< jnewbery> If you have any friends who are less experienced and want to get into Bitcoin Core development, you should send them along
< jnewbery> I just wanted to give an update on the Bitcoin Core Review Club (https://bitcoin-core-review-club.github.io/) that we've been doing for the last couple of months.
< wumpus> #topic Bitcoin Core PR review club (jnewbery)
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 5 blockers, 2 bugfixes and 6(!) things chasing concept ack
< wumpus> two topics proposed in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : Bitcoin core PR review club, ASN blob discussion
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< jonasschnelli> dig -p 53 @2604:a880:2:d0::469c:c001 AAAA seed.bitcoin.jonasschnelli.ch <--- works now
< luke-jr> that would also be nice to block other users from binding the Bitcoin JSON-RPC port
< jonasschnelli> dig -p 5353 @2604:a880:2:d0::469c:c001 AAAA seed.bitcoin.jonasschnelli.ch
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255