< bitcoin-git>
bitcoin/master fa2b083 MarcoFalke: [test] Add test to check mempool consistency in case of reorgs
< bitcoin-git>
[bitcoin] promag opened pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git>
bitcoin/master 6c21a80 Wladimir J. van der Laan: Merge #15538: wallet_bumpfee.py: Make sure coin selection produces change
< bitcoin-git>
[bitcoin] laanwj merged pull request #16212: addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors (master...SerializeFileDB-non-determinism) https://github.com/bitcoin/bitcoin/pull/16212
< bitcoin-git>
bitcoin/master d975338 practicalswift: addrdb: Remove temporary files created in SerializeFileDB. Fixes non-deter...
< bitcoin-git>
bitcoin/master 3ccab64 Wladimir J. van der Laan: Merge #16212: addrdb: Avoid eating inodes - remove temporary files created...
2019-07-01
< wumpus>
pinheadmz: that was always the problem, I'm usually happy to help people but it was always the same discussions about bitcoin over and over again, that just wears you out
< pinheadmz>
The room "#bitcoin" on "chat.freenode.net" is invite only. -- getting this message today all of a sudden, anyone else?
< bitcoin-git>
[bitcoin] laanwj merged pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
< bitcoin-git>
bitcoin/master 806b005 Sjors Provoost: [wallet] abort when attempting to fund a transaction above maxtxfee
< bitcoin-git>
bitcoin/master 1212808 Wladimir J. van der Laan: Merge #16257: [wallet] abort when attempting to fund a transaction above -...
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16320: ci: Add Travis check to catch accidental introduction of non-determinism in unit tests (master...test-deterministic-coverage-in-travis) https://github.com/bitcoin/bitcoin/pull/16320
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #16319: [MSVC] Simplify AppVeyor build by using user customized project file (master...msvc/appveyor-refactor) https://github.com/bitcoin/bitcoin/pull/16319
< bitcoin-git>
[bitcoin] promag closed pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
< bitcoin-git>
[bitcoin] emilengler opened pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< phantomcircuit>
it was called "Bitcoin Wallet" by ... however you spell his name
< sipa>
phantomcircuit, gwillen: well... i don't think; bitcoin wallet for android started as a project when afaik literally it was the first android wallet (it may have been the first wallet software besides core entirely); i don't think in that context it was unreasonable to call it that way
< bitcoin-git>
[bitcoin] fanquake merged pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< phantomcircuit>
gwillen, bitcoin wallet by bitcoin wallet developers is schilbach i think
< harding>
gwillen: that email address isn't legit. I let the owner of bitcoin.org know so he could file his own report (I filed a report myself).
2019-06-29
< gwillen>
luke-jr: I have no idea, that would make sense but "Bitcoin Wallet developers" is very vague so it made me suspicious. It has strong reviews though.
< gwillen>
hm, the developer contact email is listed as "adminsupport@bitcoin.org"
< luke-jr>
"Bitcoin Wallet" is the original Android wallet, right?
< gwillen>
(this is on "Bitcoin Core - BTC Wallet")
< gwillen>
midnightmagic: there is another one called "Bitcoin Wallet" by "Bitcoin Wallet developers"
< midnightmagic>
er. the bitcoin core - btc wallet one I mean is just a rebranded breadwallet.
< gwillen>
midnightmagic: I assume you are looking at "Bitcoin Core - BTC Wallet" by "Core Org"? (I have no idea what it is, I endorse marking it malware if nobody knows what it is.)
< bitcoin-git>
[bitcoin] hebasto opened pull request #16314: scripts and tools: Update copyright_header.py script (master...20190629-copyright-headers) https://github.com/bitcoin/bitcoin/pull/16314
< bitcoin-git>
[bitcoin] jonatack opened pull request #16313: doc: Fix broken link in doc/build-osx.md (master...fix-broken-link-in-build-osx-docs) https://github.com/bitcoin/bitcoin/pull/16313
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16312: tests: Reduce compile-time memory usage by 0.5 GB when compiling script_tests.cpp (from 1.4 GB to 0.9 GB) (master...fix-absurd-memory-usage-when-compiling-script_build) https://github.com/bitcoin/bitcoin/pull/16312
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #16308: [MSVC] Copy build output to src/ automatically after build (master...build/copy-in-msbuild) https://github.com/bitcoin/bitcoin/pull/16308
< bitcoin-git>
[bitcoin] fanquake merged pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
< bitcoin-git>
bitcoin/master fa69c3e MarcoFalke: util: Explain why the path is cached
< bitcoin-git>
bitcoin/master 935cd6b Wladimir J. van der Laan: Merge #16300: util: Explain why the path is cached
< bitcoin-git>
[bitcoin] achow101 opened pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301
2019-06-27
< bitcoin-git>
[bitcoin] meshcollider closed pull request #16192: Wallet: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192
< bitcoin-git>
[bitcoin] promag opened pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git>
[bitcoin] promag closed pull request #12419: Force distinct destinations in CWallet::CreateTransaction (master...2018-02-distinct-destinations) https://github.com/bitcoin/bitcoin/pull/12419
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< dongcarl>
For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
< bitcoin-git>
[bitcoin] practicalswift closed pull request #16045: Skip redundant memset(p, 0, 0) calls where p is not valid for writing (master...redundant-memsets) https://github.com/bitcoin/bitcoin/pull/16045
< jtimon>
regarding https://github.com/bitcoin/bitcoin/pull/8994 I'm not sure it needs conceptual review (I'm sure there's many concept acks buried in the comments), but mostly review and re-review
< gribble>
https://github.com/bitcoin/bitcoin/issues/16278 | tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests by practicalswift · Pull Request #16278 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake merged pull request #16188: net: Document what happens to getdata of unknown type (master...1906-netGetData) https://github.com/bitcoin/bitcoin/pull/16188
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16279: Return the AcceptBlock CValidationState directly in ProcessNewBlock (master...2019-06-pnb-dos-state) https://github.com/bitcoin/bitcoin/pull/16279
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16223: devtools: Fetch and display ACKs at sign-off time in github-merge (master...2019_06_contrib_acks) https://github.com/bitcoin/bitcoin/pull/16223
< bitcoin-git>
bitcoin/master 0e01e45 Wladimir J. van der Laan: devtools: Fetch and display ACKs at sign-off time in github-merge
< bitcoin-git>
bitcoin/master e115a21 MarcoFalke: Merge #16223: devtools: Fetch and display ACKs at sign-off time in github-...
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16278: tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (master...cut-compilation-bloat-in-unit-tests) https://github.com/bitcoin/bitcoin/pull/16278
< bitcoin-git>
[bitcoin] gertjaap opened pull request #16277: Supress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277
< bitcoin-git>
bitcoin/master a2aabfb Hennadii Stepanov: Use qInfo() if no error occurs
2019-06-23
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16273: refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
< bitcoin-git>
[bitcoin] practicalswift closed pull request #16238: build: Remove unused C++ standard library includes (master...c++-standard-library-headers) https://github.com/bitcoin/bitcoin/pull/16238
< ossifrage>
I have 'onlynet=ipv4' in my bitcoin.conf, but I saw this today (with 2cbcc55ba) "Error: Couldn't open socket for incoming connections (socket returned error Address family not supported by protocol (97))"
< meshcollider>
fanquake: usually the former, I think more advanced users will prefer to use the command line anyway, I think the two main purposes the GUI serves in my mind is 1) for less technical users that just want to start it up and run bitcoin, and 2) for more advanced users to do stuff that would be really painful on the command line like coin selection stuff
< fanquake>
meshcollider when thinking about the wallet GUI, what end user do you normally have in mind? Somewhere on the spectrum of "new non-technical user, just downloaded Bitcoin Core" & "one of the engineers that helps build Bitcoin Core"?
< jtimon>
In regtest, I'm sending coins from bitcoin core to lightningd's newaddr but it doesn't seem to be receiving anything, I'm generating more blocks on the core node and calling dev_rescan_outputs on the lightning node, but still not seeing anything in listfunds and fundchannel says "Cannot afford transaction"
< gwillen>
(he is also the author of "Peer-to-Peer Affine Commitment using Bitcoin", which describes the "Typecoin" system, and was almost named "Massively Multiplayer Online Linear Logic")
< gribble>
https://github.com/bitcoin/bitcoin/issues/15588 | Log the actual wallet file version and no longer publicly expose the "version" record by achow101 · Pull Request #15588 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 7c611e2 Andrew Chow: Move ismine to wallet module
< bitcoin-git>
bitcoin/master e61de63 Andrew Chow: Change ismine to take a CWallet instead of CKeyStore
< bitcoin-git>
bitcoin/master fd333e1 MeshCollider: Merge #16226: Move ismine to the wallet module
< bitcoin-git>
[bitcoin] meshcollider merged pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
< bitcoin-git>
bitcoin/master a495034 Andrew Chow: Make and get the multisig redeemscript and destination in one function ins...
< bitcoin-git>
bitcoin/master 303ec10 MeshCollider: Merge #16026: Ensure that uncompressed public keys in a multisig always re...
< kallewoof>
@sipa I am confused about a commit of yours from March 2016 (sorry..!), but someone else might be able to explain this: https://github.com/bitcoin/bitcoin/commit/8a253b342c5272496926ed391b078742bbe937ae -- the nInnerLoopCount restricts the nonce to 0..65535 (16 bits), but the nonce is 32 bits. Why? I realize if you make this 0xffffffff and try to Ctrl-C a bitcoind instance while trying to find a blokc, it will lock up and
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
< kallewoof>
I have a qemu instance for trying bitcoin compiling
< bitcoin-git>
[bitcoin] Sjors opened pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
2019-06-20
< bitcoin-git>
[bitcoin] jonatack opened pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256