2018-04-26

< bitcoin-git> bitcoin/master bd9d67b Kristaps Kaupe: Don't test against min relay fee information in mining_prioritisetransaction.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25ad2f75f5d1...24106a85b3f6
< bitcoin-git> [bitcoin] ryanofsky closed pull request #12275: Improve ScanForWalletTransactions return value (master...pr/scanstat) https://github.com/bitcoin/bitcoin/pull/12275

2018-04-25

< bitcoin-git> [bitcoin] sipa opened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git> [bitcoin] practicalswift opened pull request #13083: Add compile time checking for all cs_main runtime locking assertions (master...cs_main) https://github.com/bitcoin/bitcoin/pull/13083
< bitcoin-git> [bitcoin] kristapsk opened pull request #13082: Don't test against min relay fee information in mining_prioritisetransaction.py (master...dont-hardcode-134) https://github.com/bitcoin/bitcoin/pull/13082
< bitcoin-git> [bitcoin] practicalswift opened pull request #13081: Add compile time checking for all cs_wallet runtime locking assertions (master...cs_wallet-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/13081
< bitcoin-git> [bitcoin] practicalswift opened pull request #13080: Add compile time checking for all ::mempool.cs runtime locking assertions (master...mempool.cs) https://github.com/bitcoin/bitcoin/pull/13080
< bitcoin-git> [bitcoin] Empact opened pull request #13079: Fix ScanForWalletTransactions to report progress correctly when a pindexStop is supplied (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
< bitcoin-git> [bitcoin] practicalswift opened pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (master...cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13077
< jamesob> and if so, would want to piggyback on the bitcoin-* 16 character pthread names or just have some peripheral mapping of boost thread ids to arbitrary length names?
< bitcoin-git> [bitcoin] Empact opened pull request #13076: Fix ScanForWalletTransactions to return a bool indicating success or failure (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
< bitcoin-git> [bitcoin] jnewbery opened pull request #13075: Remove 'account' API from wallet functional tests (master...remove_functional_tests_accounts) https://github.com/bitcoin/bitcoin/pull/13075
< bitcoin-git> [bitcoin] jnewbery opened pull request #13074: [trivial] Correct help text for `importaddress` RPC (master...importaddress_help_text) https://github.com/bitcoin/bitcoin/pull/13074
< bitcoin-git> [bitcoin] laanwj closed pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
< bitcoin-git> bitcoin/master 9c01be1 James O'Beirne: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage...
< bitcoin-git> bitcoin/master 8cdcaee James O'Beirne: [qt] Display more helpful message when adding a send address has failed...
< bitcoin-git> bitcoin/master c5b2770 James O'Beirne: Add purpose arg to Wallet::getAddress...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a785bc3667d3...25ad2f75f5d1
< wumpus> jamesob: I get a compile error when I try to compile it against current master: /.../bitcoin/src/qt/test/addressbooktests.cpp:106:5: error: use of undeclared identifier 'vpwallets'; did you mean 'wallet'?
< jamesob> jimpo: I'll do it if you take a look at https://github.com/bitcoin/bitcoin/pull/12830
< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< bitcoin-git> bitcoin/master a785bc3 MarcoFalke: Merge #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
< bitcoin-git> bitcoin/master 3e53004 Wladimir J. van der Laan: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/106d9297801c...a785bc3667d3
< bitcoin-git> [bitcoin] laanwj opened pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< bitcoin-git> [bitcoin] laanwj closed pull request #13056: [tests] Make rpcauth.py testable and add unit tests (master...rpcauth) https://github.com/bitcoin/bitcoin/pull/13056
< bitcoin-git> bitcoin/master 106d929 Wladimir J. van der Laan: Merge #13056: [tests] Make rpcauth.py testable and add unit tests...
< bitcoin-git> bitcoin/master 6674a75 Qasim Javed: [tests] Make rpcauth.py testable and add unit tests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e074097c1ba3...106d9297801c
< bitcoin-git> [bitcoin] laanwj closed pull request #13051: qa: Normalize executable location (master...Mf1804-qaDefaultConfig) https://github.com/bitcoin/bitcoin/pull/13051
< bitcoin-git> bitcoin/master e074097 Wladimir J. van der Laan: Merge #13051: qa: Normalize executable location...
< bitcoin-git> bitcoin/master fa811b0 MarcoFalke: qa: Normalize executable location
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a0079d4b6dc6...e074097c1ba3
< bitcoin-git> [bitcoin] laanwj closed pull request #13071: test: Don't log to stdout in functional tests (master...2018_04_test_output) https://github.com/bitcoin/bitcoin/pull/13071
< bitcoin-git> [bitcoin] ajtowns opened pull request #13072: Update createmultisig RPC to support segwit (master...signmultisig) https://github.com/bitcoin/bitcoin/pull/13072
< bitcoin-git> [bitcoin] laanwj opened pull request #13071: test: Don't log to stdout in functional tests (master...2018_04_test_output) https://github.com/bitcoin/bitcoin/pull/13071
< gribble> https://github.com/bitcoin/bitcoin/issues/13004 | Print to console by default when not run with -daemon by practicalswift · Pull Request #13004 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #13070: Split event handlers by wallet (master...2018-04-split-handlers-by-wallet) https://github.com/bitcoin/bitcoin/pull/13070

2018-04-24

< promag> I also forget testing with bitcoin-cli..
< promag> jtimon: vRPCConvertParams is only used by bitcoin-cli
< bitcoin-git> [bitcoin] practicalswift opened pull request #13069: docs: Fix typos (master...typos-201804) https://github.com/bitcoin/bitcoin/pull/13069
< bitcoin-git> [bitcoin] practicalswift opened pull request #13068: tests: Remove unused constant MAX_INV_SZ (master...MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13068
< jnewbery> promag: looks like that job was restarted so I can't see the failure. Was it: https://github.com/bitcoin/bitcoin/issues/12863 ?
< bitcoin-git> [bitcoin] jimpo closed pull request #12647: wallet: Fix possible memory leak in CreateWalletFromFile. (master...wallet-pointer) https://github.com/bitcoin/bitcoin/pull/12647
< promag> got "test_framework.authproxy.JSONRPCException: The mempool was not loaded yet (-1)" in https://travis-ci.org/bitcoin/bitcoin/jobs/370654669
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13013: bench: Amend mempool_eviction test for witness txs (master...Mf1804-benchWitnessMempool) https://github.com/bitcoin/bitcoin/pull/13013
< bitcoin-git> bitcoin/master a0079d4 MarcoFalke: Merge #13013: bench: Amend mempool_eviction test for witness txs...
< bitcoin-git> bitcoin/master fa3bb18 MarcoFalke: bench: Amend mempool_eviction test for witness txs
< bitcoin-git> bitcoin/master 962d223 MarcoFalke: bench: Move constructors out of mempool_eviction hot loop
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/476cb35551f5...a0079d4b6dc6
< gribble> https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12909: wallet: Make fee settings to be non-static members (master...Mf1804-walletMembers) https://github.com/bitcoin/bitcoin/pull/12909
< bitcoin-git> bitcoin/master 476cb35 Wladimir J. van der Laan: Merge #12909: wallet: Make fee settings to be non-static members...
< bitcoin-git> bitcoin/master fac0db0 MarcoFalke: wallet: Make fee settings non-static members
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1d54ae6a362...476cb35551f5
< jtimon> re-re-review re-re-beg: https://github.com/bitcoin/bitcoin/pull/10757
< gribble> https://github.com/bitcoin/bitcoin/issues/9700 | Cache segwit signature hash components inside CTransaction to optimize validation performance by sdaftuar · Pull Request #9700 · bitcoin/bitcoin · GitHub
< sdaftuar> sipa: regarding your comment in https://github.com/bitcoin/bitcoin/pull/13011#issuecomment-383145046 -- #9700 did have a mechanism to avoid doing the precomputation, so that block requests (and rescan) wouldn't be impacted
< bitcoin-git> bitcoin/0.16 0e98f96 Ben Woosley: test: Use wait_until in tests where time was used for polling...
< bitcoin-git> bitcoin/0.16 1286f3e Ben Woosley: test: Use wait_until to ensure ping goes out...
< bitcoin-git> bitcoin/0.16 cfebd40 Karl-Johan Alm: [test] Round target fee to 8 decimals in assert_fee_amount...
< bitcoin-git> [bitcoin] MarcoFalke pushed 10 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/845838c4451e...9ea62a3dc4bd
< bitcoin-git> [bitcoin] ccdle12 opened pull request #13067: Pr fixes ccdle12 (master...PR-fixes-ccdle12) https://github.com/bitcoin/bitcoin/pull/13067
< jamesob> anyone know what an exit code of -6 from bitcoin-qt signifies? didn't turn anything up with grep
< bitcoin-git> [bitcoin] laanwj closed pull request #12953: Deprecate accounts (master...deprecate_accounts) https://github.com/bitcoin/bitcoin/pull/12953
< bitcoin-git> bitcoin/master 4e671f0 John Newbery: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py...
< bitcoin-git> bitcoin/master 3db1ba0 John Newbery: [tests] Set -deprecatedrpc=accounts in tests...
< bitcoin-git> bitcoin/master a28b907 John Newbery: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table...
< bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/018c7e5dadc1...d1d54ae6a362
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13066: Make travis to run verify-commits (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13066
< bitcoin-git> bitcoin/master 018c7e5 Wladimir J. van der Laan: Merge #13024: test: Add rpcauth pair that generated by rpcauth.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #13024: test: Add rpcauth pair that generated by rpcauth.py (master...rpc_test) https://github.com/bitcoin/bitcoin/pull/13024
< bitcoin-git> bitcoin/master 8b8032e Chun Kuan Lee: test: Add rpcauth pair that generated by rpcauth
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/54865cf9e6a8...018c7e5dadc1
< bitcoin-git> bitcoin/master 54865cf Wladimir J. van der Laan: Merge #13061: Make tests pass after 2020...
< bitcoin-git> [bitcoin] laanwj closed pull request #13061: Make tests pass after 2020 (master...ftbfs-2020) https://github.com/bitcoin/bitcoin/pull/13061
< bitcoin-git> bitcoin/master 3ee4be1 Bernhard M. Wiedemann: Make tests pass after 2020...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e67754e481f...54865cf9e6a8
< bitcoin-git> [bitcoin] laanwj closed pull request #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output (master...issue/11561/test-negative-transaction-version-numbers) https://github.com/bitcoin/bitcoin/pull/12436
< bitcoin-git> bitcoin/master 6e67754 Wladimir J. van der Laan: Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output...
< bitcoin-git> bitcoin/master 09b30db 251: Asserts that the tx version number is a signed 32-bit integer.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/34dd1a6d5e36...6e67754e481f
< bitcoin-git> [bitcoin] laanwj closed pull request #13032: Output values for "min relay fee not met" error (master...min-relay-fee-not-met-debug) https://github.com/bitcoin/bitcoin/pull/13032
< bitcoin-git> bitcoin/master 34dd1a6 Wladimir J. van der Laan: Merge #13032: Output values for "min relay fee not met" error...
< bitcoin-git> bitcoin/master 1accfbc Kristaps Kaupe: Output values for "min relay fee not met" error
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/896a9d026ccf...34dd1a6d5e36
< bitcoin-git> [bitcoin] laanwj closed pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (master...2018-04-18-func-test-debug-log) https://github.com/bitcoin/bitcoin/pull/13022
< bitcoin-git> bitcoin/master 896a9d0 Wladimir J. van der Laan: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages...
< bitcoin-git> bitcoin/master 80a5e59 James O'Beirne: [qa] Attach node index to test_node AssertionError and print messages...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/569e3817e000...896a9d026ccf
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< ossifrage> Does bitcoin core do some sort of io maintenance task that gobbles up a bunch of disk IO?
< bitcoin-git> [bitcoin] laanwj closed pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064
< bitcoin-git> bitcoin/master 569e381 Wladimir J. van der Laan: Merge #13064: List support for BIP173 in bips.md...
< bitcoin-git> bitcoin/master 4d33039 Pieter Wuille: List support for BIP173 in bips.md
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bdda14d1c01c...569e3817e000
< bitcoin-git> [bitcoin] ken2812221 closed pull request #13065: Let travis run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065
< gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub

2018-04-23

< bitcoin-git> [bitcoin] ken2812221 opened pull request #13065: Let travis to run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055
< bitcoin-git> bitcoin/master bdda14d MarcoFalke: Merge #13055: qt: Don't log to console by default...
< bitcoin-git> bitcoin/master aee80b0 Wladimir J. van der Laan: qt: Don't log to console by default...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a49381dfa3ee...bdda14d1c01c
< bitcoin-git> [bitcoin] sipa opened pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064
< gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #11402: Use shared pointer for wallet instances (master...2017-09-wallet-shared-pointer) https://github.com/bitcoin/bitcoin/pull/11402
< bitcoin-git> [bitcoin] sipa opened pull request #13062: Make script interpreter independent from storage type CScript (master...201804_spaninterpret) https://github.com/bitcoin/bitcoin/pull/13062
< jtimon> aj: also I just noticed I forgot this nit: https://github.com/bitcoin/bitcoin/pull/10757/files#r181616478
< bitcoin-git> [bitcoin] bmwiedemann opened pull request #13061: Make tests pass after 2020 (master...ftbfs-2020) https://github.com/bitcoin/bitcoin/pull/13061
< bitcoin-git> [bitcoin] jnewbery closed pull request #9806: txoutsbyaddress index (take 3) (master...gettxoutsbyaddress) https://github.com/bitcoin/bitcoin/pull/9806
< bitcoin-git> [bitcoin] jnewbery opened pull request #13060: [wallet] [rpc] Remove getlabeladdress RPC (master...remove_getlabeladdress) https://github.com/bitcoin/bitcoin/pull/13060
< jonasschnelli> wumpus: here is the flamgraph during 3.8GB blockserving on localhost: https://bitcoin.jonasschnelli.ch/perf-heavy-blockserving.svg
< bitcoin-git> [bitcoin] laanwj closed pull request #12885: Reduce implementation code inside CScript (master...201803_reducescript) https://github.com/bitcoin/bitcoin/pull/12885
< bitcoin-git> bitcoin/master 6a7456a Pieter Wuille: [MOVEONLY] Move CSCript::FindAndDelete to interpreter
< bitcoin-git> bitcoin/master 2fb168b Pieter Wuille: Make iterators in CScript::FindAndDelete const
< bitcoin-git> bitcoin/master 33a8ecf Pieter Wuille: Delete unused non-const-iterator CSCript::GetOp overloads
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8609ddb36821...a49381dfa3ee
< bitcoin-git> [bitcoin] laanwj closed pull request #12999: qt: Show the Window when double clicking the taskbar icon (master...qt-fix) https://github.com/bitcoin/bitcoin/pull/12999
< bitcoin-git> bitcoin/master 8609ddb Wladimir J. van der Laan: Merge #12999: qt: Show the Window when double clicking the taskbar icon...
< bitcoin-git> bitcoin/master 67bf2aa Chun Kuan Lee: qt:Show the entire Window when double clicking on taskbar
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3f04c0e81a6...8609ddb36821
< bitcoin-git> [bitcoin] laanwj closed pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (master...fix_zapwallet_multiwallet_interaction) https://github.com/bitcoin/bitcoin/pull/13030
< bitcoin-git> bitcoin/master d3f04c0 Wladimir J. van der Laan: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction....
< bitcoin-git> bitcoin/master 1f83839 John Newbery: [wallet] [tests] Test disallowed multiwallet params...
< bitcoin-git> bitcoin/master 3476e3c John Newbery: [wallet] Fix zapwallettxes/multiwallet interaction....
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/84efa9a0f752...d3f04c0e81a6
< bitcoin-git> [bitcoin] jnewbery opened pull request #13058: [wallet] `createwallet` RPC - create new wallet at runtime (master...create_wallet) https://github.com/bitcoin/bitcoin/pull/13058
< bitcoin-git> [bitcoin] laanwj closed pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448
< bitcoin-git> bitcoin/master 84efa9a Wladimir J. van der Laan: Merge #12448: Interrupt block generation on shutdown request...
< bitcoin-git> bitcoin/master 0851a75 João Barbosa: rpc: Interrupt block generation on shutdown request
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1e3c5e73cfc...84efa9a0f752
< bitcoin-git> [bitcoin] laanwj closed pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (master...2018-04-17-doc-chainparams-validation) https://github.com/bitcoin/bitcoin/pull/13012
< bitcoin-git> bitcoin/master d1e3c5e Wladimir J. van der Laan: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp...
< bitcoin-git> bitcoin/master 18326ae James O'Beirne: [doc] Add comments for chainparams.h, validation.cpp
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5713994de98e...d1e3c5e73cfc
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13052: trivial: Fix relevent typo (master...relevent) https://github.com/bitcoin/bitcoin/pull/13052
< bitcoin-git> bitcoin/master 5713994 MarcoFalke: Merge #13052: trivial: Fix relevent typo...
< bitcoin-git> bitcoin/master 6ad47b0 practicalswift: trivial: Fix relevent typo
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d5b2e98250f6...5713994de98e
< bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
< bitcoin-git> bitcoin/master d5b2e98 Wladimir J. van der Laan: Merge #12510: test: Add rpc_bind test to default-run tests...
< bitcoin-git> bitcoin/master e87fefc Wladimir J. van der Laan: test: Add rpc_bind test to default-run tests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4741ca5dc8fd...d5b2e98250f6
< bitcoin-git> [bitcoin] instagibbs opened pull request #13057: remove redundant pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
< bitcoin-git> [bitcoin] laanwj closed pull request #13020: Consistently log CValidationState on call failure (master...log-cvalidation-state) https://github.com/bitcoin/bitcoin/pull/13020
< bitcoin-git> bitcoin/master 4741ca5 Wladimir J. van der Laan: Merge #13020: Consistently log CValidationState on call failure...
< bitcoin-git> bitcoin/master e4d0b44 Ben Woosley: Consistently log CValidationState on failure...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8b4081a889b3...4741ca5dc8fd
< bitcoin-git> [bitcoin] laanwj closed pull request #13039: Add logging and error handling for file syncing (master...2018_04_fsync_noignore) https://github.com/bitcoin/bitcoin/pull/13039
< bitcoin-git> bitcoin/master 8b4081a Wladimir J. van der Laan: Merge #13039: Add logging and error handling for file syncing...
< bitcoin-git> bitcoin/master cf02779 Wladimir J. van der Laan: Add logging and error handling for file syncing...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2746db66fd5...8b4081a889b3
< bitcoin-git> [bitcoin] laanwj closed pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (master...g-failed-blocks) https://github.com/bitcoin/bitcoin/pull/13016
< bitcoin-git> bitcoin/master e2746db Wladimir J. van der Laan: Merge #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
< bitcoin-git> bitcoin/master 3cc9094 Ben Woosley: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65d7083f152e...e2746db66fd5
< bitcoin-git> [bitcoin] nixbox opened pull request #13056: [tests] Make rpcauth.py testable and add unit tests (master...rpcauth) https://github.com/bitcoin/bitcoin/pull/13056
< bitcoin-git> [bitcoin] laanwj opened pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055
< bitcoin-git> [bitcoin] laanwj closed pull request #13017: Add wallets management functions (master...2018-04-vpwallets) https://github.com/bitcoin/bitcoin/pull/13017
< bitcoin-git> bitcoin/master 3c058fd João Barbosa: wallet: Add HasWallets
< bitcoin-git> bitcoin/master 373aee2 João Barbosa: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets...
< bitcoin-git> bitcoin/master 6efd964 João Barbosa: refactor: Drop CWalletRef typedef
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3e60b9cfa768...65d7083f152e

2018-04-22

< bitcoin-git> [bitcoin] practicalswift opened pull request #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. (master...imports) https://github.com/bitcoin/bitcoin/pull/13054
< bitcoin-git> [bitcoin] practicalswift opened pull request #13052: trivial: Fix relevent typo (master...relevent) https://github.com/bitcoin/bitcoin/pull/13052
< bitcoin-git> [bitcoin] laanwj closed pull request #12998: Default to defining endian-conversion DECLs in compat w/o config (master...2018-04-default-decls) https://github.com/bitcoin/bitcoin/pull/12998
< bitcoin-git> bitcoin/master 3e60b9c Wladimir J. van der Laan: Merge #12998: Default to defining endian-conversion DECLs in compat w/o config...
< bitcoin-git> bitcoin/master 150b2f0 Matt Corallo: Default to defining endian-conversion DECLs in compat w/o config...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cac6d1184da5...3e60b9cfa768
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13048: [tests] Fix feature_block flakiness (master...fix_feature_block_flakiness) https://github.com/bitcoin/bitcoin/pull/13048
< bitcoin-git> bitcoin/master cac6d11 MarcoFalke: Merge #13048: [tests] Fix feature_block flakiness...
< bitcoin-git> bitcoin/master c1d7420 John Newbery: [tests] Fix feature_block flakiness...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f644ea487afc...cac6d1184da5

2018-04-21

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13051: qa: Normalize executable location (master...Mf1804-qaDefaultConfig) https://github.com/bitcoin/bitcoin/pull/13051
< bitcoin-git> [bitcoin] lucash-dev opened pull request #13050: [WIP] [tests] improvements to slow unit tests (master...slow-unit-tests-improvement) https://github.com/bitcoin/bitcoin/pull/13050
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13047: [trivial] Tidy blocktools.py (master...tidy_blocktools) https://github.com/bitcoin/bitcoin/pull/13047
< bitcoin-git> bitcoin/master cab8be5 John Newbery: [tests] Fix flake8 warnings in blocktools.py
< bitcoin-git> bitcoin/master 4d355bf John Newbery: [tests] tidy up blocktools.py...
< bitcoin-git> bitcoin/master b184127 Jesse Cohen: [doc][trivial] no retargeting in regtest mode
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8b262eb2d80b...f644ea487afc
< provoostenator> jnewbery: the functional test combined log output should be truncated (more) imo. 5000 lines is too much; my browser is almost unable to render the Travis logs: https://travis-ci.org/bitcoin/bitcoin/jobs/366456599
< sipa> you can't, and this is off topic here. ask in #bitcoin or on bitcoin.stackexchange.com
< sipa> go ask in #bitcoin, not here
< oxid> #bitcoin
< sipa> oxid: #bitcoin
< oxid> I find internet documents that bitcoin was published open-source in 2008; but that some coins were active in 2007, perhaps by developers or leaked or simply shared before making it a public project.
< oxid> What what the first exchange to either sell BTC to the public, or have an exchange system where you can buy coins or trade them. The most I recall on the question was that users would barter with bitcoin; and the exchanges came out where you were able to purchase them for money. I am not sure where the price correlation came around; since report and stats show the price of BTC at an inititial .003 cents; and then most charts sho
< oxid> Hi Bitcoin users.

2018-04-20

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13049: [0.16] qa: Backports (0.16...Mf1804-qa16Backports) https://github.com/bitcoin/bitcoin/pull/13049
< bitcoin-git> [bitcoin] jnewbery opened pull request #13048: [tests] Fix feature_block flakiness (master...fix_feature_block_flakiness) https://github.com/bitcoin/bitcoin/pull/13048
< gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #13047: [trivial] Tidy blocktools.py (master...tidy_blocktools) https://github.com/bitcoin/bitcoin/pull/13047
< bitcoin-git> [bitcoin] skeees opened pull request #13046: [doc][trivial] no retargeting in regtest mode (master...doc-update) https://github.com/bitcoin/bitcoin/pull/13046
< bitcoin-git> [bitcoin] instagibbs opened pull request #13045: [p2p] getblock for 1-block reorgs in response to compact block message (master...cmpcttie) https://github.com/bitcoin/bitcoin/pull/13045
< gribble> https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #13043: [qt] OptionsDialog: add prune setting (master...2018/04/qt-prune) https://github.com/bitcoin/bitcoin/pull/13043
< bitcoin-git> [bitcoin] qshuai opened pull request #13042: Calculated nBits will be replaced by the following GetNextWorkRequire… (master...master) https://github.com/bitcoin/bitcoin/pull/13042
< bitcoin-git> [bitcoin] fanquake closed pull request #13040: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/13040
< bitcoin-git> [bitcoin] practicalswift opened pull request #13041: build: Add linter checking for accidental introduction of locale dependence (master...lint-locale-dependence) https://github.com/bitcoin/bitcoin/pull/13041
< bitcoin-git> [bitcoin] AsKayDevs opened pull request #13040: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/13040
< bitcoin-git> [bitcoin] laanwj opened pull request #13039: Add logging and error handling for file syncing (master...2018_04_fsync_noignore) https://github.com/bitcoin/bitcoin/pull/13039
< gribble> https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
< meshcollider> wumpus do you want to merge https://github.com/bitcoin-core/bitcoincore.org/pull/528 now its had plenty of review and has been sitting there for a while
< bitcoin-git> [bitcoin] charkala closed pull request #13037: Genesis (master...genesis) https://github.com/bitcoin/bitcoin/pull/13037
< bitcoin-git> [bitcoin] charkala opened pull request #13037: Genesis (master...genesis) https://github.com/bitcoin/bitcoin/pull/13037
< gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
< bitcoin-git> [bitcoin] macraix opened pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
< bitcoin-git> [bitcoin] sipa closed pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (master...logging-files) https://github.com/bitcoin/bitcoin/pull/13021
< bitcoin-git> bitcoin/master 8b262eb Pieter Wuille: Merge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files....
< bitcoin-git> bitcoin/master b77b6e2 Jim Posen: MOVEONLY: Move logging code from util.{h,cpp} to new files.
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b7b4b33c9...8b262eb2d80b
< gribble> https://github.com/bitcoin/bitcoin/issues/12885 | Reduce implementation code inside CScript by sipa · Pull Request #12885 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #13034: Introduce WalletManager (master...2018-04-walletmanager) https://github.com/bitcoin/bitcoin/pull/13034
< bitcoin-git> [bitcoin] jimpo closed pull request #11857: Build tx index in parallel with validation (master...txindex-refactor) https://github.com/bitcoin/bitcoin/pull/11857
< bitcoin-git> [bitcoin] jimpo opened pull request #13033: Build txindex in parallel with validation (master...txindex-refactor-take2) https://github.com/bitcoin/bitcoin/pull/13033

2018-04-19

< bitcoin-git> [bitcoin] kristapsk opened pull request #13032: Output values for "min relay fee not met" error (master...min-relay-fee-not-met-debug) https://github.com/bitcoin/bitcoin/pull/13032
< bitcoin-git> [bitcoin] sipsorcery opened pull request #13031: Fix for utiltime to compile with msvc. (master...msvc_gmtime) https://github.com/bitcoin/bitcoin/pull/13031
< gribble> https://github.com/bitcoin/bitcoin/issues/13021 | MOVEONLY: Move logging code from util.{h,cpp} to new files. by jimpo · Pull Request #13021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10794 | Add simple light-client mode (RPC only) by jonasschnelli · Pull Request #10794 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13021 | MOVEONLY: Move logging code from util.{h,cpp} to new files. by jimpo · Pull Request #13021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13002 | Do not treat bare multisig outputs as IsMine unless watched by sipa · Pull Request #13002 · bitcoin/bitcoin · GitHub
< gribble> gmaxwell was last seen in #bitcoin-core-dev 5 weeks, 0 days, 1 hour, and 59 seconds ago: <gmaxwell> it's not like you pay lower fees due to it.
<@wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11739: Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis (master...2017-09-p2sh-segwit-from-genesis) https://github.com/bitcoin/bitcoin/pull/11739
< bitcoin-git> bitcoin/master 5c31b20 Suhas Daftuar: [qa] Remove some pre-activation segwit tests...
< bitcoin-git> bitcoin/master 95749a5 Suhas Daftuar: Separate NULLDUMMY enforcement from SEGWIT enforcement...
< bitcoin-git> bitcoin/master ce65018 Suhas Daftuar: Use P2SH consensus rules for all blocks...
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b3a67eb0861...0a8b7b4b33c9
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13026: Fix include comment in src/interfaces/wallet.h (master...2018-04-fixincludecomment) https://github.com/bitcoin/bitcoin/pull/13026
< bitcoin-git> bitcoin/master 9b3a67e MarcoFalke: Merge #13026: Fix include comment in src/interfaces/wallet.h...
< bitcoin-git> bitcoin/master defffb3 João Barbosa: trivial: Improve include comment in src/interfaces/wallet.h
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c19986940869...9b3a67eb0861
< gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13024 | test: Add rpcauth pair that generated by rpcauth by ken2812221 · Pull Request #13024 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (master...fix_zapwallet_multiwallet_interaction) https://github.com/bitcoin/bitcoin/pull/13030
< bitcoin-git> [bitcoin] Sjors opened pull request #13029: Interpret absense of prune= as prune=1 if there are pruned blocks (master...2018/04/implicit_prune) https://github.com/bitcoin/bitcoin/pull/13029
< bitcoin-git> [bitcoin] promag opened pull request #13028: Make vpwallets usage thread safe (master...2018-04-cs_wallets) https://github.com/bitcoin/bitcoin/pull/13028
< gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12855: net: Minor accumulated cleanups (master...tjps_misc_cleans) https://github.com/bitcoin/bitcoin/pull/12855
< bitcoin-git> bitcoin/master c199869 Wladimir J. van der Laan: Merge #12855: net: Minor accumulated cleanups...
< bitcoin-git> bitcoin/master 2c084a6 Thomas Snider: net: Minor accumulated cleanups
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/39cf27faf324...c19986940869
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13025: Dead code removal (master...tjps_dead_code) https://github.com/bitcoin/bitcoin/pull/13025
< bitcoin-git> bitcoin/master 39cf27f MarcoFalke: Merge #13025: Dead code removal...
< bitcoin-git> bitcoin/master 1bf3f33 Thomas Snider: node: Removed unused wallet-related methods from the Node interface.
< bitcoin-git> bitcoin/master b382004 Thomas Snider: benchmark: Removed bench/perf.cpp
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/615f7c288414...39cf27faf324
< jtimon> fixed nits on https://github.com/bitcoin/bitcoin/pull/10757 , in case anyone was waiting for that to review
< bitcoin-git> [bitcoin] promag opened pull request #13026: Fix include comment in src/interfaces/wallet.h (master...2018-04-fixincludecomment) https://github.com/bitcoin/bitcoin/pull/13026
< fanquake> or #bitcoin-dev
< fanquake> bedotech ask in #bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/12855 | net: Minor accumulated cleanups by tjps · Pull Request #12855 · bitcoin/bitcoin · GitHub
< bedotech> Hi all, currently bitcoin-core what kind of wallet derivation implement? (for example BIP44 and so on...)
< bitcoin-git> [bitcoin] tjps opened pull request #13025: Dead code removal (master...tjps_dead_code) https://github.com/bitcoin/bitcoin/pull/13025
< kallewoof> aj: probably because I am loading both kinds manually, but -noincludeconf from cli does not cancel `includeconf=relative.conf` from bitcoin.conf
< kallewoof> It's ignored in bitcoin.conf too. `noincludeconf=1 \n includeconf=relative.conf` will still include relative.conf.

2018-04-18

< bitcoin-git> [bitcoin] ken2812221 opened pull request #13024: test: Add rpcauth pair that generated by rpcauth (master...rpc_test) https://github.com/bitcoin/bitcoin/pull/13024
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] skeees opened pull request #13023: Add unit tests for signals generated by ProcessNewBlock (master...event-tests) https://github.com/bitcoin/bitcoin/pull/13023
< bitcoin-git> [bitcoin] jamesob opened pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (master...2018-04-18-func-test-debug-log) https://github.com/bitcoin/bitcoin/pull/13022
< jamesob> MarcoFalke: doesn't look like it: https://travis-ci.org/bitcoin/bitcoin/jobs/367259625
< bitcoin-git> [bitcoin] Empact closed pull request #13019: validation: Consistently use FormatStateMessage (master...format-state-message) https://github.com/bitcoin/bitcoin/pull/13019
< gribble> https://github.com/bitcoin/bitcoin/issues/13000 | travis: Switch to xenial by MarcoFalke · Pull Request #13000 · bitcoin/bitcoin · GitHub
< jamesob> has there been any talk of moving from trusty to xenial on travis? It may be the case that we're unable to run bitcoin-qt using the functional test framework due to a bug in the version of openssl trusty uses
< gribble> https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jimpo opened pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (master...logging-files) https://github.com/bitcoin/bitcoin/pull/13021
< bitcoin-git> [bitcoin] Empact opened pull request #13020: Consistently log CValidationState on call failure (master...log-cvalidation-state) https://github.com/bitcoin/bitcoin/pull/13020
< bitcoin-git> [bitcoin] Empact opened pull request #13019: Trivial: Consistently use FormatStateMessage (master...format-state-message) https://github.com/bitcoin/bitcoin/pull/13019
< MarcoFalke> wumpus: minor nit: It says 15.99 on https://dev.visucore.com/bitcoin/doxygen/index.html ; I guess you'd have to run ./configure before generating the docs?
< gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact closed pull request #13018: Make AbortNode function static (master...abort-node-static) https://github.com/bitcoin/bitcoin/pull/13018
< bitcoin-git> [bitcoin] Empact opened pull request #13018: Make AbortNode function static (master...abort-node-static) https://github.com/bitcoin/bitcoin/pull/13018
< bitcoin-git> [bitcoin] promag opened pull request #13017: Add AddWallet, RemoveWallet, GetWallet and GetWallets (master...2018-04-vpwallets) https://github.com/bitcoin/bitcoin/pull/13017
< bitcoin-git> [bitcoin] Empact opened pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (master...g-failed-blocks) https://github.com/bitcoin/bitcoin/pull/13016
< bitcoin-git> [bitcoin] Empact closed pull request #12991: Remove unused default args to Invalid and DoS (master...remove-unused-default-args-dos) https://github.com/bitcoin/bitcoin/pull/12991
< gribble> https://github.com/bitcoin/bitcoin/issues/12985 | Windows: Avoid launching as admin when NSIS installer ends. by JeremyRand · Pull Request #12985 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12985: Windows: Avoid launching as admin when NSIS installer ends. (master...nsis-de-elevate) https://github.com/bitcoin/bitcoin/pull/12985