< harding>
For 0.15.0 users raring to go with segwit, is there any reason to discourage them from using, e.g., bitcoin-cli addwitnessaddress $( bitcoin-cli getnewaddress ) ?
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11238: Fix potential null deference and resource leaks (master...201708_fbinfer_fixes) https://github.com/bitcoin/bitcoin/pull/11238
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11237: Fixing division by zero in time remaining (master...201709_fix_estimated_time) https://github.com/bitcoin/bitcoin/pull/11237
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11236: Add note on translations to CONTRIBUTING.md (master...201709_translations_in_contributing) https://github.com/bitcoin/bitcoin/pull/11236
< bitcoin-git>
[bitcoin] aeyoll closed pull request #11235: Trivial: Fix a grammar mistake and a typo in the french translations (master...fix-french-translations) https://github.com/bitcoin/bitcoin/pull/11235
< bitcoin-git>
[bitcoin] aeyoll opened pull request #11235: Trivial: Fix a grammar mistake and a typo in the french translations (master...fix-french-translations) https://github.com/bitcoin/bitcoin/pull/11235
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10701: Remove the virtual specifier for functions with the override specifier (master...virtual-override) https://github.com/bitcoin/bitcoin/pull/10701
< bitcoin-git>
bitcoin/master 50fae68 MarcoFalke: Merge #10701: Remove the virtual specifier for functions with the override specifier...
< bitcoin-git>
bitcoin/master 1bcd442 practicalswift: Remove the virtual specifier for functions with the override specifier...
< bitcoin-git>
[bitcoin] practicalswift closed pull request #10972: [Qt] Check return value of addr.GetKeyID(keyid) on custom change address change (master...GetKeyID-assertion) https://github.com/bitcoin/bitcoin/pull/10972
< BlueMatt>
note: after #10387 (or some way to identify a node as full but pruned) we should stop accepting requests to fast-relay compact blocks pre-validation from non-full nodes. Its a drastic reduction in their security model and unlikely to be worth the tiny change in relay time. I'm especially concerned that some of the spv clients are going to implement compact blocks and then someone who had set up bitcoin core as a border/firewall node
< sipa>
bitcoin core supports non-segwit capable mining software; it just won't include any segwit txn for them
< sturles>
gmaxwell: I have been running the following for a few days, after reading your tip to sdaftuar about listing segwit transactions on top of the mempool: while sleep 10; do bitcoin-cli getblocktemplate | jq '.transactions | .[] | select(.hash != .txid) | .txid' >> swtxlog; done
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11136: Docs: Add python3 to list of dependencies on some platforms (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11136
< bitcoin-git>
bitcoin/master 108222b MarcoFalke: Merge #11136: Docs: Add python3 to list of dependencies on some platforms...
< bitcoin-git>
bitcoin/master 7bb5d30 danra: Add python3 to list of dependencies on some platforms...
< bitcoin-git>
[bitcoin] jnewbery closed pull request #11213: [trivial] [rpc] Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
< bitcoin-git>
[bitcoin] jnewbery opened pull request #11213: Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
< jtimon>
review beg https://github.com/bitcoin/bitcoin/pull/8994 now there's no exception for testing segwit.py and I left the loading of the parameters from aseparated file for later
2017-08-31
< tloriato>
Hello. I was testing the development of some ideas using the BitcoinCore wallet and the CLI's commands, and I came across the move command. Unfortunately the Docs states that "move will be removed in a later version of Bitcoin Core. " Does another command fulfils its duty? I've read the documentation on the official webpage and came out with empty hands. I don't want to develop an architecture around a command that will be e
< gmaxwell>
morcos: things that work are what people do, this is the lesson from history -- in bitcoin but also in every internet protocol. If we make it work we need to be ready to support it.
< gmaxwell>
We could take a position that we'll always do dual p2sh embedded and native (at least for the forseeable future) in parallel... but that will still be a risk for every wallet that isn't us, and for bitcoin core users with explicitly imported keys, when something thinks it can convert.
< bitcoin-git>
[bitcoin] danra opened pull request #11205: Make fixed CAmounts and related sanity function constexpr (master...refactor/constexpr-amount) https://github.com/bitcoin/bitcoin/pull/11205
< morcos>
instagibbs: yeah thanks, i'm fine with you tweeting whatever you want obviously, just not from Bitcoin Core Fee Bot. Sounds official.
< morcos>
if it's a good idea that survives rigorous peer review we should implement it in a Bitcoin Core tool or bitcoind and then we can tweet out the result
< morcos>
that is never something we would add to Bitcoin Core without a whole lot of complication to determine that that is a fee rate that would have legitimately been selected for the last block
< bitcoin-git>
[bitcoin] maaku opened pull request #11196: Switch memory_cleanse implementation to BoringSSL's to ensure memory clearing even with -lto (master...fix-memory-clense) https://github.com/bitcoin/bitcoin/pull/11196
< esotericnonsense>
not sure if this is offtopic for the channel. is there a discussion anywhere surrounding why bitcoin uses bdb 4.8? it seems to me that the only real concern with using 5.x is that users would not then be able to downgrade wallet software, but how likely/useful is that anyway (and also, providing recompiled binaries for older releases with 5.x seems possible now?)
< bitcoin-git>
[bitcoin] jnewbery closed pull request #10882: [Do not merge] Stop advancing best block and shutdown node if keypool drops below critical threshold (master...keypool_topup) https://github.com/bitcoin/bitcoin/pull/10882
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11193: Terminate string *pszExePath after readlink and before passing to operator << (master...null-terminate-after-readlink) https://github.com/bitcoin/bitcoin/pull/11193
< gmaxwell>
Can someone who understands twitter better explain to me what blocking someone does there... what would blocking someone on the bitcoin core account accomplish?
< cencen>
voila... bitcoin price is up!
< bitcoin-git>
[bitcoin] AkioNak opened pull request #11191: RPC: Improve help text and behavior of RPC-logging. (master...fix_rpc_logging) https://github.com/bitcoin/bitcoin/pull/11191
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11190: [tests] Remove unused imports (script.OP_0 and script.sha256) (master...remove-unused-import-op_0) https://github.com/bitcoin/bitcoin/pull/11190
< meshcollider>
15,999 stars on bitcoin repo, so close to 16k lol
< sipa>
#bitcoin or bitcoin.stackexchange.com
< tloriato>
Hello. Good morning/night. I was wondering where I could find a Javascript documentation on how to interact with a Bitcoin full node via JSON RPC? Sorry if I'm in the wrong place, I'm new to the space and trying to develop some things
< bitcoin-git>
[bitcoin] dooglus opened pull request #11184: Use IsMine() to check whether we own the custom change address... (0.15...change_ismine_0.15) https://github.com/bitcoin/bitcoin/pull/11184
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11178: Add iswitness parameter to decode- and fundrawtransaction RPCs (master...201708_rawtx_bool) https://github.com/bitcoin/bitcoin/pull/11178
< kallewoof>
Accidentally posted in #bitcoin-dev instead of here, but I got some initial mempool optimizing code for fee estimation in place that looks promising. Will check back when I have more profiling done.
< bitcoin-git>
[bitcoin] rawodb opened pull request #11177: Support for SegWit Addresses in RPC calls (master...pr/rpc_getsegwitaddresses) https://github.com/bitcoin/bitcoin/pull/11177
< bitcoin-git>
[bitcoin] laanwj closed pull request #10303: [bench] Include ms/blk stats in Connect* benchmarks. (master...bench-add-per-block-stats) https://github.com/bitcoin/bitcoin/pull/10303
< bitcoin-git>
bitcoin/master a473eff Karl-Johan Alm: [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp.
< bitcoin-git>
bitcoin/master f088a1b Wladimir J. van der Laan: Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks....
< bitcoin-git>
bitcoin/master 5f850b0 Karl-Johan Alm: [bench] Include ms/blk stats in Connect* benchmarks.
< bitcoin-git>
[bitcoin] laanwj opened pull request #11176: build: Rename --enable-experimental-asm to --enable-asm and enable by default (master...2017_08_non_experimental_asm) https://github.com/bitcoin/bitcoin/pull/11176
< bitcoin-git>
[bitcoin] laanwj closed pull request #11126: Acquire cs_main lock before cs_wallet during wallet initialization (master...pr/loadlock2) https://github.com/bitcoin/bitcoin/pull/11126
< bitcoin-git>
bitcoin/master df91e11 Wladimir J. van der Laan: Merge #11126: Acquire cs_main lock before cs_wallet during wallet initialization...
< bitcoin-git>
bitcoin/master de9a1db Russell Yanofsky: Acquire cs_main lock before cs_wallet during wallet initialization...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11169: [GUI] Make tabs toolbar no longer have a context menu (master...rm-hide-tabs) https://github.com/bitcoin/bitcoin/pull/11169
< bitcoin-git>
bitcoin/master 5b8af7b Wladimir J. van der Laan: Merge #11169: [GUI] Make tabs toolbar no longer have a context menu...
< bitcoin-git>
bitcoin/master e254830 Andrew Chow: Make tabs toolbar no longer have a context menu...
< kallewoof>
After seeing a bunch of complaints about fee estimation on Bitcoin Core I decided to do some profiling on how well the estimator is doing. My approach may be off, but it seems to be overshooting by a ton.
< bitcoin-git>
[bitcoin] AkioNak opened pull request #11173: RPC: Fix currency unit string in the help text (master...use_currency_unit_constant) https://github.com/bitcoin/bitcoin/pull/11173
< bitcoin-git>
[bitcoin] rawodb opened pull request #11170: Add label support to "addwitnessaddress" (master...pr/rpc_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/11170
< bitcoin-git>
[bitcoin] achow101 opened pull request #11169: [GUI] Make tabs toolbar no longer have a context menu (master...rm-hide-tabs) https://github.com/bitcoin/bitcoin/pull/11169
< bitcoin-git>
[bitcoin] danra opened pull request #11164: Fix boost headers included as user instead of system headers (master...fix/boost-system-includes) https://github.com/bitcoin/bitcoin/pull/11164
< bitcoin-git>
[bitcoin] danra opened pull request #11149: Use prefix instead of postfix increment/decrement for non-trivial typ… (master...prefix-increment) https://github.com/bitcoin/bitcoin/pull/11149
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
< bitcoin-git>
[bitcoin] wrapperband opened pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11133: Document assumptions that must be fulfilled to avoid division by zero (master...div0) https://github.com/bitcoin/bitcoin/pull/11133
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11132: [wallet] Document assumptions that must be fulfilled to avoid NULL pointer dereferences (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/11132