< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
< jnewbery>
so for now, keep the wallet tool as bitcoin-wallet, and when the separated bitcoin-wallet happens the tool commands will continue to work as expected?
< jnewbery>
That seems like a reasonable suggestion to me. Merge wallet tool functionality into the new new bitcoin-wallet when it happens
< ryanofsky>
i was just thinking that you have one binary called bitcoin-wallet that you use for all wallet stuff
< ryanofsky>
not sure what advantage there would be to having separate bitcoin-wallet and bitcoin-wallet-tool binaries
< provoostenator>
Ironically bitcoin-wallet was ryanofsky's idea in that comment :-)
< provoostenator>
So wallet-tool makes sense for this tool. Or even offline-wallet or something. The live wallet in a split code base, which connects to a node, could then be called bitcoin-wallet.
< provoostenator>
luke-jr in #10102 that new binary is called bitcoin-wallet
< provoostenator>
luke-jr jnewbery: I was thoroughly confused by this naming today while debugging the Makefile, because that actualy contains "bitcoin-wallet" as an intermediate stage for the wallet itself.
< luke-jr>
has there been any discussion previously about the binary name for bitcoin-wallet? seems strange to me.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
< bitcoin-git>
[bitcoin] Csi18nAlistairMann opened pull request #15387: docs: add "sections" info to example bitcoin.conf (master...confSections) https://github.com/bitcoin/bitcoin/pull/15387
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< mryandao>
hello, i've stumbled upon a threading exception with bitcoind and the program crashed. The exception message is "invalid argument in bitcoin scheduler"
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master a1b25e1 John Newbery: [wallet] Refactor ProcessImport()
< bitcoin-git>
bitcoin/master 4cac0dd John Newbery: [wallet] Add ProcessImportLegacy()
< bitcoin-git>
bitcoin/master d2b381c John Newbery: [wallet] Refactor ProcessImport() to call ProcessImportLegacy()
< bitcoin-git>
[bitcoin] benthecarman opened pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367
< benthecarman>
gmaxwell: my thinking was that you don't need to add all those to your automatic startup or have to run anything extra and bitcoin core can set it up for you
< benthecarman>
Hey, so I am making a PR to add an option to give the user the ability to have commands run after Bitcoin Core is finished starting up, the idea is so someone could have things like lnd or electrum-personal-server automatically run when Bitcoin Core starts. Is this something desirable to add or could it be too unsafe?
< jonasschnelli>
The other route would be compiling older Bitcoin Core versions and use that as base for file interoperability tests (including levelDb upgrades, etc.)
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365
< gmaxwell>
If we really wanted a blog post ... maybe instead we should have a blog post about bitcoin wallet security best practices, and this port thing could be mentioned somewhere in it. that would make sense. But alerting on this? I don't think so.
< wumpus>
I tend to agree with harding though "I'm a fan of updating the documentation in the Bitcoin Core docs/ directory and putting something into the release notes instead of publishing a long blog post that basically says that using a computer not under your exclusive control is unsafe"
< bitcoin-git>
bitcoin/master 6440e61 João Barbosa: qa: Drop RPC connection if --usecli
< bitcoin-git>
bitcoin/master d83d607 MarcoFalke: Merge #15350: qa: Drop RPC connection if --usecli
< bitcoin-git>
[bitcoin] promag opened pull request #15363: http: Exit the event loop as soon as there are no active events (master...2019-01-loopexit) https://github.com/bitcoin/bitcoin/pull/15363
< luke-jr>
[10:13:01] <echeveria> gwillen: to check if your filesystem supports UTF characters. <-- rather, to check that the Bitcoin Core code correctly handles the unicode
< echeveria>
phwalkr: this is normal. more a question for #bitcoin.
< gwillen>
... why does the test runner keep logs in files named "test_runner_₿_🏃_...", with a unicode bitcoin sign and a unicode running-man emoji
2019-02-06
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349