2018-10-26

< gmaxwell> I'm not speculating here, there is a continual stream of users who think that it will take years to sync. E.g. example I ran into today: https://bitcoin.stackexchange.com/questions/71147/bitcoin-core-delay-in-synching
< sipa> this channel is about discussing development on the Bitcoin Core software; you're welcome to idle or discuss relevant topics, but those don't include other Bitcoin clients, and certainly not trojan horse software
< oshithemoto> no one is writting here, just like idling here? gg I am an old developer, i did some decentraliced stuff bevor bitcoin, cordinated ddos attacs and i hope to find some old crew member, it was not sub7 crew but some of the ppl from this crew can help me find my old crew members I think one of them is satoshi nakamoto. his "old" nickname was "oso", he was a hacker and our crew name was #ratpack and he told my about a decen
< jarthur> Specifically Bitcoin Core development. #bitcoin-dev or #bitcoin may be better suited.
< oshithemoto> Anyone here who coded a bitcoin wallet in VB.NET?
< bitcoin-git> [bitcoin] practicalswift opened pull request #14585: Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...) (master...no-locale-surprises-please) https://github.com/bitcoin/bitcoin/pull/14585
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< jonasschnelli> I used bit 10 because other non bitcoin (core) stuff did use the below ones.
< gribble> https://github.com/bitcoin/bitcoin/issues/14123 | gui: Add GUIUtil::bringToFront by promag · Pull Request #14123 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ken2812221 closed pull request #13827: [WIP] depends: Add native_nsis to support unicode (master...depends-nsis) https://github.com/bitcoin/bitcoin/pull/13827
< andytoshi> rust-jsonrpc is better but it's still not where i want it to be. afaik there is no HTTP client library for rust that doesn't have a bad dependency story. we would need to write our own to do bitcoin-cli in rust.
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Wallet and Window menus by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Wallet and Window menus by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< harding> wumpus: that's what I remember being done for all the other 0.*.*.1 releases, and it's easiest for the website if there are release notes because, as you say, it's the same release process. It is possible (and pretty easy) to have binaries split across two directories on both BitcoinCore.org and Bitcoin.org as we both use the same mechanism to allow for easy changes in the filenames across releases, so let me know if you ever do
< wumpus> harding: (2) the release notes are here, it's really short: https://github.com/bitcoin/bitcoin/blob/0.17/doc/release-notes.md
< harding> For 0.17.0.1, a few questions related to what changes I might need to make to BitcoinCore.org for it: (1) is only the MacOS binary going to be added to /bin/bitcoin-core-0.17.0.1/ or will there be .0.1 versions for all platforms? (2) Are there going to be release notes for it? (3) Do we want a blog post about it on the home page?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13515: travis: Enable qt for all jobs (master...travis_qt) https://github.com/bitcoin/bitcoin/pull/13515
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae85c8d28bee...f4e4ea1ceecf
< bitcoin-git> bitcoin/master 3387bb0 Chun Kuan Lee: travis: avoid timeout without saving caches, also enable all qt
< bitcoin-git> bitcoin/master f4e4ea1 MarcoFalke: Merge #13515: travis: Enable qt for all jobs...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14568: build: Fix Qt link order for Windows build (master...win-qt-fix) https://github.com/bitcoin/bitcoin/pull/14568
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d50c996a147d...ae85c8d28bee
< bitcoin-git> bitcoin/master fbaccbf Chun Kuan Lee: build: Fix Qt link order for Windows build
< bitcoin-git> bitcoin/master ae85c8d MarcoFalke: Merge #14568: build: Fix Qt link order for Windows build...
< bitcoin-git> [bitcoin] laanwj closed pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d4541508b98...d50c996a147d
< bitcoin-git> bitcoin/master ed2e183 João Barbosa: Remove fs::relative call and fix listwalletdir tests...
< bitcoin-git> bitcoin/master d50c996 Wladimir J. van der Laan: Merge #14561: Remove fs::relative call and fix listwalletdir tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/754a00d55f30...9d4541508b98
< bitcoin-git> bitcoin/master 3be209d João Barbosa: rpc: Always throw in getblockstats if -txindex is required...
< bitcoin-git> bitcoin/master 9d45415 Wladimir J. van der Laan: Merge #14518: rpc: Always throw in getblockstats if -txindex is required...
< bitcoin-git> [bitcoin] laanwj closed pull request #14576: Release 0.17.0.1 (0.17...2018_10_release_0.17.0.1) https://github.com/bitcoin/bitcoin/pull/14576
< gribble> https://github.com/bitcoin/bitcoin/issues/14561 | Remove fs::relative call and fix listwalletdir tests by promag · Pull Request #14561 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] merland opened pull request #14583: docs: Textual improvements in build docs (master...proof-read-build-docs) https://github.com/bitcoin/bitcoin/pull/14583
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof opened pull request #14582: wallet: try -avoidpartialspends mode and use its result if fees do not change (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
< bitcoin-git> [bitcoin] fanquake closed pull request #12656: Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer (master...vagrant) https://github.com/bitcoin/bitcoin/pull/12656
< bitcoin-git> [bitcoin] fanquake closed pull request #14581: 2018/08/spv rpc (master...2018/08/spv-rpc) https://github.com/bitcoin/bitcoin/pull/14581
< bitcoin-git> [bitcoin] sunshineYPH opened pull request #14581: 2018/08/spv rpc (master...2018/08/spv-rpc) https://github.com/bitcoin/bitcoin/pull/14581
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/eb2cc84a31fb...f13041f17b08
< bitcoin-git> bitcoin/0.17 f9fc08c fanquake: travis: Pin flake8 version to 3.5.0
< bitcoin-git> bitcoin/0.17 f13041f MarcoFalke: Merge #14579: [0.17] travis: Pin flake8 version to 3.5.0...
< fanquake> Looks like they are green now https://travis-ci.org/bitcoin/bitcoin/jobs/446468018
< bitcoin-git> [bitcoin] fanquake opened pull request #14579: [0.17] travis: Pin flake8 version to 3.5.0 (0.17...fix-the-linters) https://github.com/bitcoin/bitcoin/pull/14579
< gribble> https://github.com/bitcoin/bitcoin/issues/14579 | [0.17] travis: Pin flake8 version to 3.5.0 by fanquake · Pull Request #14579 · bitcoin/bitcoin · GitHub

2018-10-25

< gmaxwell> echeveria: I personally liked the one company going around telling everyone that bitcoin core constantly crashed, and then got shut up by a developer offering them a sizable bet that they couldn't report any crash...
< echeveria> some of this comes from parties like blockchain.info who have frequently gone around conferences repeating stories of how they tried so hard to contribute to bitcoin core and were rejected for their efforts.
< gmaxwell> (I very much want their input for sure, but if they don't provide it.. they don't provide it. Unfortunately, my expirence with many bitcoin companies is that they have executives that have never actually used software in a commercial context before, much less open source... and they treat it like the android play store... an app doesn't do what you want, you swap out for another one).
< echeveria> from my experience people making a lot of these sort of claims don’t actually use the software at all, so keep that in mind too. I’ve had people sit and insist to me that the bitcoin wallet has all sorts of stupid behaviour I full well know it doesn’t.
< kallewoof> gmaxwell: sdaftuar spoke against the feature in the original PR here: https://github.com/bitcoin/bitcoin/pull/12257#discussion_r204168100 ("I'm not sure that -avoidpartialspends works very well on wallets that have substantial address reuse, in particular I think you can devolve into cases where you'd produce giant transactions that take forever to sign and would never pass policy (or consensus) limits, in extreme cases.")
< esotericnonsense> wumpus: no just write the bits of qemu you need to emulate bitcoin-cli on riscv.
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: -avoidreuse feature for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< esotericnonsense> just write bitcoin-cli in bash.
< gmaxwell> Maybe the rust-bitcoin people have already done it.
< wumpus> let's write bitcoin-cli in rust
< gmaxwell> I don't think it was bad to raise, we might end up back on it if later bitcoin-cli is blocking disabling tcp rpc by default, and libevent still can't handle using domain sockets for the -cli case.
< esotericnonsense> someone using bitcoin-cli in scripts ... argh\
< sipa> my preference is just replacing the libevent http code in bitcoin-cli with hand-written HTTP though :)
< sipa> gmaxwell: generally i agree with that... but i also think bitcoin-cli is very simple :)
< gmaxwell> yea, if we wanted to rewrite anything bitcoin-cli would be it! :)
< wumpus> it woult make zero difference for bitcoin-cli wrt performance
< gmaxwell> I don't think thats absurd on its face, but: it would probably be a massive slowdown for those users who do processing using bitcoin-cli in scripts, and would suffer the standard "throwaway and rewrite software issues" -- the complexity of existing code is effectively all the accrewed knoweldge built from years and years of use... and that it probably gets right lots of behaviors none of us
< wumpus> rewriting bitcoin-cli in python, certainly using the code already in the test framework, would be trivial, but why?
< esotericnonsense> gmaxwell: i'm not suggesting it but rather responding to wumpus'/sipa message above about bitcoin-cli not needing to be a full http client and inventing some thing
< sipa> afaik the origin bitcoin-cli code was just some printf statements into a socket
< esotericnonsense> what bitcoin-cli?
< esotericnonsense> all of bitcoin? :D:D
< gmaxwell> I think esotericnonsense is suggesting bitcoin-cli get replaced with a python tool?
< esotericnonsense> WRT bitcoin-cli and http/domain sockets/etc
< esotericnonsense> obviously it's so that you can stick your bitcoin rpc behind nginx and put it on https://myexchange.com/api
< bitcoin-git> [bitcoin] hebasto opened pull request #14577: qt: Cleanup `textInteractionFlags` for `QLabel` (master...20181025-textInteractionFlags) https://github.com/bitcoin/bitcoin/pull/14577
< wumpus> (why does bitcoin use http? I do not know, I guess JSON-RPC is marginally better than rolling yet another custom protocol, though the line-based JSON RPC of c-lightning is *pretty neat*)
< sipa> wumpus: you may hate this... but given that bitcoin-cli is specific to bitcoind, it probably doesn't need to actually implement full HTTP; just whatever subset is needed for bitcoind
< bitcoin-git> [bitcoin] laanwj opened pull request #14576: Release 0.17.0.1 (0.17...2018_10_release_0.17.0.1) https://github.com/bitcoin/bitcoin/pull/14576
< gmaxwell> sipa: e.g. will it crash under concurrent request load, etc. thats something we'd probably find out really fast with bitcoin-cli switched to it.
< sipa> gmaxwell: any type of issue you're worried about in particular w.r.t. unix socket support but excluding bitcoin-cli initially?
< gmaxwell> jonasschnelli: it's hard to test extensively without bitcoin-cli support, I'd worry about it bitrotting.
< jarthur> bitcoin-cli support is what was held up by proposed upstream libevent work
< jarthur> While some folks are still here, I'm curious if any of you would be against an incremental introduction of unix domain sockets for the RPC API. e.g. release with just server support first, no bitcoin-cli support and no official work around abstract sockets. Server support may be exhumable from wumpus PR #9919.
< gribble> https://github.com/bitcoin/bitcoin/issues/9919 | UNIX sockets support for RPC by laanwj · Pull Request #9919 · bitcoin/bitcoin · GitHub
< jnewbery> sorry I missed the meeting. On the topic of testing RCs, the optech newsletter has action items each week, which included 'allocate time to test Bitcoin Core RC' for the weeks that we had RCs (eg https://bitcoinops.org/en/newsletters/2018/09/11/). If there are more specific instructions, let us know and we can help spread them.
< gribble> https://github.com/bitcoin/bitcoin/issues/5885 | [WIP] Replace OpenSSL PRNG with built-in Fortuna implementation by sipa · Pull Request #5885 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10299 | Remove OpenSSL by sipa · Pull Request #10299 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
< luke-jr> how about I make a Twitter account for posting experimental releases of Core, Knots, and other reputable Bitcoin projects? (Electrum, etc?)
< gribble> https://github.com/bitcoin/bitcoin/issues/14416 | Fix OSX dmg issue (10.12 to 10.14) by jonasschnelli · Pull Request #14416 · bitcoin/bitcoin · GitHub
< jonasschnelli> I think we should release 0.17.0.1 (osx only) to mitigate the non opening DMG issue with 0.17 (https://github.com/bitcoin/bitcoin/pull/14416)
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< esotericnonsense> anyway, this is not bitcoin core dev, sorry :P
< wumpus> yes, I guess the threat model for bitcoin is somewhat different than say, ssh
< esotericnonsense> so yeah if you have the list it would probably take a few seconds to hit them all and see if they're not bitcoin. :P
< luke-jr> harding: well, I mean perhaps some other software is listening in 8332 while Bitcoin isn't
< wumpus> or maybe they found an exploit in bitcoin-cli and are waiting for you to use it on them :-)
< harding> luke-jr: the list of IPs I scan cam from bitnodes, which I think currently filters out Bitcoin Cash nodes. Obviously so were probably spy nodes and the like.
< luke-jr> I wonder if these 8332s aren't even bitcoin itself?
< esotericnonsense> luke-jr: is it possible to get a bitcoin-like response back with invalid auth
< esotericnonsense> e.g. if you had bitcoind, bitcoin-qt and bitcoin-qt had perms on the socket but other than bitcoin-qt only root did
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< wumpus> an alert RPC, simple as that: https://github.com/laanwj/bitcoin/commit/ace137ff25ab4c7c2a521abe9ba2af0d8af32ec2 (could theoretically make the style flags configurable to send errors etc as well but anyhow xD)
< wumpus> I have various scripts that interface to bitcoin and I use them with the GUI too.
< esotericnonsense> personally i'd probably ask why bitcoin-qt even has the ability to enable RPC
< wumpus> what, if you want to enable RPC in bitcoin-qt you should be able to
< esotericnonsense> i've just jumped in here and stuck some chat in #bitcoin
< gmaxwell> harding: probably making bitcoin make its own template config file when one doesn't exist would help.
< harding> I guess when .bitcoin is created, a default bitcoin.conf could be created with some normal-to-change options and basic comment documentation. I think you'd want to keep it short, rather than providing every possible option, so that people aren't tempted to delete the whole thing and replace it with a random config from the Wiki.
< wumpus> in any case I checked: bitcoin-qt still doesn't enable RPC server by default
< gmaxwell> echeveria crawled the internet and found something like 3000 bitcoin rpc ports listening, which would be a substantial percentage of all p2p listening nodes.
< harding> Looked up the conversation on #bitcoin, the user didn't explicitly say that he was using the default config, so he could've had -server=1.
< harding> I did test on Linux, and bitcoin-qt doesn't do RPC there by default.
< wumpus> harding: setting server=1 in bitcoin.conf should be the only way to enable it with bitcoin-qt
< harding> wumpus: someone in #bitcoin the other day said that RPC was enabled by default on Windows in bitcoin-qt. That surprised me, as I didn't even know bitcoin-qt could expose RPC (I thought you needed to use bitcoind for that). I didn't think to mention it here because I didn't realize that not running RPC with bitcoin-qt was supposed to be a security feature.
< wumpus> I think what discourages people from even trying browser-based attacks is that bitcoin-qt by default has the RPC server disabled, so most unknowning users won't be affected, the people that enable RPC will generally be more technical and hopefully be careful what they allow
< Sentineo> but someoone might try to give you a browser which does not check CORS and connect to your bitcoin through rpc?
< bitcoin-git> [bitcoin] promag opened pull request #14573: qt: Add Wallet and Window menus (master...2018-10-overhaul-menus) https://github.com/bitcoin/bitcoin/pull/14573
< promag> https://github.com/bitcoin/bitcoin/blob/0.17/.travis.yml#L151 should be `travis_retry pip install flake8==3.5.0`
< wumpus> the 0.17 issue is a linter issue?!? https://travis-ci.org/bitcoin/bitcoin/jobs/446184576
< luke-jr> frankly, I think we bumped univalue too prematurely (and ended up with an unnecessary/unreasonable fork in bitcoin/univalue as a result)
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.17: https://github.com/bitcoin/bitcoin/commit/eb2cc84a31fb923b2b25b979682904cb81edec7e
< bitcoin-git> bitcoin/0.17 eb2cc84 Jonas Schnelli: [macOS] Remove DS_Store WindowBounds bytes object...
< promag> wumpus: let me know if https://github.com/bitcoin/bitcoin/pull/14561/files lgty
< bitcoin-git> [bitcoin] laanwj closed pull request #14416: Fix OSX dmg issue (10.12 to 10.14) (master...2018/10/osx_dmg) https://github.com/bitcoin/bitcoin/pull/14416
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/613fc95ee4ea...754a00d55f30
< bitcoin-git> bitcoin/master 43719e0 Jonas Schnelli: [macOS] Remove DS_Store WindowBounds bytes object
< bitcoin-git> bitcoin/master 754a00d Wladimir J. van der Laan: Merge #14416: Fix OSX dmg issue (10.12 to 10.14)...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14571: [tests] Test that nodes respond to getdata with notfound (master...Mf1810-qaNotfound) https://github.com/bitcoin/bitcoin/pull/14571
< gribble> https://github.com/bitcoin/bitcoin/issues/14561 | Remove fs::relative call and fix listwalletdir tests by promag · Pull Request #14561 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14569: travis: Print characters per 9 min to avoid timeout (master...travis-avoid-timeout) https://github.com/bitcoin/bitcoin/pull/14569
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14568: build: Fix Qt link order for Windows build (master...win-qt-fix) https://github.com/bitcoin/bitcoin/pull/14568
< ken2812221> Gitian build for Windows is fail on master branch, I can confirm this with WSL. https://bitcoin.jonasschnelli.ch/build/858
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof closed pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14566: 0.17: qa backports (0.17...Mf1810-qaBackports) https://github.com/bitcoin/bitcoin/pull/14566
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #14565: Overhaul importmulti logic (master...201810_refactor_importmulti) https://github.com/bitcoin/bitcoin/pull/14565
< bitcoin-git> [bitcoin] jameshilliard opened pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564

2018-10-24

< bitcoin-git> [bitcoin] instagibbs closed pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
< bitcoin-git> [bitcoin] instagibbs opened pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563
< michagogo> Hm. I just tried fixing https://github.com/bitcoin-core/gitian.sigs/issues/658
< instagibbs> hmm that one is giving some other error, but here's tip of 0.17 https://travis-ci.org/bitcoin/bitcoin/jobs/443960300
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< bitcoin-git> [bitcoin] Neeshmacpaul opened pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b88f67e0bcc...613fc95ee4ea
< bitcoin-git> bitcoin/master 4dca7d0 Chun Kuan Lee: appveyor: Enable multiwallet test
< bitcoin-git> bitcoin/master 613fc95 MarcoFalke: Merge #14559: appveyor: Enable multiwallet tests...
< bitcoin-git> [bitcoin] promag closed pull request #13637: wallet: Add GetBalances to calculate all balances (master...2018-06-wallet-getbalance) https://github.com/bitcoin/bitcoin/pull/13637
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929
< bitcoin-git> [bitcoin] laanwj closed pull request #14320: [bugfix] wallet: Fix duplicate fileid detection (master...2018-09-25-wallet-duplicate-fileid-fix) https://github.com/bitcoin/bitcoin/pull/14320
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6241eb3224d9...2b88f67e0bcc
< bitcoin-git> bitcoin/master 2d796fa Chun Kuan Lee: wallet: Fix duplicate fileid
< bitcoin-git> bitcoin/master 4ea7732 Chun Kuan Lee: tests: add test case for loading copied wallet twice
< bitcoin-git> bitcoin/master 2b88f67 Wladimir J. van der Laan: Merge #14320: [bugfix] wallet: Fix duplicate fileid detection...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14504: tests: show the progress of functional tests (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a74ed3a05b27...6241eb3224d9
< bitcoin-git> bitcoin/master 96c509e Isidoro Ghezzi: show the progress of functional test...
< bitcoin-git> bitcoin/master 6241eb3 MarcoFalke: Merge #14504: tests: show the progress of functional tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #14453: rpc: Fix wallet unload during walletpassphrase timeout (master...2018-10-unload-unlocked-wallet) https://github.com/bitcoin/bitcoin/pull/14453
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9886590116b1...a74ed3a05b27
< bitcoin-git> bitcoin/master 321decf João Barbosa: rpc: Fix wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master 8907df9 João Barbosa: qa: Ensure wallet unload during walletpassphrase timeout
< bitcoin-git> bitcoin/master a74ed3a Wladimir J. van der Laan: Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout...
< luke-jr> not building bitcoin-qt seems a bit extreme though; might make sense to refactor configure to just change the bip70 option
< fanquake> wumpus are we meant to be able to build bitcoin-qt without protobuf after #14451?
< gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support (master...deprecate-bip70) https://github.com/bitcoin/bitcoin/pull/14451
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e15fa16cd3b...9886590116b1
< bitcoin-git> bitcoin/master 9dcf6c0 Wladimir J. van der Laan: build: Add --disable-bip70 configure option...
< bitcoin-git> bitcoin/master 38b9850 Wladimir J. van der Laan: qt: cleanup: Move BIP70 functions together in paymentserver...
< bitcoin-git> bitcoin/master fbb643d James Hilliard: Add BIP70 deprecation warning
< bitcoin-git> [bitcoin] promag closed pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
< wumpus> loool https://github.com/bitcoin/bitcoin/pull/14504#issuecomment-431169025 apparently a spinner makes for a "boring user experience" of the tests, happy that running the tests is so exciting now
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dda5fdf64ca...2e15fa16cd3b
< bitcoin-git> bitcoin/master 585b47c João Barbosa: rpc: Prevent concurrent savemempool
< bitcoin-git> bitcoin/master 2e15fa1 Wladimir J. van der Laan: Merge #12842: Prevent concurrent savemempool...
< bitcoin-git> [bitcoin] laanwj closed pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842
< bitcoin-git> [bitcoin] karel-3d closed pull request #14502: Rpc help helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14296: [wallet] Remove addwitnessaddress (master...remove_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/14296
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/e895fdc9fc83...9dda5fdf64ca
< bitcoin-git> bitcoin/master 67d7d67 John Newbery: [test] Fix flake8 warnings in tests...
< bitcoin-git> bitcoin/master bdefc97 John Newbery: [tests] Remove deprecated addwitnessaddress call from feature_nulldummy...
< bitcoin-git> bitcoin/master 3cf77f0 John Newbery: [tests] Remove deprecated addwitnessaddress call from wallet_dump.py...
< bitcoin-git> [bitcoin] practicalswift closed pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< bitcoin-git> [bitcoin] promag opened pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561
< gribble> https://github.com/bitcoin/bitcoin/issues/14559 | appveyor: Enable multiwallet tests by ken2812221 · Pull Request #14559 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5473e255f687...e895fdc9fc83
< bitcoin-git> bitcoin/master 1c7e25d practicalswift: wallet: Add missing locks
< bitcoin-git> bitcoin/master dee4292 practicalswift: wallet: Add Clang thread safety analysis annotations
< bitcoin-git> bitcoin/master 37b2538 practicalswift: Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634
< promag> ken2812221: I don't understand what you mean here https://github.com/bitcoin/bitcoin/pull/14552#issuecomment-432409103
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559
< bitcoin-git> [bitcoin] achow101 opened pull request #14558: rpc: Require solvability in importmulti if importing more than the scriptPubKey (master...importmulti-solvability) https://github.com/bitcoin/bitcoin/pull/14558
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14444: Add compile time checking for cs_main locks which we assert at run time (master...move-runtime-checking-to-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/14444
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/94cf1ec94821...5473e255f687
< bitcoin-git> bitcoin/master 0089905 practicalswift: Add compile time checking for cs_main locks which we assert at run time
< bitcoin-git> bitcoin/master 5473e25 MarcoFalke: Merge #14444: Add compile time checking for cs_main locks which we assert at run time...

2018-10-23

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14417: Fix listreceivedbyaddress not taking address as a string (master...fix-rpc-calls-not-taking-valid-strings) https://github.com/bitcoin/bitcoin/pull/14417
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3668bb335c6a...94cf1ec94821
< bitcoin-git> bitcoin/master d4d70ed Eric Scrivner: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> bitcoin/master 94cf1ec MarcoFalke: Merge #14417: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14468: [wallet] Deprecate generate RPC method (master...deprecate_generate) https://github.com/bitcoin/bitcoin/pull/14468
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3f377daaa86...3668bb335c6a
< bitcoin-git> bitcoin/master c269209 John Newbery: [tests] Small fixups before deprecating generate...
< bitcoin-git> bitcoin/master aab8172 John Newbery: [tests] Add generate method to TestNode...
< bitcoin-git> bitcoin/master c9f0295 John Newbery: [wallet] Deprecate the generate RPC method
< bitcoin-git> [bitcoin] hebasto opened pull request #14556: qt: Fix bug #13299 (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
< bitcoin-git> [bitcoin] jimpo opened pull request #14555: Move util files to directory (master...util-cleanup) https://github.com/bitcoin/bitcoin/pull/14555
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14554: qt: Remove unused `adjustedTime` parameter (master...20181023-unused-adjustedtime) https://github.com/bitcoin/bitcoin/pull/14554
< bitcoin-git> [bitcoin] merland opened pull request #14553: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14552: wallet: throw an error if user load the wallet file by different ways (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
< bitcoin-git> [bitcoin] laanwj closed pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
< bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
< bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
< bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539

2018-10-22

< bitcoin-git> [bitcoin] sipa closed pull request #14150: Add key origin support to descriptors (master...201807_minedesc_origin) https://github.com/bitcoin/bitcoin/pull/14150
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c25409d6851...0a8f519a0626
< bitcoin-git> bitcoin/master 2c6281f Pieter Wuille: Add key origin support to descriptors
< bitcoin-git> bitcoin/master ff37459 Pieter Wuille: Add tests for key origin support
< bitcoin-git> bitcoin/master 8afb166 Pieter Wuille: Update documentation to incude origin information
< bitcoin-git> [bitcoin] instagibbs opened pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
< bitcoin-git> [bitcoin] practicalswift closed pull request #13766: Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. (master...initialize-members-in-initialization-list) https://github.com/bitcoin/bitcoin/pull/13766
< bitcoin-git> [bitcoin] practicalswift closed pull request #12984: logs: Make the columns in subsequent UpdateTip log entries horizontally aligned (master...attention-to-detail) https://github.com/bitcoin/bitcoin/pull/12984
< Wadexs> Bitcoin testnet exchange
< echeveria> might be best to continue this in #bitcoin then.
< sanket1729> This code appears to reject blocks 2 hours into future based on local time. https://github.com/bitcoin/bitcoin/blob/5c25409d6851182c5e351720cee36812c229b77a/src/validation.cpp#L3245 . What am I missing?
< sanket1729> Hello, can anyone comment on the following claim. "If there is a clock drifts more than 2 hours and and there are 2 chains similar PoW, then we can have a fork where both chains think they are longest in their own view. So, bitcoin network operates on some synchronous assumptions."
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14540 | Enable flake8 rule E231. by jbampton · Pull Request #14540 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540

2018-10-21

< bitcoin-git> [bitcoin] jbampton opened pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540
< bitcoin-git> [bitcoin] charlesrocket opened pull request #14539: add Apple SDK download and checksum (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
< wumpus> if you're looking for a specific block, you could check block explorers if they have it, or ask here or in #bitcoin
< sanket1729> Hello, I have one small quick question. Does bitcoin core ever prune orphan blocks? I mean do all full nodes have a very old orphan block, say from 2014?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14161: doc/descriptors.md tweaks (master...pr/ddoc) https://github.com/bitcoin/bitcoin/pull/14161
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/73cddb36a88f...5c25409d6851
< bitcoin-git> bitcoin/master eb49412 Russell Yanofsky: doc/descriptors.md tweaks...
< bitcoin-git> bitcoin/master eeeaa29 Russell Yanofsky: descriptors.md: Refer to descriptors as describing instead of matching
< bitcoin-git> bitcoin/master 5c25409 MarcoFalke: Merge #14161: doc/descriptors.md tweaks...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75795603dd2f...73cddb36a88f
< bitcoin-git> bitcoin/master 8640631 Mason Simon: docs: Document lint tests
< bitcoin-git> bitcoin/master 73cddb3 MarcoFalke: Merge #14526: docs: Document lint tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14309: Use non-throwing type-safe ChainType where possible (master...Mf1809-chainType) https://github.com/bitcoin/bitcoin/pull/14309
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96c409c919b9...75795603dd2f
< bitcoin-git> bitcoin/master 97ddc60 practicalswift: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)
< bitcoin-git> bitcoin/master 7579560 MarcoFalke: Merge #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909

2018-10-20

< bitcoin-git> [bitcoin] jbampton opened pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< bitcoin-git> [bitcoin] mrwhythat opened pull request #14533: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/14533
< bitcoin-git> [bitcoin] practicalswift reopened pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
< bitcoin-git> [bitcoin] luke-jr opened pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git> [bitcoin] promag opened pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14530: scripted-diff: Use RPCHelpMan on RPCs with no args (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] laanwj closed pull request #14527: qa: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6746a8951923...96c409c919b9
< bitcoin-git> bitcoin/master fadffae MarcoFalke: Revert "Make qt wallet test compatible with qt4"...
< bitcoin-git> bitcoin/master 96c409c Wladimir J. van der Laan: Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"...
< fanquake> Chris_Stewart_5 See the channel history, we've forked rapidcheck to bitcoin-core, could be a chance to use the new make install method etc. You should have gotten invite to /bitcoin and /bitcoin-core as well.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14528: travis: Compile once on xenial (master...Mf1810-travisXenial) https://github.com/bitcoin/bitcoin/pull/14528
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14527: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< wumpus> invited to bitcoin and bitcoin-core at least
< wumpus> repo created, see https://github.com/bitcoin-core/rapidcheck, who needs commit access?
< fanquake> wumpus thanks. More context in my comment here: https://github.com/bitcoin/bitcoin/pull/14430#issuecomment-431555605
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< fanquake> wumpus Would we be able to fork emil-e/rapidcheck to github.com/bitcoin-core/?
< bitcoin-git> [bitcoin] laanwj closed pull request #14497: docs: Add doc/bitcoin-conf.md (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d433239a8d54...6746a8951923
< bitcoin-git> bitcoin/master 1fb3c16 Hennadii Stepanov: Add `doc/bitcoin-conf.md`
< bitcoin-git> bitcoin/master 6746a89 Wladimir J. van der Laan: Merge #14497: docs: Add doc/bitcoin-conf.md...
< gribble> https://github.com/bitcoin/bitcoin/issues/14497 | docs: Add doc/bitcoin-conf.md by hebasto · Pull Request #14497 · bitcoin/bitcoin · GitHub
< midnightmagic> still burns me atmel dropped avr for arm. wumpus: well if it does anything interesting with the bitcoin node, I know I at least would love to hear about it.
< wumpus> yes, bitcoin runs ok, syncing doesn't go super fast but it was a bit faster than most ARM boards from a few years ago I've tried on
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14456: test: forward timeouts properly in send_blocks_and_test (master...2018-10-test-forward-timeouts) https://github.com/bitcoin/bitcoin/pull/14456