< bitcoin-git>
[bitcoin] fanquake closed pull request #14463: Reduce usage of the platform dependent `unsigned int` type (master...20181011-rbf-nseq) https://github.com/bitcoin/bitcoin/pull/14463
2018-11-01
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #14377: check that a separator is found for psbt inputs, outputs, and global map (master...fix-psbt-seps) https://github.com/bitcoin/bitcoin/pull/14377
< bitcoin-git>
bitcoin/master 4fb3388 Andrew Chow: check that a separator is found for psbt inputs, outputs, and global map
< bitcoin-git>
bitcoin/master 51e5ef3 Wladimir J. van der Laan: Merge #14377: check that a separator is found for psbt inputs, outputs, and global map...
< gribble>
https://github.com/bitcoin/bitcoin/issues/14377 | check that a separator is found for psbt inputs, outputs, and global map by achow101 · Pull Request #14377 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master f69d922 Wladimir J. van der Laan: Merge #14592: doc: Add external interface consistency guarantees...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14631: [tests] Move deterministic address import to setup_nodes (master...deprecate_generate2) https://github.com/bitcoin/bitcoin/pull/14631
< bitcoin-git>
[bitcoin] laanwj closed pull request #14197: [psbt] Convert non-witness UTXOs to witness if witness sig created (master...psbt-utxos) https://github.com/bitcoin/bitcoin/pull/14197
< bitcoin-git>
bitcoin/master 0e6de3a Martin Erlandsson: added details about commit messages
< bitcoin-git>
bitcoin/master d38a509 Wladimir J. van der Laan: Merge #14600: docs: Clarify commit message guidelines...
< gribble>
https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] murrayn opened pull request #14628: Trivial: Rename misleading 'defaultPort' to 'rpc_port' (master...rpc_port) https://github.com/bitcoin/bitcoin/pull/14628
< bitcoin-git>
[bitcoin] merland closed pull request #14553: [wip] qt: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
< wumpus>
you're working on rust? why aren't you in #rust-bitcoin
< esotericnonsense>
well, I have a working rust bitcoin-cli. it's not bitcoin-cli, bitcoin-cli has all sorts of edge cases i can't be bothered to emulate because there's ~0 chance of getting a rust binary in the repo anyway.
< bitcoin-git>
bitcoin/master f6ed748 MeshCollider: Add SegWit support to importmulti with some ProcessImport cleanup
< bitcoin-git>
bitcoin/master 353c064 MeshCollider: Fix typo in test_framework/blocktools
< bitcoin-git>
[bitcoin] merland opened pull request #14619: tests: Fix value display name in test_runner help text (master...test-runner-fix) https://github.com/bitcoin/bitcoin/pull/14619
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14618: rpc: Make HTTP RPC debug logging more informative (master...limit-rpc-request-logging) https://github.com/bitcoin/bitcoin/pull/14618
< bitcoin-git>
[bitcoin] murrayn opened pull request #14617: FreeBSD: Document Python 3 requirement for 'gmake check' (master...freebsd-test-doc) https://github.com/bitcoin/bitcoin/pull/14617
< sipa>
MarcoFalke: how is appveyor set up? there is a webhook from the bitcoin/bitcoin repo to appveyor, but how does appveyor get to report a CI status back?
< bitcoin-git>
[bitcoin] achow101 opened pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git>
[bitcoin] JBaczuk opened pull request #14610: Docs: correction to test readme compile instructions (master...fix_test_readme_compile_instructions) https://github.com/bitcoin/bitcoin/pull/14610
< sipa>
esotericnonsense: for some upgrades (though not 4th digit changes...) you may end up with difference in version between bitcoind and bitcoin-cli
< esotericnonsense>
Arvidt: non-specific to bitcoin, the binary changing out from underneath it shouldn't matter
< Arvidt>
When doing tar -xzf bitcoin-0.17.0.1-x86_64-linux-gnu.tar.gz it extracts to the folder bitcoin-0.17.0/ . I would suggest that it extracts to the folder bitcoin-0.17.0.1/ because I have a symlink "current" to the newest version, and now, my old binary tree of 0.17.0 got simply overwritten with the 0.17.0.1 version, while I was still running 0.17.0 with that binary tree :-( But it looks
< hebasto>
provoostenator: script expects 'inputs/bitcoin-0.17.0-win-unsigned.tar.gz', which is wrong.
< provoostenator>
Gitian for v0.17.0.1 Windows is presenting me with "cp: cannot stat 'inputs/bitcoin-0.17.0.1-win-unsigned.tar.gz': No such file or directory"
< bitcoin-git>
[bitcoin] achow101 closed pull request #14558: rpc: Require solvability in importmulti if importing more than the scriptPubKey (master...importmulti-solvability) https://github.com/bitcoin/bitcoin/pull/14558
2018-10-29
< bitcoin-git>
[bitcoin] sanket1729 opened pull request #14604: [Tests] Add test and refactor feature_block.py (master...feature-block-test) https://github.com/bitcoin/bitcoin/pull/14604
< bitcoin-git>
[bitcoin] jnewbery reopened pull request #9152: Wallet/RPC: sweepprivkeys method to scan UTXO set and send to local wallet (master...sweepprivkeys) https://github.com/bitcoin/bitcoin/pull/9152
< gribble>
https://github.com/bitcoin/bitcoin/issues/9152 | Wallet/RPC: sweepprivkeys method to scan UTXO set and send to local wallet by luke-jr · Pull Request #9152 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14602: Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_untrusted) https://github.com/bitcoin/bitcoin/pull/14602
< bitcoin-git>
[bitcoin] ch4ot1c opened pull request #14601: [rpc] Descriptions: Consistent arg labels for types 'object' and 'boolean' (master...fix/rpc-arg-types) https://github.com/bitcoin/bitcoin/pull/14601
< bitcoin-git>
bitcoin/master d8bf107 Luke Dashjr: Bugfix: RPC: Add address_type named param for createmultisig
< bitcoin-git>
bitcoin/master 29f429d MarcoFalke: Merge #14596: Bugfix: RPC: Add address_type named param for createmultisig...
< bitcoin-git>
[bitcoin] fanquake closed pull request #13561: Qt: Remove unnecessary image buffer for Mac dock icon (master...rm_icon_buffer) https://github.com/bitcoin/bitcoin/pull/13561
< bitcoin-git>
[bitcoin] merland opened pull request #14600: docs: Add instructions about commit message when squashing (master...update-contrib) https://github.com/bitcoin/bitcoin/pull/14600
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14599: Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. (master...no-more-locale) https://github.com/bitcoin/bitcoin/pull/14599
< josephnicholas>
Hi all, how do I change the bitcoin fee to 1 sat/byte?
< luke-jr>
HikoSeijuroXVI: you're in the chat room for development discussions. type /join #bitcoin
< luke-jr>
HikoSeijuroXVI: #bitcoin
2018-10-28
< bitcoin-git>
[bitcoin] fanquake closed pull request #14222: Qt: Fix restoration of minimized to tray window (master...windows-tray-icon) https://github.com/bitcoin/bitcoin/pull/14222
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14596: Bugfix: RPC: Add address_type named param for createmultisig (master...bugfix_createMS_named_addresstype) https://github.com/bitcoin/bitcoin/pull/14596
< bitcoin-git>
[bitcoin] hebasto opened pull request #14597: qt: Remove old MacDockIconHandler class (master...20181028-macos-dock-overhaul) https://github.com/bitcoin/bitcoin/pull/14597
< bitcoin-git>
[bitcoin] Empact closed pull request #12765: Store the current config file at read time, and return it from GetConfigFile if set (master...config-file-path) https://github.com/bitcoin/bitcoin/pull/12765
< bitcoin-git>
[bitcoin] fanquake closed pull request #13816: travis: WIP - build and run tests on os: osx (master...run-functional-tests-on-macos) https://github.com/bitcoin/bitcoin/pull/13816
2018-10-27
< bitcoin-git>
[bitcoin] harding opened pull request #14589: Docs/Release notes: 0.17.0.1 is a minor release (0.17...2018-10-rn-minor) https://github.com/bitcoin/bitcoin/pull/14589
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13783: validation: Pass tx pool reference into CheckSequenceLocks (master...Mf1807-txPoolValidation) https://github.com/bitcoin/bitcoin/pull/13783
< bitcoin-git>
bitcoin/master fa511e8 MarcoFalke: Pass tx pool reference into CheckSequenceLocks
< bitcoin-git>
bitcoin/master efaf2d8 MarcoFalke: Merge #13783: validation: Pass tx pool reference into CheckSequenceLocks...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14571: [tests] Test that nodes respond to getdata with notfound (master...Mf1810-qaNotfound) https://github.com/bitcoin/bitcoin/pull/14571
< bitcoin-git>
bitcoin/master fa78a2f MarcoFalke: [tests] Test that nodes respond to getdata with notfound...
< bitcoin-git>
bitcoin/master c70f9c0 MarcoFalke: Merge #14571: [tests] Test that nodes respond to getdata with notfound...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564
< bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564
< bitcoin-git>
[bitcoin] gwillen opened pull request #14588: Refactor PSBT signing logic to enforce invariant and fix signing bug (master...feature-psbt-sign-fix) https://github.com/bitcoin/bitcoin/pull/14588
2018-10-26
< gwillen>
"Bitcoin core is also apparently using 50% of my disk which is not true. An application was using 12mb/s of disk and it was only using about 20% of the disk total. Bitcoin core however is using 3mb/s and is using 50%"
< gmaxwell>
"Bitcoin core is currently 15 hours behind as I'm writing this and the piph (progress increase per hour) is at a STUPIDLY low speed. There are 95 blocks left but it says its going up 0.04% per hour."
< wumpus>
it doesn't matter, whatever your politics, either bitcoin is destroying the world, or well otherwise there's always infighting between implementation
< wumpus>
yess of course they just want to attack bitcoin core
< gmaxwell>
I was particularly frustrated today because I encountered yet another one where they got a long reply given them a 10 step procedure to stop using bitcoin core, which never even mentioned they were confused about progress. (certantly not the first time I've seen that happen).
< midnightmagic>
People don't want to get their hands dirty building bitcoin because they worry that if they make a mistake, someone will blame them for millions of $$ lost. And the people who overcome that are philosophically-minded people who jump off that cliff anyway and hope Miles back at the base camp packed their parachute properly. :)
< sipa>
this channel is about discussing development on the Bitcoin Core software; you're welcome to idle or discuss relevant topics, but those don't include other Bitcoin clients, and certainly not trojan horse software
< oshithemoto>
no one is writting here, just like idling here? gg I am an old developer, i did some decentraliced stuff bevor bitcoin, cordinated ddos attacs and i hope to find some old crew member, it was not sub7 crew but some of the ppl from this crew can help me find my old crew members I think one of them is satoshi nakamoto. his "old" nickname was "oso", he was a hacker and our crew name was #ratpack and he told my about a decen
< jarthur>
Specifically Bitcoin Core development. #bitcoin-dev or #bitcoin may be better suited.
< oshithemoto>
Anyone here who coded a bitcoin wallet in VB.NET?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14585: Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...) (master...no-locale-surprises-please) https://github.com/bitcoin/bitcoin/pull/14585
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< bitcoin-git>
[bitcoin] ken2812221 closed pull request #13827: [WIP] depends: Add native_nsis to support unicode (master...depends-nsis) https://github.com/bitcoin/bitcoin/pull/13827
< andytoshi>
rust-jsonrpc is better but it's still not where i want it to be. afaik there is no HTTP client library for rust that doesn't have a bad dependency story. we would need to write our own to do bitcoin-cli in rust.
< harding>
wumpus: that's what I remember being done for all the other 0.*.*.1 releases, and it's easiest for the website if there are release notes because, as you say, it's the same release process. It is possible (and pretty easy) to have binaries split across two directories on both BitcoinCore.org and Bitcoin.org as we both use the same mechanism to allow for easy changes in the filenames across releases, so let me know if you ever do
< harding>
For 0.17.0.1, a few questions related to what changes I might need to make to BitcoinCore.org for it: (1) is only the MacOS binary going to be added to /bin/bitcoin-core-0.17.0.1/ or will there be .0.1 versions for all platforms? (2) Are there going to be release notes for it? (3) Do we want a blog post about it on the home page?
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14582: wallet: try -avoidpartialspends mode and use its result if fees do not change (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
< bitcoin-git>
[bitcoin] fanquake closed pull request #12656: Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer (master...vagrant) https://github.com/bitcoin/bitcoin/pull/12656
< gmaxwell>
echeveria: I personally liked the one company going around telling everyone that bitcoin core constantly crashed, and then got shut up by a developer offering them a sizable bet that they couldn't report any crash...
< echeveria>
some of this comes from parties like blockchain.info who have frequently gone around conferences repeating stories of how they tried so hard to contribute to bitcoin core and were rejected for their efforts.
< gmaxwell>
(I very much want their input for sure, but if they don't provide it.. they don't provide it. Unfortunately, my expirence with many bitcoin companies is that they have executives that have never actually used software in a commercial context before, much less open source... and they treat it like the android play store... an app doesn't do what you want, you swap out for another one).
< echeveria>
from my experience people making a lot of these sort of claims don’t actually use the software at all, so keep that in mind too. I’ve had people sit and insist to me that the bitcoin wallet has all sorts of stupid behaviour I full well know it doesn’t.
< kallewoof>
gmaxwell: sdaftuar spoke against the feature in the original PR here: https://github.com/bitcoin/bitcoin/pull/12257#discussion_r204168100 ("I'm not sure that -avoidpartialspends works very well on wallets that have substantial address reuse, in particular I think you can devolve into cases where you'd produce giant transactions that take forever to sign and would never pass policy (or consensus) limits, in extreme cases.")
< esotericnonsense>
wumpus: no just write the bits of qemu you need to emulate bitcoin-cli on riscv.
< esotericnonsense>
just write bitcoin-cli in bash.
< gmaxwell>
Maybe the rust-bitcoin people have already done it.
< wumpus>
let's write bitcoin-cli in rust
< gmaxwell>
I don't think it was bad to raise, we might end up back on it if later bitcoin-cli is blocking disabling tcp rpc by default, and libevent still can't handle using domain sockets for the -cli case.
< esotericnonsense>
someone using bitcoin-cli in scripts ... argh\
< sipa>
my preference is just replacing the libevent http code in bitcoin-cli with hand-written HTTP though :)
< sipa>
gmaxwell: generally i agree with that... but i also think bitcoin-cli is very simple :)
< gmaxwell>
yea, if we wanted to rewrite anything bitcoin-cli would be it! :)
< wumpus>
it woult make zero difference for bitcoin-cli wrt performance
< gmaxwell>
I don't think thats absurd on its face, but: it would probably be a massive slowdown for those users who do processing using bitcoin-cli in scripts, and would suffer the standard "throwaway and rewrite software issues" -- the complexity of existing code is effectively all the accrewed knoweldge built from years and years of use... and that it probably gets right lots of behaviors none of us
< wumpus>
rewriting bitcoin-cli in python, certainly using the code already in the test framework, would be trivial, but why?
< esotericnonsense>
gmaxwell: i'm not suggesting it but rather responding to wumpus'/sipa message above about bitcoin-cli not needing to be a full http client and inventing some thing
< sipa>
afaik the origin bitcoin-cli code was just some printf statements into a socket
< esotericnonsense>
what bitcoin-cli?
< esotericnonsense>
all of bitcoin? :D:D
< gmaxwell>
I think esotericnonsense is suggesting bitcoin-cli get replaced with a python tool?
< esotericnonsense>
WRT bitcoin-cli and http/domain sockets/etc
< esotericnonsense>
obviously it's so that you can stick your bitcoin rpc behind nginx and put it on https://myexchange.com/api
< bitcoin-git>
[bitcoin] hebasto opened pull request #14577: qt: Cleanup `textInteractionFlags` for `QLabel` (master...20181025-textInteractionFlags) https://github.com/bitcoin/bitcoin/pull/14577
< wumpus>
(why does bitcoin use http? I do not know, I guess JSON-RPC is marginally better than rolling yet another custom protocol, though the line-based JSON RPC of c-lightning is *pretty neat*)
< sipa>
wumpus: you may hate this... but given that bitcoin-cli is specific to bitcoind, it probably doesn't need to actually implement full HTTP; just whatever subset is needed for bitcoind
< gmaxwell>
sipa: e.g. will it crash under concurrent request load, etc. thats something we'd probably find out really fast with bitcoin-cli switched to it.
< sipa>
gmaxwell: any type of issue you're worried about in particular w.r.t. unix socket support but excluding bitcoin-cli initially?
< gmaxwell>
jonasschnelli: it's hard to test extensively without bitcoin-cli support, I'd worry about it bitrotting.
< jarthur>
bitcoin-cli support is what was held up by proposed upstream libevent work
< jarthur>
While some folks are still here, I'm curious if any of you would be against an incremental introduction of unix domain sockets for the RPC API. e.g. release with just server support first, no bitcoin-cli support and no official work around abstract sockets. Server support may be exhumable from wumpus PR #9919.
< jnewbery>
sorry I missed the meeting. On the topic of testing RCs, the optech newsletter has action items each week, which included 'allocate time to test Bitcoin Core RC' for the weeks that we had RCs (eg https://bitcoinops.org/en/newsletters/2018/09/11/). If there are more specific instructions, let us know and we can help spread them.
< gribble>
https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub
< luke-jr>
how about I make a Twitter account for posting experimental releases of Core, Knots, and other reputable Bitcoin projects? (Electrum, etc?)
< esotericnonsense>
anyway, this is not bitcoin core dev, sorry :P
< wumpus>
yes, I guess the threat model for bitcoin is somewhat different than say, ssh
< esotericnonsense>
so yeah if you have the list it would probably take a few seconds to hit them all and see if they're not bitcoin. :P
< luke-jr>
harding: well, I mean perhaps some other software is listening in 8332 while Bitcoin isn't
< wumpus>
or maybe they found an exploit in bitcoin-cli and are waiting for you to use it on them :-)
< harding>
luke-jr: the list of IPs I scan cam from bitnodes, which I think currently filters out Bitcoin Cash nodes. Obviously so were probably spy nodes and the like.
< luke-jr>
I wonder if these 8332s aren't even bitcoin itself?
< esotericnonsense>
luke-jr: is it possible to get a bitcoin-like response back with invalid auth
< esotericnonsense>
e.g. if you had bitcoind, bitcoin-qt and bitcoin-qt had perms on the socket but other than bitcoin-qt only root did