< aj>
$ time (blk=$(bitcoin-cli getblockhash 551601); echo $blk; bitcoin-cli invalidateblock $blk; bitcoin-cli gettxoutsetinfo | grep hash_serial; bitcoin-cli reconsiderblock $blk) # --> 666550387c3f5fa8e9353ce561fcee2a164022d31b97affd7c982388f19a4904as the hash, took about 1m12 all up
< NicolasDorier>
aj: At least for the reviewers. People running those "bitcoin core in a box" are already blindly trusting binaries anyway.
< NicolasDorier>
I think this is even better UX than embedding known utxo hash set anywhere into bitcoin core.
< gmaxwell>
NicolasDorier: if the "bitcoin core in a box" then the entire software could do arbritary things, the hash it gives is meaningless.
< NicolasDorier>
Yes I can understand. I am just worried that right now what we will see with those "Bitcoin Core in a box" is blind reliance on a pre-shipped UTXO Set
< NicolasDorier>
So the user could fast sync from untrusted source, and would get a warning if that differ from Bitcoin Core website/twitter or whatever publish mechanism
< NicolasDorier>
so instead I was thinking the following: What about Bitcoin Core share the txoutset hash on bitcoincore website or twitter or whatever (like every 1000 blocks). At BTCPay level, I would show the UTXOSet of their own node and check against the website
< bitcoin-git>
bitcoin/master c77f092 Russell Yanofsky: Fix descriptor_tests not checking ToString output of public descriptors
< bitcoin-git>
bitcoin/master 0fa3703 MarcoFalke: Merge #14820: test: Fix descriptor_tests not checking ToString output of public descriptors...
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #14820: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
< gmaxwell>
provoostenator: 09:57:52 < jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason
< gribble>
https://github.com/bitcoin/bitcoin/issues/10595 | Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients by luke-jr · Pull Request #10595 · bitcoin/bitcoin · GitHub
< jnewbery>
I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason don't want to include a certain class of transaction in their blocks.
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
< jnewbery>
I think promag means 'what if the miner wants to take Bitcoin Core 0.18 but doesn't want to upgrade his pool software to support mining segwit blocks?'
< sipa>
promag: currently, if the gbt client does not provide segwit flag, bitcoin core will produce a (suboptimal) block template without segwit txn
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] hebasto opened pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< bitcoin-git>
[bitcoin] jamesob opened pull request #14812: qa: fix p2p_invalid_messages on macOS (master...2018-11-test-macos-mem-fix) https://github.com/bitcoin/bitcoin/pull/14812
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14811: Mining: Enforce that segwit option must be set in GBT (master...remove_non_segwit_mining) https://github.com/bitcoin/bitcoin/pull/14811
< bitcoin-git>
[bitcoin] stevenroose opened pull request #14805: tests: Support calling add_nodes more than once (master...test-framework) https://github.com/bitcoin/bitcoin/pull/14805
< bitcoin-git>
[bitcoin] fanquake closed pull request #14072: [primitives, consensus] Make fChecked an atomic<bool> (master...fchecked-atomic) https://github.com/bitcoin/bitcoin/pull/14072
< bitcoin-git>
[bitcoin] hebasto opened pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14400: Add Benchmark to test input de-duplication worst case (master...benchmark-reject-duplicate-inputs) https://github.com/bitcoin/bitcoin/pull/14400
< bitcoin-git>
[bitcoin] hebasto opened pull request #14798: qt: Fix Peers tab switch away in RPC console (master...20181124-fix-peers-tab-switch) https://github.com/bitcoin/bitcoin/pull/14798
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
2018-11-23
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< lopp>
are you suggesting that people have a life outside of bitcoin??? :-P
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits error: gpg failed to sign the data fatal: failed to write commit object Merge commit HEAD is not clean
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits
< bitcoin-git>
bitcoin/master af9a991 Cornelius Schumacher: Fix detection of copyright holders...
< bitcoin-git>
[bitcoin] marcoagner opened pull request #14795: test: allows test_runner command line to receive parameters for each test (master...fix_test_runner_parameters) https://github.com/bitcoin/bitcoin/pull/14795
< bitcoin-git>
bitcoin/master b81a186 Gregory Sanders: GetPubKey: make sigdata const
< bitcoin-git>
bitcoin/master 0595164 Wladimir J. van der Laan: Merge #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git>
[bitcoin] laanwj closed pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< bitcoin-git>
bitcoin/master 8284756 John Newbery: A few minor formatting fixes and clarifications to descriptors.md
< bitcoin-git>
bitcoin/master d7fbe7d Wladimir J. van der Laan: Merge #14778: A few minor formatting fixes and clarifications to descriptors.md...
2018-11-22
< bitcoin-git>
[bitcoin] kristapsk opened pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
< bitcoin-git>
[bitcoin] merland opened pull request #14787: Replace old instructions with links to official docs (master...issue14639) https://github.com/bitcoin/bitcoin/pull/14787
< promag>
maybe we should just call `noui_connect()` in bitcoin-qt?
< bitcoin-git>
[bitcoin] promag opened pull request #14783: qt: Fix boost::signals2::no_slots_error in early calls to InitWarning (master...2018-11-fix-noslotserror) https://github.com/bitcoin/bitcoin/pull/14783
< bitcoin-git>
[bitcoin] laanwj closed pull request #14756: Improve rpcauth.py by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< bitcoin-git>
[bitcoin] laanwj closed pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git>
bitcoin/master 7bad78c Ben Woosley: Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h...
< bitcoin-git>
bitcoin/master 69ca487 Ben Woosley: Implement prevector::fill once...
< bitcoin-git>
bitcoin/master e736b67 Wladimir J. van der Laan: Merge #14715: Drop defunct prevector compat handling...
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr closed pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
< gmaxwell>
"I have made progress and while the current implementation is 20% slower than it could be it is still five times faster than before and think I will settle for that. Details are in my bitcoin-armv8 repo. It is reindexing my copy of the bitcoin blockchain at over double the pace."
2018-11-21
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< gribble>
https://github.com/bitcoin/bitcoin/issues/8751 | RPC: Add parameter to addmultisigaddress / createmultisig to sort public keys by afk11 · Pull Request #8751 · bitcoin/bitcoin · GitHub
< dgpv>
sipa: actually my initial question was should I submit a PR with change for sortedmulti() or just create an issue on bitcoin core github
< sipa>
all i'm saying is that i don't think it makes sense to commit to "bitcoin core aims to be interoperable with software X"
< gmaxwell>
dgpv: Seriously, the bitcoin project has been held back for years by misguided efforts towards interoperability with a largely indifferent industry. It's a bit irritating that you're advocating us burning more time here on this particular point of it, because it would be useful in your product.
< bitcoin-git>
[bitcoin] laanwj closed pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
< sipa>
dgpv: so far, the bitcoin core wallet also hasn't really supported HD chains created by other software as import
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
< TGeek>
Hi all, I am having an issue in bitcoin core 0.17.0.1 with the bumpfee rpc call.. It keeps throwing an error "(-4) Transaction does not have a change output". Which is strange because the output for the tx has two outputs, one for the to address and one for change. I have been troubleshooting this issue for 2 days now and cannot seem to find anything related in searches.. Any help would be greatly appreciated.
2018-11-20
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
< bitcoin-git>
[bitcoin] vim88 closed pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< wumpus>
look, there's this concern we haven't even ever *thought* about and suddenly it needs to be considered in bitcoin core
< LGzr>
Hola, all. I've a question about the p2sh example at https://bitcoin.org/en/developer-examples#p2sh-multisig; is there a more appropriate forum than here? (Question is: what purpose it serves that createmultisig uses public key for one, and addresses for the others)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14757: Avoid reading uninitialized variables in serialization code (triggered when running "make check") (master...avoid-read-of-uninitialized-variable) https://github.com/bitcoin/bitcoin/pull/14757
< bitcoin-git>
[bitcoin] promag opened pull request #14756: Improve by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< gmaxwell>
(I've seen other people get tricked into thinking that 'classic' is the orignal bitcoin. .. the most amusing of which was some post after BU caught fire that tried to claim that BU's problems were mostly because the original bitcoin software was such crap, and then went after a bunch of bugs in 'classic' that either never were in Bitcoin or had long since been fixed. :P )
< BlueMatt>
you'll note the snaps in this case were pretty clearly some bitcoin classic troll
< gmaxwell>
oh jesus. it's bitcoin "classic"?
< BlueMatt>
no idea, the link to the "developer site" is bitcoin classic
< gmaxwell>
occurs at the early startup stage of bitcoin-qt, it renders bitcoin-qt
< bitcoin-git>
[bitcoin] vim88 opened pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< bitcoin-git>
[bitcoin] domob1812 opened pull request #14752: tests: Unit tests for IsPayToWitnessScriptHash and IsWitnessProgram (master...script-segwit-tests) https://github.com/bitcoin/bitcoin/pull/14752
< bitcoin-git>
[bitcoin] vim88 closed pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< bitcoin-git>
[bitcoin] vim88 opened pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< bitcoin-git>
[bitcoin] dongcarl opened pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
< dongcarl>
Any reason why `bitcoin/share/rpcauth/rpcauth.py` generates a 16 byte salt instead of a 32 byte salt? I believe RFC 2104 recommends the key length to be larger than or equal to the hash output length: https://tools.ietf.org/html/rfc2104#section-3