< bitcoin-git>
[bitcoin] practicalswift opened pull request #15296: tests: Add script checking for deterministic line coverage in unit tests (master...test_deterministic_coverage) https://github.com/bitcoin/bitcoin/pull/15296
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
< MarcoFalke>
To hold Bitcoin Core related blobs used for quality assurance
< MarcoFalke>
wumpus: Mind to create a https://github.com/new for bitcoin-core/qa-assets ?
< gkrizek>
Ok, great. I see in the logs: "Received repository 'bitcoin-core/secp256k1', but no pool is configured for it.", but I'm guessing you added the webhook before the update to the config?
< bitcoin-git>
[bitcoin] hebasto merged pull request #15163: Correct units for "-dbcache" and "-prune" (master...0190114-correct-info-units) https://github.com/bitcoin/bitcoin/pull/15163
< bitcoin-git>
bitcoin/master a47319d MarcoFalke: Merge #15159: [RPC] Remove lookup to UTXO set from GetTransaction
< bitcoin-git>
[bitcoin] amitiuttarwar merged pull request #15159: [RPC] Remove lookup to UTXO set from GetTransaction (master...3931_rebase) https://github.com/bitcoin/bitcoin/pull/15159
< gkrizek>
Thanks everyone for being patient with this! It's very hard for me to adequately mimic the bitcoin repo payloads and IRC stuff, so naturally the bugs happen in "production".
< gribble>
https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
< echeveria>
in any case you can't expect that people will change version bytes at all, or that bitcoin won't, so using them as identifiers would be a poor decision.
< echeveria>
Bullit: #bitcoin please.
2019-01-28
< sipa>
stevenroose: if it's a BIP, no need to refer to anything but bitcoin and testnet
< gleb>
I've modified transaction transmission and sometimes (very rarely though) I'm getting "non-mandatory-script-verify-flag (Witness program hash mismatch)". Any idea how it might happen or where should I look for? Transactions are generated by "bitcoin-cli sendtoaddress"
< luke-jr>
promag: or perhaps void the bitcoin.conf wallets, and load wallet w1?
< dongcarl>
Hey all, I've been working on making bitcoin builds with Guix, which I think can replace gitian for our release process one day. It is a very exciting package manger which will bring much better supply chain security to Bitcoin. Let me know your thoughts! https://github.com/bitcoin/bitcoin/pull/15277
< promag>
losing my mind with bitcoin-qt shutdown
< stevenroose>
What are some "network identifiers" that can be used to generally refer to a "bitcoin network"? I.e. Mainnet, Testnet, Liquidv1, ...
< bitcoin-git>
[bitcoin] domob1812 closed pull request #15259: Use real HTTP bind address in curl RPC help (master...decoupled-rpchelp) https://github.com/bitcoin/bitcoin/pull/15259
< bitcoin-git>
bitcoin/master 9431e1b Ben Woosley: Trivial: fixup a few doxygen comments...
< bitcoin-git>
bitcoin/master 70e7cee Ben Woosley: Trivial: Doxygenize existing CBufferedFile and VectorReader comments
< bitcoin-git>
bitcoin/master 5e0c0fd Wladimir J. van der Laan: Merge #15254: Trivial: fixup a few doxygen comments...
< bitcoin-git>
[bitcoin] fanquake opened pull request #15272: doc: correct logging return type and RPC example (master...rpc-logging-return-example) https://github.com/bitcoin/bitcoin/pull/15272
2019-01-26
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #15258: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions (master...copyright-header-abs) https://github.com/bitcoin/bitcoin/pull/15258
< bitcoin-git>
[bitcoin] d3spwn opened pull request #15268: doc: suggest using timeoutstopsec in systemd file during IBD (master...systemd-tweaks) https://github.com/bitcoin/bitcoin/pull/15268
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #15265: Flush without erasing cache during periodic and pruning flushes (master...2019-01-periodic-flush-dont-wipe) https://github.com/bitcoin/bitcoin/pull/15265
< bitcoin-git>
[bitcoin] jamesob opened pull request #15264: validation: remove useless uncache accounting in ATMPW (master...2019-01-remove-useless-uncaching-atmpw) https://github.com/bitcoin/bitcoin/pull/15264
< gmaxwell>
Is there anything we can do to head off funds loss from typos/copypaste errors with decriptor importing? The use of descriptors as user/api handled key material seems like a step backward for Bitcoin, as we're now introducing ways for simple typos (or clbuttic errors) to cause funds to go off to space.
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipa opened pull request #15263: Descriptor expansions only need pubkey entries for PKH/WPKH (master...201901_flatprovider_pkh) https://github.com/bitcoin/bitcoin/pull/15263
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #15249: Docs: Update python docs to reflect that wildcard imports are disallowed (master...wildcard-imports-doc) https://github.com/bitcoin/bitcoin/pull/15249
< bitcoin-git>
[bitcoin] domob1812 opened pull request #15259: Use real HTTP bind address in curl RPC help (master...decoupled-rpchelp) https://github.com/bitcoin/bitcoin/pull/15259
< echeveria>
similar to Travis, building Bitcoin Core, I men’s.
< echeveria>
they run mostly alright for this sort of target. I know a developer that has a dedicated Mac Mini build server for their binary distribution in a similar way to bitcoin core.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15246: qa: Add tests for invalid message headers (master...Mf1901-qaMsgHeader) https://github.com/bitcoin/bitcoin/pull/15246
< bitcoin-git>
[bitcoin] instagibbs opened pull request #15245: remove deprecated mentions of signrawtransaction from fundraw help (master...fundraw_signraw) https://github.com/bitcoin/bitcoin/pull/15245
< gmaxwell>
I think it would be nice to even do more than what Bitcoin Core currently does.. but priorities, the sign/verify after generate is a pretty general protection at least.
< provoostenator>
Even devices that don't have an official sign message feature, Bitcoin Core could just have it sign a fake transaction.
< provoostenator>
"internally to bitcoin core is sign-after-generate" - I didn't know we did that, that seems smart.
< gmaxwell>
right. Well we can only go so far too. :) But the standard we've set internally to bitcoin core is sign-after-generate.
< gmaxwell>
Which is analogous to the process bitcoin uses internally when generating keys: it signs a message and verifies, to make sure that the generated address/key actually work.
< gmaxwell>
Corruption inside bitcoin is also a concern, but a strictly less serious one than corruption by humans or across application boundaries.
< provoostenator>
So we need something to replace xpub that has a better checksum? Or does that still data corruption risk? Because something goes wrong inside of Bitcoin Core during the import?
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< jnewbery>
2. We're looking for recommendations for residents. If you know anyone who wants to immerse themselves in Bitcoin/Lightning over summer and is excited about making a real contribution to the project, please send them our way
< jnewbery>
it's 2-3 weeks of seminars followed by 2 months of project work. We're expecting the residents to make really meaningful contributions to Bitcoin Core and other Bitcoin/Lightning projects while they're here
< gribble>
https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] instagibbs opened pull request #15244: gdb attaching to process during tests has non-sudo solution (master...gdb_ptrace) https://github.com/bitcoin/bitcoin/pull/15244
< gribble>
https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #15223: Doc: add information about security to the JSON-RPC doc (master...2019-01-rpc-security) https://github.com/bitcoin/bitcoin/pull/15223
< luke-jr>
bitcoin-0.17.1/bin/bitcoin-qt: relocation error: bitcoin-0.17.1/bin/bitcoin-qt: symbol __chk_fail, version GLIBC_2.3.4 not defined in file libc.so.6 with link time reference
< bitcoin-git>
[bitcoin] jonasschnelli closed pull request #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
< bitcoin-git>
bitcoin/master fdf82ba Graham Krizek: Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible...
< bitcoin-git>
bitcoin/master 73a6bac Jonas Schnelli: Merge #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible...
< gribble>
https://github.com/bitcoin/bitcoin/issues/15196 | [test]: Update all subprocess.check_output functions to be Python 3.4 compatible by gkrizek · Pull Request #15196 · bitcoin/bitcoin · GitHub
< ryanofsky>
i know specifying --prefix lets bitcoin autoconf find the "config.site" file generated by depends
< dongcarl>
Question for people more knowledgeable about depends: in depends/README.md, it says that the way to use the results of calling `make` in depends for bitcoin is to do ./configure --prefix=`pwd`/depends/x86_64-w64-mingw32, but in our gitian descriptor we seem to use it like so: CONFIG_SITE=`pwd`/depends/x86_64-w64-mingw32/share/config.site ./configure --prefix=/. Is there a difference between the two?
< bitcoin-git>
[bitcoin] hebasto opened pull request #15236: scripts and tools: Make --setup command independent (master...20190123-gitian-build-setup) https://github.com/bitcoin/bitcoin/pull/15236
< bitcoin-git>
[bitcoin] ken2812221 reopened pull request #14922: [WIP] windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
< bitcoin-git>
[bitcoin] achow101 opened pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
< bitcoin-git>
bitcoin/master 94167e2 Wladimir J. van der Laan: Merge #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement...
< wumpus>
hm "2019-01-22 22:23:51 [ghi] Received repository 'bitcoin/bitcoin', but no pool is configured for it."
< gkrizek>
wumpus is the bitcoin-git Nick registered (ie; needs a password)?
< wumpus>
gkrizek: I've removed the github service from #bitcoin-commits, right setting up an account on my server to run ghi, and sure an example could be helpful :)
< gkrizek>
I was thinking it might be nice to add it as a webhook now and have it post to the #bitcoin-commits channel. That way we can test it out and see how it compares to the GitHub Service before it's EOL.
< meshcollider>
jonasschnelli: weird, in your github settings on the Authorized OAuth Apps page, does AppVeyor have access to read org and team membership, and the bitcoin org?
< bitcoin-git>
[bitcoin] achow101 opened pull request #15225: GUI: Change the receive button to respond to keypool state changing (master...receive-button) https://github.com/bitcoin/bitcoin/pull/15225
< bitcoin-git>
[bitcoin] sipa opened pull request #15224: Add RNG strengthening (10ms once every minute) (master...201901_rand_strengthen) https://github.com/bitcoin/bitcoin/pull/15224
< bitcoin-git>
[bitcoin] harding opened pull request #15223: Doc: add information about security to the JSON-RPC doc (master...2019-01-rpc-security) https://github.com/bitcoin/bitcoin/pull/15223
< bitcoin-git>
bitcoin/master f0c9e1c Wladimir J. van der Laan: Merge #14906: refactor: Make explicit CMutableTransaction -> CTransaction conversion....
< bitcoin-git>
bitcoin/master 6be52d6 Wladimir J. van der Laan: Merge #15213: doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable...
< bitcoin-git>
[bitcoin] laanwj closed pull request #15213: doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15213
< bitcoin-git>
bitcoin/master 85f0ca9 Gregory Sanders: Remove errant past from walletcreatefundedpsbt for nLocktime replaceability
< gribble>
https://github.com/bitcoin/bitcoin/issues/15196 | [test]: Update all subprocess.check_output functions to be Python 3.4 compatible by gkrizek · Pull Request #15196 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #15209: zmq: log outbound message high water mark when reusing socket (master...zmq-always-log-high-water-mark) https://github.com/bitcoin/bitcoin/pull/15209