2018-02-09

< bitcoin-git> [bitcoin] practicalswift opened pull request #12393: Fix a-vs-an typos (master...a-vs-an-typos) https://github.com/bitcoin/bitcoin/pull/12393
< MrBruceWayne> #bitcoin
< bitcoin-git> [bitcoin] promag closed pull request #12361: Replace unreachable error handling with assertions in feebumper (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361

2018-02-08

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (master...2018-02-fix-fpausesend-getdata-resp) https://github.com/bitcoin/bitcoin/pull/12392
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12286: Wallet: Resolve compiler warnings in ec_privkey_import_der (master...master) https://github.com/bitcoin/bitcoin/pull/12286
< bitcoin-git> [bitcoin] laanwj closed pull request #12225: Mempool cleanups (master...2018-01-mempool-cleanups) https://github.com/bitcoin/bitcoin/pull/12225
< bitcoin-git> bitcoin/master 669c943 Suhas Daftuar: Avoid leaking prioritization information when relaying transactions
< bitcoin-git> bitcoin/master e868b22 Suhas Daftuar: fee estimator: avoid sorting mempool on shutdown
< bitcoin-git> bitcoin/master 0975406 Suhas Daftuar: Correct mempool mapTx comment
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d405beea26c1...67447ba06057
< GitHub126> [bitcoin-detached-sigs] theuni closed pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
< gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< GitHub158> [bitcoin-detached-sigs] jonasschnelli opened pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
< cfields> wumpus: ah, you objected to the idea of our own impl. You were pretty pro std impl: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-283764371
< wumpus> I'm surprised if this are all the changes needed: https://github.com/theuni/bitcoin/commit/b208705020118d2be6962c0bf7b6fcfd702f576e
< Randolf> Oh, Bitcoin wasn't one of the applications.
< Randolf> cfields: Indeed. And I did notice this PR: https://github.com/bitcoin/bitcoin/pull/12381
< * wumpus> just merged the rc3 signatures on bitcoin-core/gitian.sigs
< bitcoin-git> [bitcoin] instagibbs closed pull request #10360: [WIP] [Wallet] Target effective value during transaction creation (master...feedo) https://github.com/bitcoin/bitcoin/pull/10360
< bitcoin-git> [bitcoin] jtimon closed pull request #9608: Net: Divide ProcessMessage in smaller functions (master...2017-01-split-processmessages) https://github.com/bitcoin/bitcoin/pull/9608
< bitcoin-git> [bitcoin] promag closed pull request #11563: Improve CheckBlockIndex performance (master...2017-10-improve-checkblockindex) https://github.com/bitcoin/bitcoin/pull/11563
< bitcoin-git> [bitcoin] achow101 closed pull request #9504: [RPC] dumpmasterprivkey command (master...dumpmasterprivkey) https://github.com/bitcoin/bitcoin/pull/9504
< bitcoin-git> [bitcoin] sipa closed pull request #10434: [WIP] 3072-bit MuHash based hash_serialized (master...muhash) https://github.com/bitcoin/bitcoin/pull/10434
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
< jtimon> yeah, there have been no interest in https://github.com/bitcoin/bitcoin/pull/9608 for a while so I'm more inclined to close it than to rebase it at this point unless someone changes my mind
< gribble> https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< jtimon> https://github.com/bitcoin/bitcoin/pull/12172 could use some tested acks, even if it's a small bug
< wumpus> we still have plenty of things in https://github.com/bitcoin/bitcoin/projects/8, but it hasn't been updated for a few weeks because we've effectively used the 0.16 milestone for that, so now that 0.16 has branched it's up for discussion to add/remove things
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] laanwj closed pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333
< bitcoin-git> bitcoin/master d405bee Wladimir J. van der Laan: Merge #12333: Make CWallet::ListCoins atomic...
< bitcoin-git> bitcoin/master 2f960b5 João Barbosa: [wallet] Indent only change of CWallet::AvailableCoins
< bitcoin-git> bitcoin/master 1beea7a João Barbosa: [wallet] Make CWallet::ListCoins atomic
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/663911ed581d...d405beea26c1
< MarcoFalke> debian 9 should work after the fix https://github.com/bitcoin-core/docs/pull/22
< bitcoin-git> [bitcoin] laanwj closed pull request #12282: wallet: Disallow abandon of conflicted txes (master...Mf1801-walletBumpAbandonOnlyNonConflictedTxes) https://github.com/bitcoin/bitcoin/pull/12282
< bitcoin-git> bitcoin/master 663911e Wladimir J. van der Laan: Merge #12282: wallet: Disallow abandon of conflicted txes...
< bitcoin-git> bitcoin/master fa795cf MarcoFalke: wallet: Disallow abandon of conflicted txes
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/935eb8de039d...663911ed581d
< bitcoin-git> [bitcoin] laanwj closed pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390
< bitcoin-git> [bitcoin] MajorFireball opened pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12295: Enable flake8 warnings for all currently non-violated rules (master...accidental-redefinition-of-variable) https://github.com/bitcoin/bitcoin/pull/12295
< bitcoin-git> bitcoin/master a9d0ebc practicalswift: Enable flake8 warnings for all currently non-violated rules
< bitcoin-git> bitcoin/master 4cbab15 practicalswift: tests: Fix accidental redefinition of previously defined variable via list comprehension
< bitcoin-git> bitcoin/master 0b9207e practicalswift: Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812)
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3843780fd8e0...935eb8de039d
< gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336
< bitcoin-git> bitcoin/master a8e437a John Newbery: [tests] Remove estimatefee from rpc_deprecated.py test
< bitcoin-git> bitcoin/master a5623b1 John Newbery: [tests] Remove tests for deprecated estimatefee RPC
< bitcoin-git> bitcoin/master d119f2e John Newbery: [tests] Fix style warnings in feature_fee_estimation.py
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2645286745b...3843780fd8e0
< bitcoin-git> [bitcoin] laanwj closed pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
< bitcoin-git> bitcoin/master b264528 Wladimir J. van der Laan: Merge #12354: add gpg key for fivepiece...
< bitcoin-git> bitcoin/master 27736f2 fivepiece: add fivepiece key fingerprint
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1ffddb90d1b...b2645286745b
< bitcoin-git> [bitcoin] laanwj closed pull request #12298: Refactor HaveKeys to early return on false result (master...2018-01-ismine-havekeys) https://github.com/bitcoin/bitcoin/pull/12298
< bitcoin-git> bitcoin/master a1ffddb Wladimir J. van der Laan: Merge #12298: Refactor HaveKeys to early return on false result...
< bitcoin-git> bitcoin/master 5bdbbdc João Barbosa: Refactor HaveKeys to early return on false result
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9ca4f6024e0...a1ffddb90d1b
< gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12333 | Make CWallet::ListCoins atomic by promag · Pull Request #12333 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
< bitcoin-git> bitcoin/master c9ca4f6 Wladimir J. van der Laan: Merge #12371: Add gitian PGP key: akx20000...
< bitcoin-git> bitcoin/master b947d38 Akira Takizawa: Add gitian PGP key: akx20000
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ab4ee6e69242...c9ca4f6024e0
< bitcoin-git> bitcoin/0.16 a5e3d44 Wladimir J. van der Laan: doc: Update release notes from wiki (for rc3 PRs)...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/a5e3d44cc8f61f03a94d57302ff8c33c8f8a8689
< bitcoin-git> bitcoin/0.16 4f63a43 Wladimir J. van der Laan: qt: Pre-rc3 translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/4f63a43f6b0425b4cdd9211283017af375e18c90
< bitcoin-git> bitcoin/0.16 604f289 MarcoFalke: qt: Poll ShutdownTimer after init is done...
< bitcoin-git> bitcoin/0.16 0f207c4 Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
< bitcoin-git> bitcoin/0.16 09fc859 Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
< bitcoin-git> [bitcoin] laanwj pushed 11 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/da84760701dc...758a41e10045
< bitcoin-git> [bitcoin] laanwj closed pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315
< bitcoin-git> bitcoin/master ab4ee6e Wladimir J. van der Laan: Merge #12315: Bech32 addresses in dumpwallet...
< bitcoin-git> bitcoin/master 45eea40 fivepiece: Bech32 addresses in dumpwallet...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d57d10ee96a6...ab4ee6e69242
< bitcoin-git> [bitcoin] laanwj closed pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
< bitcoin-git> bitcoin/master d57d10e Wladimir J. van der Laan: Merge #12368: Hold mempool.cs for the duration of ATMP....
< bitcoin-git> bitcoin/master 02fc886 Matt Corallo: Add braces to meet code style on line-after-the-one-changed.
< bitcoin-git> bitcoin/master 85aa839 Matt Corallo: Hold mempool.cs for the duration of ATMP....
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6db4fa7ad329...d57d10ee96a6
< bitcoin-git> [bitcoin] Willtech opened pull request #12384: Docs: Edited /doc/tor.md (master...tor.md) https://github.com/bitcoin/bitcoin/pull/12384
< bitcoin-git> bitcoin/0.16 da84760 Wladimir J. van der Laan: Merge #12380: 0.16: Check in current release notes draft...
< bitcoin-git> bitcoin/0.16 d56355a MarcoFalke: 0.16: Check in current release notes draft
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/f17942a3bc81...da84760701dc
< bitcoin-git> [bitcoin] laanwj closed pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
< bitcoin-git> bitcoin/master 11e0151 Wladimir J. van der Laan: http: Remove numThreads and ThreadCounter...
< bitcoin-git> bitcoin/master f946654 Wladimir J. van der Laan: http: Remove WaitExit from WorkQueue...
< bitcoin-git> bitcoin/master b1c2370 Wladimir J. van der Laan: http: Join worker threads before deleting work queue...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/11f3eac79334...6db4fa7ad329
< bitcoin-git> [bitcoin] laanwj closed pull request #12374: qt: Make sure splash screen is freed on AppInitMain fail (master...2017_02_splash_abort) https://github.com/bitcoin/bitcoin/pull/12374
< bitcoin-git> bitcoin/master 11f3eac Wladimir J. van der Laan: Merge #12374: qt: Make sure splash screen is freed on AppInitMain fail...
< bitcoin-git> bitcoin/master 1e5d14b Wladimir J. van der Laan: qt: Clarify some comments...
< bitcoin-git> bitcoin/master f5a4c3d Wladimir J. van der Laan: qt: Make sure splash screen is freed on AppInitMain fail...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/36a927c52585...11f3eac79334
< bitcoin-git> [bitcoin] laanwj closed pull request #12377: qt: Poll ShutdownTimer after init is done (master...Mf1802-qtInitShutdown) https://github.com/bitcoin/bitcoin/pull/12377
< bitcoin-git> bitcoin/master 36a927c Wladimir J. van der Laan: Merge #12377: qt: Poll ShutdownTimer after init is done...
< bitcoin-git> bitcoin/master 2222bf0 MarcoFalke: qt: Poll ShutdownTimer after init is done
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7217ea2cc8dd...36a927c52585
< bitcoin-git> [bitcoin] laanwj closed pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
< bitcoin-git> bitcoin/master 7217ea2 Wladimir J. van der Laan: Merge #12367: Fix two fast-shutdown bugs...
< bitcoin-git> bitcoin/master dd2de47 Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
< bitcoin-git> bitcoin/master 1c9394a Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0277173b1def...7217ea2cc8dd
< bitcoin-git> [bitcoin] fanquake closed pull request #12382: Request Source Code Pull (master...master) https://github.com/bitcoin/bitcoin/pull/12382
< bitcoin-git> [bitcoin] pristantyo opened pull request #12382: Request Source Code Pull (master...master) https://github.com/bitcoin/bitcoin/pull/12382
< bitcoin-git> [bitcoin] theuni opened pull request #12381: Remove more boost threads (master...boost-threads-again) https://github.com/bitcoin/bitcoin/pull/12381
< contrapumpkin> have y'all looked at the Nix builds of bitcoin at all?

2018-02-07

< cfields> gmaxwell: yes. So far I have a minimal rootfs that's capable of building bitcoin. It's basically just busybox/make/toolchain. Dealing with kernels is just too far out of scope, though. Ideally, we'd just boot some minimal image in a vm, chroot, and make
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< dongcarl> hink of these possible changes. I refer to the container actually building the Bitcoin
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10498: Use static_cast instead of C-style casts for non-fundamental types (master...static_cast) https://github.com/bitcoin/bitcoin/pull/10498
< bitcoin-git> bitcoin/master 0277173 MarcoFalke: Merge #10498: Use static_cast instead of C-style casts for non-fundamental types...
< bitcoin-git> bitcoin/master 9ad6746 practicalswift: Use static_cast instead of C-style casts for non-fundamental types...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1462bde767a1...0277173b1def
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12380: 0.16: Check in current release notes draft (0.16...Mf1802-docRel16) https://github.com/bitcoin/bitcoin/pull/12380
< bitcoin-git> [bitcoin] jnewbery opened pull request #12379: [WIP] Better stderr testing in functional tests (master...test_full_stderr2) https://github.com/bitcoin/bitcoin/pull/12379
< Lauda> Try #bitcoin or #bitcoin-dev; this is the wrong channel for that.
< rooster__> I am implementing the bitcoin protocol in Android/Java. When I send a getaddr message, the peer responds with an alert message?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12377: qt: Avoid initialization during shutdown (master...Mf1802-qtInitShutdown) https://github.com/bitcoin/bitcoin/pull/12377
< bitcoin-git> [bitcoin] laanwj opened pull request #12374: qt: Make sure splash screen is freed on AppInitMain fail (master...2017_02_splash_abort) https://github.com/bitcoin/bitcoin/pull/12374
< bitcoin-git> [bitcoin] murrayn opened pull request #12373: Build: Add build support for profiling. (master...profiling) https://github.com/bitcoin/bitcoin/pull/12373
< hanzou> Well Bitcoin core has code such that a client will respond to getblocks, but it never sends it.
< gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub

2018-02-06

< gribble> https://github.com/bitcoin/bitcoin/issues/12372 | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). · Issue #12372 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] akx20000a opened pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12365 | Add ppa:bitcoin/bitcoin repository on linux problem · Issue #12365 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/25110 | HTTP Error 404: Not Found
< BlueMatt> cfields: well I never found any resolution to it? moc doesnt build bitcoin-qt right now....no idea why
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
< sipa> dongcarl: if you plan to regularly dongitian builds foe bitcoin core releases, you're very mufh encouraged to upload your key and do so:)
< gribble> https://github.com/bitcoin/bitcoin/issues/12366 | http: Join worker threads before deleting work queue by laanwj · Pull Request #12366 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12368 | Hold mempool.cs for the duration of ATMP. by TheBlueMatt · Pull Request #12368 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
< bitcoin-git> [bitcoin] laanwj opened pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
< gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< BlueMatt> the stupid patch at https://github.com/bitcoin/bitcoin/issues/12362#issuecomment-363503855 apparently works
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class. (master...patch/BaseRequestHandler-virtual-dtor) https://github.com/bitcoin/bitcoin/pull/12050
< bitcoin-git> bitcoin/master 1462bde Wladimir J. van der Laan: Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class....
< bitcoin-git> bitcoin/master bdb3231 251: Implements a virtual destructor on the BaseRequestHandler class....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ad320598f06...1462bde767a1
< bitcoin-git> [bitcoin] laanwj closed pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
< bitcoin-git> bitcoin/master 5ad3205 Wladimir J. van der Laan: Merge #12363: Update README after filename change...
< bitcoin-git> bitcoin/master 8a6c62b Conor Scott: [tests] Update README after filename change
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6cd41d93e12...5ad320598f06
< gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
< Randolf> It would also be nice to know whether some major ISPs have actively started blocking Bitcoin node traffic.
< Randolf> ossifrage: I wonder if some folks have simply stopped running Bitcoin nodes given the recent downturn in price. Or are you seeing the same number of initial connections as you did before?
< bitcoin-git> [bitcoin] laanwj closed pull request #12305: [docs] [refactor] Add help messages for datadir path mangling (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
< bitcoin-git> bitcoin/master f6cd41d Wladimir J. van der Laan: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling...
< bitcoin-git> bitcoin/master 5460460 James O'Beirne: Add AbsPathForConfigVal to consolidate datadir prefixing for path args...
< bitcoin-git> bitcoin/master a1e1305 James O'Beirne: Clarify help messages for path args to mention datadir prefix...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/88971352f610...f6cd41d93e12
< bitcoin-git> [bitcoin] laanwj closed pull request #11909: contrib: Replace developer keys with list of pgp fingerprints (master...Mf1712-gitianKeysDel) https://github.com/bitcoin/bitcoin/pull/11909
< bitcoin-git> bitcoin/master 8897135 Wladimir J. van der Laan: Merge #11909: contrib: Replace developer keys with list of pgp fingerprints...
< bitcoin-git> bitcoin/master fabb72b MarcoFalke: contrib: Remove xpired 522739F6 key
< bitcoin-git> bitcoin/master faeab66 MarcoFalke: contrib: Replace developer keys with list of pgp fingerprints
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3451483d283...88971352f610
< bitcoin-git> [bitcoin] conscott opened pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
< bitcoin-git> [bitcoin] laanwj closed pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325
< bitcoin-git> [bitcoin] laanwj closed pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322
< bitcoin-git> bitcoin/master c345148 Wladimir J. van der Laan: Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build....
< bitcoin-git> bitcoin/master eeeb416 murrayn: Remove suggestion to make cloned repository world-writable for Windows build.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a32114626fc...c3451483d283
< bitcoin-git> [bitcoin] laanwj closed pull request #12218: net: Move misbehaving logging to net logging category (master...2018_01_misbehaving_logging) https://github.com/bitcoin/bitcoin/pull/12218
< bitcoin-git> bitcoin/master 9a32114 Wladimir J. van der Laan: Merge #12218: net: Move misbehaving logging to net logging category...
< bitcoin-git> bitcoin/master d3a185a Wladimir J. van der Laan: net: Move misbehaving logging to net logging category...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eaeaa2d0b4e8...9a32114626fc
< wumpus> right might be that bitcoin-cli needs changes as well
< wumpus> btcd has this option: --rpcquirks Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless interoperability issues need to be worked around -- O dpm
< bitcoin-git> [bitcoin] laanwj closed pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
< bitcoin-git> bitcoin/master eaeaa2d Wladimir J. van der Laan: Merge #12342: Extend #11583 to include "version handshake timeout" message...
< bitcoin-git> bitcoin/master c887f87 Clem Taylor: Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a30e67d20f7...eaeaa2d0b4e8
< bitcoin-git> [bitcoin] laanwj closed pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
< sipa> conman: BIP173 (https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki) under "The following list gives valid segwit addresses and the scriptPubKey that they translate to in hex" gives you what you need

2018-02-05

< bitcoin-git> [bitcoin] promag opened pull request #12361: Replace unreachable error handling with assertions in feebumber (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361
< bitcoin-git> [bitcoin] fanquake closed pull request #11398: Hardcode CSV and SEGWIT deployment (master...csvburied) https://github.com/bitcoin/bitcoin/pull/11398
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330
< bitcoin-git> bitcoin/master 2a30e67 MarcoFalke: Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions...
< bitcoin-git> bitcoin/master c409b1a João Barbosa: [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32528e733f2...2a30e67d20f7
< gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12315 | Bech32 addresses in dumpwallet by fivepiece · Pull Request #12315 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #12360: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/12360
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
< bitcoin-git> [bitcoin] filips123 opened pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
< bitcoin-git> [bitcoin] Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
< bitcoin-git> [bitcoin] Empact opened pull request #12356: Fix 'mempool min fee not met' debug output (master...minfee-message) https://github.com/bitcoin/bitcoin/pull/12356
< bitcoin-git> [bitcoin] fivepiece opened pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
< bitcoin-git> [bitcoin] fivepiece closed pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
< bitcoin-git> [bitcoin] fivepiece opened pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
< bitcoin-git> [bitcoin] fanquake closed pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
< bitcoin-git> [bitcoin] murrayn opened pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
< bitcoin-git> [bitcoin] murrayn opened pull request #12351: Libraries: Use type more precisely indicating usage and avoid compilers warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351
< gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
< bitcoin-git> [bitcoin] kien999 opened pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
< conman> my pool code asks bitcoin core to validate addresses so if I upgrade to .16 without adding support it will likely create corrupt generation transactions for bech32

2018-02-04

< bitcoin-git> [bitcoin] theuni opened pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
< bitcoin-git> [bitcoin] filips123 opened pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12331: Docs: Properly alphabetize output of CLI --help option. (master...help_changes) https://github.com/bitcoin/bitcoin/pull/12331
< bitcoin-git> bitcoin/master d32528e MarcoFalke: Merge #12331: Docs: Properly alphabetize output of CLI --help option....
< bitcoin-git> bitcoin/master d3e4675 murrayn: Properly alphabetize output of CLI --help option.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/85123be78df5...d32528e733f2
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12347: python3 http module uses enum to define HTTP status codes (master...interface_http_status_patch) https://github.com/bitcoin/bitcoin/pull/12347
< bitcoin-git> [bitcoin] yashbhutwala opened pull request #12347: python3 http module uses enum to define HTTP status codes (master...interface_http_status_patch) https://github.com/bitcoin/bitcoin/pull/12347
< bitcoin-git> [bitcoin] practicalswift closed pull request #11754: wallet: Add missing cs_wallet locks when accessing m_last_block_processed (master...missing-m_last_block_processed-locks) https://github.com/bitcoin/bitcoin/pull/11754
< gribble> https://github.com/bitcoin/bitcoin/issues/12285 | Socket select error Bad file descriptor (9) after upgrading to master · Issue #12285 · bitcoin/bitcoin · GitHub
< gmaxwell> re messages with ERROR discussed earlier, ::sigh:: https://github.com/bitcoin/bitcoin/issues/12256#issuecomment-361513326

2018-02-03

< gribble> https://github.com/bitcoin/bitcoin/issues/9989 | [Doc] Removing references to Windows 32 bit from README by NicolasDorier · Pull Request #9989 · bitcoin/bitcoin · GitHub
< Murch> yeah, opinions vary a bit here, but Bitcoin Core should probably be more selective in spending uneconomic unspents.
< rhavar> i think i created some issues on the bitcoin repo to deal with that
< bitcoin-git> [bitcoin] sipa closed pull request #12345: Asymmetric encryption stubs. (master...master) https://github.com/bitcoin/bitcoin/pull/12345
< gribble> https://github.com/bitcoin/bitcoin/issues/12345 | Asymmetric encryption stubs. by Rutkouski · Pull Request #12345 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Rutkouski opened pull request #12345: Asymmetric encryption stubs. (master...master) https://github.com/bitcoin/bitcoin/pull/12345
< bitcoin-git> [bitcoin] clemtaylor opened pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
< gribble> https://github.com/bitcoin/bitcoin/issues/11583 | Do not make it trivial for inbound peers to generate log entries by TheBlueMatt · Pull Request #11583 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #12341: Correction in choice of words in QT (dutch) (master...201802030229-qt-dutch-lang-fix) https://github.com/bitcoin/bitcoin/pull/12341
< bitcoin-git> [bitcoin] RvMp opened pull request #12341: Correction in choice of words (master...201802030229-qt-dutch-lang-fix) https://github.com/bitcoin/bitcoin/pull/12341

2018-02-02

< cfields> achow101: testing bitcoin-qt ?
< BlueMatt> achow101: it should always crash if you quit bitcoin-qt while its loading
< BlueMatt> cfields: in bitcoind (and I was very sure bitcoin-qt) if AppInitMain ever *enters* it should still call Shutdown()
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< GitHub149> [bitcoin-detached-sigs] theuni closed pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
< GitHub24> [bitcoin-detached-sigs] jonasschnelli opened pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
< bitcoin-git> [bitcoin] jnewbery opened pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336
< bitcoin-git> [bitcoin] laanwj closed pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
< bitcoin-git> bitcoin/master 85123be Wladimir J. van der Laan: Merge #12317: Document method for reviewers to verify chainTxData...
< bitcoin-git> bitcoin/master 7444149 John Newbery: Document method for reviewers to verify chainTxData...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4cad91663df3...85123be78df5
< AndyS2> Newbie to C++ and bitcoin core here. I've been looking at EvalScript in interpreter.cpp, and from what I gathered it seems to push things onto 'stack' or return an error if something isn't kosher. But when/where is the stack actually 'executed'. EvalScript doesn't seem to evaluate the script anywhere I could see.
< bitcoin-git> [bitcoin] promag opened pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333
< meshcollider> A megabit is 1 bitcoin?
< gmaxwell> somewhere some french altcoiners people are cacking at bitcoiners trying get everyone to measure their bitcoin in millièmebite.
< provoostenator> gmaxwell: that's why I always nag about screenshots: https://github.com/bitcoin/bitcoin/pull/12035#issuecomment-354297195
< meshcollider> wumpus: can I join bitcoin-core too
< wumpus> invited provoostenator for bitcoin and bitcoin-core orgs
< wumpus> I do have a lot of bitcoin core stickers
< wumpus> provoostenator: I'm not sure; maybe someone still has a stack of bitcoin core t-shirts from one of the real life dev meetings
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/ (master...b16-segwit-test-fix) https://github.com/bitcoin/bitcoin/pull/11869
< bitcoin-git> bitcoin/master 4cad916 MarcoFalke: Merge #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/...
< bitcoin-git> bitcoin/master 9bb59cf Jorge Timón: QA: segwit.py: s/find_unspent/find_spendable_utxo/
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b06ed136f17...4cad91663df3
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12283: Fix typos (master...typos-20180128) https://github.com/bitcoin/bitcoin/pull/12283
< bitcoin-git> bitcoin/master 1b06ed1 MarcoFalke: Merge #12283: Fix typos...
< bitcoin-git> bitcoin/master 1340eda practicalswift: Fix typos
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa360e76a74b...1b06ed136f17
< gribble> https://github.com/bitcoin/bitcoin/issues/12330 | Reduce scope of cs_main and cs_wallet locks in listtransactions by promag · Pull Request #12330 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.16 f17942a Wladimir J. van der Laan: qt: Pre-rc2 translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/f17942a3bc810d981724228bb5c99b5fb572efbe
< bitcoin-git> [bitcoin] laanwj closed pull request #12329: net: don't retry failed oneshot connections forever (master...no-infinite-oneshot) https://github.com/bitcoin/bitcoin/pull/12329