< bitcoin-git>
bitcoin/master c84c2b8 practicalswift: tests: Test for expected return values when calling functions returning a success code
< bitcoin-git>
bitcoin/master 9133227 MarcoFalke: Merge #14935: tests: Test for expected return values when calling functions returning a success code...
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] promag opened pull request #14958: qa: Remove race between conneting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 0e75f44 Pieter Wuille: Replace CAffectedKeysVisitor with descriptor based logic
< bitcoin-git>
bitcoin/master 7a30e0f MeshCollider: Merge #14821: Replace CAffectedKeysVisitor with descriptor based logic...
< gmaxwell>
I'm no longer a commiter on bitcoin, I'd be interested in knowing how often commiters are manually resolving conflicts on master. I believe the answer is rarely but not never.
< harding>
lopp: under the default GitHub settings, anyone with commit access can push anything they want, so they could pull a PR into a private branch, modify it, merge it locally, and push it. Some projects enable GitHub settings that prevent direct pushes like that to the master branch, but I'm not sure whether Bitcoin Core uses them. Alternatively, when you open a GitHub PR, a box is checked by default that allows people with commit
2018-12-13
< gmaxwell>
moreover, that data is there-- go use a block explorer, there is no need a bitcoin wallet or node need to provide it.
< gmaxwell>
To actually _use_ bitcoin I need that data... vs history is needed for analysis/auditing/etc purposes.
< gmaxwell>
but like, _ignoring that_ (lol), in terms of actually switching bitcoin to use it, I expect it would be easier than utxotree.
< gmaxwell>
But "oh look spending patterns changed and with no impact in fees, bandwidth needed by bitcoin nodes just went up 5x" isn't the same as saying dbcache works better with more locality.
< gmaxwell>
unless you think that downloading bitcoin node software written by other people and not doing the work of writing it yourself is giving up. :P
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gmaxwell>
jamesob: and moreover, with the exception of ultra high end commercial installs, few users would have the resources or patience to fetch 15 years of bitcoin history.
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus>
jamesob: it contains writable settings which override what is in bitcoin.conf
< jamesob>
*bitcoin.conf.qt
< wumpus>
I'm unconfortable with writing to bitcoin.conf directly, as it is specified with -conf, which might point to a read-only configuration file, it should not be assumed it is writable
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< andytoshi>
ok. the reason i ask is that in Elements we are directly using sha2 midstates to get the same speedup (which ofc changes the hash function so is completely incompatible with bitcoin)
< andytoshi>
sipa: i'm confused by https://github.com/bitcoin/bitcoin/pull/13191 ... it seems the new SHA256D64 does not append the sha256 length/padding anywhere, so how can `ComputeMerkleRoot` be consensus-compatible with the old code?
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14937: travis: fix travis would always be green even if it fail (master...travis-fix-save-cache-2) https://github.com/bitcoin/bitcoin/pull/14937
< timothy>
do you REALLY want to run something like bitcoin on an unsupported OS?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935
< fanquake>
Would be interested to know if there are many/any? users running Bitcoin-Core on Windows Vista. Could use some more input in #14922.
< bitcoin-git>
bitcoin/master 6be0fb4 Pieter Wuille: [refactor] Add a base DescriptorImpl with most common logic
< bitcoin-git>
bitcoin/master 24d3a7b Pieter Wuille: [refactor] Use DescriptorImpl internally, permitting access to new methods
< bitcoin-git>
bitcoin/master 1eda33a Pieter Wuille: [refactor] Combine the ToString and ToPrivateString implementations
< bitcoin-git>
[bitcoin] MeshCollider closed pull request #14646: Add expansion cache functions to descriptors (unused for now) (master...201811_descriptcache) https://github.com/bitcoin/bitcoin/pull/14646
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14932: ui: Warn the user on file corruption in mempool.dat (master...Mf1812-testFileCorruption) https://github.com/bitcoin/bitcoin/pull/14932
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14931: test: mempool_persist: Verify prioritization is dumped correctly (master...Mf1812-testMempoolPrio) https://github.com/bitcoin/bitcoin/pull/14931
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14930: test: pruning: Check that verifychain can be called when pruned (master...Mf1812-testPruneVerify) https://github.com/bitcoin/bitcoin/pull/14930
2018-12-11
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #14929: Allow connections from misbehavior banned peers. (master...201812-softbanmisbehaving) https://github.com/bitcoin/bitcoin/pull/14929
< bitcoin-git>
bitcoin/master 522b80b qubenix: add `--retry 5` to curl opts in install_db4.sh
< bitcoin-git>
bitcoin/master d680ef9 MarcoFalke: Merge #14883: add `--retry 5` to curl opts in install_db4.sh...
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14926: test: consensus: Check that final transactions are valid (master...Mf1812-testConsensusFinal) https://github.com/bitcoin/bitcoin/pull/14926
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14925: test: Correctly deserialize without witness (master...Mf1812-testWitnessDeser) https://github.com/bitcoin/bitcoin/pull/14925
< gribble>
https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14853 | [wip] depends: latest rapidcheck, enable property based tests on Travis by fanquake · Pull Request #14853 · bitcoin/bitcoin · GitHub
< fanquake>
Chris_Stewart_5 Yes I think so. The bitcoin related test which is failing seems too simple? to be the cause.
< provoostenator>
I'm rebuilding my unsigned ones first because it was complaining about "cp: cannot stat 'inputs/bitcoin-0.17.1rc1-win-unsigned.tar.gz"
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14918: RPCHelpMan: Check default values are given at compile-time (master...Mf1812-rpcOptionalCompile) https://github.com/bitcoin/bitcoin/pull/14918
< arch>
I apologize in advance if this was already answered somewhere, and will state in advance. Curious on a couple patch mgmt/versioning pieces with bitcoin-core.
< arch>
Since Berkeley DB (bdb) for database management was switched over to LevelDB in release 0.8 to reduce blockchain synchronization time, why does bdb remain in bitcoin/tree/master/depends/packages?
< bitcoin-git>
[bitcoin] jnewbery closed pull request #14888: Fix createrawtransaction multi op return - issue #14868 (master...fix-createrawtransaction-multi-OP_RETURN) https://github.com/bitcoin/bitcoin/pull/14888
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14893: 0.17 [Backport 14890] rpc: Avoid creating non-standard raw transactions (0.17...Mf1812-17Backports) https://github.com/bitcoin/bitcoin/pull/14893
< bitcoin-git>
[bitcoin] laanwj closed pull request #14884: Travis: enforce Python 3.4 support through linter (master...2018/12/python-3-4) https://github.com/bitcoin/bitcoin/pull/14884
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14795: test: allows test_runner command line to receive parameters for each test (master...fix_test_runner_parameters) https://github.com/bitcoin/bitcoin/pull/14795
< bitcoin-git>
bitcoin/master 2b12268 Wladimir J. van der Laan: Merge #14854: qt: Cleanup SplashScreen class...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread (master...drop-boost-thread-import) https://github.com/bitcoin/bitcoin/pull/14480
< bitcoin-git>
bitcoin/master b7df96f Chun Kuan Lee: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread
< bitcoin-git>
bitcoin/master b8b0b8c Wladimir J. van der Laan: Merge #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14863: refactor: Add and use HaveTxsDownloaded() where appropriate (master...Mf1812-docNchainTx) https://github.com/bitcoin/bitcoin/pull/14863
< gribble>
https://github.com/bitcoin/bitcoin/issues/14480 | refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread by ken2812221 · Pull Request #14480 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564
< bitcoin-git>
bitcoin/master 58c5cc9 James Hilliard: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI
< bitcoin-git>
bitcoin/master 23a1fa0 MarcoFalke: Merge #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI...
< bitcoin-git>
[bitcoin] isghe opened pull request #14888: Fix createrawtransaction multi op return - issue #14868 (master...fix-createrawtransaction-multi-OP_RETURN) https://github.com/bitcoin/bitcoin/pull/14888