< bitcoin-git>
[bitcoin] jbampton opened pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< bitcoin-git>
[bitcoin] mrwhythat opened pull request #14533: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/14533
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git>
[bitcoin] promag opened pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14530: scripted-diff: Use RPCHelpMan on RPCs with no args (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git>
[bitcoin] laanwj closed pull request #14527: qa: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< bitcoin-git>
bitcoin/master fadffae MarcoFalke: Revert "Make qt wallet test compatible with qt4"...
< bitcoin-git>
bitcoin/master 96c409c Wladimir J. van der Laan: Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"...
< fanquake>
Chris_Stewart_5 See the channel history, we've forked rapidcheck to bitcoin-core, could be a chance to use the new make install method etc. You should have gotten invite to /bitcoin and /bitcoin-core as well.
< midnightmagic>
still burns me atmel dropped avr for arm. wumpus: well if it does anything interesting with the bitcoin node, I know I at least would love to hear about it.
< wumpus>
yes, bitcoin runs ok, syncing doesn't go super fast but it was a bit faster than most ARM boards from a few years ago I've tried on
< wumpus>
midnightmagic: well... currently only run OpenBSD in VM; and yes, bitcoin builds fine on OpenBSD, there's special instructions for that, which fanquake updated for 6.4 and I'l like to test out but couldn't yet
< jarthur>
jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
< gribble>
https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
< andytoshi>
meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core"
< midnightmagic>
wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time.
< bitcoin-git>
[bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
< bitcoin-git>
[bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
< bitcoin-git>
[bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
< wumpus>
luke-jr: a bitcoin core-tor bundle has been talked about since 2012 at least
< luke-jr>
says the guy who wrote bitcoin-qt..
< wumpus>
yess I'm... not sure how I got involved in this at all tbh, I made bitcoin-qt because I thought it would help get actual GUI people invovled, make it easier for them
< wumpus>
as you can't really make an assumption about the precision, yes if you write software for bitcoin specifically you can hardcode 10^-8, but anythign that needs to interface between different systems and APIs and databases needs to convert between them on their own terms
< gmaxwell>
phantomcircuit: the old json library bitcoin used to use randomly inserted conversions to float in a minor upgrade!
< gmaxwell>
phantomcircuit: depends on what you mean by float, common bitcoin values don't fit precisely in 32-bit floats, they do in 64-bit doubles.
< wumpus>
gmaxwell: yes, it's trivial change to ValueFromAmount if you really want to, though I'd suggest looking at a better suited JSONRPC library, by now for most languages there's something for bitcoin specifically
< gmaxwell>
in Bitcoin core they're just 64 bit integers.
< sipa>
karelb: also, inside bitcoin core there no conversion of amounts to floats ever (except feerates), even to convert to JSON
< bitcoin-git>
[bitcoin] Sjors opened pull request #14509: [doc] getblocktemplate: use SegWit in example (0.17...2018/10/backport-doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14509
< karelb>
thinking out loud- yesterday we talked with colleague how we hate that JSON RPC returns BTC values as floats. (at various points.) Do you think it would be a good idea to be able to somehow switch this with some option? either option for whole bitcoind, or just another parameter for bitcoin-cli
< bitcoin-git>
[bitcoin] laanwj closed pull request #14472: [doc] getblocktemplate: use SegWit in example (master...2018/10/doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14472
< bitcoin-git>
[bitcoin] laanwj closed pull request #14370: utils and libraries: Allow values quoting in config files (master...20181002-config-quotes) https://github.com/bitcoin/bitcoin/pull/14370
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14505: Make all single parameter constructors explicit (C++11) (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
< promag>
ken2812221: do you build bitcoin-qt with msvc?
< bitcoin-git>
[bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
< bitcoin-git>
bitcoin/master ee0b7c4 practicalswift: build: Pin to specific versions of Python packages we install from PyPI in Travis
< bitcoin-git>
bitcoin/master 3036faf Wladimir J. van der Laan: Merge #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis...
< gmaxwell>
indeed, we've had people in #bitcoin that were having issues because some third party was trying to password bruteforce their rpc port or something like that..
< echeveria>
all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software.
< gmaxwell>
"We build the software that Bitcoin deserves" ... just so.
< gmaxwell>
"Use your personal node to broadcast transactions to the bitcoin network"
< echeveria>
gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin.
< bitcoin-git>
bitcoin/master edb5350 Patrick Strateman: Move NotifyNumConnectionsChanged logic to private method.
< bitcoin-git>
bitcoin/master 7479b63 Patrick Strateman: Move DisconnectNodes logic to private method.
< bitcoin-git>
bitcoin/master 2af9cff Patrick Strateman: Move InactivityCheck logic to private method.
< bitcoin-git>
[bitcoin] DesWurstes closed pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
< ken2812221__>
Copy bitcoin-cli.exe and bitcoind.exe into src folder. Modify and copy test\config.ini.in to test\config.ini. Then you can run python test\functional\test_runner.py --force.
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
< bitcoin-git>
bitcoin/master 36323e2 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
< bitcoin-git>
bitcoin/master 9bd3ff4 Wladimir J. van der Laan: Merge #14383: qt: Clean system tray icon menu for '-disablewallet' mode...
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
< kallewoof>
How does bitcoin core track bip9 activation states? I have odd cases where a copied chain state will result in all bip9 soft forks turning up as "failed" rather than "activated". If I disable the timeout, they show up as 'started', but with 'possible: false'.
2018-10-15
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
< bitcoin-git>
[bitcoin] achow101 closed pull request #14019: Import pubkeys when importing p2sh with importmulti (master...import-multi-pubkeys) https://github.com/bitcoin/bitcoin/pull/14019
< bitcoin-git>
[bitcoin] DesWurstes opened pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
< bitcoin-git>
bitcoin/master 2a2cac7 Jonas Schnelli: Merge #14424: Stop requiring imported pubkey to sign non-PKH schemes...
< bitcoin-git>
[bitcoin] HatboyWonder opened pull request #14484: changed request payment button text and tab description (master...master) https://github.com/bitcoin/bitcoin/pull/14484
< karelb>
Also - how much does bitcoin (at least new code) use all the const correctness stuff? I never know how to write it correctly and where to add `const`
< karelb>
"Class member variables have a m_ prefix" - I don't see that in many class variables in bitcoin codebase?