2016-11-22

< gribble> https://github.com/bitcoin/bitcoin/issues/9177 | NOMERGE: WIP: Support block signed custom testchains by jtimon · Pull Request #9177 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jtimon> updated https://github.com/bitcoin/bitcoin/pull/9177 's description
< bitcoin-git> [bitcoin] btcdrak opened pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206
< bitcoin-git> [bitcoin] in3rsha opened pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205
< bitcoin-git> [bitcoin] instagibbs opened pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9130: Mention the new network toggle functionality in the tooltip. (master...20161111_disable_network_tooltip) https://github.com/bitcoin/bitcoin/pull/9130
< bitcoin-git> bitcoin/master ac489b2 Jonas Schnelli: Merge #9130: Mention the new network toggle functionality in the tooltip....
< bitcoin-git> bitcoin/master 1260c11 Pavel Janík: Mention the new network toggle functionality in the tooltip.
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55b2eddcc8fd...ac489b24453c
< bitcoin-git> [bitcoin] jnewbery closed pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
< bitcoin-git> [bitcoin] jnewbery opened pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
< wumpus> this is not related to bitcoin core development, can you move this to #bitcoin?
< bitcoin-git> [bitcoin] laanwj opened pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202
< bitcoin-git> [bitcoin] laanwj closed pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
< bitcoin-git> bitcoin/master 55b2edd Wladimir J. van der Laan: Merge #9200: bench: Fix subtle counting issue when rescaling iteration count...
< bitcoin-git> bitcoin/master e0a9cb2 Wladimir J. van der Laan: bench: Fix subtle counting issue when rescaling iteration count...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4dbeb94998d...55b2eddcc8fd
< luke-jr> Victorsueca: p.s. if you want to mine testnet with it, tmp.pool.bitcoin.dashjr.org port 3334 (stratum) or 8337 (GBT & getwork)
< thermoman> gmaxwell, sipa, sdaftuar: https://github.com/bitcoin/bitcoin/issues/9201
< Victorsueca> is it safe if I move all from bitcoin to "" or I would mess with the wallet balance calculation?
< jouke> Basically the same use case as dooglus in https://github.com/bitcoin/bitcoin/issues/3816
< bitcoin-git> [bitcoin] laanwj opened pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
< wumpus> agree that tooling documentation would be useful, though none of this is specific to bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
< jonasschnelli> wumpus: how did you detected the Qt leaks? IMO last time I used it on Bitcoin-Qt on Ubuntu I had to force shutdown my machine.. :)
< bitcoin-git> bitcoin/master e4dbeb9 Jonas Schnelli: Merge #9185: [Qt] fix coincontrol sort issue...
< bitcoin-git> bitcoin/master 4231032 Wladimir J. van der Laan: [Qt] Clean up and fix coincontrol tree widget handling...
< bitcoin-git> bitcoin/master 76af4eb Jonas Schnelli: [Qt] fix coincontrol sort issue
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c577f2638b7...e4dbeb94998d
< gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
< wumpus> the most sneaky leak (and also most bytes wasted) I fixed in #9190 was the openssl certstore one (https://github.com/bitcoin/bitcoin/pull/9190/commits/4b2c2888868cb49806cd734ea36e7f5b032c3b00) . OpenSSL's documentation is somewhat fuzzy about it, but the assumption there was wrong, that X509_STORE_add_cert really tkaes ownership
< fanquake> Have only tested with bitcoin-qt so far, I'll look at bitcoind now.
< gribble> https://github.com/bitcoin/bitcoin/issues/9000 | miner debugging: faux-mining by theuni · Pull Request #9000 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9199: Always drop the least preferred HB peer when adding a new one. (master...remove_high_bandwidth_zombies) https://github.com/bitcoin/bitcoin/pull/9199

2016-11-21

< skyraider> it might help to put on a client's shoes here. context was https://github.com/petertodd/python-bitcoinlib/pull/128 in which a blind retry python decorator was considered. turns out this can a) result in actually sending bitcoin multiple times, b) result in decisions made on stale read data (balance was just an example - really any bitcoind state subject to
< skyraider> yes, sorry, shorthand for "try to send some bitcoin"
< skyraider> uh, yeah, not bitcoin transaction. isolation as in the I from ACID.
< skyraider> so 'read before you try to send lots of bitcoin' - alright. but if another RPC connection writes in the meantime, won't my read be stale, or is there transaction isolation somehow? is the recommended policy therefore 'only ever use a single RPC writer' ?
< bsm1175321> sipa: the fix here: https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/test_framework/authproxy.py#L134 looks like it is effectively a retry, and would, e.g. sendmany again.
< kanzure> okay i posted an issue about the abovementioned rpc replay protection concerns https://github.com/bitcoin/bitcoin/issues/9197
< gribble> https://github.com/bitcoin/bitcoin/issues/9194 | Add flags to getrawtransaction and getblock to return non-segwit seri… by instagibbs · Pull Request #9194 · bitcoin/bitcoin · GitHub
< thermoman> from bitcoin.conf on proxy node
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9196: Send tip change notification from invalidateblock (master...pr/notify-tip) https://github.com/bitcoin/bitcoin/pull/9196
< bitcoin-git> [bitcoin] laanwj closed pull request #8872: Remove block-request logic from INV message processing (master...fetchflags2) https://github.com/bitcoin/bitcoin/pull/8872
< bitcoin-git> bitcoin/master 037159c Matt Corallo: Remove block-request logic from INV message processing
< bitcoin-git> bitcoin/master d768f15 mrbandrews: [qa] Make comptool push blocks instead of relying on inv-fetch
< bitcoin-git> bitcoin/master 3451203 Matt Corallo: [qa] Respond to getheaders and do not assume a getdata on inv
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/210891143ba0...0c577f2638b7
< bitcoin-git> [bitcoin] laanwj closed pull request #8837: allow bitcoin-tx to parse partial transactions (master...bitcoin-tx-partial-transactions) https://github.com/bitcoin/bitcoin/pull/8837
< bitcoin-git> bitcoin/master 2108911 Wladimir J. van der Laan: Merge #8837: allow bitcoin-tx to parse partial transactions...
< bitcoin-git> bitcoin/master 7451cf5 jnewbery: Allow bitcoin-tx to parse partial transactions...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b9a87b459d25...210891143ba0
< bitcoin-git> [bitcoin] laanwj closed pull request #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute (master...Mf1611-blockFreeTxs) https://github.com/bitcoin/bitcoin/pull/9179
< bitcoin-git> bitcoin/master fa7cc5a MarcoFalke: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
< bitcoin-git> bitcoin/master b9a87b4 Wladimir J. van der Laan: Merge #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3906403c8ed...b9a87b459d25
< wumpus> my preference would be the shorter name, it *is* bitcoin we don't have any other context where we use address/pubkey/privkey
< gribble> https://github.com/bitcoin/bitcoin/issues/8811 | rpc: Add support for JSON-RPC named arguments by laanwj · Pull Request #8811 · bitcoin/bitcoin · GitHub
< instagibbs> wumpus, I'm not an old timer, which is why I'm asking more basic account questions. It's always been deprecated in my Bitcoin lifetime :P
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< bitcoin-git> [bitcoin] laanwj closed pull request #9117: net: don't send feefilter messages before the version handshake is complete (master...feefilter-assert) https://github.com/bitcoin/bitcoin/pull/9117
< bitcoin-git> bitcoin/master c390640 Wladimir J. van der Laan: Merge #9117: net: don't send feefilter messages before the version handshake is complete...
< bitcoin-git> bitcoin/master 4662553 Cory Fields: net: don't send feefilter messages before the version handshake is complete
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7490ae8b699d...c3906403c8ed
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9125: Make CBlock a vector of shared_ptr of CTransactions (master...sharedblock) https://github.com/bitcoin/bitcoin/pull/9125
< bitcoin-git> bitcoin/master 1662b43 Pieter Wuille: Make CBlock::vtx a vector of shared_ptr<CTransaction>
< bitcoin-git> bitcoin/master da60506 Pieter Wuille: Add deserializing constructors to CTransaction and CMutableTransaction
< bitcoin-git> bitcoin/master 0e85204 Pieter Wuille: Add serialization for unique_ptr and shared_ptr
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/44adf683ad23...7490ae8b699d
< bitcoin-git> [bitcoin] laanwj closed pull request #9193: Update copyright year to 2016 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9193

2016-11-20

< bitcoin-git> [bitcoin] instagibbs opened pull request #9194: Add flags to getrawtransaction and getblock to return non-segwit seri… (master...nonswserialrpc) https://github.com/bitcoin/bitcoin/pull/9194
< bitcoin-git> [bitcoin] ShamimLike opened pull request #9193: Update copyright year to 2016 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9193

2016-11-19

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9159: [qa] Wait for specific block announcement in p2p-compactblocks (master...cmpct-announce-wait) https://github.com/bitcoin/bitcoin/pull/9159
< bitcoin-git> bitcoin/master 44adf68 MarcoFalke: Merge #9159: [qa] Wait for specific block announcement in p2p-compactblocks...
< bitcoin-git> bitcoin/master dfa44d1 Russell Yanofsky: [qa] Wait for specific block announcement in p2p-compactblocks...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce612f175063...44adf683ad23
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9191: [qa] 0.13.2 Backports (0.13...Mf1611-q01302) https://github.com/bitcoin/bitcoin/pull/9191
< sipa> it's probably a relatively good way to understand the design of bitcoin, but it's not that helpful to learn how the code works now
< luke-jr> but in case he reads the log: I don't recommend reading the earliest code as a way to learn about Bitcoin. It was a mess, and included a lot of features later discarded (eg, built-in marketplace)
< meownow> im currently reading through the first commit of the bitcoin source code onto github. seems a good way to familiarize myself with the core of the code base and what it does.
< bitcoin-git> [bitcoin] laanwj closed pull request #9186: test: Fix use-after-free in scheduler tests (master...2016_11_scheduler_fix) https://github.com/bitcoin/bitcoin/pull/9186
< bitcoin-git> bitcoin/master ce612f1 Wladimir J. van der Laan: Merge #9186: test: Fix use-after-free in scheduler tests...
< bitcoin-git> bitcoin/master 12519bf Wladimir J. van der Laan: test: Fix use-after-free in scheduler tests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9346f8429957...ce612f175063
< bitcoin-git> [bitcoin] laanwj opened pull request #9190: qt: Plug many memory leaks (master...2016_11_plug_leaks) https://github.com/bitcoin/bitcoin/pull/9190
< meownow> can anyone summarize when i download the bitcoin source code on the github, what is the client i am downloading able to actually do?

2016-11-18

< bitcoin-git> [bitcoin] sipa opened pull request #9189: Always add default_witness_commitment with GBT client support (master...alwayscommit) https://github.com/bitcoin/bitcoin/pull/9189
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9188: Make orphan parent fetching ask for witnesses. (master...witness_the_orphans) https://github.com/bitcoin/bitcoin/pull/9188
< sipa> (which is irrelevant, as bitcoin core is not used for mining)
< sipa> but it's not what bitcoin core does
< cfields> sipa: did i misunderstand your intention here? https://botbot.me/freenode/bitcoin-core-dev/2016-08-11/?msg=71172676&page=4
< bitcoin-git> [bitcoin] laanwj opened pull request #9186: test: Fix use-after-free in scheduler tests (master...2016_11_scheduler_fix) https://github.com/bitcoin/bitcoin/pull/9186
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9185: [Qt] fix coincontrol sort issue (master...2016/11/fix_cc_sort) https://github.com/bitcoin/bitcoin/pull/9185
< luke-jr> sipa: protocol changes need consensus. we can't force them on people. but it only takes good willed miners to use pro-Bitcoin policys.
< dermoth> yeah and my apologies; I though I was in #bitcoin-dev (not -core-)
< sipa> dermoth, rabidus: also, please take this to #bitcoin
< rabidus> you would kill the "store of value" property of bitcoin
< dermoth> I think after a certain number of bitcoin cycles (210k blocks) we could scavenge all unspent coins from the oldest 210k block, put them in a pool and let miners siphon 1/210000th of that pool every block. At that point the older part of the chain could be completely dropped as it would no longer have any use, and pooling the fund would ensure miners get a predictable reward.
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9183: Final Preparation for main.cpp Split (master...net_processing_5) https://github.com/bitcoin/bitcoin/pull/9183
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #8930: Move orphan processing to ActivateBestChain (master...net_processing_3) https://github.com/bitcoin/bitcoin/pull/8930
< * jtimon> re-asks for review on https://github.com/bitcoin/bitcoin/pull/8855
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub

2016-11-17

< bitcoin-git> [bitcoin] mruddy opened pull request #9180: WIP: remove script checking dependency on checkpoints v2 (master...isburied) https://github.com/bitcoin/bitcoin/pull/9180
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute (master...Mf1611-blockFreeTxs) https://github.com/bitcoin/bitcoin/pull/9179
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #9014: Fix block-connection performance regression (master...2016-10-fix-tx-regression) https://github.com/bitcoin/bitcoin/pull/9014
< BlueMatt> jtimon/sipa do we care about https://github.com/bitcoin/bitcoin/pull/9075/files#r88568772 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/707 | Implement BIP 14 : separate protocol version from client version by gavinandresen · Pull Request #707 · bitcoin/bitcoin · GitHub
< meownow> oops, this pull request: https://github.com/bitcoin/bitcoin/pull/63
< gribble> https://github.com/bitcoin/bitcoin/issues/9142 | Move -salvagewallet, -zap(wtx) to where they belong by jonasschnelli · Pull Request #9142 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #9075: Decouple peer-processing-logic from block-connection-logic (#3) (master...net_processing_4) https://github.com/bitcoin/bitcoin/pull/9075
< bitcoin-git> bitcoin/master ae22357 Matt Corallo: Replace CValidationState param in ProcessNewBlock with BlockChecked
< bitcoin-git> bitcoin/master 7c98ce5 Matt Corallo: Remove pfrom parameter from ProcessNewBlock...
< bitcoin-git> bitcoin/master e2e069d Matt Corallo: Revert "RPC: Give more details when "generate" fails"...
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8b2a82618be...9346f8429957
< bitcoin-git> [bitcoin] mruddy closed pull request #9175: WIP: remove script checking dependency on checkpoints (master...script_check) https://github.com/bitcoin/bitcoin/pull/9175
< wumpus> many people only use their bitcoin wallet with wifi so could care less about bandwidth usage
< wumpus> we're just nopt using BIP37 for the light wallet mode in bitcoin core. If you want to use it in your wallet go ahead.
< gmaxwell> Chris_Stewart_5: besides, fetching blocks is 14kb/s ongoing (28kb/s perhaps soon)-- most people running bitcoin core can handle that without batting an eye.
< gmaxwell> jonasschnelli: political discussion to ##bitcoin.
< jonasschnelli> sipa: \o/ new navigation on http://bitcoin.sipa.be
< gribble> https://github.com/bitcoin/bitcoin/issues/9171 | Introduce auxiliary block requests by jonasschnelli · Pull Request #9171 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9075 | Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt · Pull Request #9075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9075 | Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt · Pull Request #9075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9171 | Introduce auxiliary block requests by jonasschnelli · Pull Request #9171 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< MarcoFalke_web> #action look at https://github.com/bitcoin/bitcoin/pull/7729
< gmaxwell> "Bitcoin developers oppose accountability."
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< wumpus> so I proposed a label API to replace accounts at the start of this year, it still hasn't had much review yet: https://github.com/bitcoin/bitcoin/pull/7729
< jonasschnelli> sipa: have a look at https://github.com/bitcoin/bitcoin/pull/8745
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8589 | Inline CTxInWitness inside CTxIn (on top of #8580) by sipa · Pull Request #8589 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< Chris_Stewart_5> I guess my real question is could 'F' in the examples be a LOW_S sig https://github.com/bitcoin/bips/blob/master/bip-0146.mediawiki#examples
< Chris_Stewart_5> and if so, how can this fail immediately without checking the signature: https://github.com/bitcoin/bitcoin/blob/35fe0393f216aa6020fc929272118eade5628636/src/script/interpreter.cpp#L880
< bitcoin-git> bitcoin/master a8b2a82 Wladimir J. van der Laan: Merge #9156: Add compile and link options echo to configure...
< bitcoin-git> [bitcoin] laanwj closed pull request #9156: Add compile and link options echo to configure (master...2016/11/configure) https://github.com/bitcoin/bitcoin/pull/9156
< bitcoin-git> bitcoin/master d8274bc Jonas Schnelli: Add compile and link options echo to configure
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aaca05c0dabd...a8b2a82618be
< Chris_Stewart_5> I get why we have all the other checks inside of CheckSignatureEncoding: https://github.com/bitcoin/bitcoin/blob/35fe0393f216aa6020fc929272118eade5628636/src/script/interpreter.cpp#L185
< bitcoin-git> [bitcoin] laanwj closed pull request #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core" (master...Mf1611-doc) https://github.com/bitcoin/bitcoin/pull/9178
< bitcoin-git> bitcoin/master fa63ee8 MarcoFalke: Doxygen: Set PROJECT_NAME = "Bitcoin Core"
< bitcoin-git> bitcoin/master aaca05c Wladimir J. van der Laan: Merge #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core"...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6db48ad1c8f...aaca05c0dabd
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core" (master...Mf1611-doc) https://github.com/bitcoin/bitcoin/pull/9178
< bitcoin-git> [bitcoin] Christewart closed pull request #9174: Modifying incorrect comments from BIP66 -> BIP62 (master...master) https://github.com/bitcoin/bitcoin/pull/9174
< bitcoin-git> bitcoin/master f6db48a Wladimir J. van der Laan: Merge #8838: Calculate size and weight of block correctly in CreateNewBlock()...
< bitcoin-git> bitcoin/master 5f274a1 jnewbery: log block size and weight correctly.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb2ed300a89e...f6db48ad1c8f
<@wumpus> what is the proper way to pass arguments to the secp256k1 configure script that is invoked by bitcoin's?
< bitcoin-git> [bitcoin] jtimon opened pull request #9177: NOMERGE: WIP: Support block signed custom testchains (master...0.13-blocksign) https://github.com/bitcoin/bitcoin/pull/9177
< bitcoin-git> [bitcoin] jtimon opened pull request #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() (master...0.13-chainparams-loadblockindexguts) https://github.com/bitcoin/bitcoin/pull/9176
< bitcoin-git> [bitcoin] mruddy opened pull request #9175: remove script checking dependency on checkpoints (master...script_check) https://github.com/bitcoin/bitcoin/pull/9175
< luke-jr> #bitcoin is the support channel btw
< bitcoin-git> [bitcoin] Christewart opened pull request #9174: Modifying incorrect comments from BIP66 -> BIP62 (master...master) https://github.com/bitcoin/bitcoin/pull/9174
< shangzhou> bitcoin.org's download link.
< shangzhou> gmaxwell: i did some search this morning at baidu. Searched "c1726ccc50635795c942c7d7e51d979c4f83a3d17f8982e9d02a114a15fef419" only one result (a thread http://8btc.com/thread-41510-1-5.html) someone use Avast complain that bitcoin 0.13.1 win exe downloaded from bitcoin.org was blocked by the avast. Search something like "bitcoin 0.13.1 win exe" top one is
< BlueMatt> -rw------- 1 matt matt 1.7T Nov 16 16:44 /home/matt/.bitcoin/debug.log

2016-11-16

< Chris_Stewart_5> Why does this test fail for EVAL_FALSE and not WITNESS_PROGRAM_MISMATCH? https://github.com/bitcoin/bitcoin/blob/master/src/test/data/script_tests.json#L1257
< theymos> fyi, some apparently-popular antivirus is flagging Bitcoin Core 0.13.1: https://www.virustotal.com/en/file/c1726ccc50635795c942c7d7e51d979c4f83a3d17f8982e9d02a114a15fef419/analysis/
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9173: demo (master...master) https://github.com/bitcoin/bitcoin/pull/9173
< bitcoin-git> [bitcoin] demodun opened pull request #9173: demo (master...master) https://github.com/bitcoin/bitcoin/pull/9173
< bitcoin-git> [bitcoin] laanwj reopened pull request #8747: [rpc] Fix transaction size comments and RPC help text. (master...rpc_comments) https://github.com/bitcoin/bitcoin/pull/8747
<@wumpus> or original VT-100 terminals or whatnot :) bitcoin isn't that old
< gribble> https://github.com/bitcoin/bitcoin/issues/9166 | listtransactions returns invalid JSON when comment contain non-UTF8 special chars · Issue #9166 · bitcoin/bitcoin · GitHub
<@wumpus> and that is how everyone uses it. We're not going to support non-UTF-8 JSON in bitcoin core.
< gribble> https://github.com/bitcoin/bitcoin/issues/7940 | [WIP] Fuzzing framework by pstratem · Pull Request #7940 · bitcoin/bitcoin · GitHub
< jonasschnelli> BLTS: maybe #bitcoin or #bitcoin-dev but not #bitcoin-core-dev I guess
< bitcoin-git> [bitcoin] laanwj opened pull request #9172: Resurrect pstratem's "Simple fuzzing framework" (master...2016_11_fuzzing_framework) https://github.com/bitcoin/bitcoin/pull/9172
< bitcoin-git> bitcoin/master cb2ed30 MarcoFalke: Merge #9155: [trivial] update comments for tx weight...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9155: [trivial] update comments for tx weight (master...master) https://github.com/bitcoin/bitcoin/pull/9155
< bitcoin-git> bitcoin/master 07ede5d Brian Deery: update comments for tx weight
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a6d48d9ed60...cb2ed300a89e
< bitcoin-git> [bitcoin] laanwj closed pull request #8747: [rpc] Fix transaction size comments and RPC help text. (master...rpc_comments) https://github.com/bitcoin/bitcoin/pull/8747
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9168: [qa] add assert_raises_message to check specific error message (master...ba-assert-raises) https://github.com/bitcoin/bitcoin/pull/9168
< bitcoin-git> bitcoin/master 307acdd mrbandrews: [qa] add assert_raises_message to check specific error message
< bitcoin-git> bitcoin/master 0a6d48d MarcoFalke: Merge #9168: [qa] add assert_raises_message to check specific error message...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/434e683f7be6...0a6d48d9ed60
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9171: Introduce out-of-band block requests (master...2016/11/spv_step_1) https://github.com/bitcoin/bitcoin/pull/9171
<@wumpus> CubicEarth: this is not a channel for general bitcoin related questions, please use #bitcoin
< bitcoin-git> [bitcoin] laanwj closed pull request #9133: Unset fImporting for loading mempool (master...noImportLoadMempool) https://github.com/bitcoin/bitcoin/pull/9133
< bitcoin-git> bitcoin/master 79f755d Alex Morcos: Unset fImporting for loading mempool
< bitcoin-git> bitcoin/master 434e683 Wladimir J. van der Laan: Merge #9133: Unset fImporting for loading mempool...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/62af16463833...434e683f7be6
< bitcoin-git> [bitcoin] laanwj closed pull request #9131: fNetworkActive is not protected by a lock, use an atomic (master...2016/11/net_toggle) https://github.com/bitcoin/bitcoin/pull/9131
< bitcoin-git> bitcoin/master 079142b Jonas Schnelli: fNetworkActive is not protected by a lock, use an atomic
< bitcoin-git> bitcoin/master 62af164 Wladimir J. van der Laan: Merge #9131: fNetworkActive is not protected by a lock, use an atomic...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4333b1c4ea74...62af16463833
< bitcoin-git> [bitcoin] laanwj closed pull request #9151: [qa] proxy_test: Calculate hardcoded port numbers (master...Mf1611-qaPort) https://github.com/bitcoin/bitcoin/pull/9151
< bitcoin-git> bitcoin/master 4333b1c Wladimir J. van der Laan: Merge #9151: [qa] proxy_test: Calculate hardcoded port numbers...
< bitcoin-git> bitcoin/master fa80ef8 MarcoFalke: [qa] proxy_test: Calculate hardcoded port numbers instead
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/918ea16dc08d...4333b1c4ea74
< bitcoin-git> [bitcoin] laanwj closed pull request #9169: build: fix qt5.7 build under macOS (master...fix-objcxx-std) https://github.com/bitcoin/bitcoin/pull/9169
< bitcoin-git> bitcoin/master 70266e9 Cory Fields: build: fix qt5.7 build under macOS...
< bitcoin-git> bitcoin/master 918ea16 Wladimir J. van der Laan: Merge #9169: build: fix qt5.7 build under macOS...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6eeac6e30d65...918ea16dc08d
< jonasschnelli> sipa: come one! s/hash rate</a></li>/hash rate</a></li><li class="hilight"><a accesskey="h" href="http://bitcoin.sipa.be/ver9-10k.png">ver9-10k</a></li>/
< sipa> gmaxwell: http://bitcoin.sipa.be
< gmaxwell> for bitcoin I do think we need DRD run on it more often, it's just a bit frustrating because its so slow.
<@wumpus> bitcoin: where even the configure scripts yell at you
< * luke-jr> cowers in fear of the new Bitcoin Core configure that yells at you :P

2016-11-15

< cfields> morcos: top two commits here: https://github.com/theuni/bitcoin/commits/prevector-move
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< cfields> morcos: assuming bitcoin-qt build succeeds after that, then yes, that's enough
< bitcoin-git> [bitcoin] theuni opened pull request #9169: build: fix qt5.7 build under macOS (master...fix-objcxx-std) https://github.com/bitcoin/bitcoin/pull/9169
< bitcoin-git> [bitcoin] mrbandrews opened pull request #9168: [qa] add assert_raises_message to check specific error message (master...ba-assert-raises) https://github.com/bitcoin/bitcoin/pull/9168
< bitcoin-git> [bitcoin] morcos opened pull request #9167: IsAllFromMe (master...IsAllFromMe) https://github.com/bitcoin/bitcoin/pull/9167
< gribble> https://github.com/bitcoin/bitcoin/issues/8589 | Inline CTxInWitness inside CTxIn (on top of #8580) by sipa · Pull Request #8589 · bitcoin/bitcoin · GitHub
< timothy> drizzt@liara ~ % bitcoin-cli listtransactions '*' 2
< thermoman> jonasschnelli, luke-jr: https://github.com/bitcoin/bitcoin/issues/9166
< bitcoin-git> [bitcoin] instagibbs opened pull request #9165: [trivial] SendMoney: use already-calculated balance (master...triv-curbal) https://github.com/bitcoin/bitcoin/pull/9165
< bitcoin-git> [bitcoin] sipa closed pull request #9164: [trivial] credit values are CAmount (master...intcredit) https://github.com/bitcoin/bitcoin/pull/9164
< bitcoin-git> bitcoin/master 6eeac6e Pieter Wuille: Merge #9164: [trivial] credit values are CAmount...
< bitcoin-git> bitcoin/master 20c3215 Gregory Sanders: credit values are CAmount
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/018a4eb120dc...6eeac6e30d65
< jonasschnelli> Now testing bitcoin-cli
< thermoman> bitcoin-cli says can't parse reply
< jonasschnelli> This one is easy to review if someone has 2-3 minutes of boringness: https://github.com/bitcoin/bitcoin/pull/9142
< sdaftuar> thrasher`: i don't know where that test case came from, but i do recall this github comment that may be of help: https://github.com/bitcoin/bitcoin/pull/5620#issuecomment-69351549
< bitcoin-git> [bitcoin] instagibbs opened pull request #9164: [trivial] credit values are CAmount (master...intcredit) https://github.com/bitcoin/bitcoin/pull/9164
< bitcoin-git> bitcoin/master f54e460 Wladimir J. van der Laan: Merge #9132: Make strWalletFile const...
< bitcoin-git> [bitcoin] laanwj closed pull request #9132: Make strWalletFile const (master...2016/11/strWalletFile_const) https://github.com/bitcoin/bitcoin/pull/9132
< bitcoin-git> bitcoin/master f734505 Jonas Schnelli: Make strWalletFile const
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/770364b8eaf7...f54e4605fc31
< bitcoin-git> [bitcoin] laanwj closed pull request #9160: [trivial] Fix hungarian variable name (master...hungarian) https://github.com/bitcoin/bitcoin/pull/9160
< bitcoin-git> bitcoin/master 770364b Wladimir J. van der Laan: Merge #9160: [trivial] Fix hungarian variable name...
< bitcoin-git> bitcoin/master ec34648 Russell Yanofsky: [trivial] Fix hungarian variable name...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b42291334651...770364b8eaf7
< gribble> https://github.com/bitcoin/bitcoin/issues/8831 | Replace CWalletDB::ReadKeyValue with CWallet::LoadKeyValue by pstratem · Pull Request #8831 · bitcoin/bitcoin · GitHub
< achow101> Squidicuz: yes, bitcoincore.org is Bitcoin Core's site
< shinyg> Maybe bitcoin is a software stack but Core is just software
< shinyg> makes sense, how about is Bitcoin Core a Solution stack or software as some describe it/
< achow101> they're trying to separate bitcoin core from bitcoin.org as bitcoin.org is for bitcoin in general whilst bitcoin core is a specific project
< sipa> but bitcoin core has its own project website now
< shinyg> so was there a specific reason why new releases stopped coming from bitcoin.org?
< achow101> well they're listed here: https://bitcoin.org/en/about-us#sponsorship

2016-11-14

< achow101> also, IIRC bitcoin.org and the bitcoin foundation are no longer related
< achow101> shinyg: blockstream does not fund Bitcoin Core development at all. There are developers who work on Bitcoin Core who also have jobs at Blockstream. The people who actually partially fund development are the MIT DCI who actually pay some people to work on Core (wladimir, cory)
< shinyg> I have recently expanded the Wikipedia article for Bitcoin Core by a factor of 10. Could someone spend just a few minutes to see if there are any major ommission or errors?
< shinyg> Hi people, I was after a little assistance from those who know more about Bitcoin Core and those who support Wikipedia.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9136: sync_blocks cleanup (master...sync-clean) https://github.com/bitcoin/bitcoin/pull/9136
< bitcoin-git> bitcoin/master 7943b13 Russell Yanofsky: [qa] Avoid 2 list comprehensions in sync_blocks
< bitcoin-git> bitcoin/master 05e57cc Russell Yanofsky: [qa] Fix sync_blocks timeout argument...
< bitcoin-git> bitcoin/master fd6bb70 Russell Yanofsky: [qa] Improve sync_blocks error messages.
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/924745dd6f5f...b42291334651
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9160: [trivial] Fix hungarian variable name (master...hungarian) https://github.com/bitcoin/bitcoin/pull/9160
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9159: [qa] Wait for specific block announcement in p2p-compactblocks (master...cmpct-announce-wait) https://github.com/bitcoin/bitcoin/pull/9159
< gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Leviathn closed pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
< bitcoin-git> [bitcoin] Leviathn opened pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9156: Add compile and link options echo to configure (master...2016/11/configure) https://github.com/bitcoin/bitcoin/pull/9156
< gmaxwell> okay, bitcoin's sha256 is 237.1 million bytes per second, openssl is 320.7 million bytes per second.. and the chacha is 358.6 million bytes per second. (openssl at slight disadvantage due to 8k vs 1m size, but it doesn't matter much)
< btcdrak> gmaxwell: no no, we're not allowed to sign that, because it's Roger Ver's attempt to snub Bitcoin Core. Looks like a more watered down version of the first leak http://pastebin.com/cgkqcWBS.
< bitcoin-git> bitcoin/master fa42e4a MarcoFalke: [qt] Make network disabled icon 50% opaque
< bitcoin-git> bitcoin/master 924745d Jonas Schnelli: Merge #9145: [qt] Make network disabled icon 50% opaque...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9145: [qt] Make network disabled icon 50% opaque (master...Mf1611-qtNetworkIcon) https://github.com/bitcoin/bitcoin/pull/9145
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87ab49e4fe38...924745dd6f5f
< bitcoin-git> [bitcoin] carryforward opened pull request #9155: [trivial] update comments for tx weight (master...master) https://github.com/bitcoin/bitcoin/pull/9155
< bitcoin-git> [bitcoin] fanquake closed pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154
< bitcoin-git> [bitcoin] XertroV opened pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154

2016-11-13

< bitcoin-git> [bitcoin] luke-jr opened pull request #9152: Wallet/RPC: sweepprivkeys method to scan UTXO set and send to local wallet (master...sweepprivkeys) https://github.com/bitcoin/bitcoin/pull/9152
< bitcoin-git> [bitcoin] luke-jr closed pull request #9150: Qt: Make network disabled icon larger and 50% opaque (master...gui_netdisabled_icon_enlarge) https://github.com/bitcoin/bitcoin/pull/9150
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9151: [qa] proxy_test: Calculate hardcoded port numbers (master...Mf1611-qaPort) https://github.com/bitcoin/bitcoin/pull/9151
< bitcoin-git> [bitcoin] luke-jr opened pull request #9150: Qt: Make network disabled icon larger and 50% opaque (master...gui_netdisabled_icon_enlarge) https://github.com/bitcoin/bitcoin/pull/9150
< fanquake> Sure, this list will show you the current "big" changes for the 0.14.0 release: https://github.com/bitcoin/bitcoin/milestone/21
< fanquake> Victorsueca If you'd just like to test stuff in general, start here : https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3AWindows . See if you can recreate/investigate issues. If so post some info about the system your using, how you tested it etc.

2016-11-12

< gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9145: [qt] Make network disabled icon 50% opaque (master...Mf1611-qtNetworkIcon) https://github.com/bitcoin/bitcoin/pull/9145
< bitcoin-git> [bitcoin] fanquake opened pull request #9144: [Trivial] Correct waitforblockheight example help text (master...rpc-commands) https://github.com/bitcoin/bitcoin/pull/9144
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9143: Refactor ZapWalletTxes to avoid layer vialotions (master...2016/11/wallet_db_refactoring_1) https://github.com/bitcoin/bitcoin/pull/9143
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9142: Move -salvagewallet, -zap(wtx) to where they belong (master...2016/11/wallet_init) https://github.com/bitcoin/bitcoin/pull/9142
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9141: Remove unnecessary calls to CheckFinalTx (master...2016/11/istrusted) https://github.com/bitcoin/bitcoin/pull/9141