< bitcoin-git>
[bitcoin] FelixWeis opened pull request #11029: [RPC] trivial: gettxout no longer shows version of tx (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11029
< bitcoin-git>
[bitcoin] sipa opened pull request #11028: Avoid masking of difficulty adjustment errors by checkpoints (master...20170810_maskpow) https://github.com/bitcoin/bitcoin/pull/11028
2017-08-10
< bitcoin-git>
[bitcoin] achow101 opened pull request #11027: [RPC] Only return hex field once in getrawtransaction (master...fix-getrawtx) https://github.com/bitcoin/bitcoin/pull/11027
< bitcoin-git>
[bitcoin] luke-jr opened pull request #11026: Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default (master...bugfix_acceptnonstd_def) https://github.com/bitcoin/bitcoin/pull/11026
< jnewbery>
if we can get bitcoin-wallet-tool and offline topup into v0.16 we have a very nice way of sidestepping most of the problems I believe
< gmaxwell>
luke-jr: but in general, versions that shutdown based on low keypool have a problem with existing wallets failing to work when users upgrade, and efforts to avoid that can create cases where we'll fail to force a shutdown when we should. (for example if the user backed up and restored a whole .bitcoin directory).
< gmaxwell>
behind; as a simple example: backup your whole .bitcoin directory and later restor the backup)
< gribble>
https://github.com/bitcoin/bitcoin/issues/10882 | Stop advancing best block and shutdown node if keypool drops below critical threshold by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11024: tests: Free the OpenSSL error queue as part of the wallet_crypto/OldDecrypt test cleanup (master...OldDecrypt-cleanup) https://github.com/bitcoin/bitcoin/pull/11024
< bitcoin-git>
[bitcoin] jnewbery opened pull request #11023: [tests] Add option to attach a python debugger if functional test fails (master...func_test_pdb) https://github.com/bitcoin/bitcoin/pull/11023
< bitcoin-git>
[bitcoin] kallewoof opened pull request #11020: [wallet] getbalance: Add option to include non-mempool UTXOs (master...unspendable-utxo-handling) https://github.com/bitcoin/bitcoin/pull/11020
< wumpus>
also in principle you can run all the functional tests with bitcoin-qt instead of bitcoind (but that's not useful for travis :-)
< wumpus>
if the test is not interested in windowed output w/ QT_QPA_PLATFORM=minimal you can avoid the X dependency, this is what the bitcoin-qt unit-tests in src/qt/test do
< aj>
wumpus: hmm, can travis start qt/bitcoin, or would local-only tests be sufficient at least to start?
< bitcoin-git>
[bitcoin] kallewoof opened pull request #11019: [wallet] Abandon transactions that fail to go into the mempool (master...abandon-longchain-failed-tx) https://github.com/bitcoin/bitcoin/pull/11019
2017-08-09
< chainhead>
bitcore is not from bitcoin core
< smill>
Hello, I have a problem using bitcore-wallet-service and insight-api, I have everything working with bitcoind from bitcoin-0.12.1 bitcore build (the one that gets installed if you follow the dosc) but im trying to get the new release working from https://github.com/bitpay/bitcoin/releases and im basically having the same problem as this guy https://github.com/bitpay/insight-ui/issues/746 and there are no answers yet
< bitcoin-git>
bitcoin/master e526ca6 MarcoFalke: Merge #10835: Rename member field according to the style guide...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10835: Rename member field according to the style guide (master...20170715_Wshadow_reverseiterator) https://github.com/bitcoin/bitcoin/pull/10835
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision (master...restore-format-state-of-cout) https://github.com/bitcoin/bitcoin/pull/10963
< bitcoin-git>
bitcoin/master ecd2135 MarcoFalke: Merge #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision...
< bitcoin-git>
bitcoin/master fd05132 practicalswift: Restore default format state of cout after printing with std::fixed/setprecision
< bitcoin-git>
[bitcoin] theuni opened pull request #11012: Make sure to clean up mapBlockSource if we've already seen the block (master...cleanup-blocksource) https://github.com/bitcoin/bitcoin/pull/11012
< earlz>
regarding std::string ABI stuff, would that really matter that much? I know compiling Bitcoin outside of Gitian (ie with system deps) works fine in every version of GCC I've tried
< earlz>
My concern isn't bitcoin itself, but rather it's dependencies will start using C++11 features, making for more and more patches being required for gitian compiles
2017-08-08
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #11011: [Trivial] Add a comment on the use of prevector in script. (master...201708-prevector-comment) https://github.com/bitcoin/bitcoin/pull/11011
< bitcoin-git>
[bitcoin] rawodb closed pull request #11010: Add information about the next state in getblockchaininfo rpc request (master...pr/getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/11010
< bitcoin-git>
[bitcoin] rawodb opened pull request #11010: Add information about the next state in getblockchaininfo rpc request (master...pr/getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/11010
< sdaftuar>
that way if someone wants to write a bitcoin network client that only worries about one of those properties, they don't need to do any complicated reasoning
< bitcoin-git>
[bitcoin] rawodb closed pull request #11009: Add information about the next state in getblockchaininfo rpc request (master...master) https://github.com/bitcoin/bitcoin/pull/11009
< bitcoin-git>
[bitcoin] rawodb opened pull request #11009: Add information about the next state in getblockchaininfo rpc request (master...master) https://github.com/bitcoin/bitcoin/pull/11009
< gribble>
https://github.com/bitcoin/bitcoin/issues/10483 | scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL by practicalswift · Pull Request #10483 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jharvell opened pull request #10997: Add option -stdinrpcpass to allow RPC password to be read from stdin (master...stdinrpcpass) https://github.com/bitcoin/bitcoin/pull/10997
< wumpus>
there is #bitcoin-dev that is more general
< wumpus>
bryyan: this channel is specifically for "bitcoin core", the c++ implementation, it has a very narrow scope on purpose to make sure the scrollback is relevant to the devs here
< gmaxwell>
the discussion is also an oppturnity to make it clear that Bitcoin developers don't support s2x... there are still some people going along spreading the idea that we'll somehow be going along with it.
2017-08-05
< arubi>
sipa, would be cool to have the .conf file per network. I do this now with shell functions and I'd love if it would be a part of the original bitcoin.conf. makes it much simpler to version control
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
< bitcoin-git>
[bitcoin] ajtowns opened pull request #10994: Add option to avoid warning on certain network upgrades (master...ignore-vbits) https://github.com/bitcoin/bitcoin/pull/10994
< gmaxwell>
Symptom is that bitcoin core rejects the private keys as invalid, which they are.
< bitcoin-git>
[bitcoin] laanwj closed pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git>
bitcoin/master 02f4c4a Wladimir J. van der Laan: Merge #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)...
< bitcoin-git>
bitcoin/master 11dd29b practicalswift: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request)...
< Chicago>
Well, you know once the base image is built; it could be a few weeks between Bitcoin release cycles; and so it has to build the dependency graph and do the package installations deterministically such that if you built an image last month with Trusty and I built an image today with Trusty, we both end up getting the exact same depgraph when we go to build everything.
< gmaxwell>
(not that bch is even the first altcoin to airdrop on bitcoin users, just the first with a highly funded marketing effort behind it)
< goatpig>
Bitcoin is unaffected though
< timothy>
gmaxwell: the real problem is that the broken forks (aka abc) uses the bitcoin-core data directory
< Chicago>
yeah, looks like he got to it 15 minutes ago on the Bitcoin subreddit
< Chicago>
venzen, I would presume the bitcoin.org (over HTTPS) hosted key is an order of magnitude more trustworthy than anything you randomly find by looking for a short string at the MIT PGP server.
< venzen>
Chicago: thanks, I'll post the link you provide to the r/bitcoin post. The OP seems to be confused and I figured wumpus should be aware of the post
< BlueMatt>
Cobra-Bitcoin: that is the intention, yes, I mailed you about this a while back :). I think the goal is to start pointing people to bitcoincore.org, but also sicne y'all wanted to keep mirroring on bitcoin.org (and cause no point telling people to go somewhere else if they're already used to bitcoin.org), they'd be in both places
< Cobra-Bitcoin>
So the release notes will point users to bitcoincore.org binaries?
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018 (master...2017-08-bad-service-bits) https://github.com/bitcoin/bitcoin/pull/10982
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell>
At the end we're doing them a favor, there are a lot more bitcoin nodes than random altcoin nodes, so these incorrect connections tend to cause them a lot more problems than us.
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell>
what? no. matt, doing that will ban Bitcoin Core users when someone on the same IP ran crapware.
< earlz>
yea, I'm not understanding where that gets created in the guide. Last time I setup gitian it was for Bitcoin 0.9 so not sure what all has changed since then
< BlueMatt>
Make Bitcoin Great Again: Bring back Pay-2-IP
< wumpus>
though if a wallet gets corrupted that's a good indication you should stop using that computer for bitcoin, now
< BlueMatt>
achow101: if you have a wallet with keys, and a default key that is invalid or missing, your wallet was clearly either corrupted or generated by something other than bitcoin core
< karelb>
ok we got abc node working, but it was some crazy solution of switching between various binaries and invalidating nodes; it did not crash (yet). But it seems that bitcore patches inside connectblock/disconnectblock are really not the way for the future; it will probably break again (both in abc and later in bitcoin core once you release the db changes)
< karelb>
I am actually talking about ABC, but the same issue crops up in bitcoin, plus it might be because ABC added some db logic from master
< karelb>
it must be because of the address index somehow, because on the same PC, bitcoin core without bitcore (sigh) patches runs fine
< bitcoin-git>
[bitcoin] laanwj closed pull request #10942: Eliminate fee overpaying edge case when subtracting fee from recipients (master...subtractfee) https://github.com/bitcoin/bitcoin/pull/10942
< bitcoin-git>
bitcoin/master 2e857bb Wladimir J. van der Laan: Merge #10942: Eliminate fee overpaying edge case when subtracting fee from recipients...
< bitcoin-git>
bitcoin/master 49d903e Alex Morcos: Eliminate fee overpaying edge case when subtracting fee from recipients
< gmaxwell>
karelb: the challenge there is that we have insanely optimized bitcoin core's sync process.. we avoid writing to leveldb at all costs, basically, and a significant fraction of UTXO never hit the database at all during normal sync because they're spent before the dbcache fills)
< karelb>
and normal bitcoin without bitcore patches doesn't do it, on the same HW
< Austindoggie>
Did it take a long time to reindex because you went back a version of bitcoin core?
< gmaxwell>
karelb: bitcoin core master changed the atomiticity requirements for the backend database, but a side effect of this is that it needs special replay logic to handle crash recovery. ABC has partially ported some of these changes. I am not sure, but I wouldn't be surprised if the address indexing would get corrupted until updated to have the right synchronization behavior.
< gmaxwell>
karelb: probably code based on Bitcoin Core master (including ABC) will not be reliably compatible with that address indexing stuff until it is changed.
< karelb>
actually one issue was sort-of ABC related, but it was because of a commit ported from master from bitcoin core, so it will be relevant anyway
< karelb>
(It is actually bitcoin-abc, I hope I won't be banned :D, but this issue popped up in bitcoin core too)
< karelb>
but right now we are reindexing bitcoin blockchain and it takes foreved
< gmaxwell>
Hi all, karelb is working on the trezor wallet, and they've been trying to use these patches to bitcoin that implement the bitcore address indexing stuff, but they're finding it really slow to the point where performance is problematic.
< praxeology>
does bitcoin still use windows registry?
< praxeology>
alright... well, its unfortunate I misdiagnosed the guy's issue. Thanks for the help. Hopefully he will come back and ask again on #bitcoin and one of sees him... for his sake... before he -reindex
< praxeology>
when bitcoin starts up, it only chooses one peer to ask for latest headers?
< praxeology>
ok. james0909 in #bitcoin said his error log said... "ERROR: invalid header received 2017-08-03 01:48:18 ProcessMessages(headers, 11422 bytes) FAILED peer=38"? and his tip was stuck at 478645.
< instagibbs>
james0909, #bitcoin please, someone can help there
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
< earlz>
Has anyone successfully cross-compiled Bitcoin Core for a raspberry pi? If so, is that process documented somewhere?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10972: Check return value of addr.GetKeyID(keyid) on custom change address change (master...GetKeyID-assertion) https://github.com/bitcoin/bitcoin/pull/10972
< bitcoin-git>
[bitcoin] theuni opened pull request #10971: build: fix missing warnings and sse42 in depends builds (master...fix-config-override) https://github.com/bitcoin/bitcoin/pull/10971
< bitcoin-git>
[bitcoin] laanwj closed pull request #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature (master...fix-addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/10788
< bitcoin-git>
bitcoin/master f66c596 Wladimir J. van der Laan: Merge #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature...
< bitcoin-git>
bitcoin/master e222dc2 Andrew Chow: Replace ismine with producesignature check in witnessifier...