2019-03-14

< gribble> https://github.com/bitcoin/bitcoin/issues/14054 | p2p: Disable BIP 61 by default by MarcoFalke · Pull Request #14054 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13134 | net: Add option `-enablebip61` to configure sending of BIP61 notifications by laanwj · Pull Request #13134 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 three PRs on here #15141 #10973 #14856
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15601: build: depends: Switch to python3 (take 3) (master...1903-buildPy3) https://github.com/bitcoin/bitcoin/pull/15601
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/85f1755163a1...889af0eaacd9
< bitcoin-git> bitcoin/0.18 889af0e Wladimir J. van der Laan: doc: Update manpages
< bitcoin-git> [bitcoin] laanwj merged pull request #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree (master...2019-03-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/15583
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/ef27a060ac0d...85f1755163a1
< bitcoin-git> bitcoin/0.18 85f1755 Wladimir J. van der Laan: build: bump to rc2
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1704c01537...7fa1f6258c05
< bitcoin-git> bitcoin/master 15c69b1 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
< bitcoin-git> bitcoin/master 7fa1f62 Wladimir J. van der Laan: Merge #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkele...
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/a01925c1502a...ef27a060ac0d
< bitcoin-git> bitcoin/0.18 ef27a06 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
< gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/232ef630ecd3...a01925c1502a
< bitcoin-git> bitcoin/0.18 a01925c Wladimir J. van der Laan: doc: Pre-rc2 translations update
< bitcoin-git> [bitcoin] luke-jr opened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600
< provoostenator> Sentineo the fingerprint of sipa's key, that you just downloaded, is in trusted-keys here: https://github.com/bitcoin/bitcoin/tree/master/contrib/verify-commits
< bitcoin-git> [bitcoin] pstratem opened pull request #15597: Generate log entry when blocks messages are received unexpectedly. (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597

2019-03-13

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15587: wallet: Remove GetLegacyBalance (master...1903-walletRemoveLegacyBal) https://github.com/bitcoin/bitcoin/pull/15587
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15596: rpc: Ignore sendmany::minconf as dummy value (master...1903-rpcWalletDummySendmany_2) https://github.com/bitcoin/bitcoin/pull/15596
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15595: rpc: Actually use sendmany::minconf (master...1903-rpcWalletDummySendmany) https://github.com/bitcoin/bitcoin/pull/15595
< wumpus> MarcoFalke: https://github.com/zw/bitcoin-gh-meta.git is what I used but it seems it hasn't been updated in a while :(
< gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
< echeveria> eg, curl -s http://data.gharchive.org/2015-01-01-{1..31}.json.gz | zgrep "github.com/bitcoin/bitcoin"
< MarcoFalke> What is the git repo again that mirrors all bitcoin core github comments?
< jonasschnelli> Any idea why Draht reports conflicts multiple times? https://github.com/bitcoin/bitcoin/pull/14032#issuecomment-471980504
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/2edd0c40c34b...232ef630ecd3
< bitcoin-git> bitcoin/0.18 232ef63 Pieter Wuille: Fix overflow bug in analyzepsbt fee: CAmount instead of int
< gribble> https://github.com/bitcoin/bitcoin/issues/15582 | Fix overflow bug in analyzepsbt fee: CAmount instead of int by sipa · Pull Request #15582 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15592 | Bitcoin signing key by @laanwj expired on 2019-02-14 · Issue #15592 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
< bitcoin-git> [bitcoin] promag closed pull request #14826: Avoid expanding descriptor scriptPubKeys (master...2018-11-faster-descriptor-expand) https://github.com/bitcoin/bitcoin/pull/14826
< bitcoin-git> [bitcoin] pajasevi opened pull request #15594: Changed Czech translation of the word "blockchain" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15594
< bitcoin-git> [bitcoin] Sjors opened pull request #15590: Descriptor: add GetAddressType() -> base58 / bech32 (master...2019/03/descriptor-address-type) https://github.com/bitcoin/bitcoin/pull/15590
< gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Ignore recursive_directory_iterator errors in ListWalletDir by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/021a9ad6f19b...2edd0c40c34b
< bitcoin-git> bitcoin/0.18 20fd64f fanquake: doc: correct analysepsbt rpc doc
< bitcoin-git> bitcoin/0.18 2edd0c4 fanquake: rpc: return a number for estimated_feerate in analyzepsbt
< bitcoin-git> [bitcoin] laanwj merged pull request #15559: doc: correct analyzepsbt rpc doc (master...fixup-analysepsbt-rpc-doc) https://github.com/bitcoin/bitcoin/pull/15559
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b1cb958f7c...8e1704c01537
< bitcoin-git> bitcoin/master a4d0fd0 fanquake: doc: correct analysepsbt rpc doc
< bitcoin-git> bitcoin/master 335931d fanquake: rpc: return a number for estimated_feerate in analyzepsbt
< bitcoin-git> bitcoin/master 8e1704c Wladimir J. van der Laan: Merge #15559: doc: correct analyzepsbt rpc doc
< bitcoin-git> [bitcoin] practicalswift closed pull request #15589: tests: Teach lint-whitespace.sh to detect missing newline at end of file (master...lint-newline-at-eof) https://github.com/bitcoin/bitcoin/pull/15589
< bitcoin-git> [bitcoin] practicalswift opened pull request #15589: lint: Teach lint-whitespace.sh to detect missing newline at end of file (master...lint-newline-at-eof) https://github.com/bitcoin/bitcoin/pull/15589
< newbie2019258_> One more question please: After I added the rpcauth=... line into the config file (bitcoin.conf) how to need activate/accept, I mean maybe need to reload some service(s) or something like that? (I want to use the PHP wrapper to manage bitcoind over RPC)
< wumpus> i think the best place to search for or ask usage questions is the bitcoin stack overflow (https://bitcoin.stackexchange.com/)
< bitcoin-git> [bitcoin] Sjors closed pull request #15567: Make OutputType consistent with Descriptor and return it (master...2019/03/descriptor-output-type) https://github.com/bitcoin/bitcoin/pull/15567
< bitcoin-git> [bitcoin] achow101 opened pull request #15588: Log the actual wallet file version and no longer publicly expose the "version" record (master...rm-wallet-nfileversion) https://github.com/bitcoin/bitcoin/pull/15588
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15587: wallet: Remove GetLegacyBalance (master...1903-walletRemoveLegacyBal) https://github.com/bitcoin/bitcoin/pull/15587
< gribble> https://github.com/bitcoin/bitcoin/issues/11911 | Free BerkeleyEnvironment instances when not in use by ryanofsky · Pull Request #11911 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15575 | 0.17: Backport 15297 by promag · Pull Request #15575 · bitcoin/bitcoin · GitHub

2019-03-12

< MDBILL49> hello dear e-pals how can i creat a chain in a block chain of bitcoin i need your help
< bitcoin-git> [bitcoin] dongcarl opened pull request #15586: chainparams: Explicitly use uint16 for nDefaultPort (master...2019-03-uint16-port) https://github.com/bitcoin/bitcoin/pull/15586
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59b291966eb6...c3b1cb958f7c
< bitcoin-git> bitcoin/master 56f1d28 Lenny Maiorani: dead code: Remove dead option in HexStr conversion
< bitcoin-git> bitcoin/master c3b1cb9 Wladimir J. van der Laan: Merge #15573: dead code: Remove dead option in HexStr conversion
< bitcoin-git> [bitcoin] laanwj merged pull request #15573: dead code: Remove dead option in HexStr conversion (master...hexstr_dead_code) https://github.com/bitcoin/bitcoin/pull/15573
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5770677de85...59b291966eb6
< bitcoin-git> bitcoin/master c9963ae Pieter Wuille: Fix overflow bug in analyzepsbt fee: CAmount instead of int
< bitcoin-git> bitcoin/master 59b2919 Wladimir J. van der Laan: Merge #15582: Fix overflow bug in analyzepsbt fee: CAmount instead of int
< bitcoin-git> [bitcoin] laanwj merged pull request #15582: Fix overflow bug in analyzepsbt fee: CAmount instead of int (master...201903_analyzepsbtoverflow) https://github.com/bitcoin/bitcoin/pull/15582
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/936ef73fabc9...021a9ad6f19b
< bitcoin-git> bitcoin/0.18 021a9ad MarcoFalke: build: use full version string in setup.exe
< bitcoin-git> [bitcoin] laanwj merged pull request #15548: build: use full version string in setup.exe (master...1903-winVer) https://github.com/bitcoin/bitcoin/pull/15548
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c94852e7912e...e5770677de85
< bitcoin-git> bitcoin/master fa55104 MarcoFalke: build: use full version string in setup.exe
< bitcoin-git> bitcoin/master e577067 Wladimir J. van der Laan: Merge #15548: build: use full version string in setup.exe
< zhangzf> luke-jr: Thank you. I see the repo. When I clone the bitcoin repo and install depends lib, I use "./autogen.sh", "./configure", "make", "make install". The bin is install in my machione, it is depends shared lib. I want to compile the bitcoin to run on another ubuntu machine.
< zhangzf> Hi, I want to package Bitcoin Core on Ubuntu, but I don't know how to package it. For windows and macOS, I know that run "make deploy". On Linux, What can I do for it.
< bitcoin-git> [bitcoin] fanquake opened pull request #15584: build: disable BIP70 support by default (master...disable-bip70-by-default) https://github.com/bitcoin/bitcoin/pull/15584

2019-03-11

< bitcoin-git> [bitcoin] promag opened pull request #15583: wallet: Ignore recursive_directory_iterator errors in ListWalletDir (master...2019-03-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/15583
< bitcoin-git> [bitcoin] sipa opened pull request #15582: Fix overflow bug in analyzepsbt fee: CAmount instead of int (master...201903_analyzepsbtoverflow) https://github.com/bitcoin/bitcoin/pull/15582
< bitcoin-git> [bitcoin] dongcarl opened pull request #15581: depends: Make less assumptions about build env (master...2019-03-true-neutral-depends) https://github.com/bitcoin/bitcoin/pull/15581
< bitcoin-git> [bitcoin] dongcarl opened pull request #15580: depends: native_protobuf: avoid system zlib (master...2019-03-depends-native_protobuf-no-zlib) https://github.com/bitcoin/bitcoin/pull/15580
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15579: Fix french translation (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15579
< bitcoin-git> [bitcoin] Ethicnology opened pull request #15579: Fix french translation (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15579
< bitcoin-git> [bitcoin] JeremyRand opened pull request #15577: Docs: Enable TLS in link to chris.beams.io (master...chris-beams-tls) https://github.com/bitcoin/bitcoin/pull/15577
< gribble> https://github.com/bitcoin/bitcoin/issues/15574 | build: Default size for the LXC disk is no longer enough · Issue #15574 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15564: cli: remove duplicate wallet fields from -getinfo (master...cli-remove-duplicate-entries) https://github.com/bitcoin/bitcoin/pull/15564
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/887f57eb7276...c94852e7912e
< bitcoin-git> bitcoin/master 3f6568d fanquake: cli: remove duplicate wallet fields from -getinfo
< bitcoin-git> bitcoin/master c94852e MarcoFalke: Merge #15564: cli: remove duplicate wallet fields from -getinfo
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15566: cli: replace testnet with chain and return network name as per BIP70. (master...cli-testnet-to-network) https://github.com/bitcoin/bitcoin/pull/15566
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/257f750cd986...887f57eb7276
< bitcoin-git> bitcoin/master 890396c fanquake: cli: replace testnet with chain and return network name as per BIP70.
< bitcoin-git> bitcoin/master 887f57e MarcoFalke: Merge #15566: cli: replace testnet with chain and return network name as p...
< gribble> https://github.com/bitcoin/bitcoin/issues/15575 | 0.17: Backport 15297 by promag · Pull Request #15575 · bitcoin/bitcoin · GitHub
< promag_> found libuv, then found #5677, you also commented there: https://github.com/bitcoin/bitcoin/pull/5677#issuecomment-135961325
< gribble> https://github.com/bitcoin/bitcoin/issues/5677 | libevent-based http server by laanwj · Pull Request #5677 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ldm5180 opened pull request #15576: constexpr: Increase constexpr usage in strencodings (master...constexpr-strencodings) https://github.com/bitcoin/bitcoin/pull/15576
< bitcoin-git> [bitcoin] promag opened pull request #15575: 0.17: Backport 15297 (0.17...2019-03-backport-15297-017) https://github.com/bitcoin/bitcoin/pull/15575

2019-03-10

< bitcoin-git> [bitcoin] ldm5180 opened pull request #15573: dead code: Remove dead option in HexStr conversion (master...hexstr_dead_code) https://github.com/bitcoin/bitcoin/pull/15573
< bitcoin-git> [bitcoin] rojarsmith opened pull request #15572: Add auto select custom fee when smart fee not initialized. (master...dev) https://github.com/bitcoin/bitcoin/pull/15572
< bitcoin-git> [bitcoin] rojarsmith closed pull request #15571: Add auto select custom fee when smart fee not initialized. (master...mydev) https://github.com/bitcoin/bitcoin/pull/15571
< bitcoin-git> [bitcoin] rojarsmith opened pull request #15571: Add auto select custom fee when smart fee not initialized. (master...mydev) https://github.com/bitcoin/bitcoin/pull/15571
< echeveria> I guess that's a good heuristic for everything other than bitcoin core.

2019-03-09

< gmaxwell> the security alias just got yet another report, apparently mac AV software is now also claiming that bitcoin is a virus.
< bitcoin-git> [bitcoin] cisba opened pull request #15569: docs: improve linux tar packages (master...improve-tar-rebased) https://github.com/bitcoin/bitcoin/pull/15569
< bitcoin-git> [bitcoin] cisba closed pull request #15554: docs: binary tar improvement (master...improve-tar) https://github.com/bitcoin/bitcoin/pull/15554
< bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
< bitcoin-git> [bitcoin] Sjors opened pull request #15567: Make OutputType consistent with Descriptor and return it (master...2019/03/descriptor-output-type) https://github.com/bitcoin/bitcoin/pull/15567
< luke-jr> yes, I have that answer typed up waiting for him in #Bitcoin XD
< teslasystems> Sorry, but I thought that the question is related to development, will post to #bitcoin
< luke-jr> teslasystems: that's a question for #bitcoin, not here
< teslasystems> Can anyone tell, where is the button for creating new wallets in Bitcoin Core? It has disappeared after 0.16.3 release
< bitcoin-git> [bitcoin] laanwj merged pull request #15565: doc: remove release note fragments (master...remove-pre-18-release-notes) https://github.com/bitcoin/bitcoin/pull/15565
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b2ee268be45...257f750cd986
< bitcoin-git> bitcoin/master 6e1aaff fanquake: doc: remove release note fragments
< bitcoin-git> bitcoin/master 257f750 Wladimir J. van der Laan: Merge #15565: doc: remove release note fragments
< gmaxwell> (in spite of my love of integers, I'm also not super fond of satoshi interfaces... values are usually too big, and it's perfectly reasonable for bitcoin software to work in sub-satoshi amounts even though thats the network precision)
< gmaxwell> unfortuantely all these fee estimation sites sprung up around a time when the min relay fee happened to be 1s/b, I think, which is what caused it to be treated as fundimental instead of the bitcoin per/1000b the bitcoin software used in it's interfaces
< gmaxwell> (feerates and guistuff and time are the things in bitcoin that use floats)
< gmaxwell> oh, though an interesting point about feerates, is that sensible feerates have more precision than bitcoin.
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #15566: cli: replace testnet with chain and return network name as per BIP70. (master...cli-testnet-to-network) https://github.com/bitcoin/bitcoin/pull/15566
< bitcoin-git> [bitcoin] fanquake opened pull request #15565: doc: remove release note fragments (master...remove-pre-18-release-notes) https://github.com/bitcoin/bitcoin/pull/15565
< bitcoin-git> [bitcoin] fanquake opened pull request #15564: cli: remove duplicate wallet fields from -getinfo (master...cli-remove-duplicate-entries) https://github.com/bitcoin/bitcoin/pull/15564
< bitcoin-git> [bitcoin] fanquake closed pull request #15563: backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (0.18...backport-15486-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15563
< bitcoin-git> [bitcoin] laanwj merged pull request #15562: doc: remove duplicate clone step in build-windows.md (master...improved-15550) https://github.com/bitcoin/bitcoin/pull/15562
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/f810f14cf61d...936ef73fabc9
< bitcoin-git> bitcoin/0.18 561b00a Suhas Daftuar: [addrman] Improve tried table collision logging
< bitcoin-git> bitcoin/0.18 487f0c3 Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
< bitcoin-git> bitcoin/0.18 333be7a Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff3814880861...6b2ee268be45
< bitcoin-git> bitcoin/master 5bd0788 Ferdinando M. Ametrano: doc: correct path in build-windows.md
< bitcoin-git> bitcoin/master 6b2ee26 Wladimir J. van der Laan: Merge #15562: doc: remove duplicate clone step in build-windows.md
< bitcoin-git> [bitcoin] fanquake opened pull request #15563: backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (0.18...backport-15486-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15563
< bitcoin-git> [bitcoin] laanwj merged pull request #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/12408d33c6ac...ff3814880861
< bitcoin-git> bitcoin/master 4d83401 Suhas Daftuar: [addrman] Improve tried table collision logging
< bitcoin-git> bitcoin/master 4991e3c Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
< bitcoin-git> bitcoin/master f71fdda Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
< bitcoin-git> [bitcoin] fanquake closed pull request #15550: doc: correct path in build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
< bitcoin-git> [bitcoin] fanquake opened pull request #15562: doc: remove duplicate clone step in build-windows.md (master...improved-15550) https://github.com/bitcoin/bitcoin/pull/15562
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/0fd3632868e2...f810f14cf61d
< bitcoin-git> bitcoin/0.18 f810f14 Wladimir J. van der Laan: gitian: Improve error handling
< bitcoin-git> [bitcoin] laanwj merged pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efed9809b4fa...12408d33c6ac
< bitcoin-git> bitcoin/master 32da92b Wladimir J. van der Laan: gitian: Improve error handling
< bitcoin-git> bitcoin/master 12408d3 Wladimir J. van der Laan: Merge #15549: gitian: Improve error handling
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub

2019-03-08

< gmaxwell> I'd expect bitcoin core users and ones that update more actively to consume more inputs... due to being larger more active wallets, and due to BNB.
< sipa> bitcoin core since 0.10 uses this as synchronization mechanism; it's called headers-first sync
< sdaftuar> pinheadmz: no, it being deprecated is just in my head, that was how i thought about. i think bitcoin core hasn't sent getblocks messages in 5+ years or so.
< pinheadmz> when I test against Bitcoin Core, I noticed Core sent getheaders first, then getdata for the actual blocks
< gmaxwell> My list of banworthy unsubtle bitcoin spies and mass connectors has been updated! https://people.xiph.org/~greg/banlist.cli.txt https://people.xiph.org/~greg/banlist.gui.txt
< bitcoin-git> [bitcoin] laanwj merged pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/923d87497c7c...efed9809b4fa
< bitcoin-git> bitcoin/master 82c3b3f practicalswift: Remove sharp edge (uninitialized m_filter_type) when using the compiler-ge...
< bitcoin-git> bitcoin/master efed980 Wladimir J. van der Laan: Merge #15532: Remove sharp edge (uninit member) when using the compiler-ge...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d211edb34982...923d87497c7c
< bitcoin-git> bitcoin/master fa58a2e MarcoFalke: contrib: Bump gitian descriptors for 0.19
< bitcoin-git> bitcoin/master 923d874 MarcoFalke: Merge #15528: contrib: Bump gitian descriptors for 0.19
< gribble> https://github.com/bitcoin/bitcoin/issues/15560 | When to make bech32 the default -addresstype? · Issue #15560 · bitcoin/bitcoin · GitHub
< gmaxwell> Bitcoin core makes it pretty easy to get other addresses when you need them for compatiblity, fortunately.
< gribble> https://github.com/bitcoin/bitcoin/issues/14561 | Remove fs::relative call and fix listwalletdir tests by promag · Pull Request #14561 · bitcoin/bitcoin · GitHub
< fanquake> At least one issue reported for rc1 so far, https://github.com/bitcoin/bitcoin/issues/15555#issuecomment-470827939, although need more info.
< gmaxwell> Also, if you can think of the idea and getsomeone on fiverr to implement it, thats less harmful than something where a 5 year bitcoin expert has two spend three weeks extracting behavior patterns from codebases.
< shesek> maybe easier to think about this as "overall negative or positive effect on bitcoin users' privacy" than in morality terms
< gmaxwell> bitcoin core can but its a setting.
< gmaxwell> You might want to look over time, you may see the release when bitcoin core wouldn't violate UIH-2.
< shesek> not specifically electrum, quite a lot of other wallet software that I've had experience with. but yes, agreed, I didn't appreciate how good bitcoin core was at avoiding change, and didn't realize that it might break UIH-2 quite often
< gmaxwell> consistent. unbiased. e.g. all through our earlier discussion, you singled out behaviors of bitcoin because they aren't done by electrum, yet bitcoin core is responsible for a much larger share of transactions, so you're litterally singling out the larger anonymity set.
< gmaxwell> shesek: the end effect is you get some weird privacy warning on a small but non-trivial percentage of bitcoin core txn, ... but how does this help anyone? it just spreads fud. The txn are usually identifyable through other characteristics.
< shesek> UIH 1 or 2? UIH 1 is quite effective with most typical consumer wallet software. and you can check for some fingerprints first to try and rule out bitcoin core transactions (say, fee sniping nlocktime)
< gmaxwell> Well I still can't see how the UIH is essentially anything other than bitcoin core (derrived code) detection. And I think that sysematically putting up privacy warnings on the by far most private option (in spite its other costs) is really harmful.
< gmaxwell> I'm concerned with it being like the "bitcoin privacy project" which had a bunch of spurrious privacy unrelated ratings that caused it to derate the only options that had remotely good privacy (bitcoin core and armory) and rate over them a dozen wallets that sent all the users addresses to third parties.
< shesek> echeveria, the message shown when there's nothing to show is "his transaction doesn't violate any of the privacy gotchas we cover. Read on other potential ways it might leak privacy.", with a link to https://en.bitcoin.it/wiki/Privacy#Blockchain_attacks_on_privacy
< shesek> right, donations made by expert users that do manual coin selection is another potential reason. I was just writing that down in the wiki Privacy page today :) https://en.bitcoin.it/w/index.php?title=Privacy&diff=66261&oldid=66255
< gmaxwell> Again, it sounds like you're basically writing detect bitcoin core and print nasty warnings about litterly the only widely used wallet software that provides users with a decent degree of privacy at all.
< gmaxwell> that hurestic will pretty reliably misidentify change for many bitcoin core users right now. :)
< shesek> bitcoin core seems pretty smart about this. but, unfortunately, I don't think its actually being used to produce that many transactions, or does it? are there any estimates on that?
< gmaxwell> fees by, then there is probably a changeless solution, and bitcoin core will find it if there is one.
< gmaxwell> shesek: bitcoin core manages to produce changeless payments quite often, so long as the wallet has many inputs.
< gmaxwell> ./bitcoin-cli getpeerinfo | grep '^ "addr"' | grep '[0-9]\.' | cut -d'"' -f4 | cut -d':' -f1 | sort | uniq
< shesek> it would be interesting to test a bunch of transactions produced by bitcoin core and see what percent of them matches UIH-2. but I'm not using core to produce transactions, any thoughts on where one might be able to find a list of txids that are known to be core-originated?
< gmaxwell> shesek: IIRC bitcoin core has always violated it from day one. just not that all that often.
< gmaxwell> shesek: yes, bitcoin core will spend inputs a bit more when fees are low, though right now that behavior is kinda weak
< bitcoin-git> [bitcoin] fanquake opened pull request #15559: doc: correct analysepsbt rpc doc (master...fixup-analysepsbt-rpc-doc) https://github.com/bitcoin/bitcoin/pull/15559
< bitcoin-git> [bitcoin] Empact closed pull request #15556: build: Optionally enable -Wthread-safety-attributes (master...wthread-safety-attributes) https://github.com/bitcoin/bitcoin/pull/15556

2019-03-07

< gmaxwell> We probably don't want to randomly query them on each start, because if some are bad for your privacy (e.g. logging networks running bitcoin node) then you'll eventually hit them.
< bitcoin-git> [bitcoin] sipa opened pull request #15558: Query DNS seeds one by one (master...201903_dnsoneatatime) https://github.com/bitcoin/bitcoin/pull/15558
< gribble> https://github.com/bitcoin/bitcoin/issues/15103 | fix getentropy import check on osx by jameshilliard · Pull Request #15103 · bitcoin/bitcoin · GitHub
< * gmaxwell> votes to drop dnsseed discovery and just have bitcoin nodes scan the whole internet. :P
< gmaxwell> It does however mean that cloudflare is seeing the ip address of ~every bitcoin node.
< gmaxwell> (it's a 300s ttl at that level, but it's not like anyone else but bitcoin nodes are querying seeds.bitcoinstats.com )
< sipa> xps is where the bitcoin.sipa.be site runs
< gmaxwell> src/chainparams.cpp: vSeeds.emplace_back("seed.bitcoin.sipa.be"); // Pieter Wuille, only supports x1, x5, x9, and xd
< sipa> dig -t seed.bitcoin.sipa.be gives me the name of the machine running my dns seed; dig -t NS bitcoin.sipa.be gives me nothing
< gmaxwell> [gmaxwell@bean ~]$ dig +short NS bitcoin.sipa.be
< shesek> oh, sorry, I think #bitcoin-dev would probably be a better place to ask, shall I move it there?
< shesek> is it likely for bitcoin core to produce transactions matching UIH-2? (https://gist.github.com/AdamISZ/4551b947789d3216bacfcb7af25e029e#gistcomment-2796539, basically means that some inputs could've been avoided and the transaction would still have enough funding to cover the larger output)
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15464: gui: Drop unused return values in WalletFrame (master...2019-02-walletframe) https://github.com/bitcoin/bitcoin/pull/15464
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3db0cc394730...d211edb34982
< bitcoin-git> bitcoin/master 28c86de João Barbosa: gui: Drop unused return values in WalletFrame
< bitcoin-git> bitcoin/master d211edb Jonas Schnelli: Merge #15464: gui: Drop unused return values in WalletFrame
< gmaxwell> Probably we wouldn't propose implementing the multi-key version for bitcoin, but we had to feel out the design to figure out if it would be useful or not.
< provoostenator> I like being able to detect when my ISP starts messing with my Bitcoin P2P traffic :-)
< sipa> instagibbs: his position is that authentication without encryption is pointless (i agree, it mostly is), and that authentication of bitcoin connections is a slippery slope
< gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15519 | Add Poly1305 implementation by jonasschnelli · Pull Request #15519 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14047 | Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli · Pull Request #14047 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14049 | Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli · Pull Request #14049 · bitcoin/bitcoin · GitHub
< jonasschnelli> In case anyone wants to review the new v2 protocol (BIP151), including the new special ChaCha20Poly1305@bitcoin AEAD,... its here -> https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] instagibbs opened pull request #15557: Enhance `bumpfee` to include inputs when targeting a feerate (master...bumpall) https://github.com/bitcoin/bitcoin/pull/15557
< bitcoin-git> [bitcoin] Empact opened pull request #15556: build: Optionally enable -Wthread-safety-attributes (master...wthread-safety-attributes) https://github.com/bitcoin/bitcoin/pull/15556
< bitcoin-git> [bitcoin] laanwj merged pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/71ac4ebe4893...0fd3632868e2
< bitcoin-git> bitcoin/0.18 9d6dcc5 Pieter Wuille: Abstract EraseBlockData out of RewindBlockIndex
< bitcoin-git> bitcoin/0.18 32b2696 Pieter Wuille: Move erasure of non-active blocks to a separate loop in RewindBlockIndex
< bitcoin-git> bitcoin/0.18 1d34287 Pieter Wuille: Merge the disconnection and erasing loops in RewindBlockIndex
< bitcoin-git> [bitcoin] laanwj merged pull request #15552: 0.18: Granular invalidateblock and RewindBlockIndex (0.18...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15552
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/726d0668ff78...3db0cc394730
< bitcoin-git> bitcoin/master 9d6dcc5 Pieter Wuille: Abstract EraseBlockData out of RewindBlockIndex
< bitcoin-git> bitcoin/master 32b2696 Pieter Wuille: Move erasure of non-active blocks to a separate loop in RewindBlockIndex
< bitcoin-git> bitcoin/master 1d34287 Pieter Wuille: Merge the disconnection and erasing loops in RewindBlockIndex
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3515612e069e...726d0668ff78
< bitcoin-git> bitcoin/master faebd2e MarcoFalke: doc: Move wallet lock annotations to header
< bitcoin-git> bitcoin/master 726d066 MarcoFalke: Merge #15530: doc: Move wallet lock annotations to header
< bitcoin-git> [bitcoin] laanwj reopened pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] laanwj closed pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< wumpus> whoa at least the wumpus-announce list (i mean, bitcoin-core-dev) is still working
< bitcoin-git> [bitcoin] cisba opened pull request #15554: docs: binary tar improvement (master...improve-tar) https://github.com/bitcoin/bitcoin/pull/15554
< gmaxwell> /join #bitcoin
<@gwillen> but it's not really in keeping with the bitcoin-qt aesthetic
< bitcoin-git> [bitcoin] fanquake closed pull request #15544: Comment typo "iff" (master...master) https://github.com/bitcoin/bitcoin/pull/15544

2019-03-06

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15552: 0.18: Granular invalidateblock and RewindBlockIndex (0.18...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15552
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df36ddf9ce8a...3515612e069e
< bitcoin-git> bitcoin/master fa5dc35 MarcoFalke: rpc: Pass mempool into MempoolToJSON
< bitcoin-git> bitcoin/master fa38535 MarcoFalke: bench: Benchmark MempoolToJSON
< bitcoin-git> bitcoin/master 3515612 MarcoFalke: Merge #15473: bench: Benchmark MempoolToJSON
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15473: bench: Benchmark MempoolToJSON (master...Mf1902-benchRpcMempool) https://github.com/bitcoin/bitcoin/pull/15473
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15504: fuzz: Link BasicTestingSetup (shared with unit tests) (master...1903-testMain) https://github.com/bitcoin/bitcoin/pull/15504
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4952a953585e...df36ddf9ce8a
< bitcoin-git> bitcoin/master fab2daa MarcoFalke: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
< bitcoin-git> bitcoin/master fa02b22 MarcoFalke: test: Remove useless test_bitcoin_main.cpp
< bitcoin-git> bitcoin/master fa85468 MarcoFalke: test: Move main_tests to validation_tests
< bitcoin-git> [bitcoin] fametrano opened pull request #15550: [trivial] fixed path (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
< wumpus> andytoshi: that's a good question, normally the bitcoin-dev mailing list would be the best place to solicit feedback like that, but now that it's not working I don't really know
< gribble> https://github.com/bitcoin/bitcoin/issues/15549 | gitian: Improve error handling by laanwj · Pull Request #15549 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15548: build: use full version string in setup.exe (master...1903-winVer) https://github.com/bitcoin/bitcoin/pull/15548
< wumpus> so… it all turned out to be a VM disk space issue: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470160960
< bitcoin-git> [bitcoin] instagibbs opened pull request #15547: Switch wallet default to reject too-long transaction chains for mempool (master...walletreject_true) https://github.com/bitcoin/bitcoin/pull/15547
< provoostenator> I just need to brush up my bash to take only the first two digits from $VERSION in https://github.com/bitcoin-core/docs/issues/18
< provoostenator> The unsolved one is that we still use "bitcoin-linux-0.18-build.assert.sig" instead of "bitcoin-linux-0.18.0-build.assert.sig"
< gribble> https://github.com/bitcoin/bitcoin/issues/15546 | gitian: Windows installer EXE filenames lack "rcN" suffix · Issue #15546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
< luke-jr> bitcoin-0.18.0-win32-setup-unsigned.exe bitcoin-0.18.0rc1-win32.zip bitcoin-0.18.0-win64-setup-unsigned.exe bitcoin-0.18.0rc1-win64.zip
< provoostenator> File naming has some other issues too, in some places it doesn't include the patch version. See: https://github.com/bitcoin-core/docs/issues/18
< provoostenator> luke-jr: for which distro? Afaik bitcoind and bitcoin-cli never include a version number.
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15440 | RFC including boost-process · Issue #15440 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15545: [doc] explain why CheckBlock() is called before AcceptBlock (master...2019/03/clarify-checkblock) https://github.com/bitcoin/bitcoin/pull/15545
< * wumpus> doesn't even succeed in making the bitcoin core build deterministic so who am I to complain ...
< wumpus> same for the divergence between my own previous and current builds, except that affects bitcoin-qt
< wumpus> the difference seems to be minimal: presence/absence of .gnu_debuglink section: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470034776
< bitcoin-git> [bitcoin] Bushstar opened pull request #15544: Comment typo "iff" (master...master) https://github.com/bitcoin/bitcoin/pull/15544
< wumpus> unfortunately ,no they're different sizes, https://github.com/bitcoin/bitcoin/issues/15541
< wumpus> Binary files achow101/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin differ
< wumpus> Binary files achow101/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin differ
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521

2019-03-05

< booyah> mmgen: #bitcoin-bans is about discussing bans
< mmgen> sipa: well, I'd be happy to take it to #bitcoin, but gmaxwell has banned me there, for promoting "snake oil"
< mmgen> well if i'm banned on #bitcoin, how can I get unbanned?
<@gwillen> FWIW I think your tool looks cool, although I am skeptical that your alternative to BIP32 is an improvement but I'd be interested to hear about the motivation behind it (but not in this channel, perhaps #bitcoin-dev would accept such a conversation)
< gmaxwell> My logs show mmgen first joined #bitcoin on feb 23rd and in that time he his linked his tool 35 times.