< jarthur>
jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
< gribble>
https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
< andytoshi>
meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core"
< midnightmagic>
wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time.
< bitcoin-git>
[bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
< bitcoin-git>
[bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
< bitcoin-git>
[bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
< wumpus>
luke-jr: a bitcoin core-tor bundle has been talked about since 2012 at least
< luke-jr>
says the guy who wrote bitcoin-qt..
< wumpus>
yess I'm... not sure how I got involved in this at all tbh, I made bitcoin-qt because I thought it would help get actual GUI people invovled, make it easier for them
< wumpus>
as you can't really make an assumption about the precision, yes if you write software for bitcoin specifically you can hardcode 10^-8, but anythign that needs to interface between different systems and APIs and databases needs to convert between them on their own terms
< gmaxwell>
phantomcircuit: the old json library bitcoin used to use randomly inserted conversions to float in a minor upgrade!
< gmaxwell>
phantomcircuit: depends on what you mean by float, common bitcoin values don't fit precisely in 32-bit floats, they do in 64-bit doubles.
< wumpus>
gmaxwell: yes, it's trivial change to ValueFromAmount if you really want to, though I'd suggest looking at a better suited JSONRPC library, by now for most languages there's something for bitcoin specifically
< gmaxwell>
in Bitcoin core they're just 64 bit integers.
< sipa>
karelb: also, inside bitcoin core there no conversion of amounts to floats ever (except feerates), even to convert to JSON
< bitcoin-git>
[bitcoin] Sjors opened pull request #14509: [doc] getblocktemplate: use SegWit in example (0.17...2018/10/backport-doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14509
< karelb>
thinking out loud- yesterday we talked with colleague how we hate that JSON RPC returns BTC values as floats. (at various points.) Do you think it would be a good idea to be able to somehow switch this with some option? either option for whole bitcoind, or just another parameter for bitcoin-cli
< bitcoin-git>
[bitcoin] laanwj closed pull request #14472: [doc] getblocktemplate: use SegWit in example (master...2018/10/doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14472
< bitcoin-git>
[bitcoin] laanwj closed pull request #14370: utils and libraries: Allow values quoting in config files (master...20181002-config-quotes) https://github.com/bitcoin/bitcoin/pull/14370
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14505: Make all single parameter constructors explicit (C++11) (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
< promag>
ken2812221: do you build bitcoin-qt with msvc?
< bitcoin-git>
[bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
< bitcoin-git>
bitcoin/master ee0b7c4 practicalswift: build: Pin to specific versions of Python packages we install from PyPI in Travis
< bitcoin-git>
bitcoin/master 3036faf Wladimir J. van der Laan: Merge #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis...
< gmaxwell>
indeed, we've had people in #bitcoin that were having issues because some third party was trying to password bruteforce their rpc port or something like that..
< echeveria>
all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software.
< gmaxwell>
"We build the software that Bitcoin deserves" ... just so.
< gmaxwell>
"Use your personal node to broadcast transactions to the bitcoin network"
< echeveria>
gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin.
< bitcoin-git>
bitcoin/master edb5350 Patrick Strateman: Move NotifyNumConnectionsChanged logic to private method.
< bitcoin-git>
bitcoin/master 7479b63 Patrick Strateman: Move DisconnectNodes logic to private method.
< bitcoin-git>
bitcoin/master 2af9cff Patrick Strateman: Move InactivityCheck logic to private method.
< bitcoin-git>
[bitcoin] DesWurstes closed pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
< ken2812221__>
Copy bitcoin-cli.exe and bitcoind.exe into src folder. Modify and copy test\config.ini.in to test\config.ini. Then you can run python test\functional\test_runner.py --force.
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
< bitcoin-git>
bitcoin/master 36323e2 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
< bitcoin-git>
bitcoin/master 9bd3ff4 Wladimir J. van der Laan: Merge #14383: qt: Clean system tray icon menu for '-disablewallet' mode...
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
< kallewoof>
How does bitcoin core track bip9 activation states? I have odd cases where a copied chain state will result in all bip9 soft forks turning up as "failed" rather than "activated". If I disable the timeout, they show up as 'started', but with 'possible: false'.
2018-10-15
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
< bitcoin-git>
[bitcoin] achow101 closed pull request #14019: Import pubkeys when importing p2sh with importmulti (master...import-multi-pubkeys) https://github.com/bitcoin/bitcoin/pull/14019
< bitcoin-git>
[bitcoin] DesWurstes opened pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
< bitcoin-git>
bitcoin/master 2a2cac7 Jonas Schnelli: Merge #14424: Stop requiring imported pubkey to sign non-PKH schemes...
< bitcoin-git>
[bitcoin] HatboyWonder opened pull request #14484: changed request payment button text and tab description (master...master) https://github.com/bitcoin/bitcoin/pull/14484
< karelb>
Also - how much does bitcoin (at least new code) use all the const correctness stuff? I never know how to write it correctly and where to add `const`
< karelb>
"Class member variables have a m_ prefix" - I don't see that in many class variables in bitcoin codebase?
< karelb>
Is there some linter on bitcoin core that looks for line length?
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14481: Add P2SH-P2WSH support to listunspent RPC (master...201810_listunspent_wsh) https://github.com/bitcoin/bitcoin/pull/14481
< bitcoin-git>
[bitcoin] MeshCollider closed pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread (master...drop-boost-thread-import) https://github.com/bitcoin/bitcoin/pull/14480
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478
2018-10-13
< bitcoin-git>
[bitcoin] sipa opened pull request #14477: Add ability to convert solvability info to descriptor (master...201810_inferdescript) https://github.com/bitcoin/bitcoin/pull/14477
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14475: serialize: Document integer width assumptions we are making when calculating compact sizes (master...integer-width-assumptions) https://github.com/bitcoin/bitcoin/pull/14475
< bitcoin-git>
[bitcoin] alecalve opened pull request #14474: bitcoin-tx: Use constant for n pubkeys check (master...bitcoin_tx_use_constant) https://github.com/bitcoin/bitcoin/pull/14474
< bitcoin-git>
[bitcoin] Sjors opened pull request #14472: [doc] getblocktemplate: use SegWit in example (master...2018/10/doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14472
< jnewbery>
promag: yes, the version the RPC will be removed in should be in the warning text and the release notes when the RPC is deprecated. See https://github.com/bitcoin/bitcoin/pull/14468/files for example
< echeveria>
#bitcoin is not +r, it does not require registration.
< echeveria>
grey-jacket: #bitcoin is not restricted in any way, ask there.
< grey-jacket>
I see this is the wrong channel, but messages to #bitcoin don't go out
< gwillen>
provoostenator: uhm, hm. It does it when I build it myself at the tag v0.17.0, but not when I run the release binary downloaded from bitcoin.org.
2018-10-11
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14465: tests: Stop node before removing the notification file (master...test-notification-fix) https://github.com/bitcoin/bitcoin/pull/14465
< sipa>
try bitcoin.stackexchange.com too, and have some patience
< sipa>
so yes, your questions about usage or development with bitcoin core are off topic
< tradermyx>
So I ask in ##bitcoin and nobody responds for hours. Ghost town. What do you want me to do? Sit and twiddle my thumbs or ask where there are experts on this particular software?
< sipa>
this channel is about develop*ing* bitcoin core
< tradermyx>
Well, I "develop", but not Bitcoin Core... rather trying to use it.
< tradermyx>
I give up. I've now wasted countless hours of my life trying to figure out the basic information about how Bitcoin Core's .conf file wants strings escaped.