2016-10-27

< GitHub55> bitcoin/master 1c3ecc7 S. Matthew English: instance of 'mem pool' to 'mempool'...
< GitHub55> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/83234d4d1723...fea5e05a6380
< whphhg> Hej, is there a Bitcoin Unlimited channel on freenode?
< GitHub134> [bitcoin] laanwj closed pull request #9033: Update build notes for dropping osx 10.7 support (fanquake) (master...Mf1610-docFanquake) https://github.com/bitcoin/bitcoin/pull/9033
< GitHub66> bitcoin/master 83234d4 Wladimir J. van der Laan: Merge #9033: Update build notes for dropping osx 10.7 support (fanquake)...
< GitHub66> bitcoin/master ba26d41 Michael Ford: Update build notes for dropping osx 10.7 support...
< GitHub66> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a49b4a75a1b6...83234d4d1723
< GitHub138> bitcoin/master a49b4a7 Wladimir J. van der Laan: doc: Add release notes for 0.13.1 release
< GitHub138> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/a49b4a75a1b671492e65eed17d6894d85ea5ebfd
< GitHub49> bitcoin/0.13 2e2388a Wladimir J. van der Laan: Move release notes to release-notes/release-notes-0.13.1.md...
< GitHub49> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/2e2388a5cbb9a6e101b36e4501698fec538a5738
< GitHub163> [bitcoin] MarcoFalke opened pull request #9033: Update build notes for dropping osx 10.7 support (fanquake) (master...Mf1610-docFanquake) https://github.com/bitcoin/bitcoin/pull/9033
< GitHub48> [bitcoin] MarcoFalke reopened pull request #9011: 0.13.2 backports (0.13...2016_10_backports_conditional_rc3) https://github.com/bitcoin/bitcoin/pull/9011
< GitHub57> [bitcoin] laanwj opened pull request #9032: test: Add format-dependent comparison to bctest (master...2016_10_bctest_smart_compare) https://github.com/bitcoin/bitcoin/pull/9032
< wumpus> gmaxwell: yeah came up earlier today already there's even an issue :) https://github.com/bitcoin/bitcoin/issues/9028
< GitHub174> [bitcoin] rebroad opened pull request #9030: Don't process blocktxns when we have the block already. (master...BlocktxnExits) https://github.com/bitcoin/bitcoin/pull/9030
< GitHub161> [bitcoin] s-matthew-english opened pull request #9029: instance of 'mem pool' to 'mempool' (master...patch-7) https://github.com/bitcoin/bitcoin/pull/9029
< btcdrak> wumpus: can you restart https://travis-ci.org/bitcoin/bitcoin/builds/170827031, dunno why Travis borked
< btcdrak> wumpus: well we have tests that compare the json output of "./bitcoin-tx -json ..." with a json file. trailing white space can get trimmed by IDE/editor settings. Trailing white space has no place in a json file. If it wasnt for that nice "log errors as diff" patch to bitcoin-unit-test.py submitted yesterday I would have lost my mind.
< GitHub177> bitcoin/0.13 03422e5 Wladimir J. van der Laan: Merge #9022: Update release notes to mention dropping OS X 10.7 support...
< GitHub177> bitcoin/0.13 1d12463 Michael Ford: Update release notes for dropping osx 10.7 support
< GitHub177> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/a32d7c23fc0e...03422e564b55
< GitHub7> [bitcoin] laanwj closed pull request #9022: Update release notes to mention dropping OS X 10.7 support (0.13...0-13-1-osx-notes) https://github.com/bitcoin/bitcoin/pull/9022
< gmaxwell> here is the max from that data, BitClub -0.00042054 HaoBTC 0.03818631 BitFury 0.05457683 BTC.com 0.07372295 SlushPool 0.09595818 BTCC 0.09886828 ViaBTC 0.11170776 F2Pool 0.12080682 Bitcoin.com 0.12846755 AntPool 0.14341536 Unknown 0.16687057 BW.COM 0.18705609 GBMiners 0.24633568 Telco 0.709605 Eligius 1.03414

2016-10-26

< gmaxwell> Bitcoin.com 0.106677
< btcdrak> Please review: "Add segwit upgrade guide" https://github.com/bitcoin-core/bitcoincore.org/pull/240
< GitHub114> [bitcoin] sdaftuar opened pull request #9026: Fix handling of invalid compact blocks (master...fix-invalidcb-handling) https://github.com/bitcoin/bitcoin/pull/9026
< wumpus> btcdrak: upstream to jgarzik/univalue, and we can merge it to bitcoin-core/univalue if that takes too long / is urgent
< GitHub151> [bitcoin] jnewbery opened pull request #9025: getrawtransaction should take a bool for verbose (master...getrawtransbool) https://github.com/bitcoin/bitcoin/pull/9025
< wumpus> that's slightly curious, maybe getrawtransaction author expected an 'even more verbose' format at some point and pass '2'? it'd have made sense for `getblock` and https://github.com/bitcoin/bitcoin/pull/8704
< GitHub162> [bitcoin] laanwj closed pull request #9020: rpc: Remove invalid explanation from wallet fee message (master...2016_10_wallet_message) https://github.com/bitcoin/bitcoin/pull/9020
< GitHub9> bitcoin/master 86f9e3d Wladimir J. van der Laan: Merge #9020: rpc: Remove invalid explanation from wallet fee message...
< GitHub9> bitcoin/master 04c1c15 Wladimir J. van der Laan: rpc: Remove invalid explanation from wallet fee message
< GitHub9> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/54259370ae93...86f9e3dbba41
< GitHub58> [bitcoin] jnewbery opened pull request #9023: Add logging to bitcoin-util-test.py (master...btutiltestlogging) https://github.com/bitcoin/bitcoin/pull/9023
< GitHub197> [bitcoin] fanquake opened pull request #9022: Update release notes to mention dropping OS X 10.7 support (0.13...0-13-1-osx-notes) https://github.com/bitcoin/bitcoin/pull/9022
< GitHub60> [bitcoin] laanwj closed pull request #9021: zetacoin 0.13 (master...gzuser01-patch-1) https://github.com/bitcoin/bitcoin/pull/9021
< GitHub64> [bitcoin] gzuser01 opened pull request #9021: zetacoin 0.13 (master...gzuser01-patch-1) https://github.com/bitcoin/bitcoin/pull/9021
< GitHub119> [bitcoin] laanwj opened pull request #9020: rpc: Remove invalid explanation from wallet fee message (master...2016_10_wallet_message) https://github.com/bitcoin/bitcoin/pull/9020
< blur3d> Hey Core. Just a thank you message for your all your work. Keep doing what you guys are doing. Ignore the outside pressures, and keep bitcoin from becoming centeralised. All of the fear mongering ignores the simple fact that the bitcoin network would be near impossible to replicate from scratch. Any transitional periods may have some discomfort, but compromising the network for short term bandaides is for fools.
< GitHub60> bitcoin/0.13 a32d7c2 Cory Fields: release: bump required osx version to 10.8. Credit jonasschnelli....
< GitHub60> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/a32d7c23fc0eedebe3579edb5d488a4c63b67b70
< GitHub90> [bitcoin] laanwj closed pull request #9015: release: bump required osx version to 10.8. (jonasschnelli) (master...osx-disable107) https://github.com/bitcoin/bitcoin/pull/9015
< GitHub193> bitcoin/master 5425937 Wladimir J. van der Laan: Merge #9015: release: bump required osx version to 10.8. (jonasschnelli)...
< GitHub193> bitcoin/master 339c4b6 Cory Fields: release: bump required osx version to 10.8. Credit jonasschnelli....
< GitHub193> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bdf5269f886...54259370ae93
< luke-jr> gmaxwell: context https://github.com/bitcoin/bitcoin/issues/9001 fwiw

2016-10-25

< GitHub177> [bitcoin] sipa closed pull request #9018: testing pr (please ignore) (master...loop) https://github.com/bitcoin/bitcoin/pull/9018
< GitHub85> [bitcoin] ryanofsky opened pull request #9018: testing pr (please ignore) (master...loop) https://github.com/bitcoin/bitcoin/pull/9018
< GitHub111> [bitcoin] instagibbs opened pull request #9017: Enable various p2sh-p2wpkh functionality (master...p2shp2wpkhstuff) https://github.com/bitcoin/bitcoin/pull/9017
< GitHub139> [bitcoin] instagibbs opened pull request #9016: Return useful error message on ATMP failure (master...atmperror) https://github.com/bitcoin/bitcoin/pull/9016
< GitHub115> [bitcoin] theuni opened pull request #9015: release: bump required osx version to 10.8. Credit jonasschnelli. (master...osx-disable107) https://github.com/bitcoin/bitcoin/pull/9015
< wumpus> the ancient wallet message I was talking about still exists, but apparently I closed the issue: https://github.com/bitcoin/bitcoin/issues/211 "Error: This transaction requires a transaction fee of at least %s because of its amount, complexity, or use of recently received funds!"
< cfields_> instagibbs: see the comments in https://github.com/bitcoin/bitcoin/pull/8888
< jonasschnelli> IIRC, I did only move the SoftSetBoolArg() in https://github.com/bitcoin/bitcoin/pull/6780
< jonasschnelli> <*highlight>[13:50:51] <wumpus:#bitcoin-core-dev> jonasschnelli: re: https://github.com/bitcoin/bitcoin/pull/9010, any idea why not all parameter interaction was moved to InitParameterInteraction?
< wumpus> no problem, just send a copy to bitcoin-core-dev too
< btcdrak> please send to bitcoin-core-dev also
< wumpus> BlueMatt: you sent the rc announcement to bitcoin-dev instead of bitcoin-core-dev :)
< cfields_> wumpus: practically, no. Bitcoin-qt is busted on 10.7. This would just make it refuse to run there, rather than mysteriously crashing.
< cfields_> wumpus: you ok with https://github.com/bitcoin/bitcoin/issues/8577#issuecomment-255947269 with no additional testing?
< GitHub136> bitcoin/0.13 58d4fa7 MarcoFalke: [net] Remove assert(nMaxInbound > 0)...
< GitHub136> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/58d4fa7da30cb57e5fc3dca62f49a64e126c76cd
< GitHub191> [bitcoin] laanwj closed pull request #9011: 0.13.1 backports conditional on rc3 (0.13...2016_10_backports_conditional_rc3) https://github.com/bitcoin/bitcoin/pull/9011
< GitHub26> [bitcoin] TheBlueMatt opened pull request #9014: Fix block-connection performance regression (master...2016-10-fix-tx-regression) https://github.com/bitcoin/bitcoin/pull/9014
< GitHub198> [bitcoin] gtsui opened pull request #9013: Trivial: Explicitly pass const CChainParams& to LoadBlockIndexDB() (master...global-params-cleanup) https://github.com/bitcoin/bitcoin/pull/9013
< GitHub126> [bitcoin] laanwj closed pull request #8515: A few mempool removal optimizations (master...moresharedmem) https://github.com/bitcoin/bitcoin/pull/8515
< GitHub99> bitcoin/master 4100499 Pieter Wuille: Return shared_ptr<CTransaction> from mempool removes
< GitHub99> bitcoin/master 51f2783 Pieter Wuille: Make removed and conflicted arguments optional to remove
< GitHub99> bitcoin/master f48211b Pieter Wuille: Bypass removeRecursive in removeForReorg
< GitHub99> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e077e0030384...9bdf5269f886
< GitHub37> bitcoin/0.13 cb69988 Wladimir J. van der Laan: Merge #9012: release-notes: Update from blog draft...
< GitHub37> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/c9a5baddeef3...cb699885728f
< GitHub37> bitcoin/0.13 99f5cf1 Luke Dashjr: release-notes: Update from blog draft
< GitHub65> [bitcoin] laanwj closed pull request #9012: release-notes: Update from blog draft (0.13...0.13.1_relnotes_update) https://github.com/bitcoin/bitcoin/pull/9012
< wumpus> jonasschnelli: re: https://github.com/bitcoin/bitcoin/pull/9010, any idea why not all parameter interaction was moved to InitParameterInteraction?
< GitHub43> [bitcoin] luke-jr opened pull request #9012: release-notes: Update from blog draft (0.13...0.13.1_relnotes_update) https://github.com/bitcoin/bitcoin/pull/9012
< GitHub175> [bitcoin] laanwj closed pull request #8948: [TRIVIAL] reorder Windows gitian build order to match Linux (master...master) https://github.com/bitcoin/bitcoin/pull/8948
< GitHub186> bitcoin/master e077e00 Wladimir J. van der Laan: Merge #8948: [TRIVIAL] reorder Windows gitian build order to match Linux...
< GitHub186> bitcoin/master 3f7581d Micha: [TRIVIAL] reorder Windows gitian build order to match Linux...
< GitHub186> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f14f07cb94eb...e077e0030384
< GitHub138> [bitcoin] laanwj opened pull request #9011: 0.13.1 backports conditional on rc3 (0.13...2016_10_backports_conditional_rc3) https://github.com/bitcoin/bitcoin/pull/9011
< GitHub161> [bitcoin] laanwj closed pull request #9008: [net] Remove assert(nMaxInbound > 0) (master...Mf1610-netAssert) https://github.com/bitcoin/bitcoin/pull/9008
< GitHub103> bitcoin/master f14f07c Wladimir J. van der Laan: Merge #9008: [net] Remove assert(nMaxInbound > 0)...
< GitHub103> bitcoin/master fa1c3c2 MarcoFalke: [net] Remove assert(nMaxInbound > 0)...
< GitHub103> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e1d1f57b56b2...f14f07cb94eb
< GitHub130> [bitcoin] laanwj closed pull request #9002: Make connect=0 disable automatic outbound connections. (master...connect0) https://github.com/bitcoin/bitcoin/pull/9002
< GitHub59> bitcoin/master e1d1f57 Wladimir J. van der Laan: Merge #9002: Make connect=0 disable automatic outbound connections....
< GitHub59> bitcoin/master 515e264 Gregory Maxwell: Make connect=0 disable automatic outbound connections....
< GitHub59> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67728a389ccf...e1d1f57b56b2
< GitHub194> [bitcoin] laanwj opened pull request #9010: Split up AppInit2 into multiple phases, daemonize after datadir lock errors (master...2016_10_init_split_daemon) https://github.com/bitcoin/bitcoin/pull/9010
< wumpus> gmaxwell: yeah it's sort of a known issue https://github.com/bitcoin/bitcoin/pull/8278#issuecomment-242706794 , though opening an issue to track it wouldn't hurt
< gmaxwell> just always says "Bitcoin server starting" :P
< sipa> 1024 + H("bitcoin port" || ip) % (32768 - 1024)
< wumpus> it also means you can make a selection "no bitcoin here, but we allow dogecoin and litecoin through!"
< wumpus> I agree that tor or vpns are a better way to avoid more persistent firewalling, but ideally bitcoin core would get around the simple case of 'port 8333 firewalled'
< tulip> I've been trying to work out where the regression that allows bitcoin core to attempt connections on port 0 is.
< jonasschnelli> Though, the original 10.7 bug was reported in #bitcoin
< GitHub15> [bitcoin] laanwj reopened pull request #8775: RPC refactoring: Never access wallet directly, only via new CRPCRequestInfo (master...multiwallet_prefactor_rpc) https://github.com/bitcoin/bitcoin/pull/8775
< luke-jr> can someone reopen https://github.com/bitcoin/bitcoin/pull/8775 ? the other PR had only a tiny part of it.. (ping wumpus)
< GitHub169> bitcoin/master 67728a3 Wladimir J. van der Laan: Merge #9004: Clarify `listenonion`...
< GitHub2> [bitcoin] laanwj closed pull request #9004: Clarify `listenonion` (master...patch-3) https://github.com/bitcoin/bitcoin/pull/9004
< GitHub169> bitcoin/master 3421e74 unsystemizer: Clarify `listenonion`...
< GitHub169> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ced22d035ac0...67728a389ccf

2016-10-24

< murch> gmaxwell: some preliminary results on the same data set I talked about at Scaling Bitcoin: https://docs.google.com/spreadsheets/d/1dzugGnAw2nBNL_BwpFR44jci8rO3RkkF5M9OcP2ESN0/pubhtml
< murch> gmaxwell: After Scaling Bitcoin I came up with a new algorithm. I'm still running experiments on it (and writing my evaluation chapter, thesis is due next week), but it looks pretty promising in all aspects.
< murch> Hey gmaxwell, I was missing you at Scaling Bitcoin. :)
< gmaxwell> nibor: majority hashpower can make their new commitment say that a million bitcoin that wasn't theirs is now theirs. Then all newly joining nodes will get the new chainstate, and eventually all old nodes will think they've hit a reorg larger than people have blocks available, and so they'll do a chainstate sync too...
< gmaxwell> The other important thing about this proposal is that it needs to be very upfront about this being a signficant change to the Bitcoin security model, and justify it. I believe it is a nessary one.
< GitHub49> [bitcoin] MarcoFalke opened pull request #9008: [net] Remove assert(nMaxInbound > 0) (master...Mf1610-netAssert) https://github.com/bitcoin/bitcoin/pull/9008
< BlueMatt> argh, someone wanna tag https://github.com/bitcoin/bitcoin/issues/9007 0.13.1?
< wumpus> does anyone care about DecodeBase58 performance? If so, please review/test https://github.com/bitcoin/bitcoin/pull/8736
< GitHub156> [bitcoin] laanwj closed pull request #8995: Add missing cs_main lock to ::GETBLOCKTXN processing (master...2016-10-fix-getblocktxn-locks) https://github.com/bitcoin/bitcoin/pull/8995
< GitHub42> bitcoin/master ced22d0 Wladimir J. van der Laan: Merge #8995: Add missing cs_main lock to ::GETBLOCKTXN processing...
< GitHub42> bitcoin/master dfe7906 Matt Corallo: Add missing cs_main lock to ::GETBLOCKTXN processing...
< GitHub42> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd29348dbe82...ced22d035ac0
< GitHub87> [bitcoin] unsystemizer opened pull request #9004: Clarify `listenonion` (master...patch-3) https://github.com/bitcoin/bitcoin/pull/9004
< GitHub145> [bitcoin] laanwj closed pull request #8993: Trivial: Fix doxygen comment: the transaction is returned in txOut (master...20161021_fix_GetTransaction_comment) https://github.com/bitcoin/bitcoin/pull/8993
< GitHub101> bitcoin/master fd29348 Wladimir J. van der Laan: Merge #8993: Trivial: Fix doxygen comment: the transaction is returned in txOut...
< GitHub101> bitcoin/master 1d8e12b Pavel Janík: Fix doxygen comment: the transaction is returned in txOut
< GitHub101> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f08222e882b1...fd29348dbe82
< wumpus> anyhow the problem here is that bitcoin core uses the OS's IP parsing, this has resulted in confusion before
< GitHub14> [bitcoin] gmaxwell opened pull request #9002: Make connect=0 disable automatic outbound connections. (master...connect0) https://github.com/bitcoin/bitcoin/pull/9002

2016-10-23

< GitHub52> [bitcoin] TheBlueMatt closed pull request #7903: Fix help text around importaddress and rename it to importscript (master...16-04-importaddress-helptext) https://github.com/bitcoin/bitcoin/pull/7903
< arubi> bitcoin is officially over 9000
< GitHub114> [bitcoin] theuni opened pull request #9000: miner debugging: faux-mining (master...faux-mining) https://github.com/bitcoin/bitcoin/pull/9000
< wumpus> I'm going to try to get this gcbpay person banned from our github, this can no longer be accidental: https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=is%3Aissue%20author%3Agcbpay%20
< wumpus> namecoin did fairly recently rebase on top of newer bitcoin core (not sure what version). But yes most coins do not, it's not like they're a big target for attacks, nor actively maintained. The only way we notice is that sometimes people file bugs/build system issues against bitcoincore that have been fixed years ago, not realizing we've moved on since
< tulip> for a long time most alt coins were, and still are 0.6 based branches. the original proof of stake patches were never rebased onto modern Bitcoin Core until quite late in the crazy. the original lfnet IRC channels still have hundreds of alt coin nodes (but only 2-3 wxBitcoin).
< jtimon> gmaxwell: wumpus btcdrak sorry I missed the rest conversation in https://botbot.me/freenode/bitcoin-core-dev/2016-10-22/?msg=75272893&page=1
< nsh> there were a couple issues identified in NCC audit by NCC group which might be relevant to bitcoin-core. not sure if they made it upstream.
< GitHub8> [bitcoin] luke-jr opened pull request #8996: Network activity toggle (master...networkactive) https://github.com/bitcoin/bitcoin/pull/8996

2016-10-22

< Victorsueca> the end of the world.... as we know it and the beginning of the decentralised currency era! buy bitcoin know while your fiduciary money is still worth something!
< btcdrak> Is this a random travis fail? https://travis-ci.org/bitcoin/bitcoin/jobs/169675967
< aj> seems like jessie; the bitcoin.org binaries seemed to work fine for me in a chroot
< gmaxwell> for the latter, I'm not sure what the answer is.. one option is "use bitcoin.org binaries" but if you have to compile perhaps there is a newer compiler you can install out of the next distro version without breaking things?
< GitHub153> [bitcoin] rebroad closed pull request #8959: Fix sort arrow in peer table (master...FixPeerTableSort) https://github.com/bitcoin/bitcoin/pull/8959
< wumpus> in any case I'm going to work on GPU drivers a bit more now, still have some outstanding work to do there, maybe I can return to bitcoin with a clearer perspective
< wumpus> I'm tired of this madness, whatever you do people are going to complain, going to disengage from bitcoin-related things for a while
< GitHub9> [bitcoin] TheBlueMatt opened pull request #8995: Add missing cs_main lock to ::GETBLOCKTXN processing (master...2016-10-fix-getblocktxn-locks) https://github.com/bitcoin/bitcoin/pull/8995
< GitHub101> [bitcoin] jtimon opened pull request #8994: Testchains: Introduce custom chain whose constructor... (master...0.13-new-testchain) https://github.com/bitcoin/bitcoin/pull/8994

2016-10-21

< GitHub91> [bitcoin] paveljanik opened pull request #8993: Trivial: Fix doxygen comment: the transaction is returned in txOut (master...20161021_fix_GetTransaction_comment) https://github.com/bitcoin/bitcoin/pull/8993
< GitHub149> [bitcoin] instagibbs opened pull request #8992: Enable pubkey lookup for p2sh-p2wpkh in validateaddress (master...validatep2pkh) https://github.com/bitcoin/bitcoin/pull/8992
< GitHub104> [bitcoin] MarcoFalke closed pull request #8982: Eliminating Inconsistencies in Textual Output (master...patch-6) https://github.com/bitcoin/bitcoin/pull/8982
< GitHub174> bitcoin/master f08222e MarcoFalke: Merge #8982: Eliminating Inconsistencies in Textual Output...
< GitHub174> bitcoin/master 3a286ab S. Matthew English: Eliminating Inconsistencies in Textual Output...
< GitHub174> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cf496d102d2...f08222e882b1
< GitHub170> [bitcoin] laanwj closed pull request #8968: Don't hold cs_main when calling ProcessNewBlock from a cmpctblock (master...cmpctblock) https://github.com/bitcoin/bitcoin/pull/8968
< GitHub86> bitcoin/master 3cf496d Wladimir J. van der Laan: Merge #8968: Don't hold cs_main when calling ProcessNewBlock from a cmpctblock...
< GitHub86> bitcoin/master 72ca7d9 Matt Corallo: Don't hold cs_main when calling ProcessNewBlock from a cmpctblock
< GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5af9a7117cff...3cf496d102d2
< GitHub164> [bitcoin] laanwj closed pull request #8975: Chainparams: Trivial: In AppInit2(), s/Params()/chainparams/ (master...0.13-chainparams-init) https://github.com/bitcoin/bitcoin/pull/8975
< GitHub36> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fb3fade3c02...5af9a7117cff
< GitHub36> bitcoin/master 6f2f639 Jorge Timón: Chainparams: Trivial: In AppInit2(), s/Params()/chainparams/
< GitHub36> bitcoin/master 5af9a71 Wladimir J. van der Laan: Merge #8975: Chainparams: Trivial: In AppInit2(), s/Params()/chainparams/...
< michagogo> Like Bitcoin, sort of
< jonasschnelli> ping cfields_ : https://github.com/bitcoin/bitcoin/issues/8577
< GitHub155> [bitcoin] laanwj closed pull request #8990: moveonly: move `coincontrol` to `src/wallet` (master...2016_10_coincontrol_wallet) https://github.com/bitcoin/bitcoin/pull/8990
< GitHub53> bitcoin/master 3fb3fad Wladimir J. van der Laan: Merge #8990: moveonly: move `coincontrol` to `src/wallet`...
< GitHub53> bitcoin/master 1ae5839 Wladimir J. van der Laan: moveonly: move `coincontrol` to `src/wallet`
< GitHub53> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b1bfa3a8786...3fb3fade3c02
< GitHub79> [bitcoin] jonasschnelli closed pull request #8985: Use pindexBestHeader instead of setBlockIndexCandidates for NotifyHeaderTip() (master...2016/10/fix_gui_overlay) https://github.com/bitcoin/bitcoin/pull/8985
< GitHub78> bitcoin/master 3154d6e Jonas Schnelli: [Qt] use NotifyHeaderTip's height and date for the progress update
< GitHub78> bitcoin/master 7b1bfa3 Jonas Schnelli: Merge #8985: Use pindexBestHeader instead of setBlockIndexCandidates for NotifyHeaderTip()...
< GitHub78> bitcoin/master 0a261b6 Jonas Schnelli: Use pindexBestHeader instead of setBlockIndexCandidates for NotifyHeaderTip()
< GitHub78> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e228557f239...7b1bfa3a8786
< Victorsueca> username is bitcoin and password is mdtj4g5w5bppajnpmt2ow2dx
< jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/8989/files, in case you want to review it again
< jonasschnelli> In general, the CoinControl objects gets "nulled()" when the user disable the CC features in the settings: https://github.com/bitcoin/bitcoin/pull/8989/files#diff-76b18bd21ccf64e256f029a8198ecdd7L702
< wumpus> it is not related to current bitcoin core development
< wumpus> please move this to #bitcoin
< luke-jr> BIP 16 was merged with exactly zero ACKs: https://github.com/bitcoin/bitcoin/pull/748
< GitHub196> [bitcoin] laanwj opened pull request #8990: moveonly: move `coincontrol` to `src/wallet` (master...2016_10_coincontrol_wallet) https://github.com/bitcoin/bitcoin/pull/8990
< GitHub24> [bitcoin] jonasschnelli opened pull request #8989: [Qt] overhaul smart-fee slider, adjust default confirmation target (master...2016/10/qt_slider) https://github.com/bitcoin/bitcoin/pull/8989
< jonasschnelli> Would it be problematic to throw CoinControl into the wallet logic in cases where CoinControl is disabled? https://github.com/bitcoin/bitcoin/blob/master/src/qt/sendcoinsdialog.cpp#L233

2016-10-20

< wumpus> either they were from the bitcoin foundation or Gavin paid that out of his own pocket, I don't know
< kanzure> r/bitcoin is unrelated
< Victorsueca> I mean the thing that was collected on r/bitcoin
< wumpus> Victorsueca: I can tell you the bitcoin core project has 0 bitcoins
< wumpus> CodeShark: re: splitting up main see https://github.com/bitcoin/bitcoin/pull/8969
< jtimon> sorry for showing code, but this is what I would do first "for cheap": https://github.com/bitcoin/bitcoin/pull/8328
< kanzure> there was an argument proposed where instead of only making libconsensus, someone (sipa?) said libconsensus + also some other library, and bitcoin core and also libconsensus consume from the other library.
< jtimon> I believe some code duplication is unavoidable once bitcoin core only talks to libconsensus' C API, for example, the primitives
< instagibbs_> bitcoin businesses will do settlement on sunday evening to avoid fees
< jonasschnelli> Most important is probably review of mrbandrews's bumpfee (https://github.com/bitcoin/bitcoin/pull/8456)
< wumpus> I asked around and from 50 or so 'no' responses, there were two actual users admitting they were still using bitcoin core on windows 32-bit
< wumpus> I think this is typical bitcoin scope creep
< jtimon> kanzure: I highly doubt libbitcoin will ever use a libconsensus that's coupled to bitcoin's storage and concurrency, for example
< jtimon> conclusion, nobody seems to want the libconsensus I've been trying to move towards to, and as an external caller I wouldn't want a libconsensus++ (coupled to bitcoin core's storage and concurrency)
< jtimon> BlueMatt: an interface for CBlockIndex wouldn't requiore a ton of review, just some review. Remember you can use wrappers for the old stuff and only libconsensus needs to use the interface (uppper layers can remain using CBlockIndex directly), please see https://github.com/bitcoin/bitcoin/pull/8493
< wumpus> cfields_: right, so it's possible to fork bitcoin core but still use the same libconsensus, for example
< gmaxwell> sorry, went to sleep during API discussions. I agree that the library should be used by bitcoin core if it is to exist. :)
< jtimon> these are the consensus flags I end with in that branch: https://github.com/jtimon/bitcoin/blob/0.13-consensus-flags/src/consensus/flags.h
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< wumpus> btw: I've had, out of many 'no' responses, only two people admitting they're still running bitcoin core on windows 32-bit. Both expect to stop doing so in the next 6 months.
< jonasschnelli> <*highlight>[20:37:05] <sipa:#bitcoin-core-dev> jonasschnelli: ah, clocking on the warning icon. that took me a while - isn't there a way to make it more obvious, like adding another top bar with "You're currently out of sync with the network. Click here for more information' ?
< gmaxwell> sipa: yea, I don't mean that in a dogmatic sense. And I think in bitcoin core things are usually sensible. But I've had too much exposure to codebases where novices overuse these really exotic tools.
< sipa> cfields_: oh, so we only need to wait until 2022 until we can use it in Bitcoin Core?
< wumpus> we *don't * want to support half of bost as part of bitcoin core
< Victorsueca> achow101: thanks, will put that on a bitcoin block so everybody knows ;)
< GitHub21> [bitcoin] laanwj closed pull request #8980: RPC: importmulti: Avoid using boost::variant::operator!=, which is only in newer boost versions (master...compat_importmulti_oldboost) https://github.com/bitcoin/bitcoin/pull/8980
< GitHub0> bitcoin/master 0e22855 Wladimir J. van der Laan: Merge #8980: RPC: importmulti: Avoid using boost::variant::operator!=, which is only in newer boost versions...
< GitHub0> bitcoin/master 7942d31 Luke Dashjr: RPC: importmulti: Avoid using boost::variant::operator!=, which is only in newer boost versions
< GitHub0> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f2d705629b51...0e228557f239
< wumpus> it's a valid way to do things, but that means targetting open source to windows is hard, ideally we should sell bitcoin core on windows instead of offer a free download :-)
< wumpus> there's nothing bitcoin specific about not being able to execute the right executable
< GitHub157> [bitcoin] jonasschnelli opened pull request #8985: Use pindexBestHeader instead of setBlockIndexCandidates for NotifyHeaderTip() (master...2016/10/fix_gui_overlay) https://github.com/bitcoin/bitcoin/pull/8985
< jonasschnelli> sipa: Okay. Let me try a PR. I'd like to fix https://github.com/bitcoin/bitcoin/issues/8984 with it as well
< jonasschnelli> When notifying about the header tip, can we not just use pIndexBestHeader instead of retrieving from setBlockIndexCandidates? https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3010
< sipa> NicolasDorier: there are good uses for a very powerful script interoreter that does more than consensus too... for example a debugger or execution inspector, or something that supports signing some general class of signatures, maybe not specific to bitcoin transactions, ...
< NicolasDorier> for info, the checks in https://github.com/bitcoin/bitcoin/pull/8976 are meant for 0.13.1 ? just to know if I update NBitcoin to deal with it now or later :D
< wumpus> in any case I'm still not sure how to handle the tests in https://github.com/bitcoin/bitcoin/pull/8976 - should I skip tests that use flag combinations that are not in the API?
< GitHub167> [bitcoin] rebroad opened pull request #8983: Show block height and size when received (master...ShowBlockHeightAndSizeWhenReceived) https://github.com/bitcoin/bitcoin/pull/8983
< GitHub133> bitcoin/0.13 c9a5bad Wladimir J. van der Laan: doc: Update blurb in release notes...
< GitHub133> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/c9a5baddeef3d8721a7c71acf070f92a3d8d43a3
< Victorsueca> what about this: do the docs on a separate repo, when it's release time then clone to bitcoin
< wumpus> otherwise they can't be included with the release, they can't be uploaded to bitcoin.org and other places, etc
< wumpus> sipa: could be, though the release notes are pretty much on the same release cycle as bitcoin core so it'd not make much of a difference
< GitHub48> [bitcoin] s-matthew-english opened pull request #8982: Eliminating Inconsistencies in Textual Output (master...patch-6) https://github.com/bitcoin/bitcoin/pull/8982
< GitHub87> [bitcoin] paveljanik opened pull request #8981: Wshadow: Do not shadow argument with a local variable (master...20161020_Wshadow_rpcdump) https://github.com/bitcoin/bitcoin/pull/8981
< GitHub49> bitcoin/0.13 5f6b312 Wladimir J. van der Laan: doc: Add missing credit to release notes...
< GitHub49> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/5f6b312e51dadaf40ea68c0f85bbb4e51fa987f1
< GitHub145> [bitcoin] luke-jr opened pull request #8980: RPC: importmulti: Avoid using boost::variant::operator!=, which is only in newer boost versions (master...compat_importmulti_oldboost) https://github.com/bitcoin/bitcoin/pull/8980
< michagogo> No Bitcoin private keys in there, but gpg, probably ssh, and also token for github, chrome, etc.
< jonasschnelli> michagogo: you could turn your working system into an appliance (including your bitcoin private keys)
< jonasschnelli> Anyone interested to test the mempool statistics collector? This would be a basic step for GUI mempool stats: https://github.com/bitcoin/bitcoin/pull/8501
< GitHub86> [bitcoin] jonasschnelli reopened pull request #8723: [Wallet] Add support for flexible BIP32/HD keypath-scheme (master...2016/09/hd_flex) https://github.com/bitcoin/bitcoin/pull/8723
< GitHub145> [bitcoin] jonasschnelli closed pull request #8723: [Wallet] Add support for flexible BIP32/HD keypath-scheme (master...2016/09/hd_flex) https://github.com/bitcoin/bitcoin/pull/8723
< GitHub117> [bitcoin] jonasschnelli opened pull request #8977: [Wallet] Refactor wallet/init interaction (Reaccept wtx, flush thread) (master...2016/10/fix_wallet_init) https://github.com/bitcoin/bitcoin/pull/8977
< GitHub161> [bitcoin] laanwj closed pull request #7551: Add importmulti RPC call (master...feature/rpc-import-multi) https://github.com/bitcoin/bitcoin/pull/7551
< GitHub91> bitcoin/master f2d7056 Wladimir J. van der Laan: Merge #7551: Add importmulti RPC call...
< GitHub91> bitcoin/master 215caba Pedro Branco: Add consistency check to RPC call importmulti
< GitHub91> bitcoin/master cb08fdb Pedro Branco: Add importmulti rpc call
< GitHub91> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5875773561c...f2d705629b51
< GitHub0> [bitcoin] laanwj opened pull request #8976: libconsensus: Add input validation of flags (master...2016_10_bitcoinconsensus_input_checking) https://github.com/bitcoin/bitcoin/pull/8976
< wumpus> NicolasDorier: it's adding the flags in the tes https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L163
< NicolasDorier> yep, can reproduce crash if P2SH|CLEANSTACK not with P2SH|WITNESS|CLEANSTACK... why did the bitcoin C++ test worked fine ?
< NicolasDorier> downloaded libconsensus from https://bitcoin.org/bin/bitcoin-core-0.13.1/test.rc2/

2016-10-19

< BlueMatt> so there was a reasonably large performance regression in block acceptance time jeremyrubin found a while back...what are folks opinions on https://github.com/TheBlueMatt/bitcoin/commits/2016-10-fix-tx-regression ?
< sipa> wumpus: maybe you know: http://bitcoin.stackexchange.com/q/49077/208
< GitHub127> [bitcoin] jtimon opened pull request #8975: Chainparams: Trivial: In AppInit2(), s/Params()/chainparams/ (master...0.13-chainparams-init) https://github.com/bitcoin/bitcoin/pull/8975
< GitHub121> [bitcoin] laanwj closed pull request #8928: Fix init segfault where InitLoadWallet() calls ATMP before genesis (master...2016-10-fix-segfault) https://github.com/bitcoin/bitcoin/pull/8928
< GitHub183> bitcoin/master c587577 Wladimir J. van der Laan: Merge #8928: Fix init segfault where InitLoadWallet() calls ATMP before genesis...
< GitHub183> bitcoin/master 37aefff Matt Corallo: Fix init segfault where InitLoadWallet() calls ATMP before genesis
< GitHub183> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/475d68252e9c...c5875773561c
< GitHub87> [bitcoin] laanwj closed pull request #8927: Add script tests for FindAndDelete in pre-segwit and segwit scripts (master...findanddeletetest) https://github.com/bitcoin/bitcoin/pull/8927
< GitHub16> bitcoin/master 475d682 Wladimir J. van der Laan: Merge #8927: Add script tests for FindAndDelete in pre-segwit and segwit scripts...
< GitHub16> bitcoin/master acf853d Johnson Lau: Add script tests for FindAndDelete in pre-segwit and segwit scripts
< GitHub16> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3e942a7060fe...475d68252e9c
< GitHub135> [bitcoin] jonasschnelli closed pull request #8775: RPC refactoring: Never access wallet directly, only via new CRPCRequestInfo (master...multiwallet_prefactor_rpc) https://github.com/bitcoin/bitcoin/pull/8775
< GitHub155> [bitcoin] jonasschnelli closed pull request #8774: Qt refactors to better abstract wallet access (master...multiwallet_prefactor_qt) https://github.com/bitcoin/bitcoin/pull/8774
< GitHub48> bitcoin/master 3e942a7 Jonas Schnelli: Merge #8774: Qt refactors to better abstract wallet access...
< GitHub48> bitcoin/master 178cd88 Luke Dashjr: Qt/splash: Specifically keep track of which wallet(s) we are connected to for later disconnecting
< GitHub48> bitcoin/master 1880aeb Luke Dashjr: Qt: Get the private key for signing messages via WalletModel
< GitHub48> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d2c8e524e10...3e942a7060fe
< GitHub37> [bitcoin] MarcoFalke closed pull request #8974: readability improvement (master...patch-5) https://github.com/bitcoin/bitcoin/pull/8974
< GitHub154> [bitcoin] laanwj closed pull request #7948: RPC: augment getblockchaininfo bip9_softforks data (master...version_bits_locked_in_block) https://github.com/bitcoin/bitcoin/pull/7948
< GitHub129> bitcoin/master 5d2c8e5 Wladimir J. van der Laan: Merge #7948: RPC: augment getblockchaininfo bip9_softforks data...
< GitHub129> bitcoin/master fc14609 mruddy: RPC: augment getblockchaininfo bip9_softforks data
< GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/97c7f7362f9b...5d2c8e524e10
< GitHub143> [bitcoin] s-matthew-english opened pull request #8974: readability improvement (master...patch-5) https://github.com/bitcoin/bitcoin/pull/8974
< GitHub131> [bitcoin] laanwj closed pull request #8788: [RPC] Give RPC commands more information about the RPC request (master...2016/09/rpc_container) https://github.com/bitcoin/bitcoin/pull/8788
< GitHub21> bitcoin/master e7156ad Jonas Schnelli: [RPC] pass HTTP basic authentication username to the JSONRequest object
< GitHub21> bitcoin/master 69d1c25 Jonas Schnelli: [RPC] Give RPC commands more information about the RPC request
< GitHub21> bitcoin/master 23c32a9 Wladimir J. van der Laan: rpc: Change JSONRPCRequest to JSONRPCRequestObj...
< GitHub21> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d736a6eb1f91...97c7f7362f9b
< jonasschnelli> wumpus: The RPC command-structure refactoring (https://github.com/bitcoin/bitcoin/pull/8788) includes your JSONRPCRequestObj renaming now. Would be nice to get this in soon to escape the rebase-hamster-wheel
< jonasschnelli> wumpus: what crash? The wallet/init one? https://github.com/bitcoin/bitcoin/pull/8928