< bitcoin-git>
[bitcoin] vim88 opened pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< BlueMatt>
I have another bitcoin-dev post coming discussing package relay, but we have a few options there, if we just want to solve package relay for contracting applications like lightning, we can do so with limited consideration, I think
< BlueMatt>
but, at least IMO, its super annoying that you cant build+run bitcoin-qt on the now-several-months-old versions of various OSs, and I presume other rolling distros (eg arch) also have this issue
< gmaxwell>
I guess I can argue the consequences either way, I can imagine someone losing a wallet file with lots of bitcoin in it because it showed a low balance due to some easily abandoned transactions.
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< BlueMatt>
but 0.17.0 currently cannot be self-built and bitcoin-qt opened on latest fedora/ubuntu release
< gribble>
https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14834: validation: do not break assumption that pindexPrev may be null (master...20181129-contextualcheckblock-pindexprev-nullness) https://github.com/bitcoin/bitcoin/pull/14834
< gribble>
https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/0.17 bb90695 gustavonalle: [wallet] Ensure wallet is unlocked before signing...
< bitcoin-git>
bitcoin/0.17 85aacc4 Walter: Add autogen.sh in ARM Cross-compilation...
< bitcoin-git>
bitcoin/0.17 9406502 Kaz Wesley: add a test demonstrating an overflow in a deserialization edge case...
< bitcoin-git>
[bitcoin] ch4ot1c opened pull request #14832: docs: Add more Doxygen information to Developer Notes (master...improvement/doxygen-docs) https://github.com/bitcoin/bitcoin/pull/14832
< bitcoin-git>
[bitcoin] vim88 opened pull request #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. (master...proper_shebang) https://github.com/bitcoin/bitcoin/pull/14831
< gribble>
https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< dongcarl>
gmaxwell: Huh... I was actually thinking that errors need error codes in Bitcoin... But perhaps that's a bad idea...
< Guest80>
Anybody here experienced with bitcoin core build?
< sipa>
for example, bitcoin core will use a very different codepath for an ecdsa signature that is too long vs one that is just invalid
< gmaxwell>
like, yes maybe bitcoin core has a branch that checks the size and terminates... but without that branch it would still reject those cases because the hash function (a size triggered OR of two functions) will never match for inputs of other sizes.
< aj>
$ time (blk=$(bitcoin-cli getblockhash 551601); echo $blk; bitcoin-cli invalidateblock $blk; bitcoin-cli gettxoutsetinfo | grep hash_serial; bitcoin-cli reconsiderblock $blk) # --> 666550387c3f5fa8e9353ce561fcee2a164022d31b97affd7c982388f19a4904as the hash, took about 1m12 all up
< NicolasDorier>
aj: At least for the reviewers. People running those "bitcoin core in a box" are already blindly trusting binaries anyway.
< NicolasDorier>
I think this is even better UX than embedding known utxo hash set anywhere into bitcoin core.
< gmaxwell>
NicolasDorier: if the "bitcoin core in a box" then the entire software could do arbritary things, the hash it gives is meaningless.
< NicolasDorier>
Yes I can understand. I am just worried that right now what we will see with those "Bitcoin Core in a box" is blind reliance on a pre-shipped UTXO Set
< NicolasDorier>
So the user could fast sync from untrusted source, and would get a warning if that differ from Bitcoin Core website/twitter or whatever publish mechanism
< NicolasDorier>
so instead I was thinking the following: What about Bitcoin Core share the txoutset hash on bitcoincore website or twitter or whatever (like every 1000 blocks). At BTCPay level, I would show the UTXOSet of their own node and check against the website
< bitcoin-git>
bitcoin/master c77f092 Russell Yanofsky: Fix descriptor_tests not checking ToString output of public descriptors
< bitcoin-git>
bitcoin/master 0fa3703 MarcoFalke: Merge #14820: test: Fix descriptor_tests not checking ToString output of public descriptors...
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #14820: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
< gmaxwell>
provoostenator: 09:57:52 < jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason
< gribble>
https://github.com/bitcoin/bitcoin/issues/10595 | Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients by luke-jr · Pull Request #10595 · bitcoin/bitcoin · GitHub
< jnewbery>
I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason don't want to include a certain class of transaction in their blocks.
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
< jnewbery>
I think promag means 'what if the miner wants to take Bitcoin Core 0.18 but doesn't want to upgrade his pool software to support mining segwit blocks?'
< sipa>
promag: currently, if the gbt client does not provide segwit flag, bitcoin core will produce a (suboptimal) block template without segwit txn
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] hebasto opened pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< bitcoin-git>
[bitcoin] jamesob opened pull request #14812: qa: fix p2p_invalid_messages on macOS (master...2018-11-test-macos-mem-fix) https://github.com/bitcoin/bitcoin/pull/14812
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14811: Mining: Enforce that segwit option must be set in GBT (master...remove_non_segwit_mining) https://github.com/bitcoin/bitcoin/pull/14811
< bitcoin-git>
[bitcoin] stevenroose opened pull request #14805: tests: Support calling add_nodes more than once (master...test-framework) https://github.com/bitcoin/bitcoin/pull/14805
< bitcoin-git>
[bitcoin] fanquake closed pull request #14072: [primitives, consensus] Make fChecked an atomic<bool> (master...fchecked-atomic) https://github.com/bitcoin/bitcoin/pull/14072
< bitcoin-git>
[bitcoin] hebasto opened pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14400: Add Benchmark to test input de-duplication worst case (master...benchmark-reject-duplicate-inputs) https://github.com/bitcoin/bitcoin/pull/14400
< bitcoin-git>
[bitcoin] hebasto opened pull request #14798: qt: Fix Peers tab switch away in RPC console (master...20181124-fix-peers-tab-switch) https://github.com/bitcoin/bitcoin/pull/14798
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
2018-11-23
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< lopp>
are you suggesting that people have a life outside of bitcoin??? :-P
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits error: gpg failed to sign the data fatal: failed to write commit object Merge commit HEAD is not clean
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits
< bitcoin-git>
bitcoin/master af9a991 Cornelius Schumacher: Fix detection of copyright holders...
< bitcoin-git>
[bitcoin] marcoagner opened pull request #14795: test: allows test_runner command line to receive parameters for each test (master...fix_test_runner_parameters) https://github.com/bitcoin/bitcoin/pull/14795
< bitcoin-git>
bitcoin/master b81a186 Gregory Sanders: GetPubKey: make sigdata const
< bitcoin-git>
bitcoin/master 0595164 Wladimir J. van der Laan: Merge #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git>
[bitcoin] laanwj closed pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< bitcoin-git>
bitcoin/master 8284756 John Newbery: A few minor formatting fixes and clarifications to descriptors.md
< bitcoin-git>
bitcoin/master d7fbe7d Wladimir J. van der Laan: Merge #14778: A few minor formatting fixes and clarifications to descriptors.md...
2018-11-22
< bitcoin-git>
[bitcoin] kristapsk opened pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
< bitcoin-git>
[bitcoin] merland opened pull request #14787: Replace old instructions with links to official docs (master...issue14639) https://github.com/bitcoin/bitcoin/pull/14787
< promag>
maybe we should just call `noui_connect()` in bitcoin-qt?
< bitcoin-git>
[bitcoin] promag opened pull request #14783: qt: Fix boost::signals2::no_slots_error in early calls to InitWarning (master...2018-11-fix-noslotserror) https://github.com/bitcoin/bitcoin/pull/14783
< bitcoin-git>
[bitcoin] laanwj closed pull request #14756: Improve rpcauth.py by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< bitcoin-git>
[bitcoin] laanwj closed pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git>
bitcoin/master 7bad78c Ben Woosley: Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h...
< bitcoin-git>
bitcoin/master 69ca487 Ben Woosley: Implement prevector::fill once...
< bitcoin-git>
bitcoin/master e736b67 Wladimir J. van der Laan: Merge #14715: Drop defunct prevector compat handling...
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr closed pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
< gmaxwell>
"I have made progress and while the current implementation is 20% slower than it could be it is still five times faster than before and think I will settle for that. Details are in my bitcoin-armv8 repo. It is reindexing my copy of the bitcoin blockchain at over double the pace."
2018-11-21
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< gribble>
https://github.com/bitcoin/bitcoin/issues/8751 | RPC: Add parameter to addmultisigaddress / createmultisig to sort public keys by afk11 · Pull Request #8751 · bitcoin/bitcoin · GitHub
< dgpv>
sipa: actually my initial question was should I submit a PR with change for sortedmulti() or just create an issue on bitcoin core github
< sipa>
all i'm saying is that i don't think it makes sense to commit to "bitcoin core aims to be interoperable with software X"
< gmaxwell>
dgpv: Seriously, the bitcoin project has been held back for years by misguided efforts towards interoperability with a largely indifferent industry. It's a bit irritating that you're advocating us burning more time here on this particular point of it, because it would be useful in your product.
< bitcoin-git>
[bitcoin] laanwj closed pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
< sipa>
dgpv: so far, the bitcoin core wallet also hasn't really supported HD chains created by other software as import