2017-07-14

< bitcoin-git> [bitcoin] ReneNyffenegger closed pull request #10768: Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp (master...init-nStart) https://github.com/bitcoin/bitcoin/pull/10768

2017-07-13

< bitcoin-git> [bitcoin] sipa opened pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820
< bitcoin-git> [bitcoin] promag opened pull request #10819: Fix uninitialized atomic variables (master...2017-07-fix-unitialized-atomic) https://github.com/bitcoin/bitcoin/pull/10819
< gribble> https://github.com/bitcoin/bitcoin/issues/10714 | Avoid printing incorrect block indexing time due to uninitialized variable by practicalswift · Pull Request #10714 · bitcoin/bitcoin · GitHub
< jtimon> can someone close https://github.com/bitcoin/bitcoin/pull/10768 ? the author said it but for some reason didn't closed it himself
< rhavar> If you can see why that model doesn't pick the obvious solution (the one you can force it to), I'd be happy to give you a $100 in bitcoin or something :P
< rhavar> I got like 10-15 emails yesterday from people freaking out after the bitcoin.org notice lolz ><
< wumpus> seems time to end the meeting, speculation about the reason for the stop of utxo growth is interesting but not a bitcoin core meeting topic
< luke-jr> jonasschnelli: bitcoin-cli will get these options too.
< luke-jr> jonasschnelli: typical multiwallet use case has wallet=abc.db \n wallet=def.db in bitcoin.conf
< jtimon> bitcoin-cli calls with -wallet that don't need it could just ignore the extra argument and spit a warning somehwere or something?
< luke-jr> jonasschnelli: how do yuo remove it, if it's in bitcoin.conf?
< luke-jr> hmm, bitcoin-cli reads bitcoin.conf, doesn't it? how does that interact? :/
< jonasschnelli> One thing that is a bit cumbersome is that you have to remove the -wallet argument from bitcoin-cli when calling a non wallet command
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier · Pull Request #9728 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9566 | threading: use std::chrono for timestamps by theuni · Pull Request #9566 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< wumpus> PSA: https://github.com/bitcoin/bitcoin/issues/9961, feature freeze is sunday (which is an awful day, it'll probably be monday in practice)
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< bitcoin-git> [bitcoin] laanwj opened pull request #10818: init: Keep track of whether data directory locked, don't cleanup if not (master...2017_05_locked_datadir) https://github.com/bitcoin/bitcoin/pull/10818
< bitcoin-git> [bitcoin] morcos opened pull request #10817: Add a discard_rate to avoid small change (master...discardmore) https://github.com/bitcoin/bitcoin/pull/10817
< morcos> while i have you, can i have your opinion on another RPC agument name change issue, this time all messed up solely by me: https://github.com/bitcoin/bitcoin/pull/10707#issuecomment-314869251
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. (master...multiwallet_parameters) https://github.com/bitcoin/bitcoin/pull/10816
< gribble> https://github.com/bitcoin/bitcoin/issues/10418 | Need fee estimation migration for 0.15 · Issue #10418 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10815 | bitcoin-qt core dumps when bitcoin(d/-qt) is already running · Issue #10815 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< jnewbery> ryanofsky: right. That's what's in the test I provided https://github.com/jnewbery/bitcoin/commit/53be2f334979f2cd979554fe81c4837ad02328cd
< jnewbery> suggest you tcpdump and compare the requests from bitcoin-cli and authproxy
< jonasschnelli> But bitcoin-cli works.. so the endpoint must be registered
< jonasschnelli> jnewbery: Ah.. is was looking for that one: https://github.com/jnewbery/bitcoin/commit/4597818e43900dc07271773f544f47d1da6d635c
< gribble> https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #10814: Change type of op to agree with type of MAX_OPCODE. (master...MAX_OPCODE) https://github.com/bitcoin/bitcoin/pull/10814
< ryanofsky> jonasschnelli, does suggested code in https://github.com/bitcoin/bitcoin/pull/10650#discussion_r123484826 not work?
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10814: Change type of op to agree with type of MAX_OPCODE. (master...MAX_OPCODE) https://github.com/bitcoin/bitcoin/pull/10814
< gribble> https://github.com/bitcoin/bitcoin/issues/10731 | Escape rather than remove any printable characters in UAs by luke-jr · Pull Request #10731 · bitcoin/bitcoin · GitHub
< gmaxwell> UA: OFFICIAL BITCOIN NOTICE. BITCOIN HAS BEEN REPLACED BY ULTRACOIN BUY REPLACEMENT COINS AT BITCOIN.COM NOW
< jonasschnelli> The original idea was also to place a donation bitcoin address there... :/
< bitcoin-git> [bitcoin] jonasschnelli reopened pull request #10731: SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731
< gribble> https://github.com/bitcoin/bitcoin/issues/10731 | SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" by luke-jr · Pull Request #10731 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10731: SanitizeString: Expand upon allowed characters in logging to include "!#%&*+=^{}~" (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10810: missing white space in function arg (master...missing_white_space) https://github.com/bitcoin/bitcoin/pull/10810
< bitcoin-git> bitcoin/master 7666250 Jonas Schnelli: Merge #10810: missing white space in function arg...
< bitcoin-git> bitcoin/master 69a4339 Lawrence Nahum: missing white space in function arg
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4fcbf797ed3...7666250ffb4e
< bitcoin-git> [bitcoin] sipa closed pull request #10780: Simplify "!foo || (foo && bar)" as "!foo || bar" (master...redundant-condition) https://github.com/bitcoin/bitcoin/pull/10780
< bitcoin-git> bitcoin/master e4fcbf7 Pieter Wuille: Merge #10780: Simplify "!foo || (foo && bar)" as "!foo || bar"...
< bitcoin-git> bitcoin/master 1e3a320 practicalswift: Simplify "!foo || (foo && bar)" as "!foo || bar"
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/479afa0f8486...e4fcbf797ed3

2017-07-12

< bitcoin-git> [bitcoin] sipa closed pull request #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. (master...fix-subscript-0) https://github.com/bitcoin/bitcoin/pull/9804
< bitcoin-git> bitcoin/master 96f2119 Jeremy Rubin: Fix subscript[0] in compressor.cpp
< bitcoin-git> bitcoin/master 500710b Jeremy Rubin: Fix 2 subscript[0] bugs in pubkey.cpp, and eliminate one extra size check
< bitcoin-git> bitcoin/master e0451e3 Jeremy Rubin: Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector
< bitcoin-git> [bitcoin] sipa pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a09a3891fde...479afa0f8486
< gribble> https://github.com/bitcoin/bitcoin/issues/10557 | Make check to distinguish between orphan txs and old txs more efficient. by morcos · Pull Request #10557 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10714: Avoid printing incorrect block indexing time due to uninitialized variable (master...avoid-uninitialized-nStart) https://github.com/bitcoin/bitcoin/pull/10714
< bitcoin-git> bitcoin/master 2a09a38 Pieter Wuille: Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable...
< bitcoin-git> bitcoin/master 959dd87 practicalswift: Avoid printing incorrect block indexing time due to uninitialized variable...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8b95239eeb0...2a09a3891fde
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< BlueMatt> <gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets (master...bitcoin_cli_ipv6) https://github.com/bitcoin/bitcoin/pull/10812
< bitcoin-git> [bitcoin] greenaddress opened pull request #10810: missing white space in function arg (master...missing_white_space) https://github.com/bitcoin/bitcoin/pull/10810
< sipa> we should include that change up into the bitcoin core subtree for 0.15
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< sipa> cfields: ack, fix it in bitcoin-core/leveldb
< bitcoin-git> [bitcoin] petertodd closed pull request #8543: Use ANYONECANPAY if -spendzeroconfchange=0 (master...2016-08-anyonecanpay-if-spendzeroconfchange-disabled) https://github.com/bitcoin/bitcoin/pull/8543
< bitcoin-git> [bitcoin] theuni opened pull request #10809: optim: mark a few classes final (master...final-classes) https://github.com/bitcoin/bitcoin/pull/10809
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10808: Avoid some new gcc warnings in 15 (master...2017-07-15-new-warnings) https://github.com/bitcoin/bitcoin/pull/10808
< bitcoin-git> [bitcoin] instagibbs opened pull request #10807: getbalance example covers at least 6 confirms (master...getbalexample) https://github.com/bitcoin/bitcoin/pull/10807
< jnewbery> arubi: yeah bitcoin-cli over ipv6 seems pretty niche. Can't imagine many people use it
< jnewbery> Does that mean you were able to use bitcoin-cli with ipv6?
< jnewbery> I've added a `-usecli` option to the functional tests which makes all RPCs go through bitcoin-cli. This is the last test that I can't get to run with that option
< jnewbery> I think so. Background is I'm trying to run rpcbind.py. It works when I use direct RPC, but not if I feed all RPC through bitcoin-cli
< gribble> https://github.com/bitcoin/bitcoin/issues/1827 | HTTP client needs IPv6 support · Issue #1827 · bitcoin/bitcoin · GitHub
< jnewbery> Does anyone know if bitcoin-cli is supposed to work with ipv6? I can't seem to make it connect when specifying an ipv6 address in -rpcconnect
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #10806: build: verify that the assembler can handle crc32 functions (master...configure-check-asm) https://github.com/bitcoin/bitcoin/pull/10806
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< jnewbery> wumpus: sorry for the back and forth - i think we can remove #10711 from https://github.com/bitcoin/bitcoin/projects/8 . I still want it to go in, but it's not essential for 0.15 (in fact it could probably go in after feature freeze since it doesn't touch product code)
< gribble> https://github.com/bitcoin/bitcoin/issues/10800 | build: add lto configure option by theuni · Pull Request #10800 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] janstary opened pull request #10805: have proper manpages for bitcoin*(1) (master...master) https://github.com/bitcoin/bitcoin/pull/10805
< bitcoin-git> [bitcoin] promag opened pull request #10804: Add histunspent RPC (master...2017-07-rpc-add-histunspent) https://github.com/bitcoin/bitcoin/pull/10804
< bitcoin-git> [bitcoin] pstratem opened pull request #10803: Explicitly search for bdb5.3. (master...2017-07-02-bdb5.3) https://github.com/bitcoin/bitcoin/pull/10803
< bitcoin-git> [bitcoin] jnewbery opened pull request #10802: [tests] skip zapwallettxes.py (master...skip_zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10802
< cdecker> We might want to think about ways to differentiate once a hard fork occurs, I'm not sure one implementation will want to differentiate itself out of fear of being called non-bitcoin
< jonasschnelli> That: The DNS seed results must consist exclusively of fairly selected and functioning Bitcoin nodes from the public network to the best of the operator's understanding and capability.
< bitcoin-git> [bitcoin] theuni opened pull request #10800: build: add lto configure option (master...enable-lto) https://github.com/bitcoin/bitcoin/pull/10800
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10799: Prevent user from specifying conflicting parameters to fundrawtx (master...2017-07-no-fundraw-conflicts) https://github.com/bitcoin/bitcoin/pull/10799

2017-07-11

< BlueMatt> -> #bitcoin
< bitcoin-git> [bitcoin] jnewbery opened pull request #10798: test bitcoin-cli (master...cli_tests) https://github.com/bitcoin/bitcoin/pull/10798
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getperblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< ryanofsky> am i missing something? https://github.com/bitcoin/bitcoin/pull/9483#discussion_r100077677 seems pretty straightforward and not a large amount of refactoring
< gribble> https://github.com/bitcoin/bitcoin/issues/10794 | Add simple light-client mode (RPC only) by jonasschnelli · Pull Request #10794 · bitcoin/bitcoin · GitHub
< ryanofsky> here is the comment where i point out the duplication: https://github.com/bitcoin/bitcoin/pull/9483#discussion_r100077677
< jonasschnelli> ryanofsky about the CAuxiliaryRequest, where do you think we have duplicated code? Also, what do you think about the points I wrote (https://github.com/bitcoin/bitcoin/pull/10794#issuecomment-314534086)?
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | [qt] Add abstraction layer for accessing node and wallet functionality from gui by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #8369: [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369
< BlueMatt> ok, no big deal, lets move to #bitcoin
< cluelessperson> is currently on my plate, but I was wondering if you might suggest something else that might be more beneficial towards bitcoin development, testing/QA?
< gmaxwell> BlueMatt: I do not believe that LTO fails to work on anything that can compile Bitcoin Core. It's been supported since GCC 4.7
< BlueMatt> is O3 a win in bitcoin?
< gribble> https://github.com/bitcoin/bitcoin/issues/9804 | Fixes subscript 0 ([0]) where should use (var.data()) instead. by JeremyRubin · Pull Request #9804 · bitcoin/bitcoin · GitHub
< gmaxwell> here is something funny: compilng bitcoin with -march=native makes the sha2 in C most of the speed of the sse one. (compiler manages to use rorx)
< BlueMatt> lol, Make Bitcoin CryptoPP Again
< bitcoin-git> [bitcoin] laanwj closed pull request #10712: Add change output if necessary to reduce excess fee (master...addchangehwenoverpaying) https://github.com/bitcoin/bitcoin/pull/10712
< bitcoin-git> bitcoin/master e8b9523 Wladimir J. van der Laan: Merge #10712: Add change output if necessary to reduce excess fee...
< bitcoin-git> bitcoin/master 0f402b9 Alex Morcos: Fix rare edge case of paying too many fees when transaction has no change....
< bitcoin-git> bitcoin/master 253cd7e Alex Morcos: Only reserve key for scriptChange once in CreateTransaction...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca4c545cc7e8...e8b95239eeb0
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10795: No longer ever reuse keypool indexes (master...2017-07-wallet-keypool-overwrite) https://github.com/bitcoin/bitcoin/pull/10795
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9171: Introduce auxiliary block requests (master...2016/11/spv_step_1) https://github.com/bitcoin/bitcoin/pull/9171
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10794: Add simple light-client mode (RPC only) (master...2017/07/spv) https://github.com/bitcoin/bitcoin/pull/10794
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10786: Add PR description to merge commit in github-merge.py (master...20170710_prbody) https://github.com/bitcoin/bitcoin/pull/10786
< bitcoin-git> bitcoin/master ca4c545 Wladimir J. van der Laan: Merge #10786: Add PR description to merge commit in github-merge.py...
< bitcoin-git> bitcoin/master 475c08c Pieter Wuille: Add PR description to merge commit in github-merge.py
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b27b004532db...ca4c545cc7e8
< bitcoin-git> [bitcoin] laanwj closed pull request #10543: Change API to estimaterawfee (master...estimaterawapi) https://github.com/bitcoin/bitcoin/pull/10543
< bitcoin-git> bitcoin/master 5e3b7b5 Alex Morcos: Improve error reporting for estimaterawfee
< bitcoin-git> bitcoin/master 1fafd70 Alex Morcos: Add function to report highest estimate target tracked per horizon
< bitcoin-git> bitcoin/master 9c85b91 Alex Morcos: Change API to estimaterawfee...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cef4b5ccaa37...b27b004532db
< bitcoin-git> [bitcoin] laanwj closed pull request #10651: Verify binaries from bitcoincore.org and bitcoin.org (master...2017-06-verify-coreorg) https://github.com/bitcoin/bitcoin/pull/10651
< bitcoin-git> bitcoin/master cef4b5c Wladimir J. van der Laan: Merge #10651: Verify binaries from bitcoincore.org and bitcoin.org...
< bitcoin-git> bitcoin/master 6270d62 Matt Corallo: Verify binaries from bitcoincore.org and bitcoin.org
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/badd81bd3185...cef4b5ccaa37
< bitcoin-git> [bitcoin] laanwj closed pull request #10792: Replace MAX_OPCODE for OP_NOP10. (master...max-opcode-over-nop10) https://github.com/bitcoin/bitcoin/pull/10792
< bitcoin-git> bitcoin/master badd81b Wladimir J. van der Laan: Merge #10792: Replace MAX_OPCODE for OP_NOP10....
< bitcoin-git> bitcoin/master c8e29d7 Mark Friedenbach: Replace MAX_OPCODE for OP_NOP10....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4f226a133d0...badd81bd3185
< bitcoin-git> [bitcoin] laanwj closed pull request #10190: [tests] mining functional tests (including regression test for submitblock) (master...mining_functional_test) https://github.com/bitcoin/bitcoin/pull/10190
< bitcoin-git> bitcoin/master 38b38cd John Newbery: [tests] getblocktemplate_proposals.py: add logging
< bitcoin-git> bitcoin/master 0a3a5ff John Newbery: [tests] Fix flake8 warnings in getblocktemplate tests
< bitcoin-git> bitcoin/master 32cffe6 John Newbery: [tests] Fix import order in getblocktemplate test
< bitcoin-git> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/104f5f21dc24...e4f226a133d0
< gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
< jonasschnelli> Beg for review on: https://github.com/bitcoin/bitcoin/pull/9502
< bitcoin-git> [bitcoin] laanwj closed pull request #10589: More economical fee estimates for RBF and RPC options to control (master...rpcestimatechoice) https://github.com/bitcoin/bitcoin/pull/10589
< bitcoin-git> bitcoin/master e0738e3 Alex Morcos: remove default argument from estimateSmartFee
< bitcoin-git> bitcoin/master d507c30 Alex Morcos: Introduce a fee estimate mode....
< bitcoin-git> bitcoin/master cfaef69 Alex Morcos: remove default argument from GetMinimumFee
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/379aed0e53a6...104f5f21dc24
< bitcoin-git> [bitcoin] MeshCollider opened pull request #10793: Changing &var[0] to var.data() (master...prefer-vector-data) https://github.com/bitcoin/bitcoin/pull/10793
< bitcoin-git> [bitcoin] laanwj closed pull request #10676: document script-based return fields for validateaddress (master...validatata) https://github.com/bitcoin/bitcoin/pull/10676
< bitcoin-git> bitcoin/master 379aed0 Wladimir J. van der Laan: Merge #10676: document script-based return fields for validateaddress...
< bitcoin-git> bitcoin/master f2f1d0a Gregory Sanders: document script-based return fields for validateaddress
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/21ed30a314cf...379aed0e53a6
< bitcoin-git> [bitcoin] MeshCollider closed pull request #10790: Use vector::data() instead of &vch[0] in base58.cpp (master...prefer-vector-data) https://github.com/bitcoin/bitcoin/pull/10790
< bitcoin-git> [bitcoin] maaku opened pull request #10792: Replace MAX_OPCODE for OP_NOP10. (master...max-opcode-over-nop10) https://github.com/bitcoin/bitcoin/pull/10792
< bitcoin-git> [bitcoin] laanwj closed pull request #10179: Give CValidationInterface Support for calling notifications on the CScheduler Thread (master...2017-01-wallet-cache-inmempool-3) https://github.com/bitcoin/bitcoin/pull/10179
< bitcoin-git> bitcoin/master 3a19fed Matt Corallo: Make ValidationInterface signals-type-agnostic...
< bitcoin-git> bitcoin/master cda1429 Matt Corallo: Give CMainSignals a reference to the global scheduler...
< bitcoin-git> bitcoin/master ff6a834 Matt Corallo: Use TestingSetup to DRY qt rpcnestedtests
< bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/9edda0c5f5f2...21ed30a314cf
< gribble> https://github.com/bitcoin/bitcoin/issues/9774 | Enable host lookups for -proxy and -onion parameters by jmcorgan · Pull Request #9774 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider opened pull request #10790: Use vector::data() instead of &vch[0] in base58.cpp (master...prefer-vector-data) https://github.com/bitcoin/bitcoin/pull/10790
< bitcoin-git> [bitcoin] stevendlander opened pull request #10789: Punctuation/grammer fixes in rpcwallet.cpp (master...cli-punctuation-standardization) https://github.com/bitcoin/bitcoin/pull/10789
< bitcoin-git> [bitcoin] achow101 opened pull request #10788: Replace ismine with producesignature check in witnessifier (master...fix-addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/10788

2017-07-10

< bitcoin-git> [bitcoin] sipa opened pull request #10786: Add PR description to merge commit in github-merge.py (master...20170710_prbody) https://github.com/bitcoin/bitcoin/pull/10786
< bitcoin-git> [bitcoin] theuni closed pull request #10782: Use AC_ARG_VAR to set ARFLAGS (master...ARFLAGS-AC_ARG_VAR) https://github.com/bitcoin/bitcoin/pull/10782
< bitcoin-git> [bitcoin] sipa opened pull request #10785: Serialization improvements (master...20170707_noncastserial) https://github.com/bitcoin/bitcoin/pull/10785
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10784: Do not allow users to get keys from keypool without reserving them (master...2017-07-keep-change) https://github.com/bitcoin/bitcoin/pull/10784
< Murch> oh, @rhavar and anyone else running Coin Selection Simulations. You will probably not want to run with all strategies at the same time as especially the Bitcoin Core based selection takes quite a lot of computation time.
< bitcoin-git> [bitcoin] instagibbs opened pull request #10783: [RPC] Various rpc argument fixes (master...rpcargfixes) https://github.com/bitcoin/bitcoin/pull/10783
< bitcoin-git> [bitcoin] laanwj closed pull request #10747: [rpc] fix verbose argument for getblock in bitcoin-cli (master...fix_getblock_verbose_argument) https://github.com/bitcoin/bitcoin/pull/10747
< bitcoin-git> bitcoin/master 9edda0c Wladimir J. van der Laan: Merge #10747: [rpc] fix verbose argument for getblock in bitcoin-cli...
< bitcoin-git> bitcoin/master 58e9864 John Newbery: [rpc] fix verbose argument for getblock in bitcoin-cli
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d4805ce0464...9edda0c5f5f2
< gribble> https://github.com/bitcoin/bitcoin/issues/0652 | Update contrib/debian/ for 0.5.0 release and fix copyright file. by TheBlueMatt · Pull Request #652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10745: Be consistent in using "opt_into_rbf" parameter for Opt-In RBF (master...opt_in_rbf-param) https://github.com/bitcoin/bitcoin/pull/10745
< bitcoin-git> [bitcoin] laanwj reopened pull request #10753: test: Check RPC argument mapping (master...2017_07_rpc_argument_check) https://github.com/bitcoin/bitcoin/pull/10753
< gribble> https://github.com/bitcoin/bitcoin/issues/9447 | Allow 2 simultaneous block downloads by morcos · Pull Request #9447 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< jnewbery> Can I get #10711 added to https://github.com/bitcoin/bitcoin/projects/8 ? It's a test framework enhancement so not super urgent, but it moves quite a lot of code within test/functional/test_framework so I'd like to avoid too many rebases.
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10782: Use AC_ARG_VAR to set ARFLAGS (master...ARFLAGS-AC_ARG_VAR) https://github.com/bitcoin/bitcoin/pull/10782
< rodarmor> How will a current bitcoin core node interpret a block with a transaction whose version is greater than CURRENT_VERSION? I can see in the code that it's used for relay policy, and for BIP68 enforcement, is that it?
< gmaxwell> yea, bitcoin.com censored my transaction, indeed.
< bitcoin-git> [bitcoin] practicalswift closed pull request #10776: Avoid unnecessary copying of non-cheaply-copied types (master...const-ref) https://github.com/bitcoin/bitcoin/pull/10776

2017-07-09

< bitcoin-git> [bitcoin] practicalswift opened pull request #10781: Python cleanups (master...python-cleanups) https://github.com/bitcoin/bitcoin/pull/10781
< bitcoin-git> [bitcoin] practicalswift opened pull request #10780: Simplify `!foo || (foo && bar)` as `!foo || bar` (master...redundant-condition) https://github.com/bitcoin/bitcoin/pull/10780
< bitcoin-git> [bitcoin] flack opened pull request #10779: Create dependencies.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10779

2017-07-08

< bitcoin-git> [bitcoin] practicalswift opened pull request #10777: [tests] Avoid redundant assignments. Remove unused variables. (master...test-vars) https://github.com/bitcoin/bitcoin/pull/10777
< bitcoin-git> [bitcoin] practicalswift opened pull request #10776: Avoid unnecessary copying of non-cheaply-copied types. Use pass by reference to const consistently where appropriate. (master...const-ref) https://github.com/bitcoin/bitcoin/pull/10776
< bitcoin-git> [bitcoin] romanornr opened pull request #10775: nCheckDepth chain height fix (master...master) https://github.com/bitcoin/bitcoin/pull/10775
< bitcoin-git> [bitcoin] romanornr closed pull request #10774: nCheckDepth chain height fix (master...master) https://github.com/bitcoin/bitcoin/pull/10774
< bitcoin-git> [bitcoin] romanornr opened pull request #10774: nCheckDepth chain height fix (master...master) https://github.com/bitcoin/bitcoin/pull/10774
< gribble> https://github.com/bitcoin/bitcoin/issues/10589 | More economical fee estimates for RBF and RPC options to control by morcos · Pull Request #10589 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10753: test: Check RPC argument mapping (master...2017_07_rpc_argument_check) https://github.com/bitcoin/bitcoin/pull/10753
< bitcoin-git> [bitcoin] practicalswift opened pull request #10773: Shell script cleanups (master...shell) https://github.com/bitcoin/bitcoin/pull/10773
< bitcoin-git> [bitcoin] shaolinfry opened pull request #10772: Implementation of BIP8 (master...bip8-height) https://github.com/bitcoin/bitcoin/pull/10772

2017-07-07

< bitcoin-git> [bitcoin] practicalswift opened pull request #10771: Remove unused variables in shell scripts (master...unused-shell-variables) https://github.com/bitcoin/bitcoin/pull/10771
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (master...2017-07-upgrade-cancel-nits) https://github.com/bitcoin/bitcoin/pull/10770
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (master...2017/07/qt_fee_slider) https://github.com/bitcoin/bitcoin/pull/10769
< gribble> https://github.com/bitcoin/bitcoin/issues/10651 | Verify binaries from bitcoincore.org and bitcoin.org by TheBlueMatt · Pull Request #10651 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10768: Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp (master...init-nStart) https://github.com/bitcoin/bitcoin/pull/10768
< bitcoin-git> [bitcoin] jnewbery opened pull request #10767: Clarify wallet initialization / destruction interface (master...walletinit2) https://github.com/bitcoin/bitcoin/pull/10767
< gribble> https://github.com/bitcoin/bitcoin/issues/10251 | Add balances cache / GUI: use a signal instead of a poll thread by jonasschnelli · Pull Request #10251 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10765: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10765
< bitcoin-git> [bitcoin] fanquake closed pull request #10764: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10764
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10764: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10764
< jonasschnelli> Anyone know why I get this liner error in travis (doesn't happen with clang): https://travis-ci.org/bitcoin/bitcoin/jobs/246110728#L2103
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (master...2017-07-fix-mult-rpc-test) https://github.com/bitcoin/bitcoin/pull/10759
< bitcoin-git> bitcoin/master 1d4805c MarcoFalke: Merge #10759: Fix multi_rpc test for hosts that dont default to utf8...
< bitcoin-git> bitcoin/master bc7d103 Matt Corallo: Fix multi_rpc test for hosts that dont default to utf8...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3b58704d1d3...1d4805ce0464
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10761: [tests] fix replace_by_fee.py (master...fix_replace_by_fee) https://github.com/bitcoin/bitcoin/pull/10761
< bitcoin-git> bitcoin/master 301fd51 John Newbery: [tests] fix replace_by_fee.py...
< bitcoin-git> bitcoin/master d3b5870 MarcoFalke: Merge #10761: [tests] fix replace_by_fee.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed88e3194c4b...d3b58704d1d3
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10744: Use method name via __func__ macro (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10744
< bitcoin-git> bitcoin/master ed88e31 MarcoFalke: Merge #10744: Use method name via __func__ macro...
< bitcoin-git> bitcoin/master 9bbf600 darksh1ne: Use method name from __func__ macro...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5af657253498...ed88e3194c4b
< bitcoin-git> [bitcoin] jnewbery opened pull request #10762: [WIP] Remove Wallet dependencies from init.cpp (master...walletinit) https://github.com/bitcoin/bitcoin/pull/10762
< bitcoin-git> [bitcoin] jnewbery opened pull request #10761: [tests] fix replace_by_fee.py (master...fix_replace_by_fee) https://github.com/bitcoin/bitcoin/pull/10761
< bitcoin-git> [bitcoin] sipa opened pull request #10760: Avoid dereference-of-casted-pointer (master...20170707_avoidcastptr) https://github.com/bitcoin/bitcoin/pull/10760
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10759: Fix multi_rpc test for hosts that dont default to utf8 (master...2017-07-fix-mult-rpc-test) https://github.com/bitcoin/bitcoin/pull/10759
< grubles> i think that is out of date (2015). i tried following it the other day and it seems some of the scripts are maybe in the wrong directories? (https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/scripts/spawn-gitian-bitcoin-host.sh in particular 404s as it is in the wrong dir)
< jtimon> mhmm, "LXC, see also Gitian host docker container[ https://github.com/gdm85/tenku/blob/master/docker/gitian-bitcoin-host/README.md ] .
< jtimon> I mean, in the deterministic build tutorial for bitcoin, which I found easy to follow, you are required to create a debian vm
< jtimon> no, I don't think docker's determinism is enough for bitcoin's deterministic builds is what I'm saying, but I'm no expert on either of them, just used them by following tutorials and reading other people's code
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10758: Fix some chainstate-init-order bugs. (master...2014-07-nonatomic-flush-fixes) https://github.com/bitcoin/bitcoin/pull/10758

2017-07-06

< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getperblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< jtimon> we don't use it all that much in bitcoin https://0bin.net/paste/p8nz4NJTOuyw622R#A-qZ020Wy3jsQcl6Py3H1KDYJkxjrO7QnCqmauzad7L but I guess that's another idea for a scripted-diff PR
< jtimon> I "had" to delete ~/.bitcoin yesterday until I learned how to cleanup things in docker (damm, should have just copied it to another disk), otherwise I could have seen the historic min fee and feerate per block that I've always wanted to see...
< bitcoin-git> [bitcoin] jtimon opened pull request #10757: RPC: Introduce getperblockstats to plot things (master...b15-rpc-plotter) https://github.com/bitcoin/bitcoin/pull/10757
< bitcoin-git> [bitcoin] theuni opened pull request #10756: net processing: swap out signals for an interface class (master...no-net-signals2) https://github.com/bitcoin/bitcoin/pull/10756
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
< wumpus> "This would require to store the plugin name and the device identifier somewhere (probably bitcoin.conf to begin with)"
< spudowiar> This would require to store the plugin name and the device identifier somewhere (probably bitcoin.conf to begin with)
< wumpus> spudowiar: if it has a special gui it should definitely draw it itself, bitcoin qt can't get into the UI delegation/embedding business
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10571 | [RPC]Move transaction combining from signrawtransaction to new RPC by achow101 · Pull Request #10571 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9961 | Release schedule for 0.15.0 · Issue #9961 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10707 | Better API for estimatesmartfee RPC by morcos · Pull Request #10707 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10712 | Add change output if necessary to reduce excess fee by morcos · Pull Request #10712 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10589 | More economical fee estimates for RBF and RPC options to control by morcos · Pull Request #10589 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10557 | Make check to distinguish between orphan txs and old txs more efficient. by morcos · Pull Request #10557 · bitcoin/bitcoin · GitHub
< jonasschnelli> The most stables index I could find so far is that one: https://github.com/bitcoin/bitcoin/pull/10370
< gribble> https://github.com/bitcoin/bitcoin/issues/9806 | txoutsbyaddress index (take 3) by droark · Pull Request #9806 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub
< sipa> "The next Bitcoin-Qt version requires a 4k screen for coin selection"
< bitcoin-git> [bitcoin] ryanofsky closed pull request #10661: Add optional wallet=filename arguments to wallet RPCs (master...pr/multiopt) https://github.com/bitcoin/bitcoin/pull/10661