2017-11-29

< jonasschnelli> Anyone up for a quick review: https://github.com/bitcoin/bitcoin/pull/11616/files?
< jimpo> leveldb docs say that DB is safe for concurrent access by multiple threads: https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/include/leveldb/db.h#L42. Is it assumed that CDBWrapper is as well or no?
< bitcoin-git> [bitcoin] jnewbery opened pull request #11791: [tests] Rename NodeConn and NodeConnCB (master...rename_node_conn) https://github.com/bitcoin/bitcoin/pull/11791
< bitcoin-git> [bitcoin] eklitzke opened pull request #11790: Add pixmaps for testnet and regtest (master...pixmaps) https://github.com/bitcoin/bitcoin/pull/11790
< eck> are there pixmaps for bitcoin testnet? i'd like to create .desktop file for bitcoin-qt -testnet=1 that uses the green logo, instead of the orange one
< bitcoin-git> [bitcoin] jnewbery opened pull request #11789: [tests] [travis-ci] Combine logs on failure (master...pr11779.2) https://github.com/bitcoin/bitcoin/pull/11789
< bitcoincore-slac> Just wanted to let everyone who has committed code to bitcoin core that there are A LOT of shout-outs and appreciation to all of you the past few days on Slack, Twitter, etc. We know what you have done and continuing to do and can't thank you enough!
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< Murch> That question is better suited for Bitcoin.stackexchange.com than for this channel. However, the difficulty scales on a range of 2^256, so that scenario is pretty far-fetched.
< erichCompSci> Hello, I was wondering about the following problem. Miners in bitcoin verify transactions in the blockchain by hashing the previous blocks header, transaction data and a nonce value. However, the block is only considered a legitimate block
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rawodb closed pull request #11787: Support for SegWit addresses, change addresses and UI request payment (master...pr/segwit_addresses_master) https://github.com/bitcoin/bitcoin/pull/11787
< BlueMatt> sipa: if you get particularly bored, I went down a way-too-deep rabbit hole reading mapBlocksUnlinked and pruning logic, and ended up with a few teaks to help my understanding and fix some tiny edge cases as I go....care to take a look at all but the top commit on https://github.com/TheBlueMatt/bitcoin/commits/2017-11-unlinked-blockx-fixes and tell me if its worth upstreaming?
< larafale> is UnspentTransactionOutputs only available throught REST ? I can also run that command throught bitcoin-cli I guess?
< gribble> https://github.com/bitcoin/bitcoin/issues/8549 | zmq: mempool notifications by jmcorgan · Pull Request #8549 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9254 | [depends] ZeroMQ 4.2.2 by fanquake · Pull Request #9254 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11737 | Document partial validation in ConnectBlock() by sdaftuar · Pull Request #11737 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 32c9b57 Wladimir J. van der Laan: Merge #11753: clarify abortrescan rpc use...
< bitcoin-git> bitcoin/master 8b2c733 Gregory Sanders: clarify abortrescan rpc use
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/46d1ebfcf854...32c9b570fcea
< gribble> https://github.com/bitcoin/bitcoin/issues/11785 | Prevent file-descriptor exhaustion from RPC layer by vii · Pull Request #11785 · bitcoin/bitcoin · GitHub
< aj> "<bitcoin-git> [bitcoin] vii opened pull request #11785: ..." came through earlier
< bitcoin-git> bitcoin/master e1a8ec5 Andras Elso: Fix: Open files read only if requested
< bitcoin-git> bitcoin/master e970396 Wladimir J. van der Laan: Merge #11747: Fix: Open files read only if requested...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26efc220a13a...e97039605e0d
< wumpus> but ask in #bitcoin please this is not a help channel
< wumpus> #bitcoin please
< shadow_walker> should I use the bitcoincore.io or https://github.com/bitcoin/bitcoin
< shadow_walker> I need some help to create a bitcoin web wallet
< kallewoof> Running "bash bitcoin/contrib/gitian-build.sh" works fine so no biggie, just annoying.
< bitcoin-git> [bitcoin] vii opened pull request #11785: Prevent file-descriptor exhaustion from RPC layer (master...master) https://github.com/bitcoin/bitcoin/pull/11785
< bitcoin-git> [bitcoin] MoneyMakerLTD opened pull request #11784: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/11784

2017-11-28

< gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/1337 | Quieter initial block download by rebroad · Pull Request #1337 · bitcoin/bitcoin · GitHub
< jonasschnelli> Masterboy: please answer in the #bitcoin channel
< sipa> Masterboy: #bitcoin
< jonasschnelli> blockchain: better use #bitcoin for this... off-topic here.
< blockchain> hi I have installed bitcoin-core 15.01 and want to use the replace by fee. but the "increase transaction fee" option is grey, how can i activate it ?
< gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
< MarcoFalke> nanotube: https://github.com/nanotube/supybot-bitcoin-marketmonitor is only for the market, no?
< gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11287: DRY config header inclusion (master...refactor/dry-config) https://github.com/bitcoin/bitcoin/pull/11287
< bitcoin-git> [bitcoin] laanwj opened pull request #11783: Fix shutdown in case of errors during initialization (master...2017_11_notify_callbacks_shutdown_crash) https://github.com/bitcoin/bitcoin/pull/11783
< bitcoin-git> [bitcoin] laanwj opened pull request #11781: Add `-debuglogfile` option (master...2017_11_logfile) https://github.com/bitcoin/bitcoin/pull/11781
< gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11647 | 0.15: Backports by MarcoFalke · Pull Request #11647 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #9754: Change NULLFAIL => SIG_NULLFAIL. (master...feature/unify_sig_nullfail) https://github.com/bitcoin/bitcoin/pull/9754
< gribble> https://github.com/bitcoin/bitcoin/issues/9754 | Change NULLFAIL => SIG_NULLFAIL. by richardkiss · Pull Request #9754 · bitcoin/bitcoin · GitHub
< jonasschnelli> raheel_: this is the core dev channel, pleae use #bitcoin or #bitcoin-dev for your Q
< wumpus> raheel_, take this to #bitcoin
< wumpus> raheel_: #bitcoin
< bitcoin-git> [bitcoin] fanquake closed pull request #9859: Make TestBlockValidity optional in CreateNewBlock (master...tbv-optional) https://github.com/bitcoin/bitcoin/pull/9859
< wumpus> this is what we should avoid: https://github.com/bitcoin/bitcoin/pull/11747 the person posts a straightforward two-line fix for an actual issue, when well-meaning but overly zealous review comments get them to refactor things in a questionable way resulting in much more discussion and doubt of correctness
< bitcoin-git> [bitcoin] laanwj closed pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
< gribble> https://github.com/bitcoin/bitcoin/issues/11389 | Support having SegWit always active in regtest (sipa, ajtowns, jnewbery) by sipa · Pull Request #11389 · bitcoin/bitcoin · GitHub
< Varunram> rusty: aj: had the bugs few days back, turned out to be exactly what rusty specified, there'd be another .bitcoin directory somewhere. Once I changed home directories, it went well
< gmurf> any good places to learn how to use Bitcoin api

2017-11-27

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11779: qa: Combine logs on travis by default (master...Mf1711-travisQaLogs) https://github.com/bitcoin/bitcoin/pull/11779
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11775: Move fee estimator into validationinterface/cscheduler thread (master...2017-09-background-feeest) https://github.com/bitcoin/bitcoin/pull/11775
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #11047: [tests] rename functional tests (master...rename_functional_tests) https://github.com/bitcoin/bitcoin/pull/11047
< bitcoin-git> [bitcoin] jnewbery opened pull request #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework (master...refactor_invalidtxrequest) https://github.com/bitcoin/bitcoin/pull/11771
< bitcoin-git> [bitcoin] joemphilips opened pull request #11770: [REST] add a rest endpoint for estimatesmartfee, docs, and test (master...rest_fee) https://github.com/bitcoin/bitcoin/pull/11770
< sipa> and it likely conflicts with how people actually use bitcoin in the real world now - where they expect a txid to be something you can track

2017-11-26

< archaeal> laptop - you do realize you're in #bitcoin-core-dev, right? Maybe try #bitcoin
< laptop> how profitable is it to mine bitcoin or alternative bitcoins in a pool like litecoin is it really worth your time
< achow101> you could use something else to broadcast, e.g. https://github.com/laanwj/bitcoin-submittx
< Randolf> jl2012: This channel is focused on the software development aspects of bitcoin core. What you've raised seems to be a usability question, which is much more likely to be served well on the #bitcoin channel. That's why I suggested that you ask there.
< Randolf> jl2012: Well, why don't you ask in the #bitcoin channel? Maybe it's already supported (I don't know).
< Randolf> jl2012: You seem to be asking a question about useability rather than about development. Have you tried asking your question in the #bitcoin channel?
< bitcoin-git> bitcoin/master a892218 MarcoFalke: Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports....
< bitcoin-git> bitcoin/master f522fb7 practicalswift: tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l)
< bitcoin-git> bitcoin/master 0f3b752 practicalswift: Remove unused imports
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a933cb14c75b...a89221873a3e

2017-11-25

< bitcoin-git> [bitcoin] fanquake closed pull request #11761: [WIP] [docs] initial QT documentation (master...qt-docs) https://github.com/bitcoin/bitcoin/pull/11761
< bitcoin-git> [bitcoin] aaron-hanson opened pull request #11765: [REST] added blockhash api, tests and documentation (master...rest-blockhash-endpoint) https://github.com/bitcoin/bitcoin/pull/11765

2017-11-24

< bitcoin-git> [bitcoin] practicalswift opened pull request #11762: Avoid locking mutexes that are already held by the same thread (master...remove-double-locks) https://github.com/bitcoin/bitcoin/pull/11762
< bitcoin-git> [bitcoin] Sjors opened pull request #11761: [docs] initial QT documentation (master...qt-docs) https://github.com/bitcoin/bitcoin/pull/11761

2017-11-23

< gribble> https://github.com/bitcoin/bitcoin/issues/11720 | iOS Deployment Target for RPC · Issue #11720 · bitcoin/bitcoin · GitHub
< Provoostenator> @jonasschnelli me too, but I think a more realistic scenario is more people running Bitcoin Core nodes and connecting their favorite wallet to it.
< jonasschnelli> I'd like to see more users using Bitcoin Core as a wallet
< jonasschnelli> The current bitcoin wallets do loose one of the primary elements Bitcoin can defeat "Trusted third parties are security holes".
< jonasschnelli> b) you add a script to your bitcoin core machine that would server over TLS (an RPC proxy)
< gribble> https://github.com/bitcoin/bitcoin/issues/10794 | Add simple light-client mode (RPC only) by jonasschnelli · Pull Request #10794 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ldm5180 opened pull request #11760: [crypto] Refactor HMAC_SHA to eliminate code duplication (master...generic-hmac_sha) https://github.com/bitcoin/bitcoin/pull/11760
< jonasschnelli> Provoostenator: please review https://github.com/bitcoin/bitcoin/pull/10794 (its a stepping stone for GUI sep.)
< gribble> https://github.com/bitcoin/bitcoin/issues/11667 | Add scripts to dumpwallet RPC by MeshCollider · Pull Request #11667 · bitcoin/bitcoin · GitHub
< jonasschnelli> I think long term we should not expect that private keys are on the same machine then bitcoin core runs (at least not with the current one process design)
< wumpus> here, a PR by first-time contributor that gets a lot of review instantly: https://github.com/bitcoin/bitcoin/pull/11747
< Provoostenator> Has Google Summer of Code ever done Bitcoin Core projects? https://developers.google.com/open-source/gsoc/
< wumpus> bitcoin isn't really a good project for first time open source contributors in that regard, some projects just merge everything effectively instantly, but we cannot have a policy like that, not for first contributors ither
< Provoostenator> I'd like to propose adding a project Onboarding to this list: https://github.com/bitcoin/bitcoin/projects
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag
< gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub

2017-11-22

< jonasschnelli> cluelessperson: this is also a handy resource (seems up to date): https://en.bitcoin.it/wiki/Protocol_documentation
< sipa> cluelessperson: bitcoin.org developer documentation is pretty good
< bitcoin-git> [bitcoin] practicalswift opened pull request #11754: Add missing cs_wallet locks when accessing m_last_block_processed (master...missing-m_last_block_processed-locks) https://github.com/bitcoin/bitcoin/pull/11754
< bitcoin-git> [bitcoin] practicalswift closed pull request #11749: wallet: Set m_last_block_processed to nullptr in SetNull() (master...m_last_block_processed) https://github.com/bitcoin/bitcoin/pull/11749
< bitcoin-git> [bitcoin] practicalswift closed pull request #11749: wallet: Set m_last_block_processed to nullptr in SetNull() (master...m_last_block_processed) https://github.com/bitcoin/bitcoin/pull/11749
< bitcoin-git> [bitcoin] instagibbs opened pull request #11753: clarify abortrescan rpc use (master...abortrescanclarity) https://github.com/bitcoin/bitcoin/pull/11753
< bitcoin-git> [bitcoin] jamesob closed pull request #11751: Use override in CCoinsView* subclasses (master...add-override-coins) https://github.com/bitcoin/bitcoin/pull/11751
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11743: qa: Add multiwallet prefix test (master...Mf1711-qaMultiwallet) https://github.com/bitcoin/bitcoin/pull/11743
< jeffrade> promag: So this is nothing that will live in the repo, e.g. bitcoin/test/functional/ ?
< jeffrade> I posted a question yesterday on https://github.com/bitcoin/bitcoin/issues/3172 I need some clarification.
< bitcoin-git> [bitcoin] practicalswift opened pull request #11749: Set m_last_block_processed to nullptr in SetNull() (master...m_last_block_processed) https://github.com/bitcoin/bitcoin/pull/11749
< gribble> https://github.com/bitcoin/bitcoin/issues/9849 | Qt: Network Watch tool by luke-jr · Pull Request #9849 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/5896 | [Qt][PoC] introduce "core-pulse" by jonasschnelli · Pull Request #5896 · bitcoin/bitcoin · GitHub
< jonasschnelli> Would adding block size(s) and weight to the block index be completely wrong? https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2017/11/blockindex_size?expand=1
< gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #11746: trivial: Fix unsuccessful typo (master...unsuccesful) https://github.com/bitcoin/bitcoin/pull/11746
< bitcoin-git> bitcoin/master 5ea932a Pieter Wuille: Merge #11746: trivial: Fix unsuccessful typo...
< bitcoin-git> bitcoin/master d2ea2bc practicalswift: trivial: Fix unsuccessful typo
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4267a3ab271...5ea932a51083
< bitcoin-git> [bitcoin] merehap opened pull request #11748: [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. (master...blockchain_unittests) https://github.com/bitcoin/bitcoin/pull/11748

2017-11-21

< bitcoin-git> [bitcoin] fanquake closed pull request #11735: [refactor] Remove magic numbers from HMAC SHA256 (master...eliminate_magic_numbers) https://github.com/bitcoin/bitcoin/pull/11735
< aj> meshcollider: mainnet bitcoin.conf and network.conf live in the same directory :(
< meshcollider> Or would having them both called bitcoin.conf be confusing
< aj> meshcollider: i'm not sure if there's a use case... atm, you could have standard settings in bitcoin.conf and special settings in network.conf (mainnet addnode's say), and switch either independently via command line options. that just seems a bit more flexible and maybe natural to me?
< aj> meshcollider: i worry about that too. current behaviour is that bitcoin.conf is loaded first and network.conf second (so bitcoin.conf can specify the network), and any setting in bitcoin.conf overrides any setting in network.conf
< aj> meshcollider: yeah: patch makes bitcoind load two config files, .bitcoin/bitcoin.conf and .bitcoin/testnet3/network.conf; -conf lets you choose a different name for the first one, -netconf a different name for the second one
< gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
< andytoshi> Chris_Stewart_5: #bitcoin-mining will probably be more helpful, or #bitcoin. this channel is specifically about software development of Bitcoin Core
< bitcoin-git> [bitcoin] Elbandi opened pull request #11747: Fix: Open files read only if requested (master...fix11745) https://github.com/bitcoin/bitcoin/pull/11747
< bitcoin-git> [bitcoin] practicalswift opened pull request #11746: trivial: Fix unsuccessful typo (master...unsuccesful) https://github.com/bitcoin/bitcoin/pull/11746
< bitcoin-git> [bitcoin] practicalswift opened pull request #11744: net: Add missing locks in net.{cpp,h} (master...missing-net-locks) https://github.com/bitcoin/bitcoin/pull/11744
< gribble> https://github.com/bitcoin/bitcoin/issues/11047 | [tests] rename functional tests by jnewbery · Pull Request #11047 · bitcoin/bitcoin · GitHub
< wumpus> also it'd make no sense, we'd have to distinguish which daemon is logging for each line - if you really want to dump all your bitcoin logging to one place, you can already use -printtoconsole w/ some log aggregation like systemd
< gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11743: qa: Add multiwallet prefix test (master...Mf1711-qaMultiwallet) https://github.com/bitcoin/bitcoin/pull/11743
< wumpus> also if you just want to test w/ bitcoin and times there's setmocktime
< Sentineo> so if I set my time to 2015 would I invalidate blocks? It sounds like bitcoin-core would take the blockchain (and other nodes) as the source of time
< bitcoin-git> [bitcoin] laanwj closed pull request #11738: Fix sendrawtransaction hang when sending a tx already in mempool (master...2017-11-fix-sendraw-block) https://github.com/bitcoin/bitcoin/pull/11738
< bitcoin-git> bitcoin/master d4267a3 Wladimir J. van der Laan: Merge #11738: Fix sendrawtransaction hang when sending a tx already in mempool...
< bitcoin-git> bitcoin/master d9340ce Matt Corallo: Fix sendrawtransaction hang when sending a tx already in mempool
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/901ba3e38194...d4267a3ab271
< fanquake> JeffSlentz Also read through https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md & https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md . They explain how the development process works, and preferred code styles etc.
< fanquake> JeffSlentz Checkout the "good first issue" label on repo. https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
< Randolf> JeffSlentz: If not, then there may be other options for you, but you'll probably need to ask about those possibilities in the #bitcoin channel.
< JeffSlentz> Hey, as a recent grad with not much experience with the Bitcoin Core project, are there any suggestions for contributing?
< Murch> morcos: I was just looking at fee rate estimation. I'm surprised that the Bitcoin Core estimate is still on 170 for second block target when the network has been clearing the mempool of <40 for four days.

2017-11-20

< bitcoin-git> [bitcoin] eklitzke opened pull request #11741: Add -logdir option to control where debug.log lives (master...logdir) https://github.com/bitcoin/bitcoin/pull/11741
< HisMajesty_> Everything ECDSA Public Key (Bitcoin Compatible): 1N2EWy7LroJVFYXtmYZryh7W9eV3k6qajd exists since Mon Oct 02 2017 23:48:19 GMT-0700 (Pacific Daylight Time)
< HisMajesty_> Hello Bitcoin Core Developers
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #11740: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signalling only* (master...2017/11/NNL_signaling) https://github.com/bitcoin/bitcoin/pull/11740
< bitcoin-git> [bitcoin] sdaftuar opened pull request #11739: RFC: Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis (master...2017-09-p2sh-segwit-from-genesis) https://github.com/bitcoin/bitcoin/pull/11739
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11714: [tests] Test that mempool rejects coinbase transactions (master...test-mempool-rejects-coinbase) https://github.com/bitcoin/bitcoin/pull/11714
< bitcoin-git> bitcoin/master 901ba3e MarcoFalke: Merge #11714: [tests] Test that mempool rejects coinbase transactions...
< bitcoin-git> bitcoin/master 65e91f5 James O'Beirne: [tests] Test that mempool rejects coinbase transactions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a43fbb959c3...901ba3e38194
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11738: Fix sendrawtransaction hang when sending a tx already in mempool (master...2017-11-fix-sendraw-block) https://github.com/bitcoin/bitcoin/pull/11738
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11729: [docs] links to code style guides (master...docs-style-guide-links) https://github.com/bitcoin/bitcoin/pull/11729
< bitcoin-git> bitcoin/master 7a43fbb MarcoFalke: Merge #11729: [docs] links to code style guides...
< bitcoin-git> bitcoin/master fe27a72 Sjors Provoost: [docs] links to code style guides
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7293d064133a...7a43fbb959c3
< bitcoin-git> [bitcoin] sdaftuar opened pull request #11737: Document partial validation in ConnectBlock() (master...2017-11-comment-validation) https://github.com/bitcoin/bitcoin/pull/11737
< bitcoin-git> [bitcoin] ldm5180 opened pull request #11735: [refactor] Remove magic numbers from HMAC SHA256 (master...eliminate_magic_numbers) https://github.com/bitcoin/bitcoin/pull/11735
< Provoostenator> I'm looking at the multiwallet GUI PR now, since it's in this list: https://github.com/bitcoin/bitcoin/projects/8
< bitcoin-git> [bitcoin] practicalswift opened pull request #11734: rpc: Work around Clang thread safety analysis quirks (master...clang-thread-safety-quirks) https://github.com/bitcoin/bitcoin/pull/11734
< bitcoin-git> [bitcoin] Sjors closed pull request #11730: WIP [RPC] [Wallet] walletdowngrade command (which can remove HD) (master...wallet-downgrade) https://github.com/bitcoin/bitcoin/pull/11730
< bitcoin-git> [bitcoin] practicalswift opened pull request #11733: Remove redundant locks (master...redundant-locks) https://github.com/bitcoin/bitcoin/pull/11733
< gribble> https://github.com/bitcoin/bitcoin/issues/7165 | build: Enable C++11 in build, require C++11 compiler by laanwj · Pull Request #7165 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11732 | RFC: bump GCC requirement to 4.8 · Issue #11732 · bitcoin/bitcoin · GitHub
< wumpus> is anyone building bitcoin core using g++ 4.7? if so, please weigh in here #11732
< bitcoin-git> [bitcoin] laanwj closed pull request #11110: [script] Avoid implicit casts from bool to CScriptNum (master...implicit-casts-from-bool-to-cscriptnum) https://github.com/bitcoin/bitcoin/pull/11110
< bitcoin-git> [bitcoin] laanwj closed pull request #11662: [0.15] Sanity-check script sizes in bitcoin-tx (0.15...bitcoin-tx-script-sizes-0.14) https://github.com/bitcoin/bitcoin/pull/11662

2017-11-19

< sipa> that doesn't look like bitcoin core
< bitcoin-git> [bitcoin] Sjors opened pull request #11730: WIP [RPC] [Wallet] walletdowngrade command (which can remove HD) (master...wallet-downgrade) https://github.com/bitcoin/bitcoin/pull/11730
< bitcoin-git> [bitcoin] Sjors opened pull request #11729: [docs] links to code style guides (master...docs-style-guide-links) https://github.com/bitcoin/bitcoin/pull/11729
< gribble> https://github.com/bitcoin/bitcoin/issues/9195 | Debug console needs a little documentation on usage · Issue #9195 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11698: [Docs] [Qt] RPC-Console nested commands documentation (master...doc-rpc-console) https://github.com/bitcoin/bitcoin/pull/11698
< bitcoin-git> bitcoin/master c3055bb Luke Mlsna: Add help-console command to Qt debug console...
< bitcoin-git> bitcoin/master 7293d06 Wladimir J. van der Laan: Merge #11698: [Docs] [Qt] RPC-Console nested commands documentation...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cdd2bcf6794...7293d064133a
< wumpus> anyhow bitcoin core works fine with the berkeleydb 5 port/package
< wumpus> "Deprecated DEPRECATED: Please migrate to db5 or db6, make sure that bitcoin and siblings moved to another database or version by then" haha
< bitcoin-git> [bitcoin] laanwj closed pull request #11718: tests: move pwalletMain to wallet test fixture (master...2017_11_wallet_test_fixture) https://github.com/bitcoin/bitcoin/pull/11718
< bitcoin-git> bitcoin/master 49bd659 Wladimir J. van der Laan: tests: move pwalletMain to wallet test fixture...
< bitcoin-git> bitcoin/master 9cdd2bc Wladimir J. van der Laan: Merge #11718: tests: move pwalletMain to wallet test fixture...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d89fa087793...9cdd2bcf6794
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11726: Cleanups + nit fixes for walletdir PR (master...201711_walletdir) https://github.com/bitcoin/bitcoin/pull/11726

2017-11-18

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11707: [tests] Fix sendheaders (master...fix_sendheaders) https://github.com/bitcoin/bitcoin/pull/11707
< bitcoin-git> bitcoin/master 25fd6e2 John Newbery: [tests] refactor check_last_announcement() in sendheaders.py...
< bitcoin-git> bitcoin/master f39d4bb John Newbery: [tests] tidy up BaseNode in sendheaders.py
< bitcoin-git> bitcoin/master 2613c54 John Newbery: [tests] fix flake8 warnings in sendheaders.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/d080a7d5030e...0d89fa087793
< merehap> Hi all, I just ran "make cov" on bitcoin core, looking for low hanging fruit for writing new unit tests. I found that src/rpc/blockchain.cpp has low coverage. Are there any objections to me adding unit tests for this file? Any caveats?
< bitcoin-git> [bitcoin] tjps opened pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
< bitcoin-git> [bitcoin] laanwj closed pull request #11466: Specify custom wallet directory with -walletdir param (master...201710_walletdir) https://github.com/bitcoin/bitcoin/pull/11466
< bitcoin-git> bitcoin/master d987889 MeshCollider: Add release notes for -walletdir and wallets/ dir
< bitcoin-git> bitcoin/master 80c5cbc MeshCollider: Add test for -walletdir
< bitcoin-git> bitcoin/master 0530ba0 MeshCollider: Add -walletdir parameter to specify custom wallet dir
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/49667a77e76a...d080a7d5030e
< bitcoin-git> [bitcoin] laanwj opened pull request #11718: tests: move pwalletMain to wallet test fixture (master...2017_11_wallet_test_fixture) https://github.com/bitcoin/bitcoin/pull/11718
< bitcoin-git> [bitcoin] laanwj closed pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
< bitcoin-git> bitcoin/master 49667a7 Wladimir J. van der Laan: Merge #11713: Fix for mismatched extern definition in wallet tests...
< bitcoin-git> bitcoin/master f94c2ec Aaron Clauson: Fix for mismatched extern definition in wallet test classes which was breaking msvc linking.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/938863965f14...49667a77e76a
< bitcoin-git> [bitcoin] laanwj closed pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
< bitcoin-git> bitcoin/master 9388639 Wladimir J. van der Laan: Merge #11710: cli: Reject arguments to -getinfo...
< bitcoin-git> bitcoin/master dcfef27 Wladimir J. van der Laan: cli: Reject arguments to -getinfo...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/142913296f00...938863965f14
< bitcoin-git> [bitcoin] jamesob opened pull request #11714: [tests] Test that mempool rejects coinbase transactions (master...test-mempool-rejects-coinbase) https://github.com/bitcoin/bitcoin/pull/11714
< bitcoin-git> [bitcoin] sipsorcery opened pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
< gmaxwell> given bitcoin transaction rates perhaps he could plausably steal 32 of those bits per signature instead of 16.
< jonasschnelli> But an attacked would have to try all 16bit combinations from all public known bitcoin signatures?
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub

2017-11-17

< bitcoin-git> [bitcoin] jnewbery opened pull request #11712: [tests] Split NodeConn from NodeConnCB (master...split_nodeconn) https://github.com/bitcoin/bitcoin/pull/11712
< bitcoin-git> [bitcoin] fanquake closed pull request #10702: [Trivial] Improve end-of-namespace comment consistency (master...improve-end-of-namespace-comment-consistence) https://github.com/bitcoin/bitcoin/pull/10702
< bitcoin-git> [bitcoin] fanquake closed pull request #10172: Fix opt-in RBF reliance on compiler integer size (master...rbf-numlimits-fix) https://github.com/bitcoin/bitcoin/pull/10172
< wumpus> so if you'd validate walletdir before intro, you'd miss it if it's provided in bitcoin.conf
< wumpus> e.g. bitcoin.conf hasn't been read yet
< bitcoin-git> [bitcoin] fanquake closed pull request #9737: Don't disconnect feeler connections prematurely (master...ServicesIrrelevantForFeelerConnections) https://github.com/bitcoin/bitcoin/pull/9737
< wumpus> promag: there was earlier discussion about that: https://github.com/bitcoin/bitcoin/pull/11466#discussion_r150251905
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
< bitcoin-git> bitcoin/master 1429132 Wladimir J. van der Laan: Merge #11140: Trivial: Improve #endif comments...
< bitcoin-git> bitcoin/master ac1cf8d danra: Trivial: Improve #endif comments...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5197100704b8...142913296f00
< bitcoin-git> [bitcoin] fanquake closed pull request #11222: bitcoin_qt.m4: Minor fixes and clean-ups. (master...config-fixes) https://github.com/bitcoin/bitcoin/pull/11222
< bitcoin-git> [bitcoin] fanquake opened pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
< gribble> https://github.com/bitcoin/bitcoin/issues/11140 | Trivial: Improve #endif comments by danra · Pull Request #11140 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
< bitcoin-git> bitcoin/master 5197100 Wladimir J. van der Laan: Merge #11706: Make default issue text all comments to make issues more readable...
< bitcoin-git> bitcoin/master e89adba Matt Corallo: Make default issue text all comments to make issues more readable
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea68190132b2...5197100704b8
< gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11196 | Switch memory_cleanse implementation to BoringSSLs to ensure memory clearing even with -lto by maaku · Pull Request #11196 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11526 | Visual Studio build configuration for Bitcoin Core. by sipsorcery · Pull Request #11526 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11704: Windows build doc update (master...windoc) https://github.com/bitcoin/bitcoin/pull/11704
< bitcoin-git> bitcoin/master ea68190 Wladimir J. van der Laan: Merge #11704: Windows build doc update...
< bitcoin-git> bitcoin/master 1cecea7 Aaron Clauson: doc: Specify required source location for Windows WSL builds...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/595ec11d804f...ea68190132b2
< gribble> https://github.com/bitcoin/bitcoin/issues/11704 | Windows build doc update by sipsorcery · Pull Request #11704 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
< bitcoin-git> [bitcoin] laanwj closed pull request #11700: Add gitian PGP key: willyko (master...master) https://github.com/bitcoin/bitcoin/pull/11700
< bitcoin-git> bitcoin/master 595ec11 Wladimir J. van der Laan: Merge #11700: Add gitian PGP key: willyko...
< bitcoin-git> bitcoin/master f88d900 Willy Ko: Add gitian PGP key: willyko
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f7695b4194b...595ec11d804f
< gribble> https://github.com/bitcoin/bitcoin/issues/11700 | Add gitian PGP key: willyko by willyko · Pull Request #11700 · bitcoin/bitcoin · GitHub
< fanquake> Indeed https://github.com/bitcoin-core/gitian.sigs/graphs/contributors isn't a long list. Plenty of people in there that haven't built recently as well.
< gribble> https://github.com/bitcoin/bitcoin/issues/10994 | Add option to avoid warning on certain network upgrades by ajtowns · Pull Request #10994 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (master...fix-osx-distcheck) https://github.com/bitcoin/bitcoin/pull/11621
< bitcoin-git> bitcoin/master 1f7695b Wladimir J. van der Laan: Merge #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck...
< bitcoin-git> bitcoin/master a7c949f fanquake: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ccc70a295fc5...1f7695b4194b
< gribble> https://github.com/bitcoin/bitcoin/issues/11621 | [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck by fanquake · Pull Request #11621 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11709 | issue : Message store directory does not exist · Issue #11709 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11648: [tests] Add messages.py (master...add_primitives_py) https://github.com/bitcoin/bitcoin/pull/11648
< bitcoin-git> bitcoin/master ccc70a2 Wladimir J. van der Laan: Merge #11648: [tests] Add messages.py...
< bitcoin-git> bitcoin/master 1135c79 John Newbery: [tests] Tidy up mininode.py module...
< bitcoin-git> bitcoin/master f9cd9b1 John Newbery: [tests] Move test_framework Bitcoin primitives into separate module...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6f8d54aff34...ccc70a295fc5
< bitcoin-git> [bitcoin] laanwj closed pull request #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) (master...fix-newPossibleKeyChange-memory-leak) https://github.com/bitcoin/bitcoin/pull/10920
< bitcoin-git> bitcoin/master f6f8d54 Wladimir J. van der Laan: Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)...
< bitcoin-git> bitcoin/master 446e261 practicalswift: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41221126c855...f6f8d54aff34
< bitcoin-git> [bitcoin] laanwj closed pull request #11702: [build] Add a script for installing db4 (master...install-db4-script) https://github.com/bitcoin/bitcoin/pull/11702
< bitcoin-git> bitcoin/master 4122112 Wladimir J. van der Laan: Merge #11702: [build] Add a script for installing db4...
< bitcoin-git> bitcoin/master 6e4cdd6 James O'Beirne: [docs] Add reference to install_db4.sh in OS X build instructions
< bitcoin-git> bitcoin/master af9103e James O'Beirne: [build] Add a script for installing db4...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/99bc0b428b03...41221126c855
< gribble> https://github.com/bitcoin/bitcoin/issues/11687 | External wallet files by ryanofsky · Pull Request #11687 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
< achow101> what does everyone think about putting various docs about things in progress and plans (e.g. sipa's wallet thing) on the wiki here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki
< bitcoin-git> [bitcoin] CryptAxe closed pull request #11098: [Qt] Add spend all button to the SendCoinsDialog (master...spendall) https://github.com/bitcoin/bitcoin/pull/11098

2017-11-16

< jtimon> weren't they using a naming just the same as bitcoin core but increasing a version? (ie 0.14.3)