2017-11-20

< bitcoin-git> bitcoin/master fe27a72 Sjors Provoost: [docs] links to code style guides
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7293d064133a...7a43fbb959c3
< bitcoin-git> [bitcoin] sdaftuar opened pull request #11737: Document partial validation in ConnectBlock() (master...2017-11-comment-validation) https://github.com/bitcoin/bitcoin/pull/11737
< bitcoin-git> [bitcoin] ldm5180 opened pull request #11735: [refactor] Remove magic numbers from HMAC SHA256 (master...eliminate_magic_numbers) https://github.com/bitcoin/bitcoin/pull/11735
< Provoostenator> I'm looking at the multiwallet GUI PR now, since it's in this list: https://github.com/bitcoin/bitcoin/projects/8
< bitcoin-git> [bitcoin] practicalswift opened pull request #11734: rpc: Work around Clang thread safety analysis quirks (master...clang-thread-safety-quirks) https://github.com/bitcoin/bitcoin/pull/11734
< bitcoin-git> [bitcoin] Sjors closed pull request #11730: WIP [RPC] [Wallet] walletdowngrade command (which can remove HD) (master...wallet-downgrade) https://github.com/bitcoin/bitcoin/pull/11730
< bitcoin-git> [bitcoin] practicalswift opened pull request #11733: Remove redundant locks (master...redundant-locks) https://github.com/bitcoin/bitcoin/pull/11733
< gribble> https://github.com/bitcoin/bitcoin/issues/7165 | build: Enable C++11 in build, require C++11 compiler by laanwj · Pull Request #7165 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11732 | RFC: bump GCC requirement to 4.8 · Issue #11732 · bitcoin/bitcoin · GitHub
< wumpus> is anyone building bitcoin core using g++ 4.7? if so, please weigh in here #11732
< bitcoin-git> [bitcoin] laanwj closed pull request #11110: [script] Avoid implicit casts from bool to CScriptNum (master...implicit-casts-from-bool-to-cscriptnum) https://github.com/bitcoin/bitcoin/pull/11110
< bitcoin-git> [bitcoin] laanwj closed pull request #11662: [0.15] Sanity-check script sizes in bitcoin-tx (0.15...bitcoin-tx-script-sizes-0.14) https://github.com/bitcoin/bitcoin/pull/11662

2017-11-19

< sipa> that doesn't look like bitcoin core
< bitcoin-git> [bitcoin] Sjors opened pull request #11730: WIP [RPC] [Wallet] walletdowngrade command (which can remove HD) (master...wallet-downgrade) https://github.com/bitcoin/bitcoin/pull/11730
< bitcoin-git> [bitcoin] Sjors opened pull request #11729: [docs] links to code style guides (master...docs-style-guide-links) https://github.com/bitcoin/bitcoin/pull/11729
< gribble> https://github.com/bitcoin/bitcoin/issues/9195 | Debug console needs a little documentation on usage · Issue #9195 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11698: [Docs] [Qt] RPC-Console nested commands documentation (master...doc-rpc-console) https://github.com/bitcoin/bitcoin/pull/11698
< bitcoin-git> bitcoin/master c3055bb Luke Mlsna: Add help-console command to Qt debug console...
< bitcoin-git> bitcoin/master 7293d06 Wladimir J. van der Laan: Merge #11698: [Docs] [Qt] RPC-Console nested commands documentation...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cdd2bcf6794...7293d064133a
< wumpus> anyhow bitcoin core works fine with the berkeleydb 5 port/package
< wumpus> "Deprecated DEPRECATED: Please migrate to db5 or db6, make sure that bitcoin and siblings moved to another database or version by then" haha
< bitcoin-git> [bitcoin] laanwj closed pull request #11718: tests: move pwalletMain to wallet test fixture (master...2017_11_wallet_test_fixture) https://github.com/bitcoin/bitcoin/pull/11718
< bitcoin-git> bitcoin/master 49bd659 Wladimir J. van der Laan: tests: move pwalletMain to wallet test fixture...
< bitcoin-git> bitcoin/master 9cdd2bc Wladimir J. van der Laan: Merge #11718: tests: move pwalletMain to wallet test fixture...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d89fa087793...9cdd2bcf6794
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11726: Cleanups + nit fixes for walletdir PR (master...201711_walletdir) https://github.com/bitcoin/bitcoin/pull/11726

2017-11-18

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11707: [tests] Fix sendheaders (master...fix_sendheaders) https://github.com/bitcoin/bitcoin/pull/11707
< bitcoin-git> bitcoin/master 25fd6e2 John Newbery: [tests] refactor check_last_announcement() in sendheaders.py...
< bitcoin-git> bitcoin/master f39d4bb John Newbery: [tests] tidy up BaseNode in sendheaders.py
< bitcoin-git> bitcoin/master 2613c54 John Newbery: [tests] fix flake8 warnings in sendheaders.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/d080a7d5030e...0d89fa087793
< merehap> Hi all, I just ran "make cov" on bitcoin core, looking for low hanging fruit for writing new unit tests. I found that src/rpc/blockchain.cpp has low coverage. Are there any objections to me adding unit tests for this file? Any caveats?
< bitcoin-git> [bitcoin] tjps opened pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
< bitcoin-git> [bitcoin] laanwj closed pull request #11466: Specify custom wallet directory with -walletdir param (master...201710_walletdir) https://github.com/bitcoin/bitcoin/pull/11466
< bitcoin-git> bitcoin/master d987889 MeshCollider: Add release notes for -walletdir and wallets/ dir
< bitcoin-git> bitcoin/master 80c5cbc MeshCollider: Add test for -walletdir
< bitcoin-git> bitcoin/master 0530ba0 MeshCollider: Add -walletdir parameter to specify custom wallet dir
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/49667a77e76a...d080a7d5030e
< bitcoin-git> [bitcoin] laanwj opened pull request #11718: tests: move pwalletMain to wallet test fixture (master...2017_11_wallet_test_fixture) https://github.com/bitcoin/bitcoin/pull/11718
< bitcoin-git> [bitcoin] laanwj closed pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
< bitcoin-git> bitcoin/master 49667a7 Wladimir J. van der Laan: Merge #11713: Fix for mismatched extern definition in wallet tests...
< bitcoin-git> bitcoin/master f94c2ec Aaron Clauson: Fix for mismatched extern definition in wallet test classes which was breaking msvc linking.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/938863965f14...49667a77e76a
< bitcoin-git> [bitcoin] laanwj closed pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
< bitcoin-git> bitcoin/master 9388639 Wladimir J. van der Laan: Merge #11710: cli: Reject arguments to -getinfo...
< bitcoin-git> bitcoin/master dcfef27 Wladimir J. van der Laan: cli: Reject arguments to -getinfo...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/142913296f00...938863965f14
< bitcoin-git> [bitcoin] jamesob opened pull request #11714: [tests] Test that mempool rejects coinbase transactions (master...test-mempool-rejects-coinbase) https://github.com/bitcoin/bitcoin/pull/11714
< bitcoin-git> [bitcoin] sipsorcery opened pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
< gmaxwell> given bitcoin transaction rates perhaps he could plausably steal 32 of those bits per signature instead of 16.
< jonasschnelli> But an attacked would have to try all 16bit combinations from all public known bitcoin signatures?
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub

2017-11-17

< bitcoin-git> [bitcoin] jnewbery opened pull request #11712: [tests] Split NodeConn from NodeConnCB (master...split_nodeconn) https://github.com/bitcoin/bitcoin/pull/11712
< bitcoin-git> [bitcoin] fanquake closed pull request #10702: [Trivial] Improve end-of-namespace comment consistency (master...improve-end-of-namespace-comment-consistence) https://github.com/bitcoin/bitcoin/pull/10702
< bitcoin-git> [bitcoin] fanquake closed pull request #10172: Fix opt-in RBF reliance on compiler integer size (master...rbf-numlimits-fix) https://github.com/bitcoin/bitcoin/pull/10172
< wumpus> so if you'd validate walletdir before intro, you'd miss it if it's provided in bitcoin.conf
< wumpus> e.g. bitcoin.conf hasn't been read yet
< bitcoin-git> [bitcoin] fanquake closed pull request #9737: Don't disconnect feeler connections prematurely (master...ServicesIrrelevantForFeelerConnections) https://github.com/bitcoin/bitcoin/pull/9737
< wumpus> promag: there was earlier discussion about that: https://github.com/bitcoin/bitcoin/pull/11466#discussion_r150251905
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
< bitcoin-git> bitcoin/master 1429132 Wladimir J. van der Laan: Merge #11140: Trivial: Improve #endif comments...
< bitcoin-git> bitcoin/master ac1cf8d danra: Trivial: Improve #endif comments...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5197100704b8...142913296f00
< bitcoin-git> [bitcoin] fanquake closed pull request #11222: bitcoin_qt.m4: Minor fixes and clean-ups. (master...config-fixes) https://github.com/bitcoin/bitcoin/pull/11222
< bitcoin-git> [bitcoin] fanquake opened pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
< gribble> https://github.com/bitcoin/bitcoin/issues/11140 | Trivial: Improve #endif comments by danra · Pull Request #11140 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
< bitcoin-git> bitcoin/master 5197100 Wladimir J. van der Laan: Merge #11706: Make default issue text all comments to make issues more readable...
< bitcoin-git> bitcoin/master e89adba Matt Corallo: Make default issue text all comments to make issues more readable
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea68190132b2...5197100704b8
< gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11196 | Switch memory_cleanse implementation to BoringSSLs to ensure memory clearing even with -lto by maaku · Pull Request #11196 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11526 | Visual Studio build configuration for Bitcoin Core. by sipsorcery · Pull Request #11526 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11704: Windows build doc update (master...windoc) https://github.com/bitcoin/bitcoin/pull/11704
< bitcoin-git> bitcoin/master ea68190 Wladimir J. van der Laan: Merge #11704: Windows build doc update...
< bitcoin-git> bitcoin/master 1cecea7 Aaron Clauson: doc: Specify required source location for Windows WSL builds...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/595ec11d804f...ea68190132b2
< gribble> https://github.com/bitcoin/bitcoin/issues/11704 | Windows build doc update by sipsorcery · Pull Request #11704 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
< bitcoin-git> [bitcoin] laanwj closed pull request #11700: Add gitian PGP key: willyko (master...master) https://github.com/bitcoin/bitcoin/pull/11700
< bitcoin-git> bitcoin/master 595ec11 Wladimir J. van der Laan: Merge #11700: Add gitian PGP key: willyko...
< bitcoin-git> bitcoin/master f88d900 Willy Ko: Add gitian PGP key: willyko
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f7695b4194b...595ec11d804f
< gribble> https://github.com/bitcoin/bitcoin/issues/11700 | Add gitian PGP key: willyko by willyko · Pull Request #11700 · bitcoin/bitcoin · GitHub
< fanquake> Indeed https://github.com/bitcoin-core/gitian.sigs/graphs/contributors isn't a long list. Plenty of people in there that haven't built recently as well.
< gribble> https://github.com/bitcoin/bitcoin/issues/10994 | Add option to avoid warning on certain network upgrades by ajtowns · Pull Request #10994 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (master...fix-osx-distcheck) https://github.com/bitcoin/bitcoin/pull/11621
< bitcoin-git> bitcoin/master 1f7695b Wladimir J. van der Laan: Merge #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck...
< bitcoin-git> bitcoin/master a7c949f fanquake: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ccc70a295fc5...1f7695b4194b
< gribble> https://github.com/bitcoin/bitcoin/issues/11621 | [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck by fanquake · Pull Request #11621 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11709 | issue : Message store directory does not exist · Issue #11709 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11648: [tests] Add messages.py (master...add_primitives_py) https://github.com/bitcoin/bitcoin/pull/11648
< bitcoin-git> bitcoin/master ccc70a2 Wladimir J. van der Laan: Merge #11648: [tests] Add messages.py...
< bitcoin-git> bitcoin/master 1135c79 John Newbery: [tests] Tidy up mininode.py module...
< bitcoin-git> bitcoin/master f9cd9b1 John Newbery: [tests] Move test_framework Bitcoin primitives into separate module...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6f8d54aff34...ccc70a295fc5
< bitcoin-git> [bitcoin] laanwj closed pull request #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) (master...fix-newPossibleKeyChange-memory-leak) https://github.com/bitcoin/bitcoin/pull/10920
< bitcoin-git> bitcoin/master f6f8d54 Wladimir J. van der Laan: Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)...
< bitcoin-git> bitcoin/master 446e261 practicalswift: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41221126c855...f6f8d54aff34
< bitcoin-git> [bitcoin] laanwj closed pull request #11702: [build] Add a script for installing db4 (master...install-db4-script) https://github.com/bitcoin/bitcoin/pull/11702
< bitcoin-git> bitcoin/master 4122112 Wladimir J. van der Laan: Merge #11702: [build] Add a script for installing db4...
< bitcoin-git> bitcoin/master 6e4cdd6 James O'Beirne: [docs] Add reference to install_db4.sh in OS X build instructions
< bitcoin-git> bitcoin/master af9103e James O'Beirne: [build] Add a script for installing db4...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/99bc0b428b03...41221126c855
< gribble> https://github.com/bitcoin/bitcoin/issues/11687 | External wallet files by ryanofsky · Pull Request #11687 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
< achow101> what does everyone think about putting various docs about things in progress and plans (e.g. sipa's wallet thing) on the wiki here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki
< bitcoin-git> [bitcoin] CryptAxe closed pull request #11098: [Qt] Add spend all button to the SendCoinsDialog (master...spendall) https://github.com/bitcoin/bitcoin/pull/11098

2017-11-16

< jtimon> weren't they using a naming just the same as bitcoin core but increasing a version? (ie 0.14.3)
< jonasschnelli> 861 peers with "Bitcoin ABC" and 100% uptime during last two hours.
< wumpus> PSA before the meeting is over: I want to collect corrupted leveldb files, if you have a leveldb corruption please patch https://github.com/bitcoin/bitcoin/pull/11674 and send me the indicated corrupted file.
< gmaxwell> change in topic, anyone have recent stats for the number of remaining btc1 nodes-- which are likely about to become a distributed DOS attack on the bitcoin network?
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11363 | net: Split socket create/connect by theuni · Pull Request #11363 · bitcoin/bitcoin · GitHub
< achow101> I have a branch for late initialiation: https://github.com/achow101/bitcoin/tree/start-no-wallet
< gribble> https://github.com/bitcoin/bitcoin/issues/11398 | Hardcode CSV and SEGWIT deployment by jl2012 · Pull Request #11398 · bitcoin/bitcoin · GitHub
< gmaxwell> jtimon: cli makes you specify it as a dashed argument to bitcoin-cli, which is a bit obnoxious but works.
< wumpus> yes, it's the same with bitcoin-cli
< wumpus> jtimon: no, agree, jonasschnelli's proposal to make it stateless and have to provide it for every command is better, that's the same as needs tobe done for bitcoin-cli
< bitcoin-git> [bitcoin] luke-jr closed pull request #10391: OP_CHECKBLOCKATHEIGHT anti-replay (BIP 115; logic only) (master...cbah) https://github.com/bitcoin/bitcoin/pull/10391
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
< wumpus> only four things left https://github.com/bitcoin/bitcoin/projects/8
< gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag
< bitcoin-git> [bitcoin] jnewbery opened pull request #11707: [tests] Fix sendheaders (master...fix_sendheaders) https://github.com/bitcoin/bitcoin/pull/11707
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
< gribble> https://github.com/bitcoin/bitcoin/issues/11686 | Make ISSUE_TEMPLATE a bit shorter, mention hardware tests by TheBlueMatt · Pull Request #11686 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11705: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11705
< bitcoin-git> [bitcoin] zhaokexun opened pull request #11705: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11705
< bitcoin-git> [bitcoin] laanwj closed pull request #10772: Implementation of BIP8 (master...bip8-height) https://github.com/bitcoin/bitcoin/pull/10772
< bitcoin-git> [bitcoin] sipsorcery opened pull request #11704: Windows build doc update (master...windoc) https://github.com/bitcoin/bitcoin/pull/11704
< bitcoin-git> [bitcoin] laanwj closed pull request #11087: Diagnose unsuitable outputs in lockunspent(). (master...lockunspent) https://github.com/bitcoin/bitcoin/pull/11087
< bitcoin-git> bitcoin/master 99bc0b4 Wladimir J. van der Laan: Merge #11087: Diagnose unsuitable outputs in lockunspent()....
< bitcoin-git> bitcoin/master 28f8b66 Eelis: Diagnose unsuitable outputs in lockunspent()....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/084f52f38dc2...99bc0b428b03
< meshcollider> kgc: I'm working on something right now here: github.com/MeshCollider/bitcoin/tree/201711_signrawtransaction_wsh
< meshcollider> sipa: It appears there is a way to use signrawtransaction with P2SH-P2WSH as-is, check out https://bitcoin.stackexchange.com/a/62746/51948
< kgc> Hi, I updated issue https://github.com/bitcoin/bitcoin/issues/11693 with some more information, while I can proceed with my implementation it's slightly tricky/confusing to use.
< kinlo> it's /join #bitcoin
< asu> join #bitcoin
< kinlo> just join #bitcoin
< asu> where is the bitcoin irc?
< kinlo> asu: that question is for #bitcoin, not for here
< asu> buy i found if my customer send 0.01bitcoin to another, the fee is 0.00027 bitcoin
< asu> i want to build a bitcoin p2p trade web
< bitcoin-git> [bitcoin] laanwj closed pull request #11654: tests: Initialize recently introduced non-static class member lastCycles to zero in constructor (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/11654
< bitcoin-git> bitcoin/master 084f52f Wladimir J. van der Laan: Merge #11654: tests: Initialize recently introduced non-static class member lastCycles to zero in constructor...
< bitcoin-git> bitcoin/master 069215e practicalswift: Initialize recently introduced non-static class member lastCycles to zero in constructor...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66d46c7901b7...084f52f38dc2
< bitcoin-git> [bitcoin] laanwj closed pull request #11699: [travis-ci] Only run linters on Pull Requests (master...lint_only_prs) https://github.com/bitcoin/bitcoin/pull/11699
< bitcoin-git> bitcoin/master 66d46c7 Wladimir J. van der Laan: Merge #11699: [travis-ci] Only run linters on Pull Requests...
< bitcoin-git> bitcoin/master ec85248 John Newbery: [travis-ci] Only run linters on Pull Requests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c098a8aa078...66d46c7901b7
< gmaxwell> But there is just an utterly stupendous amount of work required, ... the software is highly optimized (and sure, there are also still many things that could be done to make it faster). .. but e.g. compared to ethereum the amount of blockchain bitcoin core processes per second is something like two orders of magnitude greater. ( https://anduck.net/bitcoincore_vs_geth_full_node_stats.png )
< wumpus> LMDB seemed promising but I never got spectacular results, maybe I was just using it wrong, and maybe the approach of not caching at the bitcoin level would work better with it
< wumpus> I have some old utxo database experiments here: https://github.com/laanwj/bitcoin
< eck> alright, at a high level i want to know why bitcoin has a caching layer at all: there is already some caching in the kernel page cache, leveldb has some caching og it its own, and then bitcoin itself will cache data for up to 24h
< bitcoin-git> [bitcoin] laanwj closed pull request #11651: refactor: Make all #includes relative to project root (laanwj, MeshCollider, ryanofsky) (master...201711_absolute_includes) https://github.com/bitcoin/bitcoin/pull/11651
< bitcoin-git> bitcoin/master 5b56ec9 Wladimir J. van der Laan: qt: refactor: Use absolute include paths in .ui files
< bitcoin-git> bitcoin/master 0c71521 Wladimir J. van der Laan: build: Remove -I for everything but project root...
< bitcoin-git> bitcoin/master 1a44534 MeshCollider: scripted-diff: Replace #include "" with #include <> (ryanofsky)...
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/54aedc013744...3c098a8aa078
< eck> in this example you have bitcoin cache + leveldb cache + kernel page cache
< eck> random question: if leveldb already has its own WAL, then why does bitcoin need an in-memory cache/buffer for utxo updates
< bitcoin-git> [bitcoin] jamesob opened pull request #11702: [build] Add a script for installing db4 (master...install-db4-script) https://github.com/bitcoin/bitcoin/pull/11702
< gribble> https://github.com/bitcoin/bitcoin/issues/11693 | Signing raw transaction that has p2sh-p2wsh input · Issue #11693 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] willyko opened pull request #11700: Add gitian PGP key: willyko (master...master) https://github.com/bitcoin/bitcoin/pull/11700

2017-11-15

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (master...2017-11-shorter-default-issue) https://github.com/bitcoin/bitcoin/pull/11686
< bitcoin-git> bitcoin/master 54aedc0 MarcoFalke: Merge #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests...
< bitcoin-git> bitcoin/master ea3f363 Matt Corallo: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0c1f8abb018...54aedc013744
< bitcoin-git> [bitcoin] jnewbery closed pull request #11697: [trivial] remove trailing whitespace in streams.h (master...streams_trailing_whitespace) https://github.com/bitcoin/bitcoin/pull/11697
< bitcoin-git> [bitcoin] jnewbery opened pull request #11699: [travis-ci] Only run linters on Pull Requests (master...lint_only_prs) https://github.com/bitcoin/bitcoin/pull/11699
< bitcoin-git> [bitcoin] lmlsna opened pull request #11698: [Docs] [Qt] RPC-Console nested commands documentation (master...doc-rpc-console) https://github.com/bitcoin/bitcoin/pull/11698
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (master...desktop-file) https://github.com/bitcoin/bitcoin/pull/11690
< bitcoin-git> bitcoin/master f0c1f8a MarcoFalke: Merge #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it...
< bitcoin-git> bitcoin/master b077fe9 Evan Klitzke: fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ed818060ecf...f0c1f8abb018
< gribble> https://github.com/bitcoin/bitcoin/issues/11651 | refactor: Make all #includes relative to project root (laanwj, MeshCollider, ryanofsky) by MeshCollider · Pull Request #11651 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #11697: [trivial] remove trailing whitespace in streams.h (master...streams_trailing_whitespace) https://github.com/bitcoin/bitcoin/pull/11697
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid pemanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< jonasschnelli> Anyone willing to review https://github.com/bitcoin/bitcoin/pull/11281/files?w=1 ?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10600: Make feebumper class stateless (master...pr/ipc-bump) https://github.com/bitcoin/bitcoin/pull/10600
< bitcoin-git> bitcoin/master 37bdcca Russell Yanofsky: [refactor] Make feebumper namespace...
< bitcoin-git> bitcoin/master aed1d90 Russell Yanofsky: [wallet] Change feebumper from class to functions...
< bitcoin-git> bitcoin/master 7c4f009 Russell Yanofsky: [trivial] Rename feebumper variables according to project code style...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/927a1d7d088e...4ed818060ecf
< gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
< gustav> oopsie, using bitcoin-core latest version on linux (rpc, with php)
< gustav> i have one app where users are given 1 bitcoin address A, they deposit btc on A and later on they withdraw on their address B. I'd like to use segwit addresses to cut down expenses on network fees (if im getting this right). now i use getnewaddress, sendmany and rawtransactions functions. would it be possible to use $addr = getnewaddress(); $segwit
< bitcoin-git> [bitcoin] laanwj closed pull request #10286: Call wallet notify callbacks in scheduler thread (without cs_main) (master...2017-01-wallet-cache-inmempool-4) https://github.com/bitcoin/bitcoin/pull/10286
< bitcoin-git> bitcoin/master 2b4b345 Matt Corallo: Add ability to assert a lock is not held in DEBUG_LOCKORDER
< bitcoin-git> bitcoin/master 0343676 Matt Corallo: Call TransactionRemovedFromMempool in the CScheduler thread...
< bitcoin-git> bitcoin/master a7d3936 Matt Corallo: Add a CValidationInterface::TransactionRemovedFromMempool...
< bitcoin-git> [bitcoin] laanwj pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/aca77a4d58c6...927a1d7d088e
< bitcoin-git> [bitcoin] practicalswift opened pull request #11694: rpc: Add missing cs_main lock in getblocktemplate(...) (master...missing-lock-in-getblocktemplate) https://github.com/bitcoin/bitcoin/pull/11694
< bitcoin-git> [bitcoin] practicalswift closed pull request #11691: rpc: Add missing lock in getblocktemplate(...). Work around Clang thread safety analysis quirks. (master...rpc-locking) https://github.com/bitcoin/bitcoin/pull/11691
< sipa> try #bitcoin
< bitcoin-git> [bitcoin] laanwj closed pull request #11655: net: Assert state.m_chain_sync.m_work_header in ConsiderEviction (master...m_chain_sync.m_work_header) https://github.com/bitcoin/bitcoin/pull/11655
< bitcoin-git> bitcoin/master aca77a4 Wladimir J. van der Laan: Merge #11655: net: Assert state.m_chain_sync.m_work_header in ConsiderEviction...
< bitcoin-git> bitcoin/master 63c2d83 practicalswift: Explicitly state assumption that state.m_chain_sync.m_work_header != nullptr in ConsiderEviction...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4db82b7aab4a...aca77a4d58c6
< gribble> https://github.com/bitcoin/bitcoin/issues/11646 | Require a steady clock for bench with at least micro precision by TheBlueMatt · Pull Request #11646 · bitcoin/bitcoin · GitHub
< kgc> well, it's slightly weird because if I create corresponding deposit address and import it inside bitcoin core wallet, I can send to and spend funds without anyproblems
< bitcoin-git> [bitcoin] practicalswift closed pull request #11692: Remove unused Boost include. Move Boost include. (master...remove-boost-includes) https://github.com/bitcoin/bitcoin/pull/11692
< bitcoin-git> [bitcoin] practicalswift opened pull request #11692: Remove unused Boost include. Move Boost include. (master...remove-boost-includes) https://github.com/bitcoin/bitcoin/pull/11692
< meshcollider> You should probably discuss it in #bitcoin not this channel
< meshcollider> Guest27291: this is not the place, but segwit2x was called off https://lists.linuxfoundation.org/pipermail/bitcoin-segwit2x/2017-November/000685.html
< bitcoin-git> [bitcoin] practicalswift opened pull request #11691: rpc: Add missing lock in getblocktemplate(...). Work around Clang thread safety analysis quirks. (master...rpc-locking) https://github.com/bitcoin/bitcoin/pull/11691
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] eklitzke opened pull request #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (master...desktop-file) https://github.com/bitcoin/bitcoin/pull/11690
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #11680: [docs] Add instructions for lcov report generation (master...lcov-docs) https://github.com/bitcoin/bitcoin/pull/11680
< bitcoin-git> bitcoin/master 4db82b7 Jonas Schnelli: Merge #11680: [docs] Add instructions for lcov report generation...
< bitcoin-git> bitcoin/master 5ff01c2 James O'Beirne: [docs] Add instructions for lcov coverage report generation
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3bdf242fc68a...4db82b7aab4a
< eck> if any of you use fedora, I just set up a bitcoin rpm repo based mostly on the existing spec file in the contrib/ directory, feel free to help me test it or give me feedback: https://copr.fedorainfracloud.org/coprs/eklitzke/bitcoin/
< sipa> your bitcoin node rumoured that address around
< Tatty> only the second does and it is Bitcoin Core who creates it
< sipa> your bitcoin client rumours its addresses to other peers, including onion addresses if it knows th
< Tatty> incomming to the hidden service created by Bitcoin Core on tor proxy 2
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< Tatty> no, they are conecting to the seconf one, managed by bitcoin-qt
< Tatty> I run 2 different ptor proxies as allowed by Bitcoin Core 0.15.0.1
< Tatty> I think I found an outdated version User Agent on Bitcoin Core 64 bit for Windows v0.15.0.1. I enabled 2 tor proxies, both making bidirectional connections. It happened one of the proxies contacted the other, and that's when I saw a wrong version: User Agent /Satoshi:0.14.0/

2017-11-14

< gmaxwell> There is some layout tension on that; abstracting consensus rules can make them more opaque and harder to review; and bitcoin core is not an altcoin construction set. :) OTOH, sometimes moving things around makes things more clear, enables better testing harnesses, etc.
< karelb> hm, doing refactoring like that seems like an easy way to get some cheap commits in bitcoin core code :D
< karelb> Question about bitcoin-core - why is validation.h/.cpp so "overloaded"? It seems to me half of the things in there don't have to do much with validation
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11677: qa: Remove unused NodeConn members (master...Mf1711-qaMininodeUnused) https://github.com/bitcoin/bitcoin/pull/11677
< bitcoin-git> bitcoin/master 3bdf242 MarcoFalke: Merge #11677: qa: Remove unused NodeConn members...
< bitcoin-git> bitcoin/master fafdad0 MarcoFalke: qa: Remove unused NodeConn members
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d4821b693b2...3bdf242fc68a
< bitcoin-git> [bitcoin] practicalswift opened pull request #11689: Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins) (master...CTxMemPool-check) https://github.com/bitcoin/bitcoin/pull/11689
< Nobody_> Everything ECDSA Public Key (Bitcoin Compatible): 1N2EWy7LroJVFYXtmYZryh7W9eV3k6qajd exists since Mon Oct 02 2017 23:48:19 GMT-0700 (Pacific Daylight Time)
< LumberCartel> Nobody_: You should raise your concerns in the #bitcoin channel rather than in this channel.
< Nobody_> also a Faucet in the core is needed for Nobody to send Bitcoin to the requested wallet of your choice, for reasons if it is not avaliable from anyone else the system will continue to function appropriately.
< Nobody_> If anybody could get a message to the Bitcoin Core Developers to add the Mining back into the Core that would be perfect, ASIC is not needed to mine and is outdated plus not as power efficient
< Nobody_> i just wanted to state that i am requesting as a System that nobody owns and if you abuse the system you abuse yourself some upgrades that need to happen for the Bitcoin Core
< bitcoin-git> [bitcoin] ryanofsky opened pull request #11687: External wallet files (master...pr/wfile) https://github.com/bitcoin/bitcoin/pull/11687
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (master...2017-11-shorter-default-issue) https://github.com/bitcoin/bitcoin/pull/11686
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
< bitcoin-git> [bitcoin] laanwj closed pull request #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu" (master...ubutntu) https://github.com/bitcoin/bitcoin/pull/11684
< bitcoin-git> bitcoin/master 6d4821b Wladimir J. van der Laan: Merge #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu"...
< bitcoin-git> bitcoin/master d8ac893 practicalswift: trivial: Fix typo – "Ubutntu" → "Ubuntu"
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7adeea3b0fc2...6d4821b693b2
< bitcoin-git> [bitcoin] practicalswift opened pull request #11683: tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) (master...remove-int-vector-serialization) https://github.com/bitcoin/bitcoin/pull/11683
< meshcollider> Anyone wanna review https://github.com/bitcoin-core/bitcoincore.org/pull/464 so it can be merged soon?
< bitcoin-git> [bitcoin] practicalswift opened pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
< bitcoin-git> [bitcoin] laanwj closed pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
< bitcoin-git> [bitcoin] SwaddleDoddle opened pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
< bitcoin-git> [bitcoin] laanwj closed pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
< bitcoin-git> bitcoin/master 7adeea3 Wladimir J. van der Laan: Merge #11641: qa: Only allow disconnecting all NodeConns...
< bitcoin-git> [bitcoin] laanwj closed pull request #11641: qa: Only allow disconnecting all NodeConns (master...Mf1711-qaNodeConnDisconnectAll) https://github.com/bitcoin/bitcoin/pull/11641
< bitcoin-git> bitcoin/master faaa7db MarcoFalke: qa: Only allow disconnecting all NodeConns
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbb54e77a120...7adeea3b0fc2
< eck> just thinking out loud here, but you could train a simple convolutional filter (for example) to learn the best parameters to estimate a fee rate given the fee histogram from the last N time periods; but you'd have to update the convolution parameters for each bitcoin release, and it would be trivial to find pathological values after the fact to trick the trained algorithm
< bitcoin-git> bitcoin/master cbb54e7 Wladimir J. van der Laan: Merge #11533: Docs: Update WSL installation notes for Fall Creators update...
< bitcoin-git> bitcoin/master 73a7e6d Thoragh: Update WSL installation for Fall Creators update
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e468994fbb3...cbb54e77a120
< bitcoin-git> [bitcoin] jamesob opened pull request #11680: [docs] Add instructions for lcov report generation (master...lcov-docs) https://github.com/bitcoin/bitcoin/pull/11680
< bitcoin-git> [bitcoin] Thoragh reopened pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
< bitcoin-git> [bitcoin] Thoragh closed pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
< sipa> tloriato: let's move to #bitcoin-wizards
< bitcoin-git> [bitcoin] achow101 opened pull request #11678: [wip][wallet] Don't shut down after encrypting the wallet (master...encrypt-no-restart) https://github.com/bitcoin/bitcoin/pull/11678

2017-11-13

< gribble> https://github.com/bitcoin/bitcoin/issues/4416 | testnet4 · Issue #4416 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11677: qa: Remove unused NodeConn members (master...Mf1711-qaMininodeUnused) https://github.com/bitcoin/bitcoin/pull/11677
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11676: contrib/init: Update openrc-run filename (master...openrc-run) https://github.com/bitcoin/bitcoin/pull/11676
< bitcoin-git> bitcoin/master 2f041f0 Luke Dashjr: contrib/init: Update openrc-run filename...
< bitcoin-git> bitcoin/master 5e46899 MarcoFalke: Merge #11676: contrib/init: Update openrc-run filename...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41aa9c4a801a...5e468994fbb3
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11663: [trivial] doc: Add getreceivedbyaddress release notes (master...Mf1711-docReleaseNotes16) https://github.com/bitcoin/bitcoin/pull/11663
< achow101> could someone help me debug some locks on https://github.com/achow101/bitcoin/tree/encrypt-no-restart? That branch is for encrypting wallets without restarting, and something in the GUI part is holding cs_KeyStore causing the GUI to freeze
< ryanofsky> eck: re "multi-process bitcoin core" see https://eklitzke.org/multiprocess-bitcoin and prs 10102, 10244, 10973
< bitcoin-git> [bitcoin] laanwj closed pull request #11035: [contrib] Add Valgrind suppressions file (master...valgrind-suppressions) https://github.com/bitcoin/bitcoin/pull/11035
< bitcoin-git> bitcoin/master 927e528 Wladimir J. van der Laan: Merge #11035: [contrib] Add Valgrind suppressions file...