2017-09-28

< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d90a00eabed0...c9a4aa8a0e7e
< gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #11412: Simplify GetWarnings() (master...2017/09/getwarnings) https://github.com/bitcoin/bitcoin/pull/11412
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #11397: net: Improve and document SOCKS code (master...2017_09_socks_refactor) https://github.com/bitcoin/bitcoin/pull/11397
< bitcoin-git> bitcoin/master d90a00e Jonas Schnelli: Merge #11397: net: Improve and document SOCKS code...
< bitcoin-git> bitcoin/master 22f816e Wladimir J. van der Laan: net: Improve and document SOCKS code...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef8340d25f7c...d90a00eabed0
< bitcoin-git> [bitcoin] jimpo opened pull request #11411: script: Change SignatureHash input index check to an assert. (master...sighash-bounds-check) https://github.com/bitcoin/bitcoin/pull/11411
< jimpo> Why is this check for input index out of bounds below the BIP 143 sighash handling? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1223

2017-09-27

< bitcoin-git> [bitcoin] mess110 opened pull request #11410: [rpc] [tests] Add minrelaytxfee to getmempoolinfo (master...add_minrelaytxfee_to_getmempoolinfo) https://github.com/bitcoin/bitcoin/pull/11410
< instagibbs> wraithm, https://github.com/bitcoin/bitcoin/pull/9728 does hd watchonly, but as sipa said, how it interacts with stuff is non-trivial. I think a lot of the corner-cases go away post-overhaul
< Dizzle> Alternatively, the Core RPC server and Qt GUI have implementations that use CHashWriter - https://github.com/bitcoin/bitcoin/blob/791a0e6ddade27d1b69f4861a6640de60b9553cf/src/wallet/rpcwallet.cpp#L609
< Dizzle> kebman: electrum's is fairly readable: https://github.com/spesmilo/electrum/blob/master/lib/bitcoin.py#L709
< kebman> Any technical documentation on how Bitcoin signs messages?
< kebman> Can anyone guide me to good resources on how to programmatically sign messages with a Bitcoin address?
< jnewbery> boltzar: please ask at #bitcoin or https://bitcoin.stackexchange.com/ . This is a channel for discussing Bitcoin Core development
< boltzar> is: on my bitcoind server after i make 25 unconfirmed transactions they stop showing on blockchain.info for example untill they confirm ( the payments are made because i can see the tx hashes ) . Now i use another bitcoin api from block.io . Using their api i can make the same a lot of unconfirmed transactions , but their transactions are showing on blockchain.info even if there are
< boltzar> hello guys. i have a small issue. i own an exchange website and i usually use bitcoind to send the bitcoin to my clients. With these problems in the bitcoin network sometimes i have activated these options walletrejectlongchains=false , limitancestorcount=1000 , limitdescendantcount=1000 . If i didn't activate these my api would stop working on 25 unconfirmed transactions . The issue
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11031: [rpc] deprecate estimatefee (master...deprecate_estimatefee) https://github.com/bitcoin/bitcoin/pull/11031
< bitcoin-git> bitcoin/master ef8340d MarcoFalke: Merge #11031: [rpc] deprecate estimatefee...
< bitcoin-git> bitcoin/master d4cdbd6 John Newbery: [rpc] Deprecate estimatefee RPC...
< bitcoin-git> bitcoin/master 048e0c3 Cristian Mircea Messel: [rpc] [tests] Add deprecated RPC test
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/69c7ecef405d...ef8340d25f7c
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11408: Trivial: Fix parameter name typo in ErasePurpose walletdb method (master...walletdb-typo) https://github.com/bitcoin/bitcoin/pull/11408
< bitcoin-git> bitcoin/master 69c7ece MarcoFalke: Merge #11408: Trivial: Fix parameter name typo in ErasePurpose walletdb method...
< bitcoin-git> bitcoin/master 603efe9 Pierre Rochard: Fix parameter name typo in ErasePurpose walletdb method.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2505c5c0a9f8...69c7ecef405d
< gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub

2017-09-26

< CryptAxe> So they can still deserialize the transaction? Cool, I think this part: https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L204-L212 made me think that they would have an empty vin and it would be invalid
< bitcoin-git> [bitcoin] PierreRochard opened pull request #11408: Trivial: Fix parameter name typo in ErasePurpose walletdb method (master...walletdb-typo) https://github.com/bitcoin/bitcoin/pull/11408
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #11015: [Qt] Add delay before filtering transactions (master...searchDelay) https://github.com/bitcoin/bitcoin/pull/11015
< bitcoin-git> bitcoin/master 2505c5c Jonas Schnelli: Merge #11015: [Qt] Add delay before filtering transactions...
< bitcoin-git> bitcoin/master 7b137ac Lucas Betschart: [Qt] Add delay before filtering transactions...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc597bb895ef...2505c5c0a9f8
< bitcoin-git> [bitcoin] instagibbs opened pull request #11407: add functional test for mempoolreplacement command line arg (master...testmempoolreplacearg) https://github.com/bitcoin/bitcoin/pull/11407
< promag> achow101: in https://github.com/bitcoin/bitcoin/pull/10583/commits/8d5d4cf4c3077e8f3269fab3b98da7413e100081 commit message there is a double space. Also, Validateaddress should always be lowercase?
< jtimon> does anybody use -mempoolreplacement=0 ? would it make sense to do https://github.com/ElementsProject/elements/pull/248 in bitcoin ?
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11406: Add state message print to AcceptBlock failure message. (master...2017-09-checkblock-fail-print) https://github.com/bitcoin/bitcoin/pull/11406
< gmaxwell> jtimon: Making everything use the same rpc port means you cannot run testnet and bitcoin at the same time anymore except through manually configuring them.
< jtimon> esotericnonsense: for bitcoin-cli, specifying -testnet does the same as -rpcport=18332, if you specify rpcport, specifying -testnet is completely meaningless
< gribble> https://github.com/bitcoin/bitcoin/issues/11404 | RPC: Chainparams: Simplify -rpcport and CBaseMainParams by jtimon · Pull Request #11404 · bitcoin/bitcoin · GitHub
< sipa> with the bias, that can pretty much only happen for P2P default port, which is very unlikely to have any interesting services running, other than bitcoin :)
< sipa> jtimon: otherwise you can spam the network with addr messages for services you don't like, and get the whole bitcoin network to try connecting to them
< bitcoin-git> [bitcoin] jtimon closed pull request #11404: RPC: Chainparams: Simplify -rpcport and CBaseMainParams (master...b16-chainparams-rpcport) https://github.com/bitcoin/bitcoin/pull/11404
< bitcoin-git> [bitcoin] laanwj closed pull request #11225: wallet: update stored witness in AddToWallet (master...2017-09-update-tx-witness) https://github.com/bitcoin/bitcoin/pull/11225
< bitcoin-git> bitcoin/master dc597bb Wladimir J. van der Laan: Merge #11225: wallet: update stored witness in AddToWallet...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f8e09599db6...dc597bb895ef
< bitcoin-git> bitcoin/master d01a968 Suhas Daftuar: wallet: update stored witness in AddToWallet...
< bitcoin-git> [bitcoin] laanwj closed pull request #11288: More user-friendly error message when partially signing (master...201709_partial_sign_error) https://github.com/bitcoin/bitcoin/pull/11288
< bitcoin-git> bitcoin/master 0f8e095 Wladimir J. van der Laan: Merge #11288: More user-friendly error message when partially signing...
< bitcoin-git> bitcoin/master df10edf MeshCollider: More user-friendly error message when partially signing
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67879b7c4431...0f8e09599db6
< bitcoin-git> [bitcoin] laanwj closed pull request #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds (master...2017-09-bitcoin-tx-uncompressed-segwit) https://github.com/bitcoin/bitcoin/pull/11377
< bitcoin-git> bitcoin/master 67879b7 Wladimir J. van der Laan: Merge #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds...
< bitcoin-git> bitcoin/master 28d4542 Matt Corallo: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8cf88b4aaeaf...67879b7c4431
< bitcoin-git> [bitcoin] jtimon opened pull request #11404: RPC: Chainparams: Simplify -rpcport and CBaseMainParams (master...b16-chainparams-rpcport) https://github.com/bitcoin/bitcoin/pull/11404
< gribble> https://github.com/bitcoin/bitcoin/issues/10783 | [RPC] Various rpc argument fixes by instagibbs · Pull Request #10783 · bitcoin/bitcoin · GitHub
< analiser> look like #10783 041dad9 RCP Various rpc argument fixes(instagiibbs) in the 0.15 channelog is what cause some errors in python bicoinlib module i just solve the issue removing from module bitcoin SelectParams() attribute and from bitcoin.rpc remove Proxy() attribute hope that work for any here
< bitcoin-git> [bitcoin] sipa opened pull request #11403: SegWit wallet support (master...201709_segwitwallet2) https://github.com/bitcoin/bitcoin/pull/11403

2017-09-25

< gmaxwell> I think for the vast majority of bitcoin users -- bitcoin is the only open source thing they've ever looked at in any detail.
< bitcoin-git> [bitcoin] promag opened pull request #11402: [wallet] Use shared pointer for wallet instances (master...2017-09-wallet-shared-pointer) https://github.com/bitcoin/bitcoin/pull/11402
< gmaxwell> ::sigh:: yet another person on reddit spreading the idea that btc1 need only get more hashrate and we'll move over to developing it: https://www.reddit.com/r/Bitcoin/comments/72esf4/supporting_segwit2x_btc1_equals_abandoning_btc/dnhzawn/ Bluematt and I have responded saying nope. If a few more people did it would become something good to link to.
< sipa> it has nothing to do with bitcoin core
< analiser> and bitcoin.rpc no att Proxy() anymore
< analiser> bitcoin module no object has no attribute 'SelectParams'
< analiser> any advise to handle bitcoin node in python will be appreciate
< analiser> python modules bitcoin & bitcoin.rpc going weird in new core versions
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11401: doc: move gitian building to external repo (master...Mf1708-docGitianFedora) https://github.com/bitcoin/bitcoin/pull/11401
< bitcoin-git> [bitcoin] jl2012 opened pull request #11400: [wallet] Remove segwit status check (master...postsegwitwallet) https://github.com/bitcoin/bitcoin/pull/11400
< bitcoin-git> [bitcoin] laanwj closed pull request #11335: Replace save|restoreWindowGeometry with Qt functions (master...201709_fix_offscreen_2) https://github.com/bitcoin/bitcoin/pull/11335
< bitcoin-git> [bitcoin] laanwj closed pull request #11370: [test] Add getblockchaininfo functional test (master...2017-09-add-getblockchaininfo-functional-test) https://github.com/bitcoin/bitcoin/pull/11370
< bitcoin-git> bitcoin/master f6ffb14 João Barbosa: [test] Add getblockchaininfo functional test
< bitcoin-git> bitcoin/master 2d85899 Wladimir J. van der Laan: Merge #11370: [test] Add getblockchaininfo functional test...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a3b4c5943b31...2d858993035f
< bitcoin-git> bitcoin/master fd8f45f João Barbosa: [test] Add restart_node to BitcoinTestFramework
< bitcoin-git> [bitcoin] jl2012 opened pull request #11399: Fix bip68-sequence rpc test (master...bip68test-1) https://github.com/bitcoin/bitcoin/pull/11399
< bitcoin-git> [bitcoin] jl2012 opened pull request #11398: Hardcode CSV deployment (master...csvburied) https://github.com/bitcoin/bitcoin/pull/11398
< bitcoin-git> [bitcoin] laanwj opened pull request #11397: net: Improve and document SOCKS code (master...2017_09_socks_refactor) https://github.com/bitcoin/bitcoin/pull/11397
< bitcoin-git> [bitcoin] laanwj closed pull request #11392: Fix stale link in gitian-building.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11392
< bitcoin-git> bitcoin/master a3b4c59 Wladimir J. van der Laan: Merge #11392: Fix stale link in gitian-building.md...
< bitcoin-git> bitcoin/master 204cc98 Shooter: fix link error...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12ed800ab870...a3b4c5943b31
< bitcoin-git> [bitcoin] luke-jr opened pull request #11395: Qt: Enable searching by transaction id (master...gui_search_txid) https://github.com/bitcoin/bitcoin/pull/11395
< sipa> (that's how i found and constructed https://github.com/bitcoin-core/secp256k1/pull/478)
< bitcoin-git> [bitcoin] sipa opened pull request #11394: Perform a weaker subtree check in Travis (master...201709_travis_subtree) https://github.com/bitcoin/bitcoin/pull/11394
< bitcoin-git> [bitcoin] fanquake closed pull request #11369: doc: Document locks - increase LOCK(...) comment coverage from 2 % to 77 % (master...lock-comments) https://github.com/bitcoin/bitcoin/pull/11369
< bitcoin-git> [bitcoin] fanquake closed pull request #10884: Added fix for wrong PATH to build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10884
< bitcoin-git> [bitcoin] sipa closed pull request #11390: [docs] document scripted-diff (master...document_scripted_diff) https://github.com/bitcoin/bitcoin/pull/11390
< bitcoin-git> bitcoin/master 12ed800 Pieter Wuille: Merge #11390: [docs] document scripted-diff...
< bitcoin-git> bitcoin/master 90ab62c John Newbery: [docs] document scripted-diff
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/10a20bf7700e...12ed800ab870

2017-09-24

< bitcoin-git> [bitcoin] shooterman opened pull request #11392: Fix link error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11392
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11391: Remove lxcbr0 lines from gitian-build.sh (master...201709_gitian_script_fix) https://github.com/bitcoin/bitcoin/pull/11391

2017-09-23

< bitcoin-git> [bitcoin] jnewbery opened pull request #11390: [docs] document scripted-diff (master...document_scripted_diff) https://github.com/bitcoin/bitcoin/pull/11390
< bitcoin-git> [bitcoin] laanwj closed pull request #11338: qt: Backup former GUI settings on `-resetguisettings` (master...2017_10_backup_resetguisettings) https://github.com/bitcoin/bitcoin/pull/11338
< bitcoin-git> bitcoin/master 10a20bf Wladimir J. van der Laan: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`...
< bitcoin-git> bitcoin/master 723aa1b Wladimir J. van der Laan: qt: Backup former GUI settings on `-resetguisettings`...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aeed345c9bad...10a20bf7700e
< bitcoin-git> [bitcoin] sipa opened pull request #11389: Support having SegWit always active in regtest (master...201709_itsalwayssegwitinregtestia) https://github.com/bitcoin/bitcoin/pull/11389
< luke-jr> jonasschnelli: https://github.com/bitcoin/bips/pull/592 fix readme?
< achow101> esotericnonsense: I think it has a higher probability of syncing than my bitcoin 0.1.0 node does
< achow101> bitcoind or bitcoin-qt?
< gribble> https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa · Pull Request #11167 · bitcoin/bitcoin · GitHub

2017-09-22

< bitcoin-git> [bitcoin] sipa closed pull request #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck (master...combine_script_amount) https://github.com/bitcoin/bitcoin/pull/10953
< bitcoin-git> bitcoin/master 3a131b7 Johnson Lau: Rename out to m_tx_out in CScriptCheck
< bitcoin-git> bitcoin/master aeed345 Pieter Wuille: Merge #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck...
< bitcoin-git> bitcoin/master e912118 Johnson Lau: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6223b3daab0...aeed345c9bad
< bitcoin-git> [bitcoin] theuni opened pull request #11387: net: remove more CConnman globals (master...more-connman-params) https://github.com/bitcoin/bitcoin/pull/11387
< bitcoin-git> [bitcoin] sipa closed pull request #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used. (master...2017_09_rm_nBlockMaxSize) https://github.com/bitcoin/bitcoin/pull/11362
< bitcoin-git> bitcoin/master c6223b3 Pieter Wuille: Merge #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used....
< bitcoin-git> bitcoin/master 22fd04b Gregory Maxwell: Remove nBlockMaxSize from miner opt struct as it is no longer used.
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/877678710800...c6223b3daab0
< bitcoin-git> [bitcoin] sipa closed pull request #11301: add m_added_nodes to connman options (master...addnode) https://github.com/bitcoin/bitcoin/pull/11301
< bitcoin-git> bitcoin/master 35e5c22 Marko Bencun: remove unused IsArgSet check...
< bitcoin-git> bitcoin/master 8776787 Pieter Wuille: Merge #11301: add m_added_nodes to connman options...
< bitcoin-git> bitcoin/master 6059182 Marko Bencun: add m_added_nodes to connman options
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/94c9015bca86...877678710800
< ossifrage> gmaxwell, it doesn't seem to be IO or CPU bound, but I am using spinning rust, it seemed wasteful to eat up a large % of my ssd on bitcoin
< ossifrage> gmaxwell, I had a 4G dbcache which was part of the reason the oom killer picked on bitcoin
< ossifrage> That is really annoying chrome decided to eat up all the memory, but the oom killer took out bitcoin (while doing a reindex) and somehow the progress went from 99ish% to 85%, that is quite a bit of rollback
< gribble> https://github.com/bitcoin/bitcoin/issues/11335 | Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
< achow101> with old versions of bitcoin (e.g. 0.1.0), what happens if they receive blocks out of order?
< bitcoin-git> [bitcoin] runn1ng opened pull request #11386: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (master...univalue_bikeshed) https://github.com/bitcoin/bitcoin/pull/11386
< achow101> i.e. can't run bitcoin-qt
< achow101> thomas__: use linux and read the Bitcoin Core docs
< achow101> and apparently bitcoin.org's docs are wrong
< achow101> .... wow. I managed to get bitcoin 0.1.0 to start syncing off of Core 0.15.99
< gribble> https://github.com/bitcoin/bitcoin/issues/10615 | RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet (multiwallet RPC support) by luke-jr · Pull Request #10615 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj reopened pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
< gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
< bitcoin-git> bitcoin/master 94c9015 Wladimir J. van der Laan: Merge #11385: Remove some unused functions and methods...
< bitcoin-git> bitcoin/master 46c9043 Pieter Wuille: Remove some unused functions and methods...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/390771be6276...94c9015bca86
< bitcoin-git> [bitcoin] laanwj closed pull request #11380: Remove outdated share/certs/ directory (master...201709_remove_old_certs) https://github.com/bitcoin/bitcoin/pull/11380
< bitcoin-git> bitcoin/master 390771b Wladimir J. van der Laan: Merge #11380: Remove outdated share/certs/ directory...
< bitcoin-git> bitcoin/master 6951a1c MeshCollider: Remove extremely outdated share/certs dir
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c4fecfaf7be...390771be6276
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11343: added `-walletallowsymboliclink` (default false) (0.15...wallet-allow-symbolic-link) https://github.com/bitcoin/bitcoin/pull/11343
< bitcoin-git> [bitcoin] sipa opened pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
< bitcoin-git> [bitcoin] sipa closed pull request #11351: Refactor: Modernize disallowed copy constructors/assignment (master...refactor/modernize-no-copy) https://github.com/bitcoin/bitcoin/pull/11351
< bitcoin-git> bitcoin/master 6c4fecf Pieter Wuille: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment...
< bitcoin-git> bitcoin/master 2a07f87 Dan Raviv: Refactor: Modernize disallowed copy constructors/assignment...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/49f3d57eeb66...6c4fecfaf7be
< bitcoin-git> [bitcoin] Gazer022 closed pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384
< bitcoin-git> [bitcoin] Gazer022 opened pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384

2017-09-21

< bitcoin-git> [bitcoin] luke-jr opened pull request #11383: Basic Multiwallet GUI support (master...multiwallet_gui) https://github.com/bitcoin/bitcoin/pull/11383
< gribble> https://github.com/bitcoin/bitcoin/issues/10615 | RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet (multiwallet RPC support) by luke-jr · Pull Request #10615 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #11116: [script] Unit tests for script/standard and IsMine functions. (master...script-standard-tests) https://github.com/bitcoin/bitcoin/pull/11116
< bitcoin-git> bitcoin/master 49f3d57 Wladimir J. van der Laan: Merge #11116: [script] Unit tests for script/standard and IsMine functions....
< bitcoin-git> bitcoin/master 7a1e873 Jim Posen: [script] Unit tests for IsMine...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/98212745c8ac...49f3d57eeb66
< bitcoin-git> bitcoin/master d7afe2d Jim Posen: [script] Unit tests for script/standard functions
< gribble> https://github.com/bitcoin/bitcoin/issues/11116 | [script] Unit tests for script/standard and IsMine functions. by jimpo · Pull Request #11116 · bitcoin/bitcoin · GitHub
< wumpus> sipa: achow101: seems it's missing here https://bitcoin.org/en/developer-reference#protocol-versions
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7533 | RPC: sendrawtransaction: Allow the user to ignore/override specific rejections by luke-jr · Pull Request #7533 · bitcoin/bitcoin · GitHub
< wumpus> importing keys in bitcoin core is considered advanced functionality anyhow
< gribble> https://github.com/bitcoin/bitcoin/issues/11372 | Address encoding cleanup by sipa · Pull Request #11372 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa · Pull Request #11167 · bitcoin/bitcoin · GitHub
< gmaxwell> China blocking bitcoin?
< gribble> https://github.com/bitcoin/bitcoin/issues/11031 | [rpc] deprecate estimatefee by jnewbery · Pull Request #11031 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11031 | [rpc] deprecate estimatefee by jnewbery · Pull Request #11031 · bitcoin/bitcoin · GitHub
< achow101> we could move the repo to bitcoin-core and break all of those guides :)
< BlueMatt> sipa: heh, if we make it not build from bitcoin/bitcoin, ok
< sipa> wumpus: an alternative would be to have a bitcoin-releases repo (under the same org), to which only release tags get pushed
< gribble> https://github.com/bitcoin/bitcoin/issues/11031 | [rpc] deprecate estimatefee by jnewbery · Pull Request #11031 · bitcoin/bitcoin · GitHub
< luke-jr> Maybe `bitcoin-cli getinfo` should print a message informing the user about the new RPCs, like we did when bitcoind client got deprecated
< gribble> https://github.com/bitcoin/bitcoin/issues/10871 | Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) by achow101 · Pull Request #10871 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11381: Update .travis.yml (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11381
< bitcoin-git> [bitcoin] aqibbak opened pull request #11381: Update .travis.yml (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11381
< kallewoof> Someone wrote a post about that on reddit. One of the devs said two weeks I think. (LN is actually not bitcoin core, but a separate client entirely.)
< achow101> I wonder if gavin made bitcoin xt or bitcoin classic releases signed with that key...
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11380: Remove outdated share/certs/ directory (master...201709_remove_old_certs) https://github.com/bitcoin/bitcoin/pull/11380
< kallewoof> Would it be worth it to add a replay protection mechanism in Bitcoin where a NOP is replaced with <height> <blockhash> OP_CHECKBLOCKVERIFY which would fail if the hash of the block at the given height did not match <blockhash>? (It would probably require that <height> was less than <current height> - 100 to avoid nasty double spends at reorgs...)
< bitcoin-git> [bitcoin] fanquake closed pull request #11378: Update COPYING (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11378
< bitcoin-git> [bitcoin] btc1-prevention opened pull request #11378: Update COPYING (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11378
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds (master...2017-09-bitcoin-tx-uncompressed-segwit) https://github.com/bitcoin/bitcoin/pull/11377

2017-09-20

< bitcoin-git> [bitcoin] sipa closed pull request #10888: range-based loops and const qualifications in net.cpp (master...netcpp_cosmetics2) https://github.com/bitcoin/bitcoin/pull/10888
< bitcoin-git> bitcoin/master 05cae8a Marko Bencun: range-based loops and const qualifications in net.cpp...
< bitcoin-git> bitcoin/master 9821274 Pieter Wuille: Merge #10888: range-based loops and const qualifications in net.cpp...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/551d7bf604fb...98212745c8ac
< bitcoin-git> [bitcoin] tomasvdw opened pull request #11376: Ensure backupwallet fails when attempting to backup to source file (master...core) https://github.com/bitcoin/bitcoin/pull/11376
< meshcollider> adiabat: that's because it was given a BIP number 174 and moved filename, it's here now: https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki
< ThomasV> well, p2pk is a bit different, because you do not create a bitcoin address for it
< bitcoin-git> [bitcoin] laanwj closed pull request #11132: Document assumptions that are being made to avoid NULL pointer dereferences (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/11132
< bitcoin-git> bitcoin/master 551d7bf Wladimir J. van der Laan: Merge #11132: Document assumptions that are being made to avoid NULL pointer dereferences...
< bitcoin-git> bitcoin/master fdc3293 practicalswift: Document assumptions that are being made to avoid NULL pointer dereferences
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/28474802758a...551d7bf604fb
< bitcoin-git> bitcoin/master 2847480 Wladimir J. van der Laan: Merge #11305: [doc] Update release notes and manpages for 0.16...
< bitcoin-git> [bitcoin] laanwj closed pull request #11305: [doc] Update release notes and manpages for 0.16 (master...Mf1709-doc016) https://github.com/bitcoin/bitcoin/pull/11305
< bitcoin-git> bitcoin/master fa65dcd MarcoFalke: doc: Update release notes for 0.16.0
< bitcoin-git> bitcoin/master fa2c3b6 MarcoFalke: doc: Bump manpages to 0.15.99
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/44313d82508b...28474802758a
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< wumpus> BlueMatt: boost::filesystem::create_directory: Permission denied: "/home/user/.bitcoin" seems clear enough to me
< bitcoin-git> [bitcoin] laanwj closed pull request #11334: qt: Remove custom fee radio group and remove nCustomFeeRadio setting (master...rm-nCustomFeeRadio) https://github.com/bitcoin/bitcoin/pull/11334
< bitcoin-git> bitcoin/master 44313d8 Wladimir J. van der Laan: Merge #11334: qt: Remove custom fee radio group and remove nCustomFeeRadio setting...
< bitcoin-git> bitcoin/master e53fa4a Andrew Chow: Remove custom fee radio group...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f7e37e26c5d...44313d82508b
< BlueMatt> https://github.com/bitcoin/bitcoin/issues/11373 should just be closed with "Your filesystem permissions have been set to prevent bitcoind from accessing its datadir, which prevents it from starting" (unless someone wants to change it to a "we need a better error message for this bug" issue)
< gribble> https://github.com/bitcoin/bitcoin/issues/11367 | [rpc] getblockchaininfo: add size_on_disk, prune_target_size by esotericnonsense · Pull Request #11367 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] esotericnonsense closed pull request #11366: [rpc] Fix pruneheight help description in getblockchaininfo (master...2017-09-getblockchaininfo-docs) https://github.com/bitcoin/bitcoin/pull/11366
< gribble> https://github.com/bitcoin/bitcoin/issues/11366 | [rpc] Fix pruneheight help description in getblockchaininfo by esotericnonsense · Pull Request #11366 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11370 | [test] Add getblockchaininfo functional test by promag · Pull Request #11370 · bitcoin/bitcoin · GitHub
< meshcollider> Guest81071: try asking in #bitcoin - this chat is only for discussion on bitcoin core development not general development
< Guest81071> how can i develop or contribute to bitcoin
< Guest81071> can i get any useful ideas to implement to develop bitcoin
< kallewoof> Reading the OP_RETURNTRUE discussion on bitcoin-dev it struck me that if we bump segwit script version at some point, old nodes will all accept the tx without looking, and new nodes will use the new script to verify. A miner running old version could mine txs with invalid scripts and old nodes would accept this block while new nodes would not. This would become a hardfork, no?
< bitcoin-git> [bitcoin] fanquake closed pull request #11374: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11374
< bitcoin-git> [bitcoin] Reagent1981 opened pull request #11374: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11374
< bitcoin-git> [bitcoin] sipa opened pull request #11372: Address encoding cleanup (master...201709_addr_cleanup) https://github.com/bitcoin/bitcoin/pull/11372

2017-09-19

< bitcoin-git> [bitcoin] promag opened pull request #11370: [test] Add getblockchaininfo functional test (master...2017-09-add-getblockchaininfo-functional-test) https://github.com/bitcoin/bitcoin/pull/11370
< kinlo> gmaxwell: maybe that should be you? you're part of the bitcoin core team now, right?
< alephzero> somebody who has verifiable ties to bitcoin core project should file a claim.
< esotericnonsense> 0.15.0.1 extracts into bitcoin-0.15.0; is this expected? (not sure how minor-minor releases have gone before)
< bitcoin-git> [bitcoin] laanwj closed pull request #11307: wallet: Display non-HD error on first run (master...Mf1709-walletHDfirst) https://github.com/bitcoin/bitcoin/pull/11307
< bitcoin-git> bitcoin/master 4f7e37e Wladimir J. van der Laan: Merge #11307: wallet: Display non-HD error on first run...
< bitcoin-git> bitcoin/master fadf31e MarcoFalke: wallet: Display non-HD error on first run
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1ab1b687cb58...4f7e37e26c5d
< bitcoin-git> [bitcoin] practicalswift closed pull request #11361: Remove redundant LOCK(…) and AssertLockHeld(…) (master...remove-redundant-locks) https://github.com/bitcoin/bitcoin/pull/11361
< bitcoin-git> bitcoin/master 1ab1b68 Wladimir J. van der Laan: doc: Add release notes for 0.15.0.1...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/1ab1b687cb5870258add2b08169cd974f08ed032
< bitcoin-git> [bitcoin] practicalswift opened pull request #11369: doc: Document locks - increase LOCK(...) comment coverage from 2 % to 77 % (master...lock-comments) https://github.com/bitcoin/bitcoin/pull/11369
< Duvdevan> and I'm banned from #bitcoin for unknown reasons... :/
< meshcollider> Duvdevan: this channel is only for discussion of bitcoin core development, to discuss altcoin development please use ##altcoin-dev
< mryandao> Duvdevan: #bitcoin probably better.
< Duvdevan> I'm fairly new into bitcoin
< bitcoin-git> [bitcoin] esotericnonsense opened pull request #11367: RPC: getblockchaininfo: Add disk_size, prune_target_size (master...2017-09-getblockchaininfo-addsize) https://github.com/bitcoin/bitcoin/pull/11367
< meshcollider> achow101: Any advice on https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.sh#L178-L184 ? Could they simply be removed?
< meshcollider> I wonder, is it because https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#setting-up-debian-for-gitian-building uses br0 but the script tries to use lxcbr0 which doesn't exist?
< meshcollider> I had a similar issue, I gave up using the gitian-build.sh script and wrote a simple script of my own which basically follows the steps here: https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#setup-and-perform-gitian-builds
< kallewoof> I don't really wanna waste anyone's time, but I've been trying to figure out the gitian build process lately and am having issues. I was following https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md and everything was fine down to "Getting and building the inputs". For one I had to cd into ../bitcoin/ for there to be a contrib/gitian-build.sh file (not mentioned, but no biggie),
< bitcoin-git> [bitcoin] esotericnonsense opened pull request #11366: Trivial: RPC/getblockchaininfo: pruneheight is only present in pruned mode (master...2017-09-getblockchaininfo-docs) https://github.com/bitcoin/bitcoin/pull/11366
< bitcoin-git> [bitcoin] mess110 closed pull request #11329: [test] Test abortrescan command (master...kallewoof/test-abort-rescan-2) https://github.com/bitcoin/bitcoin/pull/11329
< bitcoin-git> [bitcoin] anditto opened pull request #11365: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (master...Adding-Qt-tests) https://github.com/bitcoin/bitcoin/pull/11365
< bitcoin-git> [bitcoin] azuchi closed pull request #11357: doc: Fix description of maximumCount (master...fix-0.15.0-release-notes) https://github.com/bitcoin/bitcoin/pull/11357
< bitcoin-git> [bitcoin] theuni opened pull request #11363: net: Split socket create connect (master...split-socket-create-connect) https://github.com/bitcoin/bitcoin/pull/11363

2017-09-18

< bitcoin-git> [bitcoin] gmaxwell opened pull request #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used. (master...2017_09_rm_nBlockMaxSize) https://github.com/bitcoin/bitcoin/pull/11362
< gmaxwell> goatpig: if something like that went on for weeks it would be doubtful if bitcoin would continue to exist at the end of such an event, regardless tweaking forward assumevalid wouldn't be a high priority. ... losing it entirely isn't that big of a deal.
< jonasschnelli> cfields_: can you have a final look at https://github.com/bitcoin/bitcoin/pull/11113?
< bitcoin-git> [bitcoin] practicalswift opened pull request #11361: Remove redundant LOCK(…) and AssertLockHeld(…) (master...remove-redundant-locks) https://github.com/bitcoin/bitcoin/pull/11361
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11323: mininode: add an optimistic write and disable nagle (master...optimistic-mininode) https://github.com/bitcoin/bitcoin/pull/11323
< bitcoin-git> bitcoin/master 4ce2f3d MarcoFalke: Merge #11323: mininode: add an optimistic write and disable nagle...
< bitcoin-git> bitcoin/master 1817398 Cory Fields: mininode: add an optimistic write and disable nagle...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/44e1fd926cfb...4ce2f3d0d333
< sheldonthomas> bitcoin core cruising again.
< achow101> sheldonthomas: that will work. don't forget to remove that after you start Bitcoin Core otherwise you will be resetting those settings on every start
< sheldonthomas> Am going to add resetguisettings to my bitcoin.conf will that suffice?
< sheldonthomas> Just noticed I have another plist called org.bitcoinfoundation.Bitcoin-Qt.plist should I remove that?
< gribble> https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
< achow101> start Bitcoin Core with the -resetguisettings option
< sheldonthomas> I’m running it via a command in my path like: open /Applications/bitcoin15/Bitcoin-Qt.app/ --args -datadir=‘…’
< achow101> sipa: 0.15.0.1 is not released yet (no codesigned gitian builds yet, not posted to bitcoin.org)
< achow101> sheldonthomas: then start Bitcoin Core with -resetguisettings
< achow101> sheldonthomas: please pastebin the contents of ~/Library/Preferences/org.bitcoin.Bitcoin-Qt.plist
< gribble> https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
< sipa> sheldonthomas: please open an issue on https://github.com/bitcoin/bitcoin/issues
< gribble> https://github.com/bitcoin/bitcoin/issues/11116 | [script] Unit tests for script/standard and IsMine functions. by jimpo · Pull Request #11116 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks. by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub
< andytoshi> RealM9: i am answering you in #bitcoin
< andytoshi> #bitcoin please
< RealM9> Bitcoin is again under a spam attack
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11345: [tests] Check connectivity before sending in assumevalid.py (master...assume_valid_improvement) https://github.com/bitcoin/bitcoin/pull/11345
< bitcoin-git> bitcoin/master 44e1fd9 MarcoFalke: Merge #11345: [tests] Check connectivity before sending in assumevalid.py...
< bitcoin-git> bitcoin/master e9e9391 John Newbery: [tests] Check connectivity before sending in assumevalid.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6d2c8503c40...44e1fd926cfb
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11340: Trivial: Fix validation comments (master...patch-12) https://github.com/bitcoin/bitcoin/pull/11340
< bitcoin-git> bitcoin/master d6d2c85 MarcoFalke: Merge #11340: Trivial: Fix validation comments...
< bitcoin-git> bitcoin/master a0b4c24 Dan Raviv: Trivial: Fix validation comments...