2016-09-09

< GitHub90> bitcoin/master df2d2e7 Gaurav Rana: update name of file bitcoin.qrc
< GitHub90> bitcoin/master 17347d6 Wladimir J. van der Laan: Merge #8683: fix incorrect file name bitcoin.qrc...
< GitHub90> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ddc308068d69...17347d6a5915
< CodeShark> in my ideal world, Bitcoin Core would just do peer discovery, validation, and relay
< CodeShark> I have a process connect to bitcoin core via p2p which receives inv messages and sends getdata
< midnightmagic> it should then be in an external library. putting reliable message delivery into bitcoin core would also make the binary liable in the event something (inevitably) goes wrong.

2016-09-08

< BlueMatt> sipa: https://github.com/TheBlueMatt/bitcoin/commit/96cef326f9184aefd1c562f64a21298a15f0adde simplifies the total diff from master to be more readable, to me...it matches the bip, but another way to look at it is that you have two booleans: which version of compact blocks they want (which you use to send to them) and whether they will send us segwit cmpctblocks...you simply introduce the the do-they-support-v2 bool as an additional
< cfields> kanzure: and #8680 introduces blocking calls. So you could "./bitcoin-cli waitfornewblock && ./dosomething.sh", which would essentially be blocknotify. Obviously the same could be done for wallet stuff
< kanzure> so- for example- imagine you are operating a lot of bitcoin infrastructure. you do a bunch of per-block processing. when you are running functional/integration tests, you can't run your test checks immediately after issuing a command because things take a while. so when do you expect to run? well you setup a hook and you ask your infrastructure to ping your tester as soon as the data's available, or you poll for some internal state.
< BlueMatt> (comment text from above link https://github.com/bitcoin/bips/pull/423#issuecomment-245629813 )
< wumpus> #link re: queue of things for 0.13.1, link is https://github.com/bitcoin/bitcoin/milestones/0.13.1
< sipa> BlueMatt: i haven't reviewed the changes for the bip you suggested - does it require any code changes to the bitcoin core pr?
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< GitHub36> [bitcoin] jl2012 opened pull request #8685: Discourage P2WSH with too big script or stack (master...bigp2wsh) https://github.com/bitcoin/bitcoin/pull/8685
< morcos> for instance you could imagine someone using bitcoin core has come to depend on that behavior
< morcos> cfields: i was just trying to review #8660, so this is also a regression caused by https://github.com/bitcoin/bitcoin/pull/7946?
< GitHub24> [bitcoin] bitcoinsSG opened pull request #8683: fix incorrect file name bitcoin.qrc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8683
< translatoree3> I've seen transfix, so translations there get credit on the github bitcoin repo?
< GitHub67> [bitcoin] MarcoFalke closed pull request #8671: Minimal fix to slow prevector tests as stopgap measure (master...simple_faster_tests) https://github.com/bitcoin/bitcoin/pull/8671
< GitHub87> bitcoin/master ddc3080 MarcoFalke: Merge #8671: Minimal fix to slow prevector tests as stopgap measure...
< GitHub87> bitcoin/master f71d4a3 Jeremy Rubin: Minimal fix to slow prevector tests as stopgap measure
< GitHub87> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec139a5621a9...ddc308068d69
< wumpus> /home/user/projects/bitcoin/bitcoin/src/test/addrman_tests.cpp:336:471: warning: stack frame size of 328360 bytes in function 'addrman_tests::addrman_delete::test_method' [-Wframe-larger-than=] whoa :) luckily only in the tests
< wumpus> let's try to make cfields network refactor (https://github.com/bitcoin/bitcoin/pull/8085/files) happen , it's been open so long now, line-wise there's a lot of changes so he keeps having to rebase it

2016-09-07

< cfields> morcos / jeremyrubin: as jeremyrubin suggested above, here's a quick hack at a simple future for the new hashing: https://github.com/theuni/bitcoin/commit/e93f724f0554dae43063080ea9d6c87650315c6e
< GitHub190> [bitcoin] JeremyRubin opened pull request #8681: Performance Regression Fix: Pre-Allocate txChanged vector (master...fix-perf-regressed-txChanged) https://github.com/bitcoin/bitcoin/pull/8681
< veleiro> Im trying to build v0.13.0 from source on a beaglebone black with debian jessie, i had to compile db4.8 from source but i installed libboost-all-dev, but in the ./configure stage the error i see is "configure: error: No working boost sleep implementation found." I went through https://github.com/bitcoin/bitcoin/issues/3003 with no success
< Chris_Stewart_5> jeremyrubin: With your new pull request (#8670), are you suggesting writing a new testing framework specific to bitcoin from scratch?
< GitHub128> [bitcoin] MarcoFalke closed pull request #8673: Trivial: Fix obvious assignment/equality error in test (master...fix_arith_tests_trivial) https://github.com/bitcoin/bitcoin/pull/8673
< GitHub1> bitcoin/master ec139a5 MarcoFalke: Merge #8673: Trivial: Fix obvious assignment/equality error in test...
< GitHub1> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b2ea29cf4fd...ec139a5621a9
< GitHub1> bitcoin/master 426e7bc Jeremy Rubin: Fix obvious assignment/equality error in test
< GitHub23> [bitcoin] MarcoFalke closed pull request #8644: [0.13 backport] Check for compatibility with download in FindNextBlocksToDownload (0.13...findnext_backport) https://github.com/bitcoin/bitcoin/pull/8644
< GitHub157> [bitcoin] theuni opened pull request #8680: Address Travis spurious failures (master...rpc-waitforblock) https://github.com/bitcoin/bitcoin/pull/8680
< GitHub71> [bitcoin] sipa opened pull request #8679: [0.13] Various backports (0.13...backports_0.13) https://github.com/bitcoin/bitcoin/pull/8679
< GitHub150> [bitcoin] jonasschnelli opened pull request #8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (master...2016/09/qt_cc_ui_radrio_fix) https://github.com/bitcoin/bitcoin/pull/8678
< GitHub136> [bitcoin] paveljanik opened pull request #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (master...20160907_Wshadow_8606) https://github.com/bitcoin/bitcoin/pull/8677
< GitHub39> [bitcoin] sipa closed pull request #8594: Do not add random inbound peers to addrman. (master...no_inbound_addr) https://github.com/bitcoin/bitcoin/pull/8594
< GitHub6> bitcoin/master 5b2ea29 Pieter Wuille: Merge #8594: Do not add random inbound peers to addrman....
< GitHub6> bitcoin/master eb3596f Gregory Maxwell: Do not add random inbound peers to addrman....
< GitHub6> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2a1a1ee8951...5b2ea29cf4fd
< GitHub69> [bitcoin] sipa closed pull request #8606: Fix some locks (master...lockfix) https://github.com/bitcoin/bitcoin/pull/8606
< GitHub123> bitcoin/master e2a1a1e Pieter Wuille: Merge #8606: Fix some locks...
< GitHub123> bitcoin/master 144ed76 Pieter Wuille: Fix some locks...
< GitHub123> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ea44405e76f...e2a1a1ee8951
< GitHub38> [bitcoin] isle2983 opened pull request #8676: Add missing copyright headers (master...missing-copyright) https://github.com/bitcoin/bitcoin/pull/8676
< GitHub51> [bitcoin] isle2983 opened pull request #8675: Make copyright header lines uniform (master...copyright-made-uniform) https://github.com/bitcoin/bitcoin/pull/8675
< GitHub16> [bitcoin] isle2983 opened pull request #8674: tools for analyzing, updating and adding copyright headers in souce files (master...copyright-scripts) https://github.com/bitcoin/bitcoin/pull/8674

2016-09-06

< GitHub122> [bitcoin] JeremyRubin opened pull request #8673: Trivial: Fix obvious assignment/equality error in test (master...fix_arith_tests_trivial) https://github.com/bitcoin/bitcoin/pull/8673
< GitHub82> [bitcoin] JeremyRubin closed pull request #8632: Speed up prevector tests by parallelization (master...faster_prevector_tests) https://github.com/bitcoin/bitcoin/pull/8632
< GitHub172> [bitcoin] JeremyRubin closed pull request #8650: Make tests much faster by replacing BOOST_CHECK with FAST_CHECK (master...faster_tests) https://github.com/bitcoin/bitcoin/pull/8650
< GitHub186> [bitcoin] Cocosoft opened pull request #8672: Qt: Show transaction size in transaction details window (master...qttxsizeindetails) https://github.com/bitcoin/bitcoin/pull/8672
< GitHub117> [bitcoin] JeremyRubin opened pull request #8671: Minimal fix to slow prevector tests as stopgap measure (master...simple_faster_tests) https://github.com/bitcoin/bitcoin/pull/8671
< instagibbs_> jonasschnelli: did https://github.com/bitcoin/bitcoin/pull/8606 fix your issue?
< GitHub121> [bitcoin] laanwj closed pull request #8645: Remove unused Qt 4.6 patch. (master...master) https://github.com/bitcoin/bitcoin/pull/8645
< GitHub0> bitcoin/master 38acbf8 Doug: Remove unused Qt 4.6 patch....
< GitHub0> bitcoin/master 8ea4440 Wladimir J. van der Laan: Merge #8645: Remove unused Qt 4.6 patch....
< GitHub0> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d077f43f7ecf...8ea44405e76f
< GitHub96> [bitcoin] laanwj closed pull request #8663: trivial: remove unnecessary variable fDaemon (master...trivial_fDaemon) https://github.com/bitcoin/bitcoin/pull/8663
< GitHub111> bitcoin/master d077f43 Wladimir J. van der Laan: Merge #8663: trivial: remove unnecessary variable fDaemon...
< GitHub111> bitcoin/master ff2ed7a mruddy: trivial: remove unnecessary variable fDaemon
< GitHub111> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e82fb872ff5c...d077f43f7ecf
< sipa> the bitcoin and libsecp256k1 benchmark tools just run many times, and give you minimum, maximum and average run time

2016-09-05

< BlueMatt> general fyi: book your accomodation to wed, if you feel like sticking around to do in-person Bitcoin Core code review/hacking just like the last few times
< BlueMatt> ie another core hackathon after scaling bitcoin: milan, monday and tuesday
< BlueMatt> but I dont particularly want to have /the/ key that can sign for lots of updated bitcoin-qt clients
< Lightsword> could just stick it on bitcoin.org
< BlueMatt> kanzure: people with their heads on straight are correctly avoiding ubuntu for their bitcoin node hosting, I'd think
< BlueMatt> bitcoin.org maybe, but I'd prefer to not put it there
< Lightsword> bitcoincore.org or bitcoin.org?
< GitHub78> [bitcoin] jl2012 opened pull request #8667: Fix SIGHASH_SINGLE bug in test_framework SignatureHash (master...patch-16) https://github.com/bitcoin/bitcoin/pull/8667
< achow101> Algorithmer: not here. This is for bitcoin core development.
< BlueMatt> would anyone object to bitcoin-ppa on precise being compiled with clang?
< GitHub70> [bitcoin] sipa closed pull request #8651: Predeclare PrecomputedTransactionData as struct (master...classtructblah) https://github.com/bitcoin/bitcoin/pull/8651
< GitHub77> bitcoin/master e82fb87 Pieter Wuille: Merge #8651: Predeclare PrecomputedTransactionData as struct...
< GitHub77> bitcoin/master 4424af5 Pieter Wuille: Predeclare PrecomputedTransactionData as sturct
< GitHub77> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbe9ae8c69b9...e82fb872ff5c
< GitHub176> [bitcoin] NicolasDorier opened pull request #8665: Trivial: ContextualCheckBlockHeader should never have pindexPrev equals to NULL (master...fixup) https://github.com/bitcoin/bitcoin/pull/8665
< GitHub1> [bitcoin] sdaftuar opened pull request #8664: Fix segwit-related wallet bug (master...segwit-wallet-bug) https://github.com/bitcoin/bitcoin/pull/8664

2016-09-04

< GitHub142> [bitcoin] fivepiece closed pull request #8598: Fix displaying of invalid and non-minimal small pushes as numbers (master...fixasm) https://github.com/bitcoin/bitcoin/pull/8598
< sipa> but that probably means in practice we can't use it in bitcoin core until 2024 or so :p
< GitHub195> [bitcoin] mruddy opened pull request #8663: trivial: remove unnecessary variable fDaemon (master...trivial_fDaemon) https://github.com/bitcoin/bitcoin/pull/8663
< GitHub8> [bitcoin] rebroad closed pull request #8642: Less reliance on protocol version (master...LessRelianceOnNodeVersion) https://github.com/bitcoin/bitcoin/pull/8642
< GitHub105> [bitcoin] btcdrak opened pull request #8662: Update btcdrak signing key (master...updatekey) https://github.com/bitcoin/bitcoin/pull/8662
< gmaxwell> In the case of bitcoin the cookie auth is an ephemeral username and password, saved in a cookie file, which can be used for HTTP authentication.

2016-09-03

< GitHub3> [bitcoin] gmaxwell opened pull request #8661: Do not set an addr time penalty when a peer advertises itself. (master...addrman_nopenalty_self) https://github.com/bitcoin/bitcoin/pull/8661
< GitHub168> [bitcoin] djpnewton opened pull request #8660: txoutsbyaddress index (take 2) (master...cozz8) https://github.com/bitcoin/bitcoin/pull/8660
< GitHub149> [bitcoin] gmaxwell closed pull request #8648: [0.13 backport] Precompute sighashes (0.13...precompute_backport) https://github.com/bitcoin/bitcoin/pull/8648

2016-09-02

< GitHub70> [bitcoin] paveljanik opened pull request #8658: WIP/DO NOT MERGE: Remove unused statements in serialization (master...20160902_nVersion_serialization_cleanup) https://github.com/bitcoin/bitcoin/pull/8658
< GitHub12> [bitcoin] paveljanik opened pull request #8656: Do not shadow global variable fileout (master...20160902_Wshadow_fileout) https://github.com/bitcoin/bitcoin/pull/8656
< GitHub78> [bitcoin] paveljanik opened pull request #8655: Do not shadow variables (trivials) (master...20160902_Wshadow_trivials) https://github.com/bitcoin/bitcoin/pull/8655
< GitHub85> [bitcoin] jl2012 opened pull request #8654: Reuse sighash computations across evaluation (rebase of #4562) (master...sighashcache) https://github.com/bitcoin/bitcoin/pull/8654
< cfields> jonasschnelli: so I should ignore https://github.com/bitcoin/bitcoin/pull/8085#issuecomment-244077083 ?
< jonasschnelli> 2016-09-02 07:56:40 Bitcoin version v0.13.99.0-df98230
< GitHub117> [bitcoin] sstone opened pull request #8653: doc (trivial): add tip for cross-builds on ubuntu (master...wip-doccrosscompile) https://github.com/bitcoin/bitcoin/pull/8653
< cfields> wumpus: re-ping incase you missed in backog. what do you think of the approach here to fix the travis timeouts? https://github.com/theuni/bitcoin/commit/fa88a425c0c1089ab75ea9223699286f40c8eea7
< GitHub97> [bitcoin] jl2012 closed pull request #8533: Implement LOW_S and NULLDUMMY softfork (BIP146) (master...bip146) https://github.com/bitcoin/bitcoin/pull/8533
< GitHub92> [bitcoin] laanwj closed pull request #8466: [Trivial] Do not shadow variables in networking code (master...20160805_Wshadow_net) https://github.com/bitcoin/bitcoin/pull/8466
< GitHub29> bitcoin/master cbe9ae8 Wladimir J. van der Laan: Merge #8466: [Trivial] Do not shadow variables in networking code...
< GitHub29> bitcoin/master b7c349d Pavel Janík: Do not shadow variables in networking code
< GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/381d0ddc8aaa...cbe9ae8c69b9
< GitHub190> [bitcoin] laanwj closed pull request #8449: [Trivial] Do not shadow local variable, cleanup (master...20160803_shadow_blockencodings) https://github.com/bitcoin/bitcoin/pull/8449
< GitHub76> bitcoin/master 381d0dd Wladimir J. van der Laan: Merge #8449: [Trivial] Do not shadow local variable, cleanup...
< GitHub76> bitcoin/master a159f25 Pavel Janík: Remove redundand (and shadowing) declaration
< GitHub76> bitcoin/master cce3024 Pavel Janík: Do not shadow local variable, cleanup
< GitHub76> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6f939c9080a3...381d0ddc8aaa
< GitHub77> [bitcoin] yurizhykin opened pull request #8652: [qa]: remove root test directory for RPC tests (master...cleanup) https://github.com/bitcoin/bitcoin/pull/8652
< GitHub197> [bitcoin] sipa opened pull request #8651: Predeclare PrecomputedTransactionData as struct (master...classtructblah) https://github.com/bitcoin/bitcoin/pull/8651
< GitHub51> [bitcoin] laanwj closed pull request #8629: C++11: s/boost::scoped_ptr/std::unique_ptr/ (master...0.13-boost-scoped-ptr) https://github.com/bitcoin/bitcoin/pull/8629
< GitHub55> bitcoin/master 6f939c9 Wladimir J. van der Laan: Merge #8629: C++11: s/boost::scoped_ptr/std::unique_ptr/...
< GitHub55> bitcoin/master cdd79eb Jorge Timón: C++11: s/boost::scoped_ptr/std::unique_ptr/
< GitHub55> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/91990ee01dab...6f939c9080a3
< GitHub133> [bitcoin] laanwj closed pull request #8272: Make the dummy argument to getaddednodeinfo optional (master...optionaladdnodedummy) https://github.com/bitcoin/bitcoin/pull/8272
< GitHub124> bitcoin/master 91990ee Wladimir J. van der Laan: Merge #8272: Make the dummy argument to getaddednodeinfo optional...
< GitHub124> bitcoin/master 854f1af Pieter Wuille: Make the dummy argument to getaddednodeinfo optional
< GitHub124> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f061415d12ce...91990ee01dab
< GitHub186> [bitcoin] JeremyRubin opened pull request #8650: Make tests much faster by replacing BOOST_CHECK with FAST_CHECK (master...faster_tests) https://github.com/bitcoin/bitcoin/pull/8650
< jl2012> And I already have a PR for empty failing signature https://github.com/bitcoin/bitcoin/pull/8634
< GitHub102> [bitcoin] gmaxwell opened pull request #8648: [0.13 backport] Precompute sighashes (0.13...precompute_backport) https://github.com/bitcoin/bitcoin/pull/8648
< GitHub176> [bitcoin] gmaxwell opened pull request #8646: [0.13 backport] Reduce default number of blocks to check at startup (0.13...reduceblocks_backport) https://github.com/bitcoin/bitcoin/pull/8646
< GitHub29> [bitcoin] droark opened pull request #8645: Remove unused Qt 4.6 patch. (master...master) https://github.com/bitcoin/bitcoin/pull/8645
< GitHub92> [bitcoin] gmaxwell opened pull request #8644: [0.13 backport] Check for compatibility with download in FindNextBlocksToDownload (0.13...findnext_backport) https://github.com/bitcoin/bitcoin/pull/8644

2016-09-01

< gmaxwell> grep econs ~/.bitcoin/debug.log | tail -n 100 | awk '{aa+=$16>1} END {print aa/NR}'
< jeremyrubin> (for reference, PR is here https://github.com/bitcoin/bitcoin/pull/8464)
< GitHub133> [bitcoin] jonasschnelli opened pull request #8643: [0.13 backport] Added feeler connections increasing good addrs in the tried table. (0.13...2016/08/feeler_013) https://github.com/bitcoin/bitcoin/pull/8643
< btcdrak> sdaftuar there is a NULLDUMMY only PR as well https://github.com/bitcoin/bitcoin/pull/8636
< gmaxwell> By someone triggering a fork off of bitcoin ruby.
< jonasschnelli> shouldn't we tag https://github.com/bitcoin/bitcoin/issues/8279 for 0.13.1?
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< jtimon> it seems travis is failing walletbackup.py no matter what I push https://travis-ci.org/bitcoin/bitcoin/jobs/156853453#L2310
< GitHub130> bitcoin/0.12 65ee332 Luke Dashjr: getblocktemplate: Explicitly handle the distinction between GBT-affecting softforks vs not
< GitHub130> bitcoin/0.12 40e81f5 Luke Dashjr: qa/rpc-tests: bip9-softforks: Add tests for getblocktemplate versionbits updates
< GitHub130> bitcoin/0.12 ddd8c01 Luke Dashjr: Implement BIP 9 GBT changes...
< GitHub29> [bitcoin] laanwj closed pull request #8176: [0.12.x]: Versionbits: GBT support (0.12...gbt_bip9-0.12.x) https://github.com/bitcoin/bitcoin/pull/8176
< GitHub130> [bitcoin] laanwj pushed 5 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/15502d7b2543...ec0afbd52b78
< GitHub78> [bitcoin] laanwj closed pull request #8638: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST (master...patch-2) https://github.com/bitcoin/bitcoin/pull/8638
< GitHub10> bitcoin/master f061415 Wladimir J. van der Laan: Merge #8638: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST...
< GitHub10> bitcoin/master f012a85 djpnewton: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
< GitHub10> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/44691f3c51c9...f061415d12ce
< GitHub143> [bitcoin] laanwj closed pull request #8557: [contrib] Rework verifybinaries (master...Mf1608-verifyBins) https://github.com/bitcoin/bitcoin/pull/8557
< GitHub140> bitcoin/master faaed88 MarcoFalke: [contrib] verifybinaries: Mention mandatory preparation step
< GitHub140> bitcoin/master fa917f6 MarcoFalke: [contrib] verifybinaries: Keep downloads by default
< GitHub140> bitcoin/master fab1f92 MarcoFalke: [contrib] verifybinaries: Adjust parsing to new rc path
< GitHub140> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e563d89c075...44691f3c51c9
< GitHub84> [bitcoin] laanwj closed pull request #7376: Payments: Allow zero value OP_RETURN in PaymentRequests (master...zeropayments) https://github.com/bitcoin/bitcoin/pull/7376
< GitHub159> [bitcoin] laanwj closed pull request #8472: Do not shadow LOCK's criticalblock variable for LOCK inside LOCK (master...20160806_Wshadow_LOCK) https://github.com/bitcoin/bitcoin/pull/8472
< GitHub162> bitcoin/master 0e563d8 Wladimir J. van der Laan: Merge #8472: Do not shadow LOCK's criticalblock variable for LOCK inside LOCK...
< GitHub162> bitcoin/master 33d15a3 Pavel Janík: Do not shadow LOCK's criticalblock variable for LOCK inside LOCK
< GitHub162> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2663e5149dc0...0e563d89c075
< GitHub131> [bitcoin] laanwj closed pull request #8640: [depends] Remove Qt46 package (master...remove-qt46-depends) https://github.com/bitcoin/bitcoin/pull/8640
< GitHub89> bitcoin/master 2663e51 Wladimir J. van der Laan: Merge #8640: [depends] Remove Qt46 package...
< GitHub89> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/2663e5149dc06dedb8c29672abe4b1c645768e52
< GitHub100> [bitcoin] sipa closed pull request #8524: Precompute sighashes (master...noprecomputecachedhashes) https://github.com/bitcoin/bitcoin/pull/8524
< GitHub97> bitcoin/master 35fe039 Pieter Wuille: Rename to PrecomputedTransactionData
< GitHub97> bitcoin/master ab48c5e Nicolas DORIER: Unit test for sighash caching
< GitHub97> bitcoin/master d2c5d04 Pieter Wuille: Precompute sighashes...
< GitHub97> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/84decb54f259...19b0f33de0ef
< GitHub22> [bitcoin] rebroad opened pull request #8642: Less reliance on node version (master...LessRelianceOnNodeVersion) https://github.com/bitcoin/bitcoin/pull/8642
< GitHub45> [bitcoin] sipa closed pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub2> [bitcoin] sipa closed pull request #8597: Move code from VERACK to VERSION (since VERACK is not requied) (master...NotDependentOnVerack) https://github.com/bitcoin/bitcoin/pull/8597
< GitHub15> [bitcoin] rebroad reopened pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< gmaxwell> yea, man, who does that. Next thing we're going to find out that someone used their same password on github and the bitcoin core slack. :P
< GitHub77> [bitcoin] fanquake opened pull request #8640: [depends] Remove Qt46 package (master...remove-qt46-depends) https://github.com/bitcoin/bitcoin/pull/8640

2016-08-31

< GitHub107> [bitcoin] djpnewton opened pull request #8638: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST (master...patch-2) https://github.com/bitcoin/bitcoin/pull/8638
< GitHub55> [bitcoin] yurizhykin closed pull request #8313: Use std::move() instead of copying/removing in TxMemPool (master...tx-delete) https://github.com/bitcoin/bitcoin/pull/8313
< GitHub155> [bitcoin] theuni closed pull request #8542: RFC: net: Pass best block known height into net (master...pass-in-height) https://github.com/bitcoin/bitcoin/pull/8542
< warren> I'm surprised to find that the gitian documentation in the bitcoin repo no longer explains the gitian default qemu-kvm (non-LXC) method of using make-base-vm.
< GitHub53> [bitcoin] laanwj closed pull request #8612: Check for compatibility with download in FindNextBlocksToDownload (master...fixwitban) https://github.com/bitcoin/bitcoin/pull/8612
< GitHub127> bitcoin/master 887919c Pieter Wuille: Check for compatibility with download in FindNextBlocksToDownload
< GitHub127> bitcoin/master 84decb5 Wladimir J. van der Laan: Merge #8612: Check for compatibility with download in FindNextBlocksToDownload...
< GitHub127> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/abc677c9a98a...84decb54f259
< GitHub24> [bitcoin] sipa closed pull request #8138: Add maximal amount-of-transactions limit to checkblock/CVerifyDB (master...2016/06/verify_db) https://github.com/bitcoin/bitcoin/pull/8138
< murch> sipa: I didn't get a ticket for Scaling Bitcoin unfortunately. :( I'm now hoping that my proposal will be accepted, otherwise it looks like I might not be able to go. (I'm on the waiting list.)
< GitHub163> [bitcoin] sipa opened pull request #8637: Compact Block Tweaks (rebase of #8235) (master...compactblocktweaks) https://github.com/bitcoin/bitcoin/pull/8637
< sipa> bitcoin core does not implement bip44
< murch> sipa: I had read part of the discussion on the BIP status updates on the dev list. There was a bit about the gap limit there and I assumed that Bitcoin Core also implements BIP44.
< GitHub10> [bitcoin] laanwj closed pull request #8191: Do not shadow variables in src/wallet (master...20160611_shadowing_wallet) https://github.com/bitcoin/bitcoin/pull/8191
< GitHub175> bitcoin/master b175cb7 Pavel Janík: Do not shadow variables.
< GitHub175> bitcoin/master abc677c Wladimir J. van der Laan: Merge #8191: Do not shadow variables in src/wallet...
< GitHub175> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cac8b123e7e...abc677c9a98a
< GitHub111> [bitcoin] laanwj closed pull request #8291: [util] CopyrightHolders: Check for untranslated substitution (master...Mf1607-utilCopy) https://github.com/bitcoin/bitcoin/pull/8291
< GitHub199> bitcoin/master 5cac8b1 Wladimir J. van der Laan: Merge #8291: [util] CopyrightHolders: Check for untranslated substitution...
< GitHub199> bitcoin/master 33336e1 MarcoFalke: [util] CopyrightHolders: Check for untranslated substitution...
< GitHub199> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c8875d23b37...5cac8b123e7e
< GitHub177> bitcoin/master 0c8875d Wladimir J. van der Laan: Merge #8163: Do not shadow global RPC table variable (tableRPC)...
< GitHub86> [bitcoin] laanwj closed pull request #8163: Do not shadow global RPC table variable (tableRPC) (master...20160607_shadowing_rpc) https://github.com/bitcoin/bitcoin/pull/8163
< GitHub177> bitcoin/master de1bbe3 Pavel Janík: Do not shadow global RPC table variable (tableRPC)
< GitHub177> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f25684300a72...0c8875d23b37
< GitHub28> bitcoin/0.12 15502d7 Wladimir J. van der Laan: Merge #8187: [0.12.2] backport: [qa] Switch to py3...
< GitHub28> bitcoin/0.12 2826565 MarcoFalke: [qa] Switch to py3...
< GitHub28> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/1233cb42dde9...15502d7b2543
< GitHub72> [bitcoin] laanwj closed pull request #8187: [0.12.2] backport: [qa] Switch to py3 (0.12...Mf1606-qaPy3Backport) https://github.com/bitcoin/bitcoin/pull/8187
< GitHub114> [bitcoin] laanwj closed pull request #8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9 (master...2016_08_openbsd_update) https://github.com/bitcoin/bitcoin/pull/8604
< GitHub143> bitcoin/master f256843 Wladimir J. van der Laan: Merge #8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9...
< GitHub143> bitcoin/master 6275123 Wladimir J. van der Laan: doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9...
< GitHub143> bitcoin/master 883175f Wladimir J. van der Laan: build: Updates for OpenBSD...
< GitHub143> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8ed6eb45731...f25684300a72
< GitHub86> [bitcoin] laanwj closed pull request #8621: [contrib] python: Don't use shell=True (master...Mf1608-trivial17) https://github.com/bitcoin/bitcoin/pull/8621
< GitHub76> bitcoin/master fa994a7 MarcoFalke: contrib: Don't use shell=True
< GitHub76> bitcoin/master e8ed6eb Wladimir J. van der Laan: Merge #8621: [contrib] python: Don't use shell=True...
< GitHub76> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df3f12d4096c...e8ed6eb45731
< GitHub84> [bitcoin] laanwj closed pull request #8626: Berkeley DB v6 compatibility fix (master...netsafe-patch-1) https://github.com/bitcoin/bitcoin/pull/8626
< GitHub8> bitcoin/master df3f12d Wladimir J. van der Laan: Merge #8626: Berkeley DB v6 compatibility fix...
< GitHub8> bitcoin/master 323a5fe Alexey Vesnin: Berkeley DB v6 compatibility fix...
< GitHub8> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b23dbaee5b8...df3f12d4096c
< GitHub134> [bitcoin] jl2012 opened pull request #8636: Implement NULLDUMMY softfork (master...nulldummy) https://github.com/bitcoin/bitcoin/pull/8636
< jl2012> why violating the nLockTime has 10 DoS score instead of 100? https://github.com/bitcoin/bitcoin/blob/6c9f1b8c24052134413b1a7d7d0599339daffc32/src/main.cpp#L3547
< GitHub47> [bitcoin] jl2012 opened pull request #8635: Enforce mandatory softfork flags for segwit block/tx (master...mandatorysegwitflags) https://github.com/bitcoin/bitcoin/pull/8635
< GitHub36> [bitcoin] jl2012 opened pull request #8634: Add policy: null signature for failed CHECK(MULTI)SIG (master...nullfail) https://github.com/bitcoin/bitcoin/pull/8634
< jeremyrubin> gmaxwell: even on this branch which removes sys/time https://github.com/bitcoin/bitcoin/compare/master...JeremyRubin:refactor-bench
< achow101> the idea is that the user should be able to just start Bitcoin Core with no options (except server=1 I guess) and the software (Armory) would be able to automatically know how to connect to the server without any user input
< GitHub112> [bitcoin] JeremyRubin opened pull request #8633: Ugly hack to print out tests as they are run to mitigate travis timeouts (master...test-driver-hack) https://github.com/bitcoin/bitcoin/pull/8633
< GitHub111> [bitcoin] JeremyRubin opened pull request #8632: Speed up prevector tests by parallelization (master...faster_prevector_tests) https://github.com/bitcoin/bitcoin/pull/8632
< GitHub184> [bitcoin] theuni opened pull request #8631: Nuke boost::thread and boost::thread_group (master...no-interrupt-threads) https://github.com/bitcoin/bitcoin/pull/8631
< GitHub34> [bitcoin] theuni closed pull request #8023: RFC: Interruptible threads (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/8023

2016-08-30

< GitHub24> [bitcoin] jtimon opened pull request #8629: C++11: s/boost::scoped_ptr/std::unique_ptr/ (master...0.13-boost-scoped-ptr) https://github.com/bitcoin/bitcoin/pull/8629
< jonasschnelli> bitcoin in ProcessMessages()
< GitHub82> [bitcoin] laanwj closed pull request #8611: Reduce default number of blocks to check at startup (master...fastcheck) https://github.com/bitcoin/bitcoin/pull/8611
< GitHub4> bitcoin/master 2b23dba Wladimir J. van der Laan: Merge #8611: Reduce default number of blocks to check at startup...
< GitHub4> bitcoin/master 203f212 Pieter Wuille: Reduce default number of blocks to check at startup
< GitHub4> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b9889586501...2b23dbaee5b8
< GitHub123> [bitcoin] laanwj closed pull request #8566: Easy to use gitian building script (master...gitian-build-script) https://github.com/bitcoin/bitcoin/pull/8566
< GitHub114> bitcoin/master 6ffd6b4 Andrew Chow: Create option to detach sign gitian builds and not commit the files in the script...
< GitHub114> bitcoin/master 498d8da Andrew Chow: Check for OSX SDK
< GitHub114> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/c01a6c48b982...7b9889586501
< GitHub114> bitcoin/master eda4cfb Andrew Chow: Create an easy to use gitian building script...
< GitHub194> [bitcoin] MarcoFalke closed pull request #8625: [doc] - clarify statement about parallel jobs in rpc-tests.py (master...rpcTestsDoc) https://github.com/bitcoin/bitcoin/pull/8625
< GitHub184> bitcoin/master c01a6c4 MarcoFalke: Merge #8625: [doc] - clarify statement about parallel jobs in rpc-tests.py...
< GitHub184> bitcoin/master 1467561 isle2983: [doc] - clarify statement about parallel jobs in rpc-tests.py
< GitHub184> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/89de1538ce1f...c01a6c48b982
< GitHub173> [bitcoin] netsafe opened pull request #8626: Berkeley DB v6 compatibility fix (master...netsafe-patch-1) https://github.com/bitcoin/bitcoin/pull/8626
< GitHub7> [bitcoin] isle2983 opened pull request #8625: [doc] - clarify statement about parallel jobs in rpc-tests.py (master...rpcTestsDoc) https://github.com/bitcoin/bitcoin/pull/8625

2016-08-29

< GitHub97> [bitcoin] sipa closed pull request #8624: [doc] build: Mention curl (master...Mf1608-docCurl) https://github.com/bitcoin/bitcoin/pull/8624
< GitHub32> [bitcoin] sipa closed pull request #8478: Ubuntu 14.04 server installs w/o curl (master...patch-3) https://github.com/bitcoin/bitcoin/pull/8478
< GitHub160> bitcoin/master fae6bb8 MarcoFalke: [doc] build: Mention curl
< GitHub160> bitcoin/master 89de153 Pieter Wuille: Merge #8624: [doc] build: Mention curl...
< GitHub160> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de07fdcf77e9...89de1538ce1f
< GitHub24> [bitcoin] sipa closed pull request #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit (master...gitian_osx_extractor) https://github.com/bitcoin/bitcoin/pull/8617
< GitHub154> bitcoin/master de07fdc Pieter Wuille: Merge #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit...
< GitHub154> bitcoin/master b729fcd Luke Dashjr: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit
< GitHub154> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01680195f8aa...de07fdcf77e9
< GitHub199> [bitcoin] sipa closed pull request #8564: [Wallet] remove unused code/conditions in ReadAtCursor (master...2016/08/bdb_abstraction_1) https://github.com/bitcoin/bitcoin/pull/8564
< GitHub161> bitcoin/master 0168019 Pieter Wuille: Merge #8564: [Wallet] remove unused code/conditions in ReadAtCursor...
< GitHub161> bitcoin/master beef966 Jonas Schnelli: [Wallet] remove unused code/conditions in ReadAtCursor
< GitHub161> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5bb6387f751...01680195f8aa
< GitHub120> [bitcoin] MarcoFalke opened pull request #8624: [doc] build: Mention curl (master...Mf1608-docCurl) https://github.com/bitcoin/bitcoin/pull/8624
< GitHub190> [bitcoin] daddinuz opened pull request #8623: chainparams: Added parametric halving interval for regtest-only mode (master...parametric_halving_interval) https://github.com/bitcoin/bitcoin/pull/8623
< GitHub64> [bitcoin] rebroad closed pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub171> [bitcoin] rebroad reopened pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub129> [bitcoin] MarcoFalke reopened pull request #8484: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8484
< GitHub184> [bitcoin] rebroad closed pull request #8484: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8484
< GitHub6> [bitcoin] rebroad reopened pull request #8484: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8484
< GitHub13> [bitcoin] rebroad closed pull request #8484: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8484
< GitHub97> [bitcoin] rebroad closed pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub57> [bitcoin] rebroad reopened pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub7> [bitcoin] rebroad closed pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub128> [bitcoin] rebroad closed pull request #8571: [WIP] Disconnect when a node doesn't offer the relevant services. (master...UnexpectedServicesNoDisconnect) https://github.com/bitcoin/bitcoin/pull/8571
< GitHub148> [bitcoin] rebroad reopened pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub45> [bitcoin] rebroad closed pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub120> [bitcoin] rebroad opened pull request #8622: [WIP] Clarify variable names (master...ClarifyVariableNames) https://github.com/bitcoin/bitcoin/pull/8622
< GitHub48> [bitcoin] rebroad reopened pull request #8484: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8484
< GitHub97> [bitcoin] rebroad closed pull request #8618: [WIP] Erase orphans only when banned (master...EraseOrphansOnlyWhenBanned) https://github.com/bitcoin/bitcoin/pull/8618

2016-08-28

< arubi> would love if someone took a look at https://github.com/bitcoin/bitcoin/pull/8598 , let me know if it's something folks would find useful or what should I do if not :) (close? leave open?)
< GitHub50> [bitcoin] MarcoFalke opened pull request #8621: [contrib] python: Don't use shell=True (master...Mf1608-trivial17) https://github.com/bitcoin/bitcoin/pull/8621
< GitHub191> [bitcoin] laanwj closed pull request #8607: [doc] Fix doxygen off-by-one comments, fix typos (master...Mf1608-trivial17) https://github.com/bitcoin/bitcoin/pull/8607
< GitHub96> bitcoin/master fa27c0a MarcoFalke: [doc] Fix typos in comments, doxygen: Fix comment syntax
< GitHub96> bitcoin/master fabfd5d MarcoFalke: [qa] pull-tester: Don't mute zmq ImportError
< GitHub96> bitcoin/master 67a5502 Wladimir J. van der Laan: init: Fix typo in help message for -whitelistforcerelay...
< GitHub96> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/05e1c85fb687...a5bb6387f751
< GitHub87> [bitcoin] NicolasDorier closed pull request #8422: Cache hashes (master...cachedhashes2) https://github.com/bitcoin/bitcoin/pull/8422
< GitHub82> [bitcoin] UdjinM6 closed pull request #8372: Fix AddRef() usage for CNode (master...fixNodeRefCount) https://github.com/bitcoin/bitcoin/pull/8372
< GitHub20> [bitcoin] MarcoFalke closed pull request #8620: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8620
< GitHub152> [bitcoin] rebroad opened pull request #8620: [WIP] More granular debug (master...MoreGranularDebug) https://github.com/bitcoin/bitcoin/pull/8620
< GitHub6> [bitcoin] sipa closed pull request #8573: Set jonasschnellis dns-seeder filter flag (master...2016/08/filter_seed) https://github.com/bitcoin/bitcoin/pull/8573
< GitHub116> bitcoin/master 05e1c85 Pieter Wuille: Merge #8573: Set jonasschnellis dns-seeder filter flag...
< GitHub116> bitcoin/master 40a95cf Jonas Schnelli: Set jonasschnellis dns-seeder filter flag