2018-12-20

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14653: rpcwallet: Add missing transaction categories to rpc helptexts (master...listtransactions-help) https://github.com/bitcoin/bitcoin/pull/14653
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb52cee29d0d...86e0a33f5c38
< bitcoin-git> bitcoin/master e982f0b andrewtoth: Add all category options to wallet rpc help
< bitcoin-git> bitcoin/master f3f6dde andrewtoth: Test coinbase category in wallet rpcs
< bitcoin-git> bitcoin/master 86e0a33 MarcoFalke: Merge #14653: rpcwallet: Add missing transaction categories to rpc helptexts...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14932: ui: Warn the user on file corruption in mempool.dat (master...Mf1812-testFileCorruption) https://github.com/bitcoin/bitcoin/pull/14932
< provoostenator> timothy: bitcoin-cli could prompt for a password rather than expecting it as an argument
< timothy> (bitcoin-cli already have -stdin)
< timothy> provoostenator: it's not a problem of bitcoin-cli, you cannot disable history in called command
< provoostenator> That would be a change at the bitcoin-cli level.
< bitcoin-git> [bitcoin] jnewbery opened pull request #15010: [wallet] Fix getbalance with minconf (master...fix_getbalance_with_minconf) https://github.com/bitcoin/bitcoin/pull/15010
< jnewbery> wumpus: https://github.com/bitcoin-core/univalue/pull/17 has three ACKs. May be ready for merge?
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< wumpus> though I don't really like more and more 'business rule' kind of functionality leaking into bitcoin core, it reminds me a bit of the account stuff, it's so specific on your applciation
< wumpus> bolting it on in a bitcoin specific way seems a bad idea
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< jnewbery> achow101: +1. I think we'd want to merge #13100 (and hence complete https://github.com/bitcoin/bitcoin/projects/2) before we enforced that
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub

2018-12-19

< bitcoin-git> [bitcoin] hebasto opened pull request #15007: qt: Notificator class refactoring (master...20181219-notificator-enhancement) https://github.com/bitcoin/bitcoin/pull/15007
< bitcoin-git> [bitcoin] achow101 opened pull request #15006: Add option to create an encrypted wallet (master...create-encrypted-wallet) https://github.com/bitcoin/bitcoin/pull/15006
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15005: test: Bump timeout to run tests in travis thread sanitizer (master...Mf1812-testBumpTimeout) https://github.com/bitcoin/bitcoin/pull/15005
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15004: [WIP] [do not merge] fix OSX notification bug (master...2018/12/osx_notification_fix) https://github.com/bitcoin/bitcoin/pull/15004
< luke-jr> https://github.com/bitcoin/bitcoin/pull/14228 should probably get backported?
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15004: [WIP] [do not merge] fix OSX notification bug (master...2018/12/osx_notification_fix) https://github.com/bitcoin/bitcoin/pull/15004
< bitcoin-git> [bitcoin] practicalswift closed pull request #14226: mempool: Fix unintended unsigned integer wraparound in CTxMemPool::UpdateAncestorsOf(bool add, …) when add is false (master...fix-integer-wraparound-in-calculation-of-updateSize-in-UpdateAncestorsOf) https://github.com/bitcoin/bitcoin/pull/14226
< bitcoin-git> [bitcoin] practicalswift closed pull request #13382: util: Don't throw in GetTime{Millis,Micros}(). Mark as noexcept. (master...dont-throw-in-GetTimeMillis-and-GetTimeMicros) https://github.com/bitcoin/bitcoin/pull/13382
< bitcoin-git> [bitcoin] laanwj closed pull request #14993: rpc: Fix data race (UB) in InterruptRPC() (master...rpc-datarace) https://github.com/bitcoin/bitcoin/pull/14993
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f080c65a09a8...cb52cee29d0d
< bitcoin-git> bitcoin/master 6c10037 practicalswift: rpc: Fix data race (UB) in InterruptRPC()
< bitcoin-git> bitcoin/master cb52cee Wladimir J. van der Laan: Merge #14993: rpc: Fix data race (UB) in InterruptRPC()...
< gribble> https://github.com/bitcoin/bitcoin/issues/15002 | 0.17: Backport #14941 by promag · Pull Request #15002 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15002: 0.17: Backport #14941 (0.17...2018-12-backport-14941) https://github.com/bitcoin/bitcoin/pull/15002
< gribble> https://github.com/bitcoin/bitcoin/issues/14993 | rpc: Fix data race (UB) in InterruptRPC() by practicalswift · Pull Request #14993 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11827 | Address changes should be visible to the user · Issue #11827 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #15000: qt: Fix broken notificator on GNOME (master...20181218-fix-notificator) https://github.com/bitcoin/bitcoin/pull/15000
< gribble> https://github.com/bitcoin/bitcoin/issues/14995 | possible deadlock with walletpassphrase · Issue #14995 · bitcoin/bitcoin · GitHub

2018-12-18

< bitcoin-git> [bitcoin] Empact opened pull request #14998: [WIP] Run CI against ubuntu 14.04 (master...qt52) https://github.com/bitcoin/bitcoin/pull/14998
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4197812d47d...f080c65a09a8
< bitcoin-git> bitcoin/master fa9a5bc MarcoFalke: RPCHelpMan: Support required arguments after optional ones
< bitcoin-git> bitcoin/master f080c65 MarcoFalke: Merge #14875: RPCHelpMan: Support required arguments after optional ones...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14875: RPCHelpMan: Support required arguments after optional ones (master...Mf1812-rpcOptional) https://github.com/bitcoin/bitcoin/pull/14875
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f055389cb957...d4197812d47d
< bitcoin-git> bitcoin/master fa0d3c4 MarcoFalke: test: Undo thread_local g_insecure_rand_ctx
< bitcoin-git> bitcoin/master fa61202 MarcoFalke: test: Add comment to g_insecure_rand_ctx
< bitcoin-git> bitcoin/master d419781 MarcoFalke: Merge #14985: test: Remove thread_local from test_bitcoin...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14985: test: Remove thread_local from test_bitcoin (master...Mf1812-testNoThreadLocal) https://github.com/bitcoin/bitcoin/pull/14985
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14829: travis: Enable functional tests in the ThreadSanitizer (TSan) build job (master...tsan) https://github.com/bitcoin/bitcoin/pull/14829
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b545a7e33775...f055389cb957
< bitcoin-git> bitcoin/master 069752b practicalswift: build: Enable functional tests in the ThreadSanitizer (TSan) build job
< bitcoin-git> bitcoin/master 5e5138a Chun Kuan Lee: travis: Use trap and set -e errtrace
< bitcoin-git> bitcoin/master eaf4070 practicalswift: Add suppression for InterruptRPC (fRPCRunning) data race
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14950: docs: add NSIS setup/install steps to windows docs (master...rebase-update-windows-nsis) https://github.com/bitcoin/bitcoin/pull/14950
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7b88ecbc920...b545a7e33775
< bitcoin-git> bitcoin/master 82687b5 luciana: docs: add NSIS setup/install steps to windows docs
< bitcoin-git> bitcoin/master b545a7e MarcoFalke: Merge #14950: docs: add NSIS setup/install steps to windows docs...
< instagibbs> this seems like an odd magic number in the mempool caching code: https://github.com/bitcoin/bitcoin/blob/master/src/txmempool.cpp#L603
< gribble> https://github.com/bitcoin/bitcoin/issues/14981 | rpc: Clarifying RPC getrawtransactions time help text by benthecarman · Pull Request #14981 · bitcoin/bitcoin · GitHub
< sat11> thx bitcoin
< bitcoin-git> [bitcoin] practicalswift opened pull request #14993: rpc: Fix data race (UB) in InterruptRPC() (master...rpc-datarace) https://github.com/bitcoin/bitcoin/pull/14993
< bitcoin-git> [bitcoin] benthecarman closed pull request #14977: rpc: GetKeyOrigin check in getaddressinfo RPC (master...getaddressinfo_rpc_refactor_GetKeyOrigin) https://github.com/bitcoin/bitcoin/pull/14977
< bitcoin-git> [bitcoin] hebasto closed pull request #14990: qt: Use bilinear filtering for icon (master...20181218-icon-bilinear-filtering) https://github.com/bitcoin/bitcoin/pull/14990
< bitcoin-git> [bitcoin] suprraz opened pull request #14991: Doc build macos (master...doc_build_macos) https://github.com/bitcoin/bitcoin/pull/14991
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14975: qt: Refactoring with QString::toNSString() (master...20181216-macos-shownotification-refactor) https://github.com/bitcoin/bitcoin/pull/14975
< bitcoin-git> [bitcoin] hebasto opened pull request #14990: qt: Use bilinear filtering for icon (master...20181218-icon-bilinear-filtering) https://github.com/bitcoin/bitcoin/pull/14990
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27f5a295d740...e7b88ecbc920
< bitcoin-git> bitcoin/master 4d454dc Hennadii Stepanov: Refactoring with QString::toNSString...
< bitcoin-git> bitcoin/master e7b88ec Jonas Schnelli: Merge #14975: qt: Refactoring with QString::toNSString()...
< gkrizek> Looking at the master branch in bitcoin/bitcoin, I see a lot of PRs are merged with failing tests. Why is this? Are the tests just flaky?
< gkrizek> I requested an invite to the Bitcoin Core Slack and haven't heard anything. How can I get an invite? Is IRC or Slack used more?
< bitcoin-git> [bitcoin] MeshCollider closed pull request #14957: wallet: Initialize stop_block in CWallet::ScanForWalletTransactions (master...stop-block-null) https://github.com/bitcoin/bitcoin/pull/14957
< bitcoin-git> [bitcoin] MeshCollider pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b545a6e68965...27f5a295d740
< bitcoin-git> bitcoin/master 8b9171c Ben Woosley: wallet: Initialize stop_block to nullptr in CWallet::ScanForWalletTransactions...
< bitcoin-git> bitcoin/master 27f5a29 MeshCollider: Merge #14957: wallet: Initialize stop_block in CWallet::ScanForWalletTransactions...
< bitcoin-git> [bitcoin] fanquake closed pull request #14989: Delete JSON-RPC-interface.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14989
< bitcoin-git> [bitcoin] xujc opened pull request #14989: Delete JSON-RPC-interface.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14989

2018-12-17

< bitcoin-git> [bitcoin] benthecarman opened pull request #14988: Number of confirmations added to transaction csv export (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14987: [rcp] RPCHelpMan: Require documentation of return value at compile time (master...Mf1812-rpcResultFlat) https://github.com/bitcoin/bitcoin/pull/14987
< bitcoin-git> [bitcoin] laanwj deleted 0.11 at 0bace83: https://github.com/bitcoin/bitcoin/commit/0bace83
< bitcoin-git> [bitcoin] laanwj deleted 0.12 at c1b7421: https://github.com/bitcoin/bitcoin/commit/c1b7421
< bitcoin-git> [bitcoin] laanwj deleted 0.13 at b654842: https://github.com/bitcoin/bitcoin/commit/b654842
< gribble> https://github.com/bitcoin/bitcoin/issues/14968 | http: Fail initialization when any bind fails by laanwj · Pull Request #14968 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14985: test: Remove thread_local from test_bitcoin (master...Mf1812-testNoThreadLocal) https://github.com/bitcoin/bitcoin/pull/14985
< bitcoin-git> [bitcoin] promag opened pull request #14984: rpc: Speedup getrawmempool when verbose=true (master...2018-12-speedup-getrawmempool) https://github.com/bitcoin/bitcoin/pull/14984
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14964: test: Fix race in mempool_accept (master...Mf1812-testRaceMempoolAccept) https://github.com/bitcoin/bitcoin/pull/14964
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bfd7e5409720...b545a6e68965
< bitcoin-git> bitcoin/master faee591 MarcoFalke: test: Fix race in mempool_accept
< bitcoin-git> bitcoin/master b545a6e MarcoFalke: Merge #14964: test: Fix race in mempool_accept...
< gribble> https://github.com/bitcoin/bitcoin/issues/14983 | One Travis instance should run minimum supported QT version · Issue #14983 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14884 | Travis: enforce Python 3.4 support through linter by Sjors · Pull Request #14884 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #14982: rpc: Add getrpcinfo command (master...2018-12-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/14982
< bitcoin-git> [bitcoin] benthecarman opened pull request #14981: Clarifying RPC getrawtransaction's time help text (master...getrawtransaction_help_text_fix) https://github.com/bitcoin/bitcoin/pull/14981
< fanquake> lambolife Ask in #bitcoin instead, that'll be off-topic here.
< lambolife> What's the latest update in Bitcoin's development so far. I'm gonna make a video about not to give Hopium but to present facts. So I;m here
< bitcoin-git> [bitcoin] laanwj closed pull request #14979: [Qt] Restore < Qt5.6 compatibility for addAction (master...2018/12/fix_addaction) https://github.com/bitcoin/bitcoin/pull/14979
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/34241716852d...bfd7e5409720
< bitcoin-git> bitcoin/master 3e21b69 Jonas Schnelli: [Qt] Restore < Qt5.6 compatibility for addAction
< bitcoin-git> bitcoin/master bfd7e54 Wladimir J. van der Laan: Merge #14979: [Qt] Restore < Qt5.6 compatibility for addAction...
< gribble> https://github.com/bitcoin/bitcoin/issues/14979 | [Qt] Restore < Qt5.6 compatibility for addAction by jonasschnelli · Pull Request #14979 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14979 | [Qt] Restore < Qt5.6 compatibility for addAction by jonasschnelli · Pull Request #14979 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7759 | [WIP] rest: Stream entire utxo set by laanwj · Pull Request #7759 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #14979: [Qt] Restore < Qt5.6 compatibility for addAction (master...2018/12/fix_addaction) https://github.com/bitcoin/bitcoin/pull/14979
< bitcoin-git> [bitcoin] gwillen opened pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
< Silb> How active is the Bitcoin core irc channel?

2018-12-16

< bitcoin-git> [bitcoin] benthecarman opened pull request #14977: GetKeyOrigin check in getaddressinfo RPC (master...getaddressinfo_rpc_refactor_GetKeyOrigin) https://github.com/bitcoin/bitcoin/pull/14977
< bitcoin-git> [bitcoin] hebasto opened pull request #14975: qt: Refactoring with QString::toNSString() (master...20181216-macos-shownotification-refactor) https://github.com/bitcoin/bitcoin/pull/14975
< bitcoin-git> [bitcoin] benthecarman opened pull request #14974: Removing redundant line: "Windows XP not supported" (master...release_notes_doc) https://github.com/bitcoin/bitcoin/pull/14974
< bitcoin-git> [bitcoin] murrayn opened pull request #14973: Improve Windows native build instructions (master...win_build_doc) https://github.com/bitcoin/bitcoin/pull/14973
< bitcoin-git> [bitcoin] laanwj closed pull request #14969: tests: Fix cuckoocache_tests TSAN failure introduced in 14935. (master...cuckoocache_tests) https://github.com/bitcoin/bitcoin/pull/14969
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dba0f4c5c74c...34241716852d
< bitcoin-git> bitcoin/master d98a29e practicalswift: Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.
< bitcoin-git> bitcoin/master 3424171 Wladimir J. van der Laan: Merge #14969: tests: Fix cuckoocache_tests TSAN failure introduced in 14935....
< bitcoin-git> [bitcoin] fellowserf opened pull request #14972: Master (master...master) https://github.com/bitcoin/bitcoin/pull/14972
< bitcoin-git> [bitcoin] fellowserf closed pull request #14972: Master (master...master) https://github.com/bitcoin/bitcoin/pull/14972
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9133227298ad...dba0f4c5c74c
< bitcoin-git> bitcoin/master 9ea38d0 João Barbosa: qt: Allow to inspect RPCConsole tabs
< bitcoin-git> bitcoin/master a96c0df João Barbosa: qt: Add Window menu
< bitcoin-git> bitcoin/master 95a5a9f João Barbosa: qt: Remove ellipsis from sending/receiving addresses...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14573: qt: Add Window menu (master...2018-10-overhaul-menus) https://github.com/bitcoin/bitcoin/pull/14573

2018-12-15

< bitcoin-git> [bitcoin] Emzy opened pull request #14970: [net] add dnsseed.emzy.de to DNS seeds (master...dns-seed-emzy) https://github.com/bitcoin/bitcoin/pull/14970
< bitcoin-git> [bitcoin] practicalswift opened pull request #14969: Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. (master...cuckoocache_tests) https://github.com/bitcoin/bitcoin/pull/14969
< bitcoin-git> [bitcoin] laanwj opened pull request #14968: http: Fail initialization when any bind fails (master...2018_12_http_bind_error) https://github.com/bitcoin/bitcoin/pull/14968
< gribble> https://github.com/bitcoin/bitcoin/issues/14935 | tests: Test for expected return values when calling functions returning a success code by practicalswift · Pull Request #14935 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14967 | TSAN issue in cuckoocache_erase_parallel_ok test after 14935 · Issue #14967 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14635: developer-notes: allow lowerCamelCase (master...pr/camelow) https://github.com/bitcoin/bitcoin/pull/14635
< bitcoin-git> [bitcoin] 1Il1 opened pull request #14966: fix testmempoolaccept CLI syntax (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14966
< bitcoin-git> [bitcoin] isghe opened pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965
< gribble> https://github.com/bitcoin/bitcoin/issues/14902 | v0.17.1 testing · Issue #14902 · bitcoin/bitcoin · GitHub

2018-12-14

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14964: test: Fix race in mempool_accept (master...Mf1812-testRaceMempoolAccept) https://github.com/bitcoin/bitcoin/pull/14964
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14963: doc: Add comment to cs_main and mempool::cs (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963
< sipa> anyone know why https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/21022194 (#14955) is failing?
< gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] DrahtBot closed pull request #13200: Process logs in a separate thread (master...2018-05-asynclog) https://github.com/bitcoin/bitcoin/pull/13200
< bitcoin-git> [bitcoin] ch4ot1c opened pull request #14961: [docs] Root readme improvements (master...improvements/readme) https://github.com/bitcoin/bitcoin/pull/14961
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
< jnewbery> IsMine moved from wallet to common here: https://github.com/bitcoin/bitcoin/commit/a25a4f5b04c3e045557e9e7e807b2af74ad75128 . Was that just because of the way the multisig and P2SH tests are constructed (ie could those tests just be rewritten)?
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< luke-jr> phantomcircuit: I answered in #bitcoin fyi
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6723d8e3a694...9133227298ad
< bitcoin-git> bitcoin/master c84c2b8 practicalswift: tests: Test for expected return values when calling functions returning a success code
< bitcoin-git> bitcoin/master 9133227 MarcoFalke: Merge #14935: tests: Test for expected return values when calling functions returning a success code...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b53573e5c6c7...6723d8e3a694
< bitcoin-git> bitcoin/master fa30a0e MarcoFalke: test: mempool_persist: Verify prioritization is dumped correctly
< bitcoin-git> bitcoin/master 6723d8e MarcoFalke: Merge #14931: test: mempool_persist: Verify prioritization is dumped correctly...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14931: test: mempool_persist: Verify prioritization is dumped correctly (master...Mf1812-testMempoolPrio) https://github.com/bitcoin/bitcoin/pull/14931
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< jnewbery> yes, both there already: https://github.com/bitcoin/bitcoin/projects/8
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a30e0f6c544...b53573e5c6c7
< bitcoin-git> bitcoin/master faa8311 MarcoFalke: Revert "tests: Support calling add_nodes more than once"...
< bitcoin-git> bitcoin/master fa4b8c9 MarcoFalke: test: add_nodes can only be called once after set_test_params
< bitcoin-git> bitcoin/master b53573e MarcoFalke: Merge #14951: Revert "tests: Support calling add_nodes more than once"...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14951: Revert "tests: Support calling add_nodes more than once" (master...Mf1812-TestrevertAddNodes) https://github.com/bitcoin/bitcoin/pull/14951
< bitcoin-git> [bitcoin] ch4ot1c closed pull request #14601: [rpc] Descriptions: Consistent arg labels for types 'object', 'array', 'boolean', and 'string' (master...fix/rpc-arg-types) https://github.com/bitcoin/bitcoin/pull/14601
< jnewbery> luke-jr: https://github.com/bitcoin/bips/pull/745 is ready for merge
< bitcoin-git> [bitcoin] luke-jr opened pull request #14960: lint/format-strings: Correctly exclude escaped percent symbols (master...bugfix_lint_fmtstr) https://github.com/bitcoin/bitcoin/pull/14960
< bitcoin-git> [bitcoin] promag opened pull request #14958: qa: Remove race between conneting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958
< bitcoin-git> [bitcoin] AkioNak closed pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919
< gribble> https://github.com/bitcoin/bitcoin/issues/14948 | Error when running gmake check on NetBSD 8.0 · Issue #14948 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14902 | v0.17.1 testing · Issue #14902 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj reopened pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919
< bitcoin-git> [bitcoin] kallewoof closed pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
< bitcoin-git> [bitcoin] kallewoof closed pull request #13430: use IsBlockPruned() where appropriate (master...use-isblockpruned) https://github.com/bitcoin/bitcoin/pull/13430
< fanquake> Also sipa, the new RNG changes build on macOS, but are failing on the thread sanitizer travis job: https://travis-ci.org/bitcoin/bitcoin/jobs/467863069
< bitcoin-git> [bitcoin] Empact opened pull request #14957: wallet: Initialize stop_block to nullptr in CWallet::ScanForWalletTransactions (master...stop-block-null) https://github.com/bitcoin/bitcoin/pull/14957
< gribble> https://github.com/bitcoin/bitcoin/issues/14902 | v0.17.1 testing · Issue #14902 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] bpay opened pull request #14956: [qt] Ensure tx send error highlight is visible (master...show-highlighted-field) https://github.com/bitcoin/bitcoin/pull/14956
< bitcoin-git> [bitcoin] sipa opened pull request #14955: Switch all RNG code to the built-in PRNG (master...201812_generic_rand) https://github.com/bitcoin/bitcoin/pull/14955
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< meshcollider> because you can still look at https://github.com/bitcoin/bitcoin/commits/master
< gmaxwell> In the bitcoin project. We never commit directly to master. (I believe that no adays that is an absolute never)
< gribble> https://github.com/bitcoin/bitcoin/issues/14953 | test: Make g_insecure_rand_ctx thread_local by MarcoFalke · Pull Request #14953 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider closed pull request #14821: Replace CAffectedKeysVisitor with descriptor based logic (master...201810_die_caffectedkeysvisitor_die) https://github.com/bitcoin/bitcoin/pull/14821
< bitcoin-git> [bitcoin] MeshCollider pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5aea9654f36...7a30e0f6c544
< bitcoin-git> bitcoin/master 0e75f44 Pieter Wuille: Replace CAffectedKeysVisitor with descriptor based logic
< bitcoin-git> bitcoin/master 7a30e0f MeshCollider: Merge #14821: Replace CAffectedKeysVisitor with descriptor based logic...
< gmaxwell> I'm no longer a commiter on bitcoin, I'd be interested in knowing how often commiters are manually resolving conflicts on master. I believe the answer is rarely but not never.
< gmaxwell> promag: never saw people ack specific commits? a lotof people do it consistently. e.g. first merged commit of yours I clicked on https://github.com/bitcoin/bitcoin/pull/14885#issuecomment-445561532
< harding> lopp: under the default GitHub settings, anyone with commit access can push anything they want, so they could pull a PR into a private branch, modify it, merge it locally, and push it. Some projects enable GitHub settings that prevent direct pushes like that to the master branch, but I'm not sure whether Bitcoin Core uses them. Alternatively, when you open a GitHub PR, a box is checked by default that allows people with commit

2018-12-13

< gmaxwell> moreover, that data is there-- go use a block explorer, there is no need a bitcoin wallet or node need to provide it.
< gmaxwell> To actually _use_ bitcoin I need that data... vs history is needed for analysis/auditing/etc purposes.
< gmaxwell> but like, _ignoring that_ (lol), in terms of actually switching bitcoin to use it, I expect it would be easier than utxotree.
< gmaxwell> But "oh look spending patterns changed and with no impact in fees, bandwidth needed by bitcoin nodes just went up 5x" isn't the same as saying dbcache works better with more locality.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14953: test: Make g_insecure_rand_ctx thread_local (master...Mf1812-testThreadLocal) https://github.com/bitcoin/bitcoin/pull/14953
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a4334443085...a5aea9654f36
< bitcoin-git> bitcoin/master faead93 MarcoFalke: test: Make g_insecure_rand_ctx thread_local
< bitcoin-git> bitcoin/master a5aea96 MarcoFalke: Merge #14953: test: Make g_insecure_rand_ctx thread_local...
< treyzania> inb4 bitcoin node in coq
< gmaxwell> unless you think that downloading bitcoin node software written by other people and not doing the work of writing it yourself is giving up. :P
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14954: WIP: build: Require python 3.5 (master...Mf1811-buildPython3) https://github.com/bitcoin/bitcoin/pull/14954
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< jamesob> (for anyone curious about rolling UTXO set hashes: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-May/014337.html)
< gmaxwell> jamesob: and moreover, with the exception of ultra high end commercial installs, few users would have the resources or patience to fetch 15 years of bitcoin history.
< luke-jr> jamesob: making light wallets stronger has a negative impact on Bitcoin :/
< gribble> https://github.com/bitcoin/bitcoin/issues/13014 | Allow txindex in prune mode by jonasschnelli · Pull Request #13014 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14035 | Utxoscriptindex by mgrychow · Pull Request #14035 · bitcoin/bitcoin · GitHub
< wumpus> it shouldn't be that anything non-trivial needs to end up[ in bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
< wumpus> bitcoin core is not meant as a chain analysis platform
< gmaxwell> from all I've heard running bitcoin on windows 10 sounds like it's probably a bad idea in general.
< gribble> https://github.com/bitcoin/bitcoin/issues/14881 | Tests: Contract testing for the procedure AddTimeData by mmachicao · Pull Request #14881 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14953: test: Make g_insecure_rand_ctx thread_local (master...Mf1812-testThreadLocal) https://github.com/bitcoin/bitcoin/pull/14953
< gribble> https://github.com/bitcoin/bitcoin/issues/14922 | [WIP] windows: Set _WIN32_WINNT to 0x0601 (Windows 7) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility Notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus> jamesob: it contains writable settings which override what is in bitcoin.conf
< jamesob> *bitcoin.conf.qt
< wumpus> I'm unconfortable with writing to bitcoin.conf directly, as it is specified with -conf, which might point to a read-only configuration file, it should not be assumed it is writable
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< sipa> and have the GUI (where you really want everything to be modifable) directly modify bitcoin.conf
< wumpus> don't write to bitcoin.conf, never
< wumpus> we definitely don't want to write to bitcoin.conf directly, but having a separate configuration file that's writable is fine
< gribble> https://github.com/bitcoin/bitcoin/issues/12833 | [qt] move QSettings to bitcoin_rw.conf where possible by Sjors · Pull Request #12833 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 three PRs left on the list right now: #14336 #14565 #14573
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14951 | Revert "tests: Support calling add_nodes more than once" by MarcoFalke · Pull Request #14951 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14849 | depends: qt 5.9.7 by fanquake · Pull Request #14849 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14741 | doc: Indicate -rpcauth option password hashing alg by dongcarl · Pull Request #14741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14319 | doc: Fix PSBT howto and example parameters by priscoan · Pull Request #14319 · bitcoin/bitcoin · GitHub

2018-12-12

< gribble> https://github.com/bitcoin/bitcoin/issues/14641 | rpc: Add min_conf option to fund transaction calls by promag · Pull Request #14641 · bitcoin/bitcoin · GitHub
< andytoshi> ok. the reason i ask is that in Elements we are directly using sha2 midstates to get the same speedup (which ofc changes the hash function so is completely incompatible with bitcoin)
< gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
< andytoshi> sipa: i'm confused by https://github.com/bitcoin/bitcoin/pull/13191 ... it seems the new SHA256D64 does not append the sha256 length/padding anywhere, so how can `ComputeMerkleRoot` be consensus-compatible with the old code?
< bitcoin-git> [bitcoin] mrwhythat closed pull request #14476: RPC method 'encodescript' (master...encodescript-rpc) https://github.com/bitcoin/bitcoin/pull/14476
< bitcoin-git> [bitcoin] lontivero opened pull request #14939: rpc: Add test_accept_unsigned flag to testmempoolaccept (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939
< bitcoin-git> [bitcoin] laanwj closed pull request #14914: Docs: Add nice table to files.md (master...add-nice-table) https://github.com/bitcoin/bitcoin/pull/14914
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc2822b9dc9...38fb1b40dfb3
< bitcoin-git> bitcoin/master 9b51b15 Emil Engler: Add nice table to files.md...
< bitcoin-git> bitcoin/master 38fb1b4 Wladimir J. van der Laan: Merge #14914: Docs: Add nice table to files.md...
< bitcoin-git> [bitcoin] Sjors opened pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14937: travis: fix travis would always be green even if it fail (master...travis-fix-save-cache-2) https://github.com/bitcoin/bitcoin/pull/14937
< gribble> https://github.com/bitcoin/bitcoin/issues/14914 | Docs: Add nice table to files.md by emilengler · Pull Request #14914 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (master...add-build-version-to-info-plist) https://github.com/bitcoin/bitcoin/pull/14701
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96bde4f01f41...edc2822b9dc9
< bitcoin-git> bitcoin/master 8e20934 fanquake: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString
< bitcoin-git> bitcoin/master edc2822 Wladimir J. van der Laan: Merge #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString...
< fanquake> wumpus fair enough. If you agree with my comments here, https://github.com/bitcoin/bitcoin/pull/14922#issuecomment-446585696, I'll add that to 0.18.0 and ask ken to update (including docs).
< wumpus> +indeed, as timothy says, using an unsupported OS for bitcoin is kind of stupid
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< timothy> do you REALLY want to run something like bitcoin on an unsupported OS?
< bitcoin-git> [bitcoin] practicalswift opened pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935
< fanquake> Would be interested to know if there are many/any? users running Bitcoin-Core on Windows Vista. Could use some more input in #14922.
< gribble> https://github.com/bitcoin/bitcoin/issues/14922 | windows: Set _WIN32_WINNT to 0x0600 (Windows Vista) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14909: doc: Update minimum required Qt (master...doc-qt-minimum-52) https://github.com/bitcoin/bitcoin/pull/14909
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed2a2cebd362...96bde4f01f41
< bitcoin-git> bitcoin/master b7bee6a fanquake: doc: Update minimum required qt
< bitcoin-git> bitcoin/master 96bde4f Wladimir J. van der Laan: Merge #14909: doc: Update minimum required Qt...
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
< bitcoin-git> [bitcoin] hebasto closed pull request #14905: scripted-diff: Replace deprecated C headers (master...20181209-replace-c-headers) https://github.com/bitcoin/bitcoin/pull/14905
< provoostenator> Maybe it should do a diff against bitcoin/contrib/gitian-builder.py after it checks out the branch and then prompt the user.
< provoostenator> For signing stuff on your local machine (instead of inside the VM) and pushing to Github, this maybe useful: https://github.com/bitcoin-core/docs/issues/18#issue-292936112
< bitcoin-git> [bitcoin] MeshCollider pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fff1ab817e7...ed2a2cebd362
< bitcoin-git> bitcoin/master bb24d68 Ben Woosley: Make CWallet::ScanForWalletTransactions args and return value const
< bitcoin-git> bitcoin/master 3002d6c Ben Woosley: Return a status enum from ScanForWalletTransactions...
< bitcoin-git> bitcoin/master bd3b036 Ben Woosley: Add stop_block out arg to ScanForWalletTransactions...
< bitcoin-git> [bitcoin] MeshCollider closed pull request #13076: Fix ScanForWalletTransactions to return an enum indicating scan result: success / failure / user_abort (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
< bitcoin-git> [bitcoin] MeshCollider pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/f65bce858f26...3fff1ab817e7
< bitcoin-git> bitcoin/master 6be0fb4 Pieter Wuille: [refactor] Add a base DescriptorImpl with most common logic
< bitcoin-git> bitcoin/master 24d3a7b Pieter Wuille: [refactor] Use DescriptorImpl internally, permitting access to new methods
< bitcoin-git> bitcoin/master 1eda33a Pieter Wuille: [refactor] Combine the ToString and ToPrivateString implementations
< bitcoin-git> [bitcoin] MeshCollider closed pull request #14646: Add expansion cache functions to descriptors (unused for now) (master...201811_descriptcache) https://github.com/bitcoin/bitcoin/pull/14646