2016-07-19

< jonasschnelli> 19499e5a569d5d8685a043bf3e5cf9d34450733333295b636af84d7a2589d881 bitcoin-0.13.0-x86_64-linux-gnu.tar.gz
< jonasschnelli> linux build complete: hashes to compare: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
< wumpus> yes --url bitcoin=${URI} --commit bitcoin=${COMMIT} can be very useful. You can also use local paths.
< jonasschnelli> stuff like: --url bitcoin="+giturl+"
< jonasschnelli> I had to add some html / apaxy hacks to get the html pages up: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
< GitHub180> [bitcoin] jonasschnelli opened pull request #8369: [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369
< * MarcoFalke> googles "release process bitcoin" and copies the commands
< GitHub184> bitcoin/0.13 d6bb231 Wladimir J. van der Laan: Merge #8360: doc: Add a few items to release notes...
< GitHub126> [bitcoin] laanwj closed pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360
< GitHub184> bitcoin/0.13 ded0599 Wladimir J. van der Laan: doc: Add a few items to release notes...
< GitHub184> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/ec8f5fc8b5f6...d6bb231a9fa9
< GitHub184> bitcoin/0.13 ec8f5fc Wladimir J. van der Laan: doc: Add list of pulls and authors to release notes
< GitHub184> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/ec8f5fc8b5f68ddf7fed0d74a5ec82e6b03f7f92
< GitHub48> bitcoin/0.13 24f117e Wladimir J. van der Laan: Merge #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets...
< GitHub48> bitcoin/0.13 3b38a6a Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
< GitHub68> [bitcoin] laanwj closed pull request #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366
< GitHub48> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/fca1a415cec6...24f117ef05f5
< GitHub41> [bitcoin] laanwj closed pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367
< GitHub123> bitcoin/master 045106b Wladimir J. van der Laan: Merge #8367: [Wallet] Ensure <0.13 clients can't open HD wallets...
< GitHub123> bitcoin/master a4f137f Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
< GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca7550e128a3...045106b4f13c
< GitHub24> bitcoin/0.13 fca1a41 Suhas Daftuar: Rename "block cost" to "block weight"...
< GitHub24> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/fca1a415cec6b7655448ce8b30778784ab4c181e
< GitHub19> [bitcoin] laanwj closed pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363
< GitHub70> bitcoin/master ca7550e Wladimir J. van der Laan: Merge #8363: Rename "block cost" to "block weight"...
< GitHub70> bitcoin/master 2c06bae Suhas Daftuar: Rename "block cost" to "block weight"
< GitHub70> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e3557b8e363...ca7550e128a3
< GitHub99> [bitcoin] laanwj closed pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361
< GitHub114> bitcoin/0.13 a07c8a0 Wladimir J. van der Laan: Merge #8361: Some 0.13 release notes about p2p changes...
< GitHub114> bitcoin/0.13 df85463 Pieter Wuille: Some 0.13 release notes about p2p changes
< GitHub114> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/37269105c881...a07c8a032c0d

2016-07-18

< GitHub83> [bitcoin] jonasschnelli opened pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367
< GitHub57> [bitcoin] jonasschnelli closed pull request #8343: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8343
< GitHub175> [bitcoin] jonasschnelli opened pull request #8366: [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366
< GitHub89> [bitcoin] sipa opened pull request #8365: Treat high-sigop transactions as larger rather than rejecting them (master...unifysigopcost) https://github.com/bitcoin/bitcoin/pull/8365
< GitHub50> [bitcoin] f139975 opened pull request #8364: Fix counting of sigops cost in mempool check (master...fix-mempool-sigops) https://github.com/bitcoin/bitcoin/pull/8364
< GitHub36> [bitcoin] sdaftuar opened pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363
< luke-jr> of prior versions of Bitcoin
< GitHub116> [bitcoin] sdaftuar opened pull request #8362: Scale legacy sigop count in CreateNewBlock (master...coinbase-sigops-scale) https://github.com/bitcoin/bitcoin/pull/8362
< sdaftuar> sipa: luke-jr: speaking of sigops, i just noticed this, looks like a bug? https://github.com/bitcoin/bitcoin/blob/master/src/miner.cpp#L190
< jonasschnelli> ah... IBD is also true if I start bitcoin-core with 200 blocks behind. Right?
< GitHub87> [bitcoin] sipa opened pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361
< GitHub75> [bitcoin] laanwj opened pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360
< GitHub181> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/37269105c8817a2922410ec17d976263cd589987
< GitHub181> bitcoin/0.13 3726910 Wladimir J. van der Laan: build: Release notes update...
< GitHub24> bitcoin/master 5e3557b Wladimir J. van der Laan: doc: Clean out release notes...
< GitHub24> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/5e3557b8e36308a27dbeb528569abe638c4d01dd
< wumpus> for 0.13 there's still plenty of work to do for the release notes: https://github.com/bitcoin/bitcoin/issues/7678
< GitHub85> bitcoin/master 6c0336c Wladimir J. van der Laan: build: bump version to 0.13.99...
< GitHub85> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/6c0336c7723da274c8312b82ed2a138f5d57158f
< GitHub83> bitcoin/master e4382fb Wladimir J. van der Laan: qt: periodic translations update
< GitHub83> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/e4382fbef56a0e04b0ed834e8b3a3a16f81db149
< GitHub184> [bitcoin] laanwj closed pull request #8359: mining: Improve `-blockmaxcost` help message (master...2016_07_blockmaxcost_doc) https://github.com/bitcoin/bitcoin/pull/8359
< GitHub67> bitcoin/master 03c56f6 Wladimir J. van der Laan: Merge #8359: mining: Improve `-blockmaxcost` help message...
< GitHub67> bitcoin/master 8cef5bd Wladimir J. van der Laan: mining: Improve `-blockmaxcost` help message...
< GitHub67> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8cb288a6b37d...03c56f62c2fd
< GitHub7> [bitcoin] laanwj opened pull request #8359: mining: Improve `-blockmaxcost` help message (master...2016_07_blockmaxcost_doc) https://github.com/bitcoin/bitcoin/pull/8359
< GitHub191> [bitcoin] MarcoFalke opened pull request #8358: [doc] gbuild: Set memory explicitly (default is too low) (master...Mf1607-docBuild) https://github.com/bitcoin/bitcoin/pull/8358
< GitHub77> [bitcoin] laanwj closed pull request #8354: mining: Rename `-blockmaxcost` to `-blockmaxweight` (master...2016_07_block_weight) https://github.com/bitcoin/bitcoin/pull/8354
< GitHub20> [bitcoin] MarcoFalke closed pull request #7615: [WIP] [wallet] Couple minimum change with minimum relay fee (master...Mf1602-walletMinChange) https://github.com/bitcoin/bitcoin/pull/7615
< GitHub49> [bitcoin] laanwj closed pull request #8320: Fix 0.12 release notes on block relaying (master...0.12-release-notes-block-relaying) https://github.com/bitcoin/bitcoin/pull/8320
< GitHub5> bitcoin/master 8cb288a Wladimir J. van der Laan: Merge #8320: Fix 0.12 release notes on block relaying...
< GitHub5> bitcoin/master d6dc1bc Krzysztof Jurewicz: Fix 0.12 release notes on block relaying...
< GitHub5> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f5660d381a37...8cb288a6b37d
< GitHub127> [bitcoin] maiiz opened pull request #8357: Update coins.cpp (master...maiiz-patch-1) https://github.com/bitcoin/bitcoin/pull/8357
< GitHub190> [bitcoin] NicolasDorier opened pull request #8356: Wallet: Minimum output value depends on fee instead of minTxRelayFee (master...wallet-min-output) https://github.com/bitcoin/bitcoin/pull/8356
< GitHub94> [bitcoin] maiiz closed pull request #8355: [Wallet]fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8355
< GitHub46> [bitcoin] maiiz opened pull request #8355: [Wallet]fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8355
< GitHub37> [bitcoin] laanwj closed pull request #8295: Mining-related fixups for 0.13.0 (master...cnb-segwit) https://github.com/bitcoin/bitcoin/pull/8295
< GitHub81> bitcoin/master d2e46e1 Suhas Daftuar: Remove addScoreTxs()
< GitHub81> bitcoin/master 6dd4bc2 Suhas Daftuar: Exclude witness transactions in addPackageTxs() pre-segwit activation
< GitHub81> bitcoin/master f15c2cd Suhas Daftuar: CreateNewBlock: add support for size-accounting to addPackageTxs...
< GitHub81> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/238300b39894...f5660d381a37
< GitHub68> [bitcoin] laanwj opened pull request #8354: mining: Rename `-blockmaxcost` to `-blockmaxweight` (master...2016_07_block_weight) https://github.com/bitcoin/bitcoin/pull/8354
< GitHub6> [bitcoin] laanwj closed pull request #8323: Add HD keypath to CKeyMetadata, report metadata in validateaddress (master...2016/07/hd_013) https://github.com/bitcoin/bitcoin/pull/8323
< GitHub1> bitcoin/master 986c223 Jonas Schnelli: [Wallet] print hd masterkeyid in getwalletinfo
< GitHub1> bitcoin/master b1c7b24 Jonas Schnelli: [Wallet] report optional HDKeypath/HDMasterKeyId in validateaddress
< GitHub1> bitcoin/master 5b95dd2 Jonas Schnelli: [Wallet] extend CKeyMetadata with HD keypath
< GitHub1> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/37303934fe8f...238300b39894
< GitHub135> [bitcoin] laanwj closed pull request #8305: Improve handling of unconnecting headers (master...fix-relay-2hr-rule) https://github.com/bitcoin/bitcoin/pull/8305
< GitHub121> bitcoin/master 3730393 Wladimir J. van der Laan: Merge #8305: Improve handling of unconnecting headers...
< GitHub121> bitcoin/master e91cf4b Suhas Daftuar: Add test for handling of unconnecting headers
< GitHub121> bitcoin/master 96fa953 Suhas Daftuar: Improve handling of unconnecting headers...
< GitHub121> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc94b8748782...37303934fe8f
< GitHub157> [bitcoin] maiiz closed pull request #8336: TX fees and policy: fix relaypriority calculation error Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8336
< GitHub30> [bitcoin] Tyler-Hardin closed pull request #8349: Qt: Clearer warning about being out of sync (master...issue8060) https://github.com/bitcoin/bitcoin/pull/8349

2016-07-17

< GitHub65> [bitcoin] yurizhykin opened pull request #8353: Trivial: tiny c++11 refactors (master...cpp11) https://github.com/bitcoin/bitcoin/pull/8353
< GitHub139> [bitcoin] Gitju opened pull request #8352: Trivial: Fix typo in bitcoin_es_UY.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8352
< jtimon> well, at the very least we have to maintain this failure: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3547 don't we?
< GitHub36> [bitcoin] Tyler-Hardin opened pull request #8349: Qt: Clearer warning about being out of sync (master...issue8060) https://github.com/bitcoin/bitcoin/pull/8349
< GitHub171> [bitcoin] jtimon opened pull request #8348: Trivial: Segwit: Don't call IsWitnessEnabled from ContextualCheckBlock (master...0.12.99-consensus-segwit) https://github.com/bitcoin/bitcoin/pull/8348

2016-07-16

< GitHub197> [bitcoin] jtimon opened pull request #8347: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock (master...0.12.99-consensus-const-lost) https://github.com/bitcoin/bitcoin/pull/8347
< GitHub25> [bitcoin] jtimon opened pull request #8346: Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs (master...0.12.99-consensus-mempool-checks) https://github.com/bitcoin/bitcoin/pull/8346
< GitHub120> [bitcoin] jtimon opened pull request #8345: Introduce Consensus::GetFlags() and hide IsSuperMajority() (master...0.12.99-consensus-flags) https://github.com/bitcoin/bitcoin/pull/8345
< GitHub167> [bitcoin] NicolasDorier opened pull request #8344: Consensus: Use pindex for ISM check (master...not-using-block) https://github.com/bitcoin/bitcoin/pull/8344
< luke-jr> why was https://github.com/bitcoin/bitcoin/pull/7774 merged? :/

2016-07-15

< GitHub55> [bitcoin] jonasschnelli opened pull request #8343: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8343
< GitHub167> [bitcoin] NicolasDorier opened pull request #8342: Consensus: Trivial transform BOOST_FOREACH into for loop (master...removeforeach) https://github.com/bitcoin/bitcoin/pull/8342
< GitHub29> [bitcoin] NicolasDorier opened pull request #8341: Consensus: Remove calls to error() from ContextualCheckBlock (master...error-calls) https://github.com/bitcoin/bitcoin/pull/8341
< superduper> SUPER AMAZING! I can multiply your bitcoin using block-chain exploding technology. Send me some BTC and get MUCH more back! WOW! PM me to begin!

2016-07-14

< GitHub177> [bitcoin] jtimon closed pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< jtimon> so it seems the consensus folder thing is not clear, see? not that hard to say no fast, closing #8328 and taking the renames out of https://github.com/jtimon/bitcoin/commits/0.12.99-consensus (and #8329 and #8337 )
< bsm117532> wumpus: FWIW I'm working on a commercial product that will include a bitcoin full node. It needs to fund transactions for many users, so the "label" idea sounds appropriate. But, I'll mostly be querying txids. (Which is one reason I've been working on getting segwit into python-bitcoinlib)
< petertodd> maaku: fwiw, I already do that kind of separation in python-bitcoinlib, with everything consensus under bitcoin.core
< petertodd> maaku: that's how I learned how the bitcoin protocol works
< petertodd> maaku: my usual advice to people is to follow the block acceptance logic and read the consensus code to understand how the bitcoin protocol works
<@wumpus> well if bitcoin core's wallet is unusable for commercial use, I wonder what wallet is..
< gmaxwell> I was getting flammed on reddit that it's common knoweldge that bitcoin core's wallet was unusuable for commercial use. I tried to get some unpacking there: https://www.reddit.com/r/Bitcoin/comments/4snk48/roger_ver_and_his_supporters_are_pushing_policies/d5bb73w?context=3 might be worth looking at the comments.
< petertodd> gmaxwell: well, my advice is to either use a lite-client w/ up-to-date full node, or if you're using bitcoin core, plan to put it behind an up-to-date node
< jtimon> btcdrak: I didn't knew, never used the bitcoin slack
<@wumpus> and it's not used anywhere yet in bitcoin
<@wumpus> sdaftuar: I don't think all items of https://github.com/bitcoin/bitcoin/issues/8294 are currenly being addressed in PRs?
<@wumpus> #link https://github.com/bitcoin/bitcoin/pull/8295 Mining-related fixups for 0.13.0 also by sdaftuar
<@wumpus> #link https://github.com/bitcoin/bitcoin/pull/8305 Improve handling of unconnecting headers by sdaftuar
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< sdaftuar> bsm2357: you might find it helpful to review the p2p-segwit.py test in qa/rpc-tests, see for instance https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/p2p-segwit.py#L1236
< cool_guy> ASTOUNDING! I have discovered blockchain exploding technology. Send me your bitcoin and I will return MUCH more back to you, INSTANTLY. This is totally legitimate & vouched by the OPS of this channel. PM me to begin!
< jtimon> I believe we need it for this single error message: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L1959
< jtimon> first step is completing libconsensus while allowing bitcoin core to keep using its internals
< jtimon> sipa: yeah at some point if we want to completely separate libconsensus, after bitcoin core itself calls its API, I see no other option than to duplicate some of the code in bitcoin core, but seems too far away in the future to be a big concern
< jtimon> I think it takes less time to read the changes in the makefile https://github.com/bitcoin/bitcoin/pull/8328/files#diff-480477e89f9b6ddafb30c4383dcdd705R90 than explaining but whatever...
< jtimon> if people can't review the trivial things then they will never review the cool stuff like https://github.com/jtimon/bitcoin/commit/4215929d563097f19d8059dff8b0f7d5ba7aee59
< jonasschnelli> sipa: while you are around (heh!), mind doing a quick review on https://github.com/bitcoin/bips/compare/master...jonasschnelli:2016/07/bip151_hkdf? Only technical, language will be checked by Jonathan Cross
< jtimon> in https://github.com/jtimon/bitcoin/commits/0.12.99-consensus there are big architectural changes though
< jtimon> NicolasDorier: updated https://github.com/jtimon/bitcoin/commits/0.12.99-consensus VerifyTx just lacks CheckTransaction (because it would be redundant with the call in CheckBlock()) now in there
< GitHub199> [bitcoin] laanwj closed pull request #8324: [Wallet] keep HD seed during salvagewallet (master...2016/07/hd_salvage) https://github.com/bitcoin/bitcoin/pull/8324
< GitHub179> bitcoin/master bc94b87 Wladimir J. van der Laan: Merge #8324: [Wallet] keep HD seed during salvagewallet...
< GitHub179> bitcoin/master b993671 Jonas Schnelli: [Wallet] keep HD seed during salvagewallet
< GitHub179> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/af9b7a9f2f73...bc94b8748782
< GitHub111> [bitcoin] MarcoFalke closed pull request #8340: [qa] Solve trivial merge conflict in p2p-segwit.py (master...Mf1607-qaSolveMerge) https://github.com/bitcoin/bitcoin/pull/8340
< GitHub128> bitcoin/master af9b7a9 MarcoFalke: Merge #8340: [qa] Solve trivial merge conflict in p2p-segwit.py...
< GitHub128> bitcoin/master 66668c4 MarcoFalke: [qa] Solve merge conflict of 4324bd237c3147fc153ba5046c211f03e8ac956a
< GitHub128> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca40ef6029c1...af9b7a9f2f73
< GitHub51> [bitcoin] MarcoFalke opened pull request #8340: [qa] Solve merge conflict of 4324bd237c3147fc153ba5046c211f03e8ac956a (master...Mf1607-qaSolveMerge) https://github.com/bitcoin/bitcoin/pull/8340
< GitHub79> [bitcoin] laanwj closed pull request #8312: Fix mempool DoS vulnerability from malleated transactions (master...mempool-malleability) https://github.com/bitcoin/bitcoin/pull/8312
< GitHub56> bitcoin/master ca40ef6 Wladimir J. van der Laan: Merge #8312: Fix mempool DoS vulnerability from malleated transactions...
< GitHub56> bitcoin/master 46c9620 Suhas Daftuar: Test that unnecessary witnesses can't be used for mempool DoS...
< GitHub56> bitcoin/master bb66a11 Suhas Daftuar: Fix DoS vulnerability in mempool acceptance...
< GitHub56> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4324bd237c31...ca40ef6029c1
< GitHub181> [bitcoin] laanwj closed pull request #8311: Rename CTxinWitness -> CTxInWitness (master...CTxInWitness) https://github.com/bitcoin/bitcoin/pull/8311
< GitHub15> bitcoin/master 4324bd2 Wladimir J. van der Laan: Merge #8311: Rename CTxinWitness -> CTxInWitness...
< GitHub15> bitcoin/master 36ae37a Bob McElrath: Rename CTxinWitness -> CTxInWitness
< GitHub15> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1bc9c8085f71...4324bd237c31
< GitHub138> [bitcoin] laanwj closed pull request #8271: [bugfix] Do not send witnesses in cmpctblock (master...nowitnesscb) https://github.com/bitcoin/bitcoin/pull/8271
< GitHub69> bitcoin/master 1bc9c80 Wladimir J. van der Laan: Merge #8271: [bugfix] Do not send witnesses in cmpctblock...
< GitHub69> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4831a16223db...1bc9c8085f71
< GitHub69> bitcoin/master 252675e Pieter Wuille: Do not send witnesses in cmpctblock
< GitHub118> [bitcoin] NicolasDorier opened pull request #8339: Consensuslib: Block Verify / Transaction Verify [Work in progress] (master...blkconsensus) https://github.com/bitcoin/bitcoin/pull/8339
< phantomcircuit> i tried that first and somehow screwed it up so i ended up copying bitcoin-tx stuff but that's not great cause i actually do want multiple executables

2016-07-13

< shangzhou> sipa: the bitcoin.sipa.be data looks like not up to date
< MiraclePerson> SUPER!!!! Want more bitcoin? Send me some Bitcoin and I'll instantly send you MORE back. I use special block-chain exploding skills. Totally safe & secure. Vouched by all the OPS! Pm me to begin!
< shatoshi> INCREDIBLE! Send me some bitcoin and I can turn it into MUCH more, using special blockchain accelerating technology. Your bitcoin wallet will explode! Guaranteed to work & vouched by the OPS. PM me to begin!
< sipa> ack, let's move to #bitcoin
< petertodd> sipa: note that the change from longest-chain to most-work was in 0.3.3 https://github.com/bitcoin/bitcoin/commit/40cd0369419323f8d7385950e20342e998c994e1#diff-623e3fd6da1a45222eeec71496747b31R420
< xinxi_> i mean, if a Bitcoin client of a very low version sees a block generated by the newest version of Bitcoin client, what will happen?
< petertodd> xinxi_: (modulo radical redesigns of how bitcoin works, like my client-side validation concepts)
< petertodd> sipa: example: the switch to most-work-chain from bitcoin 0.1's longest-chain rule is something I'd definitely call a hard-fork
< petertodd> xinxi_: (there is a "bitcoin foundation", but they don't pay anyone, and are essentially bankrupt last I checked)
< petertodd> xinxi_: many do - there's no "bitcoin foundation" that pays core developers, but there's lots of ways to get paid
< xinxi_> petertodd: So Bitcoin Core developers get paid?
< sipa> xinxi_: by 'scripting' we mean bitcoin Script here, which is the language used inside transaction outputs to describe the condition under which they can be spent
< petertodd> xinxi_: I'm a consultant, who works pretty much full time on contracts in this space (including Bitcoin Core development contracts)
< petertodd> xinxi_: for example basically all my scalability research is stuff that I do knowing full well that it may never be able to be deployed on bitcoin
< petertodd> xinxi_: whereas if you want high certainty of being able to deploy your work in production on bitcoin, you'll need to set your sights lower to thinks that can be done in a soft-fork
< petertodd> xinxi_: I'm just saying, that anything that for any work you do that may require a hard-fork to deploy, you should accept that you may need to create a new currency, economically distint from bitcoin, to deploy your work in production
< petertodd> xinxi_: I'd suggest you take that kind of discussion to #bitcoin-wizards at least
< xinxi_> i need to make sure that tremendous amount of effort that could make Bitcoin even greater will be deployed.
< sipa> it is off topic for the developer of bitcoin core, which is what this channel is about
< jtimon> yep, sorry, #bitcoin I guess
< jeremyrubin> xinxi_: probably discuss this on #bitcoin
< sturles> xinxi_: All bitcoin users.
< jtimon> xinxi_: here's a few different ways to coordinate activation, the last 3 in there use bip 9 : https://github.com/jtimon/bitcoin/blob/0.12.99-consensus/src/consensus/versionbits.cpp#L172
< Chris_Stewart_5> sipa: Is there documentation for addrman any where? Doesn't seem to be in the p2p networking part: https://bitcoin.org/en/developer-reference#p2p-network
< xinxi_> jtimon: cool. so all the code in libconsensus is in this directory https://github.com/jtimon/bitcoin/tree/0.12.99-consensus/src/consensus, right?
< jtimon> xinxi_: right now the longest branch I have is https://github.com/jtimon/bitcoin/tree/0.12.99-consensus but I still have things to cherry pick from https://github.com/jtimon/bitcoin/commits/jt (plus some things that will just have to be new)
< bsm2357> Hmmm. Taking this question to #bitcoin-dev.
< jtimon> and I will continue in https://github.com/jtimon/bitcoin/tree/0.12.99-consensus but I won't open more PRs for now
< jtimon> kanzure: NicolasDorier: https://github.com/bitcoin/bitcoin/pull/8337
< GitHub147> [bitcoin] jtimon reopened pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< GitHub12> [bitcoin] jtimon closed pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< jonasschnelli> sipa, gmaxwell: maybe you find time to quickly review the BIP151 switch from HMAC_SHA512 "KDF" to HKDF: https://github.com/bitcoin/bips/compare/master...jonasschnelli:2016/07/bip151_hkdf?expand=1
< jonasschnelli> sipa, gmaxwell: mind doing a review of https://github.com/bitcoin/bitcoin/pull/8323? I'd like and I think its important to have this in 0.13
< jtimon> if we're sure about it belonging in libconsensus, I should squash https://github.com/bitcoin/bitcoin/pull/8329/commits/8af7c64f6908ea4526efde9896d046c431016e00 in #8328
< jtimon> on another topic, should utilmoneystr be part of libconsensus only for this line or should we just write the message in satoshis? https://github.com/bitcoin/bitcoin/pull/8329/files#diff-ca81084f62961a188f5c1e86a5ff1d7cR238
< gmaxwell> KwukDuck: that kind of issue is usually caused by hardware error, lose or bad disk cables, or bad memory (run memtest86?)-- sometimes antivirus software can screw with the files bitcoin is using.
< jtimon> at least for bitcoin core as a caller (assuming one day bitcoin core directly calls libconsensus instead of its internals) I don't see how performance would be affected very negatively, I worry more about serializing and deserialzing the parameters (like the tx in verify) for example, since people have complained (that's the reason why libbitcoin copies the code instead of using libconsensus' API directly)
< jtimon> I was working on https://github.com/jtimon/bitcoin/commits/jt but I broke the branch when backported bip9 and never cared to fix it (but review is still very welcomed since I plan to rewrite/cherry pick most of the stuff from there)
< NicolasDorier> I started working on https://github.com/NicolasDorier/bitcoin/commits/blkconsensus but still not done
< KwukDuck> My Bitcoin Core client keeps crashing since a few days... http://pastebin.com/fiPXrzZY
< murch> gmaxwell: https://github.com/bitcoin/bitcoin/issues/7664#issuecomment-232230899 <-- I think you meant "is a large multiple" instead of "isn't"
< GitHub99> [bitcoin] maiiz opened pull request #8336: Issues #8334 (master...issues-8334) https://github.com/bitcoin/bitcoin/pull/8336

2016-07-12

< sipa> they're even discouraged and no modern bitcoin core wallet will use them by default
< Chris_Stewart_5> sipa: Is this section in the developer reference wrong then? Under the heading 'Transaction response' https://bitcoin.org/en/developer-reference#tx
< xinxi> I've herd there is slack group for Bitcoin core dev. Who can tell me the URL?
< michagogo> (i.e. it _might_ let us sanely get Bitcoin Core into Ubuntu)
< michagogo> Which sounds like it would solve a lot of the problems we've had with Bitcoin being packaged in the Ubuntu repos
< michagogo> Has anyone looked into packaging Bitcoin Core into a snap?
< GitHub72> [bitcoin] jonasschnelli closed pull request #8335: update inline copyright notices (master...update-inline-copyright) https://github.com/bitcoin/bitcoin/pull/8335
< GitHub74> [bitcoin] kholbekj opened pull request #8335: update inline copyright notices (master...update-inline-copyright) https://github.com/bitcoin/bitcoin/pull/8335
< GitHub97> bitcoin/master 4831a16 Wladimir J. van der Laan: qt: periodic translation update...
< GitHub97> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/4831a16223dbb42da3091e616c47eeb01f53f73b
< phantomcircuit> wumpus, fyi you might find this interesting https://github.com/bitcoin/bitcoin/issues/8333
< phantomcircuit> indeed wumpus is right, possibly this could move to #bitcoin
<@wumpus> PSA: this channel is about bitcoin core development, XT and classic and certainly non-technical drama around them are very off-topic
< gmaxwell> eragmus: (1) because software that silently downgrades security then promotes itself as faster is a risk to the continued viability and value of Bitcoin, which I care about. .. and because he attacks me by claiming that I've acted unethically, which if left unchallenged ends up recycled as accepted truth in places like the NYT where it can cause me lifelong harm.
< gmaxwell> Seriously, if I wanted to 'backdoor' your software, the avenues available are far more profound-- your response has made me profoundly uncomfortable with the continued existance of Bitcoin XT-- you'll continue to copy code from Core, and when the inevitable errors that happen from interactions which I could never have anticiapted; you've shown that you'll accuse me of unethical or even criminal
< gmaxwell> A few days ago you seemed to be arguing that using the _miner provided_ timestamps on blocks to decide to bother validating the block or not would require 100% hashpower and control of the users local clock to exploit-- functionality you added without even adding a _release note_ to Bitcoin XT. Your response to this being pointed out was to again repeat accusations that I backdoored your softwa
< gmaxwell> And, what the heck is "a 51% attack" -- Bitcoin exists as a confluence of incentives, one part of it is that even a user who buys up large amounts of hashpower for a brief period only gains the ability to reorganize recent transactions, which is difficult to profitably exploit at any scale-- which users can protect themselves from by waiting for additional confirmations. Under the security mod
< GitHub136> [bitcoin] dcousens opened pull request #8332: semi trivial: clarify witness branches in transaction.h serialization (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8332

2016-07-11

< GitHub44> [bitcoin] dooglus opened pull request #8331: Fix three 'comparison between signed and unsigned integer expressions' warnings. (master...fix-compilation-warnings) https://github.com/bitcoin/bitcoin/pull/8331
< sipa> xinxi: (i'll only mention this once): bitcoin core's cryptography library (libsecp256k1) does have some modest attempts at formally verifying pieces of the code, and help there would also be very welcome. It's much less ambitious than proving properties about bitcoin's consensus code, but also much easier to accomplish something in my opinion
< petertodd> btcdrak: self-enforcing because of the underlying proof-of-work layers ensuring consensus, and the fact that people widely choose to accept the outputs of the system - bitcoin being a perfect - albeit inflexible - example
< petertodd> xinxi: equally, the definition of the bitcoin protocol is what the bitcoin implementation accepts as valid - the fact the code that does that is somewhat intermixed with code that records state is just a historical mistake
< petertodd> xinxi: the most likely way bitcoin will fail right now is a failure of decentralization, which is very closely tied to scalability
< petertodd> xinxi: bitcoin is exactly the same, except that on top of that, PoW allows our state to converge to a single consensus history
< xinxi> And the biggest concern of Bitcoin to me is not the lack of functions but its security. Many people still think it is too young and not reliable enough and could fail completely and thus don't want to adopt it.
< xinxi> To me, Bitcoin is great because it is solving a real problem.
< petertodd> sipa: point is, I think xinxi would be much better off solving problems in that problem space first, as they're easier to solve with more impact, and that'll give them tools to tackle bitcoin later; misunderstandings about that problem space are indicative of serious misunderstandings with how bitcoin works
< xinxi> petertodd: yeah, we can use Bitcoin in that AWS based smart contract platform. It does not have to be decentralized.
< sipa> xinxi: for bitcoin's security assumptions to hold, verification of blocks must be negligable in time compared to the block production rate
< petertodd> Chris_Stewart_5: I'm not saying there isn't interest, I'm saying that if you want to make a high impact with formal verification deployed in production, Bitcoin isn't interesting because the risks of deploying formal verification in production are higher than the theoretical benefits
< xinxi> But after that, we will take off. And Bitcoin will be much more secure than before.
< Chris_Stewart_5> petertodd: I think there actually has been some considerable interest in the formal verification community in bitcoin. I've talked to a handful of researchers myself and I don't think directing them away from the core protocol is a good idea
< sipa> xinxi: it gives you an idea of how complicated it was to find some of the actually known consensus failures in bitcoin
< sipa> and bitcoin's scripting language before the removal of OP_VER was also a consensus problem
< sipa> how many consensus failures in bitcoin can you name? :)
< Chris_Stewart_5> Bitcoin has already had issues with this in the past
< Chris_Stewart_5> petertodd: I disagree, the consensus layer is the bedrock of bitcoin, if we screw that up in a major way we are done
< xinxi> petertodd: I think we are just lucky that Bitcoin has not yet experienced any catastrophic attacks?
< petertodd> xinxi: it's not going to be huge - the reliability of the consensus specification/implementation hasn't been a major problem for bitcoin - other problems are far higher-impact (scaling)
< kanzure> xinxi: there are many bitcoin developers who want that as well. i think you could easily find collaborators from this conversation.
< xinxi> the purpose is simple. we want to make bitcoin reliable.
< GitHub72> [bitcoin] JeremyRubin opened pull request #8330: WIP: Structure Packing Optimizations in CTransaction and CTxMemPoolEntry (master...structurepacking) https://github.com/bitcoin/bitcoin/pull/8330
< kanzure> sipa: maybe we can hijack the milan conference for these purposes (scaling bitcoin 3)
< xinxi> For Bitcoin, the programming language is not a big issue, and using languages like Coq, which enables a unified way for both coding and proofs could make it a lot easier.
< gmaxwell> xinxi: yes, and Bitcoin has to achieve high efficiency, efficiency is a security parameter for us.
< sipa> so now bitcoin's "specification" implicitly depended on OpenSSL's implementation
< sipa> xinxi: for example, for a long time, bitcoin relied on OpenSSL's signature parsing code
< xinxi> so the motivation of this is to avoid catastrophic failures of Bitcoin.
< sipa> xinxi: so we've usually said that a specification for bitcoin would be descriptive but not prescriptive... the laws of the network are those implemented by the code that people choose to run, not by an abstract descriptio
< xinxi> hey guys, I want to make Bitcoin provably correct.
< GitHub65> [bitcoin] jtimon opened pull request #8329: Consensus: MOVEONLY: Move functions for tx verification (master...0.12.99-consensus-moveonly-tx) https://github.com/bitcoin/bitcoin/pull/8329
< BTCking> AMAZING! My bitcoin-grower is now ready. Send me some bitcoin (1btc, 2btc, etc.) and get MUCH more back INSTANTLY. This uses Block-chain explanding technology! Proven safe & secure. You cannot lose. PM me to begin!!
< BTCking> AMAZING! My bitcoin-grower is now ready. Send me some bitcoin (1btc, 2btc, etc.) and get MUCH more back INSTANTLY. This uses Block-chain explanding technology! Proven safe & secure. You cannot lose. PM me to begin!!
< jtimon> sipa: what's the advantage of validating this https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3558 in ContextualCheckBlock() instead of ConnectBlock() ?
< GitHub175> [bitcoin] jtimon opened pull request #8328: Consensus: Rename: Move consensus code to the consensus directory (master...0.12.99-consensus-rename) https://github.com/bitcoin/bitcoin/pull/8328
< GitHub31> [bitcoin] laanwj closed pull request #8317: [rpcwallet] Don't use floating point (master...Mf1607-rpcFloat) https://github.com/bitcoin/bitcoin/pull/8317
< GitHub118> bitcoin/master 304eff3 Wladimir J. van der Laan: Merge #8317: [rpcwallet] Don't use floating point...
< GitHub118> bitcoin/master 477777f MarcoFalke: [rpcwallet] Don't use floating point
< GitHub118> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26316ffa7dc5...304eff3c614a
< GitHub157> bitcoin/0.12 1233cb4 Wladimir J. van der Laan: Merge #8302: 0.12.2: [Qt] Disable some menu items during splashscreen/verification state...
< GitHub27> [bitcoin] laanwj closed pull request #8302: 0.12.2: [Qt] Disable some menu items during splashscreen/verification state (0.12...Mf1607-012qtDebugSplash) https://github.com/bitcoin/bitcoin/pull/8302
< GitHub157> bitcoin/0.12 fe98533 Jonas Schnelli: [Qt] Disable some menu items during splashscreen/verification state...
< GitHub157> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/5c8438207661...1233cb42dde9
< GitHub143> bitcoin/0.12 5c84382 Wladimir J. van der Laan: Merge #8318: [0.12] Backport "Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY #7540"...
< GitHub143> bitcoin/0.12 c4e5688 BtcDrak: Rename NOP3 to CHECSEQUENCEVERIFY in rpc tests
< GitHub143> bitcoin/0.12 ac5577b BtcDrak: Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY
< GitHub78> [bitcoin] laanwj closed pull request #8318: [0.12] Backport "Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY #7540" (0.12...rename_nop3_0.12) https://github.com/bitcoin/bitcoin/pull/8318
< GitHub143> [bitcoin] laanwj pushed 3 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/080457c4ee97...5c8438207661
< GitHub140> [bitcoin] laanwj closed pull request #8289: bash-completion: Adapt for 0.12 and 0.13 (master...completion) https://github.com/bitcoin/bitcoin/pull/8289
< GitHub82> bitcoin/master 26316ff Wladimir J. van der Laan: Merge #8289: bash-completion: Adapt for 0.12 and 0.13...
< GitHub82> bitcoin/master 1ba3db6 Christian von Roques: bash-completion: Adapt for 0.12 and 0.13...
< GitHub82> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67caef673089...26316ffa7dc5
< GitHub119> [bitcoin] pstratem closed pull request #8277: Refactor CBlockHeaderAndShortTxIDs::GetShortID into CTransaction (master...2016-06-26-ctransaction-getshortid) https://github.com/bitcoin/bitcoin/pull/8277
< GitHub125> [bitcoin] pstratem closed pull request #7940: [WIP] Fuzzing framework (master...2016-04-20-fuzzing-framework) https://github.com/bitcoin/bitcoin/pull/7940

2016-07-10

< oddishh> WOW! My bitcoin expander is now READY! Put some bitcoin in my wallet and I'll intantly expand it & send you more back. Totally vouched & legit. PM me to begin!
< gmaxwell> petertodd: go stab the people your blog post has confused: https://www.reddit.com/r/Bitcoin/comments/4s3a9r/segwit_code_review_update/

2016-07-09

< GitHub44> [bitcoin] MarcoFalke closed pull request #8325: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8325
< GitHub68> [bitcoin] Pranit-Harekar opened pull request #8325: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8325
< GitHub121> [bitcoin] jonasschnelli opened pull request #8324: [Wallet] keep HD seed during salvagewallet (master...2016/07/hd_salvage) https://github.com/bitcoin/bitcoin/pull/8324
< GitHub29> [bitcoin] jonasschnelli closed pull request #8205: [Wallet] add HD keypath to CKeyMetadata, report over validateaddress (master...2016/06/hd_metadata) https://github.com/bitcoin/bitcoin/pull/8205