< June 2025 >
Su Mo Tu We Th Fr Sa 1234567891011121314
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30
2018-08-07
< MarcoFalke>
githubs send from:"notifications@github.com" to:"bitcoin@noreply.github.com" with cc:"comment@noreply.github.com" and cc you
< harding>
MarcoFalke: to ping privately, the bot could just pull the email address of the committer from the most recent commit message and email them. Alternatively, the bot could open an issue on the repository they're making their PR from, e.g. github.com/harding/bitcoin/issues/new
< gribble>
https://github.com/bitcoin/bitcoin/issues/13808 | wallet: shuffle coins before grouping, where warranted by kallewoof · Pull Request #13808 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gmaxwell>
https://github.com/bitcoin/bitcoin/pull/12495#issuecomment-367815005 < eklitzke suggests increasing leveldb's mmap limit here. ossifrage also apparently did that and reported it fixed his problems, though his specific problems are likely better fixed by switching to poll.
< gribble>
https://github.com/bitcoin/bitcoin/issues/13789 | crypto/sha256: Use pragmas to enforce necessary intrinsics for GCC and Clang by luke-jr · Pull Request #13789 · bitcoin/bitcoin · GitHub
< ossifrage>
mmap() is a great way to generate a very large amount of write pressure, but it seems like most of the leveldb use in bitcoin has a very low change rate
< gribble>
https://github.com/bitcoin/bitcoin/issues/13662 | Explain when reindex-chainstate can be used instead of reindex by Sjors · Pull Request #13662 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< gribble>
https://github.com/bitcoin/bitcoin/issues/13676 | Explain that mempool memory is added to -dbcache during IBD by Sjors · Pull Request #13676 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (master...scheduler-tests) https://github.com/bitcoin/bitcoin/pull/13247
< bitcoin-git>
bitcoin/master cbeaa91 Jesse Cohen: Update ValidationInterface() documentation to explicitly specify threading and memory model
< bitcoin-git>
bitcoin/master b296b42 Jesse Cohen: Update documentation for SingleThreadedSchedulerClient() to specify the memory model
< bitcoin-git>
bitcoin/master 9994d01 Jesse Cohen: Add Unit Test for SingleThreadedSchedulerClient...
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #13823: qa: quote path in authproxy for external multiwallets (master...Mf1808-qaAuthProxyQuotePath) https://github.com/bitcoin/bitcoin/pull/13823
< bitcoin-git>
[bitcoin] laanwj closed pull request #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) (master...call-IsIPv6-in-GetIn6Addr) https://github.com/bitcoin/bitcoin/pull/13776
< bitcoin-git>
bitcoin/master 7d36237 Wladimir J. van der Laan: Merge #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)...
< bitcoin-git>
bitcoin/master 2fb0066 practicalswift: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)
< bitcoin-git>
[bitcoin] achow101 opened pull request #13822: bench: Make CoinSelection output groups pass eligibility filter (master...fix-out-groups-bench) https://github.com/bitcoin/bitcoin/pull/13822
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
< bitcoin-git>
[bitcoin] Sjors opened pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
< bitcoin-git>
[bitcoin] scravy opened pull request #13816: travis: build and run tests on os: osx (master...run-functional-tests-on-macos) https://github.com/bitcoin/bitcoin/pull/13816
< harding>
various places in their home directory for different Bitcoin-related resources.
< harding>
mryandao: ok. I guess I have a different backup philosophy than you do. I use cheap external HDs, and so I just grab everything indiscriminately. I think there probably is an advantage to fully separating stuff we really want users to backup (e..g bitcoin.conf and wallets) from stuff that's just nice to backup (e.g. old blocks), but I personally don't think that's enough of an advantage to make them have to go looking around
< mryandao>
typically most linux distribution follow XDG specification for looking up config files, would this be preferable in Core? I know there was a previous closed issue which mentioned this, but we could keep the datadir cache separate in ~/.bitcoin as is
< sipa>
bitcoin-cli needs to know what arguments to treat as string literals and which ones not
< luke-jr>
kallewoof: for bitcoin-cli, which isn't tested by assert_raises_rpc_error
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13815: build: Add linter to make sure the return value of Parse[...](...) is checked (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
< satwo>
wumpus: thanks! I definitely need to familiarize myself with functional vs unit tests in bitcoin. I'll continue to come here to ask my noobish questions.
< fanquake>
There was at one point a bitcoin test cases/writeups repo, but I don't think it ever got much traction
< Fuzzbawls>
Question: (please ping me directly with answer) Given the recent acquisition of GitHub by Microsoft, is a relocation of the bitcoin source code to an alternative platform (like GitLab) being considered at all? If so, has anyone been actively working towards porting the `.travis.yml` file over to an alternative CI provider? I've had mixed results with such a port; some features can be duplicated/represented, and some cannot (like the $TRAVIS_COMMIT
< jonasschnelli>
ken2812221: sry. :) now my fault. I need: e56b7d20bc7bfb8203f1651ddcf4fc18d8685acf942a8c7b90919f29e24db3a1 bitcoin-0.16.2-osx-unsigned.tar.gz
< jonasschnelli>
You file: e56b7d20bc7bfb8203f1651ddcf4fc18d8685acf942a8c7b90919f29e24db3a1 bitcoin-osx-unsigned.tar.gz
< luke-jr>
wumpus: actually, it might be annoying if users get errors for Knots configs in bitcoin.conf
< sipa>
(by default it's enforced, unless you pass -ignoreunknownconfigoptions or so; and then it still only applies to bitcoin.conf and not to command line options)
< sipa>
wumpus: or we need a way to specify bitcoin.conf options that only apply to a particular binary
< sipa>
but we should probably make it ignore bitcoin-cli only options like this one, when present in bitcoin.conf
< sipa>
right; you can't put it in bitcoin.conf anymore, because it's not a bitcoind option
< sipa>
in bitcoin.conf it should work fine; that file should be read by both bitcoind and bitcoin-cli
< sipa>
satwo: no, but it's a bitcoin-cli command line option; not a bitcoind one
< satwo>
Has the bitcoind config param -rpcclienttimeout been removed? I'm getting errors trying to set it in both the command line and in bitcoin.conf.
< harding>
brighton36: I'm not sure what you're talking about, but it feels a bit off topic for this channel. Would you mind joining #bitcoin-core-website to discuss further? (Or you can PM me if you're a registered user.)
< harding>
brighton36: I help maintain the site. I don't relaly understand your question. There's a basic contributing policy at https://github.com/bitcoin-core/bitcoincore.org/blob/master/CONTRIBUTING.md but the basic process is the same for any open source project: people open PRs proposing changes, other people provide feedback, once the feedback is generally positive, the PR is merged. If the PR never gets to that stage, it's
< jonasschnelli>
sipa: would adding 'h' as equivalent to ' in the descriptor xpub/xpriv range definition makes sense? >'< in conjunction with JSON and the GUI/bitcoin-cli/shell seems to be a hassle
< BlueMatt>
jonasschnelli: well I ask because there is debate about what to write in some docs in rust-bitcoin, and also what to call it on bitcoincore.org docs
< sipa>
BlueMatt: scriptWitness is just in bitcoin core's source code though; is it called that way anywhere else?
< satwo>
Would modifying bitcoin-rpc to say something like "size (total):" or "total size:" be messy overkill? At the very least it would bring RPC and BIP 141 in harmony, potentially reducing some confusion
< satwo>
Hi all. BIP-141 defines 4 ways to measure the size of a transaction: weight, virtual size, base size, and total size. Bitcoin-cli decoderawtransaction returns weight, vsize ("virtual size" - obvious), and size (“total size" - not obvious). I must not be the only one to have found it nontrivial to figure out how base size, total size in BIP141 and “size” in RPC are related. Even once one figures out that “BIP 141
< arubi>
DDG first result for "scriptWitness" is the transaction.h file in the repo, and for "witnessScript bitcoin" the first result is is the core-dev docs site
< Lico>
Hi guys I am sorry for the basic question, but I would like to debug the bitcoin and I would like to know what tools for debug do you use for Ubuntu ? Does anybody use and IDE for Ubuntu ? I tried to use netbeans, eclipse
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13706: doc: Minor improvements to release-process.md (master...release_process_doc) https://github.com/bitcoin/bitcoin/pull/13706
< bitcoin-git>
bitcoin/master 94dd89e MarcoFalke: Merge #13706: doc: Minor improvements to release-process.md...
< bitcoin-git>
bitcoin/master 1c22cc1 Mitchell Cash: doc: Update broken links to now point to gitian-build.py
< bitcoin-git>
bitcoin/master 95464c7 Mitchell Cash: doc: Improve command to generate list of authors for release notes...
< bitcoin-git>
[bitcoin] kallewoof closed pull request #10386: [WIP] [wallet] Optional '-avoidreuse' flag which defaults to not reusing addresses in sends (master...feature-white-black-address) https://github.com/bitcoin/bitcoin/pull/10386
< bitbee>
is roger ver still stealing bitcoin core code?
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13650: [travis] Don't store debug info if --enable-debug is set (master...travis-debug-fix) https://github.com/bitcoin/bitcoin/pull/13650
< bitcoin-git>
bitcoin/master 7a9bca6 MarcoFalke: Merge #13650: [travis] Don't store debug info if --enable-debug is set...
< bitcoin-git>
bitcoin/master 14788fb Chun Kuan Lee: [travis] Don't store debug info if --enable-debug is set
< bitcoin-git>
[bitcoin] kallewoof reopened pull request #10386: [WIP] [wallet] Optional '-avoidreuse' flag which defaults to not reusing addresses in sends (master...feature-white-black-address) https://github.com/bitcoin/bitcoin/pull/10386
< bitcoin-git>
[bitcoin] laanwj closed pull request #12257: [wallet] Use destination groups instead of coins in coin select (master...feature-addrgrouped-coinselect) https://github.com/bitcoin/bitcoin/pull/12257
< bitcoin-git>
[bitcoin] 251Labs opened pull request #13751: Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency (master...patch/remove_boost_split) https://github.com/bitcoin/bitcoin/pull/13751
< bitcoin-git>
[bitcoin] Sjors opened pull request #13750: depends: use MacOS friendly sed syntax in qt.mk (master...2018/07/depends-qt-macos) https://github.com/bitcoin/bitcoin/pull/13750
< ossifrage>
harding, in my case I think it is just that my node has been up for a while and the connection count is wandering up and with it the non-bitcoin nodes (recently lost my old ip address thanks to verizon-quality)
< bitcoin-git>
[bitcoin] domob1812 opened pull request #13747: tests: Skip P2PConnection's is_closing() check when not available (master...skip-isclosing) https://github.com/bitcoin/bitcoin/pull/13747
< wumpus>
no, but in this case, being able to embed comments in JSON wouldn't help, they'd get lost in transit. bitcoin-cli parses and reformats the JSON to add indentation and such to make it more human-readable , which would lose comments
< gmaxwell>
(inspired by someone who looked like they nearly pasted the output of dumpprivkey into #bitcoin)
< gribble>
https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHubAsset 1Asset 1
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #12096: [rpc] [wallet] Allow specifying the output index when using bumpfee (master...better-bumpfee) https://github.com/bitcoin/bitcoin/pull/12096
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #12676: Show "bip125-replaceable" flag, when retrieving mempool entries (master...rpc-raw-replaceable-flag) https://github.com/bitcoin/bitcoin/pull/12676
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #12911: wallet: Show fee in results for signrawtransaction* when known (master...sign-show-fees) https://github.com/bitcoin/bitcoin/pull/12911
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (master...scheduler-tests) https://github.com/bitcoin/bitcoin/pull/13247
< bitcoin-git>
[bitcoin] fanquake closed pull request #12825: Only allocate a LevelDB block cache if LevelDB will actually use it (master...buffer-cache) https://github.com/bitcoin/bitcoin/pull/12825
< bitcoin-git>
[bitcoin] fanquake opened pull request #13741: Only allocate a LevelDB block cache if LevelDB will actually use it (master...eklitzke-buffer-cache-rebased) https://github.com/bitcoin/bitcoin/pull/13741
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11762: Avoid locking mutexes that are already held by the same thread (master...remove-double-locks) https://github.com/bitcoin/bitcoin/pull/11762
< bitcoin-git>
bitcoin/master 05714f9 MarcoFalke: Merge #11762: Avoid locking mutexes that are already held by the same thread...
< bitcoin-git>
bitcoin/master 01a06d6 practicalswift: Avoid locking mutexes that are already held by the same thread
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #12764: doc: Remove field in getblocktemplate help that has never been used. (master...remove_unused_gbt_field) https://github.com/bitcoin/bitcoin/pull/12764
< bitcoin-git>
bitcoin/master ac8a1d0 Conor Scott: [RPC] Remove field in getblocktemplate help that has never been used
< bitcoin-git>
bitcoin/master 10b9a81 MarcoFalke: Merge #12764: doc: Remove field in getblocktemplate help that has never been used....