< gribble>
https://github.com/bitcoin/bitcoin/issues/12810 | [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error by romanz · Pull Request #12810 · bitcoin/bitcoin · GitHub
< 18WAAOAGJ>
[bitcoin] MarcoFalke closed pull request #12810: [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error (master...fix-blocksdir-test) https://github.com/bitcoin/bitcoin/pull/12810
< bitcoin-git>
bitcoin/master 0c17e27 MarcoFalke: init: Remove help text for non-existent -fuzzmessagestest arg
< bitcoin-git>
bitcoin/master de7e586 MarcoFalke: Merge #12810: [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error...
< bitcoin-git>
bitcoin/master 8394300 Roman Zeyde: [Tests] fix a typo in TestNode.assert_start_raises_init_error()...
< bitcoin-git>
[bitcoin] joemphilips opened pull request #12837: fix type mistmatch in `listreceivedbyaddress` (master...fix_listreceivedbyaddress_type) https://github.com/bitcoin/bitcoin/pull/12837
< bitcoin-git>
[bitcoin] promag opened pull request #12836: Make WalletInitInterface and DummyWalletInit private (master...2018-03-walletinit) https://github.com/bitcoin/bitcoin/pull/12836
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #12823: doc: Switch release-notes.md to union merge (master...Mf1803-docGitattributes) https://github.com/bitcoin/bitcoin/pull/12823
< gribble>
https://github.com/bitcoin/bitcoin/issues/12789 | Dont return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) by practicalswift · Pull Request #12789 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] Sjors opened pull request #12833: WIP [qt] move QSettings to bitcoin.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
< bitcoin-git>
[bitcoin] practicalswift closed pull request #12789: Don't return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) (master...CExtKey-junk) https://github.com/bitcoin/bitcoin/pull/12789
< gribble>
https://github.com/bitcoin/bitcoin/issues/12790 | [Tests] Use blockmaxweight where tests previously had blockmaxsize by conscott · Pull Request #12790 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] matthias-g closed pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
< bitcoin-git>
[bitcoin] matthias-g opened pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
< bitcoin-git>
[bitcoin] eklitzke opened pull request #12825: Only allocate a LevelDB block cache if LevelDB will actually use it (master...buffer-cache) https://github.com/bitcoin/bitcoin/pull/12825
< bitcoin-git>
[bitcoin] jtimon closed pull request #11426: BIP90: Make buried deployments slightly more easily extensible (master...e16-bip90-extensible) https://github.com/bitcoin/bitcoin/pull/11426
< jtimon>
sorry for not following up, but promag will take care of the second part he discovered, please let's move on with https://github.com/bitcoin/bitcoin/pull/12172 's from 58 comments anf +9-4 as it was supposed to be
< aj>
Randolf: https://travis-ci.org/bitcoin/bitcoin/builds/359365323 failed badly, causing a bug to slip through into master that's only picked up in a travis-only (ish) test, causing travis to fail for all PRs after that, needing #12821 to fix
2018-03-28
< jnewbery>
hkjn0: #bitcoin please. This channel is for bitcoin core development
< paulg222>
with bitcoin 0.16 in regtest mode I'm seeing that coinbase transactions are not going to a segwit p2sh wrapped address, but to a regular p2pkh address. Is that expected?
< bitcoin-git>
[bitcoin] laanwj closed pull request #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table (master...2018_03_tests_summaryrow) https://github.com/bitcoin/bitcoin/pull/12811
< bitcoin-git>
bitcoin/master 0d8fc8d Wladimir J. van der Laan: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table...
< bitcoin-git>
bitcoin/master ffb033a Anthony Towns: test: List any failed tests at the end of test_runner output...
< bitcoin-git>
bitcoin/master f92541f Wladimir J. van der Laan: test: Make summary row bold-red if any test failed...
< bitcoin-git>
[bitcoin] laanwj closed pull request #12798: doc: Refer to witness reserved value as spec. in the BIP (master...Mf1803-docWitnessReservedValue) https://github.com/bitcoin/bitcoin/pull/12798
< bitcoin-git>
bitcoin/master 174d016 Wladimir J. van der Laan: Merge #12798: doc: Refer to witness reserved value as spec. in the BIP...
< bitcoin-git>
bitcoin/master adc2586 MarcoFalke: doc: Refer to witness reserved value as spec. in the BIP
< aj>
wumpus: if you're making test_runner nicer, might work to just report all the failed tests at the end so they're easy to find. https://github.com/laanwj/bitcoin/pull/6 has sample code
< bitcoin-git>
[bitcoin] laanwj opened pull request #12811: test: Make summary row bold-red if any test failed (master...2018_03_tests_summaryrow) https://github.com/bitcoin/bitcoin/pull/12811
< bitcoin-git>
[bitcoin] laanwj closed pull request #12806: qa: Fix function names in feature_blocksdir (master...Mf1803-qaBlocksdirFixup) https://github.com/bitcoin/bitcoin/pull/12806
< bitcoin-git>
bitcoin/master 18606eb Wladimir J. van der Laan: Merge #12806: qa: Fix function names in feature_blocksdir...
< bitcoin-git>
bitcoin/master d71bedb MarcoFalke: qa: Fix function names in feature_blocksdir
< bitcoin-git>
[bitcoin] romanz opened pull request #12810: [Tests] Fix a typo at assert_start_raises_init_error() and update its invocation (master...fix-blocksdir-test) https://github.com/bitcoin/bitcoin/pull/12810
< bitcoin-git>
[bitcoin] murrayn opened pull request #12809: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/12809
2018-03-27
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #12806: qa: Fix function names in feature_blocksdir (master...Mf1803-qaBlocksdirFixup) https://github.com/bitcoin/bitcoin/pull/12806
< bitcoin-git>
[bitcoin] sipa opened pull request #12803: Make BaseSignatureCreator a pure interface (master...201803_puresignaturecreator) https://github.com/bitcoin/bitcoin/pull/12803
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #12802: Colonel Mustard in the Lounge with the Lead Pipe (killed mapBlockIndex outside of validation) (master...2018-03-const-cblockindex) https://github.com/bitcoin/bitcoin/pull/12802
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #10692: Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState (master...2017-04-const-mapblockindex) https://github.com/bitcoin/bitcoin/pull/10692
< bitcoin-git>
[bitcoin] laanwj closed pull request #12653: Allow to optional specify the directory for the blocks storage (master...2018/03/blocksdir) https://github.com/bitcoin/bitcoin/pull/12653
< bitcoin-git>
bitcoin/master a192636 Jonas Schnelli: -blocksdir: keep blockindex leveldb database in datadir
< bitcoin-git>
bitcoin/master f38e4fd Jonas Schnelli: QA: Add -blocksdir test
< bitcoin-git>
bitcoin/master 386a6b6 Jonas Schnelli: Allow to optional specify the directory for the blocks storage
< bitcoin-git>
[bitcoin] skeees opened pull request #12801: Add option to only notify after wallet transactions are confirmed (master...notifycount) https://github.com/bitcoin/bitcoin/pull/12801
< bitcoin-git>
bitcoin/master 0fee2b4 practicalswift: doc: Add note about our preference for scoped enumerations ("enum class")
< bitcoin-git>
bitcoin/master 2d97611 Wladimir J. van der Laan: Merge #12800: doc: Add note about our preference for scoped enumerations ("enum class")...
< bitcoin-git>
[bitcoin] jonasschnelli closed pull request #12795: do not truncate .dat extension for wallets in gui (master...nowalletprune) https://github.com/bitcoin/bitcoin/pull/12795
< bitcoin-git>
bitcoin/master 68484d6 Jonas Schnelli: Merge #12795: do not truncate .dat extension for wallets in gui...
< bitcoin-git>
bitcoin/master fc7c32f Gregory Sanders: do not truncate .dat extension for wallets in gui
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #12798: doc: Refer to witness reserved value as spec. in the BIP (master...Mf1803-docWitnessReservedValue) https://github.com/bitcoin/bitcoin/pull/12798
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #12797: init: Fix help message for checkblockindex (master...Mf1803-initHelpCheckBlockIndex) https://github.com/bitcoin/bitcoin/pull/12797
< bitcoin-git>
[bitcoin] instagibbs opened pull request #12795: do not truncate .dat extension for wallets in gui (master...nowalletprune) https://github.com/bitcoin/bitcoin/pull/12795
< instagibbs>
AndyS2, this is #bitcoin talk, please move it there
< AndyS2>
maybe someone can chime in on when bitcoin was changed away from IP-Addresses and other weird things to what we mostly use nowadays. I remember reading something about that a long time ago
< AndyS2>
I can recommend "Mastering Bitcoin", it's freely available online or as a book. It was written in 2017, though, but it does tell you about a few things that were added later on
< provoostenator>
stepa[m]: this is more suited for #bitcoin or bitcoin.stackexchange.com
< stepa[m]>
Just read the bitcoin whitepaper, and it is so clear and concise! What are the major changes that happened since the paper was written? I believe the Merkle Tree as described is not used anymore in lieu of a Fast Merkle Tree? Are there any other major differences that make the whitepaper outdated?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12789: Don't return a CExtPubKey filled with junk when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) (master...CExtKey-junk) https://github.com/bitcoin/bitcoin/pull/12789
< bitcoin-git>
[bitcoin] kallewoof opened pull request #12788: [build] Tune wildcards for LIBSECP256K1 target (master...build-tune-libsecp256k1-wildcards) https://github.com/bitcoin/bitcoin/pull/12788
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12787: rpc: Adjust ifdef to avoid unreachable code (master...unreachable-code-ifdef-ENABLE_WALLET) https://github.com/bitcoin/bitcoin/pull/12787
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12785: wallet: Set m_last_block_processed to nullptr in CWallet::SetNull() (master...m_last_block_processed-setnull) https://github.com/bitcoin/bitcoin/pull/12785
< wumpus>
I think we should switch gitian building to 18.04 for 0.17 (https://github.com/bitcoin/bitcoin/issues/12511), would be nice to do the same for travis, but I'm not sure that's possible
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12784: Fix error in memory usage calculation (unintended integer division) (master...calc-error) https://github.com/bitcoin/bitcoin/pull/12784
< Randolf>
Dmitrii__: I suspect that you're looking for the Bitcoin community: /join #bitcoin
< kallewoof>
Huh... trying to build windows version of bitcoin with --enable-gprof --enable-debug. It fails to compile, with `Fatal error: can't write 86 bytes to section .text of wallet/libbitcoin_wallet_a-wallet.o because: 'File too big'`. That doesn't sound too good. (Without both, it compiles though.)
< sipa>
Dmitrii__: this channel is about bitcoin core, not bitcore
< CubicEarths>
emad: This is the Bitcoin development channel
< meshcollider>
luke-jr: for example, I'm not sure that setting a locktime in the transaction should modify the sequence numbers itself, if a user is using bitcoin-tx they probably want to modify the transaction themselves rather than it doing stuff in the background
< bitcoin-git>
[bitcoin] practicalswift opened pull request #12782: Explicitly state our assumptions about LookupBlockIndex(...) return values (master...LookupBlockIndex-assumptions) https://github.com/bitcoin/bitcoin/pull/12782
< bitcoin-git>
[bitcoin] GabrielDav opened pull request #12778: RPC: Add username and ip logging for RPC method requests (master...12223-rpc-log-username) https://github.com/bitcoin/bitcoin/pull/12778
< bitcoin-git>
[bitcoin] practicalswift closed pull request #12534: tests: List skipped flake8 warnings (rather than listing enabled warnings) (master...lint-python-invert) https://github.com/bitcoin/bitcoin/pull/12534
2018-03-24
< bitcoin-git>
[bitcoin] Christewart opened pull request #12775: Integration of property based testing into Bitcoin Core (master...rapidcheck_build) https://github.com/bitcoin/bitcoin/pull/12775
< bitcoin-git>
[bitcoin] jakubtrnka opened pull request #12774: Issue #10542 Signmessage doesn't work with segwit addresses (master...master) https://github.com/bitcoin/bitcoin/pull/12774