2016-04-25

< arubi> why are the expansions of op_cltv and op_csv done in different ways in 'script.h'? https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L165-L168
< GitHub25> [bitcoin] laanwj opened pull request #7939: qt: Make it possible to show details for multiple transactions (master...2016_04_qt_multiple_transaction_details) https://github.com/bitcoin/bitcoin/pull/7939
< phantomcircuit> NotAnNSAgent, you've been unbanned from #bitcoin please move your discussion there
< GitHub177> [bitcoin] MarcoFalke opened pull request #7938: [0.12.2] Backports (0.12...Mf1604-012backp) https://github.com/bitcoin/bitcoin/pull/7938
< Chris_Stewart_5> I don't think that is only relevant inside of the mempool - https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L940
< Chris_Stewart_5> Also, how could 0 be a validly encoded public key, doesn't it trivially fail this https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L66
< NotAnNSAgent> Just one more note, since sipa isn't in ##bitcoin: yes, I learned what "accounts" actually are in Bitcoin, but I also learned that the labels stuff is not stable/finished either, and that I can use "accounts" as a form of label until things stabilize, but I cannot use them to segregate money in the way I first thought was possible.
< Chris_Stewart_5> Is it becuse it is not properly encoded as per https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L202
< GitHub133> bitcoin/0.12 6aae129 MarcoFalke: [qa] wallet: Print maintenance...
< GitHub133> bitcoin/0.12 d89fbfe MarcoFalke: [qa] rpc-test: Normalize assert()...
< GitHub133> bitcoin/0.12 ad8c743 MarcoFalke: [qa] Extend tests...
< GitHub133> [bitcoin] MarcoFalke pushed 12 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/9779e1e1f320...89ae85484c8b
< GitHub46> [bitcoin] MarcoFalke closed pull request #7811: [0.12.2] qa Backports (0.12...Mf1604-qa012) https://github.com/bitcoin/bitcoin/pull/7811
< phantomcircuit> NotAnNSAgent, you've been unbanned from #bitcoin please move your discussion there
< MarcoFalke> wumpus, I think it makes sense to merge https://github.com/bitcoin/bitcoin/pull/7811#issuecomment-212380135 now
< GitHub66> [bitcoin] laanwj closed pull request #7688: List solvability in listunspent output and improve help (master...helpspendsolv) https://github.com/bitcoin/bitcoin/pull/7688
< GitHub91> bitcoin/master 46880ed Wladimir J. van der Laan: Merge #7688: List solvability in listunspent output and improve help...
< GitHub91> bitcoin/master c3932b3 Pieter Wuille: List solvability in listunspent output and improve help
< GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4e8390047a1...46880ed2fd96
< wumpus> bitcoin core is not something you should upgrade without paying attention, especially if you use it in production and there's actual money involved
< NotAnNSAgent> There is very little interest in making it possible to have any idea who owns a given address in a "Bitcoin bank" (wallet)?
< wumpus> this is the label API that will replace it: https://github.com/bitcoin/bitcoin/pull/7729 ... note that this is mostly just a subset of the account functionality, the only thing that will disappear is the account balance
< NotAnNSAgent> That is, any label I need for my own reference to know which "account" (not the deprecated Bitcoin concept of "accounts") it belongs to.
< NotAnNSAgent> wumpus: I manage to not get the bitcoin-cli binary because I only installed bitcoin-daemon because why would I want the -cli thing?
< GitHub61> [bitcoin] laanwj closed pull request #7792: depends: mac deploy Py3 compatibility (fixes macosx gitian build) (master...2016_04_fix_macosx_gitian) https://github.com/bitcoin/bitcoin/pull/7792
< da2ce7_mobile> Ok, I have just the blkXXX files, and a wallet.dat file. Will load bitcoin.
< da2ce7_mobile> I'm using Bitcoin 0.12.1
< da2ce7_mobile> hello, I wish to copy the blocks from one PC to another, what is the minimum I need to copy? It If I just copy the blk0xxx files it overwrites the files. If I include the rev00xxx files bitcoin throws an assertion. I suppose it has something to do with the chainstate obfuscation.
< wumpus> how do you manage to not get the bitcoin-cli binary?
< NotAnNSAgent> (I don't have bitcoin-cli binary)
< wumpus> NotAnNSAgent: the best documentation for the API is in bitcoind itself, using bitcoin-cli help
< instagibbs> NotAnNSAgent, bitcoin-cli help ?
< NotAnNSAgent> And has "not been reviewed by Bitcoin developers", which makes no sense to me.
< NotAnNSAgent> wumpus: I'm talking about the API to talk to bitcoind. Which seems to be explained (messily) at https://bitcoin.org/en/developer-reference#bitcoin-core-apis , but that documentation is full of dangerously outdated information.
< assder> This looks very good for those wanting to start developing: https://en.bitcoin.it/wiki/Bitcoin_Core_0.11_(ch_1):_Overview. Haven't checked it out in depth myself.
< wumpus> have you seen https://bitcoin.org/en/developer-documentation ? I think it's pretty okay
< NotAnNSAgent> This is obviously going to offend you, but I have to ask... Is the not only poor, but grossly *misleading* documentation deliberately so? I mean, maybe you don't want Bitcoin to be easy to implement to ensure job security or something? I've seriously begun asking myself if that could be the case. Again, though, I understand that this is both very difficult stuff, and you can't change things directly as individuals without first talking
< GitHub161> [bitcoin] laanwj closed pull request #7881: Update release process (master...2016_04_update_release_process) https://github.com/bitcoin/bitcoin/pull/7881
< GitHub158> bitcoin/master f154470 MarcoFalke: [contrib] Remove reference to sf and add doc to verify.sh
< GitHub158> bitcoin/master 182bec4 Wladimir J. van der Laan: contrib: remove hardcoded version from verify.sh...
< GitHub158> bitcoin/master c907f4d Wladimir J. van der Laan: doc: Update release process...
< GitHub158> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/f9c2ac72327e...c4e8390047a1
< GitHub121> bitcoin/master b69836d Wladimir J. van der Laan: dbwrapper: Pass parent CDBWrapper into CDBBatch and CDBIterator...
< GitHub160> [bitcoin] laanwj closed pull request #7927: Minor changes to dbwrapper to simplify support for other databases (master...2016_04_dbwrapper_modernization) https://github.com/bitcoin/bitcoin/pull/7927
< GitHub121> bitcoin/master 878bf48 Wladimir J. van der Laan: dbwrapper: Remove CDBWrapper::GetObfuscateKeyHex...
< GitHub121> bitcoin/master 74f7b12 Wladimir J. van der Laan: dbwrapper: Remove throw keywords in function signatures...
< GitHub121> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/f604bf63211f...f9c2ac72327e
< GitHub179> [bitcoin] laanwj closed pull request #6821: Avoid duplicate getheaders requests (master...no-duplicate-getheaders) https://github.com/bitcoin/bitcoin/pull/6821
< GitHub136> [bitcoin] pstratem opened pull request #7936: CDataStream::ignore Throw exception instead of assert on negative nSize. (master...2016-04-24-cdatastream-ignore) https://github.com/bitcoin/bitcoin/pull/7936
< GitHub66> [bitcoin] luke-jr opened pull request #7935: Versionbits: GBT support (master...gbt_bip9) https://github.com/bitcoin/bitcoin/pull/7935
< NotAnNSAgent> You make about as much sense as the Bitcoin API.
< NotAnNSAgent> It feels as if I'm desperately trying to help get some enthusiasm going for Bitcoin as a project, but everyone seems to have sort of given up mentally.
< belcher> the gui client is generally called bitcoin-qt, bitcoin core is the project that includes both of those
< NotAnNSAgent> Also, Bitcoin Core is bitcoind, no?
< luke-jr> that's how bitcoin works
< luke-jr> and Bitcoin has no concept of users
< phantomcircuit> NotAnNSAgent, you're right that should be updated, i opened an issue for it on github https://github.com/bitcoin-dot-org/bitcoin.org/issues/1287
< NotAnNSAgent> phantomcircuit: To be able to support Bitcoin donations to one of my services, and to deal with another Bitcoin account for my commercial site.
< NotAnNSAgent> Why is it so hard for Bitcoin to simply support multiple wallets? Why do I have to run entire separate blockchains and instances of the daemon for this?
< phantomcircuit> NotAnNSAgent, in bitcoin terms a "wallet" is just a collection of private keys and the transactions related to those keys in the blockchain
< NotAnNSAgent> I have to ignore the accounts stuff, because I learned it's practically removed from the Bitcoin software.
< NotAnNSAgent> Why didn't Bitcoin support multiple "wallets" right away? I have no idea what you mean that "accounts" are supposed to be, still.
< phantomcircuit> NotAnNSAgent, the "accounts" stuff is completely separate from handling of bitcoin transactions
< NotAnNSAgent> And why Bitcoin forces me to have separate instances and separate blockchains for each "account" I want to have (each "wallet" in your terms).
< NotAnNSAgent> phantomcircuit: I'm trying to discuss the concept of "accounts" in Bitcoin and why they were made the way they were.
< NotAnNSAgent> But the "wallet" idea is also an attractive thing to advertise. Though I think the "wallets" could rather be Bitcoin's own term for an "account", all inside a "Bitcoin bank" (bank.dat).
< NotAnNSAgent> So I would've liked it better if the initial metaphor wasn't "wallet" and "wallet.dat", but instead "virtual Bitcoin bank" and "bank.dat".

2016-04-24

< NotAnNSAgent> Which could only be known to somebody who is very intimately familiar with the Bitcoin development process.
< sipa> the documentation on bitcoin.org is often very good though, and better than what developers would write :)
< NotAnNSAgent> If Bitcoin.org is unofficial.
< NotAnNSAgent> Where is the actual manual for Bitcoin?
< sipa> at least, not the Bitcoin Core maintainers
< sipa> Bitcoin developers do not run that site.
< NotAnNSAgent> I mean "you" as in "Bitcoin developers".
< NotAnNSAgent> sipa: I'm referring to https://bitcoin.org/en/developer-reference#sendtoaddress
< belcher> i think i found out accounts were deprecated from the bitcoin wiki or something
< sipa> 18:12:28 < NotAnNSAgent> Since Windows 10, the Bitcoin Core client for Windows uses the awful Windows 10 notifications, which I've been forced to turn off globally.
< sipa> NotAnNSAgent: i must say that i'm somewhat surprised to see someone comment about using bitcoin on both Win10 and FreeBSD :)
< NotAnNSAgent> My experiences especially these last few weeks have really convinced me that Bitcoin has a looooong way to go before it can be implemented by anyone other than hardcore experts.
< sipa> NotAnNSAgent: for the longest time i was not paid to work on bitcoin, and i still spent weekends and evenings on it. please don't say that money is the only reason to do things
< NotAnNSAgent> Now you're just being ridiculous. Are you saying that every Bitcoin business in the world uses third-party clients because the official one only allows one single wallet?
< gmaxwell> There isn't really any "from" in the design of the bitcoin protocol in any case-- that people often think there is an artifact of the forensic analysis done by block explorers and the presentation of that analysis as 'transactions' in a way that doesn't actually reflect the operation of the bitcoin system.
< gmaxwell> sturles: the lack of good durability options for bitcoin wallets probably makes that workflow suboptimal. You probably want to have something that lets you send a transaction atomically with making a backup.
< sipa> but it's good to know that we should probably ask the bitcoin.org people to mark those RPCs as deprecated on the site
< NotAnNSAgent> But then why does this up-to-date, apparently-official manual mention accounts for the very same API call? https://bitcoin.org/en/developer-reference#sendfrom
< belcher> well they are, since before i got interested in bitcoin
< NotAnNSAgent> https://bitcoin.org/en/developer-reference#bitcoin-core-apis <-- This page doesn't seem to even display correctly.
< sipa> i suggest using the developer documentation on bitcoin.org
< NotAnNSAgent> sipa: "<amount> is a real and is rounded to 8 decimal places." <-- 0.1 seems to not mean "one tenth of a Bitcoin".
< sipa> bitcoin core's wallet is design so it only needs a backup every 100 (or whatever you set the keypool size too) transactions
< GitHub188> [bitcoin] sipa opened pull request #7934: Improve rolling bloom filter performance and benchmark (master...benchrollingbloom) https://github.com/bitcoin/bitcoin/pull/7934
< sipa> i'm not sure what kind of notifications you're talking about, as i haven't used windows or the bitcoin core GUI in a long time
< NotAnNSAgent> And it appears to be impossible to enable them only for Bitcoin Core.
< NotAnNSAgent> Since Windows 10, the Bitcoin Core client for Windows uses the awful Windows 10 notifications, which I've been forced to turn off globally.
< GitHub10> [bitcoin] sipa opened pull request #7933: Fix OOM when deserializing UTXO entries with invalid length (master...fixcompressoroom) https://github.com/bitcoin/bitcoin/pull/7933
< GitHub137> [bitcoin] pstratem closed pull request #7931: [WIP] Fuzzing framework (master...2016-04-20-fuzzing-framework) https://github.com/bitcoin/bitcoin/pull/7931
< gmaxwell> phantomcircuit: bitcoin-fuzzy should probably be in test/
< GitHub54> [bitcoin] pstratem opened pull request #7932: CAddrMan::Deserialize handle corrupt serializations better. (master...2016-04-23-addrman-deserialize-limits) https://github.com/bitcoin/bitcoin/pull/7932
< GitHub198> [bitcoin] pstratem closed pull request #7930: CAddrMan::Deserialize Initialize to NULL on insane input. (master...2014-04-23-addrman-deserialize-limits) https://github.com/bitcoin/bitcoin/pull/7930
< GitHub119> [bitcoin] pstratem opened pull request #7931: [WIP] Fuzzing framework (master...2016-04-20-fuzzing-framework) https://github.com/bitcoin/bitcoin/pull/7931
< GitHub117> [bitcoin] pstratem opened pull request #7930: CAddrMan::Deserialize Initialize to NULL on insane input. (master...2014-04-23-addrman-deserialize-limits) https://github.com/bitcoin/bitcoin/pull/7930

2016-04-23

< luke-jr> Lightsword: see https://github.com/bitcoin/bips/pull/365
< luke-jr> ok, step 1 done I hope: https://github.com/bitcoin/bips/pull/365
< belcher> wrong channel, go to #bitcoin-otc or similar
< airmac> anyone wanna trade i got 29g of bitgold with trade for bitcoin intrested msg me for trade we can use escrow if you want\
< sipa> #bitcoin-otc or similar channels please
< airmac> anyone wanna trade i got 29g of bitgold with trade for bitcoin intrested msg me for trade we can use escrow if you want
< NicolasDorier> in the bitcoin folder does not compile bitcoin2 does
< randy-waterhouse> recent commit 351abf9e035581e3320fbb72ec5b1fa452b09c2f (depends build) introduces following error http://pastebin.com/q5cP70y8 (and core dump) on bitcoin-qt
< luke-jr> NicolasDorier: ideally, copy the entire bitcoin/ dir somewhere, then re-do it successfully and compare
< GitHub187> [bitcoin] laanwj opened pull request #7927: Minor changes to dbwrapper to simplify support for other databases (master...2016_04_dbwrapper_modernization) https://github.com/bitcoin/bitcoin/pull/7927

2016-04-22

< GitHub6> [bitcoin] instagibbs opened pull request #7926: [RPC] push back getaddednodeinfo dead value (master...getaddedpushbackmaster) https://github.com/bitcoin/bitcoin/pull/7926
< GitHub82> [bitcoin] MarcoFalke closed pull request #7918: [qa] mininode: Use hexlify wrapper from util (master...Mf1604-qaMininodeHexlify) https://github.com/bitcoin/bitcoin/pull/7918
< GitHub26> [bitcoin] laanwj closed pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925
< GitHub197> bitcoin/master f604bf6 Wladimir J. van der Laan: Merge #7925: qt: Fix out-of-tree GUI builds...
< GitHub197> bitcoin/master f59dceb Wladimir J. van der Laan: qt: Fix out-of-tree GUI builds...
< GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/351abf9e0355...f604bf63211f
< GitHub99> [bitcoin] laanwj opened pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925
< GitHub133> [bitcoin] laanwj closed pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
< GitHub139> bitcoin/master 351abf9 Wladimir J. van der Laan: Merge #7911: leveldb: integrate leveldb into our buildsystem...
< GitHub139> bitcoin/master a4625ac Cory Fields: leveldb: integrate leveldb into our buildsystem...
< GitHub139> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90653bc91d39...351abf9e0355
< GitHub105> [bitcoin] laanwj closed pull request #7922: CBase58Data::SetString: cleanse the full vector (master...cleanse-fully) https://github.com/bitcoin/bitcoin/pull/7922
< GitHub186> bitcoin/master 90653bc Wladimir J. van der Laan: Merge #7922: CBase58Data::SetString: cleanse the full vector...
< GitHub186> bitcoin/master 5770449 Kaz Wesley: CBase58Data::SetString: cleanse the full vector...
< GitHub186> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76176823ba6a...90653bc91d39
< GitHub59> bitcoin/master 7617682 Wladimir J. van der Laan: Merge #7919: Fix headers announcements edge case...
< GitHub157> [bitcoin] laanwj closed pull request #7919: Fix headers announcements edge case (master...fix-sendheaders-edge-case) https://github.com/bitcoin/bitcoin/pull/7919
< GitHub59> bitcoin/master 3a99fb2 Suhas Daftuar: Fix headers announcements edge case...
< GitHub59> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c95ebce7e67...76176823ba6a
< GitHub90> [bitcoin] laanwj closed pull request #7816: [Wallet] slighly refactor GetOldestKeyPoolTime() (master...2016/04/wallet_oldest_key) https://github.com/bitcoin/bitcoin/pull/7816
< GitHub132> bitcoin/master 0c95ebc Wladimir J. van der Laan: Merge #7816: [Wallet] slighly refactor GetOldestKeyPoolTime()...
< GitHub132> bitcoin/master 9f7336b Jonas Schnelli: [Wallet] slightly refactor GetOldestKeyPoolTime()
< GitHub132> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/59ad56851a34...0c95ebce7e67
< GitHub172> [bitcoin] kazcw closed pull request #7923: Enable leveldb obfuscation for new databases (master...obfuscate) https://github.com/bitcoin/bitcoin/pull/7923
< GitHub185> [bitcoin] kazcw opened pull request #7923: Enable leveldb obfuscation for new databases (master...obfuscate) https://github.com/bitcoin/bitcoin/pull/7923
< GitHub71> [bitcoin] kazcw opened pull request #7922: CBase58Data::SetString: cleanse the full vector (master...cleanse-fully) https://github.com/bitcoin/bitcoin/pull/7922

2016-04-21

< luke-jr> hrm, I fixed some Travis-outside-of-"bitcoin" issues earleir this year
<@sipa> i would love to just enable travis on my own bitcoin fork repo
< airmac> anyone intrested in trading bitgold for bitcoin we can use escrow if you like
< Chris_Stewart_5> jl2012: Looks like you right, in sipa's pull request refactoring test cases he expects an OP_COUNT error https://github.com/sipa/bitcoin/blob/refactorscriptests_12/src/test/data/script_tests.json#L1097-L1101
< GitHub137> [bitcoin] MarcoFalke closed pull request #7912: Tests: Fix deserialization of reject messages (master...fix-mininode-reject) https://github.com/bitcoin/bitcoin/pull/7912
< GitHub39> bitcoin/master 59ad568 MarcoFalke: Merge #7912: Tests: Fix deserialization of reject messages...
< GitHub39> bitcoin/master 807fa47 Suhas Daftuar: Tests: Fix deserialization of reject messages...
< GitHub39> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78d61aab233f...59ad56851a34
< GitHub188> [bitcoin] laanwj closed pull request #7921: [contrib] verify-commits: Add MarcoFalke fingerprint (master...Mf1604-contribMFfingerp) https://github.com/bitcoin/bitcoin/pull/7921
< GitHub77> bitcoin/master fa24329 MarcoFalke: [contrib] verify-commits: Add MarcoFalke fingerprint
< GitHub77> bitcoin/master 78d61aa Wladimir J. van der Laan: Merge #7921: [contrib] verify-commits: Add MarcoFalke fingerprint...
< GitHub77> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3689ac463439...78d61aab233f
< GitHub84> [bitcoin] MarcoFalke opened pull request #7921: [contrib] verify-commits: Add MarcoFalke fingerprint (master...Mf1604-contribMFfingerp) https://github.com/bitcoin/bitcoin/pull/7921
< MarcoFalke> Ok, will add this to https://github.com/sipa/bitcoin/pull/79
< MarcoFalke> Basically https://github.com/bitcoin/bitcoin/pull/7918 would conflict with segwit (on purpose) to get rid of the wildcard import and other cleanup. Should I submit this to the segwit branch instead?
< jonasschnelli> His last commits where not listed as "verified" by github: https://github.com/bitcoin/bitcoin/pull/7918/commits
< jonasschnelli> Hmm... maybe you should add you key here first: https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys
< wumpus> MarcoFalke: I've just enabled commit access to bitcoin/bitcoin for you - to get you started, can you try to merge #7912 using the github-merge.py script? If you need any help setting it up let me know
< GitHub1> [bitcoin] laanwj closed pull request #7916: Explicitly pass CChainParams& to DisconnectTip() (master...global-params-cleanup) https://github.com/bitcoin/bitcoin/pull/7916
< GitHub119> bitcoin/master d0a6353 face: Pass CChainParams to DisconnectTip()
< GitHub119> bitcoin/master 176869f face: Explicitly pass CChainParams to ConnectBlock
< GitHub119> bitcoin/master 764d237 Jorge Timón: Globals: Explicitly pass const CChainParams& to UpdateTip()
< GitHub119> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/bafd075c5e6a...3689ac463439
< GitHub5> [bitcoin] sipa closed pull request #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp) (master...getpubkey-locking-fix) https://github.com/bitcoin/bitcoin/pull/7913
< GitHub164> bitcoin/master bafd075 Pieter Wuille: Merge #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp)...
< GitHub164> bitcoin/master 220f950 Yuri Zhykin: Fix for incorrect locking in GetPubKey() (keystore.cpp)
< GitHub164> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7daa3adb242d...bafd075c5e6a
< GitHub128> [bitcoin] sipa closed pull request #7868: net: Split DNS resolving functionality out of net structures (master...net-cleanup-resolve) https://github.com/bitcoin/bitcoin/pull/7868
< GitHub144> bitcoin/master 3675699 Cory Fields: net: resolve outside of storage structures...
< GitHub144> bitcoin/master a98cd1f Cory Fields: net: manually resolve dns seed sources...
< GitHub144> bitcoin/master e9fc71e Cory Fields: net: require lookup functions to specify all arguments...
< GitHub144> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/04a29373571d...7daa3adb242d
< GitHub112> [bitcoin] theuni opened pull request #7920: Do not merge yet: Switch Travis to Trusty (master...travis-trusty) https://github.com/bitcoin/bitcoin/pull/7920

2016-04-20

< kanzure> sipa: i replied re: SignatureHash namecalling :) https://github.com/bitcoin/bips/pull/374#issuecomment-212632899
< GitHub54> [bitcoin] sdaftuar opened pull request #7919: Fix headers announcements edge case (master...fix-sendheaders-edge-case) https://github.com/bitcoin/bitcoin/pull/7919
< GitHub21> [bitcoin] MarcoFalke opened pull request #7918: [qa] mininode: Use hexlify wrapper from util (master...Mf1604-qaMininodeHexlify) https://github.com/bitcoin/bitcoin/pull/7918
< MarcoFalke> Should be one of those tagged with "wallet": https://github.com/bitcoin/bitcoin/issues/created_by/MarcoFalke
< GitHub13> [bitcoin] sipa opened pull request #7917: Optimize reindex (master...betterreindex) https://github.com/bitcoin/bitcoin/pull/7917
< GitHub41> [bitcoin] jtimon closed pull request #7876: Globals: Explicitly pass const CChainParams& to UpdateTip() (master...0.12.99-globals-chainparams-updatetip) https://github.com/bitcoin/bitcoin/pull/7876
< GitHub149> [bitcoin] hmel opened pull request #7916: Explicitly pass CChainParams& to DisconnectTip() (master...global-params-cleanup) https://github.com/bitcoin/bitcoin/pull/7916
< GitHub185> [bitcoin] venatici opened pull request #7914: [qa] Add optional unique coinbase generation (master...coinbase) https://github.com/bitcoin/bitcoin/pull/7914
< murch> sipa: We've actually met once (very briefly) at Bitcoin 2014. :) I said hi, and told you that I'm a moderator on Bitcoin.SE. and you said, you love our work. Heh.
< murch> Completely different topic: I'm going to have a meeting later today about a potential master thesis in the area of Bitcoin. I've proposed to do my master thesis on Coin Selection (which I've did some simulation work before, e.g. gmaxwell had commented then). I've seen that CoinSelection is scheduled to be "looked at" for 0.13. Do you think it would make sense to have a more systematic analysis of CoinSelection even though that's schedu
< murch> My intent is to point out an easy improvement that could be made in the communication with the broader Bitcoin community. Unless I'm mistaken and the table is up-to-date. Then I'll rest my case of course. ;)
< murch> btcdrak: E.g. adam3us has referred to the table 16 days ago (https://www.reddit.com/r/Bitcoin/comments/4d3pdg/clearing_the_fud_around_segwit/d1nxxq6) as showing that secondary projects are working on SegWit. I've called him out on that, because the table doesn't actually show that. (I'm Xekyo on reddit). I would like to propose that development teams listed on that table get nudged to update their status, because it is my understanding
< kanzure> sipa: there is some minor doubled text at the start of your issue comment, https://github.com/bitcoin/bitcoin/pull/7910#issuecomment-211998958

2016-04-19

< GitHub192> [bitcoin] yurizhykin opened pull request #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp) (master...getpubkey-locking-fix) https://github.com/bitcoin/bitcoin/pull/7913
< GitHub79> [bitcoin] sdaftuar opened pull request #7912: Tests: Fix deserialization of reject messages (master...fix-mininode-reject) https://github.com/bitcoin/bitcoin/pull/7912
< GitHub181> [bitcoin] theuni opened pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
< sipa> bitcoin.sipa.be is a node, and run with -segnet
< NicolasDorier> morcos: there is this bug https://github.com/sipa/bitcoin/issues/73, I'll find out what happen later, but the problem is that the transaction is rejected by mempool but still added to wallet transactions. Then after one block, the transaction is rebroadcasted but this time accepted to mempool. The caller of sendtoaddress got an error and thought the money
< GitHub166> [bitcoin] jonasschnelli closed pull request #7404: [WIP] Segregated Witness (0.12...segwit) https://github.com/bitcoin/bitcoin/pull/7404
< GitHub10> [bitcoin] sipa opened pull request #7910: Segregated witness (master...segwit-master) https://github.com/bitcoin/bitcoin/pull/7910
< NicolasDorier> btw, I think it is risky to add a transaction to the wallet before it has been accepted by the mempool (https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2285)
< NicolasDorier> I was investigating https://github.com/sipa/bitcoin/issues/73
< GitHub145> [bitcoin] laanwj closed pull request #7787: [Moveonly] Create ui_interface.cpp (master...Mf1604-move-ui-helpers) https://github.com/bitcoin/bitcoin/pull/7787
< GitHub29> bitcoin/master 04a2937 Wladimir J. van der Laan: Merge #7787: [Moveonly] Create ui_interface.cpp...
< GitHub29> bitcoin/master fabbf80 MarcoFalke: [ui] Move InitError, InitWarning, AmountErrMsg
< GitHub29> bitcoin/master fa10ce6 MarcoFalke: Move ui_interface.cpp to libbitcoin_server_a_SOURCES...
< GitHub29> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1eb344ba8f4...04a29373571d
< GitHub76> [bitcoin] laanwj closed pull request #7762: [ZMQ] append a message sequence number to every ZMQ notification (master...2016/03/zmq_seq) https://github.com/bitcoin/bitcoin/pull/7762
< GitHub37> bitcoin/master a1eb344 Wladimir J. van der Laan: Merge #7762: [ZMQ] append a message sequence number to every ZMQ notification...
< GitHub37> bitcoin/master 0b25a9f Jonas Schnelli: [ZMQ] append a message sequence number to every ZMQ notification
< GitHub37> bitcoin/master de821d5 Jonas Schnelli: [ZMQ] refactor message string
< GitHub37> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e6fd5e4af31...a1eb344ba8f4
< GitHub40> [bitcoin] laanwj closed pull request #7822: Add listunspent() test for spendable/unspendable UTXO (master...support/add-test-listunspent) https://github.com/bitcoin/bitcoin/pull/7822
< GitHub84> bitcoin/master 0e6fd5e Wladimir J. van der Laan: Merge #7822: Add listunspent() test for spendable/unspendable UTXO...
< GitHub84> bitcoin/master 5d217de Joao Fonseca: Add test to check spendable and unspendable UTXO on RPC listunspent
< GitHub84> bitcoin/master fa942c7 Joao Fonseca: Move method to check matches within arrays on util.py
< GitHub84> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/187186b0fe03...0e6fd5e4af31
< GitHub199> [bitcoin] laanwj closed pull request #7625: Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused (master...bugfix_bench_checks) https://github.com/bitcoin/bitcoin/pull/7625
< GitHub112> [bitcoin] laanwj closed pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
< GitHub49> bitcoin/master a25a4f5 Wladimir J. van der Laan: wallet_ismine.h → script/ismine.h...
< GitHub49> bitcoin/master f4eae2d Wladimir J. van der Laan: test: Create test fixture for wallet...
< GitHub49> bitcoin/master de39c95 Wladimir J. van der Laan: test: move accounting_tests and rpc_wallet_tests to wallet/test...
< GitHub49> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4205ad7ca2b1...187186b0fe03
< GitHub49> [bitcoin] laanwj closed pull request #7827: Speed up getchaintips. (master...ba-fix-chaintips) https://github.com/bitcoin/bitcoin/pull/7827
< GitHub170> bitcoin/master 4205ad7 Wladimir J. van der Laan: Merge #7827: Speed up getchaintips....
< GitHub170> bitcoin/master 87049e8 mrbandrews: Speed up getchaintips.
< GitHub170> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa9d86f8c4f4...4205ad7ca2b1
< GitHub131> [bitcoin] laanwj closed pull request #7851: [qa] pull-tester: Don't mute zmq ImportError (master...Mf1604-qaUnmuteError) https://github.com/bitcoin/bitcoin/pull/7851
< GitHub160> bitcoin/master fae1f4e MarcoFalke: [qa] rpc-tests: Fix link in comment and label error msg
< GitHub160> bitcoin/master faa4f22 MarcoFalke: [qa] pull-tester: Exit early when no tests are run
< GitHub160> bitcoin/master fa05e22 MarcoFalke: [qa] pull-tester: Don't mute zmq ImportError
< GitHub160> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc9e3346e674...fa9d86f8c4f4
< GitHub161> [bitcoin] laanwj closed pull request #7894: [Qt] Use CURRENCY_UNIT for BitcoinUnits. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/7894
< GitHub13> [bitcoin] laanwj closed pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
< GitHub26> bitcoin/master fc9e334 Wladimir J. van der Laan: Merge #7904: txdb: Fix assert crash in new UTXO set cursor...
< GitHub26> bitcoin/master a3310b4 Wladimir J. van der Laan: txdb: Fix assert crash in new UTXO set cursor...
< GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d28995018003...fc9e3346e674
< gmaxwell> $ grep 'received: notfound' ~/.bitcoin/debug.log | cut -d' ' -f1 | sort | uniq -c | sort -n
< GitHub89> [bitcoin] pstratem opened pull request #7907: Optimize and Cleanup CScript::FindAndDelete (master...2016-04-17-findanddelete) https://github.com/bitcoin/bitcoin/pull/7907
< phantomcircuit> cfields: what's the best way to add a new binary to the auto tools stuff? i tried copying bitcoin-tx stuff and renaming it but things exploded

2016-04-18

< GitHub142> [bitcoin] theuni opened pull request #7906: net: prerequisites for p2p encapsulation changes (master...net-refactor-prerequisites) https://github.com/bitcoin/bitcoin/pull/7906
< Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L906 is the line i think is where the error is set
< GitHub148> [bitcoin] gavinandresen closed pull request #7887: Remove mapBlockSource (master...remove_mapBlockSource) https://github.com/bitcoin/bitcoin/pull/7887
< Chris_Stewart_5> Where is the sigop limit tracked in bitcoin core? I cannot seem to find it in interpreter.cpp
< GitHub61> [bitcoin] laanwj closed pull request #7900: fix spelling mistake (master...patch-3) https://github.com/bitcoin/bitcoin/pull/7900
< GitHub30> bitcoin/master d289950 Wladimir J. van der Laan: Merge #7900: fix spelling mistake...
< GitHub30> bitcoin/master 3107c47 Chris Moore: fix spelling mistake
< GitHub30> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9eb7565cddf2...d28995018003
< GitHub170> [bitcoin] laanwj closed pull request #7897: add missing newline (master...patch-2) https://github.com/bitcoin/bitcoin/pull/7897
< GitHub185> bitcoin/master dc0693f Chris Moore: add missing newline...
< GitHub185> bitcoin/master 9eb7565 Wladimir J. van der Laan: Merge #7897: add missing newline...
< GitHub185> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88616d200863...9eb7565cddf2
< GitHub167> [bitcoin] laanwj opened pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
< GitHub59> [bitcoin] laanwj closed pull request #7848: Divergence between 32- and 64-bit when hashing >4GB affects `gettxoutsetinfo` (master...2016_04_hash_4gb_utxoset) https://github.com/bitcoin/bitcoin/pull/7848
< GitHub146> bitcoin/master 28b400f Wladimir J. van der Laan: doc: update release-notes for `gettxoutsetinfo` change
< GitHub146> bitcoin/master 9ad1a51 Wladimir J. van der Laan: crypto: bytes counts are 64 bit...
< GitHub146> bitcoin/master 76212bb Wladimir J. van der Laan: rpc: make sure `gettxoutsetinfo` hash has txids...
< GitHub146> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1bf511af693...88616d200863
< GitHub134> [bitcoin] laanwj closed pull request #7833: tests: Check Content-Type header returned from RPC server (master...2016_04_rpc_tests_check_content_type) https://github.com/bitcoin/bitcoin/pull/7833
< GitHub29> bitcoin/master b1bf511 Wladimir J. van der Laan: Merge #7833: tests: Check Content-Type header returned from RPC server...
< GitHub29> bitcoin/master 5078ca4 Wladimir J. van der Laan: tests: Check Content-Type header returned from RPC server...
< GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec870e13991f...b1bf511af693
< GitHub124> [bitcoin] laanwj closed pull request #7888: prevector: fix 2 bugs in currently unreached code paths (master...pvfix) https://github.com/bitcoin/bitcoin/pull/7888
< GitHub153> bitcoin/master a7af72a Kaz Wesley: prevector::swap: fix (unreached) data corruption...
< GitHub153> bitcoin/master 4ed41a2 Kaz Wesley: test prevector::swap...
< GitHub153> bitcoin/master 1e2c29f Kaz Wesley: prevector: destroy elements only via erase()...
< GitHub153> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/73fc922ed643...ec870e13991f
< GitHub19> [bitcoin] laanwj opened pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
< GitHub31> [bitcoin] TheBlueMatt opened pull request #7903: Fix help text around importaddress and rename it to importscript (master...16-04-importaddress-helptext) https://github.com/bitcoin/bitcoin/pull/7903
< Chris_Stewart_5> does it hit this in bitcoin core? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L990

2016-04-17

2016-04-16

< GitHub177> [bitcoin] dooglus opened pull request #7899: optionally provide privkey to signmessage RPC (master...signmessage-using-privkey) https://github.com/bitcoin/bitcoin/pull/7899
< GitHub14> [bitcoin] dooglus closed pull request #7898: optionally provide privkey to signmessage RPC (master...signmessage-using-privkey) https://github.com/bitcoin/bitcoin/pull/7898
< GitHub122> [bitcoin] dooglus opened pull request #7898: optionally provide privkey to signmessage RPC (master...signmessage-using-privkey) https://github.com/bitcoin/bitcoin/pull/7898
< GitHub127> [bitcoin] dooglus opened pull request #7897: add missing newline (master...patch-2) https://github.com/bitcoin/bitcoin/pull/7897
< GitHub140> [bitcoin] dooglus opened pull request #7896: fix typo in help text (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7896
< GitHub141> [bitcoin] domob1812 opened pull request #7894: [Qt] Use CURRENCY_UNIT for BitcoinUnits. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/7894
< sipa> hmm, doc/release-process.md mentions that detached signatures are posted to https://github.com/bitcoin/bitcoin-detached-sigs
< GitHub86> [bitcoin] laanwj opened pull request #7892: Add full UTF-8 support to RPC (master...2016_04_i18n_unicode_rpc) https://github.com/bitcoin/bitcoin/pull/7892
< GitHub65> [bitcoin] sipa opened pull request #7891: Always require OS randomness when generating secret keys (master...betterrng) https://github.com/bitcoin/bitcoin/pull/7891
< GitHub107> [bitcoin] kazcw opened pull request #7888: prevector: fix 2 bugs in currently unreached code paths (master...pvfix) https://github.com/bitcoin/bitcoin/pull/7888

2016-04-15

< GitHub106> [bitcoin] gavinandresen opened pull request #7887: Remove mapBlockSource (master...remove_mapBlockSource) https://github.com/bitcoin/bitcoin/pull/7887