2019-03-05

< bitcoin-git> bitcoin/master 4b57b7f Wladimir J. van der Laan: Merge #15527: doc: Remove pr release notes file in wrong dir
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/6a178e52618d...71ac4ebe4893
< bitcoin-git> bitcoin/0.18 71ac4eb MarcoFalke: doc: Remove pr release notes file in wrong dir
< bitcoin-git> [bitcoin] fanquake closed pull request #15535: Dander (0.14...master) https://github.com/bitcoin/bitcoin/pull/15535
< bitcoin-git> [bitcoin] Deano1167 opened pull request #15535: Dander (0.14...master) https://github.com/bitcoin/bitcoin/pull/15535
< zhangzf> hello, Who have testnet bitcoin? Can you give me some, I want to test code. My address is mgSRBDvv9h2bRgZHGWLo4xQU9PLvssK6Yi
< bitcoin-git> [bitcoin] gwillen opened pull request #15534: In lint-format-strings, open files sequentially (fix for OS X failure) (master...feature-fix-lint-osx) https://github.com/bitcoin/bitcoin/pull/15534
< achow101> my gitian build results are available at https://github.com/achow101/bitcoin/releases/tag/v0.18.0rc1 if you need them

2019-03-04

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15533: test: .style.yapf: Set column_limit=160 (master...1903-testNoPep8Collim) https://github.com/bitcoin/bitcoin/pull/15533
< gmaxwell> Does anyone in here have a host with clang8? looks like fedora29 is using clang7. ISTM its assembly is broken: https://github.com/bitcoin-core/secp256k1/issues/594
< bitcoin-git> [bitcoin] practicalswift opened pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15531: Suggested interfaces::Chain cleanups from #15288 (master...pr/wclean2) https://github.com/bitcoin/bitcoin/pull/15531
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530
< bitcoin-git> [bitcoin] sipsorcery opened pull request #15529: WIP: Add Qt programs to msvc build (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528
< harding> dongcarl: I just tried and it lets me edit via the web interface but git push for the exact same change gives me: remote: Permission to bitcoin-core/bitcoin-devwiki.wiki.git denied to harding.
< gribble> https://github.com/bitcoin/bitcoin/issues/15527 | doc: Remove pr release notes file in wrong dir by MarcoFalke · Pull Request #15527 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15527: doc: Remove pr release notes file in wrong dir (master...1903-docRelPr) https://github.com/bitcoin/bitcoin/pull/15527
< harding> sipa: the PSBT doc was backported to the 0.17 branch but was not released in 0.17.1 (and there's no 0.17.2 yet). See MarcoFalke and my discussion about it here: https://github.com/bitcoin/bitcoin/pull/15314#issuecomment-459740847
< dongcarl> Anyone know how to push to the wiki? I've got `git@github.com:bitcoin-core/bitcoin-devwiki.wiki.git` as my remote and git tells me permission denied
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45f434f44d0b...14023c966c51
< bitcoin-git> bitcoin/master fa45123 MarcoFalke: test: Add .style.yapf
< bitcoin-git> bitcoin/master 14023c9 MarcoFalke: Merge #15479: test: Add .style.yapf
< dongcarl> wumpus: Wondering what should be done about https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes/release-notes-pr12255.md ? It seems that at least it should go in the release notes for 0.18, and perhaps removed from the tree?
< bitcoin-git> [bitcoin] MarcoFalke pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/57acfcb9fd05...45f434f44d0b
< bitcoin-git> bitcoin/master 80f52a2 Russell Yanofsky: Remove uses of CheckFinalTx in wallet code
< bitcoin-git> bitcoin/master bdc6628 Russell Yanofsky: Remove use of IsRBFOptIn in wallet code
< bitcoin-git> bitcoin/master 291276f Russell Yanofsky: Remove use of GetCountWithDescendants in wallet code
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15288: Remove wallet -> node global function calls (master...pr/wchain3) https://github.com/bitcoin/bitcoin/pull/15288
< Dizzle> lorko123: let's take this to #bitcoin
< lorko123> anyone know how to mine bitcoin directly with bitcoin core
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
< bitcoin-git> [bitcoin] laanwj deleted tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/329381d6ae9a...000000000000
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/7630301c1628...6a178e52618d
< bitcoin-git> bitcoin/0.18 6a178e5 Wladimir J. van der Laan: build: set RC1
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/b702e3757e1d...7630301c1628
< bitcoin-git> bitcoin/0.18 fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
< bitcoin-git> bitcoin/0.18 7630301 Wladimir J. van der Laan: Merge #15524: [0.18] doc: Remove ppa from linux build instructions
< bitcoin-git> [bitcoin] laanwj merged pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
< wumpus> 0.18.0 release notes draft up on the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/742f7dd972fc...b702e3757e1d
< bitcoin-git> bitcoin/0.18 b702e37 Wladimir J. van der Laan: doc: Merge release notes fragments
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
<@luke-jr> rafalcpp: include a copy of just boost::process in the Bitcoin source code, used when the system lacks it
< rafalcpp> I could make another small script to grab + build enough of boost to have boost::process for Bitcoin
< bitcoin-git> [bitcoin] practicalswift opened pull request #15522: Document sizeof(size_t) assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
< gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d46f1be0c3c...57acfcb9fd05
< bitcoin-git> bitcoin/master fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
< bitcoin-git> bitcoin/master 57acfcb Wladimir J. van der Laan: Merge #15518: doc: Remove ppa from linux build instructions
< wumpus> so is there anything in https://github.com/bitcoin/bitcoin/milestones/0.18.0 that blocks rc1?
< bitcoin-git> [bitcoin] rojarsmith opened pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521

2019-03-03

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15520: ci: Run extended tests (master...1903-ciExt) https://github.com/bitcoin/bitcoin/pull/15520
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15519: Add Poly1305 implementation (master...2019/03/poly1305) https://github.com/bitcoin/bitcoin/pull/15519
< gribble> https://github.com/bitcoin/bitcoin/issues/15474 | rest/rpc: Make mempoolinfo atomic by promag · Pull Request #15474 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15464 | gui: Drop unused return values in WalletFrame by promag · Pull Request #15464 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518
< bitcoin-git> [bitcoin] promag opened pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517
< gribble> https://github.com/bitcoin/bitcoin/issues/15500 | Support for a bitcoind ready file to indicate startup is complete. by murrayn · Pull Request #15500 · bitcoin/bitcoin · GitHub

2019-03-02

< bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/789b0bbf2afc...2d46f1be0c3c
< bitcoin-git> bitcoin/master 62e7add Jim Posen: util: Move CheckDiskSpace to util.
< bitcoin-git> bitcoin/master 9183d6e Jim Posen: validation: Extract basic block file logic into FlatFileSeq class.
< bitcoin-git> bitcoin/master e2d2abb Jim Posen: validation: Refactor OpenDiskFile into method on FlatFileSeq.
< bitcoin-git> [bitcoin] laanwj merged pull request #15118: Refactor block file logic (master...flatfile) https://github.com/bitcoin/bitcoin/pull/15118
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15335: Fix lack of warning of unrecognized section names (master...conf_include_multi) https://github.com/bitcoin/bitcoin/pull/15335
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/849f37fa22b0...789b0bbf2afc
< bitcoin-git> bitcoin/master 1a7ba84 Akio Nakamura: Fix lack of warning of unrecognized section names
< bitcoin-git> bitcoin/master 789b0bb MarcoFalke: Merge #15335: Fix lack of warning of unrecognized section names
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80112b17e75b...849f37fa22b0
< bitcoin-git> bitcoin/master fa1d400 MarcoFalke: cirrus ci: Inital config
< bitcoin-git> bitcoin/master 849f37f MarcoFalke: Merge #15338: ci: Build and run tests once on freebsd
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15296: tests: Add script checking for deterministic line coverage in unit tests (master...test_deterministic_coverage) https://github.com/bitcoin/bitcoin/pull/15296
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e3122de054a...80112b17e75b
< bitcoin-git> bitcoin/master 4320623 practicalswift: tests: Add script checking for deterministic line coverage
< bitcoin-git> bitcoin/master 80112b1 MarcoFalke: Merge #15296: tests: Add script checking for deterministic line coverage i...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e47d8a1b7c8b...9e3122de054a
< bitcoin-git> bitcoin/master 8bb3e4c Sjors Provoost: [rpc] remove deprecated generate method
< bitcoin-git> bitcoin/master 07cae52 Sjors Provoost: [wallet] remove unused GetScriptForMining
< bitcoin-git> bitcoin/master 9e3122d MarcoFalke: Merge #15492: [rpc] remove deprecated generate method
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15492: [rpc] remove deprecated generate method (master...2019/02/rpc-generate-remove) https://github.com/bitcoin/bitcoin/pull/15492
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c9985c84f9c1...e47d8a1b7c8b
< bitcoin-git> bitcoin/master 10c7642 marcuswin: docs: Update Transifex links
< bitcoin-git> bitcoin/master e47d8a1 MarcoFalke: Merge #15514: docs: Update Transifex links
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15514: docs: Update Transifex links (master...rebase-fixup-15406) https://github.com/bitcoin/bitcoin/pull/15514
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/37f236acc6de...c9985c84f9c1
< bitcoin-git> bitcoin/master c9985c8 Wladimir J. van der Laan: build: Bump version to 0.18.99
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/37f236acc6de...742f7dd972fc
< bitcoin-git> bitcoin/0.18 742f7dd Wladimir J. van der Laan: build: Bump version to 0.18.0
< bitcoin-git> [bitcoin] darosior closed pull request #15511: RPC : More user-friendly services field in getnetworkinfo and getpeerinfo (master...services_for_humans) https://github.com/bitcoin/bitcoin/pull/15511
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< wumpus> good, it worked; [bitcoin-git] is logged in as bitcoin-git
< bitcoin-git> [bitcoin] fanquake closed pull request #15071: Docs: add gmake syntax to autoconf script (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15071
< gribble> https://github.com/bitcoin/bitcoin/issues/15071 | Docs: add gmake syntax to autoconf script by seth586 · Pull Request #15071 · bitcoin/bitcoin · GitHub
< wumpus> FWIW, I have registered bitcoin-git as well, and added a password to the bot configuration
< bitcoin-git> [bitcoin] fanquake opened pull request #15514: docs: Update Transifex links (master...rebase-fixup-15406) https://github.com/bitcoin/bitcoin/pull/15514
< bitcoin-git> [bitcoin] fanquake closed pull request #15406: docs: update transifex links (master...master) https://github.com/bitcoin/bitcoin/pull/15406
< wumpus> so the channel is talk-only-for-registered-users again? would it help to register bitcoin-git?
< wumpus> poor bitcoin-git bot
< gribble> https://github.com/bitcoin/bitcoin/issues/15510 | [rpc] deriveaddresses: add range to CRPCConvertParam by Sjors · Pull Request #15510 · bitcoin/bitcoin · GitHub
< gwillen> fwiw I am a relatively experienced chanop, an op in #bitcoin and related channels, highlight on ! ops, and willing to ban people who need it, should this channel be desirous of more ops

2019-03-01

< sipa> they're a software (and bitcoin core specifically...) kinda thing
< provoostenator> Basically Bitcoin Core could give an account number and then HWI would, if the device supports SegWit return three descriptors: "pkh([44'/0'/account]xpub/0/*])", "sh(wpkh([49'/0'/account]xpub/0/*]))" and "wpkh([84'/0'/account]xpub/0/*])" (plus change), and then our wallet imports one or all
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (master...test_rpc_misc) https://github.com/bitcoin/bitcoin/pull/15485
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc251de6a5c4...f9dbb319d26f
< bitcoin-git> bitcoin/master 2fa85eb Adam Jonas: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo
< bitcoin-git> bitcoin/master f13ad1c Adam Jonas: modify test for memory locked in case locking pages failed at some point
< bitcoin-git> bitcoin/master f9dbb31 MarcoFalke: Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15512: Add ChaCha20 encryption option (XOR) (master...2019/03/chacha) https://github.com/bitcoin/bitcoin/pull/15512
< bitcoin-git> [bitcoin] darosior opened pull request #15511: RPC : More user-friendly services field in getnetworkinfo and getpeerinfo (master...services_for_humans) https://github.com/bitcoin/bitcoin/pull/15511
< darosior> gmaxwell : It is indicated "only" instead of "also" in the comment https://github.com/bitcoin/bitcoin/blob/a6d7026a45c915794338c178b7f95d5c1f8e977f/src/protocol.h#L267
< provoostenator> Surprising how many testnet peers are still stuck at the CVE-2018-17144 exploit block. https://bitcoin.stackexchange.com/questions/79662/solving-bitcoin-cores-activatebestchain-failed
< darosior> Hi, I saw that in init.cpp the service NODE_NETWORK_LIMITED is set with NODE_NETWORK at the begining, but I wonder why it is not reset if we did not pruned the block chain ? (https://github.com/bitcoin/bitcoin/blob/b4fc5257b7dc106ff210d170397d4ce0e024f2c0/src/init.cpp#L1652)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6d7026a45c9...dc251de6a5c4
< bitcoin-git> bitcoin/master aeb7fbf Chun Kuan Lee: appveyor: Don't build debug libraries instead of "build and delete"
< bitcoin-git> bitcoin/master dc251de MarcoFalke: Merge #15506: appveyor: fix cache issue and reduce dependencies build time...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15506: appveyor: fix cache issue and reduce dependencies build time (master...appveyor-release-only) https://github.com/bitcoin/bitcoin/pull/15506
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15509: [rpc] deriveaddresses: add range to CRPCConvertParam (master...1903-rpcDeriveAddress) https://github.com/bitcoin/bitcoin/pull/15509
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15509: [rpc] deriveaddresses: add range to CRPCConvertParam (master...1903-rpcDeriveAddress) https://github.com/bitcoin/bitcoin/pull/15509
< bitcoin-git> [bitcoin] Sjors opened pull request #15510: [rpc] deriveaddresses: add range to CRPCConvertParam (master...2019/02/rpcconsistentrange) https://github.com/bitcoin/bitcoin/pull/15510
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15497: rpc: Consistent range arguments in scantxoutset/importmulti/deriveaddresses (master...201902_rpcconsistentrange) https://github.com/bitcoin/bitcoin/pull/15497
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e8612adc5d07...a6d7026a45c9
< bitcoin-git> bitcoin/master 7aa6a8a Pieter Wuille: Add ParseRange function to parse args of the form int/[int,int]
< bitcoin-git> bitcoin/master 6b9f45e Pieter Wuille: Support ranges arguments in RPC help
< bitcoin-git> bitcoin/master 4566011 Pieter Wuille: Add support for stop/[start,stop] ranges to scantxoutset
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29c24b05fb71...e8612adc5d07
< bitcoin-git> bitcoin/master fa852f0 MarcoFalke: test: Bump timeout on tests that timeout on windows
< bitcoin-git> bitcoin/master e8612ad MarcoFalke: Merge #15507: test: Bump timeout on tests that timeout on windows
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15507: test: Bump timeout on tests that timeout on windows (master...1903-testTimeoutWindows) https://github.com/bitcoin/bitcoin/pull/15507
< jonasschnelli> hmm... "bitcoin-addcon invoked oom-killer"
< bitcoin-git> [bitcoin] gwillen opened pull request #15508: Refactor analyzepsbt for use outside RPC code (master...feature-separate-analyzepsbt) https://github.com/bitcoin/bitcoin/pull/15508

2019-02-28

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15507: test: Bump timeout on tests that timeout on windows (master...1903-testTimeoutWindows) https://github.com/bitcoin/bitcoin/pull/15507
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15506: appveyor: fix cache issue and reduce dependencies build time (master...appveyor-release-only) https://github.com/bitcoin/bitcoin/pull/15506
< bitcoin-git> [bitcoin] practicalswift closed pull request #15214: tests: Check for expected return values when calling functions returning a success code (master...check-return-values-in-tests) https://github.com/bitcoin/bitcoin/pull/15214
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15505: [p2p] Request NOTFOUND transactions immediately from other outbound peers, when possible (master...2019-02-notfound-requests) https://github.com/bitcoin/bitcoin/pull/15505
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20268c6d767b...29c24b05fb71
< bitcoin-git> bitcoin/master 4a5e52c Chun Kuan Lee: msvc: Use a single file to specify the include path
< bitcoin-git> bitcoin/master 29c24b0 MarcoFalke: Merge #15503: msvc: Use a single file to specify the include path
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15503: msvc: Use a single file to specify the include path (master...msvc-include-fix) https://github.com/bitcoin/bitcoin/pull/15503
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15504: test: Remove useless test_bitcoin_main.cpp (master...1903-testMain) https://github.com/bitcoin/bitcoin/pull/15504
< gribble> https://github.com/bitcoin/bitcoin/issues/15487 | [WIP] descriptor based wallet by Sjors · Pull Request #15487 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6355 | Added test-before-evict discipline in Addrman, feeler connections. by EthanHeilman · Pull Request #6355 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8282 | net: Feeler connections to increase online addrs in the tried table. by EthanHeilman · Pull Request #8282 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15497 | Consistent range arguments in scantxoutset/importmulti/deriveaddresses by sipa · Pull Request #15497 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< kanzure> how about actual bitcoin core things?
< BlueMatt> please send mail via github pr to bitcoin.ninja
< wumpus> this isn't a *bitcoin core* topic at all
< wumpus> this is about bitcoin protocol discussion
< BlueMatt> ok, -> #bitcoin-dev
< wumpus> #topic bitcoin-dev mailing list
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15503: msvc: Use a single file to specify the include path (master...msvc-include-fix) https://github.com/bitcoin/bitcoin/pull/15503
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< kanzure> bitcoin-dev mailing list has been having issues and it's broken
< bitcoin-git> [bitcoin] Sjors closed pull request #15496: [rpc] deriveaddress: rename range 'begin' argument to 'start' (master...2019/02/begin_start) https://github.com/bitcoin/bitcoin/pull/15496
< bitcoin-git> [bitcoin] ajtowns opened pull request #15502: Speed up initial connection to p2p network (master...201902-trytoavoiddns) https://github.com/bitcoin/bitcoin/pull/15502
< bitcoin-git> [bitcoin] laanwj merged pull request #15489: doc: Update release process for snap package (master...1902-docSnap) https://github.com/bitcoin/bitcoin/pull/15489
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0d4e79b4dbb...20268c6d767b
< bitcoin-git> bitcoin/master fa466cb MarcoFalke: doc: Update release process for snap package
< bitcoin-git> bitcoin/master 20268c6 Wladimir J. van der Laan: Merge #15489: doc: Update release process for snap package
< bitcoin-git> [bitcoin] fanquake closed pull request #15501: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/15501
< bitcoin-git> [bitcoin] murrayn opened pull request #15501: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/15501
< bitcoin-git> [bitcoin] luke-jr closed pull request #15428: [WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code (master...tor_gui_pairing) https://github.com/bitcoin/bitcoin/pull/15428
< bitcoin-git> [bitcoin] murrayn opened pull request #15500: Support for a bitcoind 'ready' file to indicate startup is complete. (master...ready_file) https://github.com/bitcoin/bitcoin/pull/15500
< wannabecoder> oh so the RPC's are written in the console in the bitcoin core app?
< sipa> in bitcoin-qt you can type RPC commands in the console, yes
< sipa> you can also use bitcoin-cli to send commands to a running bitcoind process
< sipa> this probably belongs on #bitcoin
< wannabecoder> I am given an assignment to create a transaction to deposit 0.01 btc to a 2 of 3 multisig script. I have the public keys of three addresses and private keys of three. I have installed Bitcoin Core and configured it to a testnet. question 1: where do i write the code?
< wannabecoder> hello, i am new to coding in bitcoin. I literally can't figure anything out.

2019-02-27

< bitcoin-git> [bitcoin] sipa opened pull request #15497: Consistent range arguments in scantxoutset/importmulti/deriveaddresses (master...201902_rpcconsistentrange) https://github.com/bitcoin/bitcoin/pull/15497
< bitcoin-git> [bitcoin] Sjors opened pull request #15496: [rpc] deriveaddress: rename range 'begin' argument to 'start' (master...2019/02/begin_start) https://github.com/bitcoin/bitcoin/pull/15496
< bitcoin-git> [bitcoin] domob1812 opened pull request #15495: Add regtests for HTTP status codes. (master...test-http-code) https://github.com/bitcoin/bitcoin/pull/15495
< bitcoin-git> [bitcoin] promag opened pull request #15494: rpc: Return whether the block was invalidated on invalidateblock (master...2019-02-invalidateblock) https://github.com/bitcoin/bitcoin/pull/15494
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a4f9c024c650...a0d4e79b4dbb
< bitcoin-git> bitcoin/master fa9ff8f MarcoFalke: doc: Remove misleading hint in getrawtransaction
< bitcoin-git> bitcoin/master 9999879 MarcoFalke: refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction
< bitcoin-git> bitcoin/master a0d4e79 Wladimir J. van der Laan: Merge #15477: doc: Remove misleading hint in getrawtransaction
< bitcoin-git> [bitcoin] laanwj merged pull request #15477: doc: Remove misleading hint in getrawtransaction (master...Mf1902-rpcRawDocFix) https://github.com/bitcoin/bitcoin/pull/15477
< bitcoin-git> [bitcoin] laanwj merged pull request #15468: wallet: Use fsbridge::ifstream to fix Windows path issue (master...win-wallet-fix) https://github.com/bitcoin/bitcoin/pull/15468
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f43ed4c5a3a...a4f9c024c650
< bitcoin-git> bitcoin/master 6ad79cb Chun Kuan Lee: wallet: Use fsbridge::ifstream to fix Windows path issue
< bitcoin-git> bitcoin/master a4f9c02 Wladimir J. van der Laan: Merge #15468: wallet: Use fsbridge::ifstream to fix Windows path issue
< bitcoin-git> [bitcoin] laanwj merged pull request #15462: gui: Fix async open wallet call order (master...2019-02-fix-15455) https://github.com/bitcoin/bitcoin/pull/15462
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d88f7f8764b1...6f43ed4c5a3a
< bitcoin-git> bitcoin/master a720a98 João Barbosa: gui: Fix async open wallet call order
< bitcoin-git> bitcoin/master 6f43ed4 Wladimir J. van der Laan: Merge #15462: gui: Fix async open wallet call order
< gribble> https://github.com/bitcoin/bitcoin/issues/15478 | wip: gui: Refactor open wallet activity by promag · Pull Request #15478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15493: rfc: Add -printconfig arg to bitcoind (master...2019-02-printconfig) https://github.com/bitcoin/bitcoin/pull/15493
< bitcoin-git> [bitcoin] Sjors opened pull request #15492: [rpc] remove deprecated generate method (master...2019/02/rpc-generate-remove) https://github.com/bitcoin/bitcoin/pull/15492
< gribble> https://github.com/bitcoin/bitcoin/issues/15491 | wallet: Improve log output for errors during load by gwillen · Pull Request #15491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15424 | [wallet] wallet-tool: command to remove key metadata by Sjors · Pull Request #15424 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gwillen opened pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< bitcoin-git> [bitcoin] fanquake closed pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< bitcoin-git> [bitcoin] iamgru opened pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15489: doc: Update release process for snap package (master...1902-docSnap) https://github.com/bitcoin/bitcoin/pull/15489

2019-02-26

< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< parmado> is the consensus here that bitcoin will dominate amongst electronic assets, or is there substantial disagreement on that?
< sipa> parmado: #bitcoin
< luke-jr> parmado: the channel is intentionally open to the public; however, if you have questions about Bitcoin, #bitcoin is usually a better place to ask
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14775: net: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15487: [WIP] descriptor based wallet (master...2019/02/descriptor-wallet) https://github.com/bitcoin/bitcoin/pull/15487
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15486: [net] Allow feeler connections to go to the same netgroup as existing outbound peers (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
< bitcoin-git> [bitcoin] adamjonas opened pull request #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (master...test_rpc_misc) https://github.com/bitcoin/bitcoin/pull/15485
< gribble> https://github.com/bitcoin/bitcoin/issues/15481 | Restrict timestamp when mining a diff-adjustment block to prev-600 by TheBlueMatt · Pull Request #15481 · bitcoin/bitcoin · GitHub
< achow101> Has anyone seen this issue with 0.17.1 on ubuntu 18.10 before: https://bitcoin.stackexchange.com/questions/84868/bitcoin-qt-testnet-0-17-1-send-and-receive-buttons-do-nothing?
< gribble> https://github.com/bitcoin/bitcoin/issues/15484 | No feeler connection is made when our tip is stale · Issue #15484 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (master...2019_02_false_positives) https://github.com/bitcoin/bitcoin/pull/15471
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f470ecc534d...d88f7f8764b1
< bitcoin-git> bitcoin/master ef362f2 Wladimir J. van der Laan: rpc/gui: Remove 'Unknown block versions being mined' warning
< bitcoin-git> bitcoin/master d88f7f8 MarcoFalke: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning...
< bitcoin-git> [bitcoin] darosior opened pull request #15483: Adding a 'logpath' entry to getrpcinfo, as discussed in #15438 (master...getrpcinfo_logpath) https://github.com/bitcoin/bitcoin/pull/15483
< Muoi> I run a Bitcoin node, there is no IP inserted to tried table since December, is this a problem?
< kanzure> just fyi, bitcoin-dev mailing list is temporarily broken
< gribble> https://github.com/bitcoin/bitcoin/issues/15482 | Implement BIPXXXs new softfork rules (The Great Consensus Cleanup) by TheBlueMatt · Pull Request #15482 · bitcoin/bitcoin · GitHub

2019-02-25

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15482: Implement BIPXXX's new softfork rules (The Great Consensus Cleanup) (master...2019-02-great-consensus-cleanup) https://github.com/bitcoin/bitcoin/pull/15482
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15481: Restrict timestamp when mining a diff-adjustment block to prev-600 (master...2019-02-600s-gbt) https://github.com/bitcoin/bitcoin/pull/15481
< sipa> dongcarl: it's hash160 of the public key. from bitcoin's perspective, compressed and uncompressed public keys are distinct
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479
< bitcoin-git> [bitcoin] promag opened pull request #15478: wip: gui: Refactor open wallet activity (master...2019-02-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/15478
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15477: doc: Remove misleading hint in getrawtransaction (master...Mf1902-rpcRawDocFix) https://github.com/bitcoin/bitcoin/pull/15477
< gribble> https://github.com/bitcoin/bitcoin/issues/15471 | rpc/gui: Remove Unknown block versions being mined warning by laanwj · Pull Request #15471 · bitcoin/bitcoin · GitHub
< provoostenator> sipa: see latest comment on PR: https://github.com/bitcoin/bitcoin/pull/15471#issuecomment-467137377
< provoostenator> on master nUpgraded tracks whether we send an alert https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2262
< bitcoin-git> [bitcoin] geekastute opened pull request #15475: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15475
< bitcoin-git> [bitcoin] geekastute closed pull request #15475: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15475
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15419: qa: Always refresh cache to be out of ibd (master...Mf1902-mocktime) https://github.com/bitcoin/bitcoin/pull/15419
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b4fc5257b7dc...8f470ecc534d
< bitcoin-git> bitcoin/master fab0d85 MarcoFalke: qa: Remove mocktime unless required
< bitcoin-git> bitcoin/master 1111aec MarcoFalke: qa: Always refresh stale cache to be out of ibd
< bitcoin-git> bitcoin/master fa25210 MarcoFalke: qa: Fix wallet_txn_doublespend issue
< bitcoin-git> [bitcoin] promag opened pull request #15474: rest/rpc: Make mempoolinfo atomic (master...2019-02-atomic-mempoolinfo) https://github.com/bitcoin/bitcoin/pull/15474
< aj> provoostenator: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-December/016556.html ? but NOINPUT tagging per the more recent threads seems more likely than OP_MASK at this point
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15473: bench: Benchmark MempoolToJSON (master...Mf1902-benchRpcMempool) https://github.com/bitcoin/bitcoin/pull/15473
< gribble> https://github.com/bitcoin/bitcoin/issues/13972 | Remove 16 bits from versionbits signalling system by btcdrak · Pull Request #13972 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15471 | rpc/gui: Remove Unknown block versions being mined warning by laanwj · Pull Request #15471 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] qingqingzijjin opened pull request #15472: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15472
< bitcoin-git> [bitcoin] fanquake closed pull request #15472: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15472
< provoostenator> Is there a SegWit v1 proposal on the bitcoin-dev list or elsewhere that I just managed to overlook? I though gmaxwell referred to that a few days ago in the context of SIGHASH_NO_INPUT_FULL_DISCLAIMER
< bitcoin-git> [bitcoin] laanwj merged pull request #15456: Enable PID file creation on WIN (master...master) https://github.com/bitcoin/bitcoin/pull/15456
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a8a5ede9fc3...b4fc5257b7dc
< bitcoin-git> bitcoin/master 3f5ad62 riordant: Enable PID file creation on Windows
< bitcoin-git> bitcoin/master b4fc525 Wladimir J. van der Laan: Merge #15456: Enable PID file creation on WIN
< bitcoin-git> [bitcoin] laanwj opened pull request #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (master...2019_02_false_positives) https://github.com/bitcoin/bitcoin/pull/15471
< bitcoin-git> [bitcoin] laanwj merged pull request #15401: rpc: Actually throw help when passed invalid number of params (master...Mf1902-rpcNumArgs) https://github.com/bitcoin/bitcoin/pull/15401
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f3f9c1de19e6...1a8a5ede9fc3
< bitcoin-git> bitcoin/master fa05626 MarcoFalke: rpc: Add RPCHelpMan::IsValidNumArgs()
< bitcoin-git> bitcoin/master fa4ce70 MarcoFalke: rpc: Actually throw help when passed invalid number of params
< bitcoin-git> bitcoin/master 1a8a5ed Wladimir J. van der Laan: Merge #15401: rpc: Actually throw help when passed invalid number of param...
< moneyball> also there is now more information about the conference on the web site https://breaking-bitcoin.com/
< moneyball> the dates are set - same as communicated a few months ago. it will precede the breaking bitcoin conference, june 5-7, with the conference being that weekend june 8-9, in amsterdam. so you should feel comfortable booking flights with those dates in mind.
< bitcoin-git> [bitcoin] fanquake closed pull request #15469: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15469

2019-02-24

< bitcoin-git> [bitcoin] hfsam opened pull request #15469: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15469
< flowctrl> I tried building from source, but the testsuite fails. Commented on existing (closed) issue @ https://github.com/bitcoin/bitcoin/issues/14349
< luke-jr> flowctrl: this is the development channel; try #bitcoin for support
< flowctrl> Hello! I downloaded a macos binary, bitcoin-0.17.1-osx.dmg, from bitcoin.org. In the image, there is a file that produces a 'permission denied' error message when I try to copy it to any location. The file is: /Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt

2019-02-23

< mischa010> in this thread it's claimed that compact blocks does indeed rank peers by their speed? https://www.reddit.com/r/Bitcoin/comments/5zo2ku/how_do_i_configure_my_node_to_use_highbandwidth/
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15468: wallet: Use fsbridge::ifstream to fix Windows path issue (master...win-wallet-fix) https://github.com/bitcoin/bitcoin/pull/15468
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< warren> https://github.com/bitcoin/bitcoin/pull/15277 Hoping people can help with what is hopefully a simple environment difference between Ubuntu and this other distro. dongcarl is really close to a deterministic replacement for gitian's toolchain. It may only be a matter of figuring out this linker issue then writing a wrapper around the entire thing.
< gmaxwell> MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/15451 I assume that we broke some altcoin that has other kinds of invs, and the PR author is trying to suggest a comment change that would have avoided his confusion.

2019-02-22

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/169dced9a42b...f3f9c1de19e6
< bitcoin-git> bitcoin/master 39e20fc Daniel Kraft: Add missing #include.
< bitcoin-git> bitcoin/master f3f9c1d MarcoFalke: Merge #15435: rpc: Add missing #include