< bitcoin-git>
bitcoin/master 5efcb77 Matt Corallo: Disable bloom filtering by default.
< bitcoin-git>
bitcoin/master f27309f Matt Corallo: Move DEFAULT_PEERBLOOMFILTERS from validation.h to net_processing.h
< bitcoin-git>
bitcoin/master bead32e Matt Corallo: Add release notes for DEFAULT_BLOOM change
< kallewoof>
Just me or is travis not creating new jobs when pushing to a PR branch..? (it creates local instances for my own repo but not for bitcoin).
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16421: Conservatively accept RBF bumps bumping one tx at the package limits (master...2019-07-lightning-policy-bump) https://github.com/bitcoin/bitcoin/pull/16421
< gribble>
https://github.com/bitcoin/bitcoin/issues/16412 | net: Make poll in InterruptibleRecv only filter for POLLIN events. by tecnovert · Pull Request #16412 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] promag opened pull request #16414: 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (0.18...2019-07-backport-16322) https://github.com/bitcoin/bitcoin/pull/16414
< gribble>
https://github.com/bitcoin/bitcoin/issues/16412 | net: Make poll in InterruptibleRecv only filter for POLLIN events. by tecnovert · Pull Request #16412 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master a981e74 João Barbosa: fix: tor: Call event_base_loopbreak from the event's callback
< bitcoin-git>
bitcoin/master 65d1211 Wladimir J. van der Laan: Merge #16405: fix: tor: Call event_base_loopbreak from the event's callbac...
< bitcoin-git>
[bitcoin] tecnovert opened pull request #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (master...bitcoin-poll) https://github.com/bitcoin/bitcoin/pull/16412
< bitcoin-git>
bitcoin/master fa9b419 MarcoFalke: test: Add test that mainnet requires standard txs
< bitcoin-git>
bitcoin/master fa89bad MarcoFalke: test: Require standard txs in regtest
< bitcoin-git>
[bitcoin] hebasto closed pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< bitcoin-git>
bitcoin/master 613c46f James O'Beirne: refactoring: move block metadata structures into BlockManager
< bitcoin-git>
bitcoin/master 4ed55df James O'Beirne: refactoring: add block_index_candidates arg to LoadBlockIndex
< bitcoin-git>
bitcoin/master 55d525a James O'Beirne: refactoring: make pindexBestInvalid internal to validation.cpp
< sipa>
stevenroose: what version of bitcoin core?
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
< pinheadmz>
I'm getting a leveldb checksum mismatch error `Fatal LevelDB error: Corruption: block checksum mismatch: /home/pi/.bitcoin/chainstate/2109327.ldb` but only when I shutdown with RPC stop... Since the error is in chainstate, can I try with -reindex ? Or do I need to redownload the chain...?
< bitcoin-git>
[bitcoin] fanquake merged pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< bitcoin-git>
bitcoin/master fa0d0ff MarcoFalke: Remove unused bits from the service flags enum
< bitcoin-git>
bitcoin/master 29082e8 fanquake: Merge #16380: Remove unused bits from the service flags enum
2019-07-15
< sipa>
and if your end goal is integrating things into bitcoin core, i suspect getting familiar with the code is probably the best way to spend time now
< elichai2>
don't you think that bitcoin core wallet should be like a reference for other wallets? because in that case other wallets got it faster :/
< sipa>
well if you want to learn bitcoin core better (which i very much encourage you to!), i think it's better to focus on one piece at a time, but actually integrate it
< elichai2>
because I still think that manual psbt without descriptors is still useful? altough you're right that I could've done it in rust-bitcoin and it would probabaly been easier and more native to the code but in the end I do want to get to know bitcoin core's code better so I will be able to make optimal solutions to bitcoin in the future :)
< sipa>
so why do it in bitcoin core at all then?
< elichai2>
and way more work. I'm trying to concentrate around PSBT for now. so i'm using `createpsbt` as a "hack" because that's the only psbt RPC command that doesn't relay on the wallet. (I'll probably move that logic to a seperate "createrawpsbt" or a `bitcoin-psbt` bin)
< bitcoin-git>
[bitcoin] achow101 opened pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git>
bitcoin/master 8f250ab Steven Roose: TEST: Replace hard-coded hex tx with classes
< bitcoin-git>
bitcoin/master 0822b44 MarcoFalke: Merge #15282: test: Replace hard-coded hex tx with class in test framework...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15282: test: Replace hard-coded hex tx with class in test framework (master...util-messages) https://github.com/bitcoin/bitcoin/pull/15282
< fanquake>
Does anyone know why Travis gets marked as failing, even though all tests are passing? i.e https://travis-ci.org/bitcoin/bitcoin/builds/558768209 is all green, but I see red in the GitHub UI (#16386) .It seems that running the extended lint stage will kick it over to green though..
< bitcoin-git>
[bitcoin] promag opened pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
< bitcoin-git>
[bitcoin] hebasto opened pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< bitcoin-git>
[bitcoin] jonatack opened pull request #16374: test: Enable passing wildcard test names to test runner from root (master...enable-passing-wildcard-files-to-test-runner-from-root) https://github.com/bitcoin/bitcoin/pull/16374
< sipa>
i'm suggesting this because i'd like a bitcoin-psbt tool that you just give psbts and utxos and descriptors and keys and figures out what it can do
< jnewbery>
provoostenator: from the base bitcoin directory: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do echo $f | xargs -n 1 basename; done)
< bitcoin-git>
[bitcoin] fanquake opened pull request #16371: trivial: build: ignore osx_volname & add it to clean-local (master...ignore_osx_volname) https://github.com/bitcoin/bitcoin/pull/16371
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
< sipa>
for bitcoin-psbt i'm more thinking something which you give a bunch of information and uses it where useful
< sipa>
bitcoin-tx is really "transformation based" thing which you give an input and then specify some transformations to apply
< elichai2>
so you think it should be separate from bitcoin-tx
< elichai2>
I want to add it to the PSBT standard so that other wallets can start working on support this even before it's in bitcoin core's wallet (assuming of course taproot will get activated)
< sipa>
and i think we need a bitcoin-psbt tool that can sign/update a psbt with keys and descriptors
< instagibbs>
might be #bitcoin chat, achow101 would know
< elichai2>
If I want to add manual psbt constructions support, does it makes sense to have it in `bitcoin-tx`? regular bitcoin core rpc or even a new `bitcoin-psbt`?
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
< bitcoin-git>
[bitcoin] laanwj merged pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git>
bitcoin/master d1fc827 Wladimir J. van der Laan: Merge #16270: depends: expat 2.2.7
< bitcoin-git>
[bitcoin] laanwj merged pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< bitcoin-git>
bitcoin/0.18 e2f7677 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git>
bitcoin/0.18 df695db João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git>
bitcoin/0.18 410774a Wladimir J. van der Laan: Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"...
< bitcoin-git>
[bitcoin] laanwj merged pull request #16237: Have the wallet give out destinations instead of keys (master...cwallet-getnewaddr) https://github.com/bitcoin/bitcoin/pull/16237