2017-08-26

< bitcoin-git> bitcoin/master bc70ab5 Dan Raviv: Fix header guards using reserved identifiers...
< bitcoin-git> bitcoin/master 7fd49d0 Wladimir J. van der Laan: Merge #11151: Fix header guards using reserved identifiers...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07c92b98e2a0...7fd49d01dc2e
< bitcoin-git> [bitcoin] danra opened pull request #11156: Fix memory leaks in qt/guiutil.cpp (master...fix/qt-guiutil-memory-leaks) https://github.com/bitcoin/bitcoin/pull/11156
< bitcoin-git> [bitcoin] danra opened pull request #11155: Trivial: Documentation fixes for CVectorWriter ctors (master...patch-8) https://github.com/bitcoin/bitcoin/pull/11155
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11153: Add meshcollider Gitian PGP key (master...201708_add_meshcollider_gpg) https://github.com/bitcoin/bitcoin/pull/11153
< bitcoin-git> [bitcoin] RHavar closed pull request #11152: Increase DEFAULT_ANCESTOR_LIMIT and DEFAULT_DESCENDANT_LIMIT to 100 (master...limits) https://github.com/bitcoin/bitcoin/pull/11152
< bitcoin-git> [bitcoin] RHavar opened pull request #11152: Increase DEFAULT_ANCESTOR_LIMIT and DEFAULT_DESCENDANT_LIMIT to 100 (master...limits) https://github.com/bitcoin/bitcoin/pull/11152
< bitcoin-git> [bitcoin] danra opened pull request #11151: Fix header guards using reserved identifiers (master...fix/header-guards) https://github.com/bitcoin/bitcoin/pull/11151

2017-08-25

< bitcoin-git> [bitcoin] mess110 opened pull request #11150: [tests] Add getmininginfo functional tests (master...test_rpc_getmininginfo) https://github.com/bitcoin/bitcoin/pull/11150
< bitcoin-git> [bitcoin] danra opened pull request #11149: Use prefix instead of postfix increment/decrement for non-trivial typ… (master...prefix-increment) https://github.com/bitcoin/bitcoin/pull/11149
< bitcoin-git> [bitcoin] danra opened pull request #11148: Trivial: Fix outdated comment (master...patch-7) https://github.com/bitcoin/bitcoin/pull/11148
< bitcoin-git> [bitcoin] eaxvac closed pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
< bitcoin-git> [bitcoin] eaxvac opened pull request #11147: Merge remote-tracking branch 'refs/remotes/bitcoin/master' (master...master) https://github.com/bitcoin/bitcoin/pull/11147
< bitcoin-git> [bitcoin] morcos opened pull request #11145: Fix rounding bug in calculation of minimum change (master...fixrounding) https://github.com/bitcoin/bitcoin/pull/11145
< bitcoin-git> [bitcoin] laanwj closed pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
< bitcoin-git> bitcoin/master f01103c Russell Yanofsky: MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp
< bitcoin-git> bitcoin/master e7fe320 Russell Yanofsky: MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp
< bitcoin-git> bitcoin/master d97fe20 Russell Yanofsky: Move some static functions out of wallet.h/cpp...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3f726c99f819...07c92b98e2a0
< bitcoin-git> [bitcoin] danra opened pull request #11144: Move local include to before system includes (master...patch-6) https://github.com/bitcoin/bitcoin/pull/11144
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
< bitcoin-git> [bitcoin] danra opened pull request #11143: Fix include path for bitcoin-config.h (master...patch-5) https://github.com/bitcoin/bitcoin/pull/11143
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
< bitcoin-git> [bitcoin] wrapperband opened pull request #11142: Enhance getinfo with regtest information (0.15...0.15-GetInfo-regtest) https://github.com/bitcoin/bitcoin/pull/11142
< bitcoin-git> [bitcoin] danra opened pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
< bitcoin-git> [bitcoin] danra opened pull request #11139: Trivial: Whitespace in bswap_64 implementation (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11139
< bitcoin-git> [bitcoin] danra opened pull request #11138: Compat: Simplify bswap_16 implementation (master...patch-2) https://github.com/bitcoin/bitcoin/pull/11138
< bitcoin-git> [bitcoin] danra opened pull request #11136: Docs: Add python3 to list of dependencies on macOS (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11136
< bitcoin-git> [bitcoin] promag opened pull request #11135: Add RPC response notes (master...2017-08-rpc-response-notes) https://github.com/bitcoin/bitcoin/pull/11135
< bitcoin-git> [bitcoin] practicalswift opened pull request #11133: Document assumptions that must be fulfilled to avoid division by zero (master...div0) https://github.com/bitcoin/bitcoin/pull/11133
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11129: [qa] util: Poll cookie file size before reading (master...Mf1708-qaPollCookie) https://github.com/bitcoin/bitcoin/pull/11129
< bitcoin-git> [bitcoin] practicalswift opened pull request #11132: [wallet] Document assumptions that must be fulfilled to avoid NULL pointer dereferences (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/11132
< bitcoin-git> [bitcoin] laanwj opened pull request #11131: rpc: Write authcookie atomically (master...2017_08_atomic_cookie) https://github.com/bitcoin/bitcoin/pull/11131
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11112: [developer-notes] By default, declare single-argument constructors "explicit" (master...declare-single-argument-constructors-explicit) https://github.com/bitcoin/bitcoin/pull/11112
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/77fc469fc78c...3f726c99f819
< bitcoin-git> bitcoin/master f1708ef practicalswift: Add recommendation: By default, declare single-argument constructors `explicit`
< bitcoin-git> bitcoin/master 3f726c9 MarcoFalke: Merge #11112: [developer-notes] By default, declare single-argument constructors "explicit"...

2017-08-24

< jimpo> I'm looking into writing a P2P test for this: https://github.com/bitcoin/bitcoin/pull/11113
< bitcoin-git> [bitcoin] jtimon closed pull request #9271: There's two types of flags: consensus and script (master...0.13-consensus-flags-error) https://github.com/bitcoin/bitcoin/pull/9271
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11108: Changing -txindex requires -reindex, not -reindex-chainstate (master...2017-08-fix-reindex-txindex-err) https://github.com/bitcoin/bitcoin/pull/11108
< bitcoin-git> bitcoin/master 77fc469 MarcoFalke: Merge #11108: Changing -txindex requires -reindex, not -reindex-chainstate...
< bitcoin-git> bitcoin/master cd0ea48 Matt Corallo: Changing -txindex requires -reindex, not -reindex-chainstate
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ae6d0fbef60...77fc469fc78c
< sipa> or bitcoin-wizards
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11129: [qa] util: Poll cookie file size before reading (master...Mf1708-qaPollCookie) https://github.com/bitcoin/bitcoin/pull/11129
< clarkmoody> gmaxwell sipa Can you guys look at https://github.com/bitcoin/bips/pull/553 ?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10798: [tests] [utils] test bitcoin-cli (master...cli_tests) https://github.com/bitcoin/bitcoin/pull/10798
< bitcoin-git> bitcoin/master c6ec435 John Newbery: [tests] Add bitcoin_cli.py test script
< bitcoin-git> bitcoin/master 4ae6d0f MarcoFalke: Merge #10798: [tests] [utils] test bitcoin-cli...
< bitcoin-git> bitcoin/master b23549f John Newbery: [tests] add TestNodeCLI class for calling bitcoin-cli for a node
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/affe9271aa49...4ae6d0fbef60
< cfields> luke-jr: if bitcoin is as fickle as a default setting, the value of that setting isn't the issue...
< gmaxwell> luke-jr: what is the security model of a bitcoin with no nodes? But with the assumevalid approach I don't know that it's really a meaningful change in the security model.
< luke-jr> morcos: yes, I think we shouldn't recommend things that harm Bitcoin.
< gmaxwell> luke-jr: I'm concerned that you seem to be fixated on size rather than on the greater goal of keeping bitcoin decenteralized, secure, usable. Size is increasingly not an interesting magic metric for that, moreover, single miners reducing their size does nothing to help here-- if it did there would be much less reason for a blocksize limit.
< kanzure> #bitcoin-core-dev
< bitcoin-git> [bitcoin] laanwj reopened pull request #11053: refactor: Make all #includes relative to project root (master...2017_08_includes_absolute) https://github.com/bitcoin/bitcoin/pull/11053
< bitcoin-git> [bitcoin] sipa closed pull request #11128: Make Bitcoin Core compatible with NYA segwit2x (master...s2x) https://github.com/bitcoin/bitcoin/pull/11128
< wumpus> if you think a defaults change kills bitcoin, you're severly underestimating it
< sipa> luke-jr: i'm only interested in a Bitcoin that survives under the assumption that miners act rationally
< sipa> luke-jr: then Bitcoin is evolving to actually be tested
< luke-jr> sipa: then Bitcoin is dead.
< achow101> the parameter interaction is defined here: https://github.com/bitcoin/bitcoin/blob/master/src/miner.cpp#L81 for reference
< bitcoin-git> [bitcoin] hovah opened pull request #11128: Make Bitcoin Core compatible with NYA segwit2x (master...s2x) https://github.com/bitcoin/bitcoin/pull/11128
< bitcoin-git> [bitcoin] romanornr closed pull request #11127: Make Bitcoin Core compatible with NYA segwit2x (master...s2x) https://github.com/bitcoin/bitcoin/pull/11127
< bitcoin-git> [bitcoin] romanornr opened pull request #11127: Make Bitcoin Core compatible with NYA segwit2x (master...s2x) https://github.com/bitcoin/bitcoin/pull/11127
< kanzure> whole bitcoin community did it
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
< bitcoin-git> [bitcoin] ryanofsky opened pull request #11126: Acquire cs_main lock before cs_wallet during wallet initialization (master...pr/loadlock2) https://github.com/bitcoin/bitcoin/pull/11126
< bitcoin-git> [bitcoin] promag opened pull request #11125: Add bitcoin-cli -stdinrpcpass functional test (master...2017-08-stdinrpcpass-functional-test) https://github.com/bitcoin/bitcoin/pull/11125
< MarcoFalke> wumpus: Mind to create a gitian.docs under bitcoin-core?
< instagibbs> adrh, try #bitcoin
< jnewbery> GAit: Github automatically creates a merge into master, which is what Travis takes for its build: https://github.com/bitcoin/bitcoin/commit/30dfb2ceda2e8aae954a25b6a3cef63d24cf6512
< GAit> I'm a bit confused by a failure, https://travis-ci.org/bitcoin/bitcoin/jobs/267945919 - two out of seven failed, seems a race but not sure what is causing it. Is stop_nodes() synchronous?
< bitcoin-git> [bitcoin] practicalswift reopened pull request #10961: Improve readability of DecodeBase58Check(...) (master...DecodeBase58Check-cleanup) https://github.com/bitcoin/bitcoin/pull/10961
< bitcoin-git> [bitcoin] practicalswift closed pull request #10961: Improve readability of DecodeBase58Check(...) (master...DecodeBase58Check-cleanup) https://github.com/bitcoin/bitcoin/pull/10961
< bitcoin-git> [bitcoin] laanwj closed pull request #10997: RPC: Add option -stdinrpcpass to bitcoin-cli to allow RPC password to be read from standard input (master...stdinrpcpass) https://github.com/bitcoin/bitcoin/pull/10997
< bitcoin-git> bitcoin/master affe927 Wladimir J. van der Laan: Merge #10997: RPC: Add option -stdinrpcpass to bitcoin-cli to allow RPC password to be read from standard input...
< bitcoin-git> bitcoin/master 79191f5 Joe Harvell: Add option -stdinrpcpass to allow RPC password to be read from standard input
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00ada17230f7...affe9271aa49
< wumpus> you did copy the right bitcoin-0.15.0-win64-setup-unsigned.exe file to inputs/? (e.g. not a stale one from rc1, for example?)
< wumpus> however your input file's sha256sum af3da01beda391e06f2fb4d2dced316b580f989b71ee886582aaddac5c00374f for bitcoin-0.15.0-win64-setup-unsigned.exe matches
< bitcoin-git> [bitcoin] laanwj closed pull request #11119: [doc] build-windows: Mention that only trusty works (master...Mf1708-docBuildWinTrusty) https://github.com/bitcoin/bitcoin/pull/11119
< bitcoin-git> bitcoin/master fa14b67 MarcoFalke: [doc] build-windows: Mention that only trusty works
< bitcoin-git> bitcoin/master 00ada17 Wladimir J. van der Laan: Merge #11119: [doc] build-windows: Mention that only trusty works...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8858b6ddd3bc...00ada17230f7
< wumpus> btw has anyone tried cross-compiling bitcoin core for windows from ubuntu zesty/17.04 or pre-.10

2017-08-23

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11068: qa: Move wait_until to util (master...Mf1708-qaWaitUntilMiniNode) https://github.com/bitcoin/bitcoin/pull/11068
< bitcoin-git> bitcoin/master 8858b6d MarcoFalke: Merge #11068: qa: Move wait_until to util...
< bitcoin-git> bitcoin/master 08ce33f MarcoFalke: qa: Move wait_until to util
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41496e20f369...8858b6ddd3bc
< bitcoin-git> [bitcoin] jnewbery opened pull request #11121: TestNode tidyups (master...test_node_tidyups) https://github.com/bitcoin/bitcoin/pull/11121
< bitcoin-git> [bitcoin] laanwj closed pull request #11077: [tests] fix timeout issues from TestNode (master...test_node_fixes) https://github.com/bitcoin/bitcoin/pull/11077
< bitcoin-git> bitcoin/master 41496e2 Wladimir J. van der Laan: Merge #11077: [tests] fix timeout issues from TestNode...
< bitcoin-git> bitcoin/master 2b4ea52 John Newbery: [tests] fix timeout issues from TestNode...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/31b2612bbf19...41496e20f369
< bitcoin-git> [bitcoin] instagibbs opened pull request #11120: verifytxoutproof returns object including blockhash (master...verifytxoutproof-blockhash) https://github.com/bitcoin/bitcoin/pull/11120
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11119: [doc] build-windows: Mention that only trusty works (master...Mf1708-docBuildWinTrusty) https://github.com/bitcoin/bitcoin/pull/11119
< bitcoin-git> [bitcoin] laanwj closed pull request #10679: Document the non-DER-conformance of one test in tx_valid.json. (master...tx-valid-comment) https://github.com/bitcoin/bitcoin/pull/10679
< bitcoin-git> bitcoin/master 31b2612 Wladimir J. van der Laan: Merge #10679: Document the non-DER-conformance of one test in tx_valid.json....
< bitcoin-git> bitcoin/master ecb11f5 Andreas Schildbach: Document the non-strict-DER-conformance of one test in tx_valid.json....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c9f5ecf3fd4...31b2612bbf19
< bitcoin-git> [bitcoin] laanwj closed pull request #10923: travis: Build with --enable-werror under OS X (master...thread-safety-analysis) https://github.com/bitcoin/bitcoin/pull/10923
< bitcoin-git> bitcoin/master 2c9f5ec Wladimir J. van der Laan: Merge #10923: travis: Build with --enable-werror under OS X...
< bitcoin-git> bitcoin/master a65e028 practicalswift: Build with --enable-werror under OS X
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3e55f13bfc98...2c9f5ecf3fd4
< bitcoin-git> [bitcoin] laanwj closed pull request #11109: Fix a typo in line 926 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11109
< bitcoin-git> [bitcoin] sipa opened pull request #11117: Prepare for non-Base58 addresses (master...201708_nocbitcoinaddress) https://github.com/bitcoin/bitcoin/pull/11117
< bitcoin-git> [bitcoin] jimpo opened pull request #11116: [script] Unit tests for script/standard and IsMine functions. (master...script-standard-tests) https://github.com/bitcoin/bitcoin/pull/11116

2017-08-22

< bitcoin-git> [bitcoin] instagibbs closed pull request #11049: coincontrol can filter for segwit inputs, expose fundraw option (master...segwitfundraw) https://github.com/bitcoin/bitcoin/pull/11049
< bitcoin-git> [bitcoin] jimpo opened pull request #11113: [net] Ignore getheaders requests for very old side blocks. (master...net-getheaders-fingerprint) https://github.com/bitcoin/bitcoin/pull/11113
< bitcoin-git> [bitcoin] practicalswift opened pull request #11112: developer-notes: By default, declare single-argument constructors `explicit`. (master...declare-single-argument-constructors-explicit) https://github.com/bitcoin/bitcoin/pull/11112
< bitcoin-git> [bitcoin] cruizh closed pull request #11111: Qt: correct Spanish translation of "receiving address" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11111
< bitcoin-git> [bitcoin] cruizh opened pull request #11111: Qt: correct Spanish translation of "receiving address" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11111
< bitcoin-git> [bitcoin] practicalswift opened pull request #11110: script: Avoid implicit casts from bool to CScriptNum (master...implicit-casts-from-bool-to-cscriptnum) https://github.com/bitcoin/bitcoin/pull/11110
< jimpo> I noticed this comment about possible fingerprinting if Core served side blocks more than a month old. https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L1006
< edin00n> Why do people use expensive GPUs for Bitcoin mining and not CPU
< BlueMatt> edin00n: ot, take it to #bitcoin
< bitcoin-git> [bitcoin] felco- opened pull request #11109: Fix a typo in line 926 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11109
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11108: Changing -txindex requires -reindex, not -reindex-chainstate (master...2017-08-fix-reindex-txindex-err) https://github.com/bitcoin/bitcoin/pull/11108
< BlueMatt> bitbee: ot, take it to #bitcoin (or elsewhere)
< bitcoin-git> [bitcoin] laanwj closed pull request #11024: tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt (master...OldDecrypt-cleanup) https://github.com/bitcoin/bitcoin/pull/11024
< bitcoin-git> bitcoin/master 3e55f13 Wladimir J. van der Laan: Merge #11024: tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt...
< bitcoin-git> bitcoin/master a897d0e practicalswift: tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc5c237d4a84...3e55f13bfc98
< sipa> rubensayshi: i plan to try to get the next bitcoin corelease (after 0.15) to implement support for it
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11107: Fix race for mapBlockIndex in AppInitMain (master...fix_mapBlockIndex_race) https://github.com/bitcoin/bitcoin/pull/11107
<@wumpus> bitcoin-cli logging "bench" maybe?
< bitcoin-git> [bitcoin] laanwj closed pull request #11007: wallet: Fix potential memory leak when loading a corrupted wallet file (master...wallet-corrupted-leak) https://github.com/bitcoin/bitcoin/pull/11007
< bitcoin-git> bitcoin/master fc5c237 Wladimir J. van der Laan: Merge #11007: wallet: Fix potential memory leak when loading a corrupted wallet file...
< bitcoin-git> bitcoin/master c06755f practicalswift: wallet: Fix memory leak when loading a corrupted wallet file
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ab7c6300f87...fc5c237d4a84
< bitcoin-git> [bitcoin] laanwj closed pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843
< bitcoin-git> bitcoin/master 2ab7c63 Wladimir J. van der Laan: Merge #10843: Add attribute [[noreturn]] (C++11) to functions that will not return...
< bitcoin-git> bitcoin/master b82c55a practicalswift: Add attribute [[noreturn]] (C++11) to functions that will not return...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4b65fa592123...2ab7c6300f87
< bitcoin-git> bitcoin/master 4b65fa5 Wladimir J. van der Laan: Merge #11058: Comments: More comments on functions/globals in standard.h....
< bitcoin-git> [bitcoin] laanwj closed pull request #11058: Comments: More comments on functions/globals in standard.h. (master...standard-comments) https://github.com/bitcoin/bitcoin/pull/11058
< bitcoin-git> bitcoin/master 360b464 Jim Posen: Comments: More comments on functions/globals in standard.h.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ed57d3d7ce8...4b65fa592123
< bitcoin-git> [bitcoin] laanwj closed pull request #11050: Avoid treating null RPC arguments different from missing arguments (master...pr/narg) https://github.com/bitcoin/bitcoin/pull/11050
< bitcoin-git> bitcoin/master fd5d71e Russell Yanofsky: Update developer notes after params.size() cleanup
< bitcoin-git> bitcoin/master e067673 Russell Yanofsky: Avoid treating null RPC arguments different from missing arguments...
< bitcoin-git> bitcoin/master e666efc Russell Yanofsky: Get rid of redundant RPC params.size() checks...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea3ac5990d9d...7ed57d3d7ce8
< bitcoin-git> [bitcoin] laanwj closed pull request #11026: Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default (master...bugfix_acceptnonstd_def) https://github.com/bitcoin/bitcoin/pull/11026
< bitcoin-git> bitcoin/master ea3ac59 Wladimir J. van der Laan: Merge #11026: Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default...
< bitcoin-git> bitcoin/master 4aa2508 Luke Dashjr: Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/271e40a98984...ea3ac5990d9d
< bitcoin-git> [bitcoin] laanwj closed pull request #11094: Docs: Hash in ZMQ hash is raw bytes, not hex (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11094
< bitcoin-git> bitcoin/master 271e40a Wladimir J. van der Laan: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex...
< bitcoin-git> bitcoin/master 06a3aec Karel Bílek: Docs: Hash in ZMQ hash is raw bytes, not hex...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c559884cac90...271e40a98984

2017-08-21

< bitcoin-git> [bitcoin] laanwj closed pull request #10809: optim: mark a few classes final (master...final-classes) https://github.com/bitcoin/bitcoin/pull/10809
< bitcoin-git> bitcoin/master c559884 Wladimir J. van der Laan: Merge #10809: optim: mark a few classes final...
< bitcoin-git> bitcoin/master 9a1675e Cory Fields: optim: mark a few classes final
< bitcoin-git> bitcoin/master 40a0f9f practicalswift: Enable devirtualization opportunities by using the final specifier (C++11)...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee6c434ce8d...c559884cac90
< Lauda> InTheVibe go to #bitcoin
< bitcoin-git> [bitcoin] laanwj closed pull request #11103: xie is coming (master...xie) https://github.com/bitcoin/bitcoin/pull/11103
< bitcoin-git> [bitcoin] laanwj closed pull request #11102: Trivial: Fix typo in release-notes.md (0.15...20170821-Trivial-Fix-typo-in-release-notes) https://github.com/bitcoin/bitcoin/pull/11102
< bitcoin-git> [bitcoin] egnlife opened pull request #11103: xie is coming (master...xie) https://github.com/bitcoin/bitcoin/pull/11103
< bitcoin-git> bitcoin/0.15 28b978b Wladimir J. van der Laan: qt: Update translations pre-rc2...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/28b978b19e87a7ed802c65f2d6561e61ef7ce911
< bitcoin-git> [bitcoin] jbarcelo opened pull request #11102: Trivial: Fix typo in release-notes.md (0.15...20170821-Trivial-Fix-typo-in-release-notes) https://github.com/bitcoin/bitcoin/pull/11102
< bitcoin-git> bitcoin/0.15 9fe1f6b Jonas Schnelli: Add length check for CExtKey deserialization...
< bitcoin-git> bitcoin/0.15 6c2b008 Jonas Nick: Fix combinerawtransaction RPC help result section...
< bitcoin-git> bitcoin/0.15 cbdd338 Gregory Sanders: disable jni in builds...
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/8f0121c957a0...129b03ff62dd
< bitcoin-git> [bitcoin] laanwj closed pull request #11095: Consensus: add const to temp int in base58.cpp (master...base58NuancedConst) https://github.com/bitcoin/bitcoin/pull/11095
< bitcoin-git> [bitcoin] laanwj closed pull request #11069: Trivial: Lossless image optimization. (master...master) https://github.com/bitcoin/bitcoin/pull/11069
< bitcoin-git> [bitcoin] kallewoof closed pull request #11084: [WIP] [mempool] Mempool snapshots to avoid lots of locking (master...mempool-snapshot) https://github.com/bitcoin/bitcoin/pull/11084
< bitcoin-git> [bitcoin] laanwj closed pull request #11097: gitian: quick hack to fix version string in releases (master...gitian-version-fix) https://github.com/bitcoin/bitcoin/pull/11097
< bitcoin-git> bitcoin/master 7ee6c43 Wladimir J. van der Laan: Merge #11097: gitian: quick hack to fix version string in releases...
< bitcoin-git> bitcoin/master 4452829 Cory Fields: gitian: quick hack to fix version string in releases...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/820ddd48a752...7ee6c434ce8d
< bitcoin-git> [bitcoin] lemzwerg opened pull request #11101: bitcoin_qt.m4: Minor fixes, improve code orthogonality (master...master) https://github.com/bitcoin/bitcoin/pull/11101
< bitcoin-git> [bitcoin] laanwj closed pull request #11027: [RPC] Only return hex field once in getrawtransaction (master...fix-getrawtx) https://github.com/bitcoin/bitcoin/pull/11027
< bitcoin-git> bitcoin/master 820ddd4 Wladimir J. van der Laan: Merge #11027: [RPC] Only return hex field once in getrawtransaction...
< bitcoin-git> bitcoin/master 6bbdafc Andrew Chow: Pass serialization flags and whether to include hex to TxToUniv
< bitcoin-git> bitcoin/master e029c6e Andrew Chow: Only return hex field once in getrawtransaction...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8532299d8b9...820ddd48a752
< bitcoin-git> [bitcoin] laanwj closed pull request #11090: Update contributor names in release-notes.md (0.15...patch-1) https://github.com/bitcoin/bitcoin/pull/11090

2017-08-20

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11100: Use a sensible default for blockmax{size,weight} (master...2017-08-sane-default-limits) https://github.com/bitcoin/bitcoin/pull/11100
< bitcoinreminder> no sorry, I was talking about bitcoin-core
< bitcoinreminder> sorry, I meant bitcoin-core.org
< gmaxwell> bitcoinreminder: email domain@bitcoin.org
< luke-jr> bitcoinreminder: bitcoin.org isn't even Bitcoin Core..
< bitcoinreminder> does anyone has a bitcoin-org email address? I created a impersonation-request on twitter for the fake https://twitter.com/BcoreProject account, but they told me that someone with a bitcoin-org email address has to create the request
< promag> luke-jr: move comment https://github.com/bitcoin/bitcoin/pull/11026#issuecomment-322063440 to PR description?
< bitcoin-git> [bitcoin] greenaddress opened pull request #11099: [RPC][mempool]: add rpc command to dump the mempool to disk (master...dump_mempool_rpc) https://github.com/bitcoin/bitcoin/pull/11099
< bitcoin-git> [bitcoin] laanwj closed pull request #11091: test: Increase initial RPC timeout to 60 seconds (master...2017_08_test_wait_for_rpc) https://github.com/bitcoin/bitcoin/pull/11091
< bitcoin-git> bitcoin/master a853229 Wladimir J. van der Laan: Merge #11091: test: Increase initial RPC timeout to 60 seconds...
< bitcoin-git> bitcoin/master c1470a0 Wladimir J. van der Laan: test: Increase initial RPC timeout to 60 seconds...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/262167393d05...a8532299d8b9
< bitcoin-git> [bitcoin] CryptAxe opened pull request #11098: [Qt] Add spend all button to the SendCoinsDialog (master...spendall) https://github.com/bitcoin/bitcoin/pull/11098

2017-08-19

< bitcoin-git> [bitcoin] theuni opened pull request #11097: gitian: quick hack to fix version string in releases (master...gitian-version-fix) https://github.com/bitcoin/bitcoin/pull/11097
< bitcoin-git> [bitcoin] mdaiter opened pull request #11095: Consensus: add const to temp int in base58.cpp (master...base58NuancedConst) https://github.com/bitcoin/bitcoin/pull/11095
< bitcoin-git> [bitcoin] runn1ng opened pull request #11094: Correct docs about transaction hash (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11094
< mryandao> hey guys, when executing a estimatefee RPC command on a node that is not fully sync-ed, shouldn't bitcoin-cli make a note that said node is not fully sync-ed and user should be cautioned to not use the estimated fee?

2017-08-18

< bitcoin-git> [bitcoin] fanquake closed pull request #11092: Litecoin ver 0.10.4 for macOS (master...master) https://github.com/bitcoin/bitcoin/pull/11092
< bitcoin-git> [bitcoin] MojaPochi opened pull request #11092: Litecoin ver 0.10.4 for macOS (master...master) https://github.com/bitcoin/bitcoin/pull/11092
< luke-jr> Bitcoin Core RPC client version v0.15.0
< bitcoin-git> [bitcoin] laanwj opened pull request #11091: test: Increase initial RPC timeout to 60 seconds (master...2017_08_test_wait_for_rpc) https://github.com/bitcoin/bitcoin/pull/11091
< bitcoin-git> [bitcoin] Derek701 opened pull request #11090: Update release-notes.md (0.15...patch-1) https://github.com/bitcoin/bitcoin/pull/11090
< bitcoin-git> [bitcoin] instagibbs closed pull request #9017: Enable various p2sh-p2wpkh functionality (master...p2shp2wpkhstuff) https://github.com/bitcoin/bitcoin/pull/9017
< bitcoin-git> [bitcoin] laanwj closed pull request #10952: [wallet] Remove vchDefaultKey and have better first run detection (master...remove-defaultkey) https://github.com/bitcoin/bitcoin/pull/10952
< bitcoin-git> bitcoin/master 2621673 Wladimir J. van der Laan: Merge #10952: [wallet] Remove vchDefaultKey and have better first run detection...
< bitcoin-git> bitcoin/master e53615b Andrew Chow: Remove vchDefaultKey and have better first run detection...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e5b7486cb7f...262167393d05
< bitcoin-git> [bitcoin] instagibbs reopened pull request #9017: Enable various p2sh-p2wpkh functionality (master...p2shp2wpkhstuff) https://github.com/bitcoin/bitcoin/pull/9017
< bitcoin-git> [bitcoin] luke-jr opened pull request #11089: Enable various p2sh-p2wpkh functionality (master...p2shp2wpkhstuff) https://github.com/bitcoin/bitcoin/pull/11089
< bitcoin-git> [bitcoin] laanwj closed pull request #11044: [wallet] Keypool topup cleanups (master...keypool_topup_cleanups) https://github.com/bitcoin/bitcoin/pull/11044
< bitcoin-git> bitcoin/master 0e5b748 Wladimir J. van der Laan: Merge #11044: [wallet] Keypool topup cleanups...
< bitcoin-git> bitcoin/master 67ceff4 John Newbery: [wallet] Add logging to MarkReserveKeysAsUsed
< bitcoin-git> bitcoin/master 1221f60 John Newbery: [wallet] Remove keypool_topup_cleanups...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc51565cbd4c...0e5b7486cb7f
< promag> This is similar https://github.com/bitcoin/bitcoin/pull/11041/files but does what luke-jr mentioned
< bitcoin-git> [bitcoin] laanwj closed pull request #11039: Avoid second mapWallet lookup (master...2017-08-avoid-second-mapwallet-lookup) https://github.com/bitcoin/bitcoin/pull/11039
< bitcoin-git> bitcoin/master fc51565 Wladimir J. van der Laan: Merge #11039: Avoid second mapWallet lookup...
< bitcoin-git> bitcoin/master 8f2f1e0 João Barbosa: wallet: Avoid second mapWallet lookup
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e00a625b43c...fc51565cbd4c
< bitcoin-git> [bitcoin] laanwj closed pull request #11066: Document the preference of nullptr over NULL or (void*)0 (master...document-nullptr-preference) https://github.com/bitcoin/bitcoin/pull/11066
< bitcoin-git> bitcoin/master 9e00a62 Wladimir J. van der Laan: Merge #11066: Document the preference of nullptr over NULL or (void*)0...
< bitcoin-git> bitcoin/master bea8e9e practicalswift: Document the preference of nullptr over NULL or (void*)0
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aeec8b4b6882...9e00a625b43c
< bitcoin-git> [bitcoin] BitonicEelis opened pull request #11087: Diagnose unsuitable outputs in lockunspent(). (master...lockunspent) https://github.com/bitcoin/bitcoin/pull/11087
< bitcoin-git> [bitcoin] laanwj closed pull request #11080: doc: Update build-openbsd for 6.1 (master...2017_08_openbsd_bump) https://github.com/bitcoin/bitcoin/pull/11080
< bitcoin-git> bitcoin/master aeec8b4 Wladimir J. van der Laan: Merge #11080: doc: Update build-openbsd for 6.1...
< bitcoin-git> bitcoin/master 5be6e9b Wladimir J. van der Laan: doc: Update build-openbsd for 6.1...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f60b3707d1e...aeec8b4b6882
< bitcoin-git> [bitcoin] laanwj closed pull request #11081: Add length check for CExtKey deserialization (jonasschnelli, guidovranken) (master...2017/08/fix_cextkey) https://github.com/bitcoin/bitcoin/pull/11081
< bitcoin-git> bitcoin/master 07685d1 Jonas Schnelli: Add length check for CExtKey deserialization
< bitcoin-git> bitcoin/master 9f60b37 Wladimir J. van der Laan: Merge #11081: Add length check for CExtKey deserialization (jonasschnelli, guidovranken)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c58128f18992...9f60b3707d1e
< bitcoin-git> [bitcoin] dooglus opened pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085
< bitcoin-git> bitcoin/0.15 1c4b9b3 Wladimir J. van der Laan: Merge #11076: 0.15 release-notes nits: fix redundancy, remove accidental parenthesis & fix range style...
< bitcoin-git> bitcoin/0.15 30c246b practicalswift: Updating the release notes (minor stylistic changes)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/252ca9c5d8d7...1c4b9b31355f
< bitcoin-git> [bitcoin] laanwj closed pull request #10878: Docs: Fix Markdown formatting issues in init.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10878
< bitcoin-git> bitcoin/master c58128f Wladimir J. van der Laan: Merge #10878: Docs: Fix Markdown formatting issues in init.md...
< bitcoin-git> bitcoin/master d201e40 Carl Dong: Update init.md: Fix section numbering.
< bitcoin-git> bitcoin/master 72a184a Carl Dong: Update init.md: Fix line breaks in section 3b.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3558834db4d...c58128f18992
< bitcoin-git> bitcoin/master f355883 Wladimir J. van der Laan: Merge #11083: Fix combinerawtransaction RPC help result section...
< bitcoin-git> [bitcoin] laanwj closed pull request #11083: Fix combinerawtransaction RPC help result section (master...fix-combinerawtransaction-help) https://github.com/bitcoin/bitcoin/pull/11083
< bitcoin-git> bitcoin/master f9ca0fe Jonas Nick: Fix combinerawtransaction RPC help result section
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dbf6bd6ea05f...f3558834db4d
< bitcoin-git> [bitcoin] laanwj closed pull request #11071: Use static_assert(…, …) (C++11) instead of assert(…) where appropriate (master...static_assert) https://github.com/bitcoin/bitcoin/pull/11071
< bitcoin-git> bitcoin/master dbf6bd6 Wladimir J. van der Laan: Merge #11071: Use static_assert(…, …) (C++11) instead of assert(…) where appropriate...
< bitcoin-git> bitcoin/master d1e6f91 practicalswift: Prefer compile-time checking over run-time checking
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4afb5aa9e173...dbf6bd6ea05f
< bitcoin-git> [bitcoin] kallewoof opened pull request #11084: [mempool] Mempool snapshots to avoid lots of locking (master...mempool-snapshot) https://github.com/bitcoin/bitcoin/pull/11084
< bitcoin-git> [bitcoin] laanwj closed pull request #10969: Declare single-argument (non-converting) constructors "explicit" (master...explicit) https://github.com/bitcoin/bitcoin/pull/10969
< bitcoin-git> bitcoin/master 4afb5aa Wladimir J. van der Laan: Merge #10969: Declare single-argument (non-converting) constructors "explicit"...
< bitcoin-git> bitcoin/master 64fb0ac practicalswift: Declare single-argument (non-converting) constructors "explicit"...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/22e301a3d56d...4afb5aa9e173

2017-08-17

< cfields> kallewoof: you can use my lock dumper to profile: https://github.com/theuni/bitcoin/commit/be49a294a240ec81a901af1aaabbba2172d38dc1
< praxeology> Does bitcoin's networking code operate on polling or interrupt?
< bitcoin-git> [bitcoin] jonasnick opened pull request #11083: Fix combinerawtransaction RPC help result section (master...fix-combinerawtransaction-help) https://github.com/bitcoin/bitcoin/pull/11083
< praxeology> kallewoof: does your bitcoin process have enough memory to hold the entire chainstate?
< kallewoof> gmaxwell: there is some amount of overhead as I am doing the profiling on my own. Maybe that's the cause for the high portion of time spent there, but it still seems like a lot of LOCK calls, regardless of actual CPU cycle count. Would be cool if the mempool could be copied once and then not lock cs at all. Code is here btw: https://github.com/kallewoof/bitcoin/tree/profile-resources
< praxeology> Like... I know that BitPay and Coinbase are declaring that they will support Segwit2x... has any exchange declared that they will continue to support Bitcoin (Bitcoin Core's rules)?
< praxeology> Re: https://docs.google.com/document/d/1y6Hsqdg1xBrJY4dFeKP6y05XCceJoVMs0_M_VwKFReM/edit Maybe it would be a good idea to communicate with the exchanges and check and see who will continue to support Bitcoin Core's chain
< jimpo> This grant doesn't appear to be checked in ThreadOpenConnections. https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1712. Only the one in ProcessOneShot is. Why is that?
< kallewoof> I'm running a modified Bitcoin Core node to do some profiling on where resources are spent (CPU cycles and bandwidth in particular) and am seeing some really weird stuff. E.g:
< luke-jr> in other news, Texas Bitcoin conference is promoting 2X as if it's Bitcoin, so I think that makes the decision to go simple (ie, not to)
< gmaxwell> if they said "[compatible fully validating nodes] btc1 \n [compatible wallet software] bitcoin classic\n" it would n... oh okay, well I suppose because it's not a lie in every possible sense it's okay. :P
< Cryptocide> Abra|BitClub Network|Bitcoin.com|BitFury|BitGo|Bitmain|BitPay Blockchain|Bloq|BTCC|Circle|Ledger|RSK Labs|Xapo, no thanks
< gmaxwell> Wow, this is super dishonest https://segwit2x.github.io/segwit2x-announce.html ... "Bitcoin Upgrade" is untrue... it claims Bitcoin "Classic" and unlimited are compatible "Compatible Fully-Validating Node Software" but they don't implement the S2X rules and don't even implement segwit!

2017-08-16

< sipa> i find it amazing that all of bitcoin core's history, is less than 100 MB
< gmaxwell> And in particular, the people that the users of bitcoin are generally reseting a fair amount of trust to create and maintain the software the network is using, for the most part (or completely though we can't be sure) don't agree with the narative they're being sold.
< bitcoin-git> [bitcoin] runn1ng closed pull request #10370: [pull request idea] addressindex, spentindex, timestampindex (Bitcore patches) (master...rebase_bitcoin_master) https://github.com/bitcoin/bitcoin/pull/10370
< BlueMatt> I mean can you seriously claim that almost the entirety of your rather short blog posts is disagreed with by almost any contributor to bitcoin core
< gmaxwell> (also, "here is a really interesting view you should read and consider" is not morally equivilent to /pretending to be us/ or faking that s2x is just an uncontroversial and low risk bitcoin upgrade...)
< bitcoin-git> [bitcoin] luke-jr opened pull request #11082: Add new bitcoin_rw.conf file that is used for settings modified by this software itself (master...rwconf) https://github.com/bitcoin/bitcoin/pull/11082
< instagibbs> i think there's the two issues: 1) claiming to be core 2) claiming to offer bitcoin upgrades
< BlueMatt> morcos: see greg's comments - people are claiming to "be" bitcoin core saying otherwise
< praxeology> Maybe... the people who would be duped into downloading/installing btc1... haven't even/don't/won't install Bitcoin Core in the first place. So that set of people is probably pretty small, like maybe 0 people?
< jimpo> cfields: Is there a reason that the "send rejects" part of SendRejectsAndCheckBanned should be called at the end of ProcessMessages as introduced in https://github.com/bitcoin/bitcoin/pull/9720?
< jimpo> If I rebroadcast an already-confirmed transaction, will Bitcoin Core nodes add it as an orphan tx?
< sturles> btc1 calls their node software Bitcoin Core as well.
< luke-jr> (or worse, does so by implying Bitcoin Core is Bitcoin!)
< luke-jr> jnewbery: it seems to fail to address the main misinformation (that they are misrepresenting an altcoin as an upgrade to Bitcoin)
<@wumpus> another openbsd issue I can't reproduce https://github.com/bitcoin/bitcoin/issues/11063, seems to work fine here
< praxeology> I disagree with luke's suggested rename to "2X". Ideally we could get the whole bitcoin/altcoin community to change the name, but its too late now, should just stick w/ what everyone is familiar with
< jnewbery> to be clear, I'm not disputing the quality of morcos's posts, and I personally agree with them, but I find the idea of 'Bitcoin Core thinks <x>' objectionable