2017-06-07

< sipa> luke-jr: i don't "want" BIP148. I want segwit, as I think it's necessary for Bitcoin's future. BIP148 is a overly risky means of obtaining that. That does not mean I oppose it if there were tremendous support, but on itself I think it's a bad idea
< jtimon> if you are included in https://en.bitcoin.it/wiki/Segwit_support please check that your position is not misrepresented (mine was by mistake)
< bitcoin-git> [bitcoin] pavlosantoniou reopened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< bitcoin-git> [bitcoin] pavlosantoniou closed pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] drizzt opened pull request #10549: Avoid printing generic and duplicated "checking for QT" during ./configure (master...check_qt) https://github.com/bitcoin/bitcoin/pull/10549
< jnewbery> no need to revert. I was just voicing surprise that it got merged without response to review comments or test cases for the new functionality in bitcoin-tx
< wumpus> any opinion on reverting https://github.com/bitcoin/bitcoin/pull/9672 ? seems to have been a bit of a mistake
< bitcoin-git> [bitcoin] laanwj closed pull request #9672: Opt-into-RBF for RPC & bitcoin-tx (master...rpc_rbf) https://github.com/bitcoin/bitcoin/pull/9672
< bitcoin-git> bitcoin/master 36bcab2 Luke Dashjr: RPC/Wallet: Add RBF support for fundrawtransaction
< bitcoin-git> bitcoin/master 891c5ee Luke Dashjr: Wallet: Refactor FundTransaction to accept parameters via CCoinControl
< bitcoin-git> bitcoin/master 578ec80 Luke Dashjr: RPC: rawtransaction: Add RBF support for createrawtransaction
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/be3e042c20e2...46311e792f4e
< bitcoin-git> [bitcoin] jnewbery closed pull request #10540: [WIP] Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git> [bitcoin] practicalswift opened pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
< bitcoin-git> [bitcoin] practicalswift opened pull request #10547: Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
< bitcoin-git> bitcoin/0.14 7a64351 Wladimir J. van der Laan: doc: Fill in details about miniupnp CVE-2017-8798
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/7a643511b474d53f952d3cd403af51aabd104044
< bitcoin-git> [bitcoin] practicalswift opened pull request #10546: Remove unused Boost includes (master...remove-unused-boost-includes) https://github.com/bitcoin/bitcoin/pull/10546
< bitcoin-git> [bitcoin] sipa closed pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git> bitcoin/master be3e042 Pieter Wuille: Merge #10523: Perform member initialization in initialization lists where possible...
< bitcoin-git> bitcoin/master 656dbd8 practicalswift: Perform member initialization in initialization lists where possible
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75e898c094ee...be3e042c20e2

2017-06-06

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10331: Share config between util and functional tests (master...shared_util_function_test_config) https://github.com/bitcoin/bitcoin/pull/10331
< bitcoin-git> bitcoin/master 89fcd35 John Newbery: Use an .ini config file for environment vars in bitcoin-util-test.py
< bitcoin-git> bitcoin/master e9265df John Newbery: Change help_text in bitcoin-util-test.py to a docstring.
< bitcoin-git> bitcoin/master ce58e93 John Newbery: Change bitcoin-util-test.py to use Python3
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/2805d606bc46...75e898c094ee
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10522: [wallet] Remove unused variables (master...unused-strings) https://github.com/bitcoin/bitcoin/pull/10522
< bitcoin-git> bitcoin/master 2805d60 MarcoFalke: Merge #10522: [wallet] Remove unused variables...
< bitcoin-git> bitcoin/master a8c09af practicalswift: Remove unused variables
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/32751807c9c0...2805d606bc46
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances") (master...occurrences) https://github.com/bitcoin/bitcoin/pull/10538
< bitcoin-git> bitcoin/master 3275180 MarcoFalke: Merge #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances")...
< bitcoin-git> bitcoin/master b083db6 practicalswift: [trivial] Fix typo: "occurrences" (misspelled as "occurrances")...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b708f2cf3e6...32751807c9c0
< bitcoin-git> [bitcoin] practicalswift opened pull request #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of (master...list_of) https://github.com/bitcoin/bitcoin/pull/10545
< bitcoin-git> [bitcoin] sipa opened pull request #10544: Update to LevelDB 1.20 (master...leveldb120) https://github.com/bitcoin/bitcoin/pull/10544
< bitcoin-git> [bitcoin] morcos opened pull request #10543: Change API to estimaterawfee (master...estimaterawapi) https://github.com/bitcoin/bitcoin/pull/10543
< bitcoin-git> [bitcoin] ABISprotocol opened pull request #10541: Docs: Update INSTALL.md to add link to dev notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10541
< bitcoin-git> [bitcoin] laanwj closed pull request #10201: pass Consensus::Params& to functions in validation.cpp and make them static (master...consensusparams-receivedblocktransactions) https://github.com/bitcoin/bitcoin/pull/10201
< bitcoin-git> bitcoin/master 1b708f2 Wladimir J. van der Laan: Merge #10201: pass Consensus::Params& to functions in validation.cpp and make them static...
< bitcoin-git> bitcoin/master 24980a3 Mario Dian: Make functions in validation.cpp static and pass chainparams...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/300f8e7a828f...1b708f2cf3e6
< bitcoin-git> [bitcoin] jnewbery opened pull request #10540: Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
< bitcoin-git> [bitcoin] laanwj closed pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git> [bitcoin] laanwj opened pull request #10539: doc: Mention update manpages in release process (master...2017_06_release_process_manpage_update) https://github.com/bitcoin/bitcoin/pull/10539
< bitcoin-git> bitcoin/0.14 5e408d9 Wladimir J. van der Laan: doc: Update manpages for 0.14.2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/5e408d99a219f80e3dab06d3ba03f102d404b886
< bitcoin-git> [bitcoin] laanwj closed pull request #9909: tests: Add FindEarliestAtLeast test for edge cases (master...pr/faltest) https://github.com/bitcoin/bitcoin/pull/9909
< bitcoin-git> bitcoin/master cf66f04 Russell Yanofsky: Add FindEarliestAtLeast test for edge cases...
< bitcoin-git> bitcoin/master 300f8e7 Wladimir J. van der Laan: Merge #9909: tests: Add FindEarliestAtLeast test for edge cases...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/980deaf0b1cc...300f8e7a828f
< bitcoin-git> [bitcoin] laanwj closed pull request #10252: RPC/Mining: Restore API compatibility for prioritisetransaction (master...rpc_prioritise_api) https://github.com/bitcoin/bitcoin/pull/10252
< bitcoin-git> bitcoin/master 980deaf Wladimir J. van der Laan: Merge #10252: RPC/Mining: Restore API compatibility for prioritisetransaction...
< bitcoin-git> bitcoin/master 870824e Luke Dashjr: RPC/Mining: Restore API compatibility for prioritisetransaction...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/30853e16d332...980deaf0b1cc
< bitcoin-git> bitcoin/0.14 cc23438 Wladimir J. van der Laan: qt: 0.14.2 pre-rc2 translations update
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/cc23438af017da8d477e2dbe58a5ba374a691a03
< bitcoin-git> [bitcoin] practicalswift opened pull request #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances") (master...occurrences) https://github.com/bitcoin/bitcoin/pull/10538
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535
< bitcoin-git> bitcoin/master 30853e1 MarcoFalke: Merge #10535: [qa] fundrawtx: Fix shutdown race...
< bitcoin-git> bitcoin/master fa62dad MarcoFalke: [qa] fundrawtx: Fix shutdown race
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67700b39241d...30853e16d332
< bitcoin-git> bitcoin/master 67700b3 Wladimir J. van der Laan: Merge #10345: [P2P] Timeout for headers sync...
< bitcoin-git> [bitcoin] laanwj closed pull request #10345: [P2P] Timeout for headers sync (master...2017-05-timeout-headers-sync) https://github.com/bitcoin/bitcoin/pull/10345
< bitcoin-git> bitcoin/master 76f7481 Suhas Daftuar: Add timeout for headers sync...
< bitcoin-git> bitcoin/master e265200 Suhas Daftuar: Delay parallel block download until chain has sufficient work...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/16f6c98fa8ee...67700b39241d
< bitcoin-git> [bitcoin] laanwj closed pull request #10426: Replace bytes_serialized with bogosize (master...bogosize) https://github.com/bitcoin/bitcoin/pull/10426
< bitcoin-git> bitcoin/master 16f6c98 Wladimir J. van der Laan: Merge #10426: Replace bytes_serialized with bogosize...
< bitcoin-git> bitcoin/master 8b22af3 Pieter Wuille: Replace bytes_serialized with bogosize
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/323a46e03414...16f6c98fa8ee
< bitcoin-git> [bitcoin] laanwj closed pull request #10463: Names: BIP9 vs versionbits (master...b15-bip8-cherry-reanme) https://github.com/bitcoin/bitcoin/pull/10463
< bitcoin-git> bitcoin/master 323a46e Wladimir J. van der Laan: Merge #10463: Names: BIP9 vs versionbits...
< bitcoin-git> bitcoin/master b463bc9 Jorge Timón: scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/...
< bitcoin-git> bitcoin/master 29c0719 shaolinfry: Rename -bip9params to -vbparams
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9fec4da0bec9...323a46e03414
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537

2017-06-05

< bitcoin-git> [bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< gribble> https://github.com/bitcoin/bitcoin/issues/9384 | CCoinsViewCache code cleanup & deduplication by ryanofsky · Pull Request #9384 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #10534: Clarify prevector::erase and avoid swap-to-clear (master...clarify_erase) https://github.com/bitcoin/bitcoin/pull/10534
< bitcoin-git> [bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
< gribble> https://github.com/bitcoin/bitcoin/issues/10463 | Names: BIP9 vs versionbits by jtimon · Pull Request #10463 · bitcoin/bitcoin · GitHub
< jtimon> https://github.com/bitcoin/bitcoin/pull/10502 was created 4 days ago and laready needed rebase twice
< BlueMatt> ;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()?
< btcdrak> wumpus: could you restart the two failing jobs here https://travis-ci.org/bitcoin/bitcoin/builds/238932256
< bitcoin-git> [bitcoin] earonesty opened pull request #10532: -bip148 option (master...bip148) https://github.com/bitcoin/bitcoin/pull/10532
< spudowiar> And provide an option at startup of Bitcoin-Qt to enter the command
< bitcoin-git> [bitcoin] laanwj closed pull request #9740: Add friendly output to dumpwallet (master...dumpwallet) https://github.com/bitcoin/bitcoin/pull/9740
< bitcoin-git> bitcoin/master 9fec4da Wladimir J. van der Laan: Merge #9740: Add friendly output to dumpwallet...
< bitcoin-git> bitcoin/master 164019d aideca: Add dumpwallet output test
< bitcoin-git> bitcoin/master 9f82134 aideca: Add friendly output to dumpwallet refs #9564
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bea5b00cfe95...9fec4da0bec9
< bitcoin-git> [bitcoin] laanwj closed pull request #9745: [RPC] Getting confirmations command (master...add-getconfirmations-to-rpc) https://github.com/bitcoin/bitcoin/pull/9745
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
< bitcoin-git> bitcoin/master bea5b00 MarcoFalke: Merge #10509: Remove xvfb configuration from travis...
< bitcoin-git> bitcoin/master e4bc19f Russell Yanofsky: Remove xvfb configuration from travis...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e654d61d94ee...bea5b00cfe95
< bitcoin-git> [bitcoin] laanwj closed pull request #10489: build: silence gcc7's implicit fallthrough warning (master...wimplicit-fallthrough) https://github.com/bitcoin/bitcoin/pull/10489
< bitcoin-git> bitcoin/master e654d61 Wladimir J. van der Laan: Merge #10489: build: silence gcc7's implicit fallthrough warning...
< bitcoin-git> bitcoin/master cf390df Cory Fields: build: silence gcc7's implicit fallthrough warning...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08d0390a5fea...e654d61d94ee
< bitcoin-git> [bitcoin] laanwj closed pull request #10403: Fix importmulti failure to return rescan errors (master...pr/scansame) https://github.com/bitcoin/bitcoin/pull/10403
< bitcoin-git> bitcoin/master 08d0390 Wladimir J. van der Laan: Merge #10403: Fix importmulti failure to return rescan errors...
< bitcoin-git> bitcoin/master 4d2d604 Russell Yanofsky: Fix importmulti failure to return rescan errors...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0747d3349817...08d0390a5fea
< bitcoin-git> [bitcoin] laanwj closed pull request #10455: Simplify feebumper minimum fee code slightly (master...pr/bumpmin) https://github.com/bitcoin/bitcoin/pull/10455
< bitcoin-git> bitcoin/master 0747d33 Wladimir J. van der Laan: Merge #10455: Simplify feebumper minimum fee code slightly...
< bitcoin-git> bitcoin/master 88b8f0b Russell Yanofsky: Simplify feebumper minimum fee code slightly...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c871f323b418...0747d3349817
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515
< bitcoin-git> bitcoin/master c871f32 MarcoFalke: Merge #10515: [test] Add test for getchaintxstats...
< bitcoin-git> bitcoin/master cc36b5e Jimmy Song: [test] Add test for getchaintxstats
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cec9e1ea6174...c871f323b418
< bitcoin-git> [bitcoin] laanwj closed pull request #10422: Fix timestamp in fee estimate debug message (master...fixtimeunits) https://github.com/bitcoin/bitcoin/pull/10422
< bitcoin-git> bitcoin/master cec9e1e Wladimir J. van der Laan: Merge #10422: Fix timestamp in fee estimate debug message...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e103b3ff1e4f...cec9e1ea6174
< bitcoin-git> bitcoin/master 8d4f401 Alex Morcos: Fix timestamp in fee estimate debug message
< bitcoin-git> [bitcoin] laanwj closed pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
< bitcoin-git> bitcoin/master e103b3f Wladimir J. van der Laan: Merge #10514: Bugfix: missing == 0 after randrange...
< bitcoin-git> bitcoin/master 9aa215b Pieter Wuille: Bugfixes: missing == 0 after randrange
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/296928eb38a4...e103b3ff1e4f
< bitcoin-git> [bitcoin] laanwj closed pull request #10478: rpc: Add listen address to incoming connections in `getpeerinfo` (master...2017_05_peer_listenaddr) https://github.com/bitcoin/bitcoin/pull/10478
< bitcoin-git> bitcoin/master 296928e Wladimir J. van der Laan: Merge #10478: rpc: Add listen address to incoming connections in `getpeerinfo`...
< bitcoin-git> bitcoin/master 3457331 Wladimir J. van der Laan: test: Add test for `getpeerinfo` `bindaddr` field
< bitcoin-git> bitcoin/master a7e3c28 Wladimir J. van der Laan: rpc: Add listen address to incoming connections in `getpeerinfo`...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/400fdd08cc95...296928eb38a4
< bitcoin-git> [bitcoin] colgreen opened pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
< spudowiar> e.g. bitcoin-hww-*
< spudowiar> The other PR we need is making signing asynchronous in Bitcoin Qt
< spudowiar> I'm not talking about the RPC interface Bitcoin Core normally uses
< spudowiar> Then on first run, Bitcoin Core could allow you to select a vendor and then a device
< spudowiar> I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one
< bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS>. (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< gribble> https://github.com/bitcoin/bitcoin/issues/10529 | Improve bitcoind systemd service file by Flowdalic · Pull Request #10529 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Flowdalic opened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
< bitcoin-git> bitcoin/0.14 21e1ed4 Wladimir J. van der Laan: doc: Preliminary release notes 0.14.2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/21e1ed48989e1d150e9f85770fd098534e0f81f1
< bitcoin-git> [bitcoin] fanquake closed pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513

2017-06-04

< gribble> https://github.com/bitcoin/bitcoin/issues/10512 | Rework same-chain from abusing DoS banning, to explicit checks by luke-jr · Pull Request #10512 · bitcoin/bitcoin · GitHub
< sipa> for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers)
< bitcoin-git> [bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
< spudowiar> One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet
< spudowiar> The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor`
< spudowiar> sipa: I ended up doing a signrawtransaction-esque API https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1489-L1527
< bitcoin-git> [bitcoin] sipa opened pull request #10526: Force on-the-fly compaction during pertxout upgrade (master...compactrange) https://github.com/bitcoin/bitcoin/pull/10526
< bitcoin-git> [bitcoin] sipa closed pull request #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const (master...master) https://github.com/bitcoin/bitcoin/pull/10471
< bitcoin-git> bitcoin/master 400fdd0 Pieter Wuille: Merge #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const...
< bitcoin-git> bitcoin/master 5f672ca Pavlos Antoniou: net: Denote some CNode functions const
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/098b01dc58ff...400fdd08cc95
< gmaxwell> luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
< spudowiar> One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
< luke-jr> can people check their positions on https://en.bitcoin.it/wiki/Segwit_support and fill in any blanks? thanks
< btcdrak> looks like https://travis-ci.org/bitcoin/bitcoin/builds/238932256 needs of two jobs which stall-errored

2017-06-03

< bitcoin-git> [bitcoin] practicalswift opened pull request #10524: Fix incorrect format strings (master...u-for-unsigned-int) https://github.com/bitcoin/bitcoin/pull/10524
< bitcoin-git> [bitcoin] practicalswift opened pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
< bitcoin-git> [bitcoin] practicalswift opened pull request #10522: Remove unused variables (master...unused-strings) https://github.com/bitcoin/bitcoin/pull/10522
< bitcoin-git> [bitcoin] practicalswift opened pull request #10521: Limit variable scope (master...tighten-scope) https://github.com/bitcoin/bitcoin/pull/10521
< spudowiar> It's basically mimicking the API, because you could just as easily have the HWW plugin connect to the Bitcoin Core over HTTP RPC
< spudowiar> luke-jr: Because then you can do "Bitcoin Core asks HWW signrawtransaction", "HWW asks Bitcoin Core gettransaction", "HWW responds to signrawtransaction"
< spudowiar> But I could do stdin, stdout and a file descriptor for a socket (to the Bitcoin daemon RPC server)
< bitcoin-git> [bitcoin] sipa closed pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
< spudowiar> So, I have a HWW plugin (a command called bitcoin-hww-trezor)
< bitcoin-git> [bitcoin] achow101 opened pull request #10519: [RPC] Remove waitforblock and waitfornewblock (master...rm-waitforblock-rpcs) https://github.com/bitcoin/bitcoin/pull/10519
< spudowiar> Or even `bitcoin-qt -hww-server=http://user:password@othermachine:8332` and connect to another bitcoind
< spudowiar> e.g. You could do `bitcoin-qt -hww-cmd=bitcoin-hww-trezor`
< bitcoin-git> [bitcoin] biniek opened pull request #10518: Fix translation error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10518
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517
< bitcoin-git> [bitcoin] luke-jr opened pull request #10516: Backports for 0.14.2 (0.14...0.14.2_fixes) https://github.com/bitcoin/bitcoin/pull/10516
< bitcoin-git> [bitcoin] jimmysong opened pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515

2017-06-02

< bitcoin-git> [bitcoin] sipa opened pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
< gmaxwell> spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
< bitcoin-git> [bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git> bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
< bitcoin-git> bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/329fc1dce7a1...098b01dc58ff
< spudowiar> If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
< spudowiar> Then Bitcoin Core verifies that
< gmaxwell> uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
< spudowiar> gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
< bitcoin-git> [bitcoin] ABISprotocol opened pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513
< bitcoin-git> [bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
< bitcoin-git> [bitcoin] achow101 opened pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511
< spudowiar> Also, are there any examples of this in the Bitcoin Core code?
< gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
< spudowiar> What's the protocol for adding new strings to Bitcoin Core? Do I have to worry about translation or will that be sorted by others?
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods (master...test_framework_start_stop_nodes) https://github.com/bitcoin/bitcoin/pull/10359
< bitcoin-git> bitcoin/master 53f6775 John Newbery: fixup: fix nits
< bitcoin-git> bitcoin/master a433d8a John Newbery: [tests] Update start/stop node functions to be private module functions...
< bitcoin-git> bitcoin/master d8c218f John Newbery: [tests] Functional tests call self.start_node(s) and self.stop_node(s)...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1aefc94dd78d...329fc1dce7a1
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10423: [tests] skipped tests should clean up after themselves (master...cleanup_skipped) https://github.com/bitcoin/bitcoin/pull/10423
< bitcoin-git> bitcoin/master 1aefc94 MarcoFalke: Merge #10423: [tests] skipped tests should clean up after themselves...
< bitcoin-git> bitcoin/master 930deb9 John Newbery: [tests] skipped tests should clean up after themselves
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00d369239612...1aefc94dd78d
< bitcoin-git> [bitcoin] laanwj closed pull request #10323: Update to latest libsecp256k1 master (master...secp_up) https://github.com/bitcoin/bitcoin/pull/10323
< bitcoin-git> bitcoin/master 00d3692 Wladimir J. van der Laan: Merge #10323: Update to latest libsecp256k1 master...
< bitcoin-git> bitcoin/master 5252827 Pieter Wuille: Update to latest libsecp256k1
< bitcoin-git> bitcoin/master e7c1b44 Pieter Wuille: Squashed 'src/secp256k1/' changes from 8225239..84973d3...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cc2c670e3d7...00d369239612
< bitcoin-git> bitcoin/0.14 4a41de4 Wladimir J. van der Laan: build: bump version to 0.14.2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/4a41de4585a4dffb451a9be8078abb838235f336
< instagibbs> bad timing... https://github.com/drivechain-project/bitcoin/pull/10 just told them about new style guide, haha
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub

2017-06-01

< gribble> https://github.com/bitcoin/bitcoin/issues/9717 | Pow: Remove fCheckPOW from CheckBlockHeader by jtimon · Pull Request #9717 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #10396: Report LevelDB estimate for chainstate size in gettxoutsetinfo (master...diskdbsize) https://github.com/bitcoin/bitcoin/pull/10396
< bitcoin-git> [bitcoin] sipa closed pull request #10506: Fix bumpfee test after #10449 (master...pr/bumpdis) https://github.com/bitcoin/bitcoin/pull/10506
< bitcoin-git> bitcoin/master 7cc2c67 Pieter Wuille: Merge #10506: Fix bumpfee test after #10449...
< bitcoin-git> bitcoin/master 8906a9a Russell Yanofsky: Fix bumpfee test after #10449...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1088b02f0ccd...7cc2c670e3d7
< bitcoin-git> [bitcoin] sipa closed pull request #10195: Switch chainstate db and cache to per-txout model (master...pertxoutcache) https://github.com/bitcoin/bitcoin/pull/10195
< bitcoin-git> bitcoin/master e484652 Pieter Wuille: Introduce CHashVerifier to hash read data...
< bitcoin-git> bitcoin/master f54580e Pieter Wuille: error() in disconnect for disk corruption, not inconsistency...
< bitcoin-git> bitcoin/master e66dbde Pieter Wuille: Add SizeEstimate to CDBBatch...
< bitcoin-git> [bitcoin] sipa pushed 30 new commits to master: https://github.com/bitcoin/bitcoin/compare/39039b12a744...1088b02f0ccd
< gribble> https://github.com/bitcoin/bitcoin/issues/10449 | Overhaul Qt fee bumper by jonasschnelli · Pull Request #10449 · bitcoin/bitcoin · GitHub
< jtimon> btw, travis didn't even run for https://github.com/bitcoin/bitcoin/pull/9176
< BlueMatt> Bitcoin Series A ICO
< * sipa> commits the Bitcoin Core.ico file
< jonasschnelli> Bitcoin Core ICO?
< luke-jr> 2.7M bitcoin-cli; 33M bitcoin-qt; 3.0M bitcoin-tx; 8.9M bitcoind; 12M test_bitcoin
< cfields> and I'd be curious to see what lto does to bitcoin-qt ?
< jtimon> and if somebody can help with https://github.com/bitcoin/bitcoin/pull/10193/commits/3f404ca62c26dae8f5a4f321820a460bf7b5373e I am kind of stuck there
< wumpus> luke-jr: where do you think it comes from? is it just bitcoin-qt being large or everything?
< jtimon> sorry for linking so many of my prs, but re boost: https://github.com/bitcoin/bitcoin/pull/10502
< gribble> https://github.com/bitcoin/bitcoin/issues/10299 | Remove OpenSSL by sipa · Pull Request #10299 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10427 | Consensus: Introduce static GetScriptFlags (mostly MOVEONLY) by jtimon · Pull Request #10427 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10506: Fix bumpfee test after #10449 (master...pr/bumpdis) https://github.com/bitcoin/bitcoin/pull/10506
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< jtimon> I would love https://github.com/bitcoin/bitcoin/pull/8994 , working on the blocksigning stuff again
< jtimon> ok, https://github.com/bitcoin/bitcoin/pull/10461 reading now, but I assume it will be acceptable to me
< gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | [qt] Add abstraction layer for accessing node and wallet functionality from gui by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10321 | Use FastRandomContext for all tests by sipa · Pull Request #10321 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9717 | Pow: Remove fCheckPOW from CheckBlockHeader by jtimon · Pull Request #9717 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< jonasschnelli> Please review HD auto restore... I whised we have this in 0.15. But seems to get late: https://github.com/bitcoin/bitcoin/pull/10240
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< bitcoin-git> [bitcoin] sipa opened pull request #10503: Use REJECT_DUPLICATE for already known and conflicted txn (master...more61duplicate) https://github.com/bitcoin/bitcoin/pull/10503
< gmaxwell> holy crap Block Filter Digest profiling post on bitcoin-dev.
< bitcoin-git> [bitcoin] jtimon opened pull request #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE (master...b15-boost-foreach) https://github.com/bitcoin/bitcoin/pull/10502
< bitcoin-git> [bitcoin] laanwj closed pull request #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate (master...poolfeerate) https://github.com/bitcoin/bitcoin/pull/10475
< bitcoin-git> bitcoin/master 39039b1 Wladimir J. van der Laan: Merge #10475: [RPC] getmempoolinfo mempoolminfee is a BTC/KB feerate...
< bitcoin-git> bitcoin/master f128f78 Gregory Sanders: getmempool mempoolminfee is a BTC/KB feerate
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64beb1317912...39039b12a744
< bitcoin-git> [bitcoin] benma opened pull request #10501: remove some unused functions (master...unusedfuncs) https://github.com/bitcoin/bitcoin/pull/10501
< gribble> https://github.com/bitcoin/bitcoin/issues/10451 | contrib/init/bitcoind.openrcconf: Dont disable wallet by default by luke-jr · Pull Request #10451 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10449 | Overhaul Qt fee bumper by jonasschnelli · Pull Request #10449 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10449 | Overhaul Qt fee bumper by jonasschnelli · Pull Request #10449 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10449: Overhaul Qt fee bumper (master...2016/05/bump_qt_overhaul) https://github.com/bitcoin/bitcoin/pull/10449
< bitcoin-git> bitcoin/master 64beb13 Jonas Schnelli: Merge #10449: Overhaul Qt fee bumper...
< bitcoin-git> bitcoin/master 6d7104c Jonas Schnelli: [Qt] make sure transaction table entry gets updated after bump
< bitcoin-git> bitcoin/master 32325a3 Jonas Schnelli: [Qt] hide bump context menu action if tx already has been bumped
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/27b99312bf09...64beb1317912
< instagibbs> wumpus, if you're still looking for things to merge :P https://github.com/bitcoin/bitcoin/pull/10475
< bitcoin-git> [bitcoin] laanwj closed pull request #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default (master...openrc_wallet) https://github.com/bitcoin/bitcoin/pull/10451
< bitcoin-git> bitcoin/master 27b9931 Wladimir J. van der Laan: Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default...
< bitcoin-git> bitcoin/master afc693d Luke Dashjr: contrib/init/bitcoind.openrcconf: Don't disable wallet by default...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb1716acc720...27b99312bf09
< bitcoin-git> [bitcoin] practicalswift opened pull request #10498: Use static_cast instead of C-style casts for non-fundamental types (master...static_cast) https://github.com/bitcoin/bitcoin/pull/10498