2017-06-29

< bitcoin-git> [bitcoin] practicalswift opened pull request #10701: Remove the virtual specifier for functions with the override specifier (master...virtual-override) https://github.com/bitcoin/bitcoin/pull/10701
< wumpus> cfields: btw any idea what to do here? https://github.com/bitcoin/bitcoin/issues/10670 arguably the openbsd case is worst-case, they use an ancient GNU binutils
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10688: contrib: Update laanwj key (master...2017_06_laanwj_key) https://github.com/bitcoin/bitcoin/pull/10688
< bitcoin-git> bitcoin/master 080ec52 MarcoFalke: Merge #10688: contrib: Update laanwj key...
< bitcoin-git> bitcoin/master 3c85332 Wladimir J. van der Laan: contrib: Update laanwj key...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90a002ea647d...080ec5209172
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9722: GUI: Display warning when attempting address reuse (master...reuse) https://github.com/bitcoin/bitcoin/pull/9722

2017-06-28

< bitcoin-git> [bitcoin] sipa opened pull request #10699: Make all script validation flags backward compatible (master...20170628_softflags) https://github.com/bitcoin/bitcoin/pull/10699
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10698: Be consistent in calling transactions "replaceable" for Opt-In RBF (master...2017-06-replaceable-rpc-args) https://github.com/bitcoin/bitcoin/pull/10698
< gribble> https://github.com/bitcoin/bitcoin/issues/9447 | Allow 2 simultaneous block downloads by morcos · Pull Request #9447 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10697: Do not hold cs_vNodes when making ForEachNode Callbacks (master...2017-06-cnodestateaccessors-5) https://github.com/bitcoin/bitcoin/pull/10697
< bitcoin-git> [bitcoin] practicalswift opened pull request #10696: Remove redundant nullptr checks before deallocation (master...delete-nullptr) https://github.com/bitcoin/bitcoin/pull/10696
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< luke-jr> Bitcoin Core doesn't NOT support Knots releases either. Knots APIs are not necessarily guaranteed, but we should try to maintain compatibility when reasonable.
< BlueMatt> bitcoin core does not support Knots releases, so I dont think you can argue we're tied to Knots' API - Knots can apply patches if it likes
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10695: [qa] Rewrite BIP65 functional tests (master...2017-06-fix-bip65-test) https://github.com/bitcoin/bitcoin/pull/10695
< bitcoin-git> [bitcoin] sipa closed pull request #10558: Address nits from per-utxo change (master...10195nits) https://github.com/bitcoin/bitcoin/pull/10558
< bitcoin-git> bitcoin/master 90a002e Pieter Wuille: Merge #10558: Address nits from per-utxo change...
< bitcoin-git> bitcoin/master 21d4afa Alex Morcos: Comment clarifications in coins.cpp
< bitcoin-git> bitcoin/master 3c8a9ae Alex Morcos: Add belt-and-suspenders in DisconnectBlock...
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/30c21306c171...90a002ea647d
< bitcoin-git> bitcoin/master 30c2130 Pieter Wuille: Merge #10685: Clarify CCoinsViewMemPool documentation....
< bitcoin-git> [bitcoin] sipa closed pull request #10685: Clarify CCoinsViewMemPool documentation. (master...2017-06-ccoinsviewmempool-doc-cleanup) https://github.com/bitcoin/bitcoin/pull/10685
< bitcoin-git> bitcoin/master 381b8fc Matt Corallo: Clarify CCoinsViewMemPool documentation....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4e551adfec2...30c21306c171
< bitcoin-git> [bitcoin] practicalswift opened pull request #10694: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (master...remove-redundant-code-in-MutateTxSign) https://github.com/bitcoin/bitcoin/pull/10694
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10692: Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState (master...2017-04-const-mapblockindex) https://github.com/bitcoin/bitcoin/pull/10692
< bitcoin-git> [bitcoin] wraith7 opened pull request #10691: Trivial: Properly comment about shutdown process in init.cpp file. (master...master) https://github.com/bitcoin/bitcoin/pull/10691
< bitcoin-git> [bitcoin] laanwj closed pull request #10148: Use non-atomic flushing with block replay (master...non_atomic_flush) https://github.com/bitcoin/bitcoin/pull/10148
< bitcoin-git> bitcoin/master 0580ee0 Pieter Wuille: Adapt memory usage estimation for flushing
< bitcoin-git> bitcoin/master 013a56a Pieter Wuille: Non-atomic flushing using the blockchain as replay journal
< bitcoin-git> bitcoin/master b3a279c Pieter Wuille: [MOVEONLY] Move LastCommonAncestor to chain
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/416af3edf5b5...d4e551adfec2
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (master...2017-06-comp-framework-extraargs) https://github.com/bitcoin/bitcoin/pull/10690
< bitcoin-git> bitcoin/master 416af3e MarcoFalke: Merge #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework...
< bitcoin-git> bitcoin/master 4ed3653 Suhas Daftuar: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a941a10101d...416af3edf5b5
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (master...2017-06-comp-framework-extraargs) https://github.com/bitcoin/bitcoin/pull/10690
< bitcoin-git> [bitcoin] fanquake closed pull request #10689: fixing a couple of typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10689
< bitcoin-git> [bitcoin] laanwj closed pull request #9527: Enable RBF transactions in wallet by default (master...pr/walletrbf) https://github.com/bitcoin/bitcoin/pull/9527
< bitcoin-git> [bitcoin] laanwj closed pull request #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class (master...overrides-ii) https://github.com/bitcoin/bitcoin/pull/10631
< bitcoin-git> bitcoin/master 9a941a1 Wladimir J. van der Laan: Merge #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class...
< bitcoin-git> bitcoin/master aa95947 practicalswift: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a381f6a5bdc2...9a941a10101d
< gribble> https://github.com/bitcoin/bitcoin/issues/9672 | Opt-into-RBF for RPC & bitcoin-tx by luke-jr · Pull Request #9672 · bitcoin/bitcoin · GitHub
< morcos> luke-jr: you ok with changing optIntoRbf and optintorbf that you added in #9672 to replaceable? should i also change rbfoptin from bitcoin-tx (same PR) ?
< bitcoin-git> [bitcoin] tiagmoraismorgado opened pull request #10689: fixing a couple of typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10689
< bitcoin-git> [bitcoin] laanwj closed pull request #10684: Remove no longer used mempool.exists(outpoint) (master...lessHaveCoin) https://github.com/bitcoin/bitcoin/pull/10684
< bitcoin-git> bitcoin/master a381f6a Wladimir J. van der Laan: Merge #10684: Remove no longer used mempool.exists(outpoint)...
< bitcoin-git> bitcoin/master 22378ad Alex Morcos: Remove no longer used mempool.exists(outpoint)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/acb11535cb84...a381f6a5bdc2
< bitcoin-git> [bitcoin] laanwj opened pull request #10688: contrib: Update laanwj key (master...2017_06_laanwj_key) https://github.com/bitcoin/bitcoin/pull/10688
< bitcoin-git> [bitcoin] laanwj closed pull request #10649: Make sure we only mine via the first wallet (master...2017/06/wallet_generate) https://github.com/bitcoin/bitcoin/pull/10649
< bitcoin-git> [bitcoin] practicalswift opened pull request #10686: Avoid usage of uninitialized values in function call arguments (master...uninitialized-arguments) https://github.com/bitcoin/bitcoin/pull/10686

2017-06-27

< BlueMatt> wumpus: when you get a chance, can you respond to sipa's question at https://github.com/bitcoin/bitcoin/pull/10179#issuecomment-310548915 ?
< bitcoin-git> [bitcoin] morcos closed pull request #10586: More economical fee estimates for opt-in-RBF transactions (master...aggressiveEstimates) https://github.com/bitcoin/bitcoin/pull/10586
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10685: Clarify CCoinsViewMemPool documentation. (master...2017-06-ccoinsviewmempool-doc-cleanup) https://github.com/bitcoin/bitcoin/pull/10685
< bitcoin-git> [bitcoin] morcos opened pull request #10684: Remove no longer used mempool.exists(outpoint) (master...lessHaveCoin) https://github.com/bitcoin/bitcoin/pull/10684
< bitcoin-git> [bitcoin] laanwj closed pull request #10659: [qa] blockchain: Pass on closed connection during generate call (master...Mf1706-qaStopPass) https://github.com/bitcoin/bitcoin/pull/10659
< bitcoin-git> bitcoin/master acb1153 Wladimir J. van der Laan: Merge #10659: [qa] blockchain: Pass on closed connection during generate call...
< bitcoin-git> bitcoin/master fab1fb7 MarcoFalke: [qa] blockchain: Pass on closed connection during generate call
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac52492cd227...acb11535cb84
< bitcoin-git> [bitcoin] laanwj opened pull request #10683: rpc: Move the `generate` RPC call to rpcwallet (master...2017_06_wallet_mining) https://github.com/bitcoin/bitcoin/pull/10683
< bitcoin-git> [bitcoin] esneider opened pull request #10682: Trivial: Move the AreInputsStandard documentation next to its implementation (master...move-doc) https://github.com/bitcoin/bitcoin/pull/10682
< bitcoin-git> [bitcoin] laanwj closed pull request #10118: Util: Remove redundant calls to argsGlobal.IsArgSet() (master...0.14-args-class2) https://github.com/bitcoin/bitcoin/pull/10118
< bitcoin-git> bitcoin/master ac52492 Wladimir J. van der Laan: Merge #10118: Util: Remove redundant calls to argsGlobal.IsArgSet()...
< bitcoin-git> bitcoin/master ed866ab Jorge Timón: Indentation after 'Remove redundant calls to gArgs.IsArgSet()'
< bitcoin-git> bitcoin/master 506b700 Jorge Timón: Util: Remove redundant calls to gArgs.IsArgSet()...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c87a9c748be...ac52492cd227
< bitcoin-git> [bitcoin] instagibbs opened pull request #10681: add gdb attach process to test README (master...gdbattach) https://github.com/bitcoin/bitcoin/pull/10681
< bitcoin-git> [bitcoin] laanwj closed pull request #10612: The young person's guide to the test_framework (master...templatefunctionaltest) https://github.com/bitcoin/bitcoin/pull/10612
< bitcoin-git> bitcoin/master 7c87a9c Wladimir J. van der Laan: Merge #10612: The young person's guide to the test_framework...
< bitcoin-git> bitcoin/master e7ba6c1 John Newbery: [tests] add example test
< bitcoin-git> bitcoin/master 76859e6 John Newbery: [tests] Update functional tests documentation
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1680ee0edf46...7c87a9c748be
< bitcoin-git> bitcoin/master 1680ee0 Wladimir J. van der Laan: Merge #10400: [RPC] Add an uptime command that displays the amount of time (in seconds) bitcoind has been running...
< bitcoin-git> bitcoin/master c074752 Ricardo Velhote: [RPC] Add an uptime command that displays the amount of time that bitcoind has been running
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78783531b7cc...1680ee0edf46
< bitcoin-git> [bitcoin] laanwj closed pull request #10675: Update INSTALL.md (master...master) https://github.com/bitcoin/bitcoin/pull/10675
< bitcoin-git> [bitcoin] laanwj closed pull request #10581: Simplify return values of GetCoin/HaveCoin(InCache) (master...simplehavecoin) https://github.com/bitcoin/bitcoin/pull/10581
< bitcoin-git> bitcoin/master 7878353 Wladimir J. van der Laan: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache)...
< bitcoin-git> bitcoin/master 21180ff Pieter Wuille: Simplify return values of GetCoin/HaveCoin(InCache)...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/234ffc677ee5...78783531b7cc
< bitcoin-git> [bitcoin] MeshCollider opened pull request #10680: Fix inconsistencies and grammar in various files (master...fix_typos_and_inconsistencies) https://github.com/bitcoin/bitcoin/pull/10680
< luke-jr> I wonder if it would fly to PR https://github.com/BitcoinHardfork/bitcoin/pull/3 on Core, but with a date 7 years in the future..
< bitcoin-git> [bitcoin] schildbach opened pull request #10679: Document the non-DER-conformance of one test in tx_valid.json. (master...tx-valid-comment) https://github.com/bitcoin/bitcoin/pull/10679
< gribble> https://github.com/bitcoin/bitcoin/issues/10636 | [qa] util: Check return code after closing bitcoind proc by MarcoFalke · Pull Request #10636 · bitcoin/bitcoin · GitHub
< wumpus> #10636 seems to be causing some travis false positives, e.g. https://travis-ci.org/bitcoin/bitcoin/jobs/247360729 in zapwallettxes.py
< bitcoin-git> [bitcoin] instagibbs opened pull request #10677: RPC Docs: addmultisigaddress is intended for non-watchonly addresses (master...importmultiwatch) https://github.com/bitcoin/bitcoin/pull/10677
< bitcoin-git> [bitcoin] instagibbs opened pull request #10676: document script-based return fields for validateaddress (master...validatata) https://github.com/bitcoin/bitcoin/pull/10676
< bitcoin-git> [bitcoin] hans-liu opened pull request #10675: Update INSTALL.md (master...master) https://github.com/bitcoin/bitcoin/pull/10675
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jtimon> I tried force pushing to #8994 several times but got timeouts all times, I don't think the branch is to blame, but perhaps I'm missing something. see https://travis-ci.org/bitcoin/bitcoin/builds/246986373

2017-06-26

< bitcoin-git> [bitcoin] jnewbery closed pull request #9569: Setting -blocksonly sets -maxmempool to zero. (master...blocksonlynomempoolsharing) https://github.com/bitcoin/bitcoin/pull/9569
< bitcoin-git> [bitcoin] practicalswift opened pull request #10673: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked() (master...null-pointer-dereference) https://github.com/bitcoin/bitcoin/pull/10673
< bitcoin-git> [bitcoin] laanwj closed pull request #10559: Change semantics of HaveCoinInCache to match HaveCoin (master...haveunspentincache) https://github.com/bitcoin/bitcoin/pull/10559
< bitcoin-git> bitcoin/master 234ffc6 Wladimir J. van der Laan: Merge #10559: Change semantics of HaveCoinInCache to match HaveCoin...
< bitcoin-git> bitcoin/master 5257698 Alex Morcos: Change semantics of HaveCoinInCache to match HaveCoin...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/22a0aca32974...234ffc677ee5
< bitcoin-git> [bitcoin] practicalswift opened pull request #10672: Avoid division by zero in the case of a corrupt estimates file (master...division-by-zero) https://github.com/bitcoin/bitcoin/pull/10672
< bitcoin-git> [bitcoin] laanwj closed pull request #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options (master...connman_options) https://github.com/bitcoin/bitcoin/pull/10496
< bitcoin-git> bitcoin/master 22a0aca Wladimir J. van der Laan: Merge #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options...
< bitcoin-git> bitcoin/master 07b2afe Marko Bencun: add Binds, WhiteBinds to CConnman::Options...
< bitcoin-git> bitcoin/master ce79f32 Marko Bencun: add WhitelistedRange to CConnman::Options...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3f1e2e7d380...22a0aca32974
< bitcoin-git> [bitcoin] laanwj closed pull request #9544: [trivial] Add end of namespace comments. Improve consistency. (master...consistent-use-of-end-of-namespace-comments) https://github.com/bitcoin/bitcoin/pull/9544
< bitcoin-git> bitcoin/master 5a9b508 practicalswift: [trivial] Add end of namespace comments
< bitcoin-git> bitcoin/master f3f1e2e Wladimir J. van der Laan: Merge #9544: [trivial] Add end of namespace comments. Improve consistency....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d609fd85ca41...f3f1e2e7d380
< wumpus> you mean in the channel topic? currently we suggest #bitcoin for usage questions, that seems ok

2017-06-25

< earlz> ah lame, so you'd have to write code to get Bitcoin Core to do that
< earlz> is there any way to easily make that request from a Bitcoin Core node?
< bitcoin-git> [bitcoin] laanwj closed pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (master...timebomb) https://github.com/bitcoin/bitcoin/pull/10282
< bitcoin-git> [bitcoin] jtimon opened pull request #10669: Pow: Introduce MaybeGenerateProof (master...b14-pow-maybe-prove) https://github.com/bitcoin/bitcoin/pull/10669
< bitcoin-git> [bitcoin] jtimon closed pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
< bitcoin-git> [bitcoin] jtimon opened pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
< bitcoin-git> bitcoin/master d609fd8 Wladimir J. van der Laan: Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()...
< bitcoin-git> bitcoin/master b324b28 Jorge Timón: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bef02fb6ac9f...d609fd85ca41
< jtimon> mhmm, it doesn't seem like https://travis-ci.org/bitcoin/bitcoin/jobs/246709867 and https://travis-ci.org/bitcoin/bitcoin/jobs/246709865 should have failed, but I'm on the laptop and I can't say for sure yet
< bitcoin-git> [bitcoin] jtimon reopened pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
< bitcoin-git> [bitcoin] jtimon closed pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
< jtimon> suryab: I believe you are correct. Not only at the rpc level but not even at a lower level. https://github.com/bitcoin/bitcoin/pull/8498 would solve this or you can just CAmount nFees = view.GetValueIn(tx)- tx.GetValueOut();

2017-06-24

< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9176 | Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() by jtimon · Pull Request #9176 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon closed pull request #10462: Consensus: Modified BIP8 implementation (master...b15-bip8-min) https://github.com/bitcoin/bitcoin/pull/10462
< sipa> this channel is about development of one specific implementation of the bitcoin protocol called bitcoin core
< Lauda> try #bitcoin-dev
< gribble> https://github.com/bitcoin/bitcoin/issues/253 | Remove send to IP address and IP transactions support by laanwj · Pull Request #253 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 5b2be2b Russell Yanofsky: Make CWallet::RescanFromTime comment less ambiguous
< bitcoin-git> [bitcoin] laanwj closed pull request #10412: Improve wallet rescan API (master...pr/scanclean) https://github.com/bitcoin/bitcoin/pull/10412
< bitcoin-git> bitcoin/master 9bb66ab Russell Yanofsky: Add RescanFromTime method and use from rpcdump...
< bitcoin-git> bitcoin/master ccf84bb Russell Yanofsky: Move birthday optimization out of ScanForWalletTransactions...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/eee398fa123f...bef02fb6ac9f
< bitcoin-git> [bitcoin] laanwj closed pull request #10339: Optimization: Calculate block hash less times (master...b15-optimization-blockhash) https://github.com/bitcoin/bitcoin/pull/10339
< bitcoin-git> [bitcoin] laanwj closed pull request #10608: Add a comment explaining the use of MAX_BLOCK_BASE_SIZE. (master...size_comment) https://github.com/bitcoin/bitcoin/pull/10608
< bitcoin-git> bitcoin/master eee398f Wladimir J. van der Laan: Merge #10608: Add a comment explaining the use of MAX_BLOCK_BASE_SIZE....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b62b4c873e18...eee398fa123f
< bitcoin-git> bitcoin/master 1887337 Gregory Maxwell: Add a comment explaining the use of MAX_BLOCK_BASE_SIZE.
< bitcoin-git> [bitcoin] laanwj closed pull request #10627: fixed listunspent rpc convert parameter (master...fixed-listunspent) https://github.com/bitcoin/bitcoin/pull/10627
< bitcoin-git> bitcoin/master b62b4c8 Wladimir J. van der Laan: Merge #10627: fixed listunspent rpc convert parameter...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00350bd6db91...b62b4c873e18
< bitcoin-git> bitcoin/master e503b2b tnaka: fixed listunspent rpc convert parameter
< bitcoin-git> [bitcoin] laanwj closed pull request #10191: [trivial] Rename unused RPC arguments 'dummy' (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
< bitcoin-git> bitcoin/master 00350bd Wladimir J. van der Laan: Merge #10191: [trivial] Rename unused RPC arguments 'dummy'...
< bitcoin-git> bitcoin/master 0ef7de9 John Newbery: [RPCs] Remove submitblock parameters argument help text
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2772dc9f2199...00350bd6db91
< bitcoin-git> [bitcoin] laanwj closed pull request #9979: p2p: Bare minimum to support UNIX sockets (master...2017_03_unix_socket_p2p) https://github.com/bitcoin/bitcoin/pull/9979
< bitcoin-git> [bitcoin] laanwj closed pull request #9919: UNIX sockets support for RPC (master...2017_03_unix_socket) https://github.com/bitcoin/bitcoin/pull/9919
< bitcoin-git> [bitcoin] laanwj closed pull request #10446: net: avoid extra dns query per seed (master...no-double-resolve) https://github.com/bitcoin/bitcoin/pull/10446
< bitcoin-git> bitcoin/master 6cdc488 Cory Fields: net: switch to dummy internal ip for dns seed source...
< bitcoin-git> bitcoin/master 6d0bd5b Cory Fields: net: do not allow resolving to an internal address...
< bitcoin-git> bitcoin/master 7f31762 Cory Fields: net: add an internal subnet for representing unresolved hostnames...
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/232508fe0fcb...2772dc9f2199
< gribble> https://github.com/bitcoin/bitcoin/issues/10622 | Compile error (ubuntu trusty) · Issue #10622 · bitcoin/bitcoin · GitHub
< wumpus> NicolasDorier: #10622 is strange - it looks like a stale bitcoin-config.h is floating around, but I'd expect git clean -dfx to take care of that
< bitcoin-git> [bitcoin] laanwj closed pull request #10577: Add an explanation of quickly hashing onto a non-power of two range. (master...hashrange-comment) https://github.com/bitcoin/bitcoin/pull/10577
< bitcoin-git> bitcoin/master 232508f Wladimir J. van der Laan: Merge #10577: Add an explanation of quickly hashing onto a non-power of two range....
< bitcoin-git> bitcoin/master dd869c6 Gregory Maxwell: Add an explanation of quickly hashing onto a non-power of two range....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0a7801223fd...232508fe0fcb
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10662: Initialize randomness in benchmarks (master...fix-bench) https://github.com/bitcoin/bitcoin/pull/10662
< bitcoin-git> bitcoin/master e0a7801 MarcoFalke: Merge #10662: Initialize randomness in benchmarks...
< bitcoin-git> bitcoin/master 5155d11 Andrew Chow: Initialize randomness in benchmarks...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c841a31a91f...e0a7801223fd
< bitcoin-git> [bitcoin] laanwj closed pull request #10626: doc: Remove outdated minrelaytxfee comment (master...Mf1706-docInit) https://github.com/bitcoin/bitcoin/pull/10626
< bitcoin-git> bitcoin/master 8c841a3 Wladimir J. van der Laan: Merge #10626: doc: Remove outdated minrelaytxfee comment...
< bitcoin-git> bitcoin/master fab9b60 MarcoFalke: doc: Remove outdated minrelaytxfee comment
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2921405dff1...8c841a31a91f
< bitcoin-git> [bitcoin] sipa closed pull request #10665: go (master...release) https://github.com/bitcoin/bitcoin/pull/10665
< annanay25> Hi, where can I find a Roadmap of Bitcoin development?
< bitcoin-git> [bitcoin] donlondon opened pull request #10665: go (master...release) https://github.com/bitcoin/bitcoin/pull/10665
< bitcoin-git> [bitcoin] theuni opened pull request #10663: net: split resolve out of connect (master...split-resolve-connect) https://github.com/bitcoin/bitcoin/pull/10663

2017-06-23

< bitcoin-git> [bitcoin] achow101 opened pull request #10662: Initialize randomness in benchmarks (master...fix-bench) https://github.com/bitcoin/bitcoin/pull/10662
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10661: Add multiwallet support to wallet RPCs (master...pr/multiopt) https://github.com/bitcoin/bitcoin/pull/10661
< luke-jr> jonasschnelli: that one used to just be "bitcoin", so didn't need to change it I think
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10644: Slightly overhaul NSI pixmaps (master...2017/06/cleanup) https://github.com/bitcoin/bitcoin/pull/10644
< bitcoin-git> bitcoin/master e292140 Jonas Schnelli: Merge #10644: Slightly overhaul NSI pixmaps...
< bitcoin-git> bitcoin/master 92fb8bd Jonas Schnelli: Slightly overhaul NSI pixmaps
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c2098ad1209...e2921405dff1
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10660: Allow to cancel the txdb upgrade via splashscreen keypress 's' (master...2017/06/chainstate_update_prog) https://github.com/bitcoin/bitcoin/pull/10660
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #10659: [qa] blockchain: Pass on closed connection during generate call (master...Mf1706-qaStopPass) https://github.com/bitcoin/bitcoin/pull/10659
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10658: German translation of '%n year(s)' (master...master) https://github.com/bitcoin/bitcoin/pull/10658
< bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10658: German translation of '%n year(s)' (master...master) https://github.com/bitcoin/bitcoin/pull/10658
< bitcoin-git> [bitcoin] str4d opened pull request #10657: Utils: Improvements to ECDSA key-handling code (master...libsecp256k1-patches) https://github.com/bitcoin/bitcoin/pull/10657
< bitcoin-git> [bitcoin] RHavar opened pull request #10655: Properly document target_confirmations in listsinceblock (master...listsinceblock) https://github.com/bitcoin/bitcoin/pull/10655
< gmaxwell> $ ./bitcoin-cli estimatefee 1008

2017-06-22

< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10653: Simple, backwards compatible RPC multiwallet support (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10653
< sipa> profall: bitcoin core is irrelevant in this question; all core does is provide a block template to mine from
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< profall> If Miner #1 is mining to address ABC and Miner #2 is mining to address XZY. However, they have are using the same bitcoin core daemon.
< wumpus> the question just makes no sense, also this is not the place to ask support questions, try #bitcoin
< sipa> Can I haz some review on https://github.com/bitcoin-core/leveldb/pull/2 ?
< bitcoin-git> [bitcoin] achow101 closed pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511
< wumpus> jtimon: it's not just bitcoin, no one ever agrees about RPC mechanisms, ever, anywhere :)
< gribble> https://github.com/bitcoin/bitcoin/issues/9271 | Theres two types of flags: consensus and script by jtimon · Pull Request #9271 · bitcoin/bitcoin · GitHub
< jonasschnelli> cfields: interested if you know why I got again dependencies issues on travis only: https://travis-ci.org/bitcoin/bitcoin/jobs/245674276#L2089
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10652: Small step towards demangling cs_main from CNodeState (master...2017-06-cnodestateaccessors-1) https://github.com/bitcoin/bitcoin/pull/10652
< gribble> https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9717 | Pow: Remove fCheckPOW from CheckBlockHeader by jtimon · Pull Request #9717 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8494 | [init, wallet] ParameterInteraction() iff wallet enabled by MarcoFalke · Pull Request #8494 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10333 | [wallet] fee fixes: always create change, adjust value, and p… by instagibbs · Pull Request #10333 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10360 | [WIP] [Wallet] Target effective value during transaction creation by instagibbs · Pull Request #10360 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jtimon> wumpus: egoistically for elements project, it would be very nice to have #8994 before 0.15 for next elements rebase (not that bitcoin should care)
< BlueMatt> random PSA: there is now a copy of binaries hosted on https://bitcoincore.org/bin as well as https://bitcoin.org/bin. This will be the new "official" download site (though the bitcoin.org folks said they were gonna keep their mirror up for those who are used to bitcoin.org to not have to hop to another site)
< gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8498 | Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
< bitcoin-git> [bitcoin] laanwj closed pull request #10565: [coverage] Remove subtrees and benchmarks from coverage report (master...lcov-remove-extra) https://github.com/bitcoin/bitcoin/pull/10565
< bitcoin-git> bitcoin/master d5711f4 Andrew Chow: Filter subtrees and and benchmarks from coverage report...
< bitcoin-git> bitcoin/master 405b86a Andrew Chow: Replace lcov -r commands with faster way...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/6bef7ca8bc6a...8c2098ad1209
< bitcoin-git> bitcoin/master c8914b9 Andrew Chow: Have `make cov` optionally include branch coverage statistics...
< bitcoin-git> [bitcoin] laanwj closed pull request #10633: doc: Fix various typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10633
< bitcoin-git> bitcoin/master 6bef7ca Wladimir J. van der Laan: Merge #10633: doc: Fix various typos...
< bitcoin-git> bitcoin/master 0a5a6b9 Dimitris Tsapakidis: Fixed multiple typos...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4bc853b50fd9...6bef7ca8bc6a
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10636: [qa] util: Check return code after closing bitcoind proc (master...Mf1706-qaTraceback) https://github.com/bitcoin/bitcoin/pull/10636
< bitcoin-git> bitcoin/master 4bc853b MarcoFalke: Merge #10636: [qa] util: Check return code after closing bitcoind proc...
< bitcoin-git> bitcoin/master 999923e MarcoFalke: [qa] util: Check return code after closing bitcoind proc...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01c4b143a87e...4bc853b50fd9
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10651: Verify binaries from bitcoincore.org and bitcoin.org (master...2017-06-verify-coreorg) https://github.com/bitcoin/bitcoin/pull/10651
< bitcoin-git> [bitcoin] laanwj closed pull request #10248: Rewrite addrdb with less duplication using CHashVerifier (master...chashverifier) https://github.com/bitcoin/bitcoin/pull/10248
< bitcoin-git> bitcoin/master 01c4b14 Wladimir J. van der Laan: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier...
< bitcoin-git> bitcoin/master cf68a48 Pieter Wuille: Deduplicate addrdb.cpp and use CHashWriter/Verifier
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b750b33c3cea...01c4b143a87e
< bitcoin-git> [bitcoin] laanwj closed pull request #10276: contrib/verifybinaries: allow filtering by platform (master...filterByPlatformInVerifySh) https://github.com/bitcoin/bitcoin/pull/10276
< bitcoin-git> bitcoin/master b750b33 Wladimir J. van der Laan: Merge #10276: contrib/verifybinaries: allow filtering by platform...
< bitcoin-git> bitcoin/master 8d4dafd Andres G. Aragoneses: contrib/verifybinaries: allow filtering by platform...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ffce893982d9...b750b33c3cea
< bitcoin-git> [bitcoin] laanwj closed pull request #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents. (master...raii-httpserver) https://github.com/bitcoin/bitcoin/pull/9517
< bitcoin-git> bitcoin/master ffce893 Wladimir J. van der Laan: Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents....
< bitcoin-git> bitcoin/master 1ae86ec Karl-Johan Alm: Changed event RAII helper functions to inline to deal with duplicate symbol linker errors.
< bitcoin-git> bitcoin/master fd369d2 Kalle Alm: Switched httpserver.cpp to use RAII wrapped libevents.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/209eef60a9ac...ffce893982d9
< def> https://0x0.st/lFn.txt <- i can't get signrawtransaction to work, any ideas? i know this isn't a support channel but i'm becoming increasingly convinced that this might be a bug in bitcoin-qt
< bitcoin-git> [bitcoin] laanwj closed pull request #9343: Don't create change at dust limit (master...noneconomicchange) https://github.com/bitcoin/bitcoin/pull/9343
< bitcoin-git> bitcoin/master 209eef6 Wladimir J. van der Laan: Merge #9343: Don't create change at dust limit...
< bitcoin-git> bitcoin/master 6171826 Alex Morcos: Don't create change at the dust limit, even if it means paying more than expected
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87e69c2549c4...209eef60a9ac
< bitcoin-git> [bitcoin] laanwj closed pull request #8831: Replace CWalletDB::ReadKeyValue with CWallet::LoadKeyValue (master...2016-09-28-cwallet-loadkeyvalue) https://github.com/bitcoin/bitcoin/pull/8831
< bitcoin-git> [bitcoin] laanwj closed pull request #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
< bitcoin-git> bitcoin/master 87e69c2 Wladimir J. van der Laan: Merge #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS>...
< bitcoin-git> bitcoin/master e5c6168 Pavlos Antoniou: Fix instantiation and array accesses in class base_uint<BITS>...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8465b68985f4...87e69c2549c4
< bitcoin-git> [bitcoin] laanwj closed pull request #10541: Docs: Update INSTALL.md to add link to build notes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10541
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< sdaftuar> sipa: i've finished my functional test for #10148 -- https://github.com/sdaftuar/bitcoin/tree/test-10148
< bitcoin-git> [bitcoin] laanwj closed pull request #10628: [depends] expat 2.2.1 (master...expat-2-2-1) https://github.com/bitcoin/bitcoin/pull/10628
< bitcoin-git> bitcoin/master 8465b68 Wladimir J. van der Laan: Merge #10628: [depends] expat 2.2.1...
< bitcoin-git> bitcoin/master 2c3fc51 fanquake: [depends] expat 2.2.1
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d991f6f18df...8465b68985f4
< bitcoin-git> [bitcoin] laanwj closed pull request #10642: Remove obsolete _MSC_VER check (master...undefined-msc-ver) https://github.com/bitcoin/bitcoin/pull/10642
< bitcoin-git> bitcoin/master 1d991f6 Wladimir J. van der Laan: Merge #10642: Remove obsolete _MSC_VER check...
< bitcoin-git> bitcoin/master 700d8d8 practicalswift: Remove obsolete _MSC_VER check...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c68a9a69278a...1d991f6f18df
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10632: qa: Add stopatheight test (master...Mf1706-qaStopAtHeight) https://github.com/bitcoin/bitcoin/pull/10632
< bitcoin-git> bitcoin/master c68a9a6 MarcoFalke: Merge #10632: qa: Add stopatheight test...
< bitcoin-git> bitcoin/master 5555fa8 MarcoFalke: qa: Add stopatheight test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d083bd9b9c52...c68a9a69278a
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10650: Multiwallet: add RPC endpoint support (master...2017/06/wallet_rpc_endpoint) https://github.com/bitcoin/bitcoin/pull/10650
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10649: Make sure we only mine via the first wallet (master...2017/06/wallet_generate) https://github.com/bitcoin/bitcoin/pull/10649

2017-06-21

< bitcoin-git> [bitcoin] practicalswift opened pull request #10645: Use nullptr instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10644: Slightly overhaul NSI pixmaps (master...2017/06/cleanup) https://github.com/bitcoin/bitcoin/pull/10644
< jonasschnelli> The rpc test failures are reported here: https://travis-ci.org/bitcoin/bitcoin/jobs/245174021
< gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rexuslexus closed pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643
< bitcoin-git> [bitcoin] rexuslexus opened pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643
< bitcoin-git> [bitcoin] laanwj closed pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
< bitcoin-git> bitcoin/master 279fde5 Andrew Chow: Check for rpcuser/rpcpassword first then for cookie...
< bitcoin-git> bitcoin/master 3ec5ad8 Andrew Chow: Add test for rpcuser/rpcpassword
< bitcoin-git> bitcoin/master c53c983 Andrew Chow: Replace cookie auth in tests...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3eb0d648551...d083bd9b9c52
< bitcoin-git> [bitcoin] practicalswift opened pull request #10642: Use the _MSC_VER macro only if it is defined (master...undefined-msc-ver) https://github.com/bitcoin/bitcoin/pull/10642