2018-11-16

< bitcoin-git> [bitcoin] kristapsk opened pull request #14738: Fix running wallet_listtransactions.py individually through test_runner.py (master...listtransactions) https://github.com/bitcoin/bitcoin/pull/14738
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14731: doc: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/384967f311b4...35739976c1d9
< bitcoin-git> bitcoin/master 07e286d Carl Dong: Improve scripted-diff developer docs...
< bitcoin-git> bitcoin/master 3573997 MarcoFalke: Merge #14731: doc: Improve scripted-diff developer docs...
< Dizzle_> luke-jr: if the mined block is proposed to Bitcoin Core via getblock template, it gets called, and I couldn't find an indication that a valid proposal gets submitted by Core.
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kazcw opened pull request #14734: fix an undefined behavior in uint::SetHex (master...SetHex-bad-ptr) https://github.com/bitcoin/bitcoin/pull/14734

2018-11-15

< bitcoin-git> [bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
< sipa> Vita: #bitcoin-wizards or so, off topic here
< stevenroose> who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e74649e95122...384967f311b4
< bitcoin-git> bitcoin/master 7c5bc2a practicalswift: miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
< bitcoin-git> bitcoin/master 145fe95 practicalswift: tests: Check return value of ParseParameters(...)
< bitcoin-git> bitcoin/master 579497e practicalswift: tests: Explicitly ignore the return value of DecodeBase58(...)
< MarcoFalke> Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 current high priority PRs are by luke-jr promag achow101 phantomcircuit sipa
< gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] dongcarl opened pull request #14731: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
< bitcoin-git> [bitcoin] qubenix opened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729

2018-11-14

< bitcoin-git> [bitcoin] kazcw opened pull request #14728: fix uninitialized read when stringifying an addrLocal (master...uninit-scopeid) https://github.com/bitcoin/bitcoin/pull/14728
< phantomcircuit> core_, mastering bitcoin is basically just a copy of the wiki
< core_> i am just starting with bitcoin core and I'm a little confused with the architecture
< core_> specifically how the client wallet fits in and connects to what pieces of the system (as shown in mastering bitcoin architecture diagram)
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14411: [wallet] Restore ability to list incoming transactions by label (master...pr/list-label) https://github.com/bitcoin/bitcoin/pull/14411
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7366d2399e2...e74649e95122
< bitcoin-git> bitcoin/master 65b740f Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git> bitcoin/master da427db Russell Yanofsky: Rename ListTransactions filter variable...
< bitcoin-git> bitcoin/master e74649e MarcoFalke: Merge #14411: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e8f9dc2bbb1...c7366d2399e2
< bitcoin-git> bitcoin/master b4f6e58 MeshCollider: Better error message for user when corrupt wallet unlock fails
< bitcoin-git> bitcoin/master c7366d2 MarcoFalke: Merge #14478: Show error to user when corrupt wallet unlock fails...
< gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14594 | qt: Fix minimized window bug on Linux by hebasto · Pull Request #14594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14577 | qt: Cleanup `textInteractionFlags` for `QLabel` by hebasto · Pull Request #14577 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704
< bitcoin-git> [bitcoin] laanwj closed pull request #14688: Doc: update release notes for changes since 0.17.0 branch (master...2018-11-release-notes) https://github.com/bitcoin/bitcoin/pull/14688
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99a3e6f0b1ab...2e8f9dc2bbb1
< bitcoin-git> bitcoin/master 86cddf0 mruddy: doc: add detached release notes for #14060
< bitcoin-git> bitcoin/master 2e8f9dc Wladimir J. van der Laan: Merge #14704: doc: add detached release notes for #14060...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74213fa4d13e...99a3e6f0b1ab
< bitcoin-git> bitcoin/master 6062f0e David A. Harding: Release notes: update notes through to 11e1ac3ae08
< bitcoin-git> bitcoin/master ba8f0c6 David A. Harding: Release notes: integrate detached release notes
< bitcoin-git> bitcoin/master 99a3e6f Wladimir J. van der Laan: Merge #14688: Doc: update release notes for changes since 0.17.0 branch...
< gribble> https://github.com/bitcoin/bitcoin/issues/14688 | Doc: update release notes for changes since 0.17.0 branch by harding · Pull Request #14688 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14704 | doc: add detached release notes for #14060 by mruddy · Pull Request #14704 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/33cd94279cd6...74213fa4d13e
< bitcoin-git> bitcoin/master 2bc3f11 Hennadii Stepanov: Bump the minimum Qt version to 5.2
< bitcoin-git> bitcoin/master 74213fa Wladimir J. van der Laan: Merge #14725: qt: Bump the minimum Qt version to 5.2...
< gribble> https://github.com/bitcoin/bitcoin/issues/14723 | Build with official Qt binary installer fails · Issue #14723 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14727 | Mac OSX High Sierra 10.13.6 Build error · Issue #14727 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14698: build: Add bitcoin-tx.exe into Windows installer (master...win-bitcoin-tx) https://github.com/bitcoin/bitcoin/pull/14698
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c59bb85f979...33cd94279cd6
< bitcoin-git> bitcoin/master 5c5902a Chun Kuan Lee: build: Add bitcoin-tx.exe into Windows installer
< bitcoin-git> bitcoin/master 33cd942 Wladimir J. van der Laan: Merge #14698: build: Add bitcoin-tx.exe into Windows installer...
< gribble> https://github.com/bitcoin/bitcoin/issues/14698 | build: Add bitcoin-tx.exe into Windows installer by ken2812221 · Pull Request #14698 · bitcoin/bitcoin · GitHub
< booyah> zhangzf: also, with such usage questions come to #bitcoin - there are more users to help. Also this channel here is only for developers of bitcoin itself so it's not good to ask here
< sipa> zhangzf: no, Bitcoin Core always runs as a full node
< zhangzf> #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14726: Use RPCHelpMan for all RPCs (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14726
< zhangzf> Hi everybody! Bitcoin core can run on Android?
< sipa> esotericnonsense: probably move to #bitcoin

2018-11-13

< bitcoin-git> [bitcoin] hebasto opened pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
< jarthur> Also, this is the development channel. #bitcoin is the place to ask general network usage questions.
< bralyclow> anyone around, posting a question I need your help with...question everyone, I have a bitcoin core full node and wallet, I tried sending a transaction today from a wallet on the node that spent all the BTC in all associated addresses at 1 satoshi per byte and the transaction has been unconfirmed now for over 8 hours which it should have been picked up by this 8 hour timeframe, my question is how can I increase the fee when ther
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f617e05c38c9...8c59bb85f979
< bitcoin-git> bitcoin/master fa0815c Jon Layton: rpc: Correctly name arguments
< bitcoin-git> bitcoin/master 8c59bb8 MarcoFalke: Merge #14720: rpc: Correctly name arguments...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14712: wallet: Require a start block in ScanForWalletTransactions (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
< gribble> https://github.com/bitcoin/bitcoin/issues/14721 | developer doc: Source code organization for standalone (util) functions · Issue #14721 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c651265c934c...f617e05c38c9
< bitcoin-git> bitcoin/master 7afddfa Gregory Sanders: importmulti: Don't add internal addresses to address book
< bitcoin-git> bitcoin/master f617e05 Wladimir J. van der Laan: Merge #14679: importmulti: Don't add internal addresses to address book...
< gribble> https://github.com/bitcoin/bitcoin/issues/14679 | importmulti: Dont add internal addresses to address book by instagibbs · Pull Request #14679 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< bitcoin-git> [bitcoin] Empact closed pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14530: Use RPCHelpMan to generate RPC doc strings (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0c6bb782308...c651265c934c
< bitcoin-git> bitcoin/master fa0d36f MarcoFalke: rpc: Include rpc/util.h where needed for RPCHelpMan...
< bitcoin-git> bitcoin/master fa483e1 MarcoFalke: rpc: Add RPCHelpMan for machine-generated help
< bitcoin-git> bitcoin/master c651265 MarcoFalke: Merge #14530: Use RPCHelpMan to generate RPC doc strings...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d605b27457d...e0c6bb782308
< bitcoin-git> bitcoin/master fa3df02 MarcoFalke: travis: Avoid timeout on verify-commits check
< bitcoin-git> bitcoin/master fa5a6ce MarcoFalke: qa: Raise ci test_runner timeout to 40 mins
< bitcoin-git> bitcoin/master e0c6bb7 MarcoFalke: Merge #14705: travis: Avoid timeout on verify-commits check...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
< gribble> https://github.com/bitcoin/bitcoin/issues/14678 | [wallet] remove redundant KeyOriginInfo access, already done in CreateSig by instagibbs · Pull Request #14678 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request (master...Mf1811-qaPassOnCentOs) https://github.com/bitcoin/bitcoin/pull/14700
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c51e1516a930...5d605b27457d
< bitcoin-git> bitcoin/master 6c787d3 MarcoFalke: tests: Make feature_block pass on centos
< bitcoin-git> bitcoin/master fa21568 MarcoFalke: qa: Avoid race in p2p_invalid_block by waiting for the block request
< bitcoin-git> bitcoin/master 5d605b2 MarcoFalke: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request...
< bitcoin-git> [bitcoin] laanwj closed pull request #14714: tests: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce7fcc356909...c51e1516a930
< bitcoin-git> bitcoin/master 27154ce 1Il1: util.h: explicitly include required QString header
< bitcoin-git> bitcoin/master c51e151 Wladimir J. van der Laan: Merge #14714: util.h: explicitly include required QString header...
< bitcoin-git> [bitcoin] murrayn opened pull request #14718: Remove unreferenced boost headers and quieten remaining clang warnings (master...clang_warnings) https://github.com/bitcoin/bitcoin/pull/14718
< bitcoin-git> [bitcoin] laanwj closed pull request #14690: Throw error if CPubKey is invalid during PSBT keypath serialization (master...check_psbt_pubkey) https://github.com/bitcoin/bitcoin/pull/14690
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/083f53547092...ce7fcc356909
< bitcoin-git> bitcoin/master 4e4de10 Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization
< bitcoin-git> bitcoin/master ce7fcc3 Wladimir J. van der Laan: Merge #14690: Throw error if CPubKey is invalid during PSBT keypath serialization...
< gribble> https://github.com/bitcoin/bitcoin/issues/14690 | Throw error if CPubKey is invalid during PSBT keypath serialization by instagibbs · Pull Request #14690 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
< bitcoin-git> [bitcoin] Empact opened pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14608: qt: Remove the "Pay only required fee..." checkbox (master...20181030-remove-payonlyrequiredfee) https://github.com/bitcoin/bitcoin/pull/14608
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b60f4e3f0951...083f53547092
< bitcoin-git> bitcoin/master 8711cc0 Hennadii Stepanov: qt: Improve BitcoinAmountField class...
< bitcoin-git> bitcoin/master a16f44c Hennadii Stepanov: qt: Remove "Pay only required fee" checkbox...
< bitcoin-git> bitcoin/master 083f535 Jonas Schnelli: Merge #14608: qt: Remove the "Pay only required fee..." checkbox...
< bitcoin-git> [bitcoin] 1Il1 closed pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #13381: RPC: creates possibility to preserve labels on importprivkey (master...feature_preserve_labels_on_import) https://github.com/bitcoin/bitcoin/pull/13381
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47ed24cf8aa7...b60f4e3f0951
< bitcoin-git> bitcoin/master a6b5ec1 marcoagner: rpc: creates possibility to preserve labels on importprivkey...
< bitcoin-git> bitcoin/master b60f4e3 Jonas Schnelli: Merge #13381: RPC: creates possibility to preserve labels on importprivkey...
< bitcoin-git> [bitcoin] 1Il1 opened pull request #14714: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
< bitcoin-git> [bitcoin] 1Il1 opened pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713

2018-11-12

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14712: wallet: Fix crash when rescanning wallet from future (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
< bitcoin-git> [bitcoin] ryanofsky opened pull request #14711: Remove uses of chainActive and mapBlockIndex in wallet code (master...pr/wchain2) https://github.com/bitcoin/bitcoin/pull/14711
< gribble> https://github.com/bitcoin/bitcoin/issues/14356 | fix converttopsbt permitsigdata arg, add basic test by instagibbs · Pull Request #14356 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14356: fix converttopsbt permitsigdata arg, add basic test (master...converttopsbt_strip) https://github.com/bitcoin/bitcoin/pull/14356
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90c0b6aca2da...47ed24cf8aa7
< bitcoin-git> bitcoin/master 88a79cb Gregory Sanders: fix converttopsbt permitsigdata arg, add basic test
< bitcoin-git> bitcoin/master 47ed24c Wladimir J. van der Laan: Merge #14356: fix converttopsbt permitsigdata arg, add basic test...
< bitcoin-git> [bitcoin] practicalswift closed pull request #11535: Avoid unintentional unsigned integer wraparounds (master...unsigned-integer-wraparounds) https://github.com/bitcoin/bitcoin/pull/11535
< bitcoin-git> [bitcoin] practicalswift closed pull request #14194: Annotate unused parameters with [[maybe_unused]] (master...annotate-intentionally-unused-parameters) https://github.com/bitcoin/bitcoin/pull/14194
< bitcoin-git> [bitcoin] practicalswift closed pull request #14224: Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations (master...no_sanitize-unsigned-integer-overflow) https://github.com/bitcoin/bitcoin/pull/14224
< bitcoin-git> [bitcoin] practicalswift closed pull request #11652: Add missing locks: validation.cpp + related (master...init-and-validation-locks) https://github.com/bitcoin/bitcoin/pull/11652
< bitcoin-git> [bitcoin] practicalswift closed pull request #14706: Fix icc (Intel C++ compiler) warnings (master...icc) https://github.com/bitcoin/bitcoin/pull/14706
< wumpus> but agian, please move usage questions to #bitcoin
< wumpus> btw; please ask further usage quesions in #bitcoin, this channel is for development
< wumpus> it downloads and validates the bitcoin block chain
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< meshcollider> wumpus: since promag isn't online, perhaps you can explain to me why there are extra quotes around the escaped quote in the boost::replace_all statements in https://github.com/bitcoin/bitcoin/pull/13339/commits/cef0327afd220950142ec9d4d051bb94f5210be1
< wumpus> the crash happens in a very strange place, while computing the standard data directory based on the home directory (~/.bitcoin)
< gribble> https://github.com/bitcoin/bitcoin/issues/16 | Mac UI issues · Issue #16 · bitcoin/bitcoin · GitHub
< millerti> 726 return pathRet / ".bitcoin";
< millerti> I just built the latest bitcoin from github, and immediately on start, I get a std::bad_alloc exception. I googled this, and I don't think any of the problems people talk about. This is a completely fresh install. No wallets or anything. It's a 64-bit build. I have penty of physical and virtual RAM. Any ideas where to start? I'll try a debugger to get a stack trace....
< bitcoin-git> [bitcoin] laanwj closed pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cdfd72b179d...90c0b6aca2da
< bitcoin-git> bitcoin/master 13fe258 MeshCollider: Error if rpcpassword in conf contains a hash character
< bitcoin-git> bitcoin/master 0385109 MeshCollider: Add test for rpcpassword hash error
< bitcoin-git> bitcoin/master 90c0b6a Wladimir J. van der Laan: Merge #14494: Error if # is used in rpcpassword in conf...
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14228: Qt: Enable system tray icon by default if available (master...unavailable-systray) https://github.com/bitcoin/bitcoin/pull/14228
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/af3c8a7e9f09...5cdfd72b179d
< bitcoin-git> bitcoin/master ec1201a Hennadii Stepanov: Don't use systray icon on inappropriate systems...
< bitcoin-git> bitcoin/master 5cdfd72 Wladimir J. van der Laan: Merge #14228: Qt: Enable system tray icon by default if available...
< bitcoin-git> [bitcoin] laanwj closed pull request #14693: test_node: get_mem_rss fixups (master...Mf1811-qaTestNodeFixups) https://github.com/bitcoin/bitcoin/pull/14693
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/48223256cf6c...af3c8a7e9f09
< bitcoin-git> bitcoin/master fa9ed38 MarcoFalke: test_node: get_mem_rss fixups
< bitcoin-git> bitcoin/master af3c8a7 Wladimir J. van der Laan: Merge #14693: test_node: get_mem_rss fixups...
< bitcoin-git> [bitcoin] laanwj closed pull request #14123: gui: Add GUIUtil::bringToFront (master...2018-08-bringtofront) https://github.com/bitcoin/bitcoin/pull/14123
< bitcoin-git> [bitcoin] laanwj closed pull request #14597: qt: Cleanup MacDockIconHandler class (master...20181028-macos-dock-overhaul) https://github.com/bitcoin/bitcoin/pull/14597
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae32806ea202...48223256cf6c
< bitcoin-git> bitcoin/master 53bb6be Hennadii Stepanov: Remove obj_c for macOS Dock icon setting...
< bitcoin-git> bitcoin/master 2464925 Hennadii Stepanov: Use Qt signal for macOS Dock icon click event...
< bitcoin-git> bitcoin/master 6b1d297 Hennadii Stepanov: Remove obj_c for macOS Dock icon menu...
< gribble> https://github.com/bitcoin/bitcoin/issues/14123 | gui: Add GUIUtil::bringToFront by promag · Pull Request #14123 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14651: Refactor: Fix compiler warning in prevector.h (master...warnings) https://github.com/bitcoin/bitcoin/pull/14651
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc715240cb6...ae32806ea202
< bitcoin-git> bitcoin/master 76e13b5 Lenny Maiorani: warnings: Compiler warning on memset usage for non-trivial type...
< bitcoin-git> bitcoin/master ae32806 Wladimir J. van der Laan: Merge #14651: Refactor: Fix compiler warning in prevector.h...
< bitcoin-git> [bitcoin] AkioNak opened pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
< bitcoin-git> [bitcoin] kallewoof closed pull request #12508: IsAllFromMe (master...feature-isallfromme) https://github.com/bitcoin/bitcoin/pull/12508
< gribble> https://github.com/bitcoin/bitcoin/issues/9615 | Wallet incremental fee by morcos · Pull Request #9615 · bitcoin/bitcoin · GitHub
< esotericnonsense> https://bitcoin.electronrelocation.com/ force refresh if you've seen it before cos I have some issues with caching.
< sanket1729> From pwuille from bitcoin stackexchange: Nodes on the network maintain unconfirmed transactions in their mempool, and when the mempool grows too big, they will raise the minimum fee necessary to enter the mempool
< sanket1729> In peak fees times, fees have been around 1000sat/byte(Jan 2018) whereas rbf only requires fees be more than minTxRelay fees(currently 1say/byte in bitcoin core) than the previous transaction. An attacker could start with 1 sat/byte fees and send 1000 RBF transactions with increasing fees 1sat/byte, 2 .... and so on. Thereby wasting node CPU validation resources 1000 times. This is not a big problem since fees are around
< bitcoin-git> [bitcoin] andrewtoth opened pull request #14707: [RPC] Add include_coinbase option to receiveby RPCs (master...receivedby-coinbase) https://github.com/bitcoin/bitcoin/pull/14707
< Guest9346> How can I contribute to bitcoin development
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub

2018-11-11

< bitcoin-git> [bitcoin] practicalswift opened pull request #14706: Fix icc (Intel C++ compiler) warnings (master...icc) https://github.com/bitcoin/bitcoin/pull/14706

2018-11-10

< sipa> please to do DoS my bitcoin.sipa.be node :)
< gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9245 | Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr · Pull Request #9245 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705
< gribble> https://github.com/bitcoin/bitcoin/issues/14608 | qt: Remove the "Pay only required fee..." checkbox by hebasto · Pull Request #14608 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] mruddy opened pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/1e49fe450dbb...5150accdd2a7
< bitcoin-git> bitcoin/0.17 89306ab Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git> bitcoin/0.17 5150acc Wladimir J. van der Laan: Merge #14441: [wallet] Backport(0.17): Restore ability to list incoming transactions by label...
< gribble> https://github.com/bitcoin/bitcoin/issues/9245 | Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr · Pull Request #9245 · bitcoin/bitcoin · GitHub
< fanquake> definitely not a first for bitcoin core
< fanquake> heh, btw, did you see jamesob's write up here: https://github.com/bitcoin/bitcoin/pull/14336#issuecomment-437384408
< bitcoin-git> [bitcoin] fanquake opened pull request #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (master...add-build-version-to-info-plist) https://github.com/bitcoin/bitcoin/pull/14701
< bitcoin-git> [bitcoin] laanwj closed pull request #12783: macOS: disable AppNap during sync (master...macos-disable-appnap) https://github.com/bitcoin/bitcoin/pull/12783
< gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b30c62d4b954...16e3b175781c
< bitcoin-git> bitcoin/master 6b8d86d Andrew Chow: Require a public key to be retrieved when signing a P2PKH input...
< bitcoin-git> bitcoin/master 16e3b17 Pieter Wuille: Merge #14689: Require a public key to be retrieved when signing a P2PKH input...
< bitcoin-git> [bitcoin] sipa closed pull request #14689: Require a public key to be retrieved when signing a P2PKH input (master...fix-pkh-pubkeys) https://github.com/bitcoin/bitcoin/pull/14689
< bitcoin-git> [bitcoin] sipa closed pull request #14588: Refactor PSBT signing logic to enforce invariant and fix signing bug (master...feature-psbt-sign-fix) https://github.com/bitcoin/bitcoin/pull/14588
< bitcoin-git> [bitcoin] sipa pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbf00939b5e8...b30c62d4b954
< bitcoin-git> bitcoin/master fe5d22b Glenn Willen: More concise conversion of CDataStream to string...
< bitcoin-git> bitcoin/master 4f3f5cb Glenn Willen: Remove redundant txConst parameter to FillPSBT
< bitcoin-git> bitcoin/master 65166d4 Glenn Willen: New PartiallySignedTransaction constructor from CTransction...

2018-11-09

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request (master...Mf1811-qaPassOnCentOs) https://github.com/bitcoin/bitcoin/pull/14700
< gribble> https://github.com/bitcoin/bitcoin/issues/14530 | Use RPCHelpMan to generate RPC doc strings by MarcoFalke · Pull Request #14530 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14441 | [wallet] Backport(0.17): Restore ability to list incoming transactions by label by jnewbery · Pull Request #14441 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/e70a19e7132d...cbf00939b5e8
< bitcoin-git> bitcoin/master 7e2e62c Russell Yanofsky: Add skeleton chain and client classes...
< bitcoin-git> bitcoin/master 8db11dd Russell Yanofsky: Pass chain and client variables where needed...
< bitcoin-git> bitcoin/master ea961c3 Russell Yanofsky: Remove direct node->wallet calls in init.cpp...
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14698: build: Add bitcoin-tx.exe into Windows installer (master...win-bitcoin-tx) https://github.com/bitcoin/bitcoin/pull/14698
< kallewoof> sipa: i want to try some command on a new instance real quick so i do e.g. mkdir x; ./bitcoind -datadir=x -regtest &; [do stuff]; ^D^C and the instance is shutdown. I could just do './bitcoin-cli -datadir=x stop' but ^D^C is .. shorter.
< gribble> https://github.com/bitcoin/bitcoin/issues/14689 | Require a public key to be retrieved when signing a P2PKH input by achow101 · Pull Request #14689 · bitcoin/bitcoin · GitHub
< esotericnonsense> it's kind of obvious, but I'm realising that if I expose getnewaddress, sendtoaddress, and maybe a QR code in my interface, you have an android wallet that's backed by bitcoin core
< esotericnonsense> has anyone (other than the ABCore project) made a mobile wallet based on bitcoin core, e.g. remote?

2018-11-08

< bitcoin-git> [bitcoin] DrahtBot closed pull request #9298: [Wallet] use CHDPubKey, don't store child priv keys in db, derive on the fly (master...2016/12/hd_no_priv) https://github.com/bitcoin/bitcoin/pull/9298
< bitcoin-git> [bitcoin] DrahtBot closed pull request #10896: Optimize compact reconstruction somewhat (master...2017-07-faster-compact-reconstruction) https://github.com/bitcoin/bitcoin/pull/10896
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14693: test_node: get_mem_rss fixups (master...Mf1811-qaTestNodeFixups) https://github.com/bitcoin/bitcoin/pull/14693
< esotericnonsense> and then it's "someone else's job" to maintain the bitcoin library to RPC shim which ensures RPC backward compatibility
< gwillen> one possible alternative I can think of would be to give bitcoin-cli a way to talk to multiple backends
< kanzure> RPC is used by many companies as the only interface to bitcoin at all; not sure i understand the scope of discussion about moving RPC into another utility or project but yeah be careful i guess.
< gribble> https://github.com/bitcoin/bitcoin/issues/14623 | [RFC] Built-in RNG design · Issue #14623 · bitcoin/bitcoin · GitHub
< luke-jr> MarcoFalke: we do have bitcoin-tx
< gribble> https://github.com/bitcoin/bitcoin/issues/14476 | RPC method encodescript by mrwhythat · Pull Request #14476 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddress RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
< wumpus> I'm just trying to prevent the codebase complicating even more, I mean, I think we should focus on consensus issues in bitcoin core, it's hard enough
< gwillen> for utility stuff that doesn't go in bitcoin core, is there some way to make it available to end-users who are not developers?
< phantomcircuit> gwillen, see bitcoin-tx
< wumpus> it could be completely separate from bitcoin core
< wumpus> provoostenator: that RPC is useful is not the discussion, does it need to be in bitcoin core!
< luke-jr> bitcoin-cli add 1 2
< provoostenator> luke-jr yes, so we can claim that Bitcoin Core is turning complete :-P
< esotericnonsense> luke-jr: bitcoin-cli 1 2 add surely. RPN-RPC.
< sipa> i think that bitcoin core, for better or worse, implements certain featuresets - and it makes sense to implement those features completely, even if some are stateless
< sipa> descriptors are a bitcoin core specific thing (at least for now), it would be trivial amount of code to implement given the existing infrastructure, but a lot of work to do elsewhere
< jnewbery> I think having duplicate code that does basically the same thing can be problematic. We've already had issues where bitcoin-tx has fallen out of sync with the equivalent RPC methods.
< gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddress RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14476 | RPC method encodescript by mrwhythat · Pull Request #14476 · bitcoin/bitcoin · GitHub
< promag> bitcoin-qt already exposes RPC functionality without network overhead
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< meshcollider> Quick topic: EOL date for 0.15 https://github.com/bitcoin-core/bitcoincore.org/pull/630
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | ~~Correctly~~ terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14623 | [RFC] Built-in RNG design · Issue #14623 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 anything to add or remove?
< gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< gribble> https://github.com/bitcoin/bitcoin/issues/14437 | Refactor: Start to separate wallet from node by ryanofsky · Pull Request #14437 · bitcoin/bitcoin · GitHub
< sipa> ezzzy: off topic here, as this channel is about bitcoin core specifically, but you may find help on https://bitcoin.stackexchange.com
< sipa> but implementing the P2P protocol... follow the bitcoin.org developer docs
< ezzzy> would you people suggest en.bitcoin.it or bitcoin.org as a reference for the protocol (for client implementors)?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14684: [doc] conf: Remove deprecated options from docs, Other cleanup (master...Mf1609-trivialPre14) https://github.com/bitcoin/bitcoin/pull/14684
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e52781067bb4...e70a19e7132d
< bitcoin-git> bitcoin/master fa4da3c MarcoFalke: [doc] conf: Remove deprecated options from docs, Other cleanup...
< bitcoin-git> bitcoin/master e70a19e MarcoFalke: Merge #14684: [doc] conf: Remove deprecated options from docs, Other cleanup...
< bitcoin-git> [bitcoin] conscott opened pull request #14691: Speedup feature_pruning test and refactor big transaction logic (master...2018_11_opreturn_splices) https://github.com/bitcoin/bitcoin/pull/14691
< gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #14689: Require a public key to be retrieved when signing a P2PKH input (master...fix-pkh-pubkeys) https://github.com/bitcoin/bitcoin/pull/14689
< bitcoin-git> [bitcoin] harding opened pull request #14688: Doc: update release notes for changes since 0.17.0 branch (master...2018-11-release-notes) https://github.com/bitcoin/bitcoin/pull/14688
< bitcoin-git> [bitcoin] mruddy opened pull request #14687: zmq: enable tcp keepalive (master...zmq-keep-alive) https://github.com/bitcoin/bitcoin/pull/14687
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14172 | Refactor and add tests for BlockFilter construction by jimpo · Pull Request #14172 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub

2018-11-07

< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< dondreyt> I'm currently in the process of doing some debugging of Bitcoin Core. Is there a way to output a CScript to console, in particular a public key signature as a string representation of hexadecimal?
< ezzzy> are there any up-to-date resources documenting the bitcoin protocol, except of en.bitcoin.it/wiki/Protocol_documentation?
< instagibbs> https://github.com/bitcoin/bitcoin/pull/14678 turns out it was just redundancy, not a bug
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d26d15c6c89a...11e1ac3ae085