2019-07-23

< elichai2> sipa: FYI https://github.com/rust-bitcoin/rust-secp256k1/pull/132 from my very non serious benchmarks it seem to be 10-15 precent faster in verification
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438

2019-07-22

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
< Raystonn> luke-jr: Is your Bitcoin Core development platform running an ARM processor?
< cfields> Did anyone manage to fetch the v0.18.1rc1 tag from bitcoin-detached-sigs ?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16437: Always connect NotifyEntryRemoved with MempoolEntryRemoved (master...1907-AlwaysNotifyMempoolEntryRemoved) https://github.com/bitcoin/bitcoin/pull/16437
< dongcarl> provoostenator: I haven't backported to 0.18.1 yet, but good reminder that I should allow building of any bitcoin git repo, not just the current tree!
< dongcarl> jonasschnelli: btw just so you're aware, we have #bitcoin-builds
< dongcarl> This is just speculating a little, I don't know what's really wrong till I have a `ldd bitcoin-qt` or something
< dongcarl> jonasschnelli: Let me know 1. If `bitcoin-qt` starts by itself 2. what the output of `ldd bitcoin-qt` is
< dongcarl> Does `bitcoin-qt` start at least?
< bitcoin-git> [bitcoin] hebasto opened pull request #16436: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
< bitcoin-git> [bitcoin] dongcarl opened pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
< gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar closed pull request #15505: [p2p] Request NOTFOUND transactions immediately from other outbound peers, when possible (master...2019-02-notfound-requests) https://github.com/bitcoin/bitcoin/pull/15505
< bitcoin-git> [bitcoin] domob1812 opened pull request #16434: Specify AM_CPPFLAGS for ZMQ (master...zmq-cppflags) https://github.com/bitcoin/bitcoin/pull/16434
< gribble> https://github.com/bitcoin/bitcoin/issues/16366 | init: Use InitError for all errors in bitcoind/qt by MarcoFalke · Pull Request #16366 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16433: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN (master...1907-txmempoolNoUnknownDefault) https://github.com/bitcoin/bitcoin/pull/16433
< bitcoin-git> [bitcoin] hebasto opened pull request #16432: qt: Add privacy to the Overview page (master...20190721-privacy) https://github.com/bitcoin/bitcoin/pull/16432
< bitcoin-git> [bitcoin] torkelrogstad closed pull request #16076: Docs: Add note on precedence of options in bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16076

2019-07-21

< achow101> sipa: meshcollider: any thoughts on how labels should work with imported descriptors? Issue is with labels being applied to newly generated addresses in a descriptor that is set as "active". For some context: https://github.com/achow101/bitcoin/pull/4#discussion_r305564366
< bitcoin-git> [bitcoin] cryptogopher opened pull request #16431: Allow proper linearize-data execution on pruned node (master...master) https://github.com/bitcoin/bitcoin/pull/16431
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16430: doc: Update bips 35, 37 and 111 status (master...1907-docBips) https://github.com/bitcoin/bitcoin/pull/16430
< bitcoin-git> [bitcoin] fanquake closed pull request #16429: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/16429
< bitcoin-git> [bitcoin] hassanwaleed82 opened pull request #16429: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/16429
< bitcoin-git> [bitcoin] fanquake closed pull request #16428: Fix typos across bitcoin repository (master...typo-fixes) https://github.com/bitcoin/bitcoin/pull/16428
< bitcoin-git> [bitcoin] kittenking opened pull request #16428: Fix Typos across bitcoin repository (master...typo-fixes) https://github.com/bitcoin/bitcoin/pull/16428

2019-07-20

< kallewoof> I am considering volunteering to help out the bitcoin/bips repository. It has 108 open PRs, dating back to 2015. Who besides Luke is maintaining that?
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.1rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.1rc1
< gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
< wumpus> aj: yes, I've solved the issue, it was due to a freebsd package upgrade invalidating the boost shared libraries while invoking bitcoin-cli, so it was trying to parse the wrong thing :-)
< wumpus> aj: 'Shared object "libboost_system.so.1.69.0" not found, required by "bitcoin-cli"' doesn't look like a getblockchaininfo response
< aj> wumpus: "bitcoin-cli getblockchaininfo: invalid response" -- did you resolve that? it looks like that's a "couldn't parse the response as json" error, maybe bitcoind is still starting up?
< bitcoin-git> [bitcoin] ariard opened pull request #16426: Remove Chain::Lock interface (master...2019-07-remove-more-locking-chain) https://github.com/bitcoin/bitcoin/pull/16426
< emilengler> Is Bitcoin Core installing to /usr/local by default? Or does it install to /usr/bin if /usr/local does not exists

2019-07-19

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
< sipa> we use 256-bit values here and there in bitcoin :)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
< bitcoin-git> [bitcoin] laanwj merged pull request #15681: [mempool] Allow one extra single-ancestor transaction per package (master...2019-03-lightning-policy) https://github.com/bitcoin/bitcoin/pull/15681
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b1fe7165c8...51a6e2c41929
< bitcoin-git> bitcoin/master 50cede3 Matt Corallo: [mempool] Allow one extra single-ancestor transaction per package
< bitcoin-git> bitcoin/master 51a6e2c Wladimir J. van der Laan: Merge #15681: [mempool] Allow one extra single-ancestor transaction per pa...
< achow101> Could someone help me figure out where the memory leak being reported here is: https://travis-ci.org/bitcoin/bitcoin/jobs/560780816 ?
< wumpus> bitcoin-cli getblockchaininfo: invalid response
< gribble> https://github.com/bitcoin/bitcoin/issues/15681 | [mempool] Allow one extra single-ancestor transaction per package by TheBlueMatt · Pull Request #15681 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/063c8ce7a054...a6cba19831da
< bitcoin-git> bitcoin/0.18 641b2ff Wladimir J. van der Laan: qt: pre-rc1 translations update
< bitcoin-git> bitcoin/0.18 aa2d12a Wladimir J. van der Laan: build: Bump version to 0.18.1rc1
< bitcoin-git> bitcoin/0.18 a6cba19 Wladimir J. van der Laan: doc: Update manpages for rc1
< gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/3f76160087c0...063c8ce7a054
< bitcoin-git> bitcoin/0.18 063c8ce tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
< bitcoin-git> [bitcoin] laanwj merged pull request #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (master...bitcoin-poll) https://github.com/bitcoin/bitcoin/pull/16412
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7b7cf299a9e...f4b1fe7165c8
< bitcoin-git> bitcoin/master a52818c tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
< bitcoin-git> bitcoin/master f4b1fe7 Wladimir J. van der Laan: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN e...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59ce537a4994...c7b7cf299a9e
< bitcoin-git> bitcoin/master 5c3c24c zenosage: test: remove redundant setup in addrman_tests
< bitcoin-git> bitcoin/master c7b7cf2 MarcoFalke: Merge #16422: test: remove redundant setup in addrman_tests
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
< fanquake> jonasschnelli: Interesting. Is the source for the site going to live here: https://github.com/jonasschnelli/bitcoin-core-ci?
< jonasschnelli> Would someone mind if I add a webhook to bitcoin/bitcoin (a "readonly" webhook) to drive the CI i have built in the last weeks?
< bitcoin-git> [bitcoin] fanquake merged pull request #16152: Disable bloom filtering by default. (master...2019-06-fix-dos) https://github.com/bitcoin/bitcoin/pull/16152
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/89d7229c9c18...59ce537a4994
< bitcoin-git> bitcoin/master 5efcb77 Matt Corallo: Disable bloom filtering by default.
< bitcoin-git> bitcoin/master f27309f Matt Corallo: Move DEFAULT_PEERBLOOMFILTERS from validation.h to net_processing.h
< bitcoin-git> bitcoin/master bead32e Matt Corallo: Add release notes for DEFAULT_BLOOM change
< kallewoof> Just me or is travis not creating new jobs when pushing to a PR branch..? (it creates local instances for my own repo but not for bitcoin).
< jonasschnelli> MarcoFalke: are you sure CCACHE_SIZE is the right directive: https://github.com/bitcoin/bitcoin/blob/master/.travis.yml#L49?
< kallewoof> Would it be horrible to remove the assume valid stuff from bitcoin core? It feels like signature validation is pretty fast these days.
< bitcoin-git> [bitcoin] fanquake merged pull request #16420: QA: Fix race condition in wallet_encryption test (master...2019/07/wallet_enc_test_fix) https://github.com/bitcoin/bitcoin/pull/16420
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5abb59a9a66...89d7229c9c18
< bitcoin-git> bitcoin/master 024ecd7 Jonas Schnelli: QA: Fix race condition in wallet_encryption test
< bitcoin-git> bitcoin/master 89d7229 fanquake: Merge #16420: QA: Fix race condition in wallet_encryption test
< bitcoin-git> [bitcoin] zenosage opened pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422

2019-07-18

< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16323: Call ProcessNewBlock() asynchronously (master...2019-07-background-pnb) https://github.com/bitcoin/bitcoin/pull/16323
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16421: Conservatively accept RBF bumps bumping one tx at the package limits (master...2019-07-lightning-policy-bump) https://github.com/bitcoin/bitcoin/pull/16421
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16415: Get rid of PendingWalletTx class (master...pr/nopend) https://github.com/bitcoin/bitcoin/pull/16415
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16415: Get rid of PendingWalletTx class (master...pr/nopend) https://github.com/bitcoin/bitcoin/pull/16415
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #16420: QA: Fix race condition in wallet_encryption test (master...2019/07/wallet_enc_test_fix) https://github.com/bitcoin/bitcoin/pull/16420
< gribble> https://github.com/bitcoin/bitcoin/issues/16328 | rpc: Tidy up reporting of buried and ongoing softforks by MarcoFalke · Pull Request #16328 · bitcoin/bitcoin · GitHub
< kallewoof> luke-jr: if you need anything from me on https://github.com/bitcoin/bips/pull/803 let me know. I believe I answered your statement in https://github.com/bitcoin/bips/pull/803#discussion_r304880606
< gribble> https://github.com/bitcoin/bitcoin/issues/16400 | [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16401 | Package relay by sdaftuar · Pull Request #16401 · bitcoin/bitcoin · GitHub
< tryphe> looking for a relabel, and some brainstorming around file handle counts, if possible: https://github.com/bitcoin/bitcoin/pull/16003 :)
< MarcoFalke> sdaftuar: It is mentioned on bitcoin.org
< gribble> https://github.com/bitcoin/bitcoin/issues/15706 | build: Check QT library version by lucayepa · Pull Request #15706 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16412 | net: Make poll in InterruptibleRecv only filter for POLLIN events. by tecnovert · Pull Request #16412 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15911 | Use wallet RBF default for walletcreatefundedpsbt by Sjors · Pull Request #15911 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
< sdaftuar> if you only analyze this from the perspective of the latest version of Bitcoin Core, for instance, you only get a one-sided view
< gribble> https://github.com/bitcoin/bitcoin/issues/16409 | Remove mempool expiry, treat txs as replaceable instead by MarcoFalke · Pull Request #16409 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16355 | refactor: move CCoinsViewErrorCatcher out of init.cpp by jamesob · Pull Request #16355 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] hebasto opened pull request #16416: Negated -datadir option implies default datadir (master...20190718-nodatadir) https://github.com/bitcoin/bitcoin/pull/16416
< bitcoin-git> [bitcoin] ryanofsky opened pull request #16415: Get rid of PendingWalletTx class (master...pr/nopend) https://github.com/bitcoin/bitcoin/pull/16415
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #16414: 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (0.18...2019-07-backport-16322) https://github.com/bitcoin/bitcoin/pull/16414
< gribble> https://github.com/bitcoin/bitcoin/issues/15990 | Add tests and documentation for blocksonly by MarcoFalke · Pull Request #15990 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16412 | net: Make poll in InterruptibleRecv only filter for POLLIN events. by tecnovert · Pull Request #16412 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15778 | [wallet] Move maxtxfee from node to wallet by jnewbery · Pull Request #15778 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16322 | wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16322 · bitcoin/bitcoin · GitHub
< promag> regarding 0.18.1, just to be clear, https://github.com/bitcoin/bitcoin/pull/13339#issuecomment-504653790 is a no go?
< bitcoin-git> [bitcoin] fanquake merged pull request #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's callback (0.18...2019-07-backport-16405) https://github.com/bitcoin/bitcoin/pull/16406
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/410774ab89fd...3f76160087c0
< bitcoin-git> bitcoin/0.18 b2711b9 João Barbosa: fix: tor: Call event_base_loopbreak from the event's callback
< bitcoin-git> bitcoin/0.18 3f76160 fanquake: Merge #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's c...
< gribble> https://github.com/bitcoin/bitcoin/issues/16409 | Remove mempool expiry, treat txs as replaceable instead by MarcoFalke · Pull Request #16409 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16379: Fix autostart filenames on Linux for testnet/regtest (master...20190712-fix-autostart) https://github.com/bitcoin/bitcoin/pull/16379
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65d12110d43a...e5abb59a9a66
< bitcoin-git> bitcoin/master ae311bc Hennadii Stepanov: Fix autostart filenames on Linux
< bitcoin-git> bitcoin/master e5abb59 Wladimir J. van der Laan: Merge #16379: Fix autostart filenames on Linux for testnet/regtest
< bitcoin-git> [bitcoin] THETCR opened pull request #16413: depends: Bump QT to LTS release 5.9.8 (master...qt-lts) https://github.com/bitcoin/bitcoin/pull/16413
< bitcoin-git> [bitcoin] laanwj merged pull request #16405: fix: tor: Call event_base_loopbreak from the event's callback (master...2019-07-fix-break-before-dispatch) https://github.com/bitcoin/bitcoin/pull/16405
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0515406acb5d...65d12110d43a
< bitcoin-git> bitcoin/master a981e74 João Barbosa: fix: tor: Call event_base_loopbreak from the event's callback
< bitcoin-git> bitcoin/master 65d1211 Wladimir J. van der Laan: Merge #16405: fix: tor: Call event_base_loopbreak from the event's callbac...
< bitcoin-git> [bitcoin] tecnovert opened pull request #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (master...bitcoin-poll) https://github.com/bitcoin/bitcoin/pull/16412
< bitcoin-git> [bitcoin] kallewoof opened pull request #16411: Signet support (master...signet) https://github.com/bitcoin/bitcoin/pull/16411
< kallewoof> luke-jr: are you around to give feedback/potential number assignment to/of https://github.com/bitcoin/bips/pull/803 ?
< bitcoin-git> [bitcoin] fanquake merged pull request #16374: test: Enable passing wildcard test names to test runner from root (master...enable-passing-wildcard-files-to-test-runner-from-root) https://github.com/bitcoin/bitcoin/pull/16374
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/459baa1756b7...0515406acb5d
< bitcoin-git> bitcoin/master 6a7a70b Jon Atack: test: enable passing wildcards with path to test runner
< bitcoin-git> bitcoin/master e142ee0 Jon Atack: doc: describe how to pass wildcard names to test runner
< bitcoin-git> bitcoin/master 0515406 fanquake: Merge #16374: test: Enable passing wildcard test names to test runner from...

2019-07-17

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409
< bitcoin-git> [bitcoin] dongcarl opened pull request #16408: depends: Prune X packages (master...2019-07-depends-X-pruning) https://github.com/bitcoin/bitcoin/pull/16408
< bitcoin-git> [bitcoin] promag opened pull request #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's callback (0.18...2019-07-backport-16405) https://github.com/bitcoin/bitcoin/pull/16406
< bitcoin-git> [bitcoin] promag opened pull request #16405: fix: tor: Call event_base_loopbreak from the event's callback (master...2019-07-fix-break-before-dispatch) https://github.com/bitcoin/bitcoin/pull/16405
< bitcoin-git> [bitcoin] promag opened pull request #16404: qa: Test ZMQ notification after chain reorg (master...2019-07-zmq-reorg) https://github.com/bitcoin/bitcoin/pull/16404
< bitcoin-git> [bitcoin] meshcollider merged pull request #16208: wallet: Consume ReserveDestination on successful CreateTransaction (master...createtransaction_keepkey) https://github.com/bitcoin/bitcoin/pull/16208
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/24dbcf380844...459baa1756b7
< bitcoin-git> bitcoin/master d9ff862 Gregory Sanders: CreateTransaction calls KeepDestination on ReserveDestination before succe...
< bitcoin-git> bitcoin/master e10e1e8 Gregory Sanders: Restrict lifetime of ReserveDestination to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 459baa1 MeshCollider: Merge #16208: wallet: Consume ReserveDestination on successful CreateTrans...

2019-07-16

< gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16306 | gui: crash in Console after loading & unloading wallet · Issue #16306 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16402: Remove wallet settings from chainparams (master...1907-walletNoChainParams) https://github.com/bitcoin/bitcoin/pull/16402
< bitcoin-git> [bitcoin] sdaftuar opened pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400
< bitcoin-git> [bitcoin] sdaftuar opened pull request #16401: Package relay (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15891: test: Require standard txs in regtest by default (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8f604361ebaa...24dbcf380844
< bitcoin-git> bitcoin/master fa613ca MarcoFalke: chainparams: Remove unused fMineBlocksOnDemand
< bitcoin-git> bitcoin/master fa9b419 MarcoFalke: test: Add test that mainnet requires standard txs
< bitcoin-git> bitcoin/master fa89bad MarcoFalke: test: Require standard txs in regtest
< bitcoin-git> [bitcoin] hebasto closed pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< bitcoin-git> [bitcoin] fjahr opened pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
< bitcoin-git> [bitcoin] laanwj merged pull request #16194: refactor: share blockmetadata with BlockManager (master...2019-06-au-blockman) https://github.com/bitcoin/bitcoin/pull/16194
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8f9725c83f1d...8f604361ebaa
< bitcoin-git> bitcoin/master 613c46f James O'Beirne: refactoring: move block metadata structures into BlockManager
< bitcoin-git> bitcoin/master 4ed55df James O'Beirne: refactoring: add block_index_candidates arg to LoadBlockIndex
< bitcoin-git> bitcoin/master 55d525a James O'Beirne: refactoring: make pindexBestInvalid internal to validation.cpp
< sipa> stevenroose: what version of bitcoin core?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13804: WIP: Transaction Pool Layer (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/13804
< bitcoin-git> [bitcoin] stevenroose opened pull request #16397: Clarify includeWatching for fundrawtransaction (master...fundraw-includewatching) https://github.com/bitcoin/bitcoin/pull/16397
< stevenroose> promag: can you do multiwallet witn bitcoin-cli without having to change the url in the config file?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29082e8f40c3...8f9725c83f1d
< bitcoin-git> bitcoin/master 1a62425 João Barbosa: qa: Add --filter option to test_runner.py
< bitcoin-git> bitcoin/master 8f9725c MarcoFalke: Merge #16390: qa: Add --filter option to test_runner.py
< pinheadmz> I'm getting a leveldb checksum mismatch error `Fatal LevelDB error: Corruption: block checksum mismatch: /home/pi/.bitcoin/chainstate/2109327.ldb` but only when I shutdown with RPC stop... Since the error is in chainstate, can I try with -reindex ? Or do I need to redownload the chain...?
< bitcoin-git> [bitcoin] fanquake merged pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d37ed888e34...29082e8f40c3
< bitcoin-git> bitcoin/master fa0d0ff MarcoFalke: Remove unused bits from the service flags enum
< bitcoin-git> bitcoin/master 29082e8 fanquake: Merge #16380: Remove unused bits from the service flags enum

2019-07-15

< sipa> and if your end goal is integrating things into bitcoin core, i suspect getting familiar with the code is probably the best way to spend time now
< elichai2> don't you think that bitcoin core wallet should be like a reference for other wallets? because in that case other wallets got it faster :/
< sipa> well if you want to learn bitcoin core better (which i very much encourage you to!), i think it's better to focus on one piece at a time, but actually integrate it
< elichai2> because I still think that manual psbt without descriptors is still useful? altough you're right that I could've done it in rust-bitcoin and it would probabaly been easier and more native to the code but in the end I do want to get to know bitcoin core's code better so I will be able to make optimal solutions to bitcoin in the future :)
< sipa> so why do it in bitcoin core at all then?
< elichai2> and way more work. I'm trying to concentrate around PSBT for now. so i'm using `createpsbt` as a "hack" because that's the only psbt RPC command that doesn't relay on the wallet. (I'll probably move that logic to a seperate "createrawpsbt" or a `bitcoin-psbt` bin)
< bitcoin-git> [bitcoin] achow101 opened pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git> [bitcoin] laanwj merged pull request #15824: docs: Improve netbase comments (master...2019-04-netbase-comments) https://github.com/bitcoin/bitcoin/pull/15824
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0822b44d8a68...6d37ed888e34
< bitcoin-git> bitcoin/master c7f6ce7 Carl Dong: docs: Improve netbase comments
< bitcoin-git> bitcoin/master 6d37ed8 Wladimir J. van der Laan: Merge #15824: docs: Improve netbase comments
< sipa> it seems highly unlikely that a change to the monetary policy will ever happen in bitcoin
< Raystonn> Bitcoin must remain <= 21 million coins.
< sipa> bitcoin does not have sub-satoshi units
< sipa> and again, bitcoin's consensus rules don't permit amounts above 2100000000000000 units
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/536590f358dc...0822b44d8a68
< bitcoin-git> bitcoin/master 8f250ab Steven Roose: TEST: Replace hard-coded hex tx with classes
< bitcoin-git> bitcoin/master 0822b44 MarcoFalke: Merge #15282: test: Replace hard-coded hex tx with class in test framework...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15282: test: Replace hard-coded hex tx with class in test framework (master...util-messages) https://github.com/bitcoin/bitcoin/pull/15282
< bitcoin-git> [bitcoin] fanquake opened pull request #16392: WIP build: macOS toolchain update (master...macos-toolchain-update) https://github.com/bitcoin/bitcoin/pull/16392
< fanquake> Does anyone know why Travis gets marked as failing, even though all tests are passing? i.e https://travis-ci.org/bitcoin/bitcoin/builds/558768209 is all green, but I see red in the GitHub UI (#16386) .It seems that running the extended lint stage will kick it over to green though..
< gribble> https://github.com/bitcoin/bitcoin/issues/16386 | depends: disable unused Qt features by fanquake · Pull Request #16386 · bitcoin/bitcoin · GitHub

2019-07-14

< bitcoin-git> [bitcoin] promag opened pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
< bitcoin-git> [bitcoin] hebasto opened pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< gribble> https://github.com/bitcoin/bitcoin/issues/16387 | macOS Catalina · Issue #16387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #16386: depends: disable unused Qt features (master...slim_qt_597) https://github.com/bitcoin/bitcoin/pull/16386

2019-07-13

< bitcoin-git> [bitcoin] jb55 opened pull request #16383: rpcwallet: default include_watchonly to true for watchonly wallets (master...20190713-watchonly-defaults) https://github.com/bitcoin/bitcoin/pull/16383
< bitcoin-git> [bitcoin] hebasto opened pull request #16381: Set minimum required Boost to 1.53.0 (master...20190713-bump-minimum-boost) https://github.com/bitcoin/bitcoin/pull/16381

2019-07-12

< bitcoin-git> [bitcoin] laanwj merged pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3453cf26dbaf...536590f358dc
< bitcoin-git> bitcoin/master 604e2a9 Carl Dong: test: rpc_users: Add function for auth'd requests.
< bitcoin-git> bitcoin/master c73d871 Carl Dong: test: rpc_users: Add function for testing auth params.
< bitcoin-git> bitcoin/master 830dc2d Carl Dong: test: rpc_users: Also test rpcauth.py with specified password.
< emilengler> Can someone help me? I'm currently stucking at a PR and I have no idea why the travis build is failing on the tests (https://travis-ci.org/bitcoin/bitcoin/jobs/557960750)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< dongcarl> achow101: This section was written specifically for you: https://github.com/bitcoin/bitcoin/tree/master/contrib/guix#speeding-up-builds-with-substitute-servers
< instagibbs> achow101, https://github.com/bitcoin/bitcoin/tree/master/contrib/guix looks like you're supposed ot be able to use it
< bitcoin-git> [bitcoin] laanwj merged pull request #15277: contrib: Enable building in Guix containers (master...2019-01-guix) https://github.com/bitcoin/bitcoin/pull/15277
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/735d6b57e795...3453cf26dbaf
< bitcoin-git> bitcoin/master 3e80ec3 Carl Dong: contrib: Add deterministic Guix builds.
< bitcoin-git> bitcoin/master 8dff3e4 Carl Dong: contrib: guix: Clarify SOURCE_DATE_EPOCH.
< bitcoin-git> bitcoin/master cd3e947 Carl Dong: contrib: guix: Various improvements.
< bitcoin-git> [bitcoin] laanwj closed pull request #16310: refactor: small optimization for IsHex method (master...master) https://github.com/bitcoin/bitcoin/pull/16310
< bitcoin-git> [bitcoin] hebasto opened pull request #16379: Fix autostart filenames Linux for testnet/regtest (master...20190712-fix-autostart) https://github.com/bitcoin/bitcoin/pull/16379
< gribble> https://github.com/bitcoin/bitcoin/issues/16152 | Disable bloom filtering by default. by TheBlueMatt · Pull Request #16152 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
< bitcoin-git> [bitcoin] Sjors opened pull request #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt (master...2019/07/walletcreatefundedpsbt_addinputs) https://github.com/bitcoin/bitcoin/pull/16377
< fanquake> Hopefully no-one has to clean any toilets.. https://github.com/bitcoin/bitcoin/pull/16248#issuecomment-510831024

2019-07-11

< bitcoin-git> [bitcoin] antigaius closed pull request #16375: secp256k1/src/tests.c: Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
< bitcoin-git> [bitcoin] antigaius opened pull request #16375: secp256k1/src/tests.c: Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13947: Dandelion transaction relay (BIP 156) (master...Mf1804-dandelion) https://github.com/bitcoin/bitcoin/pull/13947
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13903: Significantly reduce GetTransaction cs_main locking (TheBlueMatt) (master...Mf1808-ReadBlockFromDiskCsMain) https://github.com/bitcoin/bitcoin/pull/13903
< gribble> https://github.com/bitcoin/bitcoin/issues/16301 | Use CWallet::Import* functions in all import* RPCs by achow101 · Pull Request #16301 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16227: Refactor CWallet's inheritance chain (master...rm-keystores) https://github.com/bitcoin/bitcoin/pull/16227
< bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/28d1353f4837...735d6b57e795
< bitcoin-git> bitcoin/master 1b699a5 Andrew Chow: Add HaveKey and HaveCScript to SigningProvider
< bitcoin-git> bitcoin/master c7797ec Andrew Chow: Remove CKeyStore and squash into CBasicKeyStore
< bitcoin-git> bitcoin/master a913e3f Andrew Chow: Move HaveKey static function from keystore to rpcwallet where it is used
< gribble> https://github.com/bitcoin/bitcoin/issues/16227 | Refactor CWallets inheritance chain by achow101 · Pull Request #16227 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #16374: test: Enable passing wildcard test names to test runner from root (master...enable-passing-wildcard-files-to-test-runner-from-root) https://github.com/bitcoin/bitcoin/pull/16374
< bitcoin-git> [bitcoin] laanwj merged pull request #15649: Add ChaCha20Poly1305@Bitcoin AEAD (master...2019/03/chachapoly1305) https://github.com/bitcoin/bitcoin/pull/15649
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fcccdac785e...28d1353f4837
< bitcoin-git> bitcoin/master af5d1b5 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD implementation
< bitcoin-git> bitcoin/master 99aea04 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin tests
< bitcoin-git> bitcoin/master bb326ad Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD benchmark
< sipa> i'm suggesting this because i'd like a bitcoin-psbt tool that you just give psbts and utxos and descriptors and keys and figures out what it can do
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] instagibbs opened pull request #16373: Add bumpfee option to return PSBT instead of commiting to wallet (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
< provoostenator> Some thoughs on how to apply achow101's The Box to hardware wallets: https://github.com/bitcoin/bitcoin/pull/14912#issuecomment-510520757
< jnewbery> provoostenator: from the base bitcoin directory: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do echo $f | xargs -n 1 basename; done)
< bitcoin-git> [bitcoin] fanquake opened pull request #16371: trivial: build: ignore osx_volname & add it to clean-local (master...ignore_osx_volname) https://github.com/bitcoin/bitcoin/pull/16371
< bitcoin-git> [bitcoin] fanquake opened pull request #16370: depends: cleanup package configure flags (master...not_so_great_configure_cleanup) https://github.com/bitcoin/bitcoin/pull/16370

2019-07-10

< bitcoin-git> [bitcoin] ryanofsky opened pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff0aad8a40a0...4fcccdac785e
< bitcoin-git> bitcoin/master 1aecdf2 Andrew Chow: Move wallet creation out of the createwallet rpc into its own function
< bitcoin-git> bitcoin/master 4fcccda MarcoFalke: Merge #16244: Move wallet creation out of the createwallet rpc into its ow...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16361: Remove redundant pre-TopUpKeypool check (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c1e45c4c416...ff0aad8a40a0
< bitcoin-git> bitcoin/master 96b6dd4 Gregory Sanders: Remove redundant pre-TopUpKeypool checks
< bitcoin-git> bitcoin/master ff0aad8 MarcoFalke: Merge #16361: Remove redundant pre-TopUpKeypool check
< instagibbs> please no politics here. timeline for 0.19 here: https://github.com/bitcoin/bitcoin/issues/15940
< sipa> for bitcoin-psbt i'm more thinking something which you give a bunch of information and uses it where useful
< sipa> bitcoin-tx is really "transformation based" thing which you give an input and then specify some transformations to apply
< elichai2> so you think it should be separate from bitcoin-tx
< elichai2> I want to add it to the PSBT standard so that other wallets can start working on support this even before it's in bitcoin core's wallet (assuming of course taproot will get activated)
< sipa> and i think we need a bitcoin-psbt tool that can sign/update a psbt with keys and descriptors
< instagibbs> might be #bitcoin chat, achow101 would know
< elichai2> If I want to add manual psbt constructions support, does it makes sense to have it in `bitcoin-tx`? regular bitcoin core rpc or even a new `bitcoin-psbt`?
< gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16322 | wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16322 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15778 | [wallet] Move maxtxfee from node to wallet by jnewbery · Pull Request #15778 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
< bitcoin-git> [bitcoin] laanwj merged pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d1fc827300e2...6c1e45c4c416
< bitcoin-git> bitcoin/master 5c1b971 João Barbosa: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 1775501 MarcoFalke: wallet: Remove unreachable code in CreateTransaction
< bitcoin-git> bitcoin/master 0d101a3 MarcoFalke: test: Add test for maxtxfee option
< bitcoin-git> [bitcoin] laanwj merged pull request #16270: depends: expat 2.2.7 (master...expat-2-2-7) https://github.com/bitcoin/bitcoin/pull/16270
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5859b7dc6ff5...d1fc827300e2