< GitHub25>
[bitcoin] fanquake opened pull request #8754: [Doc] Target protobuf 2.6 in OS X build notes. (master...osx-protobuf-doc) https://github.com/bitcoin/bitcoin/pull/8754
< gmaxwell>
there are many things which people would like to, I'd suggest reading through the bitcoin core zurich meeting notes for things people are working on/planning on working on.
< jonasschnelli>
You might want to check the bitcoin-qt.m4 macro file
< GitHub3>
[bitcoin] fanquake opened pull request #8743: Remove old manpages from contrib/debian in favour of doc/man (master...remove-old-manpages) https://github.com/bitcoin/bitcoin/pull/8743
< GitHub14>
[bitcoin] fanquake opened pull request #8742: Specify Protobuf version 2 in paymentrequest.proto (master...proto2-vs-proto3) https://github.com/bitcoin/bitcoin/pull/8742
< BlueMatt>
argh ffs...can we all agree to not use github's fancy new review mode thing? it seems to be breaking github's emails as they are no longer threaded together for a single issue...hopefully they can fix in a day or two but they really broke my bitcoin-email workflow :(
< gmaxwell>
would it be unreasonable for us to keep a bitcoin-core keyring file that has the pgp keys of all the regulars around here in it?
< GitHub48>
[bitcoin] laanwj opened pull request #8740: net: No longer send local address in addrMe (master...2016_09_addrfrom_version) https://github.com/bitcoin/bitcoin/pull/8740
< GitHub86>
[bitcoin] paveljanik opened pull request #8737: Trivial: UndoReadFromDisk works on undo files (rev), not on block files. (master...20160915_Undo_error_message_fix) https://github.com/bitcoin/bitcoin/pull/8737
< GitHub156>
[bitcoin] jonasschnelli opened pull request #8735: [Wallet] add option for a custom extended master privat key (xpriv) (master...2016/09/hd_set_seed) https://github.com/bitcoin/bitcoin/pull/8735
< cfields_>
wumpus: lots of work remains. But, mingw depends build fully, and bitcoin build breaks with the same threading problems that have been reported, so it's enough to help with testing/debugging.
< GitHub54>
[bitcoin] rebroad opened pull request #8734: Send NOTFOUND when we don't have the block data. (master...NotfoundIfPruned) https://github.com/bitcoin/bitcoin/pull/8734
< rebroad>
if it's granular enough, then no one should need to add adhoc debug message as you are suggesting... there'd be a debug message already there that they can activate just by editing bitcoin.conf
< wumpus>
if I became really obsessed about this, and wanted this a default part of bitcoin, and became angry if other developers disagreed, that would be an ego commit
< rebroad>
wumpus, i just spend 3 days having to rebase all these debug commits due to changes that were made recently.. I am getting very very fed up with the amount of time wasted rebasing when I could be spending that time adding functionality to bitcoin. this is why this needs to get merged!
< GitHub154>
[bitcoin] rebroad opened pull request #8731: Debug headers received ("block" for new block announcement, "block2" … (master...DebugHeadersReceived) https://github.com/bitcoin/bitcoin/pull/8731
< GitHub64>
[bitcoin] laanwj opened pull request #8730: depends: Add libevent compatibility patch for windows (master...2016_09_libevent_windows_gcc_531) https://github.com/bitcoin/bitcoin/pull/8730
< GitHub174>
[bitcoin] rebroad opened pull request #8726: Move a bunch of fairly verbose debug messages from mempool to mempool2 (master...MoreGranularDebug3) https://github.com/bitcoin/bitcoin/pull/8726
< GitHub12>
[bitcoin] rebroad opened pull request #8725: Split debug for estimatefee into {estimatefee,2} (master...MoreGranularDebug2) https://github.com/bitcoin/bitcoin/pull/8725
< GitHub0>
[bitcoin] laanwj closed pull request #8715: net: only delete CConnman if it's been created (master...fix-connman-shutdown) https://github.com/bitcoin/bitcoin/pull/8715
< GitHub179>
bitcoin/master 881d7ea Wladimir J. van der Laan: Merge #8715: net: only delete CConnman if it's been created...
< GitHub179>
bitcoin/master 36fa01f Cory Fields: net: only delete CConnman if it's been created...
< wumpus>
jonasschnelli: hehe, maybe if bitcoin was designed 10 years earlier
< * jonasschnelli>
thinks we should fork to use CORBA as our bitcoin scripting language and SOAP as http API :}
< wumpus>
many people just use the RPC through curl, or bitcoin-cli, which involves executing an external process per connection per command, and they don't complain either
< dcousens>
but, my point was, even my own implementation has nothing to do bitcoin as such, its just an RPC implementation
< dcousens>
I've found it much easier to just always use a well-tested rpc library than use something "bitcoin tailored"
< gmaxwell>
the standard python bitcoin json library that people get linked to is not at all reliable (gets disconnected and then throws exceptions, and has to be wrapped to be usable) and I don't see anyone even complaining about it.
< dcousens>
bitcoin-cli*, that is
< wumpus>
no interpreters in bitcoin please
< wumpus>
I mean with bitcoin-cli you have full access to bash' scripting/variable munging/etc capabilities, in the Qt console you don't, so this adds a bit of shell power to it
< jonasschnelli>
I think its better to start with it client-side QT only, and if it turns to be useful, add it to bitcoin-cli.
< jonasschnelli>
A better approach for the RPC layer would be to add it into bitcoin-cli
< GitHub132>
[bitcoin] spencerlievens opened pull request #8717: [WALLET] Addition of ImmatureCreditCached to MarkDirty() (master...patch-2) https://github.com/bitcoin/bitcoin/pull/8717
< GitHub83>
[bitcoin] MarcoFalke opened pull request #8716: [qa] wallet: Check legacy wallet as well (master...Mf1609-qaWalletLegacy) https://github.com/bitcoin/bitcoin/pull/8716
< GitHub32>
[bitcoin] theuni opened pull request #8715: net: only delete CConnman if it's been created (master...fix-connman-shutdown) https://github.com/bitcoin/bitcoin/pull/8715
< GitHub171>
bitcoin/master 86726d8 Wladimir J. van der Laan: Rename `-optintofullrbf` option to `-walletrbf`...
< GitHub29>
[bitcoin] laanwj closed pull request #8601: Add option to opt into full-RBF when sending funds (rebase, original by petertodd) (master...2016_08_full_rbf_option) https://github.com/bitcoin/bitcoin/pull/8601
< GitHub171>
bitcoin/master 05fa823 Wladimir J. van der Laan: wallet: Add BIP125 comment for MAXINT-1/-2 behavior
< GitHub171>
bitcoin/master 152f45b Peter Todd: Add option to opt into full-RBF when sending funds
< GitHub42>
[bitcoin] laanwj closed pull request #8608: Install manpages via make install, also add some autogenerated manpages (master...man_automake2) https://github.com/bitcoin/bitcoin/pull/8608
< GitHub32>
bitcoin/master 6edf2fd nomnombtc: add gen-manpages.sh description to README.md
< GitHub32>
bitcoin/master eb5643b nomnombtc: add autogenerated manpages by help2man
< GitHub32>
bitcoin/master d2cd9c0 nomnombtc: add script to generate manpages with help2man
< GitHub2>
[bitcoin] isle2983 opened pull request #8702: [copyright] add MIT License copyright header to remaining Python files (master...misc-copyright) https://github.com/bitcoin/bitcoin/pull/8702
< GitHub127>
[bitcoin] isle2983 opened pull request #8701: [copyright] add MIT License copyright header to zmq_sub.py (master...zmq_sub-copyright) https://github.com/bitcoin/bitcoin/pull/8701
< GitHub94>
[bitcoin] isle2983 opened pull request #8700: [copyright] add MIT license headers to .sh scripts where missing (master...sh-copyright) https://github.com/bitcoin/bitcoin/pull/8700
< TheJoeB>
Please send me a quick message if anyone is interested in a short conversation regarding your personal experiences with Bitcoin and/or Ethereum (any blockchain technology). It shouldn't take longer than 10 minutes and is for my graduate work on these technologies: http://www.thejoeblankenship.com/research-proposal Your privacy, confidentially, and anonymity will be protected.
< GitHub126>
[bitcoin] pstratem opened pull request #8696: [Wallet] Remove last external reference to CWalletDB (master...2016-09-09-cwallet-listaccountcreditdebit) https://github.com/bitcoin/bitcoin/pull/8696
< luke-jr>
"If checked, users with write access to bitcoin/bitcoin can add new commits to your multiwallet branch. You can always change this setting later." … on by default O.o
< GitHub117>
[bitcoin] pstratem opened pull request #8695: Retry feeler connection if OpenNetworkConnection fails in under 1ms. (master...2016-09-09-net-feeler-timeout) https://github.com/bitcoin/bitcoin/pull/8695
< GitHub103>
[bitcoin] sipa opened pull request #8690: Use a heap to not fully sort all nodes for addr relay (master...heapaddrsort) https://github.com/bitcoin/bitcoin/pull/8690
< GitHub91>
[bitcoin] luke-jr opened pull request #8687: Bugfix: RPC/Wallet: removeprunedfunds should flush the wallet db (master...bugfix_removeprunedfunds) https://github.com/bitcoin/bitcoin/pull/8687
< gmaxwell>
and it also means you couldn't use bitcoin anymore on a connection of less than about 50kbit/sec which, otherwise, could keep up with the chain.
< GitHub48>
[bitcoin] laanwj closed pull request #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (master...20160907_Wshadow_8606) https://github.com/bitcoin/bitcoin/pull/8677
< GitHub33>
bitcoin/master 125b946 Pavel Janík: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning.
< GitHub33>
bitcoin/master 4daf02a Wladimir J. van der Laan: Merge #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning....
< CodeShark>
in my ideal world, Bitcoin Core would just do peer discovery, validation, and relay
< CodeShark>
I have a process connect to bitcoin core via p2p which receives inv messages and sends getdata
< midnightmagic>
it should then be in an external library. putting reliable message delivery into bitcoin core would also make the binary liable in the event something (inevitably) goes wrong.
2016-09-08
< BlueMatt>
sipa: https://github.com/TheBlueMatt/bitcoin/commit/96cef326f9184aefd1c562f64a21298a15f0adde simplifies the total diff from master to be more readable, to me...it matches the bip, but another way to look at it is that you have two booleans: which version of compact blocks they want (which you use to send to them) and whether they will send us segwit cmpctblocks...you simply introduce the the do-they-support-v2 bool as an additional
< cfields>
kanzure: and #8680 introduces blocking calls. So you could "./bitcoin-cli waitfornewblock && ./dosomething.sh", which would essentially be blocknotify. Obviously the same could be done for wallet stuff
< kanzure>
so- for example- imagine you are operating a lot of bitcoin infrastructure. you do a bunch of per-block processing. when you are running functional/integration tests, you can't run your test checks immediately after issuing a command because things take a while. so when do you expect to run? well you setup a hook and you ask your infrastructure to ping your tester as soon as the data's available, or you poll for some internal state.
< wumpus>
/home/user/projects/bitcoin/bitcoin/src/test/addrman_tests.cpp:336:471: warning: stack frame size of 328360 bytes in function 'addrman_tests::addrman_delete::test_method' [-Wframe-larger-than=] whoa :) luckily only in the tests
< wumpus>
let's try to make cfields network refactor (https://github.com/bitcoin/bitcoin/pull/8085/files) happen , it's been open so long now, line-wise there's a lot of changes so he keeps having to rebase it