2017-04-24

< bitcoin-git> bitcoin/master 071c955 Wladimir J. van der Laan: wallet: Get rid of fFileBacked...
< bitcoin-git> bitcoin/master be9e1a9 Wladimir J. van der Laan: wallet: Reduce references to global bitdb environment
< bitcoin-git> bitcoin/master 71afe3c Wladimir J. van der Laan: wallet: Introduce database handle wrapper...
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/342b9bc3907e...fa1ac2881f2a
< gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
< fanquake> Since we seem to be giving Boost removal a good shot for 0.15, does anyone have suggestions for replacing GetNumCores? https://github.com/bitcoin/bitcoin/blob/master/src/util.cpp#L881
<@wumpus> "bitcoin mining on mars"
<@wumpus> BlueMatt: ah yes the "apply all the buzzwords to bitcoin mining, see what sticks" approach
< BlueMatt> wumpus: the same bottom-of-the-barrel buzzword bingo that came up with "using normal computers to simulate quantum computers to do bitcoin mining"
< bitcoin-git> [bitcoin] laanwj closed pull request #9792: FastRandomContext improvements and switch to ChaCha20 (master...chacha) https://github.com/bitcoin/bitcoin/pull/9792
< bitcoin-git> bitcoin/master e04326f Pieter Wuille: Add ChaCha20
< bitcoin-git> bitcoin/master 663fbae Pieter Wuille: FastRandom benchmark
< bitcoin-git> bitcoin/master c21cbe6 Pieter Wuille: Introduce FastRandomContext::randbool()
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b25b6df0f08...342b9bc3907e
<@wumpus> "using deep learning frameworks in bitcoin mining", that's hilarious, what bottom-of-the-barrel buzzword factory did that come out of
< bitcoin-git> [bitcoin] kallewoof opened pull request #10267: New -readconfig argument for including external configuration files (master...feature-config-readconfig) https://github.com/bitcoin/bitcoin/pull/10267
< bitcoin-git> [bitcoin] fanquake closed pull request #10266: Update policy.h (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10266
< bitcoin-git> [bitcoin] 1mbtxn opened pull request #10266: Update policy.h (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10266

2017-04-23

< bitcoin-git> [bitcoin] kallewoof opened pull request #10265: [wallet] Check non-null pindex before potentially referencing (master...fix-check-pindex-scanforwallettx) https://github.com/bitcoin/bitcoin/pull/10265
< gmaxwell> Can someone please close: https://github.com/bitcoin/bitcoin/issues/6876
< bitcoin-git> [bitcoin] jimmysong opened pull request #10264: [test] Add tests for getconnectioncount, getnettotals and ping (master...test_netrpccalls) https://github.com/bitcoin/bitcoin/pull/10264
< bitcoin-git> [bitcoin] CryptAxe reopened pull request #10263: Trivial: fix fee estimate write error log message (master...coinbase) https://github.com/bitcoin/bitcoin/pull/10263
< bitcoin-git> [bitcoin] CryptAxe closed pull request #10263: Trivial: fix fee estimate write error log message (master...coinbase) https://github.com/bitcoin/bitcoin/pull/10263
< bitcoin-git> [bitcoin] CryptAxe opened pull request #10263: Trivial: fix fee estimate write error log message (master...coinbase) https://github.com/bitcoin/bitcoin/pull/10263
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10097: Move zmq test skipping logic into individual test case. (master...zmq_optional) https://github.com/bitcoin/bitcoin/pull/10097
< bitcoin-git> bitcoin/master 1b25b6d MarcoFalke: Merge #10097: Move zmq test skipping logic into individual test case....
< bitcoin-git> bitcoin/master 6803e09 John Newbery: Move zmq test skipping logic into individual test case....
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c530c1518063...1b25b6df0f08
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10023: [tests] remove maxblocksinflight.py (functionality covered by other test) (master...improvemaxblocksinflight) https://github.com/bitcoin/bitcoin/pull/10023
< bitcoin-git> bitcoin/master c530c15 MarcoFalke: Merge #10023: [tests] remove maxblocksinflight.py (functionality covered by other test)...
< bitcoin-git> bitcoin/master 5f4bcf2 John Newbery: [tests] Remove maxblocksinflight testcase...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2723bcdce324...c530c1518063
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10224: [test] Add test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
< bitcoin-git> bitcoin/master 2723bcd MarcoFalke: Merge #10224: [test] Add test for getaddednodeinfo...
< bitcoin-git> bitcoin/master bc53752 Jimmy Song: Tests: Add simple test for getaddednodeinfo...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed22eb4a62bd...2723bcdce324
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10258: Fixed typo in documentation for merkleblock.h (master...master) https://github.com/bitcoin/bitcoin/pull/10258
< bitcoin-git> bitcoin/master dd07068 Mikerah: Fixed typo in documentation for merkleblock.h
< bitcoin-git> bitcoin/master ed22eb4 MarcoFalke: Merge #10258: Fixed typo in documentation for merkleblock.h...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8feaa463626...ed22eb4a62bd
< bitcoin-git> [bitcoin] fanquake opened pull request #10260: [doc] Minor corrections to osx dependencies (master...osx-doc-update) https://github.com/bitcoin/bitcoin/pull/10260

2017-04-22

< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10254: [Qt] Remove shutdown poll timer and replace it with a signal (master...2017/04/qt_shutdown) https://github.com/bitcoin/bitcoin/pull/10254
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.14 f2a96e7 Wladimir J. van der Laan: doc: clean out release notes
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/f2a96e7d0289682eb87877a3528cb6a170f8b786
< bitcoin-git> bitcoin/master f8feaa4 Wladimir J. van der Laan: doc: Add historical release notes for 0.14.1
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/f8feaa4636260b599294c7285bcf1c8b7737f74e
< BashCo> getting a 403 on the torrent file? https://bitcoin.org/bin/bitcoin-core-0.14.1/bitcoin-0.14.1.torrent
< sipa> i promise i'll personally try to answer your questions on https://bitcoin.stackexchange.com
<@wumpus> channel topic: Bitcoin Core development discussion and commit log | This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: https://botbot.me/freenode/bitcoin-core-dev, http://www.erisian.com.au/bitcoin-core-dev/
<@wumpus> just ask these things in #bitcoin okay - more people that can answer, or use the stack overflow
< sipa> this channel is aboit development of bitcoin-core
< SopaXorzTaker> sipa, I have to disagree. The question I asked *is* about the Bitcoin Core
< sipa> SopaXorzTaker: bitcoin.stackexchange.com
< SopaXorzTaker> sipa, a question related to the bitcoin core: is the UTXO database initialized when loading the blockchain?
<@wumpus> this channel is about development of the bitcoin core code base, nothing else
< sipa> if you have more questions like this in the future, please go to bitcoin.stackexchange.com... i'll gladly answer there
< SopaXorzTaker> I am asking about the motivation of some Bitcoin design choices
< bitcoin-git> [bitcoin] Mikerah opened pull request #10258: Fixed typo in documentation for merkleblock.h (master...master) https://github.com/bitcoin/bitcoin/pull/10258
< bitcoin-git> [bitcoin] jimmysong opened pull request #10257: [test] Add test for getmemoryinfo (master...test_getmemoryinfo) https://github.com/bitcoin/bitcoin/pull/10257
< achow101> I made dummy github user non-github-bitcoin (https://github.com/non-github-bitcoin) to account for the commits made by the people who committed but don't have github accounts. right now it has sirius-m (github removed it from saracen to allow me to add that account) and lasloh. I'll be asking github to also let me add s_nakamoto which is currently under invalid-email-address. I think it would be prudent to give the repo maintainers
< bitcoin-git> [bitcoin] jimmysong opened pull request #10256: [test] Add gettxout call to wallet.py (master...test_gettxout) https://github.com/bitcoin/bitcoin/pull/10256

2017-04-21

< bitcoin-git> [bitcoin] jimmysong opened pull request #10255: [test] Add test for listaddressgroupings (master...test_listaddressgroupings) https://github.com/bitcoin/bitcoin/pull/10255
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10254: [Qt] Remove shutdown poll timer and replace it with a signal (master...2017/04/qt_shutdown) https://github.com/bitcoin/bitcoin/pull/10254
< bitcoin-git> [bitcoin] jtimon closed pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< jtimon_> wumpus: it seems you added a commit to https://github.com/bitcoin/bitcoin/pull/10201 by mistake?
< bitcoin-git> [bitcoin] jimmysong opened pull request #10253: Tests: Add test for getnetworkhashps (master...test_getnetworkhashps) https://github.com/bitcoin/bitcoin/pull/10253
< bitcoin-git> [bitcoin] luke-jr opened pull request #10252: RPC/Mining: Restore API compatibility for prioritisetransaction (master...rpc_prioritise_api) https://github.com/bitcoin/bitcoin/pull/10252
< bitcoin-git> bitcoin/master a6548a4 Wladimir J. van der Laan: Merge #10201: pass Consensus::Params& to ReceivedBlockTransactions()...
< bitcoin-git> bitcoin/master 25660e9 Mario Dian: pass Consensus::Params& to ReceivedBlockTransactions()
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1428f3030d99...a6548a47a554
< gribble> https://github.com/bitcoin/bitcoin/issues/10199 | Better fee estimates by morcos · Pull Request #10199 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10250: Fix some empty vector references (master...nonnullref) https://github.com/bitcoin/bitcoin/pull/10250
< bitcoin-git> bitcoin/master 1428f30 Wladimir J. van der Laan: Merge #10250: Fix some empty vector references...
< bitcoin-git> bitcoin/master f478d98 Pieter Wuille: Fix some empty vector references...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5352e5e75da9...1428f3030d99
< stoner19> can anyone link me to the actual code for segwit in bitcoin core?
< bitcoin-git> [bitcoin] laanwj closed pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223
< bitcoin-git> bitcoin/master 5352e5e Wladimir J. van der Laan: Merge #10223: Tests: Refactor to create witness script creation function...
< bitcoin-git> bitcoin/master c39a6b9 Jimmy Song: Tests: Refactor to create witness script creation function...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3db4c601385...5352e5e75da9
< bitcoin-git> [bitcoin] laanwj closed pull request #10229: Tests: Add test for getdifficulty (master...test_getdifficulty) https://github.com/bitcoin/bitcoin/pull/10229
< bitcoin-git> bitcoin/master f3db4c6 Wladimir J. van der Laan: Merge #10229: Tests: Add test for getdifficulty...
< bitcoin-git> bitcoin/master 821dd5e Jimmy Song: Tests: Add test for getdifficulty...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27faa6cccd8d...f3db4c601385
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10251: Add balances cache / GUI: use a signal instead of a poll thread (master...2017/04/gui_rm_locks) https://github.com/bitcoin/bitcoin/pull/10251
< jonasschnelli> I'm always surprised what kind of hack from the CoinControl implementation I find: https://github.com/bitcoin/bitcoin/blame/master/src/qt/walletmodel.cpp#L64
<@wumpus> but if it doesn't write bitcoin.conf, well, it's not too bad
< jonasschnelli> I once started a new GUI wizard with pruning: https://github.com/jonasschnelli/bitcoin/commit/7d8798d4942b7d7980a4c4f90cdd714432696ea7
< bitcoin-git> [bitcoin] sipa opened pull request #10250: Fix some empty vector references (master...nonnullref) https://github.com/bitcoin/bitcoin/pull/10250
< sipa> there is something crazy in this reasoning: bitcoin core is too annoying to use due to resource usage, thus people switch to electrum, but then complain they can't easily run their own server... which is even more expensive than just running a full node wallet in the first place
<@wumpus> of course there are more electrum users, that doesn't invalidate anything I said, most people running bitcoin core do not run an electrum server
< bitcoin-git> [bitcoin] sipa opened pull request #10249: Switch CCoinsMap from boost to std unordered_map (master...stdcoinmap) https://github.com/bitcoin/bitcoin/pull/10249
< bitcoin-git> [bitcoin] sipa opened pull request #10248: Introduce CHashVerifier to hash while deserializing (master...chashverifier) https://github.com/bitcoin/bitcoin/pull/10248
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | [qt] Add abstraction layer for accessing node and wallet functionality from gui by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228
< bitcoin-git> bitcoin/master 27faa6c Wladimir J. van der Laan: Merge #10228: build: regenerate bitcoin-config.h as necessary...
< bitcoin-git> bitcoin/master 91ab8f5 Cory Fields: build: fix bitcoin-config.h regeneration after touching build files...
< bitcoin-git> bitcoin/master 3577603 Cory Fields: build: remove wonky auto top-level convenience targets...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6f3b58a7250...27faa6cccd8d
< bitcoin-git> bitcoin/master f6f3b58 Wladimir J. van der Laan: Merge #10242: [qt] Don't call method on null WalletModel object...
< bitcoin-git> [bitcoin] laanwj closed pull request #10242: [qt] Don't call method on null WalletModel object (master...pr/rbfnull) https://github.com/bitcoin/bitcoin/pull/10242
< bitcoin-git> bitcoin/master fb463d1 Russell Yanofsky: [qt] Don't call method on null WalletModel object...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0416ea9f743f...f6f3b58a7250
< bitcoin-git> bitcoin/master 0416ea9 Wladimir J. van der Laan: Merge #10239: Make Boost use std::atomic internally...
< bitcoin-git> bitcoin/master 394ccf7 Pieter Wuille: Make Boost use std::atomic internally
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/694062eafec5...0416ea9f743f
< bitcoin-git> [bitcoin] laanwj closed pull request #10245: Minor fix in build documentation for FreeBSD 11 (master...freebsd-11-build-doc-fix) https://github.com/bitcoin/bitcoin/pull/10245
< bitcoin-git> bitcoin/master 694062e Wladimir J. van der Laan: Merge #10245: Minor fix in build documentation for FreeBSD 11...
< bitcoin-git> bitcoin/master 0611bc3 Shigeya Suzuki: Minor fix in build documentation for FreeBSD 11...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/86ea3c2ff247...694062eafec5
< luke-jr> https://github.com/bitcoin/bitcoin/pull/7107 should probably be reopened

2017-04-20

< bitcoin-git> [bitcoin] practicalswift closed pull request #10246: Silence "warning: "MSG_DONTWAIT" redefined" when compiling under Linux (master...silence-msg_dontwait-warning) https://github.com/bitcoin/bitcoin/pull/10246
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #10246: Silence "warning: "MSG_DONTWAIT" redefined" when compiling under Linux (master...silence-msg_dontwait-warning) https://github.com/bitcoin/bitcoin/pull/10246
< bitcoin-git> [bitcoin] shigeya opened pull request #10245: Minor fix in build documentation for FreeBSD 11 (master...freebsd-11-build-doc-fix) https://github.com/bitcoin/bitcoin/pull/10245
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9343 | Dont create change at dust limit by morcos · Pull Request #9343 · bitcoin/bitcoin · GitHub
< jtimon> wumpus: it seems to interfere with prevector templates in prevector_tests.cpp, see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e for the trick to make the PR pass travis. probably I should remove that commit already, but I wanted to make sure the commits after removing BOOST_REVERSE_FOREACH weren't breaking something else, plus that commit is kind of the link that maybe answers your
< jtimon> wumpus: I'm trying to replace it with https://github.com/bitcoin/bitcoin/pull/10193/commits/1e59de57eecc1a61b036d7f89ff6bf918c2c7f67, which I found in the interwebs but although I thought I fully understood, it seems I don't
< jtimon> regarding https://github.com/bitcoin/bitcoin/pull/10193 I'm still failing at replacing BOOST_REVERSE_FOREACH and I don't understand why, maybe I should reduce the scope of the PR (I moved from working stuff to trying to fully remove boost/foreach.hpp by popular demand)
< bitcoin-git> [bitcoin] laanwj closed pull request #10181: Include cleanup (master...2017-04-10-includes) https://github.com/bitcoin/bitcoin/pull/10181
< bitcoin-git> bitcoin/master 86ea3c2 Wladimir J. van der Laan: Merge #10181: Include cleanup...
< bitcoin-git> bitcoin/master 1c897fc Jorge Timón: Missing includes
< bitcoin-git> bitcoin/master a1fd450 Jorge Timón: Trivial: Remove unneeded includes from .h:...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/14c948987f0b...86ea3c2ff247
< gribble> https://github.com/bitcoin/bitcoin/issues/9343 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/9343 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10244: [qt] Add abstraction layer for accessing node and wallet functionality from gui (master...pr/ipc-local) https://github.com/bitcoin/bitcoin/pull/10244
< gribble> https://github.com/bitcoin/bitcoin/issues/10242 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/10199 | Better fee estimates by morcos · Pull Request #10199 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10242: [qt] Don't call method on null WalletModel object (master...pr/rbfnull) https://github.com/bitcoin/bitcoin/pull/10242
< bitcoin-git> [bitcoin] laanwj closed pull request #9942: Refactor CBlockPolicyEstimator (master...moveTxConfirmStats) https://github.com/bitcoin/bitcoin/pull/9942
< bitcoin-git> bitcoin/master dbb9e36 Alex Morcos: Give CBlockPolicyEstimator it's own lock
< bitcoin-git> bitcoin/master f6187d6 Alex Morcos: Make processBlockTx private.
< bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/987a6c09562e...14c948987f0b
< bitcoin-git> bitcoin/master ae7327b Alex Morcos: Make feeEstimator its own global instance of CBlockPolicyEstimator
< bitcoin-git> [bitcoin] luke-jr closed pull request #7289: [WIP] Make arguments reconfigurable at runtime via RPC (master...rpc_setarg) https://github.com/bitcoin/bitcoin/pull/7289
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9792 | FastRandomContext improvements and switch to ChaCha20 by sipa · Pull Request #9792 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10233 | Wallet: Support not reusing addresses by jet0 · Pull Request #10233 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10231 | [Qt] Reduce a significant cs_main lock freeze by jonasschnelli · Pull Request #10231 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10241: Allow tests to pass even when stderr got populated (master...2017/04/test_stderr) https://github.com/bitcoin/bitcoin/pull/10241
< jonasschnelli> luke-jr: I think its not that: check the signmessage test: https://travis-ci.org/bitcoin/bitcoin/jobs/224004681#L5243
< jonasschnelli> Why do test fail when they are successful: :/ https://travis-ci.org/bitcoin/bitcoin/jobs/224004681#L5249
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10240: [WIP] Add basic HD wallet restore functionality (master...2017/04/hd_rescan) https://github.com/bitcoin/bitcoin/pull/10240
< bitcoin-git> [bitcoin] jnewbery reopened pull request #10198: [tests] Remove is_network_split from functional test framework (master...remove_is_network_split) https://github.com/bitcoin/bitcoin/pull/10198
< bitcoin-git> [bitcoin] sipa opened pull request #10239: Make Boost use std::atomic internally (master...boost_std_atomic) https://github.com/bitcoin/bitcoin/pull/10239
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10238: Change setKeyPool to hold flexible entries (master...2017/04/keypool_fix_a) https://github.com/bitcoin/bitcoin/pull/10238
< bitcoin-git> [bitcoin] laanwj closed pull request #10231: [Qt] Reduce a significant cs_main lock freeze (master...2017/04/qt_freeze) https://github.com/bitcoin/bitcoin/pull/10231
< bitcoin-git> bitcoin/master 610a917 Jonas Schnelli: Declare headers height/time cache mutable, re-set the methods const
< bitcoin-git> bitcoin/master cf92bce Jonas Schnelli: Update the remaining blocks left in modaloverlay at init.
< bitcoin-git> bitcoin/master 7148f5e Jonas Schnelli: Reduce cs_main locks during modal overlay by adding an atomic cache
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/a987def4f629...987a6c09562e
< gribble> https://github.com/bitcoin/bitcoin/issues/10231 | [Qt] Reduce a significant cs_main lock freeze by jonasschnelli · Pull Request #10231 · bitcoin/bitcoin · GitHub
<@wumpus> #10231 gives me a compile error : bitcoin/src/qt/clientmodel.h:85:30: error: implicit instantiation of undefined template
< gmaxwell> jonasschnelli: http://luke.dashjr.org/programs/bitcoin/files/charts/software.html BF using wallets are relatively rare I seldom see more than one connected.
< bitcoin-git> [bitcoin] laanwj closed pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git> bitcoin/master e367ad5 John Newbery: [tests] rename nodehandling to disconnectban
< bitcoin-git> bitcoin/master d6564a2 John Newbery: [tests] fix nodehandling.py flake8 warnings
< bitcoin-git> bitcoin/master 23e6e64 John Newbery: Allow disconnectnode() to be called with node id...
< bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/c91ca0ace9bd...a987def4f629
< bitcoin-git> [bitcoin] laanwj closed pull request #10232: [0.14] release-notes: Accurately explain getblocktemplate improvements (0.14...0.14_relnotes_mining) https://github.com/bitcoin/bitcoin/pull/10232
< NicolasDorier> sipa: Have you considered https://github.com/bitcoin/bitcoin/pull/10148#issuecomment-295599772 ? I think it would make the whole thing a lot easier, with less risk.
< bitcoin-git> bitcoin/0.14 51c787d Warren Togami: Clarify importprivkey help text with example of blank label without rescan...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/51c787dfb4963d2a59dc8944f45e065be0a06613
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #10184: [Wallet] Worst case performance improvement on KeyPool filtering (master...hdinternalperf) https://github.com/bitcoin/bitcoin/pull/10184

2017-04-19

< gribble> https://github.com/bitcoin/bitcoin/issues/10231 | [Qt] Reduce a significant cs_main lock freeze by jonasschnelli · Pull Request #10231 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10207 | Clarify importprivkey help text ... example of blank label without rescan by wtogami · Pull Request #10207 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10235: Track keypool entries as internal vs external in memory (master...2017-04-wallet-more-keypool-cache) https://github.com/bitcoin/bitcoin/pull/10235
< bitcoin-git> [bitcoin] jnewbery opened pull request #10234: [net] listbanned RPC and QT should show correct banned subnets (master...list_banned_correctly) https://github.com/bitcoin/bitcoin/pull/10234
< bitcoin-git> [bitcoin] jet0 opened pull request #10233: Wallet: Support not reusing addresses (master...freezea) https://github.com/bitcoin/bitcoin/pull/10233
< bitcoin-git> [bitcoin] luke-jr opened pull request #10232: release-notes: Accurately explain getblocktemplate improvements (0.14...0.14_relnotes_mining) https://github.com/bitcoin/bitcoin/pull/10232
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10231: [Qt] Reduce a significant cs_main lock freeze (master...2017/04/qt_freeze) https://github.com/bitcoin/bitcoin/pull/10231
< jonasschnelli> cfields: But don't I need https://github.com/bitcoin/bitcoin/issues/10228?
< cfields> jonasschnelli: 10228 just keeps it from happening in the future. Problem is that your bitcoin-config.h is busted atm
< BlueMatt> jonasschnelli: you may still wish to test my branch which is based on that (https://github.com/TheBlueMatt/bitcoin/tree/2017-01-wallet-cache-inmempool-4, I think, though i believe travis didnt like it last time, i need to go back and fix it prior to pring it)
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< jonasschnelli> I think this was re-introduced with https://github.com/bitcoin/bitcoin/pull/9583
< bitcoin-git> [bitcoin] jet0 closed pull request #10230: Merge pull request #1 from bitcoin/master (master...freeze) https://github.com/bitcoin/bitcoin/pull/10230
< bitcoin-git> [bitcoin] jet0 opened pull request #10230: Merge pull request #1 from bitcoin/master (master...freeze) https://github.com/bitcoin/bitcoin/pull/10230
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master c91ca0a Wladimir J. van der Laan: Merge #9827: Improve ScanForWalletTransactions return value...
< bitcoin-git> [bitcoin] laanwj closed pull request #9827: Improve ScanForWalletTransactions return value (master...pr/scanret) https://github.com/bitcoin/bitcoin/pull/9827
< bitcoin-git> bitcoin/master 30abce7 Russell Yanofsky: Improve ScanForWalletTransactions return value...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e96486cbebc6...c91ca0ace9bd
< jonasschnelli> I think this is RFM: https://github.com/bitcoin/bitcoin/pull/9827
< jonasschnelli> Anyone has an opinion on: https://github.com/bitcoin/bitcoin/pull/9502
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
< bitcoin-git> bitcoin/master e96486c Jonas Schnelli: Merge #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf...
< bitcoin-git> bitcoin/master 608bbcc Matt Corallo: [qt] Stop treating coinbase outputs differently: show them at 1conf
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64c45aada702...e96486cbebc6
< bitcoin-git> [bitcoin] laanwj closed pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
< bitcoin-git> bitcoin/master 64c45aa Wladimir J. van der Laan: Merge #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename...
< bitcoin-git> bitcoin/master a4186dd Luke Dashjr: wallet: Use boost to more portably ensure -wallet specifies only a filename
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9111df9673be...64c45aada702
< gribble> https://github.com/bitcoin/bitcoin/issues/10226 | wallet: Use boost to more portably ensure -wallet specifies only a filename by luke-jr · Pull Request #10226 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9524: rpc: Don't FlushStateToDisk when pruneblockchain(0) (master...Mf1701-qaPruning) https://github.com/bitcoin/bitcoin/pull/9524
< gribble> https://github.com/bitcoin/bitcoin/issues/10143 | [net] Allow disconnectnode RPC to be called with node id by jnewbery · Pull Request #10143 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jimmysong opened pull request #10229: Tests: Add test for getdifficulty (master...test_getdifficulty) https://github.com/bitcoin/bitcoin/pull/10229

2017-04-18

< bitcoin-git> [bitcoin] theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< jtimon> btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
< gribble> https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< bitcoin-git> [bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
< bincap> dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
< bincap> luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
<@wumpus> alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
<@wumpus> general questions like that belong in#bitcoin
<@wumpus> yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
< bitcoin-git> [bitcoin] laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
<@wumpus> yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
< sipa> no offence, but this channel is about development of bitcoin core
< jonasschnelli> Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
< bitcoin-git> [bitcoin] kallewoof opened pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
< bitcoin-git> bitcoin/master 9111df9 MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
< bitcoin-git> bitcoin/master 637706d Jimmy Song: Tests: Put Extended tests first when they're included...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
< bitcoin-git> [bitcoin] laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
< bitcoin-git> bitcoin/master a86255b Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
< bitcoin-git> bitcoin/master 846dc17 Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
< bitcoin-git> bitcoin/master 3ddd227 Kalle Alm: [doc] Add blob about finding reviewers.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
< bitcoin-git> [bitcoin] laanwj closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> bitcoin/master 393160c Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
< bitcoin-git> bitcoin/master 75a08e7 Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
< bitcoin-git> bitcoin/master 9141622 Kalle Alm: [rpc] Add abortrescan command to RPC interface.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
< NicolasDorier> Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
< NicolasDorier> will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
< gribble> https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
< NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
< midnightmagic> sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
< bitcoin-git> [bitcoin] jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
< bitcoin-git> [bitcoin] jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223

2017-04-17

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10197: [tests] Functional test warnings (master...functional_test_warnings) https://github.com/bitcoin/bitcoin/pull/10197
< bitcoin-git> bitcoin/master d86bb07 MarcoFalke: Merge #10197: [tests] Functional test warnings...
< bitcoin-git> bitcoin/master 08e51c1 John Newbery: [tests] Remove cache directory by default when running test_runner
< bitcoin-git> bitcoin/master c85b080 John Newbery: [test] add warnings to test_runner
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/50a1cc0f0aef...d86bb075bf6d
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207
< bitcoin-git> bitcoin/master 50a1cc0 MarcoFalke: Merge #10207: Clarify importprivkey help text ... example of blank label without rescan...
< bitcoin-git> bitcoin/master c9e31c3 Warren Togami: Clarify importprivkey help text with example of blank label without rescan...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ce733747e16...50a1cc0f0aef
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
< bitcoin-git> bitcoin/master 6ce7337 MarcoFalke: Merge #10222: [tests] test_runner - check unicode...
< bitcoin-git> bitcoin/master a97ed80 John Newbery: [tests] test_runner - check unicode
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2584925077f9...6ce733747e16
< bitcoin-git> [bitcoin] jnewbery opened pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
< morcos> I'm happy enough to just exclude in all my bitcoin.conf files, but just want to see if everyone else is ok with the leveldb log spam... it prints a lot of useless messages right at startup (where everythign else you care about is printed)
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
<@wumpus> SopaXorzTaker: good sleuthing, but no, you don't have to be afraid I run random scripts from the internet on anything important, let alone bitcoin-related ones
< bitcoin-git> [bitcoin] laanwj closed pull request #10178: Remove CValidationInterface::UpdatedTransaction (master...2017-01-wallet-cache-inmempool-2) https://github.com/bitcoin/bitcoin/pull/10178
< bitcoin-git> bitcoin/master 2584925 Wladimir J. van der Laan: Merge #10178: Remove CValidationInterface::UpdatedTransaction...
< bitcoin-git> bitcoin/master 9fececb Matt Corallo: Remove CValidationInterface::UpdatedTransaction...
< bitcoin-git> bitcoin/master d89f8ad Matt Corallo: Make DisconnectBlock and ConnectBlock static in validation.cpp
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a077a90da88f...2584925077f9
< bitcoin-git> [bitcoin] sipa closed pull request #10215: Check interruptNet during dnsseed lookups (master...2017-04-dnsseed-break) https://github.com/bitcoin/bitcoin/pull/10215
< bitcoin-git> bitcoin/master a077a90 Pieter Wuille: Merge #10215: Check interruptNet during dnsseed lookups...
< bitcoin-git> bitcoin/master b2c9254 Matt Corallo: Check interruptNet during dnsseed lookups
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5e9e428a919...a077a90da88f
< bitcoin-git> [bitcoin] sipa closed pull request #9693: Prevent integer overflow in ReadVarInt. (master...varint_maxsize) https://github.com/bitcoin/bitcoin/pull/9693
< bitcoin-git> bitcoin/master c5e9e42 Pieter Wuille: Merge #9693: Prevent integer overflow in ReadVarInt....
< bitcoin-git> bitcoin/master 45f0961 Gregory Maxwell: Prevent integer overflow in ReadVarInt....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f4db00f9a548...c5e9e428a919
< SopaXorzTaker> wumpus, sipa, the large bitcoin collider client script is untrustworthy
< bitcoin-git> [bitcoin] laanwj opened pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
< bitcoin-git> [bitcoin] jimmysong opened pull request #10219: Tests: Order Python Tests By Duration (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219

2017-04-16

< sipa> this is not a support channel; ask in #bitcoin or on stack exchange