< GitHub0>
[bitcoin] laanwj closed pull request #8715: net: only delete CConnman if it's been created (master...fix-connman-shutdown) https://github.com/bitcoin/bitcoin/pull/8715
< GitHub179>
bitcoin/master 881d7ea Wladimir J. van der Laan: Merge #8715: net: only delete CConnman if it's been created...
< GitHub179>
bitcoin/master 36fa01f Cory Fields: net: only delete CConnman if it's been created...
< wumpus>
jonasschnelli: hehe, maybe if bitcoin was designed 10 years earlier
< * jonasschnelli>
thinks we should fork to use CORBA as our bitcoin scripting language and SOAP as http API :}
< wumpus>
many people just use the RPC through curl, or bitcoin-cli, which involves executing an external process per connection per command, and they don't complain either
< dcousens>
but, my point was, even my own implementation has nothing to do bitcoin as such, its just an RPC implementation
< dcousens>
I've found it much easier to just always use a well-tested rpc library than use something "bitcoin tailored"
< gmaxwell>
the standard python bitcoin json library that people get linked to is not at all reliable (gets disconnected and then throws exceptions, and has to be wrapped to be usable) and I don't see anyone even complaining about it.
< dcousens>
bitcoin-cli*, that is
< wumpus>
no interpreters in bitcoin please
< wumpus>
I mean with bitcoin-cli you have full access to bash' scripting/variable munging/etc capabilities, in the Qt console you don't, so this adds a bit of shell power to it
< jonasschnelli>
I think its better to start with it client-side QT only, and if it turns to be useful, add it to bitcoin-cli.
< jonasschnelli>
A better approach for the RPC layer would be to add it into bitcoin-cli
< GitHub132>
[bitcoin] spencerlievens opened pull request #8717: [WALLET] Addition of ImmatureCreditCached to MarkDirty() (master...patch-2) https://github.com/bitcoin/bitcoin/pull/8717
< GitHub83>
[bitcoin] MarcoFalke opened pull request #8716: [qa] wallet: Check legacy wallet as well (master...Mf1609-qaWalletLegacy) https://github.com/bitcoin/bitcoin/pull/8716
< GitHub32>
[bitcoin] theuni opened pull request #8715: net: only delete CConnman if it's been created (master...fix-connman-shutdown) https://github.com/bitcoin/bitcoin/pull/8715
< GitHub171>
bitcoin/master 86726d8 Wladimir J. van der Laan: Rename `-optintofullrbf` option to `-walletrbf`...
< GitHub29>
[bitcoin] laanwj closed pull request #8601: Add option to opt into full-RBF when sending funds (rebase, original by petertodd) (master...2016_08_full_rbf_option) https://github.com/bitcoin/bitcoin/pull/8601
< GitHub171>
bitcoin/master 05fa823 Wladimir J. van der Laan: wallet: Add BIP125 comment for MAXINT-1/-2 behavior
< GitHub171>
bitcoin/master 152f45b Peter Todd: Add option to opt into full-RBF when sending funds
< GitHub42>
[bitcoin] laanwj closed pull request #8608: Install manpages via make install, also add some autogenerated manpages (master...man_automake2) https://github.com/bitcoin/bitcoin/pull/8608
< GitHub32>
bitcoin/master 6edf2fd nomnombtc: add gen-manpages.sh description to README.md
< GitHub32>
bitcoin/master eb5643b nomnombtc: add autogenerated manpages by help2man
< GitHub32>
bitcoin/master d2cd9c0 nomnombtc: add script to generate manpages with help2man
< GitHub2>
[bitcoin] isle2983 opened pull request #8702: [copyright] add MIT License copyright header to remaining Python files (master...misc-copyright) https://github.com/bitcoin/bitcoin/pull/8702
< GitHub127>
[bitcoin] isle2983 opened pull request #8701: [copyright] add MIT License copyright header to zmq_sub.py (master...zmq_sub-copyright) https://github.com/bitcoin/bitcoin/pull/8701
< GitHub94>
[bitcoin] isle2983 opened pull request #8700: [copyright] add MIT license headers to .sh scripts where missing (master...sh-copyright) https://github.com/bitcoin/bitcoin/pull/8700
< TheJoeB>
Please send me a quick message if anyone is interested in a short conversation regarding your personal experiences with Bitcoin and/or Ethereum (any blockchain technology). It shouldn't take longer than 10 minutes and is for my graduate work on these technologies: http://www.thejoeblankenship.com/research-proposal Your privacy, confidentially, and anonymity will be protected.
< GitHub126>
[bitcoin] pstratem opened pull request #8696: [Wallet] Remove last external reference to CWalletDB (master...2016-09-09-cwallet-listaccountcreditdebit) https://github.com/bitcoin/bitcoin/pull/8696
< luke-jr>
"If checked, users with write access to bitcoin/bitcoin can add new commits to your multiwallet branch. You can always change this setting later." … on by default O.o
< GitHub117>
[bitcoin] pstratem opened pull request #8695: Retry feeler connection if OpenNetworkConnection fails in under 1ms. (master...2016-09-09-net-feeler-timeout) https://github.com/bitcoin/bitcoin/pull/8695
< GitHub103>
[bitcoin] sipa opened pull request #8690: Use a heap to not fully sort all nodes for addr relay (master...heapaddrsort) https://github.com/bitcoin/bitcoin/pull/8690
< GitHub91>
[bitcoin] luke-jr opened pull request #8687: Bugfix: RPC/Wallet: removeprunedfunds should flush the wallet db (master...bugfix_removeprunedfunds) https://github.com/bitcoin/bitcoin/pull/8687
< gmaxwell>
and it also means you couldn't use bitcoin anymore on a connection of less than about 50kbit/sec which, otherwise, could keep up with the chain.
< GitHub48>
[bitcoin] laanwj closed pull request #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (master...20160907_Wshadow_8606) https://github.com/bitcoin/bitcoin/pull/8677
< GitHub33>
bitcoin/master 125b946 Pavel Janík: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning.
< GitHub33>
bitcoin/master 4daf02a Wladimir J. van der Laan: Merge #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning....
< CodeShark>
in my ideal world, Bitcoin Core would just do peer discovery, validation, and relay
< CodeShark>
I have a process connect to bitcoin core via p2p which receives inv messages and sends getdata
< midnightmagic>
it should then be in an external library. putting reliable message delivery into bitcoin core would also make the binary liable in the event something (inevitably) goes wrong.
2016-09-08
< BlueMatt>
sipa: https://github.com/TheBlueMatt/bitcoin/commit/96cef326f9184aefd1c562f64a21298a15f0adde simplifies the total diff from master to be more readable, to me...it matches the bip, but another way to look at it is that you have two booleans: which version of compact blocks they want (which you use to send to them) and whether they will send us segwit cmpctblocks...you simply introduce the the do-they-support-v2 bool as an additional
< cfields>
kanzure: and #8680 introduces blocking calls. So you could "./bitcoin-cli waitfornewblock && ./dosomething.sh", which would essentially be blocknotify. Obviously the same could be done for wallet stuff
< kanzure>
so- for example- imagine you are operating a lot of bitcoin infrastructure. you do a bunch of per-block processing. when you are running functional/integration tests, you can't run your test checks immediately after issuing a command because things take a while. so when do you expect to run? well you setup a hook and you ask your infrastructure to ping your tester as soon as the data's available, or you poll for some internal state.
< wumpus>
/home/user/projects/bitcoin/bitcoin/src/test/addrman_tests.cpp:336:471: warning: stack frame size of 328360 bytes in function 'addrman_tests::addrman_delete::test_method' [-Wframe-larger-than=] whoa :) luckily only in the tests
< wumpus>
let's try to make cfields network refactor (https://github.com/bitcoin/bitcoin/pull/8085/files) happen , it's been open so long now, line-wise there's a lot of changes so he keeps having to rebase it
< veleiro>
Im trying to build v0.13.0 from source on a beaglebone black with debian jessie, i had to compile db4.8 from source but i installed libboost-all-dev, but in the ./configure stage the error i see is "configure: error: No working boost sleep implementation found." I went through https://github.com/bitcoin/bitcoin/issues/3003 with no success
< Chris_Stewart_5>
jeremyrubin: With your new pull request (#8670), are you suggesting writing a new testing framework specific to bitcoin from scratch?
< GitHub128>
[bitcoin] MarcoFalke closed pull request #8673: Trivial: Fix obvious assignment/equality error in test (master...fix_arith_tests_trivial) https://github.com/bitcoin/bitcoin/pull/8673
< GitHub150>
[bitcoin] jonasschnelli opened pull request #8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (master...2016/09/qt_cc_ui_radrio_fix) https://github.com/bitcoin/bitcoin/pull/8678
< GitHub136>
[bitcoin] paveljanik opened pull request #8677: Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (master...20160907_Wshadow_8606) https://github.com/bitcoin/bitcoin/pull/8677
< GitHub122>
[bitcoin] JeremyRubin opened pull request #8673: Trivial: Fix obvious assignment/equality error in test (master...fix_arith_tests_trivial) https://github.com/bitcoin/bitcoin/pull/8673
< GitHub82>
[bitcoin] JeremyRubin closed pull request #8632: Speed up prevector tests by parallelization (master...faster_prevector_tests) https://github.com/bitcoin/bitcoin/pull/8632
< GitHub172>
[bitcoin] JeremyRubin closed pull request #8650: Make tests much faster by replacing BOOST_CHECK with FAST_CHECK (master...faster_tests) https://github.com/bitcoin/bitcoin/pull/8650
< GitHub186>
[bitcoin] Cocosoft opened pull request #8672: Qt: Show transaction size in transaction details window (master...qttxsizeindetails) https://github.com/bitcoin/bitcoin/pull/8672
< GitHub117>
[bitcoin] JeremyRubin opened pull request #8671: Minimal fix to slow prevector tests as stopgap measure (master...simple_faster_tests) https://github.com/bitcoin/bitcoin/pull/8671
< sipa>
the bitcoin and libsecp256k1 benchmark tools just run many times, and give you minimum, maximum and average run time
2016-09-05
< BlueMatt>
general fyi: book your accomodation to wed, if you feel like sticking around to do in-person Bitcoin Core code review/hacking just like the last few times
< BlueMatt>
ie another core hackathon after scaling bitcoin: milan, monday and tuesday
< BlueMatt>
but I dont particularly want to have /the/ key that can sign for lots of updated bitcoin-qt clients
< Lightsword>
could just stick it on bitcoin.org
< BlueMatt>
kanzure: people with their heads on straight are correctly avoiding ubuntu for their bitcoin node hosting, I'd think
< BlueMatt>
bitcoin.org maybe, but I'd prefer to not put it there
< GitHub176>
[bitcoin] NicolasDorier opened pull request #8665: Trivial: ContextualCheckBlockHeader should never have pindexPrev equals to NULL (master...fixup) https://github.com/bitcoin/bitcoin/pull/8665
< GitHub142>
[bitcoin] fivepiece closed pull request #8598: Fix displaying of invalid and non-minimal small pushes as numbers (master...fixasm) https://github.com/bitcoin/bitcoin/pull/8598
< sipa>
but that probably means in practice we can't use it in bitcoin core until 2024 or so :p
< gmaxwell>
In the case of bitcoin the cookie auth is an ephemeral username and password, saved in a cookie file, which can be used for HTTP authentication.
2016-09-03
< GitHub3>
[bitcoin] gmaxwell opened pull request #8661: Do not set an addr time penalty when a peer advertises itself. (master...addrman_nopenalty_self) https://github.com/bitcoin/bitcoin/pull/8661
< GitHub70>
[bitcoin] paveljanik opened pull request #8658: WIP/DO NOT MERGE: Remove unused statements in serialization (master...20160902_nVersion_serialization_cleanup) https://github.com/bitcoin/bitcoin/pull/8658
< GitHub12>
[bitcoin] paveljanik opened pull request #8656: Do not shadow global variable fileout (master...20160902_Wshadow_fileout) https://github.com/bitcoin/bitcoin/pull/8656
< GitHub78>
[bitcoin] paveljanik opened pull request #8655: Do not shadow variables (trivials) (master...20160902_Wshadow_trivials) https://github.com/bitcoin/bitcoin/pull/8655
< GitHub85>
[bitcoin] jl2012 opened pull request #8654: Reuse sighash computations across evaluation (rebase of #4562) (master...sighashcache) https://github.com/bitcoin/bitcoin/pull/8654
< jonasschnelli>
2016-09-02 07:56:40 Bitcoin version v0.13.99.0-df98230
< GitHub117>
[bitcoin] sstone opened pull request #8653: doc (trivial): add tip for cross-builds on ubuntu (master...wip-doccrosscompile) https://github.com/bitcoin/bitcoin/pull/8653
< GitHub186>
[bitcoin] JeremyRubin opened pull request #8650: Make tests much faster by replacing BOOST_CHECK with FAST_CHECK (master...faster_tests) https://github.com/bitcoin/bitcoin/pull/8650
< GitHub176>
[bitcoin] gmaxwell opened pull request #8646: [0.13 backport] Reduce default number of blocks to check at startup (0.13...reduceblocks_backport) https://github.com/bitcoin/bitcoin/pull/8646
< GitHub92>
[bitcoin] gmaxwell opened pull request #8644: [0.13 backport] Check for compatibility with download in FindNextBlocksToDownload (0.13...findnext_backport) https://github.com/bitcoin/bitcoin/pull/8644