2015-11-21

< GitHub179> [bitcoin] pstratem closed pull request #6966: [WIP] Wallet: Cache CWalletDB pointer in CWallet to improve performance (master...wallet_speedup) https://github.com/bitcoin/bitcoin/pull/6966

2015-11-20

< GitHub82> [bitcoin] pstratem opened pull request #7071: Wallet: Replace TxnAbort with assert. (master...2015-11-20-wallet-activetxn) https://github.com/bitcoin/bitcoin/pull/7071
< GitHub11> [bitcoin] MarcoFalke opened pull request #7070: Move hardcoded maxFeeRate out of mempool (master...MarcoFalke-2015-feeRateRefactor) https://github.com/bitcoin/bitcoin/pull/7070
< GitHub105> [bitcoin] laanwj closed pull request #6979: [Qt] simple mempool info in debug window (master...2015/11/qt_mempool_easyinfo) https://github.com/bitcoin/bitcoin/pull/6979
< GitHub192> bitcoin/master 776848a Wladimir J. van der Laan: Merge pull request #6979...
< GitHub192> bitcoin/master c197798 Jonas Schnelli: [Qt] simple mempool info in debug window
< GitHub192> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07b770caf3f5...776848acefa8
< GitHub117> [bitcoin] MarcoFalke opened pull request #7069: [trivial] Fix -maxmempool InitError (master...MarcoFalke-2015-maxmempoolInitError) https://github.com/bitcoin/bitcoin/pull/7069
< GitHub146> [bitcoin] jonasschnelli opened pull request #7068: [RPC-Tests] add simple way to run rpc test over QT clients (master...2015/11/rpc_tests_qt) https://github.com/bitcoin/bitcoin/pull/7068
< GitHub15> [bitcoin] jonasschnelli opened pull request #7067: [Wallet] improve detection of conflicted transactions (master...2015/11/mempool_wallet) https://github.com/bitcoin/bitcoin/pull/7067
< GitHub86> [bitcoin] paveljanik opened pull request #7066: [Trivial,Doc] Add missing "blocktime" description to listtransactions help, fix formatting. (master...listtransactions_blocktime) https://github.com/bitcoin/bitcoin/pull/7066
< btcdrak> BIP68 bip text has been updated https://github.com/bitcoin/bips/issues/245
< gmaxwell> During the last malleability attacks I walked a bitcoin ATM operator through doing that. Hard part was explaining the need, once they got it the actual implementation was easy. (well also the wallet they were using to fill their ATMs ..... had no sendmany support. :( )
< wumpus> there's an option in bitcoin core's wallet to not spend any unconfirmed outputs
< jonasschnelli> gmaxwell, sipa: mind doing a quick concept-review if I'm going into the right direction (big !WIP!, just check the concept): https://github.com/jonasschnelli/bitcoin/commit/723b7c365ceaa1567c364e1ffc5602f5dfd1b7fb
< jonasschnelli> Luke-Jr: so that a relevant part?: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L459
< GitHub185> [bitcoin] laanwj opened pull request #7065: http: add Boost 1.49 compatibility (master...2015_11_httpserver_boost1_49) https://github.com/bitcoin/bitcoin/pull/7065
< jonasschnelli> But while looking at https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1521, it looks like that the wallet does not spend evicted transaction (confirmations: -1)? Will test now...
< gmaxwell> it could cause you to overdraft yourself and rip people off accidentally and be unable to make it right (at least not immediately) because you no longer have enough bitcoin.
< jonasschnelli> gmaxwell: did you mean that point: http://bitcoinstats.com/irc/bitcoin-dev/logs/2015/11/19#l1447960611.0
< GitHub39> [bitcoin] laanwj closed pull request #7019: [qa] travis: cover more tests (master...MarcoFalke-2015-receivedby) https://github.com/bitcoin/bitcoin/pull/7019
< GitHub118> bitcoin/master 07b770c Wladimir J. van der Laan: Merge pull request #7019...
< GitHub118> bitcoin/master 33b7f83 MarcoFalke: [qa] travis: cover *receivedby* rpcs
< GitHub118> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1bfca80521e...07b770caf3f5
< gmaxwell> midnightmagic: can you update to bitcoin core master and see that it still works there?
< GitHub156> [bitcoin] laanwj closed pull request #7059: add powerpc build support for openssl lib (master...ppc) https://github.com/bitcoin/bitcoin/pull/7059
< GitHub13> bitcoin/master a1bfca8 Wladimir J. van der Laan: Merge pull request #7059...
< GitHub13> bitcoin/master 2798e0b daniel: add powerpc build support for openssl lib
< GitHub13> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c983d6fcb47b...a1bfca80521e
< GitHub122> [bitcoin] pstratem opened pull request #7064: Perform entire CWallet::TopUpKeyPool in a transaction. (master...2015-11-19-wallet-topupkeypool) https://github.com/bitcoin/bitcoin/pull/7064

2015-11-19

< jtimon> what's with bitcoin-cli ?
< jtimon> does bitcoin-tx use every function defined in every cpp in util and common?
< cfields_> yes, but see bitcoin-cli
< jtimon> doesn't bitcoin-tx depend on both of them?
< jtimon> in the same sense, bitcoin-tx may not require everything in util or common, but it depends on util and common as a whole
< jtimon> assuming a future in which bitcoin core consumes libbitcoinconsensus C API directly instead of its code, that dependency will eventually happen
< cfields_> jtimon: that's what i meant by "consensus isn't the only POV". For (bad) example, bitcoin-tx might need hashing, but not use libsecp256k1
< instagibbs> wumpus, any pointers on installing the rpcuser python script? Source of Q: https://github.com/bitcoin/bitcoin/pull/7044#discussion_r45213005
< jtimon> aren't those these the packages/modules in which bitcoin core is divided?
< jtimon> which reminds me...I need to ask cfields what would he think about a consensus building module separated from util, common, etc, maybe merging with libsecp256 and crypto modules (that is not good for bitcoin-tx when we start adding non-tx stuff to the module, but verifyheader and verifyblock should be relatively light compared to verifytx and verifyscript)
< jtimon> sipa: your opinion is the reason #6068 is closed https://github.com/bitcoin/bitcoin/pull/6068#issuecomment-152850502 : "Frankly, I think this type of encapsulation needs to wait until the mempool
< jonasschnelli> sipa: there is already an issue for that with a little discussion: https://github.com/bitcoin/bitcoin/issues/6461
< sipa> hmm, do we have any means for people to select pruning at first run of Bitcoin-Qt?
< GitHub67> [bitcoin] sdaftuar opened pull request #7063: [Tests] Add prioritisetransaction RPC test (master...add-prioritisetransaction-rpctest) https://github.com/bitcoin/bitcoin/pull/7063
< GitHub36> [bitcoin] sdaftuar opened pull request #7062: [Mempool] Fix mempool limiting for PrioritiseTransaction (master...fix-mempool-limiting) https://github.com/bitcoin/bitcoin/pull/7062
< sipa> jgarzik: it seems that that is not really the case; you can come up with a formula to treat bitcoin-days-destroyed as extra fee, but it's probably hard to prevent it from making miners lose large amounts in fees
< wumpus> the wallet code gives me a headache. I tried to explain https://github.com/bitcoin/bitcoin/issues/7054 (Difference in getbalance and sum(listtransactions) amounts (testnet)) but failed
< wumpus> e.g. https://github.com/bitcoin/bitcoin/pull/3845 Add a method for removing a single wallet tx (rebased)
< GitHub68> [bitcoin] jonasschnelli opened pull request #7061: [Wallet] add rescanblockchain <height> RPC command (master...2015/11/wallet_rescan_rpc) https://github.com/bitcoin/bitcoin/pull/7061
< wumpus> but I agree that you either want bitcoin core to choose a fee for you (estimate confirm within # confirmations) or you want to set a fee/kB, which should be above what your mempool accepts at all
< MarcoFalke> wumpus, about the "all fees in bitcoin core are per kB" thing:
< GitHub9> [bitcoin] laanwj opened pull request #7060: doc: Make networking work inside builder in gitian-building.md (master...2015_11_gitian_building) https://github.com/bitcoin/bitcoin/pull/7060
< GitHub150> bitcoin/master 2e31d74 Wladimir J. van der Laan: gitian: use trusty for building
< GitHub117> [bitcoin] laanwj closed pull request #6900: gitian: build on ubuntu 14.04 (master...2015_10_gitian_trusty) https://github.com/bitcoin/bitcoin/pull/6900
< GitHub150> bitcoin/master 0b416c6 Wladimir J. van der Laan: depends: qt PIDLIST_ABSOLUTE patch...
< GitHub150> bitcoin/master 9f251b7 Wladimir J. van der Laan: devtools: add libraries for bitcoin-qt to symbol check...
< GitHub150> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/52c563710ddd...c983d6fcb47b
< GitHub39> bitcoin/master 52c5637 Wladimir J. van der Laan: qt: Periodic translations update
< GitHub39> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/52c563710ddd80a90c58205e866a42b01887ab63
< GitHub102> bitcoin/master a190777 Wladimir J. van der Laan: Merge pull request #7051...
< GitHub180> [bitcoin] laanwj closed pull request #7051: ui: Add "Copy raw transaction data" to transaction list context menu (master...2015_11_transaction_hex2) https://github.com/bitcoin/bitcoin/pull/7051
< GitHub102> bitcoin/master b4f3e9c Wladimir J. van der Laan: ui: Add "Copy raw transaction data" to transaction list context menu...
< GitHub102> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8e87d74c9b7...a1907772f021
< GitHub128> [bitcoin] laanwj closed pull request #7048: [doc][trivial] Remove miniupnpc build notes from build-unix (master...miniupnpc-build-unix) https://github.com/bitcoin/bitcoin/pull/7048
< GitHub169> bitcoin/master f8e87d7 Wladimir J. van der Laan: Merge pull request #7048...
< GitHub169> bitcoin/master c5f211b fanquake: [doc][trivial] Remove miniupnpc build notes build-unix
< GitHub169> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/15765df3521b...f8e87d74c9b7
< wumpus> 7fd5e22a794a6fa34defe0cd0e82d8f0ad759fba73e190aa5bd202627fa45bc5 bitcoin-0.11.99-win-unsigned.tar.gz MATCH
< wumpus> 67c3bc85ece1ad2905a7f801277fbd76d1e7ac653ad2e021cd7fadf1fa6a6307 src/bitcoin-0.11.99.tar.gz MATCH
< jonasschnelli> Can you compare: b8affff612d645598a4642dcc4eef7d4974c02d73c31a99ba2faa36425142aca bitcoin-win-0.12-desc.yml?
< jonasschnelli> wumpus: yeah.. i have though this also. But: git:b08293544a207088193de8834bb754f5d212c9bf bitcoin
< jonasschnelli> even the bitcoin-0.11.99.tar.gz doesn't match (against the hashes you have posted)
< jonasschnelli> wumpus: if you provide / pastebin your bitcoin-win-0.12-build.assert somewhere I can check the packages.
< GitHub73> [bitcoin] jonasschnelli closed pull request #7041: [doc][trivial] Update OS X install instructions (master...patch-5) https://github.com/bitcoin/bitcoin/pull/7041
< GitHub1> bitcoin/master 15765df Jonas Schnelli: Merge pull request #7041...
< GitHub1> bitcoin/master bd42e6b Michael Ford: [doc] Users now see 'Bitcoin Core' in the OSX bundle...
< GitHub1> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/73fa5e604356...15765df3521b
< GitHub150> [bitcoin] arowser opened pull request #7059: add powerpc build support for openssl lib (master...ppc) https://github.com/bitcoin/bitcoin/pull/7059
< GitHub41> [bitcoin] dcousens opened pull request #7058: init: amend ZMQ flag names (master...zmqdoc) https://github.com/bitcoin/bitcoin/pull/7058
< GitHub180> [bitcoin] pstratem opened pull request #7057: Wallet: Flush database to log files (master...2015-11-18-wallet-flush) https://github.com/bitcoin/bitcoin/pull/7057

2015-11-18

< GitHub106> [bitcoin] morcos opened pull request #7056: Save last db read (master...saveLastDBRead) https://github.com/bitcoin/bitcoin/pull/7056
< GitHub31> [bitcoin] laanwj closed pull request #6932: ModifyNewCoins saves database lookups (master...newCoinsThinAir) https://github.com/bitcoin/bitcoin/pull/6932
< GitHub151> bitcoin/master 03c8282 Alex Morcos: Make CCoinsViewTest behave like CCoinsViewDB
< GitHub151> bitcoin/master 1cf3dd8 Alex Morcos: Add unit test for UpdateCoins
< GitHub151> bitcoin/master 14470f9 Alex Morcos: ModifyNewCoins saves database lookups...
< GitHub151> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/03403d8c0f3b...73fa5e604356
< wumpus> there's one difference though: tor only authenticates on opening the connection, bitcoin http authenticates for every request. So they can use more key stretching without creating command latency issues.
< GitHub43> [bitcoin] ptschip closed pull request #7055: MAX_PROTOCOL_MESSAGE_LENGTH description (master...maxmessage) https://github.com/bitcoin/bitcoin/pull/7055
< Greyboy> sipa, i was wondering why bitcoin-core tries to connect to dyndns and alerts my IDS
< Greyboy> On a different note, I was wondering what bitcoin-core does that requires it to connect to dyndns?
< Greyboy> instagibbs, i know i'm new and my opinion is relatively worthless, but i think it's a good idea. my question is what percent of people who run bitcoin-core actually need this solution?
< GitHub96> [bitcoin] ptschip opened pull request #7055: MAX_PROTOCOL_MESSAGE_LENGTH description (master...maxmessage) https://github.com/bitcoin/bitcoin/pull/7055
< wumpus> I don't want a complex, complete authentication and permissions system in bitcoin core
< GitHub190> [bitcoin] jonasschnelli closed pull request #6951: [qt] Use maxTxFee instead of 10000000 (master...MarcoFalke-2015-qtMaxFee) https://github.com/bitcoin/bitcoin/pull/6951
< GitHub151> bitcoin/master 03403d8 Jonas Schnelli: Merge pull request #6951...
< GitHub151> bitcoin/master 513686d MarcoFalke: [qt] Use maxTxFee instead of 10000000
< GitHub151> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7f8e90da335e...03403d8c0f3b
< GitHub25> [bitcoin] jtimon closed pull request #5970: DEPENDENT: Globals: Avoid calling Params() (master...chainparams_cleanup) https://github.com/bitcoin/bitcoin/pull/5970
< GitHub111> [bitcoin] jtimon opened pull request #7053: Globals: Remove a bunch of Params() from main.cpp before 0.12 (master...globals-chainparams-main) https://github.com/bitcoin/bitcoin/pull/7053
< GitHub184> [bitcoin] MarcoFalke opened pull request #7052: [qa] python-bitcoinrpc is no longer a subtree (master...MarcoFalke-2015-qaSubtree) https://github.com/bitcoin/bitcoin/pull/7052
< GitHub125> [bitcoin] laanwj closed pull request #7030: [contrib] Delete test-patches (master...MarcoFalke-2015-contribC) https://github.com/bitcoin/bitcoin/pull/7030
< GitHub3> bitcoin/master 013a364 MarcoFalke: [contrib] Delete test-patches
< GitHub3> bitcoin/master 7f8e90d Wladimir J. van der Laan: Merge pull request #7030...
< GitHub3> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3ea48ad8b85...7f8e90da335e
< GitHub197> [bitcoin] gmaxwell closed pull request #7050: Fix debug log message for block files (master...nitfix) https://github.com/bitcoin/bitcoin/pull/7050
< GitHub147> bitcoin/master e855b01 Alex Morcos: Fix debug log message for block files
< GitHub147> bitcoin/master f3ea48a Gregory Maxwell: Merge pull request #7050...
< GitHub147> [bitcoin] gmaxwell pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8df8a5077df...f3ea48ad8b85
< GitHub23> [bitcoin] laanwj opened pull request #7051: ui: Add "Copy raw transaction data" to transaction list context menu (master...2015_11_transaction_hex2) https://github.com/bitcoin/bitcoin/pull/7051
< GitHub85> [bitcoin] morcos opened pull request #7050: Fix debug log message for block files (master...nitfix) https://github.com/bitcoin/bitcoin/pull/7050
< gmaxwell> Okay, I confess some paranoia here-- I don't want this to be like the rpc hangs issue. Where we pigheadily avoid improvements for some silly footgun which is making people stop using bitcoin core and switch to hosted apis.
< GitHub150> [bitcoin] fanquake opened pull request #7048: [doc][trivial] Update miniupnpc version in build-unix (master...miniupnpc-build-unix) https://github.com/bitcoin/bitcoin/pull/7048
< gmaxwell> As far as I know the normal relay network bitcoin nodes do nothing special on the bitcoin p2p protocol.
< GitHub144> [bitcoin] luke-jr opened pull request #7047: [WIP] Backports for 0.11.3 (updated to e8df8a5) (0.11...backports-for-0.11.3) https://github.com/bitcoin/bitcoin/pull/7047

2015-11-17

< gmaxwell> phantomcircuit: you should improve your commit messages some; e.g. https://github.com/pstratem/bitcoin/commit/17e6157c1975a4f5e0afa97d632ca0310b227158 should explain that previously if we recieved an unsolicited TX message (which we shouldn't) we'd process it anyways, even in blocks only mode.
< btcdrak> better move to #bitcoin
< BlueMatt> morcos: sorry, I've been behind on bitcoin core...people were starting to notice the relay network had been broken for a long time so i figured i needed to fix it
< GitHub102> [bitcoin] pstratem opened pull request #7046: [WIP] Net: Ignore "tx" messages in blocks only mode. (master...2015-11-17-blocksonly) https://github.com/bitcoin/bitcoin/pull/7046
< GitHub121> [bitcoin] luke-jr opened pull request #7045: Bugfix: Use unique autostart filenames on Linux for testnet/regtest (master...linux_autostart_unique) https://github.com/bitcoin/bitcoin/pull/7045
< GitHub126> [bitcoin] instagibbs opened pull request #7044: RPC: Added additional config option for multiple RPC users. (master...multrpc) https://github.com/bitcoin/bitcoin/pull/7044
< GitHub93> [bitcoin] laanwj closed pull request #7020: Implement helper class for CTxMemPoolEntry constructor (master...EntryHelper) https://github.com/bitcoin/bitcoin/pull/7020
< GitHub86> bitcoin/master e8df8a5 Wladimir J. van der Laan: Merge pull request #7020...
< GitHub86> bitcoin/master e587bc3 Alex Morcos: Implement helper class for CTxMemPoolEntry constructor...
< GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eac53ec99201...e8df8a5077df
< GitHub64> [bitcoin] fanquake opened pull request #7042: [doc] Update Debian watch & control (master...update-debian) https://github.com/bitcoin/bitcoin/pull/7042
< GitHub45> [bitcoin] fanquake opened pull request #7041: [doc][trivial] Update OS X install instructions (master...patch-5) https://github.com/bitcoin/bitcoin/pull/7041
< GitHub159> [bitcoin] fanquake opened pull request #7040: [doc] Update OS X build notes for new qt5 configure (master...patch-4) https://github.com/bitcoin/bitcoin/pull/7040
< wumpus> #bitcoin please
< btcdrak> who maintains the Ubuntu ppa packages for bitcoin? there are issues being reported https://www.reddit.com/r/Bitcoin/comments/3t04fp/psa_please_upgrade_to_bitcoin_core_0112_to/cx33vpw?context=3
< wumpus> (or #bitcoin-wizards if it is moonmath related :-) )
< wumpus> well definitely not here, this channel is just for bitcoin core related programming work. The proper answer to your question is stil 'the mailing list'. #bitcoin-dev is fine, but IRC discussion tends to be more ephermal than mailing lists
< CodeShark> The usual procedure for BIP proposals is to discuss on mailing list first. But given that at least a few important reviewers/critics either have unsubscribed to the ML entirely or else just ignore it, should we discuss it here or in bitcoin-dev?
< gmaxwell> Luke-Jr: https://github.com/bitcoin/bitcoin/pull/6851 wants rebase
< GitHub74> [bitcoin] gmaxwell closed pull request #7026: [contrib] Update versionprefix to "bitcoin-core" in verify.sh (master...MarcoFalke-2015-verify) https://github.com/bitcoin/bitcoin/pull/7026
< GitHub2> bitcoin/master eac53ec Gregory Maxwell: Merge pull request #7026...
< GitHub2> bitcoin/master a6d5a65 MarcoFalke: [trivial] contrib: Fix `echo`s in verify.sh
< GitHub2> [bitcoin] gmaxwell pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/87ee0e2dbc12...eac53ec99201
< GitHub2> bitcoin/master 141c44e MarcoFalke: [contrib] Update versionprefix to "bitcoin-core" in verify.sh
< GitHub177> [bitcoin] gmaxwell opened pull request #7037: Move the blocknotify callback ahead of peer announcement. (master...notify_early) https://github.com/bitcoin/bitcoin/pull/7037
< GitHub122> [bitcoin] dcousens opened pull request #7035: torcontrol: only output disconnect if -debug=tor (master...torlog) https://github.com/bitcoin/bitcoin/pull/7035
< GitHub68> [bitcoin] gmaxwell closed pull request #6986: Globals: Don't call Params() from miner.cpp (master...global-chainparams-miner) https://github.com/bitcoin/bitcoin/pull/6986
< GitHub18> bitcoin/master 87ee0e2 Gregory Maxwell: Merge pull request #6986...
< GitHub18> bitcoin/master 6bc9e40 Jorge Timón: Chainparams: Explicit CChainParams arg for miner:...
< GitHub18> bitcoin/master 598e494 Jorge Timón: Chainparams: Explicit CChainParams arg for main (pre miner):...
< GitHub18> [bitcoin] gmaxwell pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/972bf9c52987...87ee0e2dbc12
< GitHub25> [bitcoin] ptschip closed pull request #7034: Fixed Windows secp256k1 compilation issue #7018 (master...secp256k1_compile) https://github.com/bitcoin/bitcoin/pull/7034
< GitHub149> [bitcoin] gmaxwell closed pull request #6999: add (max)uploadtarget infos to getnettotals RPC help (master...2015/11/maxuploadtarget_rpc_help) https://github.com/bitcoin/bitcoin/pull/6999
< GitHub66> bitcoin/master 972bf9c Gregory Maxwell: Merge pull request #6999...
< GitHub66> bitcoin/master f6d9d5e Jonas Schnelli: add (max)uploadtarget infos to getnettotals RPC help
< GitHub66> [bitcoin] gmaxwell pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a547d2d5501...972bf9c52987
< GitHub106> [bitcoin] gmaxwell closed pull request #7023: Fixed integer comparison warning. (master...signed_int_comparison_fix) https://github.com/bitcoin/bitcoin/pull/7023
< GitHub69> bitcoin/master 0a547d2 Gregory Maxwell: Merge pull request #7023...
< GitHub69> bitcoin/master 4d29032 Eric Lombrozo: Fixed integer comparison warning.
< GitHub69> [bitcoin] gmaxwell pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e54ebbf60097...0a547d2d5501
< dcousens> gmaxwell: its a fresh IBD with a just-compiled 4 days ago bitcoin/bitcoin master
< GitHub175> [bitcoin] ptschip opened pull request #7034: Fixed Windows secp256k1 compilation issue #7018 (master...secp256k1_compile) https://github.com/bitcoin/bitcoin/pull/7034

2015-11-16

< gmaxwell> https://www.reddit.com/r/Bitcoin/comments/3t04fp/psa_please_upgrade_to_bitcoin_core_0112_to/cx2b117 < anyone know whats up with someone saying they can't upgrade bitcoin core without upgrading OSX?
< jonasschnelli> wumpus: https://bitcoin.jonasschnelli.ch/pulls/6900/build-win.log MinGW still has troubles with boost #6900
< jonasschnelli> wumpus: seems to work now: https://bitcoin.jonasschnelli.ch/pulls/6900/
< * jonasschnelli> ran rm -Rf gitian-builder/cache/bitcoin-linux-0.12/ ... does build again now
< wumpus> I think only bitcoin-linux-0.12
< jonasschnelli> wumpus : still have the linking issue on linux (https://bitcoin.jonasschnelli.ch/pulls/6900/build-linux.log)
< GitHub155> [bitcoin] MarcoFalke opened pull request #7030: [contrib] Delete test-patches and move testgen to devtools (master...MarcoFalke-2015-contribC) https://github.com/bitcoin/bitcoin/pull/7030
< GitHub151> [bitcoin] sdaftuar opened pull request #7029: Remove unmaintained example test script_test.py (master...script-test-cleanup) https://github.com/bitcoin/bitcoin/pull/7029
< GitHub162> [bitcoin] MarcoFalke opened pull request #7028: [doc] qa: Move README.md and update -help (master...MarcoFalke-2015-qaReadme) https://github.com/bitcoin/bitcoin/pull/7028
< jonasschnelli> wumpus: get a linker error when building #6900 (trusty gitian). Check: https://bitcoin.jonasschnelli.ch/pulls/6900/build-linux.log (very bottom)
< sipa> also, it may not be exploitable... the BN_sqr bug we found in OpenSSL (thanks to libsecp256k1's unit tests that compared with OpenSSL) was technically a hard fork for bitcoin when it got foxed, but an unexploitable one as far as we know
< GitHub113> bitcoin/master e54ebbf Wladimir J. van der Laan: Merge pull request #6954...
< GitHub119> [bitcoin] laanwj closed pull request #6954: Switch to libsecp256k1-based ECDSA validation (master...secp256k1) https://github.com/bitcoin/bitcoin/pull/6954
< GitHub113> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dafefb79244d...e54ebbf60097
< GitHub113> bitcoin/master 6e18268 Pieter Wuille: Switch to libsecp256k1-based validation for ECDSA
< GitHub159> [bitcoin] MarcoFalke opened pull request #7027: [qa] rpc-tests: Properly use test framework (master...MarcoFalke-2015-rpcTestCleanup) https://github.com/bitcoin/bitcoin/pull/7027
< GitHub43> [bitcoin] MarcoFalke opened pull request #7026: [contrib] Update versionprefix to "bitcoin-core" in verify.sh (master...MarcoFalke-2015-verify) https://github.com/bitcoin/bitcoin/pull/7026
< GitHub134> bitcoin/master dafefb7 Wladimir J. van der Laan: Merge pull request #7016...
< GitHub72> [bitcoin] laanwj closed pull request #7016: Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN. (master...without_EVENT_LOG_WARN) https://github.com/bitcoin/bitcoin/pull/7016
< GitHub134> bitcoin/master aee22bf Gregory Maxwell: Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN....
< GitHub134> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6876a78b863e...dafefb79244d
< wumpus> BTW: if you get "/home/user/bitcoin/src/key.cpp:204: undefined reference to `secp256k1_ecdsa_sign_recoverable'" errors after updating to master you need to clean your git tree (since #6983)
< GitHub45> [bitcoin] jonasschnelli opened pull request #7025: [Qt] refactor and optimize proxy settings behavior (master...2015/11/qt_settingsvalidation) https://github.com/bitcoin/bitcoin/pull/7025
< GitHub193> bitcoin/0.11 595c8d6 Wladimir J. van der Laan: Merge pull request #7021...
< GitHub193> bitcoin/0.11 9730051 Alex Morcos: add bip65 tests to rpc-tests.sh -extended
< GitHub193> [bitcoin] laanwj pushed 2 new commits to 0.11: https://github.com/bitcoin/bitcoin/compare/7e278929df53...595c8d6301cf
< GitHub34> [bitcoin] laanwj closed pull request #7021: add bip65 tests to rpc-tests.sh -extended (in 0.11 branch) (0.11...11rpcfixups) https://github.com/bitcoin/bitcoin/pull/7021
< GitHub101> [bitcoin] gmaxwell closed pull request #6991: Minor: Clarify 'fee' field in fundrawtransaction help text (master...clarify-fundrawtransaction-help) https://github.com/bitcoin/bitcoin/pull/6991
< GitHub194> bitcoin/master 9bd3f03 Peter Todd: Clarify 'fee' field in fundrawtransaction help text...
< GitHub194> bitcoin/master 6876a78 Gregory Maxwell: Merge pull request #6991...
< GitHub194> [bitcoin] gmaxwell pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/814697c5569c...6876a78b863e
< jonasschnelli> and this matched that: https://github.com/bitcoin/bitcoin/pull/7004/files
< jonasschnelli> master needs to have https://github.com/bitcoin/bitcoin/pull/7004
< GitHub19> [bitcoin] jonasschnelli closed pull request #7000: [Qt] add shortcurts for debug-/console-window (master...2015/11/qt_shortcuts) https://github.com/bitcoin/bitcoin/pull/7000
< GitHub184> bitcoin/master 773ae46 Jonas Schnelli: [Qt] add shortcurts for debug-/console-window
< GitHub184> bitcoin/master 814697c Jonas Schnelli: Merge pull request #7000...
< GitHub184> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b632145edeb3...814697c5569c
< gmaxwell> for me bitcoin core sync runs at around 8000tx/s (with secp256k1), even though every tx is involving a non-cachable missing record check for bip30 (in addition to all the cached stuff)... thats really quite remarkable IMO.
< GitHub18> [bitcoin] CodeShark opened pull request #7023: Fixed integer comparison warning. (master...signed_int_comparison_fix) https://github.com/bitcoin/bitcoin/pull/7023

2015-11-15

< GitHub84> [bitcoin] morcos opened pull request #7022: Change default block priority size to 0 (master...defaultPrioritySize) https://github.com/bitcoin/bitcoin/pull/7022
< GitHub64> [bitcoin] morcos opened pull request #7021: add bip65 tests to rpc-tests.sh -extended (in 0.11 branch) (0.11...11rpcfixups) https://github.com/bitcoin/bitcoin/pull/7021
< Luke-Jr> FWIW, I figured out why the CLTV tests failed on 0.11.2: https://github.com/bitcoin/bitcoin/pull/6523#issuecomment-156782660
< gmaxwell> FWIW, I've unsubscribed from bitcoin-dev mailing list.
< gmaxwell> yes, not a risk for us but we'll probably get asked to update when people notice bitcoin-qt links it.
< GitHub184> [bitcoin] morcos opened pull request #7020: Implement helper class for CTxMemPoolEntry constructor (master...EntryHelper) https://github.com/bitcoin/bitcoin/pull/7020
< gmaxwell> Well it's also a bit #bitcoin-core-dev too, in that I think it would be useful if work were done in the GUI to make mining fun, ... but probably more than that is just speculation :)
< gmaxwell> also it suggests a framework for setting minimum feerates which are independant of bitcoin's price-- though dependant on communications efficiency, which is perhaps no better. :)

2015-11-14

< GitHub136> [bitcoin] MarcoFalke opened pull request #7019: [trivial] travis: cover *receivedby* rpcs (master...MarcoFalke-2015-receivedby) https://github.com/bitcoin/bitcoin/pull/7019
< GitHub50> [bitcoin] morcos closed pull request #6292: Rename and comment priority calculation in TxMemPoolEntry (master...PriorityComment) https://github.com/bitcoin/bitcoin/pull/6292
< GitHub101> [bitcoin] gmaxwell opened pull request #7016: Avoid a compile error on hosts with libevent too old for EVENT_LOG_WARN. (master...without_EVENT_LOG_WARN) https://github.com/bitcoin/bitcoin/pull/7016
< gmaxwell> morcos: the relay network has its own protocol, and a local proxy you run that speaks bitcoin p2p.
< GitHub168> [bitcoin] gmaxwell closed pull request #6993: Add -blocksonly option (master...blocksonly) https://github.com/bitcoin/bitcoin/pull/6993
< GitHub86> bitcoin/master 3a96497 Patick Strateman: Add whitelistalwaysrelay option
< GitHub86> bitcoin/master 420fa81 Patick Strateman: Do not process tx inv's in blocksonly mode
< GitHub86> bitcoin/master 4044f07 Patick Strateman: Add blocksonly mode
< GitHub86> [bitcoin] gmaxwell pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ffc687288dd...b632145edeb3
< tulip> morcos: there's also stratum proxies like bfgminer and stratum-mining-proxy which present work to downstream miners, based on either an upstream work server or a Bitcoin node. the latter was meant for use with early hardware miners which supported getwork but not stratum.
< gmaxwell> (Forrestv seems to have flamed out due to a mixture of bitcoin drama, and then donations to support p2pool being relatively low (compared to life changing amounts of income centeralized pool operators were getting), and then he got ripped off ... twice, I think, by mining hardware makers.)
< gmaxwell> Also through this time the developer burned out on Bitcoin, and only does life support maintaince on p2pool now.
< gmaxwell> P2pool is nice idea with cute features, but has always struggled with the high startup cost of having to run a bitcoin node with it; and then high latency asics showed up (in particular, some of the early BFL products had 10%+ hashrate loss from 10 second retasking)
< gmaxwell> morcos: well it's armored by bitcoin nodes in and out; not that there haven't been problems.
< gmaxwell> Yes. It is. I tried to do it for bitcoin core eons ago, but the utility library was GPLed... they since changed the licensing.
< gmaxwell> sipa: someone was seeking feedback from you here: https://github.com/bitcoin/bitcoin/pull/6844
< GitHub18> bitcoin/master e495ed5 Jonas Schnelli: add documentation for exluding whitelistes peer from maxuploadtarget
< GitHub44> [bitcoin] gmaxwell closed pull request #6984: don't enforce maxuploadtarget's disconnect for whitelisted peers (master...2015/11/maxupload_whitebind) https://github.com/bitcoin/bitcoin/pull/6984
< GitHub18> bitcoin/master 5760749 Jonas Schnelli: [docs] rename reducetraffic.md to reduce-traffic.md
< GitHub18> bitcoin/master d61fcff Jonas Schnelli: don't enforce maxuploadtargets disconnect for whitelisted peers
< GitHub18> [bitcoin] gmaxwell pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/44ac42e50d56...9ffc687288dd
< GitHub79> [bitcoin] laanwj closed pull request #7004: update jonasschnellis gpg key (master...2015/11/signing_key_jonasschnelli) https://github.com/bitcoin/bitcoin/pull/7004
< GitHub151> bitcoin/master 44ac42e Wladimir J. van der Laan: Merge pull request #7004...
< GitHub151> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/44ac42e50d567b08d3cb3f3c5766588468ce5bbf
< GitHub81> [bitcoin] laanwj closed pull request #7013: Remove LOCK(cs_main) from decodescript (master...2015-11-remove-cs-main-from-decodescript) https://github.com/bitcoin/bitcoin/pull/7013
< GitHub73> bitcoin/master 36baa9f Wladimir J. van der Laan: Merge pull request #7013...
< GitHub73> bitcoin/master b3ae384 Peter Todd: Remove LOCK(cs_main) from decodescript...
< GitHub73> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0a5ef84272b...36baa9f47587
< wumpus> sure that's why I dont give "integrate it into bitcoin core" as an alternative, but say communicate through a pipe or socket
< gmaxwell> But the biggest reason for the seperate process is to tear down development barriers. E.g. so someone can build a module without the scarryness in bitcoin core. :)
< GitHub67> [bitcoin] gmaxwell closed pull request #7010: Fix fundrawtransaction handling of includeWatching (master...2015-11-fix-fundrawtransaction-bugs) https://github.com/bitcoin/bitcoin/pull/7010
< GitHub147> bitcoin/master e0a5ef8 Gregory Maxwell: Merge pull request #7010...
< GitHub147> bitcoin/master 10953a7 Peter Todd: Better error message for fundrawtransaction w/ empty vout...
< GitHub147> bitcoin/master 61e1eb2 Peter Todd: Actually use includeWatching value in fundrawtransaction...
< GitHub147> [bitcoin] gmaxwell pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/dbd2c135ddb9...e0a5ef84272b
< gmaxwell> wumpus: jonasschnelli: Care to give me a quick design sniff test? I'm thinking of having someone implement functionality for external signers in Bitcoin core along these lines, http://0bin.net/paste/7HCkLWNJBDqJB7Up#hPgdwfs06m7FJw-WQZUCBNTNfCZnrix2K0Mo++6jpbH

2015-11-13

< GitHub74> [bitcoin] petertodd opened pull request #7013: Remove LOCK(cs_main) from decodescript (master...2015-11-remove-cs-main-from-decodescript) https://github.com/bitcoin/bitcoin/pull/7013
< GitHub38> [bitcoin] petertodd opened pull request #7011: Add mediantime to getblockchaininfo (master...2015-11-add-mediantime-to-getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/7011
< GitHub157> [bitcoin] petertodd opened pull request #7010: Fix fundrawtransaction handling of includeWatching (master...2015-11-fix-fundrawtransaction-bugs) https://github.com/bitcoin/bitcoin/pull/7010
< GitHub117> [bitcoin] gmaxwell closed pull request #6990: http: speed up shutdown (master...2015_11_threadexit) https://github.com/bitcoin/bitcoin/pull/6990
< GitHub138> bitcoin/master dbd2c13 Gregory Maxwell: Merge pull request #6990...
< GitHub138> [bitcoin] gmaxwell pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/dbd2c135ddb96bdc3a4e870c2371cb1fac227135
< Luke-Jr> sdaftuar: I don't have any env vars set related to Bitcoin
< GitHub155> [bitcoin] laanwj closed pull request #7007: Fix bug in mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007
< GitHub165> bitcoin/master d356560 Wladimir J. van der Laan: Merge pull request #7007...
< GitHub165> bitcoin/master a78e6ea Alex Morcos: Fix bug in mempool_tests unit test
< GitHub165> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f09b77c7fa5...d3565604e3d9
< wumpus> jonasschnelli: you can set the 'GUI' label yourself now :) say on https://github.com/bitcoin/bitcoin/pull/7006
< GitHub121> [bitcoin] morcos opened pull request #7008: Lower bound priority (master...lowerBoundPriority) https://github.com/bitcoin/bitcoin/pull/7008
< GitHub75> [bitcoin] morcos opened pull request #7007: Fix bug in unit mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007
< GitHub8> [bitcoin] sipa closed pull request #6983: Update libsecp256k1 (master...secp256k1new) https://github.com/bitcoin/bitcoin/pull/6983
< GitHub104> bitcoin/master 9e475d5 Pieter Wuille: Update libsecp256k1
< GitHub104> bitcoin/master 48edf57 Pieter Wuille: Update key.cpp to new secp256k1 API
< GitHub104> bitcoin/master 1d84107 Pieter Wuille: Squashed 'src/secp256k1/' changes from 22f60a6..2bfb82b...
< GitHub104> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2e987aa1929...4f09b77c7fa5
< GitHub21> [bitcoin] jonasschnelli opened pull request #7006: [Qt] add startup option to reset Qt settings (master...2015/11/qt_resetsettings) https://github.com/bitcoin/bitcoin/pull/7006
< GitHub147> [bitcoin] jgarzik opened pull request #7005: Add MAINTAINERS file, a user guide to code subsystems (master...2015_maintainer) https://github.com/bitcoin/bitcoin/pull/7005
< jonasschnelli> [12:41:14] <Luke-Jr>jonasschnelli: why a new key? :/ <-- the new key is not really new, It's just the one that I use for bitcoin-dev posts, etc. The "old" key is used for non-bitcoin software-projects (and sadly, i have used it for gitian signatures)
< michagogo> Are you opped in #bitcoin?
< GitHub8> [bitcoin] laanwj closed pull request #6958: [trivial] Cleanup maxuploadtarget (doc & log) (master...MarcoFalke-2015-maxupload) https://github.com/bitcoin/bitcoin/pull/6958
< GitHub22> bitcoin/master d2e987a Wladimir J. van der Laan: Merge pull request #6958...
< GitHub22> bitcoin/master 9c3ee3b MarcoFalke: [doc] Add -maxuploadtarget release notes
< GitHub22> bitcoin/master b27e81f MarcoFalke: [net] Cleanup maxuploadtarget...
< GitHub22> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/24c4841d1686...d2e987aa1929
< wumpus> 0.11.2 binaries are live: https://bitcoin.org/bin/bitcoin-core-0.11.2/
< michagogo> bitcoin-osx-unsigned.tar.gz
< Luke-Jr> the file gitian generates is bitcoin-0.11.2-osx-unsigned.tar.gz
< GitHub106> [bitcoin] jonasschnelli opened pull request #7004: update jonasschnellis gpg key (master...2015/11/signing_key_jonasschnelli) https://github.com/bitcoin/bitcoin/pull/7004
< GitHub28> [bitcoin] laanwj opened pull request #7003: doc: Add non-style-related development guidelines (master...2015_11_development_guidelines) https://github.com/bitcoin/bitcoin/pull/7003
< GitHub86> bitcoin/master 24c4841 Wladimir J. van der Laan: Merge pull request #6998...
< GitHub153> [bitcoin] laanwj closed pull request #6998: doc: Remove mention of pulltester from README.md (master...2015_11_readme_pull_pulltester) https://github.com/bitcoin/bitcoin/pull/6998
< GitHub86> bitcoin/master 01afa80 Wladimir J. van der Laan: doc: Remove mention of pulltester from README.md...
< GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/38ed190eefcc...24c4841d1686
< gmaxwell> So sipa updated this PR https://github.com/bitcoin/bitcoin/pull/6983 but I can't figure out what changed
< CodeShark> if I whitelist a node, other than network/transport issues or misbehaving, is there ever any conceivable situation where the node could get disconnected by bitcoin core
< dcousens> sorry, will go to bitcoin-dev

2015-11-12

< GitHub188> [bitcoin] jgarzik closed pull request #6771: Policy: Lower default limits for tx chains (master...lowerLimits) https://github.com/bitcoin/bitcoin/pull/6771
< GitHub107> bitcoin/master 38ed190 Jeff Garzik: Merge #6771 from branch 'lowerLimits' of git://github.com/morcos/bitcoin
< GitHub107> bitcoin/master 971a4e6 Alex Morcos: Lower default policy limits...
< GitHub107> [bitcoin] jgarzik pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd629d77edbe...38ed190eefcc
< jgarzik> morcos, the latter - I always travis in jgarzik/bitcoin on the merged tree before pushing
< gmaxwell> I mean, I'm probably at fault for making people think that its the only way to get a fraud proof for spending non-existing coins, since in the very first writeup I suggest that https://en.bitcoin.it/wiki/User:Gmaxwell/features#Proofs
< gmaxwell> it's been discussed in #bitcoin-wizards.
< Luke-Jr> wangchun: let's chat in #bitcoin since there is conversation here already
< GitHub56> [bitcoin] sdaftuar closed pull request #6992: [WIP] [Mempool] Add space for priority transactions (master...add-priority-to-mempool) https://github.com/bitcoin/bitcoin/pull/6992