2017-07-27

< gribble> https://github.com/bitcoin/bitcoin/issues/10778 | update assumevalid and minimum chain work · Issue #10778 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10919 | Fix more init bugs. by TheBlueMatt · Pull Request #10919 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< wumpus> kanzure: true, you can fork and edit locally, but I mean the bitcoin core master revision
< gribble> https://github.com/bitcoin/bitcoin/issues/10034 | sendtoaddress subtractfeefromamount=true does not respect paytxfee values · Issue #10034 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9889 | TODO for release notes 0.15.0 · Issue #9889 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10034 | sendtoaddress subtractfeefromamount=true does not respect paytxfee values · Issue #10034 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9278 | test_bitcoin fails valgrind · Issue #9278 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10931: Fix misleading "Method not found" multiwallet errors (master...pr/multierr) https://github.com/bitcoin/bitcoin/pull/10931
< bitcoin-git> bitcoin/master 0b11a07 Wladimir J. van der Laan: Merge #10931: Fix misleading "Method not found" multiwallet errors...
< bitcoin-git> bitcoin/master df389bc Russell Yanofsky: Change wallet method disabled error text...
< bitcoin-git> bitcoin/master e526b3d Russell Yanofsky: Fix misleading "Method not found" multiwallet errors...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ba1bbb049b8f...0b11a0784875
< bitcoin-git> [bitcoin] laanwj closed pull request #10892: Replace traditional for with ranged for in block and transaction primitives (master...20170721-rangedfor-primitives) https://github.com/bitcoin/bitcoin/pull/10892
< bitcoin-git> bitcoin/master ba1bbb0 Wladimir J. van der Laan: Merge #10892: Replace traditional for with ranged for in block and transaction primitives...
< bitcoin-git> bitcoin/master 72f0060 Dag Robole: Replace traditional for with ranged for in primitives
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a99fe053a5d...ba1bbb049b8f
< bitcoin-git> [bitcoin] laanwj closed pull request #10501: remove some unused functions (master...unusedfuncs) https://github.com/bitcoin/bitcoin/pull/10501
< bitcoin-git> bitcoin/master 8a99fe0 Wladimir J. van der Laan: Merge #10501: remove some unused functions...
< bitcoin-git> bitcoin/master f228b8e Marko Bencun: remove some unused functions...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c8eb7916de7...8a99fe053a5d
< gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify functional test by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #10941: Add blocknotify functional test (master...2017-07-blocknotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10941
< wumpus> gah, coredev.tech is september, scaling bitcoin in november, both in SF area, would have been better to plan it closer together :/
< wumpus> it doesn't belong in two places, no it just belongs in bitcoin-cli
< wumpus> why is it so much to ask that documentation for bitcoin-cli arguments belongs in bitcoin-cli?
< wumpus> sigh, no, I still don't think it's acceptable to mention bitcoin-cli specifically in RPC error messages, it should be aimed at people using the JSON-RPC API, not people using bitcoin-cli only
< bitcoin-git> [bitcoin] fanquake closed pull request #10940: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/10940
< bitcoin-git> [bitcoin] vadimVoloshanov opened pull request #10940: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/10940
< gribble> https://github.com/bitcoin/bitcoin/issues/2476 | no separate source code tarball download available · Issue #2476 · bitcoin/bitcoin · GitHub
< gmaxwell> ::sigh:: https://www.reddit.com/r/Bitcoin/comments/6pu13q/whats_up_with_bitcoin_core/ so github seems to be distributing tar files for our tags that have nothing to do with our distribution, and it sounds like netbsd's stuff was using them and is not happy that the checksums change (presumably because file order or compressor changed)

2017-07-26

< bitcoin-git> [bitcoin] practicalswift opened pull request #10939: Check that -blocknotify command is non-empty before executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939
< eck> wallet.dat file was stolen sept 2011, the same month encryption was added to bitcoin core (0.4.0 released sep 23, 2011)
< bitcoin-git> [bitcoin] laanwj reopened pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
< jtimon> can I build bitcoind but only bitcoind without bitcoin-cli, bitcoin-tx, libbitcoinconsensus.la, test/test_bitcoin_fuzzy, bench/bench_bitcoin and test/test_bitcoin ?
< bitcoin-git> [bitcoin] laanwj closed pull request #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp (master...arrays-are-not-pointers) https://github.com/bitcoin/bitcoin/pull/10912
< bitcoin-git> bitcoin/master 5c8eb79 Wladimir J. van der Laan: Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
< bitcoin-git> bitcoin/master 065039d practicalswift: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dd6a2be4188...5c8eb7916de7
< bitcoin-git> [bitcoin] fanquake closed pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937
< bitcoin-git> [bitcoin] laanwj closed pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936
< bitcoin-git> [bitcoin] fanquake closed pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936
< bitcoin-git> [bitcoin] fanquake closed pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935
< bitcoin-git> [bitcoin] fanquake closed pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934
< bitcoin-git> [bitcoin] fanquake closed pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933
< bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10932: Create models.js (master...patch-5) https://github.com/bitcoin/bitcoin/pull/10932
< bitcoin-git> bitcoin/master 5c003cb Wladimir J. van der Laan: Merge #10917: developer-notes: add reference to snake_case and PascalCase...
< bitcoin-git> [bitcoin] laanwj closed pull request #10917: developer-notes: add reference to snake_case and PascalCase (master...pascalcase) https://github.com/bitcoin/bitcoin/pull/10917
< bitcoin-git> bitcoin/master 4a7a4ff Marko Bencun: developer-notes: add reference to snake_case and PascalCase...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/04d395e8327d...5c003cb1afcb
< bitcoin-git> [bitcoin] ryanofsky opened pull request #10931: Fix misleading "Method not found" multiwallet errors (master...pr/multierr) https://github.com/bitcoin/bitcoin/pull/10931
< gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
< bitcoin-git> bitcoin/master 04d395e Wladimir J. van der Laan: Merge #10854: Avoid using sizes on non-fixed-width types to derive protocol constants....
< bitcoin-git> bitcoin/master 095b917 Gregory Maxwell: Avoid using sizes on non-fixed-width types to derive protocol constants....
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78f307b66428...04d395e8327d
< bitcoin-git> [bitcoin] laanwj closed pull request #10655: Properly document target_confirmations in listsinceblock (master...listsinceblock) https://github.com/bitcoin/bitcoin/pull/10655
< bitcoin-git> bitcoin/master 9f8a46f Ryan Havar: Properly document target_confirmations in listsinceblock
< bitcoin-git> bitcoin/master 78f307b Wladimir J. van der Laan: Merge #10655: Properly document target_confirmations in listsinceblock...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b995a374f727...78f307b66428
< bitcoin-git> [bitcoin] laanwj closed pull request #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (master...2017-04-fix-missing-scheduler-lock) https://github.com/bitcoin/bitcoin/pull/10914
< bitcoin-git> bitcoin/master b995a37 Wladimir J. van der Laan: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()...
< bitcoin-git> bitcoin/master a56f8b0 Matt Corallo: Add missing lock in CScheduler::AreThreadsServicingQueue()...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f29d5dbd04da...b995a374f727
< bitcoin-git> [bitcoin] laanwj closed pull request #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
< bitcoin-git> bitcoin/master f29d5db Wladimir J. van der Laan: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds...
< bitcoin-git> bitcoin/master 0be03c7 Brian McMichael: Qt: Use _putenv_s instead of setenv on Windows builds
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8537187d4213...f29d5dbd04da
< bitcoin-git> [bitcoin] sipa closed pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
< bitcoin-git> [bitcoin] DevlinShepherd opened pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
< gribble> https://github.com/bitcoin/bitcoin/issues/10703 | [tests] Allow tests to pass when stderr is non-empty by jnewbery · Pull Request #10703 · bitcoin/bitcoin · GitHub

2017-07-25

< bitcoin-git> bitcoin/master 8537187 Wladimir J. van der Laan: Merge #10799: Prevent user from specifying conflicting parameters to fundrawtx...
< bitcoin-git> [bitcoin] laanwj closed pull request #10799: Prevent user from specifying conflicting parameters to fundrawtx (master...2017-07-no-fundraw-conflicts) https://github.com/bitcoin/bitcoin/pull/10799
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d5e8f92a7db...8537187d4213
< bitcoin-git> bitcoin/master 99c7fc3 Matt Corallo: Prevent user from specifying conflicting parameters to fundrawtx...
< bitcoin-git> [bitcoin] laanwj closed pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
< bitcoin-git> bitcoin/master 9d5e8f9 Wladimir J. van der Laan: Merge #10927: test: Make sure wallet.backup is created in temp path...
< bitcoin-git> bitcoin/master 88af227 Wladimir J. van der Laan: test: Make sure wallet.backup is created in temp path...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60f9778abfea...9d5e8f92a7db
< bitcoin-git> bitcoin/master 60f9778 Wladimir J. van der Laan: Revert "[tests] Allow tests to pass when stderr is non-empty"...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/60f9778abfea615beac384a08e6a13ebec65275b
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10703: [tests] Allow tests to pass when stderr is non-empty (master...test_stderr) https://github.com/bitcoin/bitcoin/pull/10703
< bitcoin-git> bitcoin/master f1f1605 MarcoFalke: Merge #10703: [tests] Allow tests to pass when stderr is non-empty...
< bitcoin-git> bitcoin/master d64ac3f Jonas Schnelli: [tests] Allow tests to pass when stderr is non-empty...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1caafa6cde3b...f1f1605c22a6
< promag> wumpus: please restart job https://travis-ci.org/bitcoin/bitcoin/jobs/257251574
< BlueMatt> jonasschnelli: oh, i see your confusion, no, what you want to look at is https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2197
< bitcoin-git> [bitcoin] laanwj opened pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
< bitcoin-git> [bitcoin] laanwj reopened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
< bitcoin-git> [bitcoin] laanwj closed pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
< bitcoin-git> bitcoin/master 4f92b5f Russell Yanofsky: Run Qt wallet tests on travis...
< bitcoin-git> bitcoin/master 1caafa6 Wladimir J. van der Laan: Merge #10508: Run Qt wallet tests on travis...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/412b466d11ff...1caafa6cde3b
< bitcoin-git> [bitcoin] laanwj closed pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
< bitcoin-git> [bitcoin] laanwj closed pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
< bitcoin-git> bitcoin/master 412b466 Wladimir J. van der Laan: Merge #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets...
< bitcoin-git> bitcoin/master 9737572 Jonas Schnelli: [Qt] Use wallet 0 in rpc console if running with multiple wallets
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1124328ad1e8...412b466d11ff
< bitcoin-git> [bitcoin] laanwj closed pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
< bitcoin-git> [bitcoin] laanwj closed pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
< bitcoin-git> [bitcoin] fanquake closed pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
< bitcoin-git> [bitcoin] kore90 opened pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
< jonasschnelli> Is that comment correct? https://github.com/bitcoin/bitcoin/blob/master/src/validationinterface.h#L53 ( BlueMatt )
< bitcoin-git> [bitcoin] laanwj closed pull request #10789: Punctuation/grammer fixes in rpcwallet.cpp (master...cli-punctuation-standardization) https://github.com/bitcoin/bitcoin/pull/10789
< bitcoin-git> bitcoin/master 1124328 Wladimir J. van der Laan: Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp...
< bitcoin-git> bitcoin/master a5ecaf1 Steven D. Lander: Fix misspellings and remove safety verbiage
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c70e845aa92...1124328ad1e8
< bitcoin-git> [bitcoin] practicalswift opened pull request #10923: Use -Wthread-safety-analysis if available (+ -Werror=thread-safety-analysis if --enable-werror) (master...thread-safety-analysis) https://github.com/bitcoin/bitcoin/pull/10923

2017-07-24

< bitcoin-git> [bitcoin] jimhashhq opened pull request #10922: New file-partiion.md doc describing how to partition files to ensure fast initial blockchain synchronization.. (master...master) https://github.com/bitcoin/bitcoin/pull/10922
< bitcoin-git> [bitcoin] practicalswift opened pull request #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) (master...fix-newPossibleKeyChange-memory-leak) https://github.com/bitcoin/bitcoin/pull/10920
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10919: Fix more init bugs. (master...2017-07-init-bugs) https://github.com/bitcoin/bitcoin/pull/10919
< bitcoin-git> [bitcoin] laanwj closed pull request #10865: Move CloseSocket out of SetSocketNonBlocking and pass socket as const reference (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
< bitcoin-git> bitcoin/master 0c70e84 Wladimir J. van der Laan: Merge #10865: Move CloseSocket out of SetSocketNonBlocking and pass socket as const reference...
< bitcoin-git> bitcoin/master 05e023f Dag Robole: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ef3c7ec6233...0c70e845aa92
< promag> someone can restart job https://travis-ci.org/bitcoin/bitcoin/jobs/256251292?
< bitcoin-git> [bitcoin] laanwj closed pull request #10580: Prefer gpg2 to gpg (master...prefer_gpg2) https://github.com/bitcoin/bitcoin/pull/10580
< bitcoin-git> [bitcoin] laanwj closed pull request #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block (master...listsinceblock-include-lost-txs) https://github.com/bitcoin/bitcoin/pull/9622
< bitcoin-git> bitcoin/master 6ef3c7e Wladimir J. van der Laan: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block...
< bitcoin-git> bitcoin/master 876e92b Karl-Johan Alm: Testing: listsinceblock should display all transactions that were affected since the given block, including transactions that were removed due to a reorg.
< bitcoin-git> bitcoin/master f999c46 Karl-Johan Alm: listsinceblock: optionally find and list any transactions that were undone due to reorg when requesting a non-main chain block in a new 'removed' array.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c173a15ca1b...6ef3c7ec6233
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10894: Add CChain object for headers-only chain (master...2017/07/hdr_chain) https://github.com/bitcoin/bitcoin/pull/10894
< bitcoin-git> [bitcoin] benma opened pull request #10917: developer-notes: CamelCase -> PascalCase (master...pascalcase) https://github.com/bitcoin/bitcoin/pull/10917

2017-07-23

< bitcoin-git> [bitcoin] benma opened pull request #10916: add missing lock to crypter GetKeys() (master...GetKeys) https://github.com/bitcoin/bitcoin/pull/10916
< BlueMatt> phantomcircuit: dunno, got a guy I'm talking to claiming to run stock ppa 0.14.2 with a somewhat-reasonable bitcoin.conf and his node isnt sending any messages (not even veracks)
< bitcoin-git> [bitcoin] benma opened pull request #10915: get rid of the fRelayTxes global (master...fRelayTxes) https://github.com/bitcoin/bitcoin/pull/10915
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (master...2017-04-fix-missing-scheduler-lock) https://github.com/bitcoin/bitcoin/pull/10914
< bitcoin-git> [bitcoin] fanquake closed pull request #10913: fixing a couple of typos (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10913
< bitcoin-git> [bitcoin] tiagmoraismorgado opened pull request #10913: fixing a couple of typos (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10913

2017-07-22

< bitcoin-git> [bitcoin] practicalswift opened pull request #10912: [tests] Remove incorrect memory_cleanse(…) call in crypto_tests.cpp (master...arrays-are-not-pointers) https://github.com/bitcoin/bitcoin/pull/10912
< bitcoin-git> [bitcoin] keystrike opened pull request #10911: Typo in optionsdialog.ui (master...master) https://github.com/bitcoin/bitcoin/pull/10911
< bitcoin-git> [bitcoin] fanquake closed pull request #10908: pls review (master...master) https://github.com/bitcoin/bitcoin/pull/10908
< bitcoin-git> [bitcoin] Astrali opened pull request #10908: pls review (master...master) https://github.com/bitcoin/bitcoin/pull/10908
< bitcoin-git> [bitcoin] corebob opened pull request #10907: Prefer iterators arrow operator over iterator dereference (master...20170722-refactor-arrow-1) https://github.com/bitcoin/bitcoin/pull/10907
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10893: [QA] Avoid running multiwallet.py twice (master...2017/07/fix_mw_test) https://github.com/bitcoin/bitcoin/pull/10893
< bitcoin-git> bitcoin/master 0c173a1 MarcoFalke: Merge #10893: [QA] Avoid running multiwallet.py twice...
< bitcoin-git> bitcoin/master 44eb9d4 Jonas Schnelli: [QA] Avoid running multiwallet.py twice
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/420238d3103a...0c173a15ca1b
< bitcoin-git> [bitcoin] jamesob opened pull request #10903: Add configuration files for a Docker-based development environment (master...docker) https://github.com/bitcoin/bitcoin/pull/10903
< praxeology> which would then potentially result in the longest valid chain (as appearing to current bitcoin core clients) to swap back and forth between the chain w/ the non-segwit-signal chain and the all segwit-signal chain

2017-07-21

< bitcoin-git> [bitcoin] promag opened pull request #10901: Fix constness of ArgsManager methods (master...2017-07-args-manager-constness) https://github.com/bitcoin/bitcoin/pull/10901
< bitcoin-git> [bitcoin] achow101 opened pull request #10900: [0.14] Enforce segsignal activation height and rules (0.14...early-uasf-bip91) https://github.com/bitcoin/bitcoin/pull/10900
< bitcoin-git> [bitcoin] brianmcmichael opened pull request #10899: Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
< [\\\]> this is slightly off topic, but I'm asking anyway: any reason to allow or not allow bitcoinuasf.org in #bitcoin ?
< praxeology> sipa: then it sounds to me like you have decided that you do want 91 to be enforced... for it to become the new bitcoin
< bitcoin-git> [bitcoin] practicalswift opened pull request #10898: Fix invalid checks (NULL checks after dereference, redundant checks, etc.) (master...invalid-logic) https://github.com/bitcoin/bitcoin/pull/10898
< bitcoin-git> [bitcoin] practicalswift closed pull request #10895: [wallet] Fix wallet memory leaks in cases of unsuccessful CreateWalletFromFile calls (master...wallet-memory-leaks) https://github.com/bitcoin/bitcoin/pull/10895
< gmaxwell> while true; do if [ `./bitcoin-cli getblockcount` -gt 476892 ]; then echo alarm_goes_here ; fi ; sleep 10 ; done
< gribble> https://github.com/bitcoin/bitcoin/issues/10444 | Implement BIP91 Reduced threshold Segwit MASF by jameshilliard · Pull Request #10444 · bitcoin/bitcoin · GitHub
< morcos> gmaxwell: I think the point is that we as a community could decide that BIP91 is the new rules of Bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/1144 | json_spirit_writer_template.h - comparison is always true due to limited range of data type warning · Issue #1144 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10896: Optimize compact reconstruction somewhat (master...2017-07-faster-compact-reconstruction) https://github.com/bitcoin/bitcoin/pull/10896
< bitcoin-git> [bitcoin] practicalswift opened pull request #10895: [wallet] Fix wallet memory leaks in cases of unsuccessful CreateWalletFromFile calls (master...wallet-memory-leaks) https://github.com/bitcoin/bitcoin/pull/10895
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10894: Add CChain object for headers-only chain (master...2017/07/hdr_chain) https://github.com/bitcoin/bitcoin/pull/10894
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #10893: [QA] Avoid running multiwallet.py twice (master...2017/07/fix_mw_test) https://github.com/bitcoin/bitcoin/pull/10893
< bitcoin-git> [bitcoin] laanwj closed pull request #10604: [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test (master...multiwallet_test) https://github.com/bitcoin/bitcoin/pull/10604
< bitcoin-git> bitcoin/master 9508761 John Newbery: [wallet] [rpc] Add listwallets RPC...
< bitcoin-git> bitcoin/master 4a05715 John Newbery: [wallet] [rpc] print wallet name in getwalletinfo
< bitcoin-git> bitcoin/master 09eacee John Newbery: [wallet] fix comment for CWallet::Verify()
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/6adc3a37324c...420238d3103a
< bitcoin-git> [bitcoin] corebob opened pull request #10892: Replace traditional for with ranged for in block and transaction primitives (master...20170721-rangedfor-primitives) https://github.com/bitcoin/bitcoin/pull/10892
< morcos> its terrible that i bet between all of us here, we can't even agree on what the rules of bitcoin are 48 hours from now. if miners don't follow BIP 91, what do we do?
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #10891: [RPC] Make ImportAddress works with segwit scriptPubKey (master...importaddresswitness) https://github.com/bitcoin/bitcoin/pull/10891
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10891: [RPC] Make ImportAddress works with segwit scriptPubKey (master...importaddresswitness) https://github.com/bitcoin/bitcoin/pull/10891
< bitcoin-git> [bitcoin] rohythakur opened pull request #10890: added version (master...master) https://github.com/bitcoin/bitcoin/pull/10890
< bitcoin-git> [bitcoin] brianmcmichael opened pull request #10889: Docs: Run windows build in a clean path (master...docswin) https://github.com/bitcoin/bitcoin/pull/10889

2017-07-20

< bitcoin-git> bitcoin/master 6adc3a3 Wladimir J. van der Laan: qt: Periodic translations update...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/6adc3a37324caa07015368bfe8529e1964366eef
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< instagibbs> sorry for #bitcoin level q, testing
< kanzure> the bitcoin.org warning was about aug1?
< instagibbs> bitcoincore.org could have something like bitcoin.org's warning
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8745 | [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli · Pull Request #8745 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10526 | Force on-the-fly compaction during pertxout upgrade by sipa · Pull Request #10526 · bitcoin/bitcoin · GitHub
< instagibbs> so, there's gotta be something better than "load your wallet in an older bitcoin instance"
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10821 | Add SSE4 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 has pretty much been cleaned out (only #10652 left), anything new?
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< wumpus> BlueMatt: https://github.com/laanwj/bitcoin/tree/2016_05_sha256_accel readme.md has some benchmarks
< bitcoin-git> [bitcoin] laanwj closed pull request #10821: Add SSE4 optimized SHA256 (master...20170713_shasse) https://github.com/bitcoin/bitcoin/pull/10821
< bitcoin-git> bitcoin/master c1ccb15 Pieter Wuille: Add SSE4 based SHA256
< bitcoin-git> bitcoin/master 2991c91 Pieter Wuille: Add SHA256 dispatcher
< bitcoin-git> bitcoin/master 4d50f38 Pieter Wuille: Support multi-block SHA256 transforms...
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c2400cb8ab7...16240f43a550
< wumpus> there's no reason bitcoind couldn't have a dynamic settings mechanism, with some configuration that automatically gets re-loaded on next run, for example the bitcoin-rw.conf idea
< jonasschnelli> https://github.com/bitcoin/bitcoin/pull/10870#discussion_r128546723 must be removed (replaced) once 0.15 is fixed.
< jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/10870#discussion_r128546723, .. what do you think about not doing the URL encode
< bitcoin-git> [bitcoin] laanwj closed pull request #10775: nCheckDepth chain height fix (master...master) https://github.com/bitcoin/bitcoin/pull/10775
< bitcoin-git> bitcoin/master d9d1bd3 romanornr: nCheckDepth chain height fix
< bitcoin-git> bitcoin/master 7c2400c Wladimir J. van der Laan: Merge #10775: nCheckDepth chain height fix...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/041dad94b047...7c2400cb8ab7
< gribble> https://github.com/bitcoin/bitcoin/issues/10882 | [WIP] Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10783: [RPC] Various rpc argument fixes (master...rpcargfixes) https://github.com/bitcoin/bitcoin/pull/10783
< bitcoin-git> bitcoin/master 4dc1915 Gregory Sanders: check for null values in rpc args and handle appropriately
< bitcoin-git> bitcoin/master 999ef20 Gregory Sanders: importmulti options are optional
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd2814ef1182...041dad94b047
< bitcoin-git> bitcoin/master a70d025 Gregory Sanders: fixup some rpc param counting for rpc help
< bitcoin-git> [bitcoin] laanwj closed pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition". (master...nEnd) https://github.com/bitcoin/bitcoin/pull/10862
< bitcoin-git> bitcoin/master fd2814e Wladimir J. van der Laan: Merge #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition"....
< bitcoin-git> bitcoin/master 5a6671c practicalswift: Fix typo: "conditon" → "condition"...
< bitcoin-git> bitcoin/master 35aff43 practicalswift: Remove unused variable int64_t nEnd...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/adf170daf90f...fd2814ef1182
< bitcoin-git> [bitcoin] laanwj closed pull request #10571: [RPC]Move transaction combining from signrawtransaction to new RPC (master...combineraw-rpc) https://github.com/bitcoin/bitcoin/pull/10571
< bitcoin-git> bitcoin/master adf170d Wladimir J. van der Laan: Merge #10571: [RPC]Move transaction combining from signrawtransaction to new RPC...
< bitcoin-git> bitcoin/master 6b4f231 Andrew Chow: Move transaction combining from signrawtransaction to new RPC...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf3b742e2852...adf170daf90f
< bitcoin-git> [bitcoin] jnewbery closed pull request #10868: Remove -usewallet (master...remove_use_wallet) https://github.com/bitcoin/bitcoin/pull/10868
< bitcoin-git> [bitcoin] benma opened pull request #10888: range-based loops and const qualifications in net.cpp (master...netcpp_cosmetics2) https://github.com/bitcoin/bitcoin/pull/10888
< bitcoin-git> [bitcoin] laanwj closed pull request #10883: Rename -usewallet to -rpcwallet (master...rpcwallet) https://github.com/bitcoin/bitcoin/pull/10883
< bitcoin-git> bitcoin/master bf3b742 Wladimir J. van der Laan: Merge #10883: Rename -usewallet to -rpcwallet...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df0793f324e3...bf3b742e2852
< bitcoin-git> bitcoin/master 2264236 Alex Morcos: Rename -usewallet to -rpcwallet
< wumpus> he also has some english to english messages in de_DE https://www.transifex.com/bitcoin/bitcoin/translate/#de_DE/$/65093519?user=pehotinec
< wumpus> e.g. nearly all of these are nonsense https://www.transifex.com/bitcoin/bitcoin/translate/#de/$/104570304?user=pehotinec, sometimes he copies slightly similar messages to make it look ok, sometimes he just copies the English message, in any cast this seems deliberate
< bitcoin-git> [bitcoin] MeshCollider closed pull request #10886: Remove unused #define in sync.h (master...remove-unused-define) https://github.com/bitcoin/bitcoin/pull/10886
< bitcoin-git> [bitcoin] MeshCollider opened pull request #10886: Remove unused #define in sync.h (master...remove-unused-define) https://github.com/bitcoin/bitcoin/pull/10886
< bitcoin-git> [bitcoin] promag opened pull request #10885: Prevent duplicate wallets (master...2017-07-prevent-duplicate-wallets) https://github.com/bitcoin/bitcoin/pull/10885

2017-07-19

< promag> is this correct bitcoin-qt -wallet=foo.dat -wallet=wallet.dat -regtest ?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10681: add gdb attach process to test README (master...gdbattach) https://github.com/bitcoin/bitcoin/pull/10681
< bitcoin-git> bitcoin/master 7ec3343 Gregory Sanders: add gdb attach process to test README
< bitcoin-git> bitcoin/master df0793f MarcoFalke: Merge #10681: add gdb attach process to test README...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d445a2c2eaa1...df0793f324e3
< bitcoin-git> [bitcoin] eliahuhorwitz opened pull request #10884: Update build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10884
< jnewbery> I suppose we'll generally need to give bitcoin-cli more smarts if we do wallet process separation
< jonasschnelli> BTW: github recommends to add a COC to the bitcoin core project: https://opensource.guide/code-of-conduct/
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
< bitcoin-git> [bitcoin] morcos opened pull request #10883: Rename -usewallet to -rpcwallet (master...rpcwallet) https://github.com/bitcoin/bitcoin/pull/10883
< instagibbs> eck, #bitcoin (can answer there)
< jonasschnelli> But I guess what we should merge for 0.15 is the Qt console support: https://github.com/bitcoin/bitcoin/pull/10870
< jonasschnelli> Should we still revoke (halt bitcoin-cli) if one provides multiple -rpc/-usewallet arguments?
< wumpus> if it wasn't for the authentication options we could stop parsing bitcoin.conf completely for the -cli
< sipa> ./bitcoin-cli -thethingimean=foo
< gmaxwell> is it the setting that tells bitcoin-cli what wallet to talk to
< jonasschnelli> I just though until now, I could not see any "rpc" in bitcoin-cli (from the users perspetive)
< sipa> bitcoin-cli is an rpc client
< jonasschnelli> I probably over-engineer. But what if we once change bitcoin-cli's transport layer?
< jonasschnelli> isn't bitcoin-cli transport agnostic?
< bitcoin-git> [bitcoin] jnewbery closed pull request #10830: [WIP] [wallet] keypool restore (master...pr10240) https://github.com/bitcoin/bitcoin/pull/10830
< gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10882: [WIP] Keypool topup (master...keypool_topup) https://github.com/bitcoin/bitcoin/pull/10882
< jnewbery> but specifying the wrong -dbcache on the command line for bitcoin-cli cannot lead to loss of funds
< jnewbery> >we don't complain in bitcoin-cli that -dbcache is specfied
< gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< sipa> but we don't complain in bitcoin-cli that -dbcache is specfied, right?
< jnewbery> I think Russ is thinking about the case where someone starts bitcoind with -wallet=mybusinesswallet.dat in the conf file, then calls `bitcoin-cli -wallet=mypersonalwallet.dat send ...` and is confused that money is sent from their business wallet even though they specified a different wallet
< ryanofsky> yes that's why i said "on bitcoin-cli command line"
< ryanofsky> maybe also consider making it an error for user to specify -wallet on bitcoin-cli command line if it will be ignored
< jnewbery> Because of the arguments I give here: https://github.com/bitcoin/bitcoin/pull/10868#issuecomment-316409725
< wumpus> why owuld that be strange? bitcoin-cli has lots of arguments that are not used by bitcoind
< jnewbery> having a `useargument` argument that is used by bitcoin-cli but is not used by bitcoind seems strange to me
< wumpus> if bitcoin-cli would not read the config file at all, or a different config file, I'd be ok with it
< ryanofsky> wumpus, yes, the tradeoff for having bitcoin-cli accept a wallet argument is having to ignore wallet values from the config file
< wumpus> e.g. you might want to set a default wallet for bitcoin-cli to use in the configuration file, you can't use -wallet for that
< wumpus> I don't think re-using -wallet for bitcoin-cli is a good idea
< sipa> jonasschnelli: but it's not so different from how -rpcport for bitcoind means "the port to listen on" nd for bitcoin-cli means "the port to connect to"
< jnewbery> but how -usewallet is interpreted is differentiated as well - acted on by bitcoin-cli, ignored by bitcoind, and you haven't decided on whether it should be ignored or not by bitcoin-qt
< ryanofsky> that is a drawback. if you want bitcoin-cli to be able to use wallet filename from a config file, you have to call the option something other than -wallet
< jonasschnelli> I just can't follow why you would want to add code to differenciate -wallet in bitcoin conf to -wallet passed into bitcoin-cli
< ryanofsky> users should just be shown an error if they are expecting bitcoin-cli to send an single rpc command to multiple wallets
< bitcoin-git> [bitcoin] laanwj closed pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< bitcoin-git> bitcoin/master d445a2c Wladimir J. van der Laan: Merge #10857: [RPC] Add a deprecation warning to getinfo's output...