< bitcoin-git>
[bitcoin] laanwj closed pull request #10892: Replace traditional for with ranged for in block and transaction primitives (master...20170721-rangedfor-primitives) https://github.com/bitcoin/bitcoin/pull/10892
< bitcoin-git>
bitcoin/master ba1bbb0 Wladimir J. van der Laan: Merge #10892: Replace traditional for with ranged for in block and transaction primitives...
< bitcoin-git>
bitcoin/master 72f0060 Dag Robole: Replace traditional for with ranged for in primitives
< bitcoin-git>
[bitcoin] promag opened pull request #10941: Add blocknotify functional test (master...2017-07-blocknotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10941
< wumpus>
gah, coredev.tech is september, scaling bitcoin in november, both in SF area, would have been better to plan it closer together :/
< wumpus>
it doesn't belong in two places, no it just belongs in bitcoin-cli
< wumpus>
why is it so much to ask that documentation for bitcoin-cli arguments belongs in bitcoin-cli?
< wumpus>
sigh, no, I still don't think it's acceptable to mention bitcoin-cli specifically in RPC error messages, it should be aimed at people using the JSON-RPC API, not people using bitcoin-cli only
< gmaxwell>
::sigh:: https://www.reddit.com/r/Bitcoin/comments/6pu13q/whats_up_with_bitcoin_core/ so github seems to be distributing tar files for our tags that have nothing to do with our distribution, and it sounds like netbsd's stuff was using them and is not happy that the checksums change (presumably because file order or compressor changed)
2017-07-26
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10939: Check that -blocknotify command is non-empty before executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939
< eck>
wallet.dat file was stolen sept 2011, the same month encryption was added to bitcoin core (0.4.0 released sep 23, 2011)
< bitcoin-git>
[bitcoin] laanwj reopened pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
< jtimon>
can I build bitcoind but only bitcoind without bitcoin-cli, bitcoin-tx, libbitcoinconsensus.la, test/test_bitcoin_fuzzy, bench/bench_bitcoin and test/test_bitcoin ?
< bitcoin-git>
[bitcoin] laanwj closed pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
< bitcoin-git>
bitcoin/master 04d395e Wladimir J. van der Laan: Merge #10854: Avoid using sizes on non-fixed-width types to derive protocol constants....
< bitcoin-git>
bitcoin/master 095b917 Gregory Maxwell: Avoid using sizes on non-fixed-width types to derive protocol constants....
< bitcoin-git>
[bitcoin] laanwj closed pull request #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
< bitcoin-git>
bitcoin/master f29d5db Wladimir J. van der Laan: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds...
< bitcoin-git>
bitcoin/master 0be03c7 Brian McMichael: Qt: Use _putenv_s instead of setenv on Windows builds
< bitcoin-git>
bitcoin/master 99c7fc3 Matt Corallo: Prevent user from specifying conflicting parameters to fundrawtx...
< bitcoin-git>
[bitcoin] laanwj closed pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
< bitcoin-git>
bitcoin/master 9d5e8f9 Wladimir J. van der Laan: Merge #10927: test: Make sure wallet.backup is created in temp path...
< bitcoin-git>
bitcoin/master 88af227 Wladimir J. van der Laan: test: Make sure wallet.backup is created in temp path...
< bitcoin-git>
[bitcoin] laanwj opened pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10923: Use -Wthread-safety-analysis if available (+ -Werror=thread-safety-analysis if --enable-werror) (master...thread-safety-analysis) https://github.com/bitcoin/bitcoin/pull/10923
2017-07-24
< bitcoin-git>
[bitcoin] jimhashhq opened pull request #10922: New file-partiion.md doc describing how to partition files to ensure fast initial blockchain synchronization.. (master...master) https://github.com/bitcoin/bitcoin/pull/10922
< bitcoin-git>
[bitcoin] laanwj closed pull request #10865: Move CloseSocket out of SetSocketNonBlocking and pass socket as const reference (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
< bitcoin-git>
bitcoin/master 0c70e84 Wladimir J. van der Laan: Merge #10865: Move CloseSocket out of SetSocketNonBlocking and pass socket as const reference...
< bitcoin-git>
bitcoin/master 05e023f Dag Robole: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions
< bitcoin-git>
[bitcoin] laanwj closed pull request #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block (master...listsinceblock-include-lost-txs) https://github.com/bitcoin/bitcoin/pull/9622
< bitcoin-git>
bitcoin/master 6ef3c7e Wladimir J. van der Laan: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block...
< bitcoin-git>
bitcoin/master 876e92b Karl-Johan Alm: Testing: listsinceblock should display all transactions that were affected since the given block, including transactions that were removed due to a reorg.
< bitcoin-git>
bitcoin/master f999c46 Karl-Johan Alm: listsinceblock: optionally find and list any transactions that were undone due to reorg when requesting a non-main chain block in a new 'removed' array.
< BlueMatt>
phantomcircuit: dunno, got a guy I'm talking to claiming to run stock ppa 0.14.2 with a somewhat-reasonable bitcoin.conf and his node isnt sending any messages (not even veracks)
< bitcoin-git>
[bitcoin] jamesob opened pull request #10903: Add configuration files for a Docker-based development environment (master...docker) https://github.com/bitcoin/bitcoin/pull/10903
< praxeology>
which would then potentially result in the longest valid chain (as appearing to current bitcoin core clients) to swap back and forth between the chain w/ the non-segwit-signal chain and the all segwit-signal chain
2017-07-21
< bitcoin-git>
[bitcoin] promag opened pull request #10901: Fix constness of ArgsManager methods (master...2017-07-args-manager-constness) https://github.com/bitcoin/bitcoin/pull/10901
< bitcoin-git>
[bitcoin] achow101 opened pull request #10900: [0.14] Enforce segsignal activation height and rules (0.14...early-uasf-bip91) https://github.com/bitcoin/bitcoin/pull/10900
< bitcoin-git>
[bitcoin] brianmcmichael opened pull request #10899: Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
< [\\\]>
this is slightly off topic, but I'm asking anyway: any reason to allow or not allow bitcoinuasf.org in #bitcoin ?
< praxeology>
sipa: then it sounds to me like you have decided that you do want 91 to be enforced... for it to become the new bitcoin
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10898: Fix invalid checks (NULL checks after dereference, redundant checks, etc.) (master...invalid-logic) https://github.com/bitcoin/bitcoin/pull/10898
< morcos>
gmaxwell: I think the point is that we as a community could decide that BIP91 is the new rules of Bitcoin
< gribble>
https://github.com/bitcoin/bitcoin/issues/1144 | json_spirit_writer_template.h - comparison is always true due to limited range of data type warning · Issue #1144 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #10604: [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test (master...multiwallet_test) https://github.com/bitcoin/bitcoin/pull/10604
< bitcoin-git>
[bitcoin] corebob opened pull request #10892: Replace traditional for with ranged for in block and transaction primitives (master...20170721-rangedfor-primitives) https://github.com/bitcoin/bitcoin/pull/10892
< morcos>
its terrible that i bet between all of us here, we can't even agree on what the rules of bitcoin are 48 hours from now. if miners don't follow BIP 91, what do we do?
< bitcoin-git>
[bitcoin] NicolasDorier closed pull request #10891: [RPC] Make ImportAddress works with segwit scriptPubKey (master...importaddresswitness) https://github.com/bitcoin/bitcoin/pull/10891
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #10891: [RPC] Make ImportAddress works with segwit scriptPubKey (master...importaddresswitness) https://github.com/bitcoin/bitcoin/pull/10891
< gribble>
https://github.com/bitcoin/bitcoin/issues/10604 | [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test by jnewbery · Pull Request #10604 · bitcoin/bitcoin · GitHub
< wumpus>
there's no reason bitcoind couldn't have a dynamic settings mechanism, with some configuration that automatically gets re-loaded on next run, for example the bitcoin-rw.conf idea
< wumpus>
e.g. nearly all of these are nonsense https://www.transifex.com/bitcoin/bitcoin/translate/#de/$/104570304?user=pehotinec, sometimes he copies slightly similar messages to make it look ok, sometimes he just copies the English message, in any cast this seems deliberate
< jnewbery>
but specifying the wrong -dbcache on the command line for bitcoin-cli cannot lead to loss of funds
< jnewbery>
>we don't complain in bitcoin-cli that -dbcache is specfied
< gribble>
https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< sipa>
but we don't complain in bitcoin-cli that -dbcache is specfied, right?
< jnewbery>
I think Russ is thinking about the case where someone starts bitcoind with -wallet=mybusinesswallet.dat in the conf file, then calls `bitcoin-cli -wallet=mypersonalwallet.dat send ...` and is confused that money is sent from their business wallet even though they specified a different wallet
< ryanofsky>
yes that's why i said "on bitcoin-cli command line"
< ryanofsky>
maybe also consider making it an error for user to specify -wallet on bitcoin-cli command line if it will be ignored
< wumpus>
why owuld that be strange? bitcoin-cli has lots of arguments that are not used by bitcoind
< jnewbery>
having a `useargument` argument that is used by bitcoin-cli but is not used by bitcoind seems strange to me
< wumpus>
if bitcoin-cli would not read the config file at all, or a different config file, I'd be ok with it
< ryanofsky>
wumpus, yes, the tradeoff for having bitcoin-cli accept a wallet argument is having to ignore wallet values from the config file
< wumpus>
e.g. you might want to set a default wallet for bitcoin-cli to use in the configuration file, you can't use -wallet for that
< wumpus>
I don't think re-using -wallet for bitcoin-cli is a good idea
< sipa>
jonasschnelli: but it's not so different from how -rpcport for bitcoind means "the port to listen on" nd for bitcoin-cli means "the port to connect to"
< jnewbery>
but how -usewallet is interpreted is differentiated as well - acted on by bitcoin-cli, ignored by bitcoind, and you haven't decided on whether it should be ignored or not by bitcoin-qt
< ryanofsky>
that is a drawback. if you want bitcoin-cli to be able to use wallet filename from a config file, you have to call the option something other than -wallet
< jonasschnelli>
I just can't follow why you would want to add code to differenciate -wallet in bitcoin conf to -wallet passed into bitcoin-cli
< ryanofsky>
users should just be shown an error if they are expecting bitcoin-cli to send an single rpc command to multiple wallets
< bitcoin-git>
[bitcoin] laanwj closed pull request #10857: [RPC] Add a deprecation warning to getinfo's output (master...deprecate-getinfo) https://github.com/bitcoin/bitcoin/pull/10857
< bitcoin-git>
bitcoin/master d445a2c Wladimir J. van der Laan: Merge #10857: [RPC] Add a deprecation warning to getinfo's output...