2016-11-25

< gribble> https://github.com/bitcoin/bitcoin/issues/8844 | Change sigops cost to sigops weight by jnewbery · Pull Request #8844 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #8983: WIP: Log block height and size when received (master...ShowBlockHeightAndSizeWhenReceived) https://github.com/bitcoin/bitcoin/pull/8983
< bitcoin-git> [bitcoin] laanwj opened pull request #9219: doc: Improve windows build instructions using Linux subsystem (master...2016_11_windows_build_update) https://github.com/bitcoin/bitcoin/pull/9219
< bitcoin-git> [bitcoin] laanwj closed pull request #9189: Always add default_witness_commitment with GBT client support (master...alwayscommit) https://github.com/bitcoin/bitcoin/pull/9189
< bitcoin-git> bitcoin/master d932159 Wladimir J. van der Laan: Merge #9189: Always add default_witness_commitment with GBT client support...
< bitcoin-git> bitcoin/master 95f4a03 Suhas Daftuar: [qa] Test getblocktemplate default_witness_commitment
< bitcoin-git> bitcoin/master ad04d1c Pieter Wuille: Always add default_witness_commitment with GBT client support
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc121b0eb197...d932159f3467

2016-11-24

< gribble> https://github.com/bitcoin/bitcoin/issues/9189 | Always add default_witness_commitment with GBT client support by sipa · Pull Request #9189 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9188 | Make orphan parent fetching ask for witnesses. by gmaxwell · Pull Request #9188 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9218 | qt: Show progress overlay when clicking spinner icon by laanwj · Pull Request #9218 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #9218: qt: Show progress overlay when clicking spinner icon (master...2016_11_overlay_when_clicking_sync_icon) https://github.com/bitcoin/bitcoin/pull/9218
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9216: Doc: Fix copypasted comment (master...20161124_commentfix_banmap) https://github.com/bitcoin/bitcoin/pull/9216
< bitcoin-git> bitcoin/master bc121b0 MarcoFalke: Merge #9216: Doc: Fix copypasted comment...
< bitcoin-git> bitcoin/master f26da35 Pavel Janík: Fix copypasted comment.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c98f6b3d93a2...bc121b0eb197
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9144: [Trivial] Correct waitforblockheight example help text (master...rpc-commands) https://github.com/bitcoin/bitcoin/pull/9144
< bitcoin-git> bitcoin/master c98f6b3 MarcoFalke: Merge #9144: [Trivial] Correct waitforblockheight example help text...
< bitcoin-git> bitcoin/master e3c4f7e fanquake: Correct help output for waitfor RPC commands
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db5e22e0537a...c98f6b3d93a2
< gribble> https://github.com/bitcoin/bitcoin/issues/9144 | [Trivial] Correct waitforblockheight example help text by fanquake · Pull Request #9144 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9190: qt: Plug many memory leaks (master...2016_11_plug_leaks) https://github.com/bitcoin/bitcoin/pull/9190
< bitcoin-git> bitcoin/master e4f126a Wladimir J. van der Laan: qt: Avoid splash-screen related memory leak...
< bitcoin-git> bitcoin/master 47db075 Wladimir J. van der Laan: qt: Plug many memory leaks...
< bitcoin-git> bitcoin/master 693384e Wladimir J. van der Laan: qt: Prevent thread/memory leak on exiting RPCConsole...
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/93566e0c37c5...db5e22e0537a
< bitcoin-git> [bitcoin] paveljanik opened pull request #9216: Doc: Fix copypasted comment (master...20161124_commentfix_banmap) https://github.com/bitcoin/bitcoin/pull/9216
< gribble> https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub
< gmaxwell> bitcoin358: add more fees later in the chain and enjoy giving them to miners running Bitcoin Core, since it will happily notice those fees later in the chain.
< bitcoin-git> [bitcoin] luke-jr reopened pull request #8889: Qt/ModalOverlay: Use theme tooltip colours (master...overlay_theme) https://github.com/bitcoin/bitcoin/pull/8889
< bitcoin-git> bitcoin/master d2b88f9 Matt Corallo: Move orphan-conflict removal from main logic into a callback...
< bitcoin-git> bitcoin/master 97e2802 Matt Corallo: Erase orphans per-transaction instead of per-block
< bitcoin-git> bitcoin/master ec4525c Matt Corallo: Move orphan processing to ActivateBestChain...
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/407d9232ef5c...93566e0c37c5
< rusty> gmaxwell: it's your fault I now have 'while sleep 10; do bitcoin-cli getblocktemplate | awk '/"fee"/ { FEES += $2 } /"height"/ { HEIGHT = $2 } END { print HEIGHT,FEES }'; done' running in a terminal here, BTW.
< bitcoin-git> [bitcoin] sipa closed pull request #9199: Always drop the least preferred HB peer when adding a new one. (master...remove_high_bandwidth_zombies) https://github.com/bitcoin/bitcoin/pull/9199
< bitcoin-git> bitcoin/master 407d923 Pieter Wuille: Merge #9199: Always drop the least preferred HB peer when adding a new one....
< bitcoin-git> bitcoin/master ca8549d Gregory Maxwell: Always drop the least preferred HB peer when adding a new one....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0de7fd36de57...407d9232ef5c

2016-11-23

< gmaxwell> echo `date -u +%s` `./bitcoin-cli getblockcount` `./bitcoin-cli getblocktemplate | grep \"fee\" | awk '{aa+=$2} END {print aa}'`
< gribble> https://github.com/bitcoin/bitcoin/issues/9183 | Final Preparation for main.cpp Split by TheBlueMatt · Pull Request #9183 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8930 | Move orphan processing to ActivateBestChain by TheBlueMatt · Pull Request #8930 · bitcoin/bitcoin · GitHub
< cfields> BlueMatt: i suppose we're looking at this from different sides. I originally rewrote the net layer and tried to plug it into bitcoin. I didn't like the result. I started instead trying to rip bitcoin out of our net layer, and that's where we are now. The next step would be to split the resulting CConnman into high and low levels. That's next.
< BlueMatt> cfields: bitcoin-specific hacks like what?
< cfields> BlueMatt: for context, I first wrote a completely low-level, no-bitcoin network layer. Plugging that into bitcoin proved to require a bunch of bitcoin-specific hacks. In the end, I didn't think it was an improvement over what we had.
< BlueMatt> cfields: well I dont think you mean that tighter-integration is needed between bitcoin logic and libevent/async
< sipa> CConnman is exactly the bitcoin specific thing
< BlueMatt> sipa: CConnman should be a networking library, not a bitcoin networking library
< BlueMatt> sipa: the way i see it: processing of messages and the peer handling is already well-separated, or at least somewhat separated...we currently have bitcoin-specific and general-networking code intermixed in a bunch of places, and that also needs to be separated
< BlueMatt> not a bitcoin-p2p-management library
< gribble> https://github.com/bitcoin/bitcoin/issues/9128 | net: Decouple CConnman and message serialization by theuni · Pull Request #9128 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8930 | Move orphan processing to ActivateBestChain by TheBlueMatt · Pull Request #8930 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9183 | Final Preparation for main.cpp Split by TheBlueMatt · Pull Request #9183 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9211: [0.12.2] Backports (0.12...Mf1611-back12) https://github.com/bitcoin/bitcoin/pull/9211
< Victorsueca> please move to #bitcoin
< brhood9_> Is there any way that you all could help me figure out what is going on with my bitcoin transaction? I have asked and looked and read everywhere. The transaction that you need to look at is this one.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9139: Change sync_blocks to pick smarter maxheight (on top of #9196) (master...sync-height) https://github.com/bitcoin/bitcoin/pull/9139
< bitcoin-git> bitcoin/master 0de7fd3 MarcoFalke: Merge #9139: Change sync_blocks to pick smarter maxheight (on top of #9196)...
< bitcoin-git> bitcoin/master 1126c85 Russell Yanofsky: [qa] Change sync_blocks to pick smarter maxheight...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e662d281b837...0de7fd36de57
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9139: Change sync_blocks to pick smarter maxheight (on top of #9196) (master...sync-height) https://github.com/bitcoin/bitcoin/pull/9139
< bitcoin-git> [bitcoin] sdaftuar opened pull request #9208: [WIP] Improve DisconnectTip performance (master...faster-disconnect-rebased) https://github.com/bitcoin/bitcoin/pull/9208
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206
< bitcoin-git> bitcoin/master e662d28 MarcoFalke: Merge #9206: Make test constant consistent with consensus.h...
< bitcoin-git> bitcoin/master 09dc406 BtcDrak: Make test constant consistent with consensus.h
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa1f944107f9...e662d281b837
< bitcoin-git> [bitcoin] laanwj closed pull request #9207: [Doc] Move comments above bash command in build-unix (master...patch-2) https://github.com/bitcoin/bitcoin/pull/9207
< bitcoin-git> bitcoin/master fa1f944 Wladimir J. van der Laan: Merge #9207: [Doc] Move comments above bash command in build-unix...
< bitcoin-git> bitcoin/master 69bc8e7 Amir Abrams: [Doc] Move comments above bash command
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/74ced54b7e7b...fa1f944107f9
< BlueMatt> so I could PR relay-compact-block-before-full-validation (https://github.com/TheBlueMatt/bitcoin/commits/2016-11-compact-fast-relay) but now I'm kinda thinking I dont want to do that prior to there being multithreaded ProcessMessages with some smarts to respond to getblocktxn without a lock for the latest block...thoughts?
< gribble> https://github.com/bitcoin/bitcoin/issues/9128 | net: Decouple CConnman and message serialization by theuni · Pull Request #9128 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] AmirAbrams opened pull request #9207: [Doc] Add missing bash # comment characters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/9207
< bitcoin-git> [bitcoin] laanwj closed pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204
< bitcoin-git> bitcoin/master 918b126 instagibbs: fix CreateTransaction error messages
< bitcoin-git> bitcoin/master 74ced54 Wladimir J. van der Laan: Merge #9204: Clarify CreateTransaction error messages...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e8631b6cb5b...74ced54b7e7b
< luke-jr> [07:28:49] <jonasschnelli> I think this is ready: https://github.com/bitcoin/bitcoin/pull/9196 <-- am I missing something? what if the new best isn't pprev?
< bitcoin-git> [bitcoin] laanwj closed pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205
< bitcoin-git> bitcoin/master 5e8631b Wladimir J. van der Laan: Merge #9205: Minor change to comment for consistency....
< bitcoin-git> bitcoin/master f004e67 Greg Walker: Minor change to comment above new NODE_WITNESS service flag to keep it consitent with existing comment structure. Helps with readability.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e2bfd62419f...5e8631b6cb5b
< bitcoin-git> [bitcoin] laanwj closed pull request #9196: Send tip change notification from invalidateblock (master...pr/notify-tip) https://github.com/bitcoin/bitcoin/pull/9196
< bitcoin-git> bitcoin/master 67c6326 Russell Yanofsky: Send tip change notification from invalidateblock...
< bitcoin-git> bitcoin/master 7e2bfd6 Wladimir J. van der Laan: Merge #9196: Send tip change notification from invalidateblock...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/791b58d148ab...7e2bfd62419f
< jonasschnelli> I think this is ready: https://github.com/bitcoin/bitcoin/pull/9196
< bitcoin-git> bitcoin/master 791b58d Wladimir J. van der Laan: Merge #8690: Do not fully sort all nodes for addr relay...
< bitcoin-git> bitcoin/master a33b169 Pieter Wuille: Do not fully sort all nodes for addr relay...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ea5e0401cb3...791b58d148ab
< wumpus> btw RPC named arguments is feature-complete now (support in bitcoin-cli landed) and ready for testing https://github.com/bitcoin/bitcoin/pull/8811
< gribble> https://github.com/bitcoin/bitcoin/issues/9073 | Trivial: Add common failure cases for rpc server connection failure by instagibbs · Pull Request #9073 · bitcoin/bitcoin · GitHub
< wumpus> instagibbs: eh in #9073 you changed the bitcoin-cli message but it's confusing now: error: couldn't connect to server (make sure server is running and you are connecting to the correct RPC port: -1 unknown)
< gribble> https://github.com/bitcoin/bitcoin/issues/9172 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< cfields> wumpus: see the suggestion in https://github.com/bitcoin/bitcoin/issues/9198 as well
< gribble> https://github.com/bitcoin/bitcoin/issues/9128 | net: Decouple CConnman and message serialization by theuni · Pull Request #9128 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9141: Remove unnecessary calls to CheckFinalTx (master...2016/11/istrusted) https://github.com/bitcoin/bitcoin/pull/9141
< bitcoin-git> bitcoin/master 5ea5e04 Wladimir J. van der Laan: Merge #9141: Remove unnecessary calls to CheckFinalTx...
< bitcoin-git> bitcoin/master 4512550 Jonas Schnelli: Remove unnecessary calls to CheckFinalTx
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/40022fe5f2b5...5ea5e0401cb3
< bitcoin-git> [bitcoin] laanwj closed pull request #9142: Move -salvagewallet, -zap(wtx) to where they belong (master...2016/11/wallet_init) https://github.com/bitcoin/bitcoin/pull/9142
< bitcoin-git> bitcoin/master 40022fe Wladimir J. van der Laan: Merge #9142: Move -salvagewallet, -zap(wtx) to where they belong...
< bitcoin-git> bitcoin/master 2e44893 Jonas Schnelli: Move -salvagewallet, -zap(wtx) to where they belong
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4d8558a2871e...40022fe5f2b5
< bitcoin-git> bitcoin/master 4d8558a Wladimir J. van der Laan: Merge #9025: getrawtransaction should take a bool for verbose...
< bitcoin-git> bitcoin/master 240189b John Newbery: add testcases for getrawtransaction
< bitcoin-git> bitcoin/master ce2bb23 jnewbery: getrawtransaction should take a bool for verbose
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac489b24453c...4d8558a2871e

2016-11-22

< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9177 | NOMERGE: WIP: Support block signed custom testchains by jtimon · Pull Request #9177 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jtimon> updated https://github.com/bitcoin/bitcoin/pull/9177 's description
< bitcoin-git> [bitcoin] btcdrak opened pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206
< bitcoin-git> [bitcoin] in3rsha opened pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205
< bitcoin-git> [bitcoin] instagibbs opened pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9130: Mention the new network toggle functionality in the tooltip. (master...20161111_disable_network_tooltip) https://github.com/bitcoin/bitcoin/pull/9130
< bitcoin-git> bitcoin/master ac489b2 Jonas Schnelli: Merge #9130: Mention the new network toggle functionality in the tooltip....
< bitcoin-git> bitcoin/master 1260c11 Pavel Janík: Mention the new network toggle functionality in the tooltip.
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55b2eddcc8fd...ac489b24453c
< bitcoin-git> [bitcoin] jnewbery closed pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
< bitcoin-git> [bitcoin] jnewbery opened pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
< wumpus> this is not related to bitcoin core development, can you move this to #bitcoin?
< bitcoin-git> [bitcoin] laanwj opened pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202
< bitcoin-git> [bitcoin] laanwj closed pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
< bitcoin-git> bitcoin/master 55b2edd Wladimir J. van der Laan: Merge #9200: bench: Fix subtle counting issue when rescaling iteration count...
< bitcoin-git> bitcoin/master e0a9cb2 Wladimir J. van der Laan: bench: Fix subtle counting issue when rescaling iteration count...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4dbeb94998d...55b2eddcc8fd
< luke-jr> Victorsueca: p.s. if you want to mine testnet with it, tmp.pool.bitcoin.dashjr.org port 3334 (stratum) or 8337 (GBT & getwork)
< thermoman> gmaxwell, sipa, sdaftuar: https://github.com/bitcoin/bitcoin/issues/9201
< Victorsueca> is it safe if I move all from bitcoin to "" or I would mess with the wallet balance calculation?
< jouke> Basically the same use case as dooglus in https://github.com/bitcoin/bitcoin/issues/3816
< bitcoin-git> [bitcoin] laanwj opened pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
< wumpus> agree that tooling documentation would be useful, though none of this is specific to bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
< jonasschnelli> wumpus: how did you detected the Qt leaks? IMO last time I used it on Bitcoin-Qt on Ubuntu I had to force shutdown my machine.. :)
< bitcoin-git> bitcoin/master e4dbeb9 Jonas Schnelli: Merge #9185: [Qt] fix coincontrol sort issue...
< bitcoin-git> bitcoin/master 4231032 Wladimir J. van der Laan: [Qt] Clean up and fix coincontrol tree widget handling...
< bitcoin-git> bitcoin/master 76af4eb Jonas Schnelli: [Qt] fix coincontrol sort issue
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c577f2638b7...e4dbeb94998d
< gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
< wumpus> the most sneaky leak (and also most bytes wasted) I fixed in #9190 was the openssl certstore one (https://github.com/bitcoin/bitcoin/pull/9190/commits/4b2c2888868cb49806cd734ea36e7f5b032c3b00) . OpenSSL's documentation is somewhat fuzzy about it, but the assumption there was wrong, that X509_STORE_add_cert really tkaes ownership
< fanquake> Have only tested with bitcoin-qt so far, I'll look at bitcoind now.
< gribble> https://github.com/bitcoin/bitcoin/issues/9000 | miner debugging: faux-mining by theuni · Pull Request #9000 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9199: Always drop the least preferred HB peer when adding a new one. (master...remove_high_bandwidth_zombies) https://github.com/bitcoin/bitcoin/pull/9199

2016-11-21

< skyraider> it might help to put on a client's shoes here. context was https://github.com/petertodd/python-bitcoinlib/pull/128 in which a blind retry python decorator was considered. turns out this can a) result in actually sending bitcoin multiple times, b) result in decisions made on stale read data (balance was just an example - really any bitcoind state subject to
< skyraider> yes, sorry, shorthand for "try to send some bitcoin"
< skyraider> uh, yeah, not bitcoin transaction. isolation as in the I from ACID.
< skyraider> so 'read before you try to send lots of bitcoin' - alright. but if another RPC connection writes in the meantime, won't my read be stale, or is there transaction isolation somehow? is the recommended policy therefore 'only ever use a single RPC writer' ?
< bsm1175321> sipa: the fix here: https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/test_framework/authproxy.py#L134 looks like it is effectively a retry, and would, e.g. sendmany again.
< kanzure> okay i posted an issue about the abovementioned rpc replay protection concerns https://github.com/bitcoin/bitcoin/issues/9197
< gribble> https://github.com/bitcoin/bitcoin/issues/9194 | Add flags to getrawtransaction and getblock to return non-segwit seri… by instagibbs · Pull Request #9194 · bitcoin/bitcoin · GitHub
< thermoman> from bitcoin.conf on proxy node
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9196: Send tip change notification from invalidateblock (master...pr/notify-tip) https://github.com/bitcoin/bitcoin/pull/9196
< bitcoin-git> [bitcoin] laanwj closed pull request #8872: Remove block-request logic from INV message processing (master...fetchflags2) https://github.com/bitcoin/bitcoin/pull/8872
< bitcoin-git> bitcoin/master 037159c Matt Corallo: Remove block-request logic from INV message processing
< bitcoin-git> bitcoin/master d768f15 mrbandrews: [qa] Make comptool push blocks instead of relying on inv-fetch
< bitcoin-git> bitcoin/master 3451203 Matt Corallo: [qa] Respond to getheaders and do not assume a getdata on inv
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/210891143ba0...0c577f2638b7
< bitcoin-git> [bitcoin] laanwj closed pull request #8837: allow bitcoin-tx to parse partial transactions (master...bitcoin-tx-partial-transactions) https://github.com/bitcoin/bitcoin/pull/8837
< bitcoin-git> bitcoin/master 2108911 Wladimir J. van der Laan: Merge #8837: allow bitcoin-tx to parse partial transactions...
< bitcoin-git> bitcoin/master 7451cf5 jnewbery: Allow bitcoin-tx to parse partial transactions...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b9a87b459d25...210891143ba0
< bitcoin-git> [bitcoin] laanwj closed pull request #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute (master...Mf1611-blockFreeTxs) https://github.com/bitcoin/bitcoin/pull/9179
< bitcoin-git> bitcoin/master fa7cc5a MarcoFalke: Set DEFAULT_LIMITFREERELAY = 0 kB/minute
< bitcoin-git> bitcoin/master b9a87b4 Wladimir J. van der Laan: Merge #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3906403c8ed...b9a87b459d25
< wumpus> my preference would be the shorter name, it *is* bitcoin we don't have any other context where we use address/pubkey/privkey
< gribble> https://github.com/bitcoin/bitcoin/issues/8811 | rpc: Add support for JSON-RPC named arguments by laanwj · Pull Request #8811 · bitcoin/bitcoin · GitHub
< instagibbs> wumpus, I'm not an old timer, which is why I'm asking more basic account questions. It's always been deprecated in my Bitcoin lifetime :P
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< bitcoin-git> [bitcoin] laanwj closed pull request #9117: net: don't send feefilter messages before the version handshake is complete (master...feefilter-assert) https://github.com/bitcoin/bitcoin/pull/9117
< bitcoin-git> bitcoin/master c390640 Wladimir J. van der Laan: Merge #9117: net: don't send feefilter messages before the version handshake is complete...
< bitcoin-git> bitcoin/master 4662553 Cory Fields: net: don't send feefilter messages before the version handshake is complete
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7490ae8b699d...c3906403c8ed
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9125: Make CBlock a vector of shared_ptr of CTransactions (master...sharedblock) https://github.com/bitcoin/bitcoin/pull/9125
< bitcoin-git> bitcoin/master 1662b43 Pieter Wuille: Make CBlock::vtx a vector of shared_ptr<CTransaction>
< bitcoin-git> bitcoin/master da60506 Pieter Wuille: Add deserializing constructors to CTransaction and CMutableTransaction
< bitcoin-git> bitcoin/master 0e85204 Pieter Wuille: Add serialization for unique_ptr and shared_ptr
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/44adf683ad23...7490ae8b699d
< bitcoin-git> [bitcoin] laanwj closed pull request #9193: Update copyright year to 2016 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9193

2016-11-20

< bitcoin-git> [bitcoin] instagibbs opened pull request #9194: Add flags to getrawtransaction and getblock to return non-segwit seri… (master...nonswserialrpc) https://github.com/bitcoin/bitcoin/pull/9194
< bitcoin-git> [bitcoin] ShamimLike opened pull request #9193: Update copyright year to 2016 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9193

2016-11-19

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9159: [qa] Wait for specific block announcement in p2p-compactblocks (master...cmpct-announce-wait) https://github.com/bitcoin/bitcoin/pull/9159
< bitcoin-git> bitcoin/master 44adf68 MarcoFalke: Merge #9159: [qa] Wait for specific block announcement in p2p-compactblocks...
< bitcoin-git> bitcoin/master dfa44d1 Russell Yanofsky: [qa] Wait for specific block announcement in p2p-compactblocks...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce612f175063...44adf683ad23
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9191: [qa] 0.13.2 Backports (0.13...Mf1611-q01302) https://github.com/bitcoin/bitcoin/pull/9191
< sipa> it's probably a relatively good way to understand the design of bitcoin, but it's not that helpful to learn how the code works now
< luke-jr> but in case he reads the log: I don't recommend reading the earliest code as a way to learn about Bitcoin. It was a mess, and included a lot of features later discarded (eg, built-in marketplace)
< meownow> im currently reading through the first commit of the bitcoin source code onto github. seems a good way to familiarize myself with the core of the code base and what it does.
< bitcoin-git> [bitcoin] laanwj closed pull request #9186: test: Fix use-after-free in scheduler tests (master...2016_11_scheduler_fix) https://github.com/bitcoin/bitcoin/pull/9186
< bitcoin-git> bitcoin/master ce612f1 Wladimir J. van der Laan: Merge #9186: test: Fix use-after-free in scheduler tests...
< bitcoin-git> bitcoin/master 12519bf Wladimir J. van der Laan: test: Fix use-after-free in scheduler tests...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9346f8429957...ce612f175063
< bitcoin-git> [bitcoin] laanwj opened pull request #9190: qt: Plug many memory leaks (master...2016_11_plug_leaks) https://github.com/bitcoin/bitcoin/pull/9190
< meownow> can anyone summarize when i download the bitcoin source code on the github, what is the client i am downloading able to actually do?

2016-11-18

< bitcoin-git> [bitcoin] sipa opened pull request #9189: Always add default_witness_commitment with GBT client support (master...alwayscommit) https://github.com/bitcoin/bitcoin/pull/9189
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9188: Make orphan parent fetching ask for witnesses. (master...witness_the_orphans) https://github.com/bitcoin/bitcoin/pull/9188
< sipa> (which is irrelevant, as bitcoin core is not used for mining)
< sipa> but it's not what bitcoin core does
< cfields> sipa: did i misunderstand your intention here? https://botbot.me/freenode/bitcoin-core-dev/2016-08-11/?msg=71172676&page=4
< bitcoin-git> [bitcoin] laanwj opened pull request #9186: test: Fix use-after-free in scheduler tests (master...2016_11_scheduler_fix) https://github.com/bitcoin/bitcoin/pull/9186
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9185: [Qt] fix coincontrol sort issue (master...2016/11/fix_cc_sort) https://github.com/bitcoin/bitcoin/pull/9185
< luke-jr> sipa: protocol changes need consensus. we can't force them on people. but it only takes good willed miners to use pro-Bitcoin policys.
< dermoth> yeah and my apologies; I though I was in #bitcoin-dev (not -core-)
< sipa> dermoth, rabidus: also, please take this to #bitcoin
< rabidus> you would kill the "store of value" property of bitcoin
< dermoth> I think after a certain number of bitcoin cycles (210k blocks) we could scavenge all unspent coins from the oldest 210k block, put them in a pool and let miners siphon 1/210000th of that pool every block. At that point the older part of the chain could be completely dropped as it would no longer have any use, and pooling the fund would ensure miners get a predictable reward.
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9183: Final Preparation for main.cpp Split (master...net_processing_5) https://github.com/bitcoin/bitcoin/pull/9183
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #8930: Move orphan processing to ActivateBestChain (master...net_processing_3) https://github.com/bitcoin/bitcoin/pull/8930
< * jtimon> re-asks for review on https://github.com/bitcoin/bitcoin/pull/8855
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub

2016-11-17

< bitcoin-git> [bitcoin] mruddy opened pull request #9180: WIP: remove script checking dependency on checkpoints v2 (master...isburied) https://github.com/bitcoin/bitcoin/pull/9180
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9179: Set DEFAULT_LIMITFREERELAY = 0 kB/minute (master...Mf1611-blockFreeTxs) https://github.com/bitcoin/bitcoin/pull/9179
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #9014: Fix block-connection performance regression (master...2016-10-fix-tx-regression) https://github.com/bitcoin/bitcoin/pull/9014
< BlueMatt> jtimon/sipa do we care about https://github.com/bitcoin/bitcoin/pull/9075/files#r88568772 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/707 | Implement BIP 14 : separate protocol version from client version by gavinandresen · Pull Request #707 · bitcoin/bitcoin · GitHub
< meownow> oops, this pull request: https://github.com/bitcoin/bitcoin/pull/63
< gribble> https://github.com/bitcoin/bitcoin/issues/9142 | Move -salvagewallet, -zap(wtx) to where they belong by jonasschnelli · Pull Request #9142 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #9075: Decouple peer-processing-logic from block-connection-logic (#3) (master...net_processing_4) https://github.com/bitcoin/bitcoin/pull/9075
< bitcoin-git> bitcoin/master ae22357 Matt Corallo: Replace CValidationState param in ProcessNewBlock with BlockChecked
< bitcoin-git> bitcoin/master 7c98ce5 Matt Corallo: Remove pfrom parameter from ProcessNewBlock...
< bitcoin-git> bitcoin/master e2e069d Matt Corallo: Revert "RPC: Give more details when "generate" fails"...
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8b2a82618be...9346f8429957
< bitcoin-git> [bitcoin] mruddy closed pull request #9175: WIP: remove script checking dependency on checkpoints (master...script_check) https://github.com/bitcoin/bitcoin/pull/9175
< wumpus> many people only use their bitcoin wallet with wifi so could care less about bandwidth usage
< wumpus> we're just nopt using BIP37 for the light wallet mode in bitcoin core. If you want to use it in your wallet go ahead.
< gmaxwell> Chris_Stewart_5: besides, fetching blocks is 14kb/s ongoing (28kb/s perhaps soon)-- most people running bitcoin core can handle that without batting an eye.
< gmaxwell> jonasschnelli: political discussion to ##bitcoin.
< jonasschnelli> sipa: \o/ new navigation on http://bitcoin.sipa.be
< gribble> https://github.com/bitcoin/bitcoin/issues/9171 | Introduce auxiliary block requests by jonasschnelli · Pull Request #9171 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9075 | Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt · Pull Request #9075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9075 | Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt · Pull Request #9075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9171 | Introduce auxiliary block requests by jonasschnelli · Pull Request #9171 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< MarcoFalke_web> #action look at https://github.com/bitcoin/bitcoin/pull/7729
< gmaxwell> "Bitcoin developers oppose accountability."
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/7729 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< wumpus> so I proposed a label API to replace accounts at the start of this year, it still hasn't had much review yet: https://github.com/bitcoin/bitcoin/pull/7729
< jonasschnelli> sipa: have a look at https://github.com/bitcoin/bitcoin/pull/8745
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8589 | Inline CTxInWitness inside CTxIn (on top of #8580) by sipa · Pull Request #8589 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
< gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
< Chris_Stewart_5> I guess my real question is could 'F' in the examples be a LOW_S sig https://github.com/bitcoin/bips/blob/master/bip-0146.mediawiki#examples
< Chris_Stewart_5> and if so, how can this fail immediately without checking the signature: https://github.com/bitcoin/bitcoin/blob/35fe0393f216aa6020fc929272118eade5628636/src/script/interpreter.cpp#L880
< bitcoin-git> bitcoin/master a8b2a82 Wladimir J. van der Laan: Merge #9156: Add compile and link options echo to configure...
< bitcoin-git> [bitcoin] laanwj closed pull request #9156: Add compile and link options echo to configure (master...2016/11/configure) https://github.com/bitcoin/bitcoin/pull/9156
< bitcoin-git> bitcoin/master d8274bc Jonas Schnelli: Add compile and link options echo to configure
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aaca05c0dabd...a8b2a82618be
< Chris_Stewart_5> I get why we have all the other checks inside of CheckSignatureEncoding: https://github.com/bitcoin/bitcoin/blob/35fe0393f216aa6020fc929272118eade5628636/src/script/interpreter.cpp#L185
< bitcoin-git> [bitcoin] laanwj closed pull request #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core" (master...Mf1611-doc) https://github.com/bitcoin/bitcoin/pull/9178
< bitcoin-git> bitcoin/master fa63ee8 MarcoFalke: Doxygen: Set PROJECT_NAME = "Bitcoin Core"
< bitcoin-git> bitcoin/master aaca05c Wladimir J. van der Laan: Merge #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core"...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6db48ad1c8f...aaca05c0dabd
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #9178: Doxygen: Set PROJECT_NAME = "Bitcoin Core" (master...Mf1611-doc) https://github.com/bitcoin/bitcoin/pull/9178
< bitcoin-git> [bitcoin] Christewart closed pull request #9174: Modifying incorrect comments from BIP66 -> BIP62 (master...master) https://github.com/bitcoin/bitcoin/pull/9174
< bitcoin-git> bitcoin/master f6db48a Wladimir J. van der Laan: Merge #8838: Calculate size and weight of block correctly in CreateNewBlock()...
< bitcoin-git> bitcoin/master 5f274a1 jnewbery: log block size and weight correctly.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb2ed300a89e...f6db48ad1c8f
<@wumpus> what is the proper way to pass arguments to the secp256k1 configure script that is invoked by bitcoin's?
< bitcoin-git> [bitcoin] jtimon opened pull request #9177: NOMERGE: WIP: Support block signed custom testchains (master...0.13-blocksign) https://github.com/bitcoin/bitcoin/pull/9177
< bitcoin-git> [bitcoin] jtimon opened pull request #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() (master...0.13-chainparams-loadblockindexguts) https://github.com/bitcoin/bitcoin/pull/9176
< bitcoin-git> [bitcoin] mruddy opened pull request #9175: remove script checking dependency on checkpoints (master...script_check) https://github.com/bitcoin/bitcoin/pull/9175
< luke-jr> #bitcoin is the support channel btw
< bitcoin-git> [bitcoin] Christewart opened pull request #9174: Modifying incorrect comments from BIP66 -> BIP62 (master...master) https://github.com/bitcoin/bitcoin/pull/9174
< shangzhou> bitcoin.org's download link.
< shangzhou> gmaxwell: i did some search this morning at baidu. Searched "c1726ccc50635795c942c7d7e51d979c4f83a3d17f8982e9d02a114a15fef419" only one result (a thread http://8btc.com/thread-41510-1-5.html) someone use Avast complain that bitcoin 0.13.1 win exe downloaded from bitcoin.org was blocked by the avast. Search something like "bitcoin 0.13.1 win exe" top one is
< BlueMatt> -rw------- 1 matt matt 1.7T Nov 16 16:44 /home/matt/.bitcoin/debug.log

2016-11-16

< Chris_Stewart_5> Why does this test fail for EVAL_FALSE and not WITNESS_PROGRAM_MISMATCH? https://github.com/bitcoin/bitcoin/blob/master/src/test/data/script_tests.json#L1257
< theymos> fyi, some apparently-popular antivirus is flagging Bitcoin Core 0.13.1: https://www.virustotal.com/en/file/c1726ccc50635795c942c7d7e51d979c4f83a3d17f8982e9d02a114a15fef419/analysis/
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9173: demo (master...master) https://github.com/bitcoin/bitcoin/pull/9173
< bitcoin-git> [bitcoin] demodun opened pull request #9173: demo (master...master) https://github.com/bitcoin/bitcoin/pull/9173
< bitcoin-git> [bitcoin] laanwj reopened pull request #8747: [rpc] Fix transaction size comments and RPC help text. (master...rpc_comments) https://github.com/bitcoin/bitcoin/pull/8747
<@wumpus> or original VT-100 terminals or whatnot :) bitcoin isn't that old