< bitcoin-git>
[bitcoin] lemzwerg opened pull request #11101: bitcoin_qt.m4: Minor fixes, improve code orthogonality (master...master) https://github.com/bitcoin/bitcoin/pull/11101
< bitcoin-git>
[bitcoin] laanwj closed pull request #11027: [RPC] Only return hex field once in getrawtransaction (master...fix-getrawtx) https://github.com/bitcoin/bitcoin/pull/11027
< bitcoin-git>
bitcoin/master 820ddd4 Wladimir J. van der Laan: Merge #11027: [RPC] Only return hex field once in getrawtransaction...
< bitcoin-git>
bitcoin/master 6bbdafc Andrew Chow: Pass serialization flags and whether to include hex to TxToUniv
< bitcoin-git>
bitcoin/master e029c6e Andrew Chow: Only return hex field once in getrawtransaction...
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #11100: Use a sensible default for blockmax{size,weight} (master...2017-08-sane-default-limits) https://github.com/bitcoin/bitcoin/pull/11100
< bitcoinreminder>
no sorry, I was talking about bitcoin-core
< bitcoinreminder>
sorry, I meant bitcoin-core.org
< luke-jr>
bitcoinreminder: bitcoin.org isn't even Bitcoin Core..
< bitcoinreminder>
does anyone has a bitcoin-org email address? I created a impersonation-request on twitter for the fake https://twitter.com/BcoreProject account, but they told me that someone with a bitcoin-org email address has to create the request
< bitcoin-git>
[bitcoin] greenaddress opened pull request #11099: [RPC][mempool]: add rpc command to dump the mempool to disk (master...dump_mempool_rpc) https://github.com/bitcoin/bitcoin/pull/11099
< bitcoin-git>
[bitcoin] theuni opened pull request #11097: gitian: quick hack to fix version string in releases (master...gitian-version-fix) https://github.com/bitcoin/bitcoin/pull/11097
< bitcoin-git>
[bitcoin] mdaiter opened pull request #11095: Consensus: add const to temp int in base58.cpp (master...base58NuancedConst) https://github.com/bitcoin/bitcoin/pull/11095
< mryandao>
hey guys, when executing a estimatefee RPC command on a node that is not fully sync-ed, shouldn't bitcoin-cli make a note that said node is not fully sync-ed and user should be cautioned to not use the estimated fee?
< bitcoin-git>
[bitcoin] laanwj closed pull request #10952: [wallet] Remove vchDefaultKey and have better first run detection (master...remove-defaultkey) https://github.com/bitcoin/bitcoin/pull/10952
< bitcoin-git>
bitcoin/master 2621673 Wladimir J. van der Laan: Merge #10952: [wallet] Remove vchDefaultKey and have better first run detection...
< bitcoin-git>
bitcoin/master e53615b Andrew Chow: Remove vchDefaultKey and have better first run detection...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11066: Document the preference of nullptr over NULL or (void*)0 (master...document-nullptr-preference) https://github.com/bitcoin/bitcoin/pull/11066
< bitcoin-git>
bitcoin/master 9e00a62 Wladimir J. van der Laan: Merge #11066: Document the preference of nullptr over NULL or (void*)0...
< bitcoin-git>
bitcoin/master bea8e9e practicalswift: Document the preference of nullptr over NULL or (void*)0
< bitcoin-git>
bitcoin/master 07685d1 Jonas Schnelli: Add length check for CExtKey deserialization
< bitcoin-git>
bitcoin/master 9f60b37 Wladimir J. van der Laan: Merge #11081: Add length check for CExtKey deserialization (jonasschnelli, guidovranken)...
< bitcoin-git>
[bitcoin] dooglus opened pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085
< bitcoin-git>
bitcoin/0.15 1c4b9b3 Wladimir J. van der Laan: Merge #11076: 0.15 release-notes nits: fix redundancy, remove accidental parenthesis & fix range style...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11071: Use static_assert(…, …) (C++11) instead of assert(…) where appropriate (master...static_assert) https://github.com/bitcoin/bitcoin/pull/11071
< bitcoin-git>
bitcoin/master dbf6bd6 Wladimir J. van der Laan: Merge #11071: Use static_assert(…, …) (C++11) instead of assert(…) where appropriate...
< praxeology>
Does bitcoin's networking code operate on polling or interrupt?
< bitcoin-git>
[bitcoin] jonasnick opened pull request #11083: Fix combinerawtransaction RPC help result section (master...fix-combinerawtransaction-help) https://github.com/bitcoin/bitcoin/pull/11083
< praxeology>
kallewoof: does your bitcoin process have enough memory to hold the entire chainstate?
< kallewoof>
gmaxwell: there is some amount of overhead as I am doing the profiling on my own. Maybe that's the cause for the high portion of time spent there, but it still seems like a lot of LOCK calls, regardless of actual CPU cycle count. Would be cool if the mempool could be copied once and then not lock cs at all. Code is here btw: https://github.com/kallewoof/bitcoin/tree/profile-resources
< praxeology>
Like... I know that BitPay and Coinbase are declaring that they will support Segwit2x... has any exchange declared that they will continue to support Bitcoin (Bitcoin Core's rules)?
< kallewoof>
I'm running a modified Bitcoin Core node to do some profiling on where resources are spent (CPU cycles and bandwidth in particular) and am seeing some really weird stuff. E.g:
< luke-jr>
in other news, Texas Bitcoin conference is promoting 2X as if it's Bitcoin, so I think that makes the decision to go simple (ie, not to)
< gmaxwell>
if they said "[compatible fully validating nodes] btc1 \n [compatible wallet software] bitcoin classic\n" it would n... oh okay, well I suppose because it's not a lie in every possible sense it's okay. :P
< Cryptocide>
Abra|BitClub Network|Bitcoin.com|BitFury|BitGo|Bitmain|BitPay Blockchain|Bloq|BTCC|Circle|Ledger|RSK Labs|Xapo, no thanks
< gmaxwell>
Wow, this is super dishonest https://segwit2x.github.io/segwit2x-announce.html ... "Bitcoin Upgrade" is untrue... it claims Bitcoin "Classic" and unlimited are compatible "Compatible Fully-Validating Node Software" but they don't implement the S2X rules and don't even implement segwit!
< sipa>
i find it amazing that all of bitcoin core's history, is less than 100 MB
< gmaxwell>
And in particular, the people that the users of bitcoin are generally reseting a fair amount of trust to create and maintain the software the network is using, for the most part (or completely though we can't be sure) don't agree with the narative they're being sold.
< BlueMatt>
I mean can you seriously claim that almost the entirety of your rather short blog posts is disagreed with by almost any contributor to bitcoin core
< gmaxwell>
(also, "here is a really interesting view you should read and consider" is not morally equivilent to /pretending to be us/ or faking that s2x is just an uncontroversial and low risk bitcoin upgrade...)
< bitcoin-git>
[bitcoin] luke-jr opened pull request #11082: Add new bitcoin_rw.conf file that is used for settings modified by this software itself (master...rwconf) https://github.com/bitcoin/bitcoin/pull/11082
< instagibbs>
i think there's the two issues: 1) claiming to be core 2) claiming to offer bitcoin upgrades
< BlueMatt>
morcos: see greg's comments - people are claiming to "be" bitcoin core saying otherwise
< praxeology>
Maybe... the people who would be duped into downloading/installing btc1... haven't even/don't/won't install Bitcoin Core in the first place. So that set of people is probably pretty small, like maybe 0 people?
< jimpo>
cfields: Is there a reason that the "send rejects" part of SendRejectsAndCheckBanned should be called at the end of ProcessMessages as introduced in https://github.com/bitcoin/bitcoin/pull/9720?
< praxeology>
I disagree with luke's suggested rename to "2X". Ideally we could get the whole bitcoin/altcoin community to change the name, but its too late now, should just stick w/ what everyone is familiar with
< jnewbery>
to be clear, I'm not disputing the quality of morcos's posts, and I personally agree with them, but I find the idea of 'Bitcoin Core thinks <x>' objectionable
< BlueMatt>
can also just quote tweet and say like "Some thoughts on 2x, from a major contributor to Bitcoin Core"
< luke-jr>
"Of the 25 Bitcoin Core developers who have stated a position on 2X, all of them are opposed."
< jnewbery>
Murch - I agree. Have misgivings about "Bitcoin Core" endorsing a personal opinion
< Murch>
gmaxwell: That needs a response from the actual Bitcoin Core twitter account to condemn it as false flag.
<@wumpus>
luke-jr: yes, something like https://planet.freedesktop.org/ would be nice, though on the other hand for bitcoin that would result in endless political discussions about who to include and who not
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #11081: Add length check for CExtKey deserialization (master...2017/08/fix_cextkey) https://github.com/bitcoin/bitcoin/pull/11081
< Murch>
BlueMatt: Yeah, Replay Protection might be a bit over the head for the general audience. It should be mentioned though that it is unrelated to and _not supported by Bitcoin Core_.
< BlueMatt>
yea, that seems reasonable, just "hey, this is unrelated to Bitcoin Core or Bitcoin, really, they are playing a very, very risky game and most folks dont condone this"
< gmaxwell>
praxeology: it's run by the bitcoin.org people. They're generally reasonable folks.
< Chris_St1>
maybe bitcoin.org people can throw up a warning about people promoting consensus imcompatible implementations
< praxeology>
How close is bitcoin.org w/ the core dev team? Who runs it?
< gmaxwell>
We can also talk to the bitcoin.org folks in general.
< BlueMatt>
ok, so objections to luke-jr's proposal to put something on bitcoincore.org that simply points out that s2x is unrelated to segwit, and a fork of bitcoin, not a "harmless upgrade"?
< gmaxwell>
E.g. seen it on reddit and hacker news; and our community links people to https://en.bitcoin.it/wiki/Segwit_support but then gets trolls responding that its "fake" and "censored by theymos"
< gmaxwell>
spreading misinformation about S2X describing it as a harmless "upgrade" to bitcoin, misstating that things like
< BlueMatt>
<gribble> https://github.com/bitcoin/bitcoin/issues/10267 | INew -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11071: Use static_assert(…, …) instead of assert(…) where appropriate (master...static_assert) https://github.com/bitcoin/bitcoin/pull/11071
< gribble>
https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10923 | Use -Wthread-safety-analysis if available (+ -Werror=[…] if --enable-werror) by practicalswift · Pull Request #10923 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10923 | Use -Wthread-safety-analysis if available (+ -Werror=[…] if --enable-werror) by practicalswift · Pull Request #10923 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jnewbery opened pull request #11078: [tests] Make p2p-leaktests.py more robust (master...p2p_leaktests_robust) https://github.com/bitcoin/bitcoin/pull/11078
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11066: Document the preference of nullptr over NULL or (void*)0 (master...document-nullptr-preference) https://github.com/bitcoin/bitcoin/pull/11066
< karelb>
question about bitcoin 0.15.0 ... does estimatesmartfee return the same fees as estimatefee?
< karelb>
Hello, nobody replied at #bitcoin, I hope I am not interrupting a meeting again, I will ask here
< webuser232>
wumpus, re your reply over https://github.com/bitcoin/bitcoin/issues/11064 , posting an idea publicly like that usually saves you all the work you listed in case you missed something obvious to begin with
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645
< bitcoin-git>
bitcoin/master c484ec6 MarcoFalke: Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant...
< bitcoin-git>
bitcoin/master 36d326e practicalswift: Use nullptr instead of zero (0) as the null pointer constant
< bitcoin-git>
[bitcoin] BitonicEelis opened pull request #11074: Assert that CWallet::SyncMetaData finds oldest transaction. (master...syncassert) https://github.com/bitcoin/bitcoin/pull/11074
< bitcoin-git>
[bitcoin] BitonicEelis opened pull request #11073: Remove dead store in ecdsa_signature_parse_der_lax. (master...deadstore) https://github.com/bitcoin/bitcoin/pull/11073
< bitcoin-git>
[bitcoin] kallewoof opened pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (master...mempool-alreadythere) https://github.com/bitcoin/bitcoin/pull/11062
< bitcoin-git>
[bitcoin] jimpo opened pull request #11058: Comments: More comments on functions/globals in standard.h. (master...standard-comments) https://github.com/bitcoin/bitcoin/pull/11058
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10957: Avoid returning a BIP9Stats object with uninitialized values (master...bip9status) https://github.com/bitcoin/bitcoin/pull/10957
< bitcoin-git>
bitcoin/master a46a671 MarcoFalke: Merge #10957: Avoid returning a BIP9Stats object with uninitialized values...
< bitcoin-git>
bitcoin/master 3eb53b8 practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #9964: Add const to methods that do not modify the object for which it is called (master...const) https://github.com/bitcoin/bitcoin/pull/9964
< bitcoin-git>
bitcoin/master b6a4891 MarcoFalke: Merge #9964: Add const to methods that do not modify the object for which it is called...
< bitcoin-git>
bitcoin/master 6e8c48d practicalswift: Add const to methods that do not modify the object for which it is called
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11011: [Trivial] Add a comment on the use of prevector in script. (master...201708-prevector-comment) https://github.com/bitcoin/bitcoin/pull/11011
< bitcoin-git>
bitcoin/master 7db65c3 MarcoFalke: Merge #11011: [Trivial] Add a comment on the use of prevector in script....
< bitcoin-git>
bitcoin/master 08f71c2 Gregory Maxwell: [Trivial] Add a comment on the use of prevector in script.
< gribble>
https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] jnewbery opened pull request #11055: getreceivedbyaddress should return error if called with address not owned by the wallet (master...getreceivedbyaddress_error) https://github.com/bitcoin/bitcoin/pull/11055
< bitcoin-git>
[bitcoin] laanwj opened pull request #11053: refactor: Make all #includes relative to project root (master...2017_08_includes_absolute) https://github.com/bitcoin/bitcoin/pull/11053
< bitcoin-git>
[bitcoin] laanwj closed pull request #10752: Use quoted form when including primitives/transaction.h and wallet/wallet.h (master...transaction-h) https://github.com/bitcoin/bitcoin/pull/10752
< arowser>
Hi, if exists a place that can download the dbg file that split from the released bitcoin core ?
< dermoth>
the details are in comments, but basically I ensure each blockfile is loaded in OS cache before bitcoin-qt opens them while rescanning the whole blockchain
< dermoth>
Hey... I worked out a small speedup to initial blockchain load from bootstrap.dat (and likely rescan operations)... If you're interested it would be best implemented as a separate thread in the bitcoin node...
2017-08-14
< bitcoin-git>
[bitcoin] instagibbs opened pull request #11049: coincontrol can filter for segwit inputs, expose fundraw option (master...segwitfundraw) https://github.com/bitcoin/bitcoin/pull/11049