2017-04-19

< bitcoin-git> [bitcoin] laanwj closed pull request #9524: rpc: Don't FlushStateToDisk when pruneblockchain(0) (master...Mf1701-qaPruning) https://github.com/bitcoin/bitcoin/pull/9524
< gribble> https://github.com/bitcoin/bitcoin/issues/10143 | [net] Allow disconnectnode RPC to be called with node id by jnewbery · Pull Request #10143 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jimmysong opened pull request #10229: Tests: Add test for getdifficulty (master...test_getdifficulty) https://github.com/bitcoin/bitcoin/pull/10229

2017-04-18

< bitcoin-git> [bitcoin] theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< jtimon> btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
< gribble> https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< bitcoin-git> [bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
< bincap> dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
< bincap> luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
<@wumpus> alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
<@wumpus> general questions like that belong in#bitcoin
<@wumpus> yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
< bitcoin-git> [bitcoin] laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
<@wumpus> yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
< sipa> no offence, but this channel is about development of bitcoin core
< jonasschnelli> Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
< bitcoin-git> [bitcoin] kallewoof opened pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
< bitcoin-git> bitcoin/master 9111df9 MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
< bitcoin-git> bitcoin/master 637706d Jimmy Song: Tests: Put Extended tests first when they're included...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
< bitcoin-git> [bitcoin] laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
< bitcoin-git> bitcoin/master a86255b Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
< bitcoin-git> bitcoin/master 846dc17 Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
< bitcoin-git> bitcoin/master 3ddd227 Kalle Alm: [doc] Add blob about finding reviewers.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
< bitcoin-git> [bitcoin] laanwj closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> bitcoin/master 393160c Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
< bitcoin-git> bitcoin/master 75a08e7 Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
< bitcoin-git> bitcoin/master 9141622 Kalle Alm: [rpc] Add abortrescan command to RPC interface.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
< NicolasDorier> Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
< NicolasDorier> will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
< gribble> https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
< NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
< midnightmagic> sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
< bitcoin-git> [bitcoin] jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
< bitcoin-git> [bitcoin] jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223

2017-04-17

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10197: [tests] Functional test warnings (master...functional_test_warnings) https://github.com/bitcoin/bitcoin/pull/10197
< bitcoin-git> bitcoin/master d86bb07 MarcoFalke: Merge #10197: [tests] Functional test warnings...
< bitcoin-git> bitcoin/master 08e51c1 John Newbery: [tests] Remove cache directory by default when running test_runner
< bitcoin-git> bitcoin/master c85b080 John Newbery: [test] add warnings to test_runner
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/50a1cc0f0aef...d86bb075bf6d
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207
< bitcoin-git> bitcoin/master 50a1cc0 MarcoFalke: Merge #10207: Clarify importprivkey help text ... example of blank label without rescan...
< bitcoin-git> bitcoin/master c9e31c3 Warren Togami: Clarify importprivkey help text with example of blank label without rescan...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ce733747e16...50a1cc0f0aef
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
< bitcoin-git> bitcoin/master 6ce7337 MarcoFalke: Merge #10222: [tests] test_runner - check unicode...
< bitcoin-git> bitcoin/master a97ed80 John Newbery: [tests] test_runner - check unicode
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2584925077f9...6ce733747e16
< bitcoin-git> [bitcoin] jnewbery opened pull request #10222: [tests] test_runner - check unicode (master...test_runner_check_unicode) https://github.com/bitcoin/bitcoin/pull/10222
< morcos> I'm happy enough to just exclude in all my bitcoin.conf files, but just want to see if everyone else is ok with the leveldb log spam... it prints a lot of useless messages right at startup (where everythign else you care about is printed)
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
<@wumpus> SopaXorzTaker: good sleuthing, but no, you don't have to be afraid I run random scripts from the internet on anything important, let alone bitcoin-related ones
< bitcoin-git> [bitcoin] laanwj closed pull request #10178: Remove CValidationInterface::UpdatedTransaction (master...2017-01-wallet-cache-inmempool-2) https://github.com/bitcoin/bitcoin/pull/10178
< bitcoin-git> bitcoin/master 2584925 Wladimir J. van der Laan: Merge #10178: Remove CValidationInterface::UpdatedTransaction...
< bitcoin-git> bitcoin/master 9fececb Matt Corallo: Remove CValidationInterface::UpdatedTransaction...
< bitcoin-git> bitcoin/master d89f8ad Matt Corallo: Make DisconnectBlock and ConnectBlock static in validation.cpp
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a077a90da88f...2584925077f9
< bitcoin-git> [bitcoin] sipa closed pull request #10215: Check interruptNet during dnsseed lookups (master...2017-04-dnsseed-break) https://github.com/bitcoin/bitcoin/pull/10215
< bitcoin-git> bitcoin/master a077a90 Pieter Wuille: Merge #10215: Check interruptNet during dnsseed lookups...
< bitcoin-git> bitcoin/master b2c9254 Matt Corallo: Check interruptNet during dnsseed lookups
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5e9e428a919...a077a90da88f
< bitcoin-git> [bitcoin] sipa closed pull request #9693: Prevent integer overflow in ReadVarInt. (master...varint_maxsize) https://github.com/bitcoin/bitcoin/pull/9693
< bitcoin-git> bitcoin/master c5e9e42 Pieter Wuille: Merge #9693: Prevent integer overflow in ReadVarInt....
< bitcoin-git> bitcoin/master 45f0961 Gregory Maxwell: Prevent integer overflow in ReadVarInt....
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f4db00f9a548...c5e9e428a919
< SopaXorzTaker> wumpus, sipa, the large bitcoin collider client script is untrustworthy
< bitcoin-git> [bitcoin] laanwj opened pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
< bitcoin-git> [bitcoin] jimmysong opened pull request #10219: Tests: Order Python Tests By Duration (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219

2017-04-16

< sipa> this is not a support channel; ask in #bitcoin or on stack exchange
< __0> got this issue https://github.com/bitcoin/bitcoin/issues/7970 what to do? apt-get install libdb-dev already did
< MarcoFalke> github removed all pulls from our leveldb repo after the transition. Maybe send them a follow up sipa? E.g. https://github.com/bitcoin-core/leveldb/issues/17
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #8319: [qa] wallet*.py: Check for salvagewallet regressions (master...Mf1607-qaSalv) https://github.com/bitcoin/bitcoin/pull/8319
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10078: [qa] Fundraw: Use named args to limit scope of names (master...Mf1703-qaNamedShadow) https://github.com/bitcoin/bitcoin/pull/10078

2017-04-15

< jonasschnelli> <*highlight>[22:09:48] <BlueMatt:#bitcoin-core-dev> jonasschnelli: hey
<@wumpus> trying to compile bitcoin core with c++17 clang runs into some curious things: https://github.com/laanwj/bitcoin/commit/7a05ed0835fa962064a9c5198ab568109ab02d85 explicit bool coercion required at some places, as well as ?: needing to be exactly the right type *and* constness
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10216: [Wallet] FundRawTransaction can accept pre-set inputs whose parent is not yet broadcasted (master...fundrawtransaction2) https://github.com/bitcoin/bitcoin/pull/10216
< bitdroid> does bitcoin core have a android app?

2017-04-14

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10215: Check interruptNet during dnsseed lookups (master...2017-04-dnsseed-break) https://github.com/bitcoin/bitcoin/pull/10215
< bitcoin-git> [bitcoin] KibbledJiveElkZoo closed pull request #10183: [RPC] Don't default rescan on private/public key imports. (master...rpc_rescan_fixes) https://github.com/bitcoin/bitcoin/pull/10183
< bitcoin-git> [bitcoin] rawodb closed pull request #10214: Abortable rescans & rpc abortrescan command (master...pr/rpc_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10214
< bitcoin-git> [bitcoin] rawodb opened pull request #10214: Abortable rescans & rpc abortrescan command (master...pr/rpc_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10214
< bitcoin-git> [bitcoin] practicalswift opened pull request #10212: Make sure parameter names in .cpp and .h files are in sync (master...make-doxygen-happy-by-using-consistent-parameter-names) https://github.com/bitcoin/bitcoin/pull/10212
< bitcoin-git> [bitcoin] kallewoof opened pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
<@wumpus> the current form has quite some risks while it activates, which wouldn't really be our prefered way of working, see the mailing list for example gmaxwell's writeup here: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-April/014152.html
< bitcoin-git> bitcoin/0.14 33fadc2 Wladimir J. van der Laan: doc: Update release notes pre-rc2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/33fadc20bae4828788d6d82c582c457adc6941e1
< bitcoin-git> bitcoin/0.14 348a717 Wladimir J. van der Laan: qt: translations update pre-rc2
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/348a71701db4cb29a762c7d60aba34380ee1d403
< bitcoin-git> [bitcoin] laanwj closed pull request #10205: [0.14] net: define NodeId as an int64_t (0.14...10176-backport) https://github.com/bitcoin/bitcoin/pull/10205
< bitcoin-git> bitcoin/0.14 30fa231 Cory Fields: net: define NodeId as an int64_t...
< bitcoin-git> bitcoin/0.14 3c79602 John Newbery: [rpc] rename disconnectnode argument...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/06909df179e7...30fa231011a6
< bitcoin-git> [bitcoin] laanwj closed pull request #10204: [rpc] rename disconnectnode argument (master...rename_disconnect_node_argument) https://github.com/bitcoin/bitcoin/pull/10204
< bitcoin-git> bitcoin/master f4db00f Wladimir J. van der Laan: Merge #10204: [rpc] rename disconnectnode argument...
< bitcoin-git> bitcoin/master 883154c John Newbery: [rpc] rename disconnectnode argument
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b7365f0545b1...f4db00f9a548
< jonasschnelli> Hmm.... I don't really understand why getaddrinfo on OSX does cache forever... https://github.com/bitcoin/bitcoin/blob/1a5aaabb8a3d67a039ad120bb5d8d418467cac4e/src/netbase.cpp#L104
< bitcoin-git> [bitcoin] jonasschnelli reopened pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> [bitcoin] kallewoof opened pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> [bitcoin] kallewoof closed pull request #9872: [qa] Multi-chain support in test framework (master...qa-multi-chain-support) https://github.com/bitcoin/bitcoin/pull/9872
< kallewoof> I'm not sure. I talked to wumpus about it. See e.g. https://github.com/bitcoin/bitcoin/pull/9387#issuecomment-268213151
< kallewoof> cfields: This is the part, I was a bit off on the struct names, but: https://github.com/bitcoin/bitcoin/pull/9387/files#diff-321303fddcf725df060981d626a05df9R234
< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9517 | [refactor] Switched httpserver.cpp to use RAII wrapped libevents. by kallewoof · Pull Request #9517 · bitcoin/bitcoin · GitHub
< gmaxwell> /home/gmaxwell/src/bitcoin/src/support/events.h:37: multiple definition of `obtain_event(event_base*, int, short, void (*)(int, short, void*), void*)'
< gmaxwell> test/test_test_bitcoin-raii_event_tests.o:/home/gmaxwell/src/bitcoin/src/./support/events.h:30: first defined here
< gribble> https://github.com/bitcoin/bitcoin/issues/9517 | [refactor] Switched httpserver.cpp to use RAII wrapped libevents. by kallewoof · Pull Request #9517 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] wtogami opened pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207

2017-04-13

< bitcoin-git> [bitcoin] dramaticbulgarian closed pull request #10206: Chainparams: In ReceivedBlockTransactions() (master...chainparams) https://github.com/bitcoin/bitcoin/pull/10206
< bitcoin-git> [bitcoin] dramaticbulgarian opened pull request #10206: Chainparams: In ReceivedBlockTransactions() (master...chainparams) https://github.com/bitcoin/bitcoin/pull/10206
< bitcoin-git> [bitcoin] theuni opened pull request #10205: net: define NodeId as an int64_t (0.14...10176-backport) https://github.com/bitcoin/bitcoin/pull/10205
< gribble> https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
< BlueMatt> wumpus: i think you can remove the merged PRs from https://github.com/bitcoin/bitcoin/projects/8
< petertodd> spudowiar: I dropped out of a physics degree for bitcoin (though I was doing it part time while working at a startup...)
< gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
<@wumpus> morcos: BlueMatt: ok added them to the project https://github.com/bitcoin/bitcoin/projects/8
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9792 | FastRandomContext improvements and switch to ChaCha20 by sipa · Pull Request #9792 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< ryanofsky> and qt seemed like it might be a less controversial place to start since we already have separate bitcoind and bitcoin-qt executables
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP) by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP) by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gmaxwell> /mode #bitcoin-dev +b *!*@178.62.68.75
< gribble> https://github.com/bitcoin/bitcoin/issues/10143 | [net] Allow disconnectnode RPC to be called with node id by jnewbery · Pull Request #10143 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10204: [rpc] rename disconnectnode argument (master...rename_disconnect_node_argument) https://github.com/bitcoin/bitcoin/pull/10204
< gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
< BlueMatt> and bitcoin core is a big part of that
<@wumpus> #link Release schedule for 0.15.0 https://github.com/bitcoin/bitcoin/issues/9961
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< petertodd> wumpus: granted, if you ever compile bitcoin you're running stuff within the repo anyway
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< spudowiar> 2017-04-11 21:37:35 -- Mode #bitcoin [+b *!*@178.62.68.75] by gmaxwell
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure blue
< cfields_> sipa: for leveldb merge, whenever it's needed: https://github.com/theuni/bitcoin/commit/2cb7dda13884e44105f33c16e7e2c1a9aed46295
< bitcoin-git> [bitcoin] sipa closed pull request #9480: De-duplicate SignatureCacheHasher (master...refactor-signaturecachehasher-visibility) https://github.com/bitcoin/bitcoin/pull/9480
< bitcoin-git> bitcoin/master b7365f0 Pieter Wuille: Merge #9480: De-duplicate SignatureCacheHasher...
< bitcoin-git> bitcoin/master f9c8807 Jeremy Rubin: Deduplicate SignatureCacheHasher...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eab00d96dfe9...b7365f0545b1
< gribble> https://github.com/bitcoin/bitcoin/issues/9743 | Fix several potential issues found by sanitizers by sipa · Pull Request #9743 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9480 | De-duplicate SignatureCacheHasher by JeremyRubin · Pull Request #9480 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #9665: Use cached [compact] blocks to respond to getdata messages (master...2017-02-processgetdata-cache) https://github.com/bitcoin/bitcoin/pull/9665
< bitcoin-git> bitcoin/master b49ad44 Matt Corallo: Add comment about cs_most_recent_block coverage
< bitcoin-git> bitcoin/master c47f5b7 Matt Corallo: Cache witness-enabled state with recent-compact-block-cache
< bitcoin-git> bitcoin/master efc135f Matt Corallo: Use cached [compact] blocks to respond to getdata messages
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf8a8b1028d6...eab00d96dfe9
< gribble> https://github.com/bitcoin/bitcoin/issues/9665 | Use cached [compact] blocks to respond to getdata messages by TheBlueMatt · Pull Request #9665 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #10176: net: gracefully handle NodeId wrapping (master...nodeid-no-wrap) https://github.com/bitcoin/bitcoin/pull/10176
< bitcoin-git> bitcoin/master cf8a8b1 Wladimir J. van der Laan: Merge #10176: net: gracefully handle NodeId wrapping...
< bitcoin-git> bitcoin/master c851be4 Cory Fields: net: define NodeId as an int64_t...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/70f6f56e9dde...cf8a8b1028d6
< sipa> wumpus: it's annoying to create PRs against the bitcoin core leveldb repository
< bitcoin-git> [bitcoin] laanwj closed pull request #7148: [NO MERGE] Travis: Run nightly test suite (master...travis/nightly) https://github.com/bitcoin/bitcoin/pull/7148
< gribble> https://github.com/bitcoin/bitcoin/issues/7289 | [WIP] Make arguments reconfigurable at runtime via RPC by luke-jr · Pull Request #7289 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10202: [Wallet] FundRawTransaction can fund a transaction with preset inputs found in the CoinView (master...fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/10202
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #10068: [Wallet] FundRawTransaction accepts preset non-wallet inputs (master...nonwalletinputs) https://github.com/bitcoin/bitcoin/pull/10068
< bitcoin-git> [bitcoin] mariodian opened pull request #10201: pass Consensus::Params& to ReceivedBlockTransactions() (master...consensusparams-receivedblocktransactions) https://github.com/bitcoin/bitcoin/pull/10201
< bitcoin-git> [bitcoin] laanwj closed pull request #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair (master...inputcoin) https://github.com/bitcoin/bitcoin/pull/10165
< bitcoin-git> bitcoin/master f597dcb NicolasDorier: [Wallet] Simplify code using CInputCoin
< bitcoin-git> bitcoin/master e78bc45 NicolasDorier: [Wallet] Decouple CInputCoin from CWalletTx
< bitcoin-git> bitcoin/master fd44ac1 NicolasDorier: [Wallet] Rename std::pair<const CWalletTx*, unsigned int> to CInputCoin
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9ff4f8ee601...70f6f56e9dde
< bitcoin-git> bitcoin/0.14 06909df Wladimir J. van der Laan: Merge #10185: [0.14] Mention dbcache memory changes in release notes...
< bitcoin-git> bitcoin/0.14 b7caa30 Suhas Daftuar: Mention dbcache memory changes in 0.14.1 release notes
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/55f641ca194b...06909df179e7
< bitcoin-git> [bitcoin] laanwj closed pull request #10186: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number (master...remove_SYNC_TRANSACTION_NOT_IN_BLOCK_magic_number) https://github.com/bitcoin/bitcoin/pull/10186
< bitcoin-git> bitcoin/master c9ff4f8 Wladimir J. van der Laan: Merge #10186: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number...
< bitcoin-git> bitcoin/master d0cd0bd John Newbery: Make CWallet::SyncTransactions() interface friendlier
< bitcoin-git> bitcoin/master 714e4ad John Newbery: AddToWalletIfInvolvingMe should test pIndex, not posInBlock
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/de01da7cad32...c9ff4f8ee601
< gribble> https://github.com/bitcoin/bitcoin/issues/10185 | [0.14] Mention dbcache memory changes in release notes by sdaftuar · Pull Request #10185 · bitcoin/bitcoin · GitHub
< sdaftuar> gmaxwell: is this what you have in mind? https://github.com/sdaftuar/bitcoin/tree/2017-04-braindead-simple-mining
< jtimon> sipa: I'm getting some errors related to prevector templating, perhaps you can help with https://github.com/bitcoin/bitcoin/pull/10193#issuecomment-293742166

2017-04-12

< berndj> gmaxwell, i think i started this line of thinking in #bitcoin, my version was only slightly different, where the coins become redeemable by anyone (i.e. probably a miner) if SW should fail to be active
< jtimon> yep, look at https://github.com/bitcoin/bitcoin/pull/10193 for an example (needs some squashing after completing it)
< cfields> BlueMatt: I don't see what's so terrible about automating this checking: https://github.com/bitcoin/bitcoin/pull/9902/commits/bac5c9cf643e9333479ac667426d0b70f8f3aa7f
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10200: Mining: Skip recent transactions if fee difference is small (master...2017-04-dont-mine-recent-tx) https://github.com/bitcoin/bitcoin/pull/10200
< gribble> https://github.com/bitcoin/bitcoin/issues/9480 | De-duplicate SignatureCacheHasher by JeremyRubin · Pull Request #9480 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] bulldozer00 closed pull request #10194: Remove unecessary friend keyword from the class definition (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10194
< bitcoin-git> [bitcoin] laanwj closed pull request #10177: Changed "Send" button default status from true to false (master...ui_fixes) https://github.com/bitcoin/bitcoin/pull/10177
< bitcoin-git> bitcoin/master de01da7 Wladimir J. van der Laan: Merge #10177: Changed "Send" button default status from true to false...
< bitcoin-git> bitcoin/master 8c3e6c6 KibbledJiveElkZoo: Changed "Send" button default status from true to false...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/350b22497c7c...de01da7cad32
< bitcoin-git> [bitcoin] laanwj closed pull request #10150: [rpc] Add logging rpc (master...logging_rpc) https://github.com/bitcoin/bitcoin/pull/10150
< bitcoin-git> bitcoin/master 7fd50c3 John Newbery: allow libevent logging to be updated during runtime
< bitcoin-git> bitcoin/master 5255aca John Newbery: [rpc] Add logging RPC...
< bitcoin-git> bitcoin/master 4d9950d John Newbery: Set BCLog::LIBEVENT correctly for old libevent versions.
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b44adf92342a...350b22497c7c
< Chris_Stewart_5> arubi: Look at this function if you haven't seen it yet: https://github.com/bitcoin/bitcoin/blob/b83264d9c7a8ddb79f64bd9540caddc8632ef31f/src/script/interpreter.cpp#L186
< gribble> https://github.com/bitcoin/bitcoin/issues/10199 | Better fee estimates by morcos · Pull Request #10199 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] morcos opened pull request #10199: Better fee estimates (master...smarterfee) https://github.com/bitcoin/bitcoin/pull/10199
< Chris_Stewart_5> arubi: Like you mentioned you can tinker with the verify flags: https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.h#L52
< bitcoin-git> [bitcoin] jnewbery closed pull request #10198: [tests] Remove is_network_split from functional test framework (master...remove_is_network_split) https://github.com/bitcoin/bitcoin/pull/10198
< bitcoin-git> [bitcoin] jnewbery opened pull request #10198: [tests] Remove is_network_split from functional test framework (master...remove_is_network_split) https://github.com/bitcoin/bitcoin/pull/10198
< bitcoin-git> [bitcoin] jnewbery opened pull request #10197: Functional test warnings (master...functional_test_warnings) https://github.com/bitcoin/bitcoin/pull/10197
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10196: Bugfix: PrioritiseTransaction updates the mempool tx counter (master...2017-04-prioritise-transaction) https://github.com/bitcoin/bitcoin/pull/10196
< bitcoin-git> [bitcoin] jnewbery reopened pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
< bitcoin-git> [bitcoin] sipa opened pull request #10195: Switch chainstate db and cache to per-txout model (master...pertxoutcache) https://github.com/bitcoin/bitcoin/pull/10195
< bitcoin-git> [bitcoin] bulldozer00 opened pull request #10194: Remove unecessary friend keyword from the class definition (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10194
< gribble> https://github.com/bitcoin/bitcoin/issues/8694 | Basic multiwallet support by luke-jr · Pull Request #8694 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9694 | Importmulti cannot import bare private keys · Issue #9694 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon opened pull request #10193: scripted-diff: sed -i 's/BOOST_FOREACH(\(.*\),/for (\1 :/' ./src/qt/*.cpp (master...b14-10189-scripted-qt-foreach) https://github.com/bitcoin/bitcoin/pull/10193
< gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub

2017-04-11

< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187
< bitcoin-git> bitcoin/master b44adf9 MarcoFalke: Merge #10187: tests: Fix test_runner return value in case of skipped test...
< bitcoin-git> bitcoin/master e96462f Wladimir J. van der Laan: tests: Fix test_runner return value in case of skipped test...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67023e9004ba...b44adf92342a
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10125: Exit bitcoind immediately on shutdown instead of 200ms later (master...2017-03-faster-shutdown) https://github.com/bitcoin/bitcoin/pull/10125
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10192: Cache full script execution results in addition to signatures (master...2017-04-cache-scriptchecks) https://github.com/bitcoin/bitcoin/pull/10192
< bitcoin-git> [bitcoin] jnewbery closed pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
< bitcoin-git> [bitcoin] jnewbery opened pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #10190: Mining functional tests (including regression test for submitblock) (master...mining_functional_test) https://github.com/bitcoin/bitcoin/pull/10190
< bitcoin-git> [bitcoin] theuni opened pull request #10189: devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. (master...private-nodeid) https://github.com/bitcoin/bitcoin/pull/10189
< gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187
< wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/220971234 shows as a failed build, but the build, the unit tests and the functional tests seem to pass
< bitcoin-git> [bitcoin] jnewbery opened pull request #10186: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number (master...remove_SYNC_TRANSACTION_NOT_IN_BLOCK_magic_number) https://github.com/bitcoin/bitcoin/pull/10186
< gribble> https://github.com/bitcoin/bitcoin/issues/10182 | [scheduler] Switched CScheduler to C++11 threading primitives by tjps · Pull Request #10182 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #10185: [0.14] Mention dbcache memory changes in release notes (0.14...2017-04-relnotes-0.14.1) https://github.com/bitcoin/bitcoin/pull/10185
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10184: [Wallet] Worst case performance improvement on KeyPool filtering (master...hdinternalperf) https://github.com/bitcoin/bitcoin/pull/10184
< bitcoin-git> [bitcoin] KibbledJiveElkZoo opened pull request #10183: Don't default rescan on private/public key imports. (master...rpc_rescan_fixes) https://github.com/bitcoin/bitcoin/pull/10183
< jcorgan> as well as encryption using a key one can control, but with bitcoin traffic that seems less than essential
< bitcoin-git> [bitcoin] tjps opened pull request #10182: [scheduler] Switched CScheduler to C++11 threading primitives (master...tjps_scheduler) https://github.com/bitcoin/bitcoin/pull/10182
< bitcoin-git> [bitcoin] jtimon opened pull request #10181: Include cleanup (master...2017-04-10-includes) https://github.com/bitcoin/bitcoin/pull/10181

2017-04-10

< gribble> https://github.com/bitcoin/bitcoin/issues/10178 | Remove CValidationInterface::UpdatedTransaction by TheBlueMatt · Pull Request #10178 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) (master...inadvertantly-and-tempoarily) https://github.com/bitcoin/bitcoin/pull/10180
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10179: Give CValidationInterface Support for calling notifications on the CScheduler Thread (master...2017-01-wallet-cache-inmempool-3) https://github.com/bitcoin/bitcoin/pull/10179
< bitcoin-git> [bitcoin] laanwj closed pull request #9725: CValidationInterface Cleanups (master...2017-01-wallet-cache-inmempool-1) https://github.com/bitcoin/bitcoin/pull/9725
< bitcoin-git> bitcoin/master 29e6e23 Matt Corallo: Make ConnectTrace::blocksConnected private, hide behind accessors
< bitcoin-git> bitcoin/master 822000c Matt Corallo: Add pblock to connectTrace at the end of ConnectTip, not start...
< bitcoin-git> bitcoin/master f5e9a01 Matt Corallo: Include missing #include in zmqnotificationinterface.h
< bitcoin-git> [bitcoin] laanwj pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/e183ea2047b3...67023e9004ba
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10178: Remove CValidationInterface::UpdatedTransaction (master...2017-01-wallet-cache-inmempool-2) https://github.com/bitcoin/bitcoin/pull/10178
< gribble> https://github.com/bitcoin/bitcoin/issues/10176 | net: gracefully handle NodeId wrapping by theuni · Pull Request #10176 · bitcoin/bitcoin · GitHub
< jtimon> weird, for some reason travis didn't checked https://github.com/bitcoin/bitcoin/pull/9494 after last rebase
< bitcoin-git> [bitcoin] KibbledJiveElkZoo opened pull request #10177: Changed "Send" button default status from true to false (master...ui_fixes) https://github.com/bitcoin/bitcoin/pull/10177
< bitcoin-git> [bitcoin] theuni opened pull request #10176: net: gracefully handle NodeId wrapping (master...nodeid-no-wrap) https://github.com/bitcoin/bitcoin/pull/10176
< bitcoin-git> [bitcoin] mrwhythat closed pull request #10161: Support for Tor's Single Onion Service (master...tor-single-onion-service) https://github.com/bitcoin/bitcoin/pull/10161
< bitcoin-git> [bitcoin] laanwj closed pull request #10164: Wallet: reduce excess logic InMempool() (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10164
< bitcoin-git> bitcoin/master 3491476 Kewde: Wallet: reduce excess logic InMemPool()...
< bitcoin-git> bitcoin/master e183ea2 Wladimir J. van der Laan: Merge #10164: Wallet: reduce excess logic InMempool()...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e19586a8a955...e183ea2047b3
< bitcoin-git> [bitcoin] laanwj closed pull request #10135: [p2p] Send the correct error code in reject messages (master...correctrejectmessages) https://github.com/bitcoin/bitcoin/pull/10135
< bitcoin-git> bitcoin/master e19586a Wladimir J. van der Laan: Merge #10135: [p2p] Send the correct error code in reject messages...
< bitcoin-git> bitcoin/master 5d08c9c John Newbery: Send the correct error code in reject messages
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a27dbc55b1aa...e19586a8a955
< bitcoin-git> [bitcoin] laanwj closed pull request #9949: [bench] Avoid function call arguments which are pointers to uninitialized values (master...avoid-pointers-to-unitialized-values-in-function-calls) https://github.com/bitcoin/bitcoin/pull/9949
< bitcoin-git> bitcoin/master a27dbc5 Wladimir J. van der Laan: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values...
< bitcoin-git> bitcoin/master 218d915 practicalswift: [bench] Avoid function call arguments which are pointers to uninitialized values
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/51833a17347f...a27dbc55b1aa
< bitcoin-git> [bitcoin] laanwj closed pull request #10156: Fix for issues with startup and multiple monitors on windows. (master...masterMultiMonFix) https://github.com/bitcoin/bitcoin/pull/10156
< bitcoin-git> bitcoin/master 51833a1 Wladimir J. van der Laan: Merge #10156: Fix for issues with startup and multiple monitors on windows....
< bitcoin-git> bitcoin/master e9ff818 Allan Doensen: Fix for issues with startup and multiple monitors on windows.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fa4ae67a330...51833a17347f
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9890: Add a button to open the config file in a text editor (master...master) https://github.com/bitcoin/bitcoin/pull/9890
< bitcoin-git> bitcoin/master 1fa4ae6 Jonas Schnelli: Merge #9890: Add a button to open the config file in a text editor...
< bitcoin-git> bitcoin/master 9ab9e7d Eric Shaw Jr: Add a button to open the config file in a text editor
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64962aecb6be...1fa4ae67a330
< wumpus> midnightmagic: yes, the github info is being mirrored https://github.com/zw/bitcoin-gh-meta
< bitcoin-git> [bitcoin] practicalswift opened pull request #10175: Remove excess logic. (master...excess-logic) https://github.com/bitcoin/bitcoin/pull/10175
< bitcoin-git> [bitcoin] laanwj closed pull request #10166: Ignore Doxyfile generated from Doxyfile.in template. (master...20170407_gitignoreDoxyfile) https://github.com/bitcoin/bitcoin/pull/10166
< bitcoin-git> bitcoin/master 64962ae Wladimir J. van der Laan: Merge #10166: Ignore Doxyfile generated from Doxyfile.in template....
< bitcoin-git> bitcoin/master 9eaf718 Pavel Janík: Ignore Doxyfile generated from Doxyfile.in template.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/813eacf81b73...64962aecb6be
< bitcoin-git> [bitcoin] laanwj closed pull request #10167: [trivial] Fix typo ("improssible" → "impossible") (master...improssible) https://github.com/bitcoin/bitcoin/pull/10167