<bitcoin-git>
[bitcoin] furszy closed pull request #25881: wallet: remove unused DummySignTx and CKeyPool from GetReservedDestination (master...2022_wallet_clean_ckeypool) https://github.com/bitcoin/bitcoin/pull/25881
2023-12-02
<bitcoin-git>
[bitcoin] hebasto opened pull request #28989: test: Fix test by checking the actual exception instance (master...231202-system-test) https://github.com/bitcoin/bitcoin/pull/28989
<fanquake>
Note that we’ve now added support for more repos to this channel, including: btcdeb, bitcoin-maintainer-tools, qa-assets, packaging also the website and guix.sigs
<bitcoin-git>
[bitcoin] furszy opened pull request #28987: wallet: simplify and batch zap wallet txes process (master...2023_wallet_zaptx) https://github.com/bitcoin/bitcoin/pull/28987
2023-12-01
<bitcoin-git>
[bitcoin] murchandamus opened pull request #28985: Avoid changeless input sets when SFFO is active (master...2023-11-no-changeless-sffo) https://github.com/bitcoin/bitcoin/pull/28985
<bitcoin-git>
[bitcoin] achow101 merged pull request #28784: rpc: keep `.cookie` file if it was not generated (master...fix-cookie-delete) https://github.com/bitcoin/bitcoin/pull/28784
<bitcoin-git>
bitcoin/master 18bed14 Andrew Chow: Merge bitcoin/bitcoin#28784: rpc: keep `.cookie` file if it was not genera...
<bitcoin-git>
bitcoin/master 7cb9367 Roman Zeyde: rpc: keep .cookie if it was not generated
<bitcoin-git>
[bitcoin] achow101 merged pull request #28848: bugfix, Change up submitpackage results to return results for all transactions (master...2023-11-submitpackage-results) https://github.com/bitcoin/bitcoin/pull/28848
<bitcoin-git>
[bitcoin] hebasto opened pull request #28981: POC: Replace Boost.Process with cpp-subprocess (master...231130-replace-bp) https://github.com/bitcoin/bitcoin/pull/28981
<bitcoin-git>
[bitcoin] furszy opened pull request #28980: rpc: encryptwallet help, mention HD seed rotation and backup requirement (master...2023_rpc_wallet_encryptwallet) https://github.com/bitcoin/bitcoin/pull/28980
2023-11-30
<bitcoin-git>
[bitcoin] ishaanam opened pull request #28979: wallet, rpc: document and update `sendall` behavior around unconfirmed inputs (master...sendall_ancestor_aware_funding) https://github.com/bitcoin/bitcoin/pull/28979
<Murch[m]>
Re today’s meeting. Here’s a draft of a stupid simple coin selection algorithm that curbs unnecessary fee spending at high feerates while still usually being slightly consolidatory. Basically, a bound on the worst case: https://github.com/bitcoin/bitcoin/pull/28977
<BlueMatt[m]>
so if you're writing a bitcoin parsing library, and you have to parse transactions with no context, and sometimes without a known length, istm you should almost certainly rely on the segwit marker for 0-input transactions
<BlueMatt[m]>
sipa: in general, somehow I had recalled bitcoin core's "heuristic" here to be "try both, and if only one manages to read the full buffer successfully use that"
<bitcoin-git>
[bitcoin] BrandonOdiwuor opened pull request #28974: doc: explain what the wallet password does (master...wallet_passphrase) https://github.com/bitcoin/bitcoin/pull/28974
<Murch[m]>
We recently had another user submit disbelief when their Bitcoin Core wallet used over 500 inputs at a feerate of 75 sat/vB, when they had multiple UTXOs that could have funded the transaction by itself.
<Murch[m]>
Bitcoin Core wallet currently uses three different coin selection algorithms and generates up to ~12 candidate input sets from those in the first attempt, then picks the least wasteful among those per the waste heuristic.
<RubenSomsen>
A change we're considering in outpoint hashing (to make things simpler for hardware wallets) has an issue with forced collisions (worst case is address reuse), a possible fix is being discussed at https://github.com/bitcoin/bips/pull/1458#discussion_r1395934177
<gribble>
https://github.com/bitcoin/bitcoin/issues/25273 | wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction by achow101 · Pull Request #25273 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/28848 | bugfix, Change up submitpackage results to return results for all transactions by instagibbs · Pull Request #28848 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] maflcko opened pull request #28972: test: Add and use option for tx-version in MiniWallet methods (master...2311-test-mw-version-) https://github.com/bitcoin/bitcoin/pull/28972
<bitcoin-git>
[bitcoin] maflcko opened pull request #28969: fuzz: Avoid signed-integer-overflow in wallet_notifications fuzz target (master...2311-wn-sio-) https://github.com/bitcoin/bitcoin/pull/28969
<bitcoin-git>
[bitcoin] maflcko opened pull request #28968: fuzz: Fix nullptr deref in scriptpubkeyman (master...2311-fuzz-wallet-null-deref-) https://github.com/bitcoin/bitcoin/pull/28968
<bitcoin-git>
[bitcoin] fanquake opened pull request #28967: build: disable external-signer for Windows (master...disable_external_signer_win) https://github.com/bitcoin/bitcoin/pull/28967
<bitcoin-git>
[bitcoin] achow101 merged pull request #28554: bugfix: throw an error if an invalid parameter is passed to getnetworkhashps RPC (master...getnetworkhashps_height_validation) https://github.com/bitcoin/bitcoin/pull/28554
<bitcoin-git>
bitcoin/master 9ac114e Jameson Lopp: Throw error if invalid parameters passed to getnetworkhashps RPC endpoint
<bitcoin-git>
bitcoin/master 75462b3 Andrew Chow: Merge bitcoin/bitcoin#28554: bugfix: throw an error if an invalid paramete...
<bitcoin-git>
[bitcoin] ajtowns closed pull request #28686: refactor: Split per-peer parts of net module into new node/connection module (master...202310-nodenode) https://github.com/bitcoin/bitcoin/pull/28686
<bitcoin-git>
[bitcoin] fanquake merged pull request #28892: refactor: P2P transport without serialize version and type (master...2311-p2p-no-nVersion-) https://github.com/bitcoin/bitcoin/pull/28892
<bitcoin-git>
bitcoin/master 66669da MarcoFalke: Remove unused Make() overload in netmessagemaker.h
<bitcoin-git>
bitcoin/master fa9b5f4 MarcoFalke: refactor: NetMsg::Make() without nVersion
<bitcoin-git>
bitcoin/master fa0ed07 MarcoFalke: refactor: VectorWriter without nVersion
<bitcoin-git>
[bitcoin] theStack opened pull request #28951: fuzz: BIP324: damage ciphertext/aad in full byte range (master...202311-fuzz-bip324-damage_in_full_byte_range) https://github.com/bitcoin/bitcoin/pull/28951
2023-11-27
<bitcoin-git>
[bitcoin] instagibbs opened pull request #28950: RPC: Add maxfeerate and maxburnamount args to submitpackage (master...2023-11-submitpackage-max-fee-burn) https://github.com/bitcoin/bitcoin/pull/28950
<bitcoin-git>
[bitcoin] 23rd closed pull request #28947: [refactor] Moved simple math calculations from runtime to compile time. (master...patch-1-constexpr) https://github.com/bitcoin/bitcoin/pull/28947
<bitcoin-git>
[bitcoin] 23rd opened pull request #28947: [refactor] Moved simple math calculations from runtime to compile time. (master...patch-1-constexpr) https://github.com/bitcoin/bitcoin/pull/28947
<bitcoin-git>
[bitcoin] willcl-ark opened pull request #28946: init: don't delete PID file if it was not generated (master...fix-pidfile-delete) https://github.com/bitcoin/bitcoin/pull/28946
<bitcoin-git>
[bitcoin] martinus opened pull request #28945: sync: improve CCoinsViewCache ReallocateCache (master...2023-11-improve-ccoinsviewcache-reallocatecache) https://github.com/bitcoin/bitcoin/pull/28945
2023-11-26
<bitcoin-git>
[bitcoin] ishaanam opened pull request #28944: wallet, rpc: add anti-fee-sniping to `send` and `sendall` (master...sendall_anti_fee_sniping) https://github.com/bitcoin/bitcoin/pull/28944
<bitcoin-git>
[bitcoin] martinus opened pull request #28939: memusage: let PoolResource keep track of all allocated/deallocated memory (master...2023-11-more-accurate-pool-memory) https://github.com/bitcoin/bitcoin/pull/28939