< bitcoin-git>
[bitcoin] jharvell opened pull request #10997: Add option -stdinrpcpass to allow RPC password to be read from stdin (master...stdinrpcpass) https://github.com/bitcoin/bitcoin/pull/10997
< wumpus>
there is #bitcoin-dev that is more general
< wumpus>
bryyan: this channel is specifically for "bitcoin core", the c++ implementation, it has a very narrow scope on purpose to make sure the scrollback is relevant to the devs here
< gmaxwell>
the discussion is also an oppturnity to make it clear that Bitcoin developers don't support s2x... there are still some people going along spreading the idea that we'll somehow be going along with it.
2017-08-05
< arubi>
sipa, would be cool to have the .conf file per network. I do this now with shell functions and I'd love if it would be a part of the original bitcoin.conf. makes it much simpler to version control
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
< bitcoin-git>
[bitcoin] ajtowns opened pull request #10994: Add option to avoid warning on certain network upgrades (master...ignore-vbits) https://github.com/bitcoin/bitcoin/pull/10994
< gmaxwell>
Symptom is that bitcoin core rejects the private keys as invalid, which they are.
< bitcoin-git>
[bitcoin] laanwj closed pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git>
bitcoin/master 02f4c4a Wladimir J. van der Laan: Merge #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)...
< bitcoin-git>
bitcoin/master 11dd29b practicalswift: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request)...
< Chicago>
Well, you know once the base image is built; it could be a few weeks between Bitcoin release cycles; and so it has to build the dependency graph and do the package installations deterministically such that if you built an image last month with Trusty and I built an image today with Trusty, we both end up getting the exact same depgraph when we go to build everything.
< gmaxwell>
(not that bch is even the first altcoin to airdrop on bitcoin users, just the first with a highly funded marketing effort behind it)
< goatpig>
Bitcoin is unaffected though
< timothy>
gmaxwell: the real problem is that the broken forks (aka abc) uses the bitcoin-core data directory
< Chicago>
yeah, looks like he got to it 15 minutes ago on the Bitcoin subreddit
< Chicago>
venzen, I would presume the bitcoin.org (over HTTPS) hosted key is an order of magnitude more trustworthy than anything you randomly find by looking for a short string at the MIT PGP server.
< venzen>
Chicago: thanks, I'll post the link you provide to the r/bitcoin post. The OP seems to be confused and I figured wumpus should be aware of the post
< BlueMatt>
Cobra-Bitcoin: that is the intention, yes, I mailed you about this a while back :). I think the goal is to start pointing people to bitcoincore.org, but also sicne y'all wanted to keep mirroring on bitcoin.org (and cause no point telling people to go somewhere else if they're already used to bitcoin.org), they'd be in both places
< Cobra-Bitcoin>
So the release notes will point users to bitcoincore.org binaries?
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018 (master...2017-08-bad-service-bits) https://github.com/bitcoin/bitcoin/pull/10982
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell>
At the end we're doing them a favor, there are a lot more bitcoin nodes than random altcoin nodes, so these incorrect connections tend to cause them a lot more problems than us.
< gribble>
https://github.com/bitcoin/bitcoin/issues/8498 | Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... by jtimon · Pull Request #8498 · bitcoin/bitcoin · GitHub
< gmaxwell>
what? no. matt, doing that will ban Bitcoin Core users when someone on the same IP ran crapware.
< earlz>
yea, I'm not understanding where that gets created in the guide. Last time I setup gitian it was for Bitcoin 0.9 so not sure what all has changed since then
< BlueMatt>
Make Bitcoin Great Again: Bring back Pay-2-IP
< wumpus>
though if a wallet gets corrupted that's a good indication you should stop using that computer for bitcoin, now
< BlueMatt>
achow101: if you have a wallet with keys, and a default key that is invalid or missing, your wallet was clearly either corrupted or generated by something other than bitcoin core
< karelb>
ok we got abc node working, but it was some crazy solution of switching between various binaries and invalidating nodes; it did not crash (yet). But it seems that bitcore patches inside connectblock/disconnectblock are really not the way for the future; it will probably break again (both in abc and later in bitcoin core once you release the db changes)
< karelb>
I am actually talking about ABC, but the same issue crops up in bitcoin, plus it might be because ABC added some db logic from master
< karelb>
it must be because of the address index somehow, because on the same PC, bitcoin core without bitcore (sigh) patches runs fine
< bitcoin-git>
[bitcoin] laanwj closed pull request #10942: Eliminate fee overpaying edge case when subtracting fee from recipients (master...subtractfee) https://github.com/bitcoin/bitcoin/pull/10942
< bitcoin-git>
bitcoin/master 2e857bb Wladimir J. van der Laan: Merge #10942: Eliminate fee overpaying edge case when subtracting fee from recipients...
< bitcoin-git>
bitcoin/master 49d903e Alex Morcos: Eliminate fee overpaying edge case when subtracting fee from recipients
< gmaxwell>
karelb: the challenge there is that we have insanely optimized bitcoin core's sync process.. we avoid writing to leveldb at all costs, basically, and a significant fraction of UTXO never hit the database at all during normal sync because they're spent before the dbcache fills)
< karelb>
and normal bitcoin without bitcore patches doesn't do it, on the same HW
< Austindoggie>
Did it take a long time to reindex because you went back a version of bitcoin core?
< gmaxwell>
karelb: bitcoin core master changed the atomiticity requirements for the backend database, but a side effect of this is that it needs special replay logic to handle crash recovery. ABC has partially ported some of these changes. I am not sure, but I wouldn't be surprised if the address indexing would get corrupted until updated to have the right synchronization behavior.
< gmaxwell>
karelb: probably code based on Bitcoin Core master (including ABC) will not be reliably compatible with that address indexing stuff until it is changed.
< karelb>
actually one issue was sort-of ABC related, but it was because of a commit ported from master from bitcoin core, so it will be relevant anyway
< karelb>
(It is actually bitcoin-abc, I hope I won't be banned :D, but this issue popped up in bitcoin core too)
< karelb>
but right now we are reindexing bitcoin blockchain and it takes foreved
< gmaxwell>
Hi all, karelb is working on the trezor wallet, and they've been trying to use these patches to bitcoin that implement the bitcore address indexing stuff, but they're finding it really slow to the point where performance is problematic.
< praxeology>
does bitcoin still use windows registry?
< praxeology>
alright... well, its unfortunate I misdiagnosed the guy's issue. Thanks for the help. Hopefully he will come back and ask again on #bitcoin and one of sees him... for his sake... before he -reindex
< praxeology>
when bitcoin starts up, it only chooses one peer to ask for latest headers?
< praxeology>
ok. james0909 in #bitcoin said his error log said... "ERROR: invalid header received 2017-08-03 01:48:18 ProcessMessages(headers, 11422 bytes) FAILED peer=38"? and his tip was stuck at 478645.
< instagibbs>
james0909, #bitcoin please, someone can help there
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp (master...pr/wmove) https://github.com/bitcoin/bitcoin/pull/10976
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
< earlz>
Has anyone successfully cross-compiled Bitcoin Core for a raspberry pi? If so, is that process documented somewhere?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10972: Check return value of addr.GetKeyID(keyid) on custom change address change (master...GetKeyID-assertion) https://github.com/bitcoin/bitcoin/pull/10972
< bitcoin-git>
[bitcoin] theuni opened pull request #10971: build: fix missing warnings and sse42 in depends builds (master...fix-config-override) https://github.com/bitcoin/bitcoin/pull/10971
< bitcoin-git>
[bitcoin] laanwj closed pull request #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature (master...fix-addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/10788
< bitcoin-git>
bitcoin/master f66c596 Wladimir J. van der Laan: Merge #10788: [RPC] Fix addwitnessaddress by replacing ismine with producesignature...
< bitcoin-git>
bitcoin/master e222dc2 Andrew Chow: Replace ismine with producesignature check in witnessifier...
< bitcoin-git>
[bitcoin] promag opened pull request #10966: Add walletnotify functional test (master...2017-07-walletnotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10966
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10965: Use the noexcept specifier (C++11) instead of deprecated throw() (master...noexcept) https://github.com/bitcoin/bitcoin/pull/10965
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10964: Pass SendCoinsRecipient (208 bytes) and CConnman::Options (168 bytes) by reference (master...pass-big-parameters-by-reference) https://github.com/bitcoin/bitcoin/pull/10964
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10963: [bench] Restore format state of cout after printing with std::fixed/setprecision (master...restore-format-state-of-cout) https://github.com/bitcoin/bitcoin/pull/10963
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10961: Improve readability of DecodeBase58Check(...) (master...DecodeBase58Check-cleanup) https://github.com/bitcoin/bitcoin/pull/10961
< bitcoin-git>
bitcoin/master 42307c4 Wladimir J. van der Laan: qt: Periodic translations update...
< sipa>
for some data with well-defined serialization, Bitcoin Core has a REST interface
< bryyan>
yes, but why write bitcoin core in c++, a platform dependent language under many circumstances?
< bryyan>
if Bitcoin core is written in C++, why not support any kind of native interface directly (numbers as represented in memory going over tcp sockets as an RPC opposed to the serialised JSON RPC) ?
2017-07-30
< bitcoin-git>
[bitcoin] practicalswift opened pull request #10957: Do not return a BIP9Stats object with uninitialized values (master...bip9status) https://github.com/bitcoin/bitcoin/pull/10957
< bitcoin-git>
[bitcoin] jl2012 opened pull request #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck (master...combine_script_amount) https://github.com/bitcoin/bitcoin/pull/10953
< bitcoin-git>
[bitcoin] achow101 opened pull request #10952: [wallet] Remove vchDefaultKey and have better first run detection (master...remove-defaultkey) https://github.com/bitcoin/bitcoin/pull/10952
< gribble>
https://github.com/bitcoin/bitcoin/issues/10483 | scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL by practicalswift · Pull Request #10483 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #10947: [Wallet] Bare segwit scriptPubKey are not considered change by the wallet (master...importaddresssegwit) https://github.com/bitcoin/bitcoin/pull/10947
< wumpus>
this is from a person that has been translating bitcoin strings to Danish for a long time, I think it's a good indication that if he doesn't understand any of it, no other non-dev will
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #10945: Update defaultAssumeValid according to release-process.md. (master...201707-update-assumevalid) https://github.com/bitcoin/bitcoin/pull/10945
< bitcoin-git>
[bitcoin] morcos opened pull request #10942: Eliminate fee overpaying edge case when subtracting fee from recipients (master...subtractfee) https://github.com/bitcoin/bitcoin/pull/10942
< gribble>
https://github.com/bitcoin/bitcoin/issues/10924 | [RPC][Wallet][Segwit] Bug: Transaction sent to imported P2WSH does not appear in listtransaction. · Issue #10924 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/10924 | [RPC][Wallet][Segwit] Bug: Transaction sent to imported P2WSH does not appear in listtransaction. · Issue #10924 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj closed pull request #10892: Replace traditional for with ranged for in block and transaction primitives (master...20170721-rangedfor-primitives) https://github.com/bitcoin/bitcoin/pull/10892
< bitcoin-git>
bitcoin/master ba1bbb0 Wladimir J. van der Laan: Merge #10892: Replace traditional for with ranged for in block and transaction primitives...
< bitcoin-git>
bitcoin/master 72f0060 Dag Robole: Replace traditional for with ranged for in primitives