< bitcoin-git>
[bitcoin] NicolasDorier opened pull request #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair (master...inputcoin) https://github.com/bitcoin/bitcoin/pull/10165
< NicolasDorier>
I rebased https://github.com/bitcoin/bitcoin/pull/9728 I would be happy if Hardware wallets people can review. I ate my own dog food, and it seems this PR would really help helping bitcoin core wore seemlessly with hardware wallet and normal wallet without code modification.
< jcorgan>
patience is a virtue well-honed by participation in the bitcoin world :-)
< sturles>
An UASF would need support from a supermajority of exchanges and payment processors, and preferably as many merchants as possible dealing with bitcoin directly.
< abpa>
It's really for #bitcoin discussion not #bitcoin-core-dev
< jcorgan>
but perhaps this particular thing should stay in #bitcoin, sorry guys
< rgrant>
jcorgan: "FairHeader" has gained a following already in #bitcoin. "forward compatible" might stir up big blockers.
< jeremyrubin>
In the future, you don't want some regulator charging in requesting feature changes to disable a "covert" bitcoin feature
< jeremyrubin>
I think we need to be very careful with how we brand any changes happening. The reason we would like to ban it is *NOT* because it is covert. It is because it is incomaptible with Bitcoin's incentive systems (e.g., transaction selection to maximiuze fees) and it interferes with protocol development.
< jtimon>
let's move the discussion to #bitcoin ?
< wumpus>
well it's fine to mention it. I'm sure we want the BIP implemented in bitcoin core?
< wumpus>
if it shouldn't be used for the good of bitcoin, your BIP is exactly what they should adopt too
< wumpus>
saying they don't use it 'for the sake of bitcoin' can't be jived with saying it's a valuable optimization though
< gmaxwell>
Yes, the proposal is specifically designed to have minimal impact and only interfear with covert asicboost and only to the extent that it gums up protocol extensions (like segwit, utxo commitments, bloom filter commitments, etc.) But in their response they claim that I am trying to harm bitcoin by blocking a valuable optimization. :-/
< gmaxwell>
E.g. they helpfully confim their hardware implements asicboost, they loudly say they have the right to use it. They claim that they haven't used it on mainnet 'for the good of bitcoin' (how that jives with their claims that they'll make all the empty blocks they want because the protocol allows it, I dunno)
< jtimon>
althought it isn't mine, I think https://github.com/bitcoin/bitcoin/pull/7729 should be added to the list of things to review: that blocks the removal of accounts system
< bitcoin-git>
[bitcoin] mrwhythat opened pull request #10161: [WIP] Support for Tor's Single Onion Service (master...tor-single-onion-service) https://github.com/bitcoin/bitcoin/pull/10161
< cfields>
i think i've learned how to force a tag in the bitcoin repo, though. it seems to be a sure thing as soon as i leave for a few days :)
< gmaxwell>
The third option is that bitcoin will fail due to it, which I don't think we'll accept as a community. But eventually could be a fair while.
< Taek>
Though there are clear reasons for wanting such optimizations disabled, Bitcoin resists contentious changes, and I think the miners would be able to put up enough of a fight to prevent the change
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10159: [tests] color test results and sort alphabetically (master...sort_test_results) https://github.com/bitcoin/bitcoin/pull/10159
< bitcoin-git>
bitcoin/0.14 920acbc Wladimir J. van der Laan: doc: Update release notes for 0.14.1
< bitcoin-git>
[bitcoin] laanwj closed pull request #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails) (master...logging_initialization) https://github.com/bitcoin/bitcoin/pull/10151
< bitcoin-git>
bitcoin/master c7e73ea Wladimir J. van der Laan: Merge #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails)...
< bitcoin-git>
bitcoin/master cd7f394 John Newbery: initialize flag variable to 0 (and continue if GetLogCategory() fails)
< bitcoin-git>
[bitcoin] AllanDoensen opened pull request #10156: Fix for issues with startup and mutiple monitors on windows. (master...masterMultiMonFix) https://github.com/bitcoin/bitcoin/pull/10156
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #10146: Better error handling for submitblock (master...better_error_submitblock) https://github.com/bitcoin/bitcoin/pull/10146
2017-04-03
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #10145: Separate Contextual checks and handling & switch on enum in net_processing.cpp (master...netprocessing_enum_rebased) https://github.com/bitcoin/bitcoin/pull/10145
< bitcoin-git>
[bitcoin] theuni reopened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git>
[bitcoin] theuni closed pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143
< bitcoin-git>
[bitcoin] laanwj closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git>
bitcoin/master 471ed00 Wladimir J. van der Laan: Merge #10123: Allow debug logs to be excluded from specified component...
< bitcoin-git>
bitcoin/master 3bde556 John Newbery: Add -debugexclude option to switch off logging for specified components
< bitcoin-git>
[bitcoin] ryanofsky closed pull request #10117: Fix "make check" on systems with qt and libxcb but no active DISPLAY (master...pr/noqapp) https://github.com/bitcoin/bitcoin/pull/10117
< bitcoin-git>
[bitcoin] laanwj closed pull request #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings. (master...log_category_simplify) https://github.com/bitcoin/bitcoin/pull/9424
< bitcoin-git>
bitcoin/master 1a5aaab Wladimir J. van der Laan: Merge #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings....
< bitcoin-git>
bitcoin/master 6b3bb3d Gregory Maxwell: Change LogAcceptCategory to use uint32_t rather than sets of strings....
< bitcoin-git>
[bitcoin] jnewbery closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10135: Send the correct error code in reject messages (master...correctrejectmessages) https://github.com/bitcoin/bitcoin/pull/10135
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #10134: [qa] Fixes segwit block relay test after inv-direct-fetch was disabled (master...2017-03-fix-segwit-relay-test) https://github.com/bitcoin/bitcoin/pull/10134
< bitcoin-git>
[bitcoin] gmaxwell reopened pull request #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings. (master...log_category_simplify) https://github.com/bitcoin/bitcoin/pull/9424
< bitcoin-git>
[bitcoin] theuni opened pull request #10129: scheduler: fix sub-second precision with boost < 1.50 (master...fix-scheduler-millisecs) https://github.com/bitcoin/bitcoin/pull/10129
< gmaxwell>
Or we take a whole different approach to failure messages, .e.g. wrap bitcoin-qt in another program that when qt exists it can go through the logs and give you a useful error. (though this doesn't answer morcos' wallet flush, but really that should be in another process.)
< gribble>
https://github.com/bitcoin/bitcoin/issues/9424 | Change LogAcceptCategory to use uint32_t rather than sets of strings. by gmaxwell · Pull Request #9424 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #10127: [0.14 backport] Mining: Prevent slowdown in CreateNewBlock on large mempools (0.14...2017-03-backport-cnb-optimizations) https://github.com/bitcoin/bitcoin/pull/10127
< bitcoin-git>
[bitcoin] jnewbery closed pull request #9630: Add logging to GetAncestor if pindex->pprev == NULL (master...crashlogging) https://github.com/bitcoin/bitcoin/pull/9630
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10125: Exit bitcoind immediately on shutdown instead of 200ms later (master...2017-03-faster-shutdown) https://github.com/bitcoin/bitcoin/pull/10125
< bitcoin-git>
[bitcoin] jnewbery opened pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123
< bitcoin-git>
[bitcoin] laanwj opened pull request #10120: util: Work around (virtual) memory exhaustion on 32-bit w/ glibc (master...2017_03_address_space_exhaustion_workaround) https://github.com/bitcoin/bitcoin/pull/10120
< bitcoin-git>
[bitcoin] fanquake closed pull request #10089: Fix shadowing of 'what' as described in #10080. (master...fix-what-shadowing) https://github.com/bitcoin/bitcoin/pull/10089
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #10117: Fix "make check" on systems with qt and libxcb but no active DISPLAY (master...pr/noqapp) https://github.com/bitcoin/bitcoin/pull/10117
< bitcoin-git>
[bitcoin] roconnor-blockstream opened pull request #10116: Consensus: use IsWitnessEnabled in ContextualCheckBlock (master...ContextualCheckBlock-refector) https://github.com/bitcoin/bitcoin/pull/10116
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10115: Avoid reading the old hd master key during wallet encryption (master...2017-03-cleanup-sethdmasterkey) https://github.com/bitcoin/bitcoin/pull/10115